Thank you Phil for clearing this.
Thank you Prasanta for your review.
Thanks and regards,
Shashi
From: Philip Race
Sent: Sunday, February 24, 2019 4:43 AM
To: Shashidhara Veerabhadraiah
Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202
khan
Sent: Monday, February 18, 2019 5:39 PM
To: Shashidhara Veerabhadraiah ; Philip
Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi,
I think if the overhead can be fixed with a small change, we should
Hi Prasanta, I hope I have answered your questions satisfactorily. Please let
me know if you have any more questions.
Thanks and regards,
Shashi
From: Shashidhara Veerabhadraiah
Sent: Friday, February 15, 2019 12:37 PM
To: Prasanta Sadhukhan ; Philip Race
Cc: 2d-dev@openjdk.java.net
riday, February 15, 2019 12:28 PM
To: Shashidhara Veerabhadraiah ; Philip
Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi,
In this case, we know doCompare() is called from one location only [and also is
not a p
you agree with me.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, February 15, 2019 12:11 PM
To: Phil Race ; Shashidhara Veerabhadraiah
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi Shashi
Hi Phil, Here is the new Webrev fixing those comments:
http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.06/
Thanks and regards,
Shashi
From: Philip Race
Sent: Saturday, February 9, 2019 2:25 AM
To: Shashidhara Veerabhadraiah
Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Hi Phil, Here is the updated Webrev fixing those comments:
http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.05/
Thanks and regards,
Shashi
From: Phil Race
Sent: Thursday, January 31, 2019 4:36 AM
To: Shashidhara Veerabhadraiah
Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Hi Phil, I have updated with small code updates:
http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.04/
Thanks and regards,
Shashi
From: Shashidhara Veerabhadraiah
Sent: Monday, December 10, 2018 3:19 PM
To: Philip Race
Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: RE
Hi Phil, Please find the updated Webrev.
http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.03/
Thanks and regards,
Shashi
From: Philip Race
Sent: Friday, December 7, 2018 8:54 PM
To: Shashidhara Veerabhadraiah
Cc: Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: Re
null string
reference)? Handling the null on the caller isn't an easier option?
Thanks and regards,
Shashi
From: Phil Race
Sent: Thursday, December 6, 2018 2:35 AM
To: Shashidhara Veerabhadraiah ;
Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-82
4, 2018 11:42 AM
To: Shashidhara Veerabhadraiah ; Philip
Race ; Prasanta Sadhukhan
; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
Hi, Shashi.
> The big problem was that I was not able to reproduce this problem neither at
> my e
NPE
till now.
Thanks and regards,
Shashi
From: Phil Race
Sent: Wednesday, November 28, 2018 11:19 PM
To: Shashidhara Veerabhadraiah ;
Prasanta Sadhukhan ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
I am not
Sadhukhan ; Shashidhara
Veerabhadraiah ; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print tests after
JDK-8153732
[Removed swing-dev as this as nothing to do with swing].
You mention in the bug eval that you don't need a new test because this
is al
fix tries
to eliminate the possible NPE cases.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Monday, November 26, 2018 8:01 PM
To: Shashidhara Veerabhadraiah ;
swing-...@openjdk.java.net; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [12] JDK-8212202: NPE in the print
currentRemotePrinters is
null, then also you update prevRemotePrinters to currentRemotePrinters
which is the output of getRemotePrintersNames().
Regards
Prasanta
On 26-Nov-18 2:33 PM, Shashidhara Veerabhadraiah wrote:
Hi All, Please review a NPE fix for the below bug.
Bug: https://bugs.openjdk.java.net
Hi All, Please review a NPE fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212202
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8212202/webrev.00/
Function getRemotePrintersNames() may return null values and hence they need to
be handled from the caller of tha
My bad Prashanta. Here is the updated Webrev:
http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.07/
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 22, 2018 2:46 PM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.net>
S
Hi Prasanta, Here is the new webrev for that change:
http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.06/
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 22, 2018 2:00 PM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.
Thank you Prasanta for the review.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 22, 2018 1:42 PM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote
printer chan
Sent: Friday, June 22, 2018 10:41 AM
To: Shashidhara Veerabhadraiah ; Philip
Race ; 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [11] JDK-8153732: Windows remote
printer changes do not reflect in lookupPrintServices()
I guess
if (pollStr.equalsIgnoreCase("tru
27;Devices
and Printers' dialog. A network printer will have the property 'Device
description' set to 'Network printer connection'.
Thanks and regards,
Shashi
From: Phil Race
Sent: Friday, June 22, 2018 2:16 AM
To: Shashidhara Veerabhadraiah ; 2d-dev
<2d-d
Hi Phil, Here is the new Webrev for changes you suggested.
http://cr.openjdk.java.net/~sveerabhadra/8153732/webrev.03/
Thanks and regards,
Shashi
From: Phil Race
Sent: Friday, June 22, 2018 1:02 AM
To: Shashidhara Veerabhadraiah ; 2d-dev
<2d-dev@openjdk.java.net>
Subject: Re
net>; Shashidhara Veerabhadraiah
Subject: Fwd: Re: [11] JDK-8153732: Windows remote printer changes
do not reflect in lookupPrintServices()
The main concern I have is we now have a busy thread burning CPU ..
bad for laptops .. and if we add a delay we have less prompt notification
of a new local print
t 2, 2017 2:45 AM
To: Shashidhara Veerabhadraiah
Cc: awt-...@openjdk.java.net; 2d-dev@openjdk.java.net; Jim Graham
Subject: Re: [OpenJDK 2D-Dev] [10] JDK-8169044: The tray icon color is not green
Hi, Shashi.
As far as I understand the "width/height" in the IconCanvas is a size of the
TrayIc
om: Jim Graham
Sent: Tuesday, August 1, 2017 2:14 AM
To: Shashidhara Veerabhadraiah ;
awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] [10] JDK-8169044: The tray icon color is not green
Will the tray icon canvas always be on the default screen? I bel
Hi, Kindly review a fix for JDK-8169044 where the non hi dpi icon was picked
among the icon set of hi dpi and a non hi dpi icons for a hi dpi display screen.
Issue: The non hi dpi icon is red in color (and hi dpi icon is green in color)
and was getting picked up among the set for a hi dpi dis
Hi All, Anything more needs to be done with respect this? Can I push this?
Thanks and regards,
Shashi
From: Shashidhara Veerabhadraiah
Sent: Monday, July 17, 2017 11:28 AM
To: Philip Race ; 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for
javax
Hi Phil, Please see below for my responses:
New Webrev with fixes @
<http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev.07/>
Thanks and regards,
Shashi
From: Philip Race
Sent: Sunday, July 9, 2017 11:58 PM
To: Shashidhara Veerabhadraiah
Cc: Prasanta Sadhukhan ;
space between if and ( -- on lines 65 and 70.
You can make this change before pushing. No need to have a new webrev just for
this.
Regards,
Ajit
From: Shashidhara Veerabhadraiah
Sent: Friday, July 14, 2017 10:01 AM
To: HYPERLINK "mailto:2d-dev@openjdk.java.net"2d-dev@openjdk.java.n
Sure Ajit. Will take care of that before pushing the change.
Thanks and regards,
Shashi
From: Ajit Ghaisas
Sent: Friday, July 14, 2017 5:32 PM
To: Shashidhara Veerabhadraiah ;
2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for
javax/imageio
Hi All, Anything more comments on this? Can I close this now?
Thanks and regards,
Shashi
From: Jayathirth D V
Sent: Wednesday, July 12, 2017 3:14 PM
To: Shashidhara Veerabhadraiah
Cc: 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for
javax/imageio
: Wednesday, July 12, 2017 11:53 AM
To: Shashidhara Veerabhadraiah
Cc: 2d-dev@openjdk.java.net
Subject: RE: [OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for
javax/imageio/AllowSearch.java
Hello Shashi,
The lines before the try{} block in test() function in the test case can throw
IOException
hat to do with respect to them. Should I raise new bugs if there
is problem with them(if not on the bug db) and fix it?
Updated Webrev:
http://cr.openjdk.java.net/~pkbalakr/shashi/8183341/webrev_01/
Thanks and regards,
Shashi
From: Sergey Bylokhov
Sent: Wednesday, July 12, 2017
Hi All,
Please review a fix for a test bug which was not cleaning up the temporary test
files that it used to create.
The issue with this test was that the test used to create temporary files but
not deleting them.
The updated test file does the deletion of the temporary files that the test is
Hi, Here is the updated Webrev with comment fixes:
http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_06/
Thanks and regards,
Shashi
From: Shashidhara Veerabhadraiah
Sent: Monday, June 12, 2017 11:19 PM
To: Philip Race ; Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Ok Phil. I shall update the test and send it for re-review tomorrow.
Thanks and regards,
Shashi
From: Phil Race
Sent: Monday, June 12, 2017 11:15 PM
To: Shashidhara Veerabhadraiah ;
Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Subject: Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print
failures because the
settings are different for different locales and it may be difficult to adapt
to every possible locales.
Thanks and regards,
Shashi
From: Phil Race
Sent: Monday, June 12, 2017 10:01 PM
To: Shashidhara Veerabhadraiah ;
Prasanta Sadhukhan
Cc: 2d-dev@openjdk.java.net
Hi Phil, Please see below for the comments:
The updated Webrev is at:
http://cr.openjdk.java.net/~aghaisas/shashi/6949753/webrev_05/
Thanks and regards,
Shashi
From: Phil Race
Sent: Saturday, June 10, 2017 3:07 AM
To: Prasanta Sadhukhan ; Shashidhara
Veerabhadraiah
Cc: 2d-dev
Hi All, Please find the updated Webrev with fixes for the comments @
http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_04/
Thanks and regards,
Shashi
From: Philip Race
Sent: Thursday, June 8, 2017 3:32 AM
To: Prasanta Sadhukhan
Cc: Shashidhara Veerabhadraiah ;
2d-dev
updated Webrev @
http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_03/
Please let me know if any comments on it.
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Tuesday, June 6, 2017 11:52 AM
To: Shashidhara Veerabhadraiah ;
2d-dev@openjdk.java.net
Cc: Philip Race
Sadhukhan
Sent: Monday, June 5, 2017 12:35 PM
To: Shashidhara Veerabhadraiah ;
2d-dev@openjdk.java.net
Cc: Philip Race
Subject: Re: [9]JDK-6949753:[TEST BUG]:
java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite
loop
I guess there is one more problem in usage of
Hi, I have fixed the comments below and updated the webrev @
http://cr.openjdk.java.net/~pkbalakr/shashi/6949753/webrev_01/
Thanks and regards,
Shashi
From: Prasanta Sadhukhan
Sent: Friday, June 2, 2017 12:36 PM
To: Shashidhara Veerabhadraiah ;
2d-dev@openjdk.java.net
Cc: Philip Race
Hi All,
Please review a fix for a test bug which contained an infinite loop to test the
printer setup dialog's margin attributes retention without the manual step
procedure.
The issue with PDialogTest.java which tests the printer setup dialog's margin
attributes retention by having as infinite
43 matches
Mail list logo
