Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

ks good to me. Just some nits. >> >> Can we split the long lines like this ? :- >> >> #define contextAwareMetricsX(vx, vy) \ >>(FTFixedToFloat(context->transform.xx) * (vx) - \ >> FTFixedToFloat(context->transform.xy) * (vy)) >> >> an

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

split the long lines like this ? :- > > #define contextAwareMetricsX(vx, vy) \ > (FTFixedToFloat(context->transform.xx) * (vx) - \ > FTFixedToFloat(context->transform.xy) * (vy)) > > and why "vx" and "vy", not just x and y ? > > -phil. &

[OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

Hello, could you please review a fix for JDK-8139178. Bug: https://bugs.openjdk.java.net/browse/JDK-8139178 Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/ The freetype scaler calculates font metrics with a transform applied to the scaler context. We have to revert this transform

Re: [OpenJDK 2D-Dev] RFR: 8204929: Fonts with embedded bitmaps are not always rotated

Hello Phil, the change looks fine to me. There is another bug which reports the same problem for openjdk8: https://bugs.openjdk.java.net/browse/JDK-8163278 Probably, it can be closed as a duplicate of 8204929. Thanks, Andrew > On Jun 15, 2018, at 4:23 AM, Philip Race wrote: > > Bug : http

Re: [OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

u need to use deriveFont and can't > test this with the constructor taking int of 12. > > -phil > > On 5/22/18, 8:50 AM, Andrew Brygin wrote: >> Webrev: http://cr.openjdk.java.net/~bae/8203485/webrev.00/ >> >> Bug: >> https://bugs.openjdk.java.net/b

[OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

Webrev: http://cr.openjdk.java.net/~bae/8203485/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8203485 With freetype, text rotated on 180 or 270 degrees is too narrow. Attached test case and screenshots demonstrate the problem. The problem is caused by the rounding applied to the case

Re: [OpenJDK 2D-Dev] RFR: 8047931: Remove unused medialib code

Hello Vadim, the change looks fine to me. Probably, there is more room for optimization: we actually use only mlib images with types MLIB_BYTE, and MLIB_SHORT (see allocateArray() and allocateReasterArray()) so routines for other types likely can be eliminated. Thanks, Andrew > On May 4, 2

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race mailto:philip.r...@oracle.com>> wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous substantial fixes and provided m

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race mailto:philip.r...@oracle.com>> wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous substantial fixes and provided m

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

we can detect the cases when GDI and JDK disagree on the actual font and remap the glyph id. -phil. On 7/15/15 4:12 AM, Andrew Brygin wrote: Hello, could you please review a fix for 8078382? bug: https://bugs.openjdk.java.net/browse/JDK-8078382 webrev: http://cr.openjdk.java.net/~bae/80783

[OpenJDK 2D-Dev] [9] request for review: 8098853: [PIT] Fonts look much darker than before in the PIT build for b68

Hello, could you please review a fix for 8098853? bug: https://bugs.openjdk.java.net/browse/JDK-8098853 webrev: http://cr.openjdk.java.net/~bae/8098853/9/webrev.00/ By default, we use 140 as lcd contrast value. However, on macosx this value causes significant discrepancy with results of nati

[OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

Hello, could you please review a fix for 8078382? bug: https://bugs.openjdk.java.net/browse/JDK-8078382 webrev: http://cr.openjdk.java.net/~bae/8078382/9/webrev.00/ The problem is caused by following peculiarity of the Code New Roman font: this font provides plain, italic and bold variants.

Re: [OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

Hello Phil, the fix looks fine to me. Thanks, Andrew On 7/15/2015 1:37 AM, Phil Race wrote: If a child raster is created with a non-zero x-offset then subsequently in the code that validates the raster for imaging operations we may incorrectly calculate that the image exceeds the data buffer.

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

/8087201/9/webrev.01/ What do you think? Thanks, Andrew On 6/25/2015 8:08 PM, Phil Race wrote: On 06/25/2015 03:33 AM, Andrew Brygin wrote: Given that it is a unified driver it sounds like we may be want to disable this code path when on windows at least for NV but I guess we may also want to

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

%) | | *** | On 19.06.15 15:54, Andrew Brygin wrote: Hello Sergey, the only part of the fix affects the performance of AA case: the cache cell size. In a case of retina

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

24/06/15 21:40, Phil Race wrote: On 6/24/15 8:18 AM, Andrew Brygin wrote: Hello Phil, please see my comments inline. 23/06/15 21:29, Phil Race wrote: Hi Andrew, Overall the fix looks good. A few questions. 1. Regarding translucent surfaces, do you know when Swing has a translucent

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

inal performance. Thanks, Andrew -phil. On 06/18/2015 07:40 AM, Andrew Brygin wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8087201 Webrev: http://cr.openjdk.java.net/~bae/8087201/9/webrev.00/ Thanks, Andrew 18/06/15 17:39, Andrew Brygin пишет: Hello, could you please review a fi

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

Hello Prasanta, I have couple comments regarding the fix. * lines 408 - 420 and lines 438 - 444. Here you are obtaining the source and destination rasters for all bands (colors + alpha). However, it is already done on the lines 391 and 392. Could you please clarify a purpose of

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

ling subpixel rendering btw, except for some text rendered double, but I think that's a netbeans issue; https://bugzilla-attachments-216655.netbeans.org/bugzilla/attachment.cgi?id=153905 On 19 June 2015 at 00:40, Andrew Brygin wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-80

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

ite etc. I think this information can be useful as a comments in the code. On 18.06.15 17:39, Andrew Brygin wrote: Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content of destination surface to lcd shader to compose the lcd glyph co

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

Bug: https://bugs.openjdk.java.net/browse/JDK-8087201 Webrev: http://cr.openjdk.java.net/~bae/8087201/9/webrev.00/ Thanks, Andrew 18/06/15 17:39, Andrew Brygin пишет: Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content of

[OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content of destination surface to lcd shader to compose the lcd glyph correctly. In order to do this, we have to copy a sub-image from destination buffer to an intermediate texture using gl

Re: [OpenJDK 2D-Dev] [9] Review Request: 8080993 Compilation errors with recent clang in awt_parseImage.c and splashscreen_sys.m

Hi Sergey, the fix looks fine to me. Thanks, Andrew On 6/17/2015 1:16 AM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 08.06.15 19:52, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. Two simple warnings were fixed. The fix contributed by Staffan Lar

Re: [OpenJDK 2D-Dev] review backport fix of 8081756 to 8u-dev

Hello Phil, the backport looks fine to me. Thanks, Andrew On 6/10/2015 11:25 PM, Phil Race wrote: Andrew/Sergey, Could one of you please be a 'sanity check' backport reviewer on this backport of a missing check for NULL in LittleCMS code. It is identical to the JDK 9 changeset : - http://h

[OpenJDK 2D-Dev] [9] request for review: 8085910: OGL text renderer: gamma lut cleanup

Hello Sergey, and Phil, could you please review a fix for CR 8085910? Bug: https://bugs.openjdk.java.net/browse/JDK-8085910 Webrev: http://cr.openjdk.java.net/~bae/8085910/9/webrev.00/ This fix just removes the code related to gamma LUTs from ogl text renderer. This code is not needed anymor

Re: [OpenJDK 2D-Dev] RFR: 8u-dev backport: 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

hil Race wrote: This is fine by me. -phil. On 05/30/2015 10:21 AM, Andrew Brygin wrote: Hello Sergey, and Phil, could you please review a backport of the fix for 8023794 to 8u-dev? The change is exactly same, except a declaration of the loop counter 'i' in getReverseGammaLut()

[OpenJDK 2D-Dev] RFR: 8u-dev backport: 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Sergey, and Phil, could you please review a backport of the fix for 8023794 to 8u-dev? The change is exactly same, except a declaration of the loop counter 'i' in getReverseGammaLut() routine (CGGlyphImages.m, lines 206-217): it has to be moved in order to meet XCode 4.x expectations.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061831 [OGL] "java.lang.InternalError: not implemented yet" during the blit of VI to VI in xor mode

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 5/22/2015 7:59 PM, Sergey Bylokhov wrote: On 21.05.15 22:59, Jim Graham wrote: I'm curious about bufferClip in the converter routine. Does that help? Since we clip when we blit back to the destination in the last line, we don't nec

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

y your best to ignore the colour) match what other apps produce ? -phil. On 04/30/2015 06:21 AM, Andrew Brygin wrote: Hello Phil, please take a look to updated version of the fix: http://cr.openjdk.java.net/~bae/8023794/9/webrev.09/ The main difference is in glyph generation. I have impl

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

take a look. Thanks, Andrew On 4/24/2015 7:33 PM, Andrew Brygin wrote: Hello Phil, please see my comments inline. On 4/23/2015 11:15 PM, Phil Race wrote: 373 fontHints.put(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_ON); Why do we need this ? Historically in

Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7

' the resulting 8 files against the 9 files and they are all identical So the end result is that we will have exactly LCMS 2.7 "FCS/GA" in both JDK 8u60 and JDK 9 I am also running a full JPRT job to make sure there are no build surprises. -phil. On 04/28/2015 09:39 PM, An

Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7

Hello Phil, the change looks fine to me. Thanks, Andrew. 29/04/15 00:34, Phil Race wrote: On 04/21/2015 03:47 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8078331 http://cr.openjdk.java.net/~prr/8078331/ These changes are all directly from upstream LCMS. It takes us from 2

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

And can (should) any of these changes also be applied to D3D ? 1. We can check how gamma correction is done in d3d. If a lookup is also used there, we can assess how rough the interpolation is. 2. translucent destination support (as a part of JDK-8078516)? Thanks, Andrew -phil. On 03/2

Re: [OpenJDK 2D-Dev] RFR: Backport :8073699: Memory leak in jdk/src/java/desktop/share/native/libjavajpeg/imageioJPEG.c

Hi Phil, it looks fine to me. Thanks, Andrew 20/04/15 21:49, Phil Race пишет: Andrew & Sergey, Please review this identical 8u60 backport (diff below) of the JDK 9 fix : http://hg.openjdk.java.net/jdk9/hs/jdk/rev/b7e402c9b183 hg diff imageioJPEG.c diff --git a/src/share/native/sun/awt/ima

Re: [OpenJDK 2D-Dev] RFR: 7145508: java.awt.GraphicsDevice.get/setDisplayMode behavior is incorrect when no display is present

Hello Phil, the change looks fine to me. Thanks, Andrew On 4/18/2015 12:19 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/7145508/ https://bugs.openjdk.java.net/browse/JDK-7145508 If you physically disconnect the monitor and run headful, then on X, the XR&R extension will return NUL

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

, Andrew Brygin wrote: Hi Chris, thank you for the comments and explanation. I have updated the OGLContext_IsLCDShaderSupportAvailable() and comments in OGLTextRenderer.c accordingly: http://cr.openjdk.java.net/~bae/8023794/9/webrev.07/ Good to know that you keep an eye on the OGL pipeline

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

the restrictions in OGLContext_IsLCDShaderSupportAvailable() could be loosened since you only need 2 texture units now. Just in the extremely unlikely case that anyone's running this stuff on ancient hardware :) Thanks, Chris Andrew Brygin wrote: Hello Phil, could you please take a look to updated

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

1 Number of ties: 2 Number of losses: 1 Thanks, Andrew On 12/12/2014 8:11 PM, Andrew Brygin wrote: Hello Phil, at the moment, I failed to get acceptable results for rendering to translucent destination. I am playing with an idea to fall back to grayscale AA on non-opaque pixels

[OpenJDK 2D-Dev] [9] request for review: 8074954: ImageInputStreamImpl.readShort/readInt do not behave correctly at EOF

Hello, could you please review a fix for CR 8074954? Bug: https://bugs.openjdk.java.net/browse/JDK-8074954 Webrev: http://cr.openjdk.java.net/~bae/8074954/9/webrev.00/ The problem happens if an input stream does not contain enough data to read a multi-byte type (as 4-bytes integer or 2-bytes

Re: [OpenJDK 2D-Dev] [9] Review Request: 4958064 JPGWriter does not throw UnsupportedException when canWriteSequence retuns false

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 2/9/2015 4:30 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk 9. The API Doc for ImageWriter.PrepareWriteSequence() claims that this method will throw UnsupportedOperationException when canWriteSequence() returns

Re: [OpenJDK 2D-Dev] RFR: copy/paste duplicated tests in some condition statements

Hi Phil, the fix looks fine. Thanks, Andrew On 2/3/2015 11:14 PM, Phil Race wrote: Fixing the mistakes Sergey just pointed out : http://cr.openjdk.java.net/~prr/8072433/ I marked these no-reg clean up as both are not easily reachable by tests. One being in the case we de-register bad fonts,

Re: [OpenJDK 2D-Dev] RFR: 6243376: JPEGImageWriter corrupts color for non-JFIF images with differing sample factors

Hello Phil, the fix looks fine to me. Thanks, Andrew On 2/3/2015 9:34 PM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-6243376 http://cr.openjdk.java.net/~prr/6243376/ One-line fix we should have done a long time ago. The test was more work .. -phil.

Re: [OpenJDK 2D-Dev] Review Request: 4952954 abort flag is not cleared for every write operation for JPEG ImageWriter

Hello Sergey, the change looks fine to me. Thanks, Andrew On 1/29/2015 1:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. After the fix a jpeg plugin will clear abort flag and reset the native state when the write method will be called after abort. Bug: https://bugs.ope

Re: [OpenJDK 2D-Dev] RFR: 8064833 : [macosx] Native font lookup uses family+style, not full name/postscript name

like I was using the assigned variable to do some debugging. I'll update the webrev - including the test. -phil. On 1/23/15 12:29 PM, Andrew Brygin wrote: Hi Phil, please see my comments inline. On 1/23/2015 9:51 PM, Phil Race wrote: 280-282 is creating an italic version of the plain f

Re: [OpenJDK 2D-Dev] RFR: 8064833 : [macosx] Native font lookup uses family+style, not full name/postscript name

this? Thanks, Andrew so its not the same variant. -phil. On 12/31/2014 12:41 AM, Andrew Brygin wrote: Hello Phil, could you please clarify why do we need to register italic variant twice: CFontManager.java: 280 registerGenericFont(plain.createItalicVariant(), true); 281

Re: [OpenJDK 2D-Dev] RFR: 8064833 : [macosx] Native font lookup uses family+style, not full name/postscript name

Hello Phil, could you please clarify why do we need to register italic variant twice: CFontManager.java: 280registerGenericFont(plain.createItalicVariant(), true); 281CFont f = plain.createItalicVariant(); 282registerGenericFont(f, true); the

Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

Hello Mario, the change looks fine to me. Thanks, Andrew - Original Message - From: neug...@redhat.com To: philip.r...@oracle.com Cc: 2d-dev@openjdk.java.net Sent: Friday, December 19, 2014 7:34:06 PM GMT +04:00 Abu Dhabi / Muscat Subject: Re: [OpenJDK 2D-Dev] Printing to Postscript doe

Re: [OpenJDK 2D-Dev] [9] Review Request: 8065373 [macosx] jdk8, jdk7u60 Regression in Graphics2D drawing of derived Fonts

Hello Sergey, the change looks fine to me. Thanks, Andrew. On 12/12/2014 12:57 AM, Sergey Bylokhov wrote: Hi, Phil. - philip.r...@oracle.com wrote: > > Consistent treatment of concatenating sInverseTx seems right although > I am not sure of the overall picture here. > > Quartz uses "y in

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

consider to use two different programs: one for opaque paint (in order to preserve performance), and another (like published now) for the case of alpha paint. Please take a look. Thanks, Andrew On 10/25/2014 12:03 AM, Phil Race wrote: On 10/24/2014 10:56 AM, Andrew Brygin wrote: Hello

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061832 J2DBench can be improved

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 11/7/2014 11:50 AM, Sergey Bylokhov wrote: Hi, Phil. The new version of the fix: http://cr.openjdk.java.net/~serb/8061832/webrev.03 On 06.11.2014 21:48, Phil Race wrote: Am I right in understanding that the huge 4000x4000 option is di

Re: [OpenJDK 2D-Dev] [9] Review Request: 8059944 [OGL] Metrics for a method choice copying of texture should be improved

Hello Sergey, the change looks fine to me. Thanks, Andrew On 11/24/2014 9:00 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This fix initially was sent as a fix for JDK-8029253 [1], but was postponed because another issue became a bottleneck [2] Description: We have two

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

paint. This behavior is common for all cases (software loops, OGL, and D3D), so it seems to deserve a separate bug if we want to handle this case. Thanks, Andrew On 10/14/2014 3:39 AM, Phil Race wrote: On 10/13/2014 05:41 AM, Andrew Brygin wrote: Hello Phil, please see my

Re: [OpenJDK 2D-Dev] [9] Review Request: 8059941 [D3D] The fix for JDK-8029253 should be ported to d3d pipeline

Hello Sergey, the change looks fine to me. Thanks, Andrew On 10/15/2014 10:43 PM, Sergey Bylokhov wrote: Hello. After a few attempts I am able to run 2dbench on my laptop in d3d mode: Config file: http://cr.openjdk.java.net/~serb/8059941/nvidia-d3d-win/drawimage Results: http://cr.openjdk.j

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061456 [OGL] Incorrect clip is used during sw->surface blit in xor mode

Hello Sergey, the change is fine to me. Thanks, Andrew On 10/21/2014 7:09 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. In the OGLAnyCompositeBlit the clip for the primary destination is used as the clip for the temporal buffer. Bug: https://bugs.openjdk.java.net/brows

Re: [OpenJDK 2D-Dev] RFR: 8061392: PrinterJob NPE when drawing translucent image with null user clip

Hello Phil, the change looks fine to me. Thanks, Andrew On 10/18/2014 1:19 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8061392/ https://bugs.openjdk.java.net/browse/JDK-8061392 A check for null was missing This was partly to blame for a JavaFX printing bug. -phil.

Re: [OpenJDK 2D-Dev] RFR: 8061267: PrinterJob: Specified Page Ranges not displayed in Windows Native Print Dialog

Hello Phil, the change looks fine to me. Thanks, Andrew On 10/17/2014 12:32 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8061267/ https://bugs.openjdk.java.net/browse/JDK-8061267 An apparently old issue that the specified page ranges don't get displayed because we forgot to set the

Re: [OpenJDK 2D-Dev] RFR: 8058969 : Test closed/sun/java2d/cmm/StubCMMShellTest.sh fails

Hello Phil, the fix looks fine to me. Thanks, Andrew On 10/14/2014 3:27 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8058969 http://cr.openjdk.java.net/~prr/8058969/ This is a missing doprivileged in code updated to support jigsaw -phil.

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

o evaluate these hints properly, and a best solution is probably to raise an error. Thanks, Andrew -phil. On 10/10/14 2:13 PM, Andrew Brygin wrote: Hello Phil, please see my comments inline. On 10/11/2014 12:49 AM, Phil Race wrote: On 10/10/14 11:05 AM, Andrew Brygin wrote: Hello Ph

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Phil, please see my comments inline. On 10/11/2014 12:49 AM, Phil Race wrote: On 10/10/14 11:05 AM, Andrew Brygin wrote: Hello Phil, changes in SunGraphics2D and SurfaceData were made in order to implement an approach 'LCD instead of greyscale AA if possible'. Without th

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

NTVAL_TEXT_ANTIALIAS_ON: 752 //return aaTextRenderer; ... that looks like the case where the application code has *explicitly* specified greyscale (ON==greyscale) so I don't see why you need to go check the fontinfo in this case ? -phil. On 10/10/2014 07:34 AM, Andrew Brygin wrot

Re: [OpenJDK 2D-Dev] RFR: 8059848 Test java/awt/GraphicsDevice/CloneConfigsTest.java causes JVM crash in OEL 7.0

Hello Phil, the fix looks fine to me. Thanks, Andrew On 10/10/2014 8:20 PM, Phil Race wrote: This looks like its a driver bug. We use a scratch surface of size 1x1 when iterating through testing all the gl capable visuals and some of them get a SIGFPE: FPE_INTDIV when as we try to make the co

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

return only lcdTextRenderer from SurfaceData.getTextPipe() Of course it is a brute force approach, but it allows producing a legible text in case of offscreen rendering. Thank you, Denis. On 29 Sep 2014, at 19:30, Andrew Brygin <mailto:andrew.bry...@oracle.com>> wrote: Hello De

Re: [OpenJDK 2D-Dev] RFR: 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

Hello Phil, the change looks fine to me. Thanks, Andrew On 10/9/2014 11:09 PM, Phil Race wrote: Apparently jigsaw finds it inconvenient that the service provider class names are different for Windows vs the rest of the platforms, so this fix basically just renames both classes to PrintServi

Re: [OpenJDK 2D-Dev] [9] Review Request: 8029253 [macosx] Performance problems with Retina display on Mac OS X

Hello Sergey, the change looks fine to me. Regarding the performance results, I have no words... Thanks, Andrew On 10/6/2014 9:29 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The new blit was implemented: OGLGeneralTransformedBlit, it adds a huge boost in case of unc

Re: [OpenJDK 2D-Dev] RFR: 8059219 : JDK, JDK-8059219, , javax.print.PrintServiceLookup allows to register null service

Hello Phil, the fix looks fine. Thanks, Andrew On 10/3/2014 11:22 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8059219/ https://bugs.openjdk.java.net/browse/JDK-8059219 Straightforward fix for a very old bug .. -phil.

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Denis, I am not sure whether we should use 'apple.awt.graphics.UseQuartz' property. Probably we have to change the text antialiasing defaults for macosx instead. I am working on the issue with software loops. I will update the thread with my findings. Thanks, Andrew On 9/3/2014 3:

Re: [OpenJDK 2D-Dev] JDK-8038998: buttons/checkboxes/menus etc have disapearing text or fail to repaint properly

Hello Hendrik, the bug report mentions that the problem is reproducible on 1.8.0-b132. Is the problem reproducible with 8u20? Also, according to comments in the bug, it looks like D3D pipeline was activated on Intel video board: [I] Description : Intel(R) HD Graphics 4000 [I] D3DContext::Con

Re: [OpenJDK 2D-Dev] RFR: JDK-8017773: OpenJDK7 returns incorrect TrueType font metrics

Hello Yasumasa, the fix looks ok to me. Thanks, Andrew On 9/20/2014 5:58 AM, Yasumasa Suenaga wrote: > Hi Phil, > > I changed subject of this email thread. > webrev of this issue is here: > > http://cr.openjdk.java.net/~ysuenaga/JDK-8017773/webrev.00/ > > I'm just an author of jdk9, not a commit

Re: [OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

bug can be fixed in the readHeader itself? Because currently it call iis.skipBytes(bitmapOffset) at the end only for the first time. On 03.09.2014 16:23, Andrew Brygin wrote: Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http

[OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http://cr.openjdk.java.net/~bae/8041465/9/webrev.00/ The problem happens if we perform multiple read operations from a source which is set only once. For instance, we can try to

Re: [OpenJDK 2D-Dev] RFR: 8056122: Upgrade JDK to use LittleCMS 2.6

Hello Phil, the change looks fine to me. Thanks, Andrew On 8/27/2014 2:26 AM, Phil Race wrote: Andrew (and at least one other brave soul), please review :- http://cr.openjdk.java.net/~prr/8056122/ -phil.

Re: [OpenJDK 2D-Dev] Review request for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black

Hello Clemens, the fix and the test look fine to me. The test probably can be simplified a bit with using getSnapshot() method of VolatileImage class, but it does not matter much here. Thanks, Andrew On 8/26/2014 11:35 PM, Phil Race wrote: Andrew or Jennifer : can you add your review 2c

Re: [OpenJDK 2D-Dev] [9] request for review: 8040617: macosx : Large JTable cell results in a OutOfMemoryException

: Hi, Andrew. It seems to me that the same bug exists on other platforms as well. Probably we can move this check to the upper level(in the same way as d3d in case of InvalidPipeException?)? On 22.08.2014 18:34, Andrew Brygin wrote: Hello, could you please review a fix for CR 8040617? Bug

[OpenJDK 2D-Dev] [9] request for review: 8040617: macosx : Large JTable cell results in a OutOfMemoryException

Hello, could you please review a fix for CR 8040617? Bug: https://bugs.openjdk.java.net/browse/JDK-8040617 Webrev: http://cr.openjdk.java.net/~bae/8040617/9/ The problem happens when we are trying to create an accelerated copy for a buffered image with dimension exceeded GL_MAX_TEXTURE_SIZE.

Re: [OpenJDK 2D-Dev] RFR: 8055201 : Some missing JNI error checking

Hello Phil, the change looks fine. Thanks, Andrew On 8/18/2014 10:16 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8055201/ Checks for (unlikely) failures in some JNI calls. -phil.

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

oes against this. What is the rationale, and why can't it be reverted to be able to build on 1.4 and run on 1.2 ? If it uses JDK 1.5 language features, just back them out. If it uses JDK 1.5 APIs then maybe Jim had to handle something similar and has an idea ? -phil. On 4/30/2014 4:13 AM, A

Re: [OpenJDK 2D-Dev] [9] Review Request: 8046007: Java app receives javax.print.PrintException: Printer is not accepting job

Hello Alexey, the fix looks fine to me. Thanks, Andrew On 8/11/2014 1:42 PM, Alexey Ivanov wrote: Hello, Could anybody please review the fix as the second reviewer? bug: https://bugs.openjdk.java.net/browse/JDK-8046007 webrev: http://cr.openjdk.java.net/~aivanov/8046007/jdk9/webrev.

Re: [OpenJDK 2D-Dev] Review Request for JDK-6708093: Removal of a redundant unused native method declaration in LCMS.java

Hello Pushan, the change looks fine. Thanks, Andrew On 8/8/2014 1:51 AM, Pushan Hinduja wrote: Hello, Could you please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-6708093 The corresponding Webrev is located at: http://cr.openjdk.java.net/~ssides/6708093/

Re: [OpenJDK 2D-Dev] [9] Review Request: 8026497 Font2DTest demo: unused resource files

Hello Sergey, the change looks fine to me. Thanks, Andrew On 8/1/2014 2:25 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk9. Unused property files were removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8026497 Webrev can be found at: http://cr.openjdk.java.net/~serb

Re: [OpenJDK 2D-Dev] RFR: 8052396: Catch exceptions resulting from missing font cmap

Hello Phil, in general, the change looks fine to me. The only concern is whether the code at FileFontStrike.java lines 498 - 506 triggers tools like findbug due to missed 'break' statement. Does it worth to add 'break' there? Thanks, Andrew On 7/29/2014 2:30 AM, Phil Race wrote: https:/

Re: [OpenJDK 2D-Dev] RFR 8u-dev backport of 8043508: JVM core dumps with very long text in tooltip

Hello Phil, the backport looks fine. Thanks, Andrew On 7/23/2014 9:24 PM, Phil Race wrote: Please OK this back port, It is identical to the 9 fix http://cr.openjdk.java.net/~prr/8043508.8u/ http://hg.openjdk.java.net/jdk9/client/jdk/rev/8a7fdbaea99b https://bugs.openjdk.java.net/browse/JDK-80

Re: [OpenJDK 2D-Dev] RFR: 8048583: CustomMediaSizeName class matching to standard media is too loose

the updated fix looks fine to me. Thanks, Andrew On 7/11/2014 10:24 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8048583.1/ updated version to fix the incorrect usage of w and h instead of dw and dh spotted by Andrew. -phil. On 06/27/2014 01:40 PM, Phil Race wrote: Bug : https://b

Re: [OpenJDK 2D-Dev] RFR: 8048583: CustomMediaSizeName class matching to standard media is too loose

Hello Phil, 79 float dw = Math.abs(w - width); 80 float dh = Math.abs(h - length); 81 if (w > 0.1 || h > 0.1) { 82 mediaName = null; 83 } I have an impression that we have to check dw and dh on line 81,

Re: [OpenJDK 2D-Dev] RFR: 8048328: CUPS Printing does not report supported printer resolutions.

Hello Phil, the fix looks fine to me. Thanks, Andrew On 6/28/2014 12:47 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8048328 Fix: http://cr.openjdk.java.net/~prr/8048328/ We have never supported returning the available printer resolutions for CUPS printing although it

Re: [OpenJDK 2D-Dev] [9] Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth

is a complete duplicate of https://bugs.openjdk.java.net/browse/JDK-4991647 Always remember to look for duplicates ! So I have closed 8041460 and you should push under 4991647 - once the code is fixed and reviewed. I have assigned 4991647 to you. -phil. On 6/23/2014 6:09 AM, Andrew Brygin wrote: He

Re: [OpenJDK 2D-Dev] [9] Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth

Hello Mikhail, the fix looks fine to me. Thanks, Andrew On 6/9/2014 10:32 PM, mikhail cherkasov wrote: Hi all, please review the fix: http://cr.openjdk.java.net/~mcherkas/8041460/webrev.02/ for the following bug: https://bugs.openjdk.java.net/browse/JDK-8041460 The problem is that during me

Re: [OpenJDK 2D-Dev] [9] Review request for 8047066: Test test/sun/awt/image/bug8038000.java fails with ClassCastException

Hello Anton, the fix looks fine. Thanks, Andrew On 6/18/2014 6:54 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8047066/9/webrev.00/ bug: https://bugs

Re: [OpenJDK 2D-Dev] [9] Review Request: 8029253 [macosx] Performance problems with Retina display on Mac OS X

Hi Sergey, could you please clarify why you have eliminated OGLC_VENDOR_SUN? Thanks, Andrew On 6/11/2014 5:01 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9, which is also targeted for jdk 8u20. Description: We have two codepaths to draw a raster to the opengl: - via glDra

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface->sw blit

Hello Sergey, the fix for ogl looks fine to me. Could you please update the test, and submit a separate bug against d3d? Thanks, Andrew On 5/20/2014 9:31 PM, Sergey Bylokhov wrote: On 5/20/14 9:17 PM, Phil Race wrote: On 5/20/2014 10:03 AM, Sergey Bylokhov wrote: On 5/20/14 8:52 PM, Phil

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 and 8017626

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 5/13/2014 5:00 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This a second iteration of the fix for 8041129, because it was changed to cover 8017626 as well. Description of the problem: 8041129: [OGL] surface-

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041439: Clipping doesn't work on JPanel after setXORMode method call.

Hello Mikhail, could you please provide a bit more detailed explanation for your fix? Thanks, Andrew On 5/29/2014 3:35 PM, mikhail cherkasov wrote: Hello, Please review the fix for jdk 9: http://cr.openjdk.java.net/~mcherkas/8041439/9/webrev.00/ the bug: https://bugs.openjdk.java.net/browse/

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042103 Deserialization of empty java.awt.geom.Path2D will cause an exception

Hello Sergey, the fix looks good to me. Thanks, Andrew On 5/23/2014 10:34 PM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 5/5/14 5:30 PM, Sergey Bylokhov wrote: Hi, Jim. On 01.05.2014 4:44, Jim Graham wrote: Hi Sergey, I think the bug is in the readObject routine. I

Re: [OpenJDK 2D-Dev] 8038876: Remove use of ServiceLoader in locating sun.java2d.cmm.CMMServiceProvider

Hello Phil, the change looks fine to me. Thanks, Andrew On 5/10/2014 2:41 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8038876/ https://bugs.openjdk.java.net/browse/JDK-8038876 Another one to help the job of jigsaw .. -phil.

Re: [OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

Hello Phil, I have corrected both occurrences of the typo: http://cr.openjdk.java.net/~bae/6945174/9/webrev.01/ Thanks, Andrew On 5/9/2014 2:04 AM, Phil Race wrote: Looks OK but please fix the typo in the exception string .. lenght -> length -phil. On 5/8/14 11:43 AM, Andrew Bry

[OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

Hello, could you please review a fix for CR 6945174? Bug: https://bugs.openjdk.java.net/browse/JDK-6945174 Webrev: http://cr.openjdk.java.net/~bae/6945174/9/webrev.00/ PNG image reader validates the length of chunk's data when reads image metadata. However, if metadata is ignored, the length i

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

Hello Sergey, the change looks fine to me. Thanks, Andrew On 4/30/2014 3:12 PM, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk 9. Makefile and README were fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8042199 Webrev can be found at: http://cr.openjdk.java.net/~serb

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

On 4/25/2014 4:52 PM, Sergey Bylokhov wrote: On 4/25/14 4:35 PM, Andrew Brygin wrote: Hello Sergey, the fix looks fine to me. The tests do not force the OGL pipeline, so they will verify the change only on macosx. Is it done for purpose? Yes, I assume that the jdk know better, when to

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

Number of losses: 0 On 21.04.2014 18:52, Andrew Brygin wrote: Hello Sergey, the fast path skips j2d_glPixelStorei(GL_PACK_SKIP_ROWS, dsty). Could you please clarify why? I think that initial value of dsty (dstInfo.bounds.y1) can be non-zero, and this operation seem to be required... T

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface->sw blit is extremely slow

Hello Sergey, the fast path skips j2d_glPixelStorei(GL_PACK_SKIP_ROWS, dsty). Could you please clarify why? I think that initial value of dsty (dstInfo.bounds.y1) can be non-zero, and this operation seem to be required... Thanks, Andrew On 4/21/2014 6:17 PM, Sergey Bylokhov wrote: Hello.

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

at least one scanline. Below is the updated fix. I've also added explicit check for implicit (minY - sampleModelTranslateY >= 0) constraint. http://cr.openjdk.java.net/%7Eanashaty/8038000/webrev.02/ Thank you! Anton. On 11.04.2014 15:06, Andrew Brygin wrote: Hello Anton, we prob

  1   2   3   4   >