.02/>
Regards,
Jay
*From:*Prahalad Kumar Narayanan
*Sent:* Tuesday, April 17, 2018 11:50 AM
*To:* Jayathirth D V; Philip Race; 2d-dev
*Subject:* RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter
incorrectly sets bKGD chunk
Hello Jay
The changes are fine.
Just a minor observation: The
Hello Jay
Changes are good.
Thanks
Have a good day
Prahalad N.
From: Jayathirth D V
Sent: Tuesday, April 17, 2018 2:23 PM
To: Prahalad Kumar Narayanan; Philip Race; 2d-dev
Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly
sets bKGD chunk
Hi
; Philip Race; 2d-dev
Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly
sets bKGD chunk
Hello Jay
The changes are fine.
Just a minor observation: The image reader should be disposed in the test case.
Thank you
Have a good day
Prahalad N.
From
: Wednesday, April 11, 2018 10:40 PM
To: Jayathirth D V; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly
sets bKGD chunk
The fix seems fine but like the other review I wonder if
the test can use a bytearrayoutputstream instead of writing to a file.
-phil
; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly
sets bKGD chunk
The fix seems fine but like the other review I wonder if
the test can use a bytearrayoutputstream instead of writing to a file.
-phil.
On 04/11/2018 03:51 AM, Jayathirth D V wrote:
Hello
The fix seems fine but like the other review I wonder if
the test can use a bytearrayoutputstream instead of writing to a file.
-phil.
On 04/11/2018 03:51 AM, Jayathirth D V wrote:
Hello All,
Please review the following fix in JDK11 :
Bug : https://bugs.openjdk.java.net/browse/JDK-6574555
Hello All,
Please review the following fix in JDK11 :
Bug : https://bugs.openjdk.java.net/browse/JDK-6574555
Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/
Issue: PNGImageWriter. write_bKGD() function sets incorrect R, G, B value when
IHDR colortype and bKGD colortype
