-Original Message-
From: Jim Graham
Sent: Tuesday, May 03, 2016 1:42 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets bright artifacts
Thanks Prahalad,
Looks great - +1
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets bright artifacts
Thanks Prahalad,
Looks great - +1
...jim
On 5/2/2016 8:29 AM, Prahalad Kumar Narayanan
l 28, 2016 2:05 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets bright artifacts
Thanks Prahalad,
First, the macro design issues for all of these LoopMacros.h et al f
>> */ \
>> /* operations and add the loaded color to result
>> */ \
>> if (blendF != MaxValFor4ByteArgb) { \
>> MultiplyAndStore4ByteArgbComps(tmp, \
>>
e again for your effort in review
Have a great day
Prahalad N.
-Original Message-
From: Jim Graham
Sent: Wednesday, April 27, 2016 2:12 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent
} \
> Store ## DST ## From4ByteArgbComps(DST_PTR, pix, \
> PIXEL_INDEX, res); \
> } \
> } while (0);
>
> My apologies if the above code did not appear on the final webrev email.
> ( In few instances, the newlin
e in review
Have a good day
Prahalad N.
-Original Message-
From: Jim Graham
Sent: Tuesday, April 05, 2016 3:07 AM
To: Prahalad Kumar Narayanan; Sergey Bylokhov; Philip Race
Cc: Praveen Srivastava
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text
Thank you for your time in review & detailed feedback that you get
> every time.
>
> Every such review improves the quality of code & the solution
>
> Prahalad N.
>
> *From:* Prahalad Kumar Narayanan
> *Sent:* Friday, April 01, 2016 5:07 PM
> *To:* Jim Graham; Serge
age-
From: Jim Graham
Sent: Friday, March 18, 2016 6:07 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070:
Antialiased text on translucent backgrounds gets bright artifacts
Hi Prahalad,
This basically boils down to &
uggestions.
Webrev Link:
http://cr.openjdk.java.net/~psadhukhan/prahlad/8015070/webrev.02/
Thank you for your time in review
Have a good day
Prahalad N.
-Original Message-
From: Jim Graham
Sent: Thursday, March 24, 2016 7:57 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java
: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets bright artifacts
Hi Prahalad,
(On a side note - ouch! I came up with these macros in the first place, but 20
years later I'm now realizing just how hard they are to navigate and review.
My
n review
Have a good day
Prahalad N.
-Original Message-
From: Jim Graham
Sent: Friday, March 18, 2016 6:07 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets brigh
Just curious, is the approach in SRCOVER_MASKFILL faster? I think yes,
but it adds and an additional branches which can affect performance. Did
you measure the difference?
On 22.03.16 14:35, Prahalad Kumar Narayanan wrote:
Observation from SRCOVER_MASKFILL
1. The mask fill reduces
7 AM
To: Prahalad Kumar Narayanan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased
text on translucent backgrounds gets bright artifacts
Hi Prahalad,
This basically boils down to "alpha blending math needs to be performed in
premultip
Hi Prahalad,
This basically boils down to "alpha blending math needs to be performed
in premultiplied form" and the existing code was not doing that.
Your changes do add a pre-multiplication step to the math in two places
- when you mix the src alpha and the glyph alpha at the top of the
Hello Everyone on Java2D Group
Good day to you.
Herewith, I 'm sharing the webrev for two identical Java2D Bugs.
Bug ID : JDK-8015070
Title : Antialiased text on translucent backgrounds gets bright
artifacts
Link : https://bugs.openjdk.java.net/browse/JDK-8015070
16 matches
Mail list logo
