Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-06-21 Thread Jennifer Godinez
Approved. Jennifer On 4/23/13 8:19 AM, Anton Litvinov wrote: Hello Jennifer, Thank you for clarification of your situation with JVM crash. I am very glad to know that it was not caused by the fix and that you managed to evaluate it. I tried to test the fix with the printer driver "Brother M

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-06-20 Thread Phil Race
I am ok with this fix. -phil. On 4/23/2013 8:19 AM, Anton Litvinov wrote: Hello Jennifer, Thank you for clarification of your situation with JVM crash. I am very glad to know that it was not caused by the fix and that you managed to evaluate it. I tried to test the fix with the printer driv

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-23 Thread Anton Litvinov
Hello Jennifer, Thank you for clarification of your situation with JVM crash. I am very glad to know that it was not caused by the fix and that you managed to evaluate it. I tried to test the fix with the printer driver "Brother MFC-J6710DW", which you specified in your previous e-mail. I also

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-19 Thread Jennifer Godinez
Hi Anton, I apologize that the cause of the crash is specific to my system. I re-cloned a fresh copy and did not see the crash anymore. The fix works but I have concern that mixing media size names with JDK predefined names with printer driver is still confusing for the user. For one, I wa

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-19 Thread Anton Litvinov
Hello Jennifer, I am sorry, but I cannot confirm existence of such a crash, because in my local environment I do not experience any unchecked Java exceptions and JVM crashes. Today I have made a fresh clone of all workspaces from the repository (http://hg.openjdk.java.net/jdk8/jdk8), have appl

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-18 Thread Jennifer Godinez
Hi Anton, I got a crash when I tried to go down the list of Media Size in Page Setup Dialog. Output is below. Can you confirm? Jennifer OUTPUT: --- PrintService = Win32 Printer : PrimoPDF * AWT Assertion Failure * value != NULL

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-17 Thread Jennifer Godinez
Thanks Anton. I will test your fix and let you know. Jennifer On 4/17/2013 5:53 AM, Anton Litvinov wrote: Hello Jennifer, Thank you very much for the review of this fix. For reproduction of this bug and testing of the fix the printer "PrimoPDF" with its driver "PrimoPDF" was used. This prin

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-04-17 Thread Anton Litvinov
Hello Jennifer, Thank you very much for the review of this fix. For reproduction of this bug and testing of the fix the printer "PrimoPDF" with its driver "PrimoPDF" was used. This printer is a virtual printer which generates PDF files as a result of printing jobs and which can be downloaded a

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-03-29 Thread Jennifer Godinez
Hi Anton, What printer and printer driver version did you use to test your fix? Thanks. Jennifer On 3/11/2013 1:41 AM, Anton Litvinov wrote: Hello, Please review the following fix. This is the second reminder message. Please take into account that the original review request was sent more t

[OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-03-11 Thread Anton Litvinov
Hello, Please review the following fix. This is the second reminder message. Please take into account that the original review request was sent more than 1 month ago and no response has been received yet. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007642 Webrev: http://cr.openjd

Re: [OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-02-21 Thread Anton Litvinov
Hello, I am sorry for inconvenience. This is a reminder message. I am still interested in reception of the response to this review request and just want to be sure that it is not lost on the mail alias's archive. Thank you, Anton On 2/8/2013 8:09 PM, Anton Litvinov wrote: Hello, Please rev

[OpenJDK 2D-Dev] [8] Review request for 8007642: Media Names on Java Print Do Not Match the Printer's and Confuse Users

2013-02-08 Thread Anton Litvinov
Hello, Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007642 Webrev: http://cr.openjdk.java.net/~alitvinov/8007642/webrev.00 The bug consists in the fact that Java cross-platform Page Setup and Print dialogs do not always list all media size