Hi,
Kindly review the small fix.
Background:
"javax/imageio/plugins/bmp/BMP8BPPLoadTest.java test case" has been added part
of JDK-8182461,
Test case has a dependency on input file "BMP8BPPLoadTest.PNG", during push
this was missed.
In this fix test case also modified to refer the input file
Hi Fairoz,
Do you know if the bmp image file has Oracle copyright? If not, you
cannot check it in.
Alternatively, you may get a hexdump of the bmp file and create a byte[]
array with that hex data and create ByteArrayInputStream with that and
use that for ImageIO as an ImageInputStream.
Rega
Hi Prasanta,
Thanks for looking into it.
> -Original Message-
> From: Prasanta Sadhukhan
> Sent: Friday, October 26, 2018 8:56 AM
> To: Fairoz Matte ; 2d-dev@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
> javax/imageio/plugins/bmp/BMP8BPPL
] [8u] RFR: 8212914: Test
javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
Hi Fairoz,
Do you know if the bmp image file has Oracle copyright? If not, you cannot
check it in.
I was not aware of it. Yes image file is not Oracle copyright compliant.
Alternatively, you may get a hexdump of th
Hi Prasanta,
> -Original Message-
> From: Prasanta Sadhukhan
> Sent: Monday, October 29, 2018 12:18 PM
> To: Fairoz Matte ; 2d-dev@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
> javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
>
>
; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
Hi Fairoz,
I do not see ImageIO.read and ImageIO.createImageInputStream throwing
IOB exception in the spec, it throws IOException so I guess there's no point
cat
>
> >> -Original Message-
> >> From: Prasanta Sadhukhan
> >> Sent: Monday, October 29, 2018 12:18 PM
> >> To: Fairoz Matte ; 2d-dev@openjdk.java.net
> >> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
> >> ja
tte
Sent: Tuesday, October 30, 2018 1:33 PM
To: Prasanta Sadhukhan; 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails
Thanks Prasanta,
I will update that, need one more review on this?
Thanks,
Fairoz
> -Origi
anges are fine.
>
> Thanks,
> Jay
>
> -Original Message-
> From: Fairoz Matte
> Sent: Tuesday, October 30, 2018 1:33 PM
> To: Prasanta Sadhukhan; 2d-dev@openjdk.java.net
> Subject: Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test
> javax/imageio/plug
