Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-04-04 Thread Jayathirth D V
Hi Prasanta, Changes are fine and test case looks good. Please make proper indentation for jtreg comments before checkin. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, April 01, 2016 10:47 PM To: prasanta sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9]: RFR JDK

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-04-01 Thread Phil Race
Looks good ! -phil. On 04/01/2016 12:02 AM, prasanta sadhukhan wrote: Please find the modified webrev with check for existing values to select which order to do the update. http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.02/ I have checked with 1) initially user sets from=3, to=4 and

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-04-01 Thread prasanta sadhukhan
Please find the modified webrev with check for existing values to select which order to do the update. http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.02/ I have checked with 1) initially user sets from=3, to=4 and then user change from=1,to=2 2) initially user sets from=3, to=4 and then

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-31 Thread Philip Race
On 3/30/16, 10:22 PM, prasanta sadhukhan wrote: Hi Phil, I found out we do not need to change minPage. That makes more sense now. Changing toPage before frompage should be enough. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.01/ Don't you need to

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-30 Thread prasanta sadhukhan
Hi Phil, I found out we do not need to change minPage. Changing toPage before frompage should be enough. Please find the modified webrev: http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.01/ Regards Prasanta On 3/29/2016 6:45 AM, Philip Race wrote: Please add an evaluation to the bug

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-28 Thread prasanta sadhukhan
Hi Phil, On 3/29/2016 6:45 AM, Philip Race wrote: Please add an evaluation to the bug report. As to the fix I am under the impression that min page are meant to constrain what the user can enter in the dialog so if min page & max page are set to "1" then the problem may be with those settings

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-28 Thread Philip Race
Please add an evaluation to the bug report. As to the fix I am under the impression that min page are meant to constrain what the user can enter in the dialog so if min page & max page are set to "1" then the problem may be with those settings ? i.e the application can set those values and

[OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

2016-03-28 Thread prasanta sadhukhan
Hi All, Please review a print job attribute fix for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-6357905 webrev: http://cr.openjdk.java.net/~psadhukhan/6357905/webrev.00/ The issue was in the Print-dialog, when some pages are specified using "Pages" within "Page range",