D V
Sent: Wednesday, December 16, 2015 2:57 PM
To: Philip Race
Cc: 2d-dev@openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-8143562:
JPEG reader returns null for getRawImageType()
Thanks for the review Phil.
Can I get one more review for new webrev : HYPERLINK
&
Thanks for the review Phil.
Can I get one more review for new webrev : HYPERLINK
"http://cr.openjdk.java.net/%7Ejdv/8143562/webrev.01/"http://cr.openjdk.java.net/~jdv/8143562/webrev.01/
Regards,
Jay
From: Phil Race
Sent: Wednesday, December 16, 2015 12:00 AM
To: Jayathirth D V
Cc:
Looks OK.
-phil.
On 12/14/2015 01:37 AM, Jayathirth D V wrote:
Hi Phil,
I have made changes based on your suggestions.
I have removed specific comment which mentioned about how we handle
YCbCr in JPEG and just added common comment(If there is no close match
then a type which preserves the
The quoted code comment is essentially disclaiming the spec comment.
And the spec. comment is misleading in that it strongly suggests
getRawImageType
will hand you an ImageTypeSpecifier representing YCbCr when in fact it
does not.
In fact all these comments and behaviours together seem to
The fix looks good to me.
The spec says "Returns an |ImageTypeSpecifier| indicating the
|SampleModel| and |ColorModel| which most closely represents the "raw"
internal format of the image. For example, for a JPEG image the raw type
might have a YCbCr color space even though the image would
Hi,
Please review following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8143562
Webrev : http://cr.openjdk.java.net/~jdv/8143562/webrev.00/
Issue : We are getting null for ImageTypeSpecifier when we use
getRawImageType() API for YCbCr Image.
Root cause : When
