Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-21 Thread Phil Race
Ditto . -phil. On 2/20/2014 11:48 PM, Andrew Brygin wrote: Hello Henry, the fix looks fine to me. Thanks, Andrew On 2/21/2014 1:01 AM, Henry Jen wrote: Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/

Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Andrew Brygin
Hello Henry, the fix looks fine to me. Thanks, Andrew On 2/21/2014 1:01 AM, Henry Jen wrote: Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/ - revert the clone method changes so that return ty

[OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

2014-02-20 Thread Henry Jen
Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/ - revert the clone method changes so that return type remains Object - break long lines - fix fallthrough warnings as Andrew suggested. Cheers, Henr