Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-28 Thread Alan Bateman
On 27/05/2015 18:14, Phil Race wrote: Hi Volker, Sorry for breaking AIX but I think it may be more related to these bugs https://bugs.openjdk.java.net/browse/JDK-8073152 https://bugs.openjdk.java.net/browse/JDK-8073893 8035302 then takes advantage of these but did not create/update the

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-28 Thread Alan Bateman
On 28/05/2015 10:10, Volker Simonis wrote: : Yes, but as I wrote, there is a hard dependency from some of the sun.font classes to some non-standard charsets: sun.font.X11GB2312 - sun.nio.cs.EUC_CN sun.font.X11GBK - sun.nio.cs.GBK sun.font.X11KSC5601 - sun.nio.cs.EUC_KR If I decide that I don't

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-28 Thread Volker Simonis
On Thu, May 28, 2015 at 9:24 AM, Alan Bateman alan.bate...@oracle.com wrote: On 27/05/2015 18:14, Phil Race wrote: Hi Volker, Sorry for breaking AIX but I think it may be more related to these bugs https://bugs.openjdk.java.net/browse/JDK-8073152

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-28 Thread Volker Simonis
On Thu, May 28, 2015 at 11:27 AM, Alan Bateman alan.bate...@oracle.com wrote: On 28/05/2015 10:10, Volker Simonis wrote: : Yes, but as I wrote, there is a hard dependency from some of the sun.font classes to some non-standard charsets: sun.font.X11GB2312 - sun.nio.cs.EUC_CN sun.font.X11GBK

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Volker Simonis
Hi Phil, thanks for looking at this. On Wed, May 27, 2015 at 7:18 PM, Phil Race philip.r...@oracle.com wrote: Oh .. I see how 8035302 would be implicated on AIX. It was the removal of the now redundant wildcard ext imports for the Oracle platforms in the X11 charsets that no longer mattered

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Phil Race
Oh .. I see how 8035302 would be implicated on AIX. It was the removal of the now redundant wildcard ext imports for the Oracle platforms in the X11 charsets that no longer mattered for those but still did for AIX. Most probably what you propose as quick solution is best but I'll defer to

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Phil Race
Hi Volker, Sorry for breaking AIX but I think it may be more related to these bugs https://bugs.openjdk.java.net/browse/JDK-8073152 https://bugs.openjdk.java.net/browse/JDK-8073893 8035302 then takes advantage of these but did not create/update the per-platform configuration. I think the

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-05-27 Thread Volker Simonis
Hi everybody, sorry, but as usually, I'm a little late to the game:) This change, along with change 8073152: Update Standard/ExtendedCharsets to work with module system causes build failures on AIX. It took me some time to dig trough the build system, but I think that I at least have a weak

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-04-09 Thread Mandy Chung
On 3/25/15 3:48 PM, Phil Race wrote: Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/ sun/font/XMap.java +jclass = JIS0201; // CHECK +jclass = MS950_HKSCS_XP; // CHECK What is the CHECK comment? Otherwise, looks okay. Thank you for removing java.desktop

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-04-09 Thread Phil Race
Old notes to self from an earlier revision. I'll delete before pushing. -phil. On 04/09/2015 12:25 PM, Mandy Chung wrote: On 3/25/15 3:48 PM, Phil Race wrote: Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/ sun/font/XMap.java +jclass = JIS0201; // CHECK +

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-04-09 Thread Sergey Bylokhov
Hi, Phil. The fix looks good. But probably we can rename MFontConfiguration since dependency on motif was removed? On 26.03.15 1:48, Phil Race wrote: Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/ - removed the jdk.charsets export to java.desktop from modules.xml - removed the

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-04-01 Thread Alan Bateman
On 31/03/2015 22:16, Phil Race wrote: Its a fixed set, but what I have here is using a public means to grab the same information previously obtained from the same internal source by internal means. I do not see it as worth my time to create and test and maintain a map when this should work fine

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-04-01 Thread Phil Race
I asked Sherman about the tests in the last round of review and he said to just delete them -phil. On 04/01/2015 12:21 AM, Alan Bateman wrote: On 31/03/2015 22:16, Phil Race wrote: Its a fixed set, but what I have here is using a public means to grab the same information previously obtained

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-31 Thread Phil Race
Its a fixed set, but what I have here is using a public means to grab the same information previously obtained from the same internal source by internal means. I do not see it as worth my time to create and test and maintain a map when this should work fine and should be at least as robust as a

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-26 Thread Xueming Shen
On 3/26/15 1:11 AM, Alan Bateman wrote: On 25/03/2015 22:48, Phil Race wrote: Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/ - removed the jdk.charsets export to java.desktop from modules.xml - removed the COMPOUND_TEXT support which likely has not been used since Motif support

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-26 Thread Alan Bateman
On 26/03/2015 16:28, Xueming Shen wrote: An alternative is to simply grip the names and build a small internal mapping for those used by the fonts, it's a limited/small/fixed list, I assume. That might be look better than the current hacky one. So a small name - historical name map? If that

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-25 Thread Phil Race
Updated webrev http://cr.openjdk.java.net/~prr/8035302.2/ - removed the jdk.charsets export to java.desktop from modules.xml - removed the COMPOUND_TEXT support which likely has not been used since Motif support was removed -phil. On 3/20/15 2:39 PM, Phil Race wrote: On 3/19/15 8:19 PM,

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-20 Thread Phil Race
On 3/19/15 8:19 PM, Mandy Chung wrote: On 03/16/2015 02:32 PM, Phil Race wrote: Here is an updated fix that instead of removing the sun.nio dependency instead removes the jdk.charsets static dependency. From the internal API point of view its sun.nio.cs.ext that is the issue, not sun.nio

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-19 Thread Mandy Chung
On 03/16/2015 02:32 PM, Phil Race wrote: Here is an updated fix that instead of removing the sun.nio dependency instead removes the jdk.charsets static dependency. From the internal API point of view its sun.nio.cs.ext that is the issue, not sun.nio

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-19 Thread Phil Race
Any comments ? -phil. On 03/16/2015 02:32 PM, Phil Race wrote: Here is an updated fix that instead of removing the sun.nio dependency instead removes the jdk.charsets static dependency. From the internal API point of view its sun.nio.cs.ext that is the issue, not sun.nio

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-03-16 Thread Phil Race
Here is an updated fix that instead of removing the sun.nio dependency instead removes the jdk.charsets static dependency. From the internal API point of view its sun.nio.cs.ext that is the issue, not sun.nio http://cr.openjdk.java.net/~prr/8035302.1/ -phil. On 2/21/15 1:02 AM, Alan Bateman

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-19 Thread Phil Race
Sigh .. try this URL http://cr.openjdk.java.net/~prr/8035302/ The other is inaccessible and not right anyway. -phil. On 2/19/15 4:23 PM, Phil Race wrote: http://javaweb.us.oracle.com/~prrace/8035302/ https://bugs.openjdk.java.net/browse/JDK-8035302 With this change, for the benefit of

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-19 Thread Mandy Chung
On 2/19/2015 8:57 PM, Phil Race wrote: On 2/19/15 8:50 PM, Mandy Chung wrote: On 2/19/2015 4:23 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8035302/ I'll let Sherman and others to do the detailed review here. Minor comment: FontDescriptor.java line 56-58: can use

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-19 Thread Phil Race
On 2/19/15 8:50 PM, Mandy Chung wrote: On 2/19/2015 4:23 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8035302/ I'll let Sherman and others to do the detailed review here. Minor comment: FontDescriptor.java line 56-58: can use try-with-resource. Its a ByteArrayInputStream

[OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

2015-02-19 Thread Phil Race
http://javaweb.us.oracle.com/~prrace/8035302/ https://bugs.openjdk.java.net/browse/JDK-8035302 With this change, for the benefit of jigsaw, the Charset support needed by the font code now uses just the public APIs. Some utility code was copied from sun.nio - some of which could perhaps have