Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

On 11/24/15, 11:20 AM, Sergey Bylokhov wrote: On 23.11.15 23:20, Philip Race wrote: Not sure if you are suggesting TK.createImage migrate to Image I/O to keep them in sync ? Yes, I suggest to drop the old decoders and replace them by imageio. As I mentioned in a separate thread there are

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

On 23.11.15 23:20, Philip Race wrote: Not sure if you are suggesting TK.createImage migrate to Image I/O to keep them in sync ? Yes, I suggest to drop the old decoders and replace them by imageio. Note that already BMP and WBMP are supported only via image I/O and there is no notion of

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

The fix looks fine. Note that this change implement the new SPI readers for ImageIO. But as far as I understand it does not add support of the tiff format to the Toolkit.createImage which use old decoders. I think it is necessary to delete support of old decoders and to replace it with spi?

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

OK. "Approved" in case there is any doubt on that. -phil. On 11/20/15, 7:35 AM, Brian Burkhalter wrote: On Nov 19, 2015, at 7:41 PM, Philip Race > wrote: The changes to pre-existing files look good although it is not apparent to me

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

On Nov 19, 2015, at 7:41 PM, Philip Race wrote: > The changes to pre-existing files look good although it is not apparent > to me why you deleted this in iio-plugin.properties > SimpleRenderedImage0=The provided region doesn't intersect with the image > bounds > is it

[OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

Please review at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-8143342 Webrev: http://cr.openjdk.java.net/~bpb/8143342/8143342.00/ This review request pertains to the changes required to integrate Java Image I/O support for TIFF into JDK 9. The two branches of the webrev,

Re: [OpenJDK 2D-Dev] RFR: 8143342: Integrate Java Image I/O support for TIFF per JEP 262

The changes to pre-existing files look good although it is not apparent to me why you deleted this in iio-plugin.properties SimpleRenderedImage0=The provided region doesn't intersect with the image bounds is it just not used ? The rest I barely "skimmed" but I give it a go. -phil. On