ok
+1
On 21.10.16 23:11, Brian Burkhalter wrote:
Barring objections to the contrary I am inclined to go with webrev.00.
There is no precedent in the public javax.imageio.plugins classes for
making getters and the like final. Note also that BMPImageWriteParam,
JPEGImageReadParam, and JPEGImageWri
Barring objections to the contrary I am inclined to go with webrev.00. There is
no precedent in the public javax.imageio.plugins classes for making getters and
the like final. Note also that BMPImageWriteParam, JPEGImageReadParam, and
JPEGImageWriteParam and not final either.
Thanks,
Brian
On
One could potentially change all the public getters in non-final classes in
javax.imageio.plugins.tiff to be final as in
http://cr.openjdk.java.net/~bpb/8165981/webrev.01/
or go even further and additionally refactor TIFFDirectory to be an interface
implemented by the internal TIFFIFD class. In
Probably some methods can be made final also (at least setters and getters)?
because it always a problem when we validate something in the
setter(constructor), but the user returns something unspecified from the
overriden getter.
On 03.10.16 22:51, Brian Burkhalter wrote:
Good point. I think
Good point. I think TIFFIFD needs to be a subclass therefore lets leave
TIFFDirectory as is.
Thanks,
Brian
On Oct 3, 2016, at 12:44 PM, Phil Race wrote:
> > Question is whether TIFFDirectory might be made final as well.
>
> com.sun.imageio.plugins.tiff.TIFFIFD extends TIFFDirectory so that
Ok to the two you are making final.
> Question is whether TIFFDirectory might be made final as well.
com.sun.imageio.plugins.tiff.TIFFIFD extends TIFFDirectory so that
is more than a case of marking it final.
Therefore it at least depends on whether you think that internal subclass
really needs
A trivial change, code-wise:
--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java
+++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java
@@ -261,7 +261,7 @@
* @see TIFFDirectory
* @see TIFFTag
*/
-public class TIFFField implements Cloneab
