On Fri, 2 Apr 2021 00:12:58 GMT, Sergey Bylokhov wrote:
>> I do not suggest that the change should be moved forth and back, but I think
>> that the second conditions should always be shifted, and if this causes 80
>> chars overflow then some other line split/rename/etc should be done to
>> pre
On Thu, 1 Apr 2021 17:29:08 GMT, Sergey Bylokhov wrote:
>>> I would prefer if you revert this line or if we want to put emphasis on
>>> readability moving '{' to new line also seems fine.
>>
>> Done.
>
> I do not suggest that the change should be moved forth and back, but I think
> that the se
On Thu, 1 Apr 2021 17:29:08 GMT, Sergey Bylokhov wrote:
>>> I would prefer if you revert this line or if we want to put emphasis on
>>> readability moving '{' to new line also seems fine.
>>
>> Done.
>
> I do not suggest that the change should be moved forth and back, but I think
> that the se
On Thu, 1 Apr 2021 13:28:50 GMT, Alexey Ivanov wrote:
>>> By mapping i mean same indentation for all conditions in if statement…
>>
>> Okay, it's the first time I've come across to such a use of `map`.
>>
>>> I have not come across code in java.desktop where we add indentation at
>>> each cont
On Thu, 1 Apr 2021 13:19:07 GMT, Alexey Ivanov wrote:
>> I would prefer if you revert this line or if we want to put emphasis on
>> readability moving '{' to new line also seems fine.
>
>> By mapping i mean same indentation for all conditions in if statement…
>
> Okay, it's the first time I've
On Thu, 1 Apr 2021 13:28:48 GMT, Alexey Ivanov wrote:
>> When `getAllPrinterNames()` returns null, the list of `printServices` is
>> assigned a new empty array without invalidating old services which were in
>> the array before.
>>
>> The old print services should be invalidated.
>
> Alexey Iv
> When `getAllPrinterNames()` returns null, the list of `printServices` is
> assigned a new empty array without invalidating old services which were in
> the array before.
>
> The old print services should be invalidated.
Alexey Ivanov has updated the pull request incrementally with one additio
