Re: [OpenJDK 2D-Dev] Please review change in regression test sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java

2010-09-13 Thread Artem Ananiev
Hi, Pavel, indeed, the names are confusing. Your changes look correct. Thanks, Artem On 9/10/2010 2:12 PM, Pavel Tisnovsky wrote: Hi, can anybody please review the simple change in regression test sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java? Webrev contai

[OpenJDK 2D-Dev] Fixes for two bugs in stroker

2010-09-13 Thread Omair Majid
Hi, A while ago I filed http://bugs.openjdk.java.net/show_bug.cgi?id=100046 and http://bugs.openjdk.java.net/show_bug.cgi?id=100047 which contain fixes for two bugs in lines drawn by the Stroker. Will someone be kind enough to review these patches? The bug reports contain patches and images sho

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-09-13 Thread Denis Lila
Hello Jim. I think I finally have a version without correctness problems: http://icedtea.classpath.org/~dlila/webrevs/noflatten/webrev/ Assuming no bugs, there are still a few minor issues: - whitespace (I'll fix this tomorrow) - comments (also tomorrow) - in dasher, there are variables called sx

Re: [OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces

2010-09-13 Thread Jim Graham
Hi Denis, sx1,sy1 have lost their way along the way somewhere. Here is the thing I think they may have once been used for that seems to be gone now... - If the first dash starts in the middle of an "on" phase then you shouldn't send it to the output right away. Remember its segments until