Re: Re: PATCH: ServerSide buttons are back

2006-12-12 Thread Simon Lessard
A new component library could be nice indeed. On 12/12/06, Adam Winer [EMAIL PROTECTED] wrote: Maybe we could pull all of the image generation code out of trinidad-impl and into a third library? I really want it out of the main library - for a totally unused API, it adds a lot of code. --

Re: PATCH: ServerSide buttons are back

2006-12-11 Thread Mark Robinson
So I've cleaned up my patch. I've removed the dependence on trinidadinternal.ui and I've added some classes which I needed to implement server side buttons. Mark Mark Robinson wrote: Hi, I've written up a patch which will enable the use of server generated buttons in tr:commandButtons.

Re: PATCH: ServerSide buttons are back

2006-12-06 Thread Mark Robinson
So I've cleaned up my patch. I've removed the dependence on trinidadinternal.ui and I've added some classes which I needed to implement server side buttons. Mark Adam Winer wrote: On 12/5/06, Mark Robinson [EMAIL PROTECTED] wrote: Adam, By myfaces.ui, do you mean trinidadinternal.ui?

Re: PATCH: ServerSide buttons are back

2006-12-05 Thread Mark Robinson
Adam, By myfaces.ui, do you mean trinidadinternal.ui? Is there a reason for getting rid of it? Also, is there migration documentation? Ie, class X is gone, use class Y and Z. Thanks, Mark Adam Winer wrote: Mark, It's not OK for anything in myfaces.trinidadinternal.renderkit to have

Re: Re: PATCH: ServerSide buttons are back

2006-12-05 Thread Adam Winer
On 12/5/06, Mark Robinson [EMAIL PROTECTED] wrote: Adam, By myfaces.ui, do you mean trinidadinternal.ui? Oops, yes. Is there a reason for getting rid of it? Also, is there migration documentation? Ie, class X is gone, use class Y and Z. It is ancient legacy code - based on UIX - that has

Re: PATCH: ServerSide buttons are back

2006-12-05 Thread Scott O'Bryan
Mark, Yes, he means trinidadinternal.ui. The reason we are getting rid of this is basically a historical reason. These classes are basically a set of adapters designed to port Oracle's old UIX component base over to Faces. As the components were enhanced and expanded, we started turning

Re: PATCH: ServerSide buttons are back

2006-12-05 Thread Jeanne Waldman
Hi all, Have we decided that we want to keep the image generation code around, then? Looking back at old emails, it sounds like a couple of people want to keep the rounded-buttons. Thanks, Jeanne Scott O'Bryan wrote: Mark, Yes, he means trinidadinternal.ui. The reason we are getting rid

Re: PATCH: ServerSide buttons are back

2006-12-04 Thread Adam Winer
Mark, It's not OK for anything in myfaces.trinidadinternal.renderkit to have dependencies on code in myfaces.ui; our goal is to kill all code in myfaces.ui. So, for example: import org.apache.myfaces.trinidadinternal.ui.UIXRenderingContext; import