Re: Patches

2007-02-14 Thread Scott O'Bryan
Yeah, thanks anyway Jeanne. Adam is on the ball. :) Jeanne Waldman wrote: Oh, I see Adam already did this. Thanks Adam. Jeanne Waldman wrote: Scott, I'll do my best to review your patches and check them into trunk and the JSF 1.2 branch. It would be great if someone else can give

Patches

2007-02-13 Thread Scott O'Bryan
Can someone please take a look at the patches for the following JIRA issues and give me your feedback so that we can get these merged into the JSF 1.2 branch and trunk? ADFFACES-374 ADFFACES-379 Thanks. Scott O'Bryan

Re: Patches

2007-02-13 Thread Jeanne Waldman
Scott, I'll do my best to review your patches and check them into trunk and the JSF 1.2 branch. It would be great if someone else can give their feedback, since I'm not that familiar with what you are doing here.. Thanks, - Jeanne Scott O'Bryan wrote: Can someone please take a look

Re: Patches

2007-02-13 Thread Jeanne Waldman
Oh, I see Adam already did this. Thanks Adam. Jeanne Waldman wrote: Scott, I'll do my best to review your patches and check them into trunk and the JSF 1.2 branch. It would be great if someone else can give their feedback, since I'm not that familiar with what you are doing here.. Thanks

Re: Pending PDA Patches

2006-09-22 Thread Piyush Hari
Hey Joey, I just realised that I had submitted patches for panelradio and panelChoice which had dependencies on other issues being commited. I cancelled those patches after I read Jeanne's and your e-mails. Thanks, Piyush - Original Message - From: Joseph Rozier [EMAIL PROTECTED

Re: Pending PDA Patches

2006-09-21 Thread Jeanne Waldman
this new patch would get reviewed until the first patch that it depends on gets checked in. So then when we review the second patch, the differences won't be the differences of both patches, just the second patch. - Jeanne Joseph Rozier wrote: Hello, I'm resending this since there was no response

Re: Pending PDA Patches

2006-09-21 Thread Jeanne Waldman
the first patch that it depends on gets checked in. So then when we review the second patch, the differences won't be the differences of both patches, just the second patch. - Jeanne Joseph Rozier wrote: Hello, I'm resending this since there was no response to the first one... I'd particularly

Re: Pending PDA Patches

2006-09-15 Thread Joseph Rozier
patches would be appreciated as well. :)) Thanks, Joey On 9/13/06, Joseph Rozier [EMAIL PROTECTED] wrote: Hello, The following two JIRAs have patches waiting to be reviewed/committed. https://issues.apache.org/jira/browse/ADFFACES-167 Add 'autoSubmit' support for basic input components on PDAs

Pending PDA Patches

2006-09-13 Thread Joseph Rozier
Hello, The following two JIRAs have patches waiting to be reviewed/committed. https://issues.apache.org/jira/browse/ADFFACES-167 Add 'autoSubmit' support for basic input components on PDAs https://issues.apache.org/jira/browse/ADFFACES-110 Add Agent for BlackBerry Browser 4.0 (this has a fix

PDA-Related Patches Available

2006-08-21 Thread Joseph Rozier
Hello, I've got patches available for three PDA-related issues. Any chance these could get reviewed and committed, or do I need to do something else first? Avoid Hardcoding Height and Width Capabilities https://issues.apache.org/jira/browse/ADFFACES-130 Improve Font Appearance on BlackBerry