Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-30 Thread Jeanne Waldman
Adam, I just noticed this email. I'll ping Scott. - Jeanne Adam Winer wrote: Has this change been tested? I'm far from certain that this was purely an optimization. We often check whether there is a PartialPageContext to see if PPR is enabled, and if this check is removed, then a lot of code

Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-30 Thread Scott O'Bryan
Yeah sorry, I didn't notice the comment either. I updates the JIRA ticket. You're correct Adam, and I need some advice on the ticket if you could. Jeanne Waldman wrote: Adam, I just noticed this email. I'll ping Scott. - Jeanne Adam Winer wrote: Has this change been tested? I'm far from

Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-25 Thread Adam Winer
Has this change been tested? I'm far from certain that this was purely an optimization. We often check whether there is a PartialPageContext to see if PPR is enabled, and if this check is removed, then a lot of code will (I think) assume that PPR is enabled and available when it is not. --