thanks for checking this in for me.
I filed issue
http://issues.apache.org/jira/browse/ADFFACES-243
so that the renderers for UIXTree and UIXTreeTable can take advantage of
this new api to prune the client-rowkey map when nodes are collapsed. at
the moment this client-rowkey cache grows
I made a few minor changes to this as reported on
http://issues.apache.org/jira/browse/ADFFACES-210
On 10/15/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote:
I've updated
http://issues.apache.org/jira/browse/ADFFACES-210
with this discussion and a patch.
let me know what you think.
On 10/9/06,
I was trying to implement this, and immediately ran into the following
issue:
The new Renderer was storing the clientRowKey-ServerRowKey cache as a
private attribute on the component.
but this fails when the component is inside a stamping container (ie: nested
table case).
The rowkey cache must
sorry, that last method has to be public (Renderer needs access to it during
encodeBegin to do pruning).
so UIXCollection has:
public String getClientRowKey()
public void setClientRowKey(String clientKey)
public final ClientRowKeyManager getClientRowKeyManager()
On 10/9/06, Arjuna Wijeyekoon
YES!!
(I've always found currency to be about the most confusing
term imaginable.)
-- Adam
On 10/7/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote:
after this is checked in, I want to start a new thread to rename
UIXCollection.get/setCurrencyString to
UIXCollection.get/setClientRowKey
I decided to call this
ClientRowKeyManager:
public String getClientRowKey(FacesContext, UIComponent table, Object
rowKey);
public Object getRowKey(FacesContext, UIComponent table, String
clientRowKey);
what d'ya think?
On 10/4/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote:
If you're having
after this is checked in, I want to start a new thread to rename
UIXCollection.get/setCurrencyString to
UIXCollection.get/setClientRowKey
does this make sense?
On 10/7/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote:
I decided to call this
ClientRowKeyManager:
public String
Adam,
In the absence, we should have a default implementation
that is exactly the current implementation, and table/tree/treeTable
can all use it. Maybe a protected getRowKeyManagingRenderer()
hook up on UIXCollection that provides this?
the current implementation clears the cache at the start
I'd like to have the name of the interface end in Renderer,
so it's obvious that Renderers are supposed to implement
it. So, maybe RowKeyManagingRenderer?
In the absence, we should have a default implementation
that is exactly the current implementation, and table/tree/treeTable
can all use it.
http://issues.apache.org/jira/browse/ADFFACES-210
On 9/26/06, Matthias Wessendorf [EMAIL PROTECTED] wrote:
sorry for the delay.
Not sure if I got it completely, but your suggestion to move that
stuff from UIXColl. to a Renderer API makes pretty much sense. At
least from that what I
What would you like to call this new Renderer interface?
Is RowKeyStringManager ok?
Also, in the absence of a RowKeyStringManager what should the
table/tree/treeTable do
when get/setCurrencyString() is called?
1. throw an exception
2. return the index as the string key (this will work for
sorry for the delay.
Not sure if I got it completely, but your suggestion to move that
stuff from UIXColl. to a Renderer API makes pretty much sense. At
least from that what I understand.
The customized treeTable support might be much much more important,
when all of the renderer api overhauls
ok, I will file a jira.
hi,
anyone like to comment on this? feel free :)
--arjuna
On 9/22/06, Arjuna Wijeyekoon [EMAIL PROTECTED] wrote:
Folks,
Currently the UIXCollection class (which is the super class for
table/tree/treeTable) maintains a mapping between
Object rowkeys and String tokens.
see
private
14 matches
Mail list logo
