[frameworks-kio] [Bug 401514] Application with invalid work path silently fails to launch

https://bugs.kde.org/show_bug.cgi?id=401514 Ahmad Samir changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO Resolution

[frameworks-kio] [Bug 401510] Occasional plasmashell crash in KIO::DropJob::setApplicationActions() when dragging files to desktop

https://bugs.kde.org/show_bug.cgi?id=401510 Ahmad Samir changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution

[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files

https://bugs.kde.org/show_bug.cgi?id=422189 --- Comment #3 from Ahmad Samir --- (In reply to Méven Car from comment #2) [..] > > Still we tru to dectect orhpaned files such as here where we have the > metadata but not the files. Your bug shows it does not clean its record, > once it

[frameworks-kio] [Bug 422189] kf5.kio.trash stats thousands of files in ~/.local/share/Trash/files

https://bugs.kde.org/show_bug.cgi?id=422189 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com

[frameworks-kwallet] [Bug 422149] KDE Wallet won't unlock / can't recognize my password

https://bugs.kde.org/show_bug.cgi?id=422149 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com

[frameworks-kio] [Bug 309192] KIO turns slash character ("/") into "⁄" when writing file names--but not directory names

https://bugs.kde.org/show_bug.cgi?id=309192 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #6 from Ahmad

[frameworks-kio] [Bug 386406] Doubly encoded URL sent to proxy

https://bugs.kde.org/show_bug.cgi?id=386406 Ahmad Samir changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

[konsole] [Bug 419526] Qt5.15 Crash on right click

https://bugs.kde.org/show_bug.cgi?id=419526 --- Comment #13 from Ahmad Samir --- @Fabian: I am sorry, I forgot to credit you in the commit message, you basically pin-pointed the responsible code in Konsole. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-kio] [Bug 422094] KIO spams login dialogs

https://bugs.kde.org/show_bug.cgi?id=422094 Ahmad Samir changed: What|Removed |Added Resolution|--- |DUPLICATE CC

[dolphin] [Bug 420911] Authentication dialog to access a Samba share always re-appears together a pointiless "Examining" notification after canceling

https://bugs.kde.org/show_bug.cgi?id=420911 Ahmad Samir changed: What|Removed |Added CC||linus.kardell+kdebugs@gmail

[konqueror] [Bug 178806] Sending SSL Own Certificates for Authentification with sites doesn't work at all

https://bugs.kde.org/show_bug.cgi?id=178806 Bug 178806 depends on bug 167668, which changed state. Bug 167668 Summary: client certificate authentication disabled (KIO::TCPSlaveBase::selectClientCertificate under #if 0), causes handshake error https://bugs.kde.org/show_bug.cgi?id=167668

[frameworks-kio] [Bug 167668] client certificate authentication disabled (KIO::TCPSlaveBase::selectClientCertificate under #if 0), causes handshake error

https://bugs.kde.org/show_bug.cgi?id=167668 Ahmad Samir changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[frameworks-kio] [Bug 58530] flaws in digest authentication implementation

https://bugs.kde.org/show_bug.cgi?id=58530 Ahmad Samir changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC

[frameworks-kio] [Bug 414410] "Open containing folder feature" using KIO::highlightInFileManager() does not work in Windows

https://bugs.kde.org/show_bug.cgi?id=414410 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Status

[frameworks-kio] [Bug 409607] Dolphin crashes due to nested eventloops of the RenameDialog

https://bugs.kde.org/show_bug.cgi?id=409607 Ahmad Samir changed: What|Removed |Added Summary|Dolphin crashes after |Dolphin crashes due

[frameworks-kio] [Bug 400469] Wrong character representation in file names with slash

https://bugs.kde.org/show_bug.cgi?id=400469 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #4 from Ahmad

D29362: [KCharSelect] Initially give focus to the search lineedit

ahmadsamir added a comment. Moved to https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/2 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29362 To: ahmadsamir, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29362: [KCharSelect] Initially give focus to the search lineedit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:c0c93cc0fcb5: [KCharSelect] Initially give focus to the search lineedit (authored by ahmadsamir). REPOSITORY R236

[frameworks-kio] [Bug 402276] Dolphin transfer speeds significantly slower than other file managers

https://bugs.kde.org/show_bug.cgi?id=402276 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #7 from Ahmad

[frameworks-kio] [Bug 421374] Service file specifiying 'Run in terminal' gives "Error code 100, Could not find the program ‘konsole’" after Plasma 5.18.5 update.

https://bugs.kde.org/show_bug.cgi?id=421374 Ahmad Samir changed: What|Removed |Added CC||samoht0-bugzi...@yahoo.com --- Comment #23 from

[frameworks-kio] [Bug 422270] Desktop link files with Terminal=true don't work after KDE Frameworks 5.70.0 update

https://bugs.kde.org/show_bug.cgi?id=422270 Ahmad Samir changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[frameworks-kio] [Bug 406510] Associating .html with Kwrite will not open it with others in "Open With"

https://bugs.kde.org/show_bug.cgi?id=406510 Ahmad Samir changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[Discover] [Bug 419967] Updating KIO libs requires executing kdeinit5 to pick up the new libs

https://bugs.kde.org/show_bug.cgi?id=419967 Ahmad Samir changed: What|Removed |Added Summary|Updating KIO libs requires |Updating KIO libs requires

[frameworks-kio] [Bug 377978] Unable to create new folder named "~" without using escape character

https://bugs.kde.org/show_bug.cgi?id=377978 Ahmad Samir changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit

[plasmashell] [Bug 417745] Relatively high CPU usage when attempting to copy/paste a file with an existing name.

https://bugs.kde.org/show_bug.cgi?id=417745 Ahmad Samir changed: What|Removed |Added Version|5.67.0 |5.18.90 Assignee|fa...@kde.org

[frameworks-kio] [Bug 418984] RenameDialog shows '%2520' in file name labels instead of '%20'

https://bugs.kde.org/show_bug.cgi?id=418984 Ahmad Samir changed: What|Removed |Added Version|5.6.0 |5.70.0 -- You are receiving this mail because

[frameworks-kio] [Bug 418984] RenameDialog shows '%2520' in file name labels instead of '%20'

https://bugs.kde.org/show_bug.cgi?id=418984 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Summary|Copying

[frameworks-kio] [Bug 197276] Provide a user-friendly error when attempting to change only the case of a file located on a case-insensitive filesystem

https://bugs.kde.org/show_bug.cgi?id=197276 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Resolution

[frameworks-kio] [Bug 262551] Changing the keyboard shortcut to view hidden files in Dolphin does not affect the file/open dialogs

https://bugs.kde.org/show_bug.cgi?id=262551 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #13 from Ahmad

[frameworks-kio] [Bug 273745] Dolphin shows incorrect partition usage

https://bugs.kde.org/show_bug.cgi?id=273745 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #5 from Ahmad

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1009 > +if (QDir::isAbsolutePath(binaryName)) { > +QFileInfo fi(binaryName); > +if (fi.exists() && !fi.isExecutable()) { It's created on the next line. Anyway my initial comment

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Actually, that doesn't exist https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc:

[frameworks-kio] [Bug 365850] Glitch in copy/move dialog window

https://bugs.kde.org/show_bug.cgi?id=365850 Ahmad Samir changed: What|Removed |Added Resolution|--- |WORKSFORME CC

[frameworks-kio] [Bug 373352] file open / save / save as dialog is slow if automounted filesystems are not available (nfs, smb, etc )

https://bugs.kde.org/show_bug.cgi?id=373352 Ahmad Samir changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO CC

[frameworks-kio] [Bug 373658] KDEInit could not launch 'konsole'

https://bugs.kde.org/show_bug.cgi?id=373658 Ahmad Samir changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution

[frameworks-kio] [Bug 375604] Create new Link to application's name unchangeable

https://bugs.kde.org/show_bug.cgi?id=375604 Ahmad Samir changed: What|Removed |Added Resolution|--- |WORKSFORME CC

[konsole] [Bug 419526] Qt5.15 Crash on right click

https://bugs.kde.org/show_bug.cgi?id=419526 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #10 from Ahmad

[frameworks-kio] [Bug 376949] Link to NFS location complains that it's already mounted when accessed a second time

https://bugs.kde.org/show_bug.cgi?id=376949 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Resolution

[frameworks-kio] [Bug 376679] chaning mimeapps.list is not respected by folderview unless you restart Xorg

https://bugs.kde.org/show_bug.cgi?id=376679 Ahmad Samir changed: What|Removed |Added Status|REOPENED|NEEDSINFO CC

[umbrello] [Bug 373928] KF5 installed file conflicts with related files from KDE4

https://bugs.kde.org/show_bug.cgi?id=373928 Bug 373928 depends on bug 377686, which changed state. Bug 377686 Summary: Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation https://bugs.kde.org/show_bug.cgi?id=377686 What|Removed

[frameworks-kio] [Bug 377686] Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation

https://bugs.kde.org/show_bug.cgi?id=377686 Ahmad Samir changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC

[umbrello] [Bug 373928] KF5 installed file conflicts with related files from KDE4

https://bugs.kde.org/show_bug.cgi?id=373928 Bug 373928 depends on bug 377687, which changed state. Bug 377687 Summary: Installed name of kioslave conflicts with related KDE4 installation https://bugs.kde.org/show_bug.cgi?id=377687 What|Removed |Added

[frameworks-kio] [Bug 377687] Installed name of kioslave conflicts with related KDE4 installation

https://bugs.kde.org/show_bug.cgi?id=377687 Ahmad Samir changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution

[frameworks-kio] [Bug 421878] LocalDomainUriFilter::filterUri prepends 'http://' in the event of a dns lookup timeout (QHostInfo)

https://bugs.kde.org/show_bug.cgi?id=421878 Ahmad Samir changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

[frameworks-kio] [Bug 381667] Please allow kuiserver to be built separately without additional dependencies

https://bugs.kde.org/show_bug.cgi?id=381667 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #16 from Ahmad

[frameworks-kio] [Bug 388471] Open in file manager doesn't work for superfloppies

https://bugs.kde.org/show_bug.cgi?id=388471 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Status|REPORTED

[frameworks-kio] [Bug 390297] Improve support for saving screenshots remotely

https://bugs.kde.org/show_bug.cgi?id=390297 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Status|REPORTED

[frameworks-kio] [Bug 386042] Only one attempt to enter correct password; it will not be asked a second time

https://bugs.kde.org/show_bug.cgi?id=386042 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com

[frameworks-kio] [Bug 386822] unreferenced local variable warning in netpref.cpp

https://bugs.kde.org/show_bug.cgi?id=386822 Ahmad Samir changed: What|Removed |Added Status|REPORTED|RESOLVED CC

[frameworks-kio] [Bug 390517] Opening Sambashares from applications menu results in application crash

https://bugs.kde.org/show_bug.cgi?id=390517 Ahmad Samir changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[frameworks-kio] [Bug 421878] LocalDomainUriFilter::filterUri prepends 'http://' in the event of a dns lookup timeout (QHostInfo)

https://bugs.kde.org/show_bug.cgi?id=421878 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Ever confirmed|0

[kio-extras] [Bug 421914] Notification from Dolphin shows wrong amount of deleted files when I delete a folder located in a Samba share

https://bugs.kde.org/show_bug.cgi?id=421914 Ahmad Samir changed: What|Removed |Added CC||k...@privat.broulik.de -- You are receiving

[frameworks-kio] [Bug 390517] Opening Sambashares from applications menu results in application crash

https://bugs.kde.org/show_bug.cgi?id=390517 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com Status|REPORTED

[frameworks-kio] [Bug 417851] Status bar shows free space in file system as "unknown" when Dolphin is opened via context menu of desktop

https://bugs.kde.org/show_bug.cgi?id=417851 Ahmad Samir changed: What|Removed |Added Version Fixed In||5.19.80 Resolution

[frameworks-kio] [Bug 420985] KIO::mostLocalUrl shouldn't actually stat remote slaves

https://bugs.kde.org/show_bug.cgi?id=420985 Ahmad Samir changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

[kio-extras] [Bug 421914] Notification from Dolphin shows wrong amount of deleted files when I delete a folder located in a Samba share

https://bugs.kde.org/show_bug.cgi?id=421914 Ahmad Samir changed: What|Removed |Added Product|frameworks-kio |kio-extras Component|general

[kio-extras] [Bug 422001] KF5 5.70.0 regression: Dolphin shows same SMB share twice

https://bugs.kde.org/show_bug.cgi?id=422001 Ahmad Samir changed: What|Removed |Added CC||sit...@kde.org -- You are receiving this mail

[kio-extras] [Bug 422001] KF5 5.70.0 regression: Dolphin shows same SMB share twice

https://bugs.kde.org/show_bug.cgi?id=422001 Ahmad Samir changed: What|Removed |Added Version|5.70.0 |unspecified Assignee|fa...@kde.org

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir). CHANGED

[frameworks-kcmutils] [Bug 421566] System setting crash

https://bugs.kde.org/show_bug.cgi?id=421566 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #14 from Ahmad

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. I guess a proper fix will need to revert part of this to have the KModuleInfo ctor that took a KService not use KPluginInfo internally; better still, of course, is having the KPluginInfo ctor work for the case of X-KDE-ServiceTypes=SystemSettingsExternalApp, (I

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

ahmadsamir added a comment. systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid

D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir commandeered this revision. ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. Should be handled by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28673: [PackageUrlInterceptor] Make QRegularExpression static

ahmadsamir abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: ahmadsamir, #plasma, broulik Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

[frameworks-kio] [Bug 94781] When only files are copied, they are unnecessarily counted before the transfer begins which wastes a lot of time

https://bugs.kde.org/show_bug.cgi?id=94781 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #9 from Ahmad

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e3b251fd5b06: [IconApplet] Port KRun to ApplicationLauncherJob (authored by ahmadsamir). REPOSITORY R120 Plasma

[frameworks-kio] [Bug 421052] Cannot copy folder to NTFS partition

https://bugs.kde.org/show_bug.cgi?id=421052 Ahmad Samir changed: What|Removed |Added CC||a.samir...@gmail.com --- Comment #1 from Ahmad

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir updated this revision to Diff 83017. ahmadsamir added a comment. Remove one include REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29687?vs=82943=83017 BRANCH l-krun-port (branched from master) REVISION DETAIL

D29800: Fix URL being passed as argument when launching a .desktop file

ahmadsamir added a comment. In D29800#672399 , @fvogt wrote: > Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec LGTM. REPOSITORY R241 KIO REVISION DETAIL

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir added a comment. In D29558#672395 , @dfaure wrote: > Not committed after all. It was committed, as I had it when I did git pull, but you lucked out, it seemed to have been eaten by the migration to gitlab somehow; I had to

D29787: Fix krununittest

ahmadsamir added a comment. In D29787#672139 , @dfaure wrote: > Let's hope the CI has xterm installed I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird. The CI seems to have xterm available as the unit

D29787: Fix krununittest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29787?vs=82975=83011 REVISION DETAIL

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bed09e39fe24: [kio_file] Handle renaming file A to a on FAT32 filesystems (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29610?vs=82750=83010

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir added a comment. In D29782#672157 , @dfaure wrote: > Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it

D29787: Fix krununittest

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 6452a34cf01d03d316 ,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

ahmadsamir updated this revision to Diff 82974. ahmadsamir retitled this revision from "[StatJob] Change mostLocalUrl to only handle protocols with Class=:local" to "[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs". ahmadsamir edited the summary of this revision. ahmadsamir

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added a comment. In D29385#671987 , @dfaure wrote: > That's the point, a NFS mount *is* a local URL, so we do use QFile for it. And then it takes forever because the kernel has to talk over a socket to answer us. > Yes this is

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added a comment. In D29385#671980 , @dfaure wrote: > It's 3 times faster on my local SSD. > > Now think of a NFS mount on a server from another country I was thinking mostly of QFile when url.isLocalFile() is true, but

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in openurljob.cpp:261 > LOL we're like an old couple, the explicit discussion doesn't actually need > to happen anymore ;) > > OK for everyone else, we're debating whether it's ok to use blocking > local-file I/O like QFile or

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in openurljob.h:120 > You meant, according to > https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members > :) I got the info from a commit in kwidgetsaddons where you "fixed" a

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

ahmadsamir accepted this revision. ahmadsamir added a subscriber: kossebau. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > openurljob.h:120 > + * > + * @param b whether to only show the "open with" dialog. > + */ It seems that we

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Previously mostLocalUrl would check that !url.isLocalFile(), that meant a statjob would be fired for

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:435 > but "desktop file path" is what we're doing. what I believe is happening that > you're actually launching the original file, not the one the icon uses. I tried with: KService::Ptr service =

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir updated this revision to Diff 82943. ahmadsamir added a comment. Address comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29687?vs=82714=82943 BRANCH l-krun-port (branched from master) REVISION DETAIL

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:435 > But why would `serviceByStorageId` work then? > Looks like this needs to be `KService::Ptr(new KService(m_localPath))` then? According to the kservice docs KService::serviceByStorageId() param is "the

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29687 To: ahmadsamir, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf,

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:1052 > I'm confused. We want to solve renaming 'a' to 'A' when 'A' does *not* exist. > > QFile::rename will not overwrite an existing file, so it will do nothing if > dest exists. const QByteArray dest1 =

[frameworks-kwidgetsaddons] [Bug 420287] KFontChooser sometimes selects a non-regular style by default

https://bugs.kde.org/show_bug.cgi?id=420287 --- Comment #8 from Ahmad Samir --- Updating the report here, Plasma 5.18 still uses QFontDialog, so this bug report isn't directly related. However if the ",Regular" bit is removed from kdeglobals, QFontDialog will probably select the w

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #8 from Ahmad Samir --- It turns out that the issue was in how itemMatches() was being called; it was being called too many times. A proposed fix: https://invent.kde.org/kde/okular/-/merge_requests/166 -- You are receiving this mail

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #8 from Ahmad Samir --- It turns out that the issue was in how itemMatches() was being called; it was being called too many times. A proposed fix: https://invent.kde.org/kde/okular/-/merge_requests/166 -- You are receiving this mail

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #7 from Ahmad Samir --- Indeed it is slower... reverting the changes in KTreeViewSearchLine::itemMatches() restores the old behaviour. I am looking at it, so far I don't see anything obvious, other than that QRegExp::FixedString has some

[okular] [Bug 421469] [Regression] Slow search in the contents pane

https://bugs.kde.org/show_bug.cgi?id=421469 --- Comment #7 from Ahmad Samir --- Indeed it is slower... reverting the changes in KTreeViewSearchLine::itemMatches() restores the old behaviour. I am looking at it, so far I don't see anything obvious, other than that QRegExp::FixedString has some

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. Continuing the discussion from IRC, plasma 5.18 branch still uses QFontDialog, so https://bugs.kde.org/show_bug.cgi?id=420287 isn't directly related. However if users remove the ',Regular' bit from kdeglobals, QFontDialog will probably select the wrong style

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. In D29710#670151 , @ahmadsamir wrote: > Also, is it OK to backport https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 and this diff to Plasma/5.18? Scratch that, 5.18 min.

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir added a comment. In D29610#667858 , @dfaure wrote: > OK for now, to fix the unittests. The *real* fix however is to use QFile::rename in kio_file so that this failure to rename doesn't even happen in the first place. > > In this

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

ahmadsamir updated this revision to Diff 82750. ahmadsamir retitled this revision from "[CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming" to "[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems". ahmadsamir edited the summary of this revision.

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. Also, is it OK to backport https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 and this diff to Plasma/5.18? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29710 To: ahmadsamir, #plasma, bport,

<    10   11   12   13   14   15   16   17   18   19   >