---
NEWS | 18 ++
configure.ac | 4 ++--
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 30912c5..acfffb8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,21 @@
+Major changes in 0.12.3:
+
+* monitor client bandwidth and lat
---
server/red_parse_qxl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index 4b39029..65781e7 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
@@ -104,7 +104,7 @@ static size_t red_get_data_chunks_ptr(RedMe
---
server/main_dispatcher.c | 2 +-
server/red_dispatcher.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/main_dispatcher.c b/server/main_dispatcher.c
index 92b0791..e7a451a 100644
--- a/server/main_dispatcher.c
+++ b/server/main_dispatcher.c
@@ -78,7 +78,7
---
server/red_dispatcher.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h
index 4d0d2a8..7d23b11 100644
--- a/server/red_dispatcher.h
+++ b/server/red_dispatcher.h
@@ -43,10 +43,10 @@ void
red_dispatcher_client_monitors_c
---
server/tests/Makefile.am | 8 ++-
server/tests/test_display_base.c | 48 ++---
server/tests/test_display_base.h | 13 +
server/tests/test_display_width_stride.c | 92
4 files changed, 154 insertions(+), 7 deletio
---
server/red_worker.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 14d219b..f047d29 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1279,6 +1279,9 @@ static MonitorsConfig
*monitors_config_getref
---
server/tests/test_display_base.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index 588e960..8657e91 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
@@ -
The situation causing this assert is unknown but it doesn't cause
correctness issues with later rendering, and it is causing an abort.
---
server/red_worker.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 8f3e478..14d219b 10
---
server/red_worker.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index fb736b5..8f3e478 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -1040,7 +1040,7 @@ typedef struct RedWorker {
uint64_t *comma
Feel free to shoot down anything (like the rename for no apparent reason other
then using the word cap)
Alon Levy (9):
server/red_worker:
s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small
comment)
server/red_worker: turn critical (assert) non error into warning
On Wed, 2013-05-15 at 18:05 +0800, bigclouds wrote:
> hi,
> 1.how to know the channel type of a port?
There is no way, since there is a single port, and the order of client
connection to the server is determined by the client, and the ports are
determined by the operating system. You will have to l
On Tue, 2013-05-14 at 07:18 -0400, Marc-André Lureau wrote:
>
> Hi
>
> - Mensaje original -
> >
> > We don't have any keep alive.
>
> Do you know if there is a reason? (perhaps I am missing something obvious)
Not really. I mean, what's the down side, a tiny bit of bandwidth /
wakeups?
On Tue, 2013-05-14 at 17:38 +0800, bigclouds wrote:
> hi,all
> look at the output of netstat, it is after at least 30minutes i
> un-plug cable.
> how to make server know client's disconnect and disconnect
> channels(clean channels).
>
>
> tcp0 0 192.168.5.240:5903 192.168.5
Sorry for the noise, brain fart.
On Mon, 2013-05-13 at 14:01 +0300, Alon Levy wrote:
> ACK from me.
>
> Soren, are you ok with this?
>
> On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote:
> > Signed-off-by: Jeremy White
> > ---
> >
> > This i
ACK from me.
Soren, are you ok with this?
On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
>
> This is the controversial patch; see previous conversation here:
> http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html
>
> I feel
Makes it easier to debug situations where the source and target have
different ram blocks in a device and migration fails due to that, for
instance a BAR size change on a PCI device.
Signed-off-by: Alon Levy
---
v3: use RAM_ADDR_FMT
arch_init.c | 3 +++
1 file changed, 3 insertions(+)
diff
t; כדי לבטל את המנוי לקבוצה הזו ולהפסיק לקבל ממנה הודעות דוא"ל, שלח הודעת דוא"ל
> אל hasadna+unsubscr...@googlegroups.com.
> כדי לפרסם הודעות בקבוצה זו, שלח דוא"ל ל-hasa...@googlegroups.com.
> לאפשרויות נוספות בקר ב-https://groups.google.com/groups/opt_out.
>
>
--
Alon Levy
___
arig-discuss mailing list
arig-discuss@lists.subsignal.org
https://lists.subsignal.org/mailman/listinfo/arig-discuss
red_create_stream is called even without any client but there is no
encoding since the mjpeg encoder is now associated with StreamAgent
which is only created when we have a client.
---
server/red_worker.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.
The following changes since commit 909eedb74f88d1d6d9e6bbdc34875772e7a8a5ab:
target-ppc: slightly optimize lfiwax (2013-04-27 00:37:46 +0200)
are available in the git repository at:
git://people.freedesktop.org/~alon/qemu libcacard_ccid.2
for you to fetch changes up to ae12e3a643c66575c7721
fetch changes up to 203a368e66f5211b832e17b85c6f5dacfc8d7bf9:
libcacard/cac: change big switch functions to single return point (2013-04-24
10:57:48 +0300)
Alon Levy (15):
dev-smartcard-reader: white space fixes
dev
> With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to
> know what part of the primary to use for each monitor. If the guest driver
> does not support this, the server sends messages to the client for a
> single monitor spanning the entire primary.
>
> As soon as the guest
> Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600:
> > Sounds like I'm missing something. We're looking at using Windows
> > Server 2k8 as a workstation OS as the licensing seems to be more
> > reasonable for vdi.
>
> Ah, OK. Then it would be reasonable to add server systems as supported
> to
> Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600:
> > Sounds like I'm missing something. We're looking at using Windows
> > Server 2k8 as a workstation OS as the licensing seems to be more
> > reasonable for vdi.
>
> Ah, OK. Then it would be reasonable to add server systems as supported
> to
Adds todos.
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 45 +++
1 file changed, 45 insertions(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 8022f9f..78ef504 100644
--- a/hw/usb/dev-smartcard-reader.c
From: Marc-André Lureau
---
libcacard/vscclient.c | 314 ++
1 file changed, 162 insertions(+), 152 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 9b744f2..5e00db3 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vs
Signed-off-by: Alon Levy
---
libcacard/cac.c | 73 -
1 file changed, 52 insertions(+), 21 deletions(-)
diff --git a/libcacard/cac.c b/libcacard/cac.c
index 5864539..7a06b5a 100644
--- a/libcacard/cac.c
+++ b/libcacard/cac.c
@@ -40,41
We don't support T=1 so we shouldn't advertise it by default.
Two independent changes:
* Default ATR
sets T=0. This gets overwritten by the client provided ATR later.
* Class descriptor
changes dwAdvertise dwProtocols. to 0x1 and dwProtocols.=0 per spec.
Signed-off-by:
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 38c3c0e..98f3be1 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 78ef504..125cc2c 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -1051,6
Only because qemu's checkpatch complains about it.
Signed-off-by: Alon Levy
---
Makefile.objs | 1 +
libcacard/vcard_emul_nss.c | 14 +++---
libcacard/vcardt.c | 40
libcacard/vcardt.h
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 69 +++
1 file changed, 63 insertions(+), 6 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 57eb803..6653619 100644
--- a/hw/usb/dev-smartcard
From: Marc-André Lureau
The VCARD_ATR_PREFIX macro adds a prefix of 6 characters only.
pcsc_scan was complaining before the patch:
+ Historical bytes: 56 43 41 52 44 5F 4E 53 53
ERROR! ATR is truncated: 2 byte(s) is/are missing
---
libcacard/vcardt.h | 2 +-
1 file changed, 1 insertion(+), 1
From: Marc-André Lureau
---
libcacard/vscclient.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index 5e00db3..5f47634 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -218,8 +218,7 @@ on_host_init(VSCM
namespace, i.e:
Signed-off-by: Alon Levy
---
hw/usb/ccid-card-passthru.c | 2 ++
hw/usb/dev-smartcard-reader.c | 1 +
include/qemu-common.h | 5 +
util/cutils.c | 23 +++
4 files changed, 31 insertions(+)
diff --git a/hw
Using g_debug with log domain libcacard
Signed-off-by: Alon Levy
---
libcacard/cac.c | 7 -
libcacard/cac.h | 8 ++
libcacard/vreader.c | 77 +
3 files changed, 85 insertions(+), 7 deletions(-)
diff --git a/libcacard/cac.c b
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 74 +++
1 file changed, 47 insertions(+), 27 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 35f234e..0d482a9 100644
--- a/hw/usb/dev-smartcard
Signed-off-by: Alon Levy
---
hw/usb/ccid-card-passthru.c | 59 +
1 file changed, 59 insertions(+)
diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index 275b887..16d51c9 100644
--- a/hw/usb/ccid-card-passthru.c
+++ b/hw/usb/ccid
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 6653619..6133edf 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev
Signed-off-by: Alon Levy
---
libcacard/vcardt.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
index 538bdde..3b9a619 100644
--- a/libcacard/vcardt.h
+++ b/libcacard/vcardt.h
@@ -26,9 +26,17 @@ typedef struct
From: Marc-André Lureau
This version handles non-blocking sending and receiving from the
socket.
Signed-off-by: Marc-André Lureau
---
libcacard/vscclient.c | 391 +++---
1 file changed, 246 insertions(+), 145 deletions(-)
diff --git a/libcacard/vscc
By not advertising USB wakeup support (which we don't).
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 6133edf..38c3c0e 100644
--- a/hw/us
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index db8ce02..57eb803 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -471,6 +471,7
From: Marc-André Lureau
It's a bit nicer to look for default database under
CSIDL_COMMON_APPDATA\pki\nss rather that /etc/pki/nss.
Signed-off-by: Marc-André Lureau
---
libcacard/vcard_emul_nss.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/libcacard/vc
From: Marc-André Lureau
Use only the modules defined in the NSS database.
---
libcacard/vcard_emul_nss.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index 6b1ca8a..9ba80fb 100644
--- a/libcacard/vca
From: Marc-André Lureau
For some reason, with sql:/ prefix, the PKCS11 modules are not loaded.
This patch goes on top of Alon smartcard series.
---
libcacard/vcard_emul_nss.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_e
From: Marc-André Lureau
Compile and link with version.lo
Signed-off-by: Marc-André Lureau
---
Makefile | 8 ++--
rules.mak | 3 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 88375dc..b6ad03a 100644
--- a/Makefile
+++ b/Makefile
@@ -166,11 +16
From: Jim Meyering
Signed-off-by: Jim Meyering
---
hw/usb/ccid-card-emulated.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/ccid-card-emulated.c b/hw/usb/ccid-card-emulated.c
index 6cbb176..094284d 100644
--- a/hw/usb/ccid-card-emulated.c
+++ b/hw/usb/ccid-ca
From: Marc-André Lureau
Program received signal SIGSEGV, Segmentation fault.
__strcmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
164 movdqu(%rsi), %xmm2
(gdb) bt
at /home/elmarco/320g/src/qemu/hw/ccid-card-emulated.c:477
at /home/elmarco/320g/src/qemu
From: Marc-André Lureau
vscclient needs to call socket_init() for portability.
Moving to osdep.c since it has no internal dependency.
Signed-off-by: Marc-André Lureau
---
util/osdep.c| 23 +++
util/qemu-sockets.c | 24
2 files changed, 23 in
From: Marc-André Lureau
It is needed to give that flag to the linker as well, but latest
libtool 2.4.2 still swallows that argument, so let's pass it with
libtool -Wc argument.
qemu-1.4.0/stubs/arch-query-cpu-def.c:6: undefined reference to
`__stack_chk_guard'
Signed-off-by: Marc-André Lureau
From: Jim Meyering
Signed-off-by: Jim Meyering
---
hw/usb/ccid-card-passthru.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index 71a45f6..275b887 100644
--- a/hw/usb/ccid-card-passthru.c
+++ b/hw/usb/ccid-card-pas
that were not acked before.
did all the changes per Marc Andre's comments. Please look at the g_debug one,
I'm not sure
about the ifdeffery there (not if it works, but if it looks ok).
Alon Levy (15):
dev-smartcard-reader: white space fixes
dev-smartcard-reader: nicer debug mess
> On 04/17/2013 10:47 AM, Alon Levy wrote:
> > On Mon, 2013-04-15 at 14:54 -0400, Yonit Halperin wrote:
> >> Hi,
> >> On 04/14/2013 09:37 AM, Alon Levy wrote:
> >>> On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote:
> >>>
> >&g
> If the current latency is smaller than the new min-latency
> value, we cork the playback till the target latency is achieved.
>
> Note: I didn't modify the prebuf configuration and used
> pa_stream_prebuf, because pulse updated the prebuf only if
> I set both prebuf and tlength to be target_late
> handle MSG_STREAM_ACTIVIATE_REPORT and send MSGC_STREAM_REPORT
> periodically, or when the playback is out of sync.
ACK with one comment
> ---
> gtk/channel-display-priv.h | 10
> gtk/channel-display.c | 116
> -
> spice-common
> Support checking whether an audio playback is active and what its latency
> is.
ACK, one comment.
> ---
> gtk/Makefile.am | 1 +
> gtk/channel-playback-priv.h | 23 +++
> gtk/channel-playback.c | 24
> gtk/spice-session-priv.h|
> The plugin binary name was changed from libnsISpice to npSpiceConsole,
> but the Makefile.am rule optionnally building SpiceXpi.xpi was not
> changed to take this rename into account.
ACK series.
> ---
> SpiceXPI/Makefile.am | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
On Mon, 2013-04-15 at 14:54 -0400, Yonit Halperin wrote:
> Hi,
> On 04/14/2013 09:37 AM, Alon Levy wrote:
> > On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote:
> >
> > ACK series, sorry for the delay. I have to admit I don't understand the
> > fir
On Mon, 2013-04-15 at 15:31 +0200, Marc-André Lureau wrote:
> Hi
>
>
> On Wed, Mar 27, 2013 at 9:36 PM, Alon Levy wrote:
> This series:
> 1. fixes windows guests to show the ccid device
> 2. changes libcacard to use glib
> 3. makes lib
On Sun, 2013-04-14 at 16:06 -0400, Cole Robinson wrote:
> Reproducer:
>
> ./x86_64-softmmu/qemu-system-x86_64 -device usb-ccid,id=ccid0 -usb -device
> ccid-card-emulated -monitor stdio
>
ACK, thanks.
Marc-Andre, could you review the fixed patches I sent previously, and
then I can put this on t
On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote:
ACK series, sorry for the delay. I have to admit I don't understand the
first patches as well as I should, but seeing as they have been tested
and that I would just be delaying them further, I prefer to let you push
them. I hope to wo
On Tue, Feb 26, 2013 at 01:04:10PM -0500, Yonit Halperin wrote:
> mjpeg_encoder modify the initial bit we supply it, according to the
> client feedback. If it reaches a bit rate which is higher than the
> initial one, we use the higher bit rate as the new bit rate estimation.
ACK to this and the r
On Tue, Feb 26, 2013 at 01:04:09PM -0500, Yonit Halperin wrote:
ACK
one comment below
> ---
> server/red_worker.c | 56
> -
> 1 file changed, 51 insertions(+), 5 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index
On Tue, Feb 26, 2013 at 01:04:08PM -0500, Yonit Halperin wrote:
> When there is no audio playback, we set the mm_time in the client to be older
> than the one in the server by at least the requested latency (the delta is
> actually bigger, due to the network latency).
> When there is an audio playb
On Tue, Feb 26, 2013 at 01:04:07PM -0500, Yonit Halperin wrote:
> also update spice-common submodule
ACK with one line removed.
> ---
> server/snd_worker.c | 45 +
> server/snd_worker.h | 2 ++
> 2 files changed, 47 insertions(+)
>
> diff --git a/ser
On Tue, Feb 26, 2013 at 01:04:06PM -0500, Yonit Halperin wrote:
ACK
> ---
> server/dispatcher.h | 6 +++---
> server/main_dispatcher.h | 1 +
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/server/dispatcher.h b/server/dispatcher.h
> index a468c58..1b389bd 100644
> ---
On Tue, Feb 26, 2013 at 01:04:05PM -0500, Yonit Halperin wrote:
> A frame can be dropped if a new frame was added during the same
> call to red_process_command (we didn't attempt to send the older
> frame). Such drops are ignored.
ACK.
red_detach_stream / red_attach_stream and red_stream_mainten
On Tue, Feb 26, 2013 at 01:04:04PM -0500, Yonit Halperin wrote:
ACK
> ---
> server/red_worker.c | 17 +
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 23f9ca5..ff26f84 100644
> --- a/server/red_worker.c
> +++
On Tue, Feb 26, 2013 at 01:04:03PM -0500, Yonit Halperin wrote:
ACK, one spelling error below.
> update mjpeg_encoder with reports from the client about
> the playback quality.
> ---
> server/red_dispatcher.c | 1 +
> server/red_worker.c | 86
> +
On Tue, Feb 26, 2013 at 01:04:02PM -0500, Yonit Halperin wrote:
> This patch only employs setting the stream parameters based on
> the initial given bit-rate, the latency, and the encoding size.
> Later patches will also employ mjpeg_encoder response to client reports,
> and its control over frame
On Tue, Feb 26, 2013 at 01:04:01PM -0500, Yonit Halperin wrote:
ACK
> ---
> server/red_worker.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 82f2fc9..5043c10 100644
> --- a/server/red_worker.c
> +++ b/server/red_w
On Tue, Feb 26, 2013 at 01:04:00PM -0500, Yonit Halperin wrote:
> Periodically calculate the rate of frames arriving from the guest to the
> server.
ACK.
red_now should be put in a header later.
> ---
> server/red_worker.c | 36 +++-
> 1 file changed, 35 insertio
On Tue, Feb 26, 2013 at 01:03:59PM -0500, Yonit Halperin wrote:
ACK.
just a note: maybe we should not send our time, but an id, to not leak
information?
another note: should we drop the special case main channel ping later?
other notes (all nitpick quality) below.
> ---
> server/inputs_channe
On Tue, Feb 26, 2013 at 01:03:58PM -0500, Yonit Halperin wrote:
> display channel - supplying timeouts interface to red_channel, in order to
> allow
> periodic latency monitoring (see next patch).
ACK
> ---
> server/red_worker.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff
On Tue, Feb 26, 2013 at 01:03:57PM -0500, Yonit Halperin wrote:
> Each thread can create a spice_timer_queue, for managing its
> own timers.
ACK.
nitpick: why ms and not nano?
> ---
> server/Makefile.am | 2 +
> server/spice_timer_queue.c | 268
> +
On Tue, Feb 26, 2013 at 01:03:56PM -0500, Yonit Halperin wrote:
> The stream starts after lossless frames were sent to the client,
> and without rate control (except for pipe congestion). Thus, on the beginning
> of the stream, we might observe frame drops on the client and server side
> which
> a
On Tue, Feb 26, 2013 at 01:03:55PM -0500, Yonit Halperin wrote:
> The actual frames distribution does not necessarily fit the
> condition "at least one frame every (1000/rate_contorl->fps)
> milliseconds".
> For keeping the average frame rate close to the defined fps, we
> periodically measure the
On Tue, Feb 26, 2013 at 01:03:54PM -0500, Yonit Halperin wrote:
ACK with one comment.
> ---
> server/mjpeg_encoder.c | 20 +---
> server/mjpeg_encoder.h | 21 ++---
> server/red_worker.c| 21 -
> 3 files changed, 39 insertions(+), 23 deleti
On Tue, Feb 26, 2013 at 01:03:53PM -0500, Yonit Halperin wrote:
> The required client playback latency is assessed based on the current
> estimation of the bit rate, the network latency, and the encoding size
> of the frames. When the playback delay that is reported by the client
> seems too small,
On Tue, Feb 26, 2013 at 01:03:52PM -0500, Yonit Halperin wrote:
> Downgrading stream bit rate when the input frame rate in the server
> exceeds the output frame rate, and frames are being dropped from the
> output pipe.
ACK.
> ---
> server/mjpeg_encoder.c | 103
> +++
On Tue, Feb 26, 2013 at 01:03:51PM -0500, Yonit Halperin wrote:
> mjpeg_encoder can receive periodic reports about the playback status on
> the client side. Then, mjpeg_encoder analyses the report and can
> increase or decrease the stream bit rate, depending on the report.
> When the bit rate is ch
On Tue, Feb 26, 2013 at 01:03:50PM -0500, Yonit Halperin wrote:
> If the encoding size seems to get smaller/bigger, re-evaluate the
> stream quality and frame rate.
ACK.
> ---
> server/mjpeg_encoder.c | 147
> ++---
> 1 file changed, 139 insertions(+)
On Tue, Feb 26, 2013 at 01:03:49PM -0500, Yonit Halperin wrote:
> Previously, the mjpeg quality was always 70. The frame rate was
> tuned according to the frames' congestion in the pipe.
> This patch sets the quality and frame rate according to
> a given bit rate and the size of the first encoded f
On Tue, Feb 26, 2013 at 01:03:48PM -0500, Yonit Halperin wrote:
> The mjpeg_encoder should be client specific, and not shared between
> different clients**, for the following reasons:
> (1) Since we use abbreviated jpeg datastream for mjpeg, employing the same
> mjpeg_encoder for different clie
On Tue, Feb 26, 2013 at 01:03:47PM -0500, Yonit Halperin wrote:
> Frames counting was skipped when the previous frame was already
> sent completely to the client.
ACK
> ---
> server/red_worker.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/server/re
namespace, i.e:
Signed-off-by: Alon Levy
---
hw/ccid-card-passthru.c | 2 ++
hw/usb/dev-smartcard-reader.c | 1 +
include/qemu-common.h | 5 +
util/cutils.c | 23 +++
4 files changed, 31 insertions(+)
diff --git a/hw
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 7040e8d..689468b 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -1051,6
Signed-off-by: Alon Levy
---
libcacard/cac.c | 73 -
1 file changed, 52 insertions(+), 21 deletions(-)
diff --git a/libcacard/cac.c b/libcacard/cac.c
index 5864539..7a06b5a 100644
--- a/libcacard/cac.c
+++ b/libcacard/cac.c
@@ -40,41
Using g_debug with log domain libcacard
Signed-off-by: Alon Levy
---
libcacard/cac.c | 7 -
libcacard/cac.h | 8 ++
libcacard/vreader.c | 77 +
3 files changed, 85 insertions(+), 7 deletions(-)
diff --git a/libcacard/cac.c b
Adds todos.
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 45 +++
1 file changed, 45 insertions(+)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index bb96f02..7040e8d 100644
--- a/hw/usb/dev-smartcard-reader.c
Signed-off-by: Alon Levy
---
hw/usb/dev-smartcard-reader.c | 74 +++
1 file changed, 47 insertions(+), 27 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 751bd04..014c0b1 100644
--- a/hw/usb/dev-smartcard
Only because qemu's checkpatch complains about it.
Signed-off-by: Alon Levy
---
Makefile.objs | 1 +
libcacard/vcard_emul_nss.c | 14 +++---
libcacard/vcardt.c | 40
libcacard/vcardt.h
We don't support T=1 so we shouldn't advertise it by default.
Two independent changes:
* Default ATR
sets T=0. This gets overwritten by the client provided ATR later.
* Class descriptor
changes dwAdvertise dwProtocols. to 0x1 and dwProtocols.=0 per spec.
Signed-off-by:
Signed-off-by: Alon Levy
---
hw/ccid-card-passthru.c | 59 +
1 file changed, 59 insertions(+)
diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c
index 3566e55..111894f 100644
--- a/hw/ccid-card-passthru.c
+++ b/hw/ccid-card-passthru.c
Signed-off-by: Alon Levy
---
libcacard/vcardt.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
index 538bdde..3b9a619 100644
--- a/libcacard/vcardt.h
+++ b/libcacard/vcardt.h
@@ -26,9 +26,17 @@ typedef struct
Marc Andre's comments. Please look at the g_debug one,
I'm not sure
about the ifdeffery there (not if it works, but if it looks ok).
Alon Levy (10):
libcacard: change default ATR
ccid-card-passthru: add atr check
ccid-card-passthru, dev-smartcard-reader: add debug environment
On Fri, Mar 22, 2013 at 03:23:15PM +0100, Marc-André Lureau wrote:
> Hi,
>
>
> On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy wrote:
> > +if (atr_protocol_num == 0) {
> > +DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T0 parameters"
> >
> Hi,
> On 03/27/2013 06:17 AM, Hans de Goede wrote:
> > Hi,
> >
> > On 03/27/2013 09:07 AM, Søren Sandmann wrote:
> >> Hello,
> >>
> >> The following is some notes on what I am planning to do for UMS
> >> memory
> >> management. It basically amounts to a rewrite of qxl-surface-ums.c
> >
> > Looks
> This patch-series is the result of the
> "[PATCH 1/2] char: add qemu_chr_be_is_fe_connected" discussion
> thread.
>
> This patch series (tries to) make(s) the frontend open concept both
> more
> explicit and generic, and significantly cleans up the surrounding
> code.
The whole patch series loo
> Hi, I'm learning about qxl device in KVM VM. I got a problem and asks
> for help. Thanks.
>
> The qemu's command is:
> qemu-system-x86_64 -spice port=5900,disable-ticketing -vga
> qxl
> --enable-kvm ...
>
> The code in function 'interface_get_command' is followed:
> SPIC
401 - 500 of 4874 matches
Mail list logo
