Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-01-24 Thread Alon Levy
On Wed, Jan 23, 2013 at 04:40:38PM -0600, Jeremy White wrote: > This fixes a bug with x-spice where you could not specify > a default mode in an xorg.conf modeline that was greater > than 1024x768. This also eliminates (and partially > reverts) patch c1b537fc. > > It may also fix bug 894421, wher

Re: [Spice-devel] settings for qxl memory size

2013-01-23 Thread Alon Levy
> Hi, > we have been posting all our results on xen-devel too, but we haven't > made any progress by now. We are trying to narrow down the problem as > much as possible so that we can ask the right question at the right > place, any advice is welcome (eg. what tests can be done). > > Changing the

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-22 Thread Alon Levy
> > BTW reading patch 1 again, I wonder what exactly it tries to solve, > > since > > currently when using spice with qemu (no experience with x-spice) > > you can > > already set modes > 1024x768 without problems. > > This will teach me to set down a patch for a few months while I work > on other

Re: [Spice-devel] spice crashes

2013-01-22 Thread Alon Levy
> Hello All, > > while using remote-viewer, qemu and libs as compiled below, my > 32bit-win7-VMs (spice-guest-tools-0.3.exe) are crashing quit > frequently, and the following error is shown in the hosts dmesg log: > > segfault at 50 ip 7f8b6bab3119 sp 7f8b64db3b00 error 6 in > libspice-se

Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2013-01-21 Thread Alon Levy
Adding Gerd. > Signed-off-by: Alon Levy > --- > hw/qxl.c | 11 +++ > trace-events | 2 ++ > 2 files changed, 13 insertions(+) > > diff --git a/hw/qxl.c b/hw/qxl.c > index 9dc44b9..0d81816 100644 > --- a/hw/qxl.c > +++ b/hw/qxl.c >

[Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192

2013-01-21 Thread Alon Levy
t;(flipped)" modes prior to the patch, and the patch loses the ability to set "Portrait" modes. But this is a separate bug to be fixed in the driver, and besides the patch doesn't affect the new arbitrary mode setting functionality. Signed-off-by: Alon Levy --- hw/qxl.c | 13 ++

[Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2013-01-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void interface_set_client_capabilities(QXLInstance *sin

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-21 Thread Alon Levy
> On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape > > (flipped), Portrait (flipped) > > - You can ch

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-20 Thread Alon Levy
On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote: > On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape

[Spice-devel] win7 guest display flipped

2013-01-18 Thread Alon Levy
Hi, Did this ever work: start win7 guest (I'm using 64 bit), desktop, screen resolution, choose one of the flipped options (landscape/portrait) - I get an error dialog: title: Change Settings Contents: Unable to save display settings. Choosing both of the non flipped modes (landscape, portrai

[libvirt] [PATCH v2] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
Adds a "ram" attribute globally to the video.model element, that changes the resulting qemu command line only if video.type == "qxl". That attribute gets a default value of 64*1024. The schema is unchanged for other video element types. The resulting qemu command line change is the addition

Re: [Spice-devel] settings for qxl memory size

2013-01-18 Thread Alon Levy
> Thanks for your reply, > I did more tests with this new patch for qxl, but it still doesn't > work: > http://lists.xen.org/archives/html/xen-devel/2013-01/msg01405.html Hi Davide, Perhaps you should ask on xen-devel? I am curios about this effort but I don't think anyone involved with it is o

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
> On 01/17/2013 12:35 PM, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > s/globaly/globally/ check. > > > the resulting qemu command line only if video.type == "qxl". > > > > Th

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-18 Thread Alon Levy
f :) - Original Message - > On 01/17/2013 12:35 PM, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > s/globaly/globally/ > > > the resulting qemu command line only if video.type == "qxl". > &

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
> On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > the resulting qemu command line only if video.type == "qxl". > > > > That attribute gets a default value of

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
> On 17.01.2013 20:35, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > the resulting qemu command line only if video.type == "qxl". > > > > That attribute gets a default value of 64*1024 only if

Re: [libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
> On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote: > > Adds a qxl-ram attribute globaly to the video.model element, that > > changes > > the resulting qemu command line only if video.type == "qxl". > > > > That attribute gets a default value of

[libvirt] [PATCH] qemu: Support ram bar size for qxl devices

2013-01-17 Thread Alon Levy
Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == "qxl". That attribute gets a default value of 64*1024 only if model.type is "qxl". In effect not changing any xml or argv for non qxl devices. For qxl devices a new prop

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-17 Thread Alon Levy
- Original Message - > On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape > > (flipped), Portrait (

[Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2013-01-16 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 9dc44b9..0d81816 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -945,6 +945,12 @@ static void interface_set_client_capabilities(QXLInstance *sin

[Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-16 Thread Alon Levy
xpected Changes to the second patch: - no orientations except the normal - hard code 8192 bytes rom size - assert if the required size is larger Alon Levy (2): qxl: stop using non revision 4 rom fields for revision < 4 qxl: change rom size to 8192 hw/qxl.c | 25 ++

[Qemu-devel] [PATCH v2 2/2] qxl: change rom size to 8192

2013-01-16 Thread Alon Levy
t the future QXLRom increases via spice-protocol changes. Signed-off-by: Alon Levy --- hw/qxl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 0d81816..0cd854a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -79,10 +79,7 @@ QXL_MODE(x_res,

Re: [Spice-devel] spice multi-clients issue

2013-01-16 Thread Alon Levy
> Hi,All, > Currently I'm trying the multi-client feature of spice, the server > side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux > machine the spicec-0.10 or spice-gtk-0.10 as clients, the > multi-clients > works fine, > but if I use the old version(e.g. spicec-0.6) spicec-wi

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2013-01-15 Thread Alon Levy
On Sun, Dec 23, 2012 at 10:31:38PM +0200, Alon Levy wrote: > On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote: > > On 12/13/12 12:36, Alon Levy wrote: > > > This is a simpler solution to 869981, where migration breaks since qxl's > > > rom bar size

Re: [Spice-devel] [PATCH spice-protocol] vd_agent.h: add a VD_AGENT_CAP_SPARSE_MONITORS_CONFIG capability (rhbz#881072)

2013-01-15 Thread Alon Levy
On Thu, Jan 10, 2013 at 11:52:28PM +0100, Hans de Goede wrote: > Currently the agent expect a monitor config to be continuous. If the user has > 3 monitors (3 spice display windows) open and tries to disable the 2nd one, > then instead of the 2nd one being closed, the 3th one ends up closed. > > T

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-15 Thread Alon Levy
On Sat, Jan 12, 2013 at 12:25:12AM +0100, Hans de Goede wrote: > Hi, > > On 01/12/2013 12:04 AM, Jeremy White wrote: > >On 01/11/2013 04:02 PM, Hans de Goede wrote: > >>Hi, > >> > >>On 01/11/2013 10:34 PM, Jeremy White wrote: > >>>This makes the default display not stretch for 4096x768. > >> > >>H

Re: [Spice-devel] [PATCH spice 1/2] server: Fix SpiceWorker-CRITICAL **: red_worker.c:10968:red_push_monitors_config: condition `monitors_config != NULL' failed

2013-01-15 Thread Alon Levy
On Thu, Jan 10, 2013 at 11:52:38PM +0100, Hans de Goede wrote: > During my dynamic monitor support testing today, I hit the following assert > in red_worker.c: > "red_push_monitors_config: condition `monitors_config != NULL' failed" > > This is caused by the following scenario: > 1) Guest causes h

Re: [Spice-devel] settings for qxl memory size

2013-01-15 Thread Alon Levy
On Thu, Jan 03, 2013 at 12:21:11PM +0100, Davide Canova wrote: > I'm trying qxl with xen, qemu 1.3 and spice 0.12.2, and I get this error: > Spice-CRITICAL **: red_memslots.c:123:get_virt: slot_id 194 too big, > addr=c2c2c2c2c2c2c2c2 That's a bug in the driver/device/spice_server (but I guess driv

Re: [Spice-devel] [PATCH] link libspice server with libm libpthread

2013-01-14 Thread Alon Levy
On Fri, Jan 11, 2013 at 11:23:33PM +0400, Michael Tokarev wrote: > Ping? Pushed. > > More than half a year has been passed away, but the patch is > still needed for current 0.12.2 version... > (patchwork url: http://patchwork.freedesktop.org/patch/10546/ ) > > Thanks, > > /mjt > > 04.06.2012

Re: [Spice-devel] Could you please give me some help on windows display driver?

2013-01-07 Thread Alon Levy
Forwarding to spice-devel. Please post there next time, thanks. > Alon, > > I'm new to windows display driver, I read the qxl xddm driver and > found you are the main committer to this project. I write a miniport > driver and a display driver, install them to windows xp. And infos > from VideoDe

Re: [Spice-devel] Announcing spice 0.12.2 & spice-protocol 0.12.3

2012-12-23 Thread Alon Levy
On Thu, Dec 20, 2012 at 09:18:17PM +0100, Hans de Goede wrote: > Hi All, > > I'm happy to announce a new bugfix (+ a small feature) release > in the stable spice-0.12.x series. > > Changes in spice-0.12.2: > > * Skipped 0.12.1, it existed in git but was never released > *

Re: [Spice-devel] multi-clients issue

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 01:05:04PM +0800, Rozen Lin wrote: > Hi,All, > Currently I'm trying the multi-client feature of spice, the server > side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux > machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clients > works fine,

[Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2012-12-23 Thread Alon Levy
static in the guest. By registering the interface on post load spice server will pass on the agent messages fixing the mouse behavior after migration. RHBZ #725965 Signed-off-by: Alon Levy --- spice-qemu-char.c | 42 ++ 1 file changed, 42 insertions(+) diff

[Qemu-devel] [PATCH] usb/redirect.c: unbreak compilation due to include/char/char.h

2012-12-23 Thread Alon Levy
Broken since: commit 927d4878b0ff319ed87fed9363f314613b0a5ed9 Author: Paolo Bonzini Date: Mon Dec 17 18:20:05 2012 +0100 softmmu: move remaining include files to include/ subdirectories Signed-off-by: Alon Levy --- hw/usb/redirect.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 09:33:28AM +0100, Paolo Bonzini wrote: > Il 28/11/2012 10:53, Alon Levy ha scritto: > >> Il 28/11/2012 10:16, Alon Levy ha scritto: > >>> > > diff --git a/roms/openbios b/roms/openbios > >>> > > index f095c85..d1d2787 1600

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 03:43:46PM +0100, Gerd Hoffmann wrote: > Hi, > > >> That is indeed a better solution, but it does change functionality. I > >> think it is correct but I'd like to get some other opinions - Uri, > >> Arnon, Yonit, Soren - any problems with dropping these? > >> > > Orientat

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2012-12-23 Thread Alon Levy
On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote: > On 12/13/12 12:36, Alon Levy wrote: > > This is a simpler solution to 869981, where migration breaks since qxl's > > rom bar size has changed. Instead of ignoring fields in QXLRom, which is > > what ha

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-20 Thread Alon Levy
On Thu, Dec 13, 2012 at 08:29:48AM -0500, Yonit Halperin wrote: > On 12/13/2012 06:42 AM, Alon Levy wrote: > >All looks good except the assert. We should be removing them whenever they > >are guest trigerable - maybe I'm not following the code, but if in > >red_get_im

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-13 Thread Alon Levy
All looks good except the assert. We should be removing them whenever they are guest trigerable - maybe I'm not following the code, but if in red_get_image sees no pallete in the qxl struct then palette will be NULL, which means it's guest trigerable. > Non rgb bitmaps are allowed to not have a

[Qemu-devel] [PATCH 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2012-12-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 3f835b8..8611ee9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -981,6 +981,12 @@ static void interface_set_client_capabilities(QXLInstance *sin

[Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2012-12-13 Thread Alon Levy
esult in failure at startup (could do this compile time also but not sure how). Signed-off-by: Alon Levy --- hw/qxl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 8611ee9..99b354a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -88,9 +88,7 @@ #d

Re: [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code

2012-12-13 Thread Alon Levy
All looks good. Reviewed-by: Alon Levy - Original Message - > This series reworks the post_load code recently introduced to > allocate > the structures only when required (i.e. only at load time). This > helps keep the VirtIOSerial struct clean, and use less RAM. > &

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Alon Levy
> On 12/06/12 16:41, Alon Levy wrote: > > RHBZ 869981 > > > > Before this patch revision < 4 (4 is the default) would result in a > > wrong > > qxl_rom size of 16384 instead of 8192 when building with > > spice-protocol-0.12, due to the addition of fie

Re: [Spice-devel] Translating the Spice protocol using spice-client-glib

2012-12-11 Thread Alon Levy
> Hello, > > I am looking to use spice-client-glib (which seems to be the only > low-level client library available) to implement a plugin for guacd > which translates between the Spice protocol and the Guacamole > protocol, thus adding Spice support to Guacamole (an HTML5 remote > desktop gateway

[Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-06 Thread Alon Levy
of the revision and nop-ing. Signed-off-by: Alon Levy --- hw/qxl.c | 37 - hw/qxl.h | 2 ++ trace-events | 2 ++ 3 files changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3f835b8..4794f13 100644 --- a/hw/qxl.c +++ b/hw

Re: [Qemu-devel] [PATCH] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
> On 12/06/2012 02:02 PM, Alon Levy wrote: > > Signed-off-by: Alon Levy > > --- > > arch_init.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch_init.c b/arch_init.c > > index e6effe8..84bca99 100644 > > --

[Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
Signed-off-by: Alon Levy --- Please ignore previous version, accidentally removed goto done and used wrong format size specifiers. arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index e6effe8..fba24f3 100644 --- a/arch_init.c +++ b/arch_init.c

[Qemu-devel] [PATCH] arch_init/ram_load: add error message for block length mismatch

2012-12-06 Thread Alon Levy
Signed-off-by: Alon Levy --- arch_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index e6effe8..84bca99 100644 --- a/arch_init.c +++ b/arch_init.c @@ -808,8 +808,10 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id

Re: [Spice-devel] Building qxl w/WDK

2012-12-06 Thread Alon Levy
> Hi, > > Is building qxl supported with the latest WDK 8.59.25584? > > http://www.spice-space.org/page/WinQXL > > I am trying to follow the directions. I open up a command prompt > called > "Microsoft Windows 7 x64 Debug Build Environment" and set > SPICE_COMMON_DIR and run the "build -cZg" com

Re: [Spice-devel] [PATCH spice-server] red_worker: revert 8855438a

2012-12-06 Thread Alon Levy
ACK - Original Message - > red_proccess_commands calls were added after calling > guest_set_client_capabilities in order to cleanup the command ring > from > old commands that the client might not be able to handle. > However, calling red_process_commands at this stage does send > messages

Re: [Spice-devel] Some spice-html5 issues

2012-12-05 Thread Alon Levy
> Hello, > > I would also be very interested for a fix. > Do you have a bug tracker I can feed? https://bugs.freedesktop.org/enter_bug.cgi?product=Spice > > Thanks. > Erfane > > On Nov 30, 2012, at 11:07 AM, Vincent Desprez > wrote: > > > Hi, > > > > When using spice-html5, I cannot properl

Re: [Spice-devel] [PATCH spice] server: add "port" channel support

2012-12-04 Thread Alon Levy
> A Spice port channel carry arbitrary data between the Spice client > and > the Spice server. It may be used to provide additional services on > top > of a Spice connection. For example, a channel can be associated with > the qemu monitor for the client to interact with it, just like any > qemu ch

Re: [Spice-devel] Native USB redirection does not work - (remote-viewer) did not claim interface 0 before use

2012-12-04 Thread Alon Levy
> > > > On Tue, December 4, 2012 08:36, Alon Levy wrote: > >> On 12/02/2012 11:58 AM, Hans de Goede wrote: > >> > >>> Hi, > >>> > >>> > >>> On 11/30/2012 03:40 PM, Sigbjorn Lie wrote: > >>> &g

Re: [Spice-devel] Native USB redirection does not work - (remote-viewer) did not claim interface 0 before use

2012-12-03 Thread Alon Levy
> On 12/02/2012 11:58 AM, Hans de Goede wrote: > > Hi, > > > > On 11/30/2012 03:40 PM, Sigbjorn Lie wrote: > >> Hi, > >> > >> I have disabled pcscd with chkconfig and rebooted. After the > >> reboot I > >> attempted to connect to the > >> VDI and share my smart card reader again. The same issue occ

Re: [Spice-devel] Native USB redirection does not work - (remote-viewer) did not claim interface 0 before use

2012-12-03 Thread Alon Levy
> On 12/02/2012 11:58 AM, Hans de Goede wrote: > > Hi, > > > > On 11/30/2012 03:40 PM, Sigbjorn Lie wrote: > >> Hi, > >> > >> I have disabled pcscd with chkconfig and rebooted. After the > >> reboot I > >> attempted to connect to the > >> VDI and share my smart card reader again. The same issue occ

Re: [Spice-devel] Adding the support for chromium to spice-xpi

2012-12-03 Thread Alon Levy
> The goal of the following patches is to add the support for the > chromium > browser. Along the way small issues has been fixed. > > The resulting build for fedora 17 can be found here: > > http://fsimonce.fedorapeople.org/spice-xpi-chromium-f17/ > > And it has been succesfully tested with chr

Re: [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
> The current code waits until the chardev can read MIN(len, VMC_MAX) > But some chardev may never reach than amount, in fact some of them > will only ever accept write of 1. Fix the min computation and remove > the VMC_MAX constant. Looks good to me. > > Signed-off-by: Marc-André Lureau > ---

Re: [Spice-devel] [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
> The current code waits until the chardev can read MIN(len, VMC_MAX) > But some chardev may never reach than amount, in fact some of them > will only ever accept write of 1. Fix the min computation and remove > the VMC_MAX constant. Looks good to me. > > Signed-off-by: Marc-André Lureau > ---

Re: [Spice-devel] spice-guest-tools-0.2 and Windows 2008 R2

2012-11-29 Thread Alon Levy
> On 11/29/2012 09:11 AM, David Jaša wrote: > > You need to extract the driver (sys, cat and inf files) from the > > installer and then use "Update Driver -> ... Have Disk" in Device > > Manager. > > For Windows 8, I follow these steps and click "Have Disk". I see the > Red > Hat QXL GPU device. B

Re: [Spice-devel] [PATCH spice-server 2/2] red_worker: no need to align the stride of internal images

2012-11-28 Thread Alon Levy
> On 11/28/2012 05:54 PM, Alon Levy wrote: > > Why is there no need to align the stride of internal images? what > > happens if we keep this alignment? Please add the answers to the > > patch log message. > > > Why do you think there may be a need? those images ar

Re: [Spice-devel] [PATCH spice-server 2/2] red_worker: no need to align the stride of internal images

2012-11-28 Thread Alon Levy
Why is there no need to align the stride of internal images? what happens if we keep this alignment? Please add the answers to the patch log message. > --- > server/red_worker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c >

Re: [Spice-devel] [PATCH spice-protocol V3] vd_agent.h: drag-and-drop support

2012-11-28 Thread Alon Levy
> Hi > > - Mensaje original - > > At present, Vmware and Virtualbox has supported file drag&drop > > feature, > > I think it's a good feature for users, so we want qemu/spice to > > supports it. > > > > This patch first adds communication protocol between client and > > guest, > > we must

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device

2012-11-28 Thread Alon Levy
> Il 28/11/2012 12:54, Luiz Capitulino ha scritto: > > On Wed, 28 Nov 2012 10:54:33 +0200 > > Alon Levy wrote: > > > >> Instead of aborting immediately after at DEVICE_CLASS(obj) > >> > >> Signed-off-by: Alon Levy > >> --- > >&g

Re: [Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device

2012-11-28 Thread Alon Levy
> On Wed, 28 Nov 2012 10:54:33 +0200 > Alon Levy wrote: > > > Instead of aborting immediately after at DEVICE_CLASS(obj) > > > > Signed-off-by: Alon Levy > > --- > > hw/qdev-monitor.c | 5 + > > 1 file changed, 5 insertions(+) > > >

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
> Alon Levy writes: > > >> Alon Levy writes: > >> > >> > The target has not seen the guest_connected event via > >> > spice_chr_guest_open or spice_chr_write, and so spice server > >> > wrongly > >> > assumes there is

Re: [Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-11-28 Thread Alon Levy
> Il 28/11/2012 10:16, Alon Levy ha scritto: > > diff --git a/roms/openbios b/roms/openbios > > index f095c85..d1d2787 16 > > --- a/roms/openbios > > +++ b/roms/openbios > > @@ -1 +1 @@ > > -Subproject commit f095c858136896d236931357

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
> Alon Levy writes: > > > The target has not seen the guest_connected event via > > spice_chr_guest_open or spice_chr_write, and so spice server > > wrongly > > assumes there is no agent active, while the client continues to > > send > > motion events o

[Qemu-devel] [PATCH] libcacard: build vscclient from root only

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/Makefile | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 7bce286..98c971d 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -1,3 +1,7 @@ +ifeq ($(BUILD_DIR

[Qemu-devel] [PATCH 2/3] qemu-char: add qemu_chr_be_connected

2012-11-28 Thread Alon Levy
always connected status. This is not really important right now since there is only a single user, spice-char-dev.c, which uses virtio-console as the backend, which does implement the callback. Signed-off-by: Alon Levy --- backends/rng-egd.c | 4 ++-- gdbstub.c | 2 +- hw/ccid

[Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-28 Thread Alon Levy
static in the guest. By registering the interface on post load spice server will pass on the agent messages fixing the mouse behavior after migration. RHBZ #725965 Signed-off-by: Alon Levy --- spice-qemu-char.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a

[Qemu-devel] [PATCH 1/3] virtio-serial: add virtio_serial_guest_connected

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/virtio-serial-bus.c | 9 + hw/virtio-serial.h | 5 + 2 files changed, 14 insertions(+) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index ccce1fa..9147497 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -290,6

[Qemu-devel] [PATCH 2/2] libcacard: fix missing symbol in libcacard.so

2012-11-28 Thread Alon Levy
Before patch: $ make libcacard.la $ nm ./libcacard/.libs/libcacard.so.0.0.0 | grep " U " | \ egrep -v "(g_)|(GLIBC)|(SECMOD)|(PK11)|(CERT)|(NSS)|(PORT)|(PR)" U error_set Signed-off-by: Alon Levy --- libcacard/Makefile | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PATCH 1/2] libcacard: use LDFLAGS to produce i686 with --cpu=i386

2012-11-28 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/Makefile | 4 ++-- roms/openbios | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index c26aac6..25bc4a0 100644 --- a/libcacard/Makefile +++ b/libcacard/Makefile @@ -15,7 +15,7

[Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration

2012-11-28 Thread Alon Levy
Adds a new char device backend callback to check connectedness, implemented for virtio console, and used by spice-char-dev in post migration. Is using NULL for DeviceState the intention for non device vmstates? It works fine in practice. Alon Levy (3): virtio-serial: add

[Qemu-devel] [PATCH] hw/qdev-monitor: report error for -device

2012-11-28 Thread Alon Levy
Instead of aborting immediately after at DEVICE_CLASS(obj) Signed-off-by: Alon Levy --- hw/qdev-monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 479eecd..3b70cdb 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -426,6

Re: [Spice-devel] Spice Display updates

2012-11-28 Thread Alon Levy
> > Hi, > Technologies like VNC send screen updates primarily to the client to > reduce bandwidth utilization between client and server. But after > every few seconds, VNC sends across entire screen data to VNC client > (I believe to recover from any corruption). Does spice send entire > screen da

Re: [Spice-devel] server RFC: 2 significant build-time changes

2012-11-28 Thread Alon Levy
> On Fri, Nov 23, 2012 at 04:58:23PM +0100, Christophe Fergeau wrote: > > Hey, > > > > This patch series introduces 2 build system changes that are worth > > some > > attention. The first one disables client build by default as it's > > deprecated, > > and the second patch adds a dependency on gli

Re: [Spice-devel] [PATCH 1/3] Don't build client by default

2012-11-26 Thread Alon Levy
ACK Note that packages will need to be updated. - Original Message - > It has been superseded by virt-viewer/remote-viewer > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index d02ea19..a12e119 100644 > --- a/co

[Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-25 Thread Alon Levy
When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client if the client is using semi-seamless or switch host migration. After migration the target client has never received

Re: [Qemu-devel] [PATCH 1/2] hw/qxl: extract verify_surface_cmd from qxl_track_command

2012-11-20 Thread Alon Levy
> On 11/20/12 10:19, Alon Levy wrote: > > Signed-off-by: Alon Levy > > Doesn't apply to master. Good. It didn't apply because it was missing warn on sync io-usage and validate surface data. The later we agreed should be dropped in favor of spice reporting an e

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alon Levy
- Original Message - > On 11/20/12 10:07, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > >> On 11/19/12 14:11, Alexander Larsson wrote: > >>> This way you can easily tell from qemu if the guest is using > >>> a qxl driver or not. > >> > >> Dev

[Qemu-devel] [PATCH 1/2] hw/qxl: extract verify_surface_cmd from qxl_track_command

2012-11-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 48 +--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 1482389..af5f68e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -430,6 +430,34 @@ static void qxl_ring_set_dirty

[Qemu-devel] [PATCH 2/2] qxl/verify_surface_cmd: check format != 0 (buggy drivers can do that)

2012-11-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index af5f68e..91e4fec 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -455,6 +455,12 @@ static int verify_surface_cmd(PCIQXLDevice *qxl, QXLSurfaceCmd *cmd) return 1

Re: [Spice-devel] spice-vdagent start failed

2012-11-18 Thread Alon Levy
> > Hi, > > > I use this qemu command line to start my virtual machine, but didn't > get /dev/virtio-ports/com.redhat.spice.0 Is the guest kernel loading virtio-console module? You should see something like: # cat /proc/devices | grep virt 252 virtio-portsdev you should have CONFIG_VIRTIO_CO

[Qemu-devel] [PATCH v2] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-17 Thread Alon Levy
Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy --- v1->v2 deanonymized added structs (Blue Swirl) hw/virtio-serial-bus.c |

Re: [Spice-devel] [PATCH spice-gtk] win32: clip and move cursor within window region

2012-11-15 Thread Alon Levy
> Windows grab do not exist like on X11, so we need to clip the cursor > to our client window, while making sure it doesn't overlap with > windows statusbar. When wrapping the cursor, we need to make sure we > also stay within the clip region, or else the clip is inverted > (pointer can't enter the

Re: [Spice-devel] [RFC] server/red_parse_qxl: introduce visitor for cursor

2012-11-15 Thread Alon Levy
> Hi > > > > > On Wed, Nov 14, 2012 at 9:36 PM, Alon Levy < al...@redhat.com > > wrote: > > > This is a second attempt at recording commands received from the qxl > device. The visitor allows more code to be shared between the device > to > sp

[Spice-devel] [RFC] server/red_parse_qxl: introduce visitor for cursor

2012-11-14 Thread Alon Levy
This is a second attempt at recording commands received from the qxl device. The visitor allows more code to be shared between the device to spice struct verifier and copier and the logger. --- Does this look doable? it's the beginning of a second try at recording qxl traffic for debugging and deve

[Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-14 Thread Alon Levy
Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy --- hw/virtio-serial-bus.c | 54 -- 1 file

Re: [Spice-devel] [RFC] [PATCH spice-gtk 0/4] simply implement of file drag-and-drop

2012-11-12 Thread Alon Levy
- Original Message - > > Hi! > > > > > On Mon, Nov 5, 2012 at 10:01 AM, Dunrong Huang < riegama...@gmail.com > > wrote: > > > These patches simply implement file drag-and-drop from client to > guest. > > > > nice! > > > > There are some TODOs needed to be done: > * transfer m

Re: [Spice-devel] spice-server: the guest crash

2012-11-12 Thread Alon Levy
ib64/libspice-server.so.1 > #4 0x7f23ff207585 in red_client_destroy () from > /usr/lib64/libspice-server.so.1 > #5 0x7f23ff236f4a in reds_client_disconnect () from > /usr/lib64/libspice-server.so.1 > #6 0x7f23ff202ce1 in red_channel_client_receive () from > /usr/lib64/libspice

Re: [libvirt] [PATCH v2 2/3] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-12 Thread Alon Levy
> On Sat, Nov 10, 2012 at 15:20:24 +0100, Jiri Denemark wrote: > > On Sat, Nov 10, 2012 at 02:40:24 +0100, Alon Levy wrote: > > > > ACK with that removed. > > Actually, the ACK might have been a bit premature? What QEMU version > is needed > to support multiple g

Re: [libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-12 Thread Alon Levy
[snip] > > I'd prefer if the refactoring of qemuBuildCommandLine was separated > from > removing the limit for number of graphics cards. But since I already > reviewed > the patch and I don't want to do that again, I'm giving a formal ACK > to this > version (with the small issues fixed, of course

Re: [Spice-devel] Spice arm port 2D rendering/requirements

2012-11-10 Thread Alon Levy
> > > Hello, > > I have come to know that GNU/Linux Arm ports for various arm > platforms out there usually dont have a working X server. The GPUs > usually lack a dedicated X server driver. That being the case arm > platforms usually support OpenGLES/OpenVG libraries. spice-gtk arm > port is 2D

Re: [Spice-devel] spice-server: the guest crash

2012-11-10 Thread Alon Levy
> > > > The client connect the guest serval times when the guest play the > movie, the guest is crash. > The error is spice-server : "SpiceWorker-ERROR **: > ../spice-common/common/ring.h:121:ring_next: assertion `pos->next != > NULL && pos->prev != NULL' failed " What is the stack trace when t

[libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
The check for a single display remains so no new functionality is added. --- v2 changes: removed enum, use virReportOOMError directly. use --patience added a one line label fix patch. The second patch changes a string that needs to be translated - how do I go about it? src/qemu/qemu_command.

[libvirt] [PATCH v2 3/3] qemu/qemu_command.c: fix indent of label

2012-11-09 Thread Alon Levy
--- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a1a4523..02a28b3 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -788,7 +788,7 @@ qemuAssignDeviceAliases(virDomainDefPtr de

[libvirt] [PATCH v2 2/3] qemu: graphics support for simultaneous one of each sdl, vnc, spice

2012-11-09 Thread Alon Levy
--- src/qemu/qemu_command.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba99c7a..a1a4523 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6183,9 +6183,26 @@ qemuBuildComma

Re: [libvirt] [PATCH 1/2] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
> On 11/08/2012 07:04 AM, Daniel P. Berrange wrote: > > On Thu, Nov 08, 2012 at 09:48:55AM +0100, Alon Levy wrote: > >> The check for a single display remains so no new functionality is > >> added. > >> --- > >> > >> Concerning both patches,

Re: [libvirt] [PATCH 1/2 RESEND] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
hmm, I'm not using the enum everywhere, I'll send again after fixing (and use --patience). - Original Message - > From: Alon Levy > > The check for a single display remains so no new functionality is > added. > --- > > No change to the patch itself, just

<    2   3   4   5   6   7   8   9   10   11   >