[Lldb-commits] [lldb] r348890 - Add ObjectFileBreakpad.{cpp, h} to the Xcode project.

Author: jingham Date: Tue Dec 11 11:25:03 2018 New Revision: 348890 URL: http://llvm.org/viewvc/llvm-project?rev=348890=rev Log: Add ObjectFileBreakpad.{cpp,h} to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

The current behavior is definitely correct. An Address without a section is generally going to be something like a stack or heap address. Those definitely have load addresses of whatever their value is. I'm not sure what it means to have a file address represented as an offset not a section

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

It the section isn't in the target's SectionLoadList, then GetLoadAddress should return LLDB_INVALID_ADDRESS. I.e. this bit from Section::GetLoadBaseAddress: load_base_addr = target->GetSectionLoadList().GetSectionLoadAddress( const_cast(this)->shared_from_this()); should return

[Lldb-commits] [lldb] r348561 - Add SBInitializerOptions.h to the Xcode project.

Author: jingham Date: Thu Dec 6 18:28:04 2018 New Revision: 348561 URL: http://llvm.org/viewvc/llvm-project?rev=348561=rev Log: Add SBInitializerOptions.h to the Xcode project. And mark it as a public header so it will get copied into the LLDB.framework. A handful of "api" tests were failing

[Lldb-commits] [lldb] r348559 - Handle detecting exec for DynamicLoaderMacOS with older debugservers

Author: jingham Date: Thu Dec 6 17:18:40 2018 New Revision: 348559 URL: http://llvm.org/viewvc/llvm-project?rev=348559=rev Log: Handle detecting exec for DynamicLoaderMacOS with older debugservers that don't send reason:exec. Differential Revision: https://reviews.llvm.org/D55399 Modified:

[Lldb-commits] [lldb] r348519 - Fix the Xcode project build for the addition of NativePDB/DWARFLocationExpression.{h, cpp}

Author: jingham Date: Thu Dec 6 11:23:21 2018 New Revision: 348519 URL: http://llvm.org/viewvc/llvm-project?rev=348519=rev Log: Fix the Xcode project build for the addition of NativePDB/DWARFLocationExpression.{h,cpp} Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r346775 - Since ABI's now hold a process WP, they should be handed

Author: jingham Date: Tue Nov 13 10:18:32 2018 New Revision: 346775 URL: http://llvm.org/viewvc/llvm-project?rev=346775=rev Log: Since ABI's now hold a process WP, they should be handed out one per process rather than keeping a single global instance. Differential Revision:

Re: [Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

For dotest style tests, the debug format to test is chosen by the test driver. All the tests should run with any format, but sometimes there are bugs in one reader or another (or in one version of DWARF or another) so you can skip or xfail a test based on format. Sounds like this test should

[Lldb-commits] [lldb] r346162 - Fix the Xcode project for the removal of the Go, Java & OCaml

Author: jingham Date: Mon Nov 5 12:15:27 2018 New Revision: 346162 URL: http://llvm.org/viewvc/llvm-project?rev=346162=rev Log: Fix the Xcode project for the removal of the Go, Java & OCaml plugins. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

Thanks for doing this! Why do we care about the file name of the test, shouldn't we be using the test class name for everything (that one I did remember to change...) Jim > On Nov 3, 2018, at 11:18 PM, Jan Kratochvil via Phabricator > wrote: > > jankratochvil added a comment. > > In

[Lldb-commits] [lldb] r346053 - Add an SBExpressionOptions setting mirroring the "exec" command's --allow-jit.

Author: jingham Date: Fri Nov 2 16:42:40 2018 New Revision: 346053 URL: http://llvm.org/viewvc/llvm-project?rev=346053=rev Log: Add an SBExpressionOptions setting mirroring the "exec" command's --allow-jit. Differential Revision: https://reviews.llvm.org/D54056 Added:

Re: [Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

gdb's expression parser went out of it's way to allow you to type as little as possible, and to do things that made no sense in the current context (use variables and types in expressions that aren't actually visible in the current context, etc). People's workflows came to really depend on

Re: [Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

I am pretty sure the has is computed from the name string. And BTW, having the base name in the quick lookup tables (either with or alongside the full name) is a really good thing. People using the debugger really don't want to type out fully qualified names as a general rule. So you have to

Re: [Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

Ah, right... Too many patches (a good problem!) The standard as I read it says that the name entry points into the general string table, but doesn't specify which entry it points to. However, the current DWARF debug_info doesn't ever emit a string for the fully qualified name, so you would

Re: [Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

So far as I can tell, this patch will make lookup of exact types faster for PDB, but because of the way DWARF debug_names tables are constructed, I don't think there's any way we can do the same thing for DWARF. But unless I'm misunderstanding the patch, this doesn't change correctness of the

[Lldb-commits] [lldb] r344647 - Return a named error in the result object of an expression with no result

Author: jingham Date: Tue Oct 16 14:58:40 2018 New Revision: 344647 URL: http://llvm.org/viewvc/llvm-project?rev=344647=rev Log: Return a named error in the result object of an expression with no result Before we returned an error that was not exposed in the SB API and no useful error message.

[Lldb-commits] [lldb] r344418 - Change the default handling for SIGPIPE to pass/, no-stop/no-notify.

Author: jingham Date: Fri Oct 12 14:27:49 2018 New Revision: 344418 URL: http://llvm.org/viewvc/llvm-project?rev=344418=rev Log: Change the default handling for SIGPIPE to pass/,no-stop/no-notify. Most of the time SIGPIPE is just annoying, and so we should pass it on silently it by default.

[Lldb-commits] [lldb] r344397 - Add "v" as well as "var" as an alias for "frame var".

Author: jingham Date: Fri Oct 12 11:46:02 2018 New Revision: 344397 URL: http://llvm.org/viewvc/llvm-project?rev=344397=rev Log: Add "v" as well as "var" as an alias for "frame var". Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified:

[Lldb-commits] [lldb] r344102 - Add "var" and "vo" aliases for "frame variable" and "frame variable -O".

Author: jingham Date: Tue Oct 9 17:51:30 2018 New Revision: 344102 URL: http://llvm.org/viewvc/llvm-project?rev=344102=rev Log: Add "var" and "vo" aliases for "frame variable" and "frame variable -O". Differential Revision: https://reviews.llvm.org/D53010 Modified:

[Lldb-commits] [lldb] r342419 - Add docs for scripted breakpoint resolvers

Author: jingham Date: Mon Sep 17 14:55:46 2018 New Revision: 342419 URL: http://llvm.org/viewvc/llvm-project?rev=342419=rev Log: Add docs for scripted breakpoint resolvers Differential Revision: https://reviews.llvm.org/D52065 Modified: lldb/trunk/www/python-reference.html Modified:

[Lldb-commits] [lldb] r342259 - Make the eSearchDepthFunction searches work, add tests

Author: jingham Date: Fri Sep 14 11:41:40 2018 New Revision: 342259 URL: http://llvm.org/viewvc/llvm-project?rev=342259=rev Log: Make the eSearchDepthFunction searches work, add tests using the scripted breakpoint resolver. Differential Revision: https://reviews.llvm.org/D52111 Modified:

[Lldb-commits] [lldb] r342190 - svn add the new files...

Author: jingham Date: Thu Sep 13 14:59:16 2018 New Revision: 342190 URL: http://llvm.org/viewvc/llvm-project?rev=342190=rev Log: svn add the new files... I started from a clean slate to do the checkin, but forgot to svn add the new files. Do that now. Also add the one new source file to

[Lldb-commits] [lldb] r342188 - Remember to sort the Xcode project file. NFC.

Author: jingham Date: Thu Sep 13 14:55:00 2018 New Revision: 342188 URL: http://llvm.org/viewvc/llvm-project?rev=342188=rev Log: Remember to sort the Xcode project file. NFC. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commits

[Lldb-commits] [lldb] r342185 - Add a "scripted" breakpoint type to lldb.

Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py?rev=342185=342184=342185=diff == ---

[Lldb-commits] [lldb] r342185 - Add a "scripted" breakpoint type to lldb.

Author: jingham Date: Thu Sep 13 14:35:32 2018 New Revision: 342185 URL: http://llvm.org/viewvc/llvm-project?rev=342185=rev Log: Add a "scripted" breakpoint type to lldb. This change allows you to write a new breakpoint type where the logic for setting breakpoints is determined by a Python

[Lldb-commits] [lldb] r341690 - NFC: Move Searcher::Depth into lldb-enumerations as SearchDepth.

Author: jingham Date: Fri Sep 7 11:43:04 2018 New Revision: 341690 URL: http://llvm.org/viewvc/llvm-project?rev=341690=rev Log: NFC: Move Searcher::Depth into lldb-enumerations as SearchDepth. In a subsequent commit, I will need to expose the search depth to the SB API's, so I'm moving this

[Lldb-commits] [lldb] r341683 - Add input files to the "prepare swig bindings" step.

Author: jingham Date: Fri Sep 7 11:10:26 2018 New Revision: 341683 URL: http://llvm.org/viewvc/llvm-project?rev=341683=rev Log: Add input files to the "prepare swig bindings" step. This build phase had no inputs, so you always had to manually delete LLDBWrapPython.cpp to get it to rebuild. Add

[Lldb-commits] [lldb] r340053 - Show how to use "lldb -P" to find the lldb.py.

Author: jingham Date: Fri Aug 17 10:39:32 2018 New Revision: 340053 URL: http://llvm.org/viewvc/llvm-project?rev=340053=rev Log: Show how to use "lldb -P" to find the lldb.py. We had hard-coded the path in the docs but that got out of date - showing again that -P is the better way to do this.

[Lldb-commits] [lldb] r339833 - Fix a little thinko in generating ___lldb_unnamed_symbol symbols

Author: jingham Date: Wed Aug 15 16:10:32 2018 New Revision: 339833 URL: http://llvm.org/viewvc/llvm-project?rev=339833=rev Log: Fix a little thinko in generating ___lldb_unnamed_symbol symbols when we have only an in-memory copy of the binary. Also added a test for the generation of these

Re: [Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

It looks like lots of options to debugserver were added without also adding them to the --help output. Probably because there are so few clients they already know the options (the same person added & used them...) But if you look at the actual options in debugserver.cpp, you will see:

[Lldb-commits] [lldb] r339182 - If a function starts with line number 0, don't try to check if a breakpoint crossed function boundaries.

Author: jingham Date: Tue Aug 7 14:09:55 2018 New Revision: 339182 URL: http://llvm.org/viewvc/llvm-project?rev=339182=rev Log: If a function starts with line number 0, don't try to check if a breakpoint crossed function boundaries. clang doesn't use line number 0 (to mean artifically

[Lldb-commits] [lldb] r339181 - Fix the Xcode project for the Core -> Utility moves.

Author: jingham Date: Tue Aug 7 14:05:34 2018 New Revision: 339181 URL: http://llvm.org/viewvc/llvm-project?rev=339181=rev Log: Fix the Xcode project for the Core -> Utility moves. Scalar.{h,cpp}, RegisterValue.{h,cpp}, State.{h,cpp} were moved. Modified:

[Lldb-commits] [lldb] r337515 - Defend LoadImageUsingPaths against a path list

Author: jingham Date: Thu Jul 19 18:20:18 2018 New Revision: 337515 URL: http://llvm.org/viewvc/llvm-project?rev=337515=rev Log: Defend LoadImageUsingPaths against a path list with empty paths on it. Modified:

[Lldb-commits] [lldb] r337058 - Make these tests c++ tests so they can be skipped on systems that don't support those tests.

Author: jingham Date: Fri Jul 13 15:31:59 2018 New Revision: 337058 URL: http://llvm.org/viewvc/llvm-project?rev=337058=rev Log: Make these tests c++ tests so they can be skipped on systems that don't support those tests. Modified:

[Lldb-commits] [lldb] r337035 - Fix the libcxx set, multiset, vector and bitset formatters to work on references.

Author: jingham Date: Fri Jul 13 12:28:32 2018 New Revision: 337035 URL: http://llvm.org/viewvc/llvm-project?rev=337035=rev Log: Fix the libcxx set, multiset, vector and bitset formatters to work on references. The synthetic child providers for these classes had a type expression that matched

[Lldb-commits] [lldb] r337034 - Add the new PDBLocationToDWARFExpression.{cpp, h} to the Xcode project.

Author: jingham Date: Fri Jul 13 12:24:26 2018 New Revision: 337034 URL: http://llvm.org/viewvc/llvm-project?rev=337034=rev Log: Add the new PDBLocationToDWARFExpression.{cpp,h} to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [lldb] r336991 - Add abbreviated name for Debugger::EventHandlerThread.

There's code in the ThreadHandler to handle systems with short thread names. If that isn't producing readable names, we should fix it there. A better algorithm might be to drop the leading "lldb" and then instead of truncating drop vowels (maybe leaving the first vowel after a .) So you'd

[Lldb-commits] [lldb] r336403 - Remove a bunch more references to _LIBCPP_INLINE_VISIBILITY

Author: jingham Date: Thu Jul 5 17:16:21 2018 New Revision: 336403 URL: http://llvm.org/viewvc/llvm-project?rev=336403=rev Log: Remove a bunch more references to _LIBCPP_INLINE_VISIBILITY and adjust the tests that needed it to set their breakpoints more robustly. Modified:

[Lldb-commits] [lldb] r336398 - Address a few post facto review comments from Adrian.

Author: jingham Date: Thu Jul 5 16:23:06 2018 New Revision: 336398 URL: http://llvm.org/viewvc/llvm-project?rev=336398=rev Log: Address a few post facto review comments from Adrian. Thanks, Adrian! Modified: lldb/trunk/include/lldb/Target/Platform.h

[Lldb-commits] [lldb] r336397 - Don't muck with _LIBCPP_INLINE_VISIBILITY just to get predictable line table entries.

Author: jingham Date: Thu Jul 5 16:11:27 2018 New Revision: 336397 URL: http://llvm.org/viewvc/llvm-project?rev=336397=rev Log: Don't muck with _LIBCPP_INLINE_VISIBILITY just to get predictable line table entries. This test was trying to stop at a variety of std::vector calls. It looks like

Re: [Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

Sure, that also sounds fine. Jim > On Jun 29, 2018, at 11:55 AM, Dave Lee via Phabricator > wrote: > > kastiglione added a comment. > > Thanks @jingham. > >> if the `IOHandlerDelegate` could say whether it wants to be notified for >> `IOHandlerActivated` when non-interactive (like have a

Re: [Lldb-commits] [lldb] r335956 - Fix TestLoadUsingPaths on linux

Thanks for fixing this. Jim > On Jun 29, 2018, at 2:22 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Fri Jun 29 02:22:07 2018 > New Revision: 335956 > > URL: http://llvm.org/viewvc/llvm-project?rev=335956=rev > Log: > Fix TestLoadUsingPaths on linux > > we need to

[Lldb-commits] [lldb] r335912 - Add a way to load an image using a library name and list of paths.

Author: jingham Date: Thu Jun 28 13:02:11 2018 New Revision: 335912 URL: http://llvm.org/viewvc/llvm-project?rev=335912=rev Log: Add a way to load an image using a library name and list of paths. This provides an efficient (at least on Posix platforms) way to offload to the target process the

[Lldb-commits] [lldb] r335690 - Use the API's to get the TargetSP.

Author: jingham Date: Tue Jun 26 16:54:50 2018 New Revision: 335690 URL: http://llvm.org/viewvc/llvm-project?rev=335690=rev Log: Use the API's to get the TargetSP. Modified: lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp Modified:

[Lldb-commits] [lldb] r335689 - The Process class ivar ivar was changed to a weak pointer, but was still _sp.

Author: jingham Date: Tue Jun 26 16:38:58 2018 New Revision: 335689 URL: http://llvm.org/viewvc/llvm-project?rev=335689=rev Log: The Process class ivar ivar was changed to a weak pointer, but was still _sp. Fix that to _wp. Modified: lldb/trunk/include/lldb/Target/Process.h

[Lldb-commits] [lldb] r335688 - This is not a debug info sensitive test.

Author: jingham Date: Tue Jun 26 16:31:44 2018 New Revision: 335688 URL: http://llvm.org/viewvc/llvm-project?rev=335688=rev Log: This is not a debug info sensitive test. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py Modified:

[Lldb-commits] [lldb] r335659 - Reverting r335656, SWIG doesn't like "enum class".

Author: jingham Date: Tue Jun 26 13:40:29 2018 New Revision: 335659 URL: http://llvm.org/viewvc/llvm-project?rev=335659=rev Log: Reverting r335656, SWIG doesn't like "enum class". Modified: lldb/trunk/include/lldb/lldb-enumerations.h Modified: lldb/trunk/include/lldb/lldb-enumerations.h

Re: [Lldb-commits] [lldb] r335401 - Update cmdtemplate.py to use best pratices.

> On Jun 22, 2018, at 5:20 PM, Jim Ingham wrote: > > This is very cool! > > Could we make a base class for lldb commands in the lldb module that provides > register_lldb_command? Then you wouldn't have to copy and paste this > boiler-plate in every command file. Now that you have a

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 22, 2018, at 4:05 AM, Pavel Labath wrote: > > On Wed, 20 Jun 2018 at 23:21, Jim Ingham wrote: >> >> It is not uncommon that you would be parsing the DWARF for module A and find >> a type that is only known as a forward declaration. In that case, lldb will >> look through the

Re: [Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

> On Jun 22, 2018, at 3:19 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I think this would be a very nice feature for lldb. Thank you for working on > this. > > However, I am somewhat worried about how you're hooking the expression > completer into the

Re: [Lldb-commits] [PATCH] D48450: [DataFormatter] Add CFDictionary data formatter

Yes, I really wish unittest2 allowed non-aborting tests. If you split up all these tests, then you make the testsuite have to build and run some little executable over and over. It would be so nice if there were a way to say: self.startTestBundle() self.assertTrue(something) ...

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

Part of gdb's slow startup used to be because it built its indexes manually. But also, while gdb does do lazy ingestion of debug information it's laziness is (or was last time I looked at it) on a compile-unit boundary, so when you stop in a file that includes a many complex types you can end

Re: [Lldb-commits] [lldb] r335236 - ScriptInterpreterPython cleanup

This change will break building from Xcode without Python. It will take a bunch of monkeying with the project files to achieve the same effect as your cmake changes, and I don't have time to do that right now. I have no problem with changing cmake to just not build the relevant files, but can

Re: [Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

> On Jun 20, 2018, at 3:14 PM, Frederic Riss via Phabricator > wrote: > > friss added a comment. > > In https://reviews.llvm.org/D48393#1138398, @zturner wrote: > >> Long term I think one potentially interesting possibility for solving a lot >> of these threading and lazy evaluation issues

Re: [Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

The client won't be expecting a struct return, and will have generated code to take a void return. If SBError happens to be returned in registers, nothing bad will happen, but if it's returned on the stack, that would corrupt the caller's stack. Relying on the particular kind of struct return

Re: [Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

Won't this break client code that was calling StepOver? We are pretty serious about maintaining binary compatibility with the SB API's. Jim > On Jun 20, 2018, at 11:19 AM, Alexander Polyakov via Phabricator > wrote: > > apolyakov added a comment. > > I think we just can make old versions

Re: [Lldb-commits] [PATCH] D47991: Improve SBThread's stepping API using SBError parameter.

The SB API's tend to take SBError as an in/out parameter for the cases where the function in question naturally returns some other value, and return an SBError when there's no other logical return value. So in these cases it would be more in line with the general practice to return an SBError.

Re: [Lldb-commits] [PATCH] D48177: Suppress SIGSEGV on Android when the program will recover

Thanks for the explanation! Jim > On Jun 15, 2018, at 2:35 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > Thank you for implementing this. We've had code like this in android studio > for a long time, but it's definitely better doing it in lldb instead. > > I'll

Re: [Lldb-commits] [lldb] r334439 - Add a new SBTarget::LoadCore() overload which surfaces errors if the load fails

> On Jun 11, 2018, at 2:19 PM, Leonard Mosescu via lldb-commits > wrote: > > Author: lemo > Date: Mon Jun 11 14:19:26 2018 > New Revision: 334439 > > URL: http://llvm.org/viewvc/llvm-project?rev=334439=rev > Log: > Add a new SBTarget::LoadCore() overload which surfaces errors if the load >

[Lldb-commits] [lldb] r333971 - Add ClangHost.cpp to the Xcode project.

Author: jingham Date: Mon Jun 4 17:19:03 2018 New Revision: 333971 URL: http://llvm.org/viewvc/llvm-project?rev=333971=rev Log: Add ClangHost.cpp to the Xcode project. Also add an include that was needed for the if APPLE branch of the function. Modified:

[Lldb-commits] [lldb] r333238 - Add DWARFBaseDie.{h, cpp} to the Xcode build.

Author: jingham Date: Thu May 24 16:33:27 2018 New Revision: 333238 URL: http://llvm.org/viewvc/llvm-project?rev=333238=rev Log: Add DWARFBaseDie.{h,cpp} to the Xcode build. This should unbreak the green dragon bot builds. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r333207 - Add SystemInitializerLLGS to the lldb-server target.

Author: jingham Date: Thu May 24 10:06:11 2018 New Revision: 333207 URL: http://llvm.org/viewvc/llvm-project?rev=333207=rev Log: Add SystemInitializerLLGS to the lldb-server target. This should unbreak the xcode build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

> On May 23, 2018, at 7:21 PM, Zachary Turner wrote: > > > On Wed, May 23, 2018 at 7:04 PM Jim Ingham via Phabricator > wrote: > jingham added a comment. > > I worry when concerns of layering which seem a little artificial to me would > make

Re: [Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

The expression command had two modes before introducing the REPL. You can do: (lldb) expr -- some C expression or you can do: (lldb) expr Enter expressions, then terminate with an empty line to evaluate: 1: first C expression 2: Second C Expression 3: The second only differs from the

Re: [Lldb-commits] [PATCH] D43984: Make the clang module cache setting available without a target

Where clang stores modules by default on the host system seems like a Host function. It isn't in practice because that gets delegated to clang to do the host specific calculation, but in theory that seems where the functionality properly belongs. It's a little odd to have ModuleList depend on

Re: [Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

0) >> - breakpoint set --address 0x1010 >> - continue (server pretends to stop at 0x1010) >> - continue (after the first $s packet, server stays at 0x1010, after the >> second one it advances to 0x1011, after the final $c, return W00) >> - verify the expected packet

Re: [Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

> - continue (after the first $s packet, server stays at 0x1010, after the > second one it advances to 0x1011, after the final $c, return W00) > - verify the expected packets were sent > > Have you tried using MockGdbServer in this way? > > regards, > pl > > On Tue, 22 M

[Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

Author: jingham Date: Mon May 21 17:06:55 2018 New Revision: 332922 URL: http://llvm.org/viewvc/llvm-project?rev=332922=rev Log: Work around some odd instruction single-step behavior on macOS. We've seen some cases on macOS where you go to instruction single step (over a breakpoint), and single

[Lldb-commits] [lldb] r332914 - Fix the Xcode project for the refactoring of the

Author: jingham Date: Mon May 21 15:41:28 2018 New Revision: 332914 URL: http://llvm.org/viewvc/llvm-project?rev=332914=rev Log: Fix the Xcode project for the refactoring of the DWARF reader. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r331501 - Add children and child[N] properties to SBValue.i.

Author: jingham Date: Thu May 3 18:31:47 2018 New Revision: 331501 URL: http://llvm.org/viewvc/llvm-project?rev=331501=rev Log: Add children and child[N] properties to SBValue.i. Also fixed some bad formatting in SBValue.i. Modified:

Re: [Lldb-commits] [lldb] r331049 - Always normalize FileSpec paths.

Greg, Your new FileSpecTest unit tests are failing in the Xcode build of lldb, e.g.: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/6271/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671 Can you figure out what's up with this? Jim BTW, the "reply to" for lldb-commits mails

[Lldb-commits] [lldb] r331012 - Fix a thinko in the iteration over StructuredDataPlugin Create functions.

Author: jingham Date: Thu Apr 26 18:57:40 2018 New Revision: 331012 URL: http://llvm.org/viewvc/llvm-project?rev=331012=rev Log: Fix a thinko in the iteration over StructuredDataPlugin Create functions. The code was grabbing the first plugin, and then never getting another one. Modified:

[Lldb-commits] [lldb] r330460 - Fix the Xcode gtest target for the move of FileSpecTest.cpp.

Author: jingham Date: Fri Apr 20 11:30:31 2018 New Revision: 330460 URL: http://llvm.org/viewvc/llvm-project?rev=330460=rev Log: Fix the Xcode gtest target for the move of FileSpecTest.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r330214 - Change PlatformPosix::DoLoadImage to use a UtilityFunction.

Author: jingham Date: Tue Apr 17 13:44:47 2018 New Revision: 330214 URL: http://llvm.org/viewvc/llvm-project?rev=330214=rev Log: Change PlatformPosix::DoLoadImage to use a UtilityFunction. That way we won't have to compile a new expression every time we want dlopen a library. Differential

[Lldb-commits] [lldb] r330211 - Fix the xcode project for the Args -> Utility move.

Author: jingham Date: Tue Apr 17 13:35:00 2018 New Revision: 330211 URL: http://llvm.org/viewvc/llvm-project?rev=330211=rev Log: Fix the xcode project for the Args -> Utility move. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r329844 - Fix a thinko in CommandObjectMemoryRegion.

Author: jingham Date: Wed Apr 11 12:27:03 2018 New Revision: 329844 URL: http://llvm.org/viewvc/llvm-project?rev=329844=rev Log: Fix a thinko in CommandObjectMemoryRegion. Don't try to read the first argument till you've checked that there is one. Modified:

[Lldb-commits] [lldb] r329745 - Convert an absolute to a group relative reference for TestOptionArgParser.cpp.

Author: jingham Date: Tue Apr 10 12:29:37 2018 New Revision: 329745 URL: http://llvm.org/viewvc/llvm-project?rev=329745=rev Log: Convert an absolute to a group relative reference for TestOptionArgParser.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r329727 - Fix a typo in the gtest build target for Debug configuration.

Author: jingham Date: Tue Apr 10 10:49:56 2018 New Revision: 329727 URL: http://llvm.org/viewvc/llvm-project?rev=329727=rev Log: Fix a typo in the gtest build target for Debug configuration. I usually run DebugClang... Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r329722 - Fix the Xcode build for the addition of OptionArgsParser.

Author: jingham Date: Tue Apr 10 10:20:27 2018 New Revision: 329722 URL: http://llvm.org/viewvc/llvm-project?rev=329722=rev Log: Fix the Xcode build for the addition of OptionArgsParser. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r328721 - Revert r328715. Wasn't wrong, just not the issue.

Author: jingham Date: Wed Mar 28 11:05:43 2018 New Revision: 328721 URL: http://llvm.org/viewvc/llvm-project?rev=328721=rev Log: Revert r328715. Wasn't wrong, just not the issue. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py Modified:

[Lldb-commits] [lldb] r328715 - Explicitly import subprocess

Author: jingham Date: Wed Mar 28 10:06:23 2018 New Revision: 328715 URL: http://llvm.org/viewvc/llvm-project?rev=328715=rev Log: Explicitly import subprocess For some reason on one of our bots subprocess wasn't already imported. Do so explicitly. Modified:

[Lldb-commits] [lldb] r328389 - Add support for __attribute__(trivial_abi).

Author: jingham Date: Fri Mar 23 16:44:52 2018 New Revision: 328389 URL: http://llvm.org/viewvc/llvm-project?rev=328389=rev Log: Add support for __attribute__(trivial_abi). , Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

> On Mar 20, 2018, at 4:55 AM, Pavel Labath via lldb-commits > wrote: > > Deleting the test build dir is fairly easy. I can whip up a patch for that, > but I'm not sure if that's the part that is bothering you the most here. > Dealing with the log files is a bot

[Lldb-commits] [lldb] r327941 - Add a suggestion to convert dotest tests to use run_to_source_breakpoint.

Author: jingham Date: Mon Mar 19 19:15:23 2018 New Revision: 327941 URL: http://llvm.org/viewvc/llvm-project?rev=327941=rev Log: Add a suggestion to convert dotest tests to use run_to_source_breakpoint. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

So that file you are looking for is "packages/Python/lldbsuite/test/README-testsuite. It would be great to have a fresh pair of eyes look this over and add whatever you would have found useful... Jim > On Mar 19, 2018, at 6:44 PM, Davide Italiano wrote: > > On Mon,

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

to find this? Jim > On Mar 19, 2018, at 6:31 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Mon, Mar 19, 2018 at 4:15 PM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> Author: jingham >> Date: Mon Mar 19 16:15:06 2018 >

[Lldb-commits] [lldb] r327924 - Modernize a test.

Author: jingham Date: Mon Mar 19 16:15:06 2018 New Revision: 327924 URL: http://llvm.org/viewvc/llvm-project?rev=327924=rev Log: Modernize a test. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py Modified:

[Lldb-commits] [lldb] r327448 - Add a missing return in SBPlatform::IsConnected and test

Author: jingham Date: Tue Mar 13 14:06:05 2018 New Revision: 327448 URL: http://llvm.org/viewvc/llvm-project?rev=327448=rev Log: Add a missing return in SBPlatform::IsConnected and test for the behavior - using the fact that the Host platform is always present & connected. Modified:

[Lldb-commits] [lldb] r327331 - Re-add change for https://reviews.llvm.org/D42582 with added directories.

Author: jingham Date: Mon Mar 12 14:17:04 2018 New Revision: 327331 URL: http://llvm.org/viewvc/llvm-project?rev=327331=rev Log: Re-add change for https://reviews.llvm.org/D42582 with added directories. Added: lldb/trunk/lit/Breakpoint/Inputs/ppc64-localentry.s

[Lldb-commits] [lldb] r327318 - Improve prologue handling to support functions with multiple entry points.

Author: jingham Date: Mon Mar 12 12:21:59 2018 New Revision: 327318 URL: http://llvm.org/viewvc/llvm-project?rev=327318=rev Log: Improve prologue handling to support functions with multiple entry points. https://reviews.llvm.org/D42582 Patch from Leandro Lupori. Modified:

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

> On Mar 8, 2018, at 2:49 AM, Pavel Labath wrote: > > > > > On Thu, 8 Mar 2018 at 02:46, Davide Italiano wrote: > On Wed, Mar 7, 2018 at 6:39 PM, Jim Ingham wrote: > > The hashing algorithm gives different values - at least for

Re: [Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

The hashing algorithm gives different values - at least for foobár - between the two implementations. So if you build with an older clang, and test with a new lldb, the type lookup fails. Were the two algorithms supposed to be identical? It will mean that type lookups in the output of older

Re: [Lldb-commits] [lldb] r326449 - Make TestDynamicValueSameBase gcc-compatible

Thanks! Jim > On Mar 1, 2018, at 8:56 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Mar 1 08:56:28 2018 > New Revision: 326449 > > URL: http://llvm.org/viewvc/llvm-project?rev=326449=rev > Log: > Make TestDynamicValueSameBase

Re: [Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

I have no general objections to macros, and reducing boiler-plate is good. They do get in the way of debugging because of the weird C rule that a macro has to pretend that it is all one source line, so if they contain code you are interested in stopping at, there needs to be some other way to

[Lldb-commits] [lldb] r326412 - We were getting the wrong dynamic type if there were two classes with the same basename.

Author: jingham Date: Wed Feb 28 18:44:34 2018 New Revision: 326412 URL: http://llvm.org/viewvc/llvm-project?rev=326412=rev Log: We were getting the wrong dynamic type if there were two classes with the same basename. There's a bug in FindTypes, it ignores the exact flag if you pass a name that

[Lldb-commits] [lldb] r326378 - Fix up the gtest targets for changes in the UnwindAssembly tests.

Author: jingham Date: Wed Feb 28 14:41:11 2018 New Revision: 326378 URL: http://llvm.org/viewvc/llvm-project?rev=326378=rev Log: Fix up the gtest targets for changes in the UnwindAssembly tests. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

Sure, as long as we aren't turning the output of the "break set" or other commands into test API - which your version of this lit test does not - then this sort of test seems fine to me. When we were starting out and building up the set of tests available I at least tended to err on the side

[Lldb-commits] [lldb] r325958 - Fix breakpoint thread name conditionals after breakpoint options refactor.

Author: jingham Date: Fri Feb 23 13:10:42 2018 New Revision: 325958 URL: http://llvm.org/viewvc/llvm-project?rev=325958=rev Log: Fix breakpoint thread name conditionals after breakpoint options refactor. PR36435 Modified:

Re: [Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

To be fair, you could probably have made the dotest.py version of the test close to as fast by not running a process. The old test was testing that we got a location for the breakpoint AND hit it. The latter was probably overkill. But the two tests aren't testing the same thing. > On Feb

Re: [Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

We don’t parse libraries beyond getting sections until we look for symbols, this doesn’t seem to slow startup noticeably, and since I find it super useful especially for a program like lldb, where the driver has very little code in it and most of the functionality is in libraries, I’m happy

<    1   2   3   4   5   6   7   8   9   10   >