Re: [Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

Note that the breakpoint location's site gets cleared when you disable the breakpoint or its location, as well as when you delete it. So if you have a workflow that does: "hit a breakpoint, disable it, hit another, reenable the first, hit the second" you'll end up re-evaluating the condition

Re: [Lldb-commits] [PATCH] D29615: Convert Log class to llvm streams

> On Feb 6, 2017, at 7:19 PM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > The log callback gets passed down from the SB API (in the SBDebugger > constructor, no less). My best guess is that it is (was?) used to display

Re: [Lldb-commits] [PATCH] D29510: Remove LIBLLDB_LOG_VERBOSE category

Not to be snarky, but that's why we put comments in headers... Jim > On Feb 3, 2017, at 4:47 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > I guess the same way you would know how to use any part of a library or API. > The first time

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

I don't think any of this should be terribly controversial. The "Long term" part of the proposals might be, but that's not what you're talking about here, right? These changes will presumably require adjustments to the Xcode project. If you can do that yourself, then that's great. If you

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

BTW, not to exclude the positive because it doesn't need discussing: all the rest of the changes you were proposing seem appropriate and good to me. Thanks for taking the trouble to clean this up. Jim > On Jan 31, 2017, at 5:45 PM, Zachary Turner wrote: > > Yea, there

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

Yeah, I have no idea how you'd make sure that the SBError returned to Python in a Python SBValue was checked before it went out of scope, and I'm not sure it's our business to be enforcing that... So we're going to have to do something special for those errors. We also use the pattern where

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

I think we discussed this before, but we need an informational error object. IIRC, the llvm::Error has to be checked. But for instance if you ask a value object to evaluate itself, but you've moved to a section of code where the variable has no location, then evaluating that value will result

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

My vote is to err on the side of leaving stuff in Utility that is general (like SharingPtr) but only used by one client, rather than moving it next to its current only client. After all, you are likely to go dumpster diving in Utility when you need a tool, but you're less likely to look

Re: [Lldb-commits] [PATCH] D29359: Start breaking some dependencies in lldbUtility

> On Jan 31, 2017, at 3:59 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > zturner created this revision. > Herald added a subscriber: mgorny. > > The goal here is to make `lldbUtility` a library which depends on no other > libraries. It seems

[Lldb-commits] [lldb] r290216 - Ignore SIGPIPE in the mini-driver used by these tests.

Author: jingham Date: Tue Dec 20 18:12:54 2016 New Revision: 290216 URL: http://llvm.org/viewvc/llvm-project?rev=290216=rev Log: Ignore SIGPIPE in the mini-driver used by these tests. We're seeing some very occasional failures in these tests where the mini-driver dies with a SIGPIPE. We don't

[Lldb-commits] [lldb] r289746 - Fix incorrectly named variables.

Author: jingham Date: Wed Dec 14 18:30:30 2016 New Revision: 289746 URL: http://llvm.org/viewvc/llvm-project?rev=289746=rev Log: Fix incorrectly named variables. Modified: lldb/trunk/source/API/SBFrame.cpp lldb/trunk/source/API/SBTarget.cpp

[Lldb-commits] [lldb] r289695 - Test num locations >= 1 not == 1.

Author: jingham Date: Wed Dec 14 13:35:56 2016 New Revision: 289695 URL: http://llvm.org/viewvc/llvm-project?rev=289695=rev Log: Test num locations >= 1 not == 1. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py

Re: [Lldb-commits] [PATCH] D27394: Fix expression evaluation inside lambda functions for gcc

> On Dec 6, 2016, at 1:42 AM, Tamas Berghammer via Phabricator > wrote: > > tberghammer added a reviewer: aprantl. > tberghammer added a comment. > > +Adrian > > Thank you for all the comment. I agree that teaching the AST Importer to be > able to handle types

Re: [Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

> On Dec 2, 2016, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > >> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know

[Lldb-commits] [PATCH] D26883: Demonstrate proposed new Args API

jingham added a comment. In https://reviews.llvm.org/D26883#600683, @labath wrote: > I don't know how deep do you want this refactor to be, but there is one issue > I would like us to consider, if only to decide it is out of scope of this > change. I am talking about the `quote_char` thingy.

[Lldb-commits] [lldb] r287386 - Fix "thread step until" handling of multiple line inputs.

Author: jingham Date: Fri Nov 18 16:06:10 2016 New Revision: 287386 URL: http://llvm.org/viewvc/llvm-project?rev=287386=rev Log: Fix "thread step until" handling of multiple line inputs. Also document that it handles same, and add some tests. Added:

Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

Not a big deal. Formal changes are fine, but even dead code in areas you don’t work on might represent a work in progress, so it’s good to ask first. For instance, Enrico and Greg originally had plans for “frame var” to be able to print slices of arrays - that’s presumably the dead code

Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

I didn’t see this patch go up for review. The parameter you removed might have been vestigial or might have been one that the owner of this code was planning to do something with. Anyway, this seems to go beyond purely formal changes and so should have been discussed. My apologies if I just

Re: [Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

If we are going to do that, I wonder if we should start having tests share their inputs. We don’t do that for source files because the cost of duplication is so small, and then you don’t have the hassle of adding something to a source fie for test A messes up test B. But for binaries like

[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

jingham added a comment. Excellent, thanks for catching that. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

Ah, good catch. That is not right. If there’s inlined function information, you want to make sure you haven’t gone from one inlined function to another. But the symbol is always going to be the same in this case. Actually, the old code is a overly restrictive by comparing the blocks

[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That way of doing it is fine too. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r287189 - Make GetValueForVariableExpression use StringRef.

Probably just an oversight, but changing var_expr_cstr to a StringRef, but leaving it called "_cstr" will cause confusion. Jim > On Nov 16, 2016, at 5:37 PM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Wed Nov 16 19:37:52 2016 > New

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

jingham added a comment. Besides Greg's comments, this looks reasonable to me. https://reviews.llvm.org/D26676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26528: Fix uninitialized members.

jingham accepted this revision. jingham added a reviewer: jingham. jingham added a comment. This revision is now accepted and ready to land. Looks fine to me. https://reviews.llvm.org/D26528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26553: Remove weak-linked symbols for SBBreakpointListImpl

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine. https://reviews.llvm.org/D26553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

Is it worthwhile having some place where we can put this sort of policy so people don't have to follow our mailing list to know this sort of rule? The coding conventions were one possible site, but that fell victim to the code reformat... Jim > On Nov 11, 2016, at 9:11 AM, Zachary Turner

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

> On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits > wrote: > > Maybe just inline the initializations so we don't have to repeat code across > multiple constructors? i.e. > > bool m_is_resolved = false; > > in the header file. I actually like the

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D26470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

jingham added a comment. This is fine with one comment on the text. Comment at: SB-api-coding-rules.html:51-54 +An example of this is the SBValue class. Please note it is necessary for the Impl class to +

[Lldb-commits] [lldb] r286312 - "thread backtrace" should use the thread-stop-format.

Author: jingham Date: Tue Nov 8 17:43:36 2016 New Revision: 286312 URL: http://llvm.org/viewvc/llvm-project?rev=286312=rev Log: "thread backtrace" should use the thread-stop-format. Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp Modified:

[Lldb-commits] [lldb] r286301 - Fix up the formats.html for the addition of the thread-stop-format.

Author: jingham Date: Tue Nov 8 16:05:29 2016 New Revision: 286301 URL: http://llvm.org/viewvc/llvm-project?rev=286301=rev Log: Fix up the formats.html for the addition of the thread-stop-format. Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL:

[Lldb-commits] [lldb] r286288 - Clean up the stop printing header lines.

Author: jingham Date: Tue Nov 8 14:36:40 2016 New Revision: 286288 URL: http://llvm.org/viewvc/llvm-project?rev=286288=rev Log: Clean up the stop printing header lines. I added a "thread-stop-format" to distinguish between the form that is just the thread info (since the stop printing

[Lldb-commits] [PATCH] D26325: Re-write OutputFormattedHelpText in terms of StringRef

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks formally equivalent to me. https://reviews.llvm.org/D26325 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r286170 - UserExpression::Evaluate only returns a non-empty ValueObjectSP

Author: jingham Date: Mon Nov 7 16:47:01 2016 New Revision: 286170 URL: http://llvm.org/viewvc/llvm-project?rev=286170=rev Log: UserExpression::Evaluate only returns a non-empty ValueObjectSP if it returns eExpressionCompleted. Don't try to get the error from the ValueObjectSP if that's not

[Lldb-commits] [lldb] r285977 - Added a couple more odd dot patterns that we got out

Author: jingham Date: Thu Nov 3 20:47:59 2016 New Revision: 285977 URL: http://llvm.org/viewvc/llvm-project?rev=285977=rev Log: Added a couple more odd dot patterns that we got out of clang. Modified: lldb/trunk/unittests/Host/FileSpecTest.cpp Modified:

[Lldb-commits] [lldb] r285781 - Fix SBWatchpoint::SetEnabled to send an event.

Author: jingham Date: Tue Nov 1 20:06:42 2016 New Revision: 285781 URL: http://llvm.org/viewvc/llvm-project?rev=285781=rev Log: Fix SBWatchpoint::SetEnabled to send an event. We really shouldn't be sending events for SB API's, dunno when we started doing that. We don't do it for other things.

[Lldb-commits] [lldb] r285761 - Xfail this while I figure out why the event isn't getting sent.

Author: jingham Date: Tue Nov 1 17:53:54 2016 New Revision: 285761 URL: http://llvm.org/viewvc/llvm-project?rev=285761=rev Log: Xfail this while I figure out why the event isn't getting sent. Modified:

[Lldb-commits] [lldb] r285742 - Switch SBWatchpoint::SetEnabled over to using Process::{Enable, Disable}Watchpoint.

Author: jingham Date: Tue Nov 1 15:37:02 2016 New Revision: 285742 URL: http://llvm.org/viewvc/llvm-project?rev=285742=rev Log: Switch SBWatchpoint::SetEnabled over to using Process::{Enable,Disable}Watchpoint. We don't have a good story for what happens to watchpoints when you don't have a

[Lldb-commits] [lldb] r285153 - SBWatchpoint::Disable doesn't actually work. Add a test that shows this.

Author: jingham Date: Tue Oct 25 20:09:21 2016 New Revision: 285153 URL: http://llvm.org/viewvc/llvm-project?rev=285153=rev Log: SBWatchpoint::Disable doesn't actually work. Add a test that shows this. Next to fix it! Added:

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

I already fixed this in r285113. Jim > On Oct 25, 2016, at 2:49 PM, Tim Hammerquist via lldb-commits > wrote: > > Hi Pavel, > > Looks like some code left after this revert is still expecting this file > (added contemporary to r284828) that was removed in this

[Lldb-commits] [lldb] r285114 - Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process.

Author: jingham Date: Tue Oct 25 15:34:32 2016 New Revision: 285114 URL: http://llvm.org/viewvc/llvm-project?rev=285114=rev Log: Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process. This closes https://reviews.llvm.org/D25875. Modified:

[Lldb-commits] [lldb] r285113 - Fixing up the project file for the removal of LibStdcppSmartPointer.cpp.

Author: jingham Date: Tue Oct 25 15:32:26 2016 New Revision: 285113 URL: http://llvm.org/viewvc/llvm-project?rev=285113=rev Log: Fixing up the project file for the removal of LibStdcppSmartPointer.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

Re: [Lldb-commits] [lldb] r284817 - Revert "Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands."

Note that the WatchpointSentry logic predated the support for "!watchpoint_triggers_after", and it's real goal was to have accesses to the watchpoint in commands in the breakpoint action not re-trigger the watchpoint. The step-over-watchpoint logic was accidentally getting the benefit of this,

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

the same state. But that's a question for another day. Jim > On Oct 21, 2016, at 11:05 AM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Yeah, sorry, that was an oversight on my part, but I think it's trivial to > fix. The WatchpointSentry wa

[Lldb-commits] [lldb] r284851 - Add the new stdcpp formatters to the Xcode project.

Author: jingham Date: Fri Oct 21 13:18:25 2016 New Revision: 284851 URL: http://llvm.org/viewvc/llvm-project?rev=284851=rev Log: Add the new stdcpp formatters to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

Yeah, sorry, that was an oversight on my part, but I think it's trivial to fix. The WatchpointSentry was being set up before the little single step over the watchpoint dance, and it was accidentally being used to get the watchpoint disabled. That's not the main point of the sentry, which is

[Lldb-commits] [lldb] r284795 - Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands.

Author: jingham Date: Thu Oct 20 19:06:38 2016 New Revision: 284795 URL: http://llvm.org/viewvc/llvm-project?rev=284795=rev Log: Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands. Also, watchpoint commands, like breakpoint commands, need to run in async

[Lldb-commits] [lldb] r284792 - Add an API to remove an action from the Process PreResumeActions.

Author: jingham Date: Thu Oct 20 17:50:00 2016 New Revision: 284792 URL: http://llvm.org/viewvc/llvm-project?rev=284792=rev Log: Add an API to remove an action from the Process PreResumeActions. Modified: lldb/trunk/include/lldb/Target/Process.h lldb/trunk/source/Target/Process.cpp

[Lldb-commits] [lldb] r284791 - Remove an unnecessary and incorrect check for num locations of a breakpoint

Author: jingham Date: Thu Oct 20 17:49:06 2016 New Revision: 284791 URL: http://llvm.org/viewvc/llvm-project?rev=284791=rev Log: Remove an unnecessary and incorrect check for num locations of a breakpoint by grubbing the break list output. If you pass a number of locations into the run_break_*

[Lldb-commits] [PATCH] D25792: Don't set a software stepping breakpoint at 0 on arm.

jingham added a comment. Not commenting on the substance of the change (though it seems sensible to me.) The inclusion of the .gitignore was probably accidental, but in any case, try not to gang unrelated changes together like this. Thanks! https://reviews.llvm.org/D25792

Re: [Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > >> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits >> <lldb-commits@lists.llvm.org> wrote: >> >> >> ===

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

> On Oct 4, 2016, at 9:28 AM, Pavel Labath via lldb-commits > wrote: > > Also, apparently lldb has a bug, where it mishandles the case where you do a > (user-level) single step over an instruction triggering a watchpoint. That > would be pretty important to fix

Re: [Lldb-commits] [PATCH] D25750: When invoking Terminal, don't assume the default shell

I am pretty sure /bin/sh is supposed to be a posix shell. We could probably use that as well if we felt that there might be an OS X without /bin/bash. But we aren't using any but the most basic properties of the shell along this code path. It isn't being done for shell expansion or anything

[Lldb-commits] [lldb] r284448 - Remove a debug print statement.

Author: jingham Date: Mon Oct 17 20:52:32 2016 New Revision: 284448 URL: http://llvm.org/viewvc/llvm-project?rev=284448=rev Log: Remove a debug print statement. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/TestRegisterVariables.py Modified:

[Lldb-commits] [lldb] r284446 - More testsuite xfail markings cleanup.

Author: jingham Date: Mon Oct 17 20:43:22 2016 New Revision: 284446 URL: http://llvm.org/viewvc/llvm-project?rev=284446=rev Log: More testsuite xfail markings cleanup. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py

[Lldb-commits] [lldb] r284439 - Fix a crash in expressions with fixits in the dummy target.

Author: jingham Date: Mon Oct 17 18:59:41 2016 New Revision: 284439 URL: http://llvm.org/viewvc/llvm-project?rev=284439=rev Log: Fix a crash in expressions with fixits in the dummy target. In the expression command, if the target is NULL, you have to use the dummy target. Modified:

[Lldb-commits] [lldb] r284296 - This test is no longer failing for gmodules.

Author: jingham Date: Fri Oct 14 19:04:38 2016 New Revision: 284296 URL: http://llvm.org/viewvc/llvm-project?rev=284296=rev Log: This test is no longer failing for gmodules. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py Modified:

[Lldb-commits] [lldb] r284182 - This test is passing on i386 now.

Author: jingham Date: Thu Oct 13 20:03:03 2016 New Revision: 284182 URL: http://llvm.org/viewvc/llvm-project?rev=284182=rev Log: This test is passing on i386 now. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-class-method/TestObjCClassMethod.py Modified:

[Lldb-commits] [lldb] r283959 - This test now passes.

Author: jingham Date: Tue Oct 11 19:05:36 2016 New Revision: 283959 URL: http://llvm.org/viewvc/llvm-project?rev=283959=rev Log: This test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImport.py Modified:

[Lldb-commits] [lldb] r283956 - Added a radar on our end for this test's failure.

Author: jingham Date: Tue Oct 11 18:30:38 2016 New Revision: 283956 URL: http://llvm.org/viewvc/llvm-project?rev=283956=rev Log: Added a radar on our end for this test's failure. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py Modified:

[Lldb-commits] [lldb] r283940 - Add the radar number on our end.

Author: jingham Date: Tue Oct 11 16:08:27 2016 New Revision: 283940 URL: http://llvm.org/viewvc/llvm-project?rev=283940=rev Log: Add the radar number on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py Modified:

[Lldb-commits] [lldb] r283929 - This test now passes.

Author: jingham Date: Tue Oct 11 15:09:40 2016 New Revision: 283929 URL: http://llvm.org/viewvc/llvm-project?rev=283929=rev Log: This test now passes. Modified:

[Lldb-commits] [lldb] r283923 - Added a bugreport tracking the failure to get float return values

Author: jingham Date: Tue Oct 11 14:29:25 2016 New Revision: 283923 URL: http://llvm.org/viewvc/llvm-project?rev=283923=rev Log: Added a bugreport tracking the failure to get float return values on i386. Modified:

[Lldb-commits] [lldb] r283578 - The PR that caused this test ot fail was fixed in July, removing the XFAIL.

Author: jingham Date: Fri Oct 7 13:15:11 2016 New Revision: 283578 URL: http://llvm.org/viewvc/llvm-project?rev=283578=rev Log: The PR that caused this test ot fail was fixed in July, removing the XFAIL. Modified:

[Lldb-commits] [lldb] r283479 - StringRef::front asserts on empty strings, causing "break modify -c ''" to assert.

Author: jingham Date: Thu Oct 6 13:57:30 2016 New Revision: 283479 URL: http://llvm.org/viewvc/llvm-project?rev=283479=rev Log: StringRef::front asserts on empty strings, causing "break modify -c ''" to assert. Added a check for empty at the point where we were going to crash. Modified:

[Lldb-commits] [lldb] r283468 - These test cases don't test different debug info formats.

Author: jingham Date: Thu Oct 6 12:01:00 2016 New Revision: 283468 URL: http://llvm.org/viewvc/llvm-project?rev=283468=rev Log: These test cases don't test different debug info formats. Modified:

[Lldb-commits] [lldb] r283289 - The collision of class C and libsystem_c.dylib:C is a failure

Author: jingham Date: Tue Oct 4 20:19:15 2016 New Revision: 283289 URL: http://llvm.org/viewvc/llvm-project?rev=283289=rev Log: The collision of class C and libsystem_c.dylib:C is a failure worth preserving, but not essential to the purpose of this test so I broke it into a separate test.

[Lldb-commits] [lldb] r283287 - This test is failing because there's a global symbol "C" in libsystem_c.dylib,

Author: jingham Date: Tue Oct 4 20:09:43 2016 New Revision: 283287 URL: http://llvm.org/viewvc/llvm-project?rev=283287=rev Log: This test is failing because there's a global symbol "C" in libsystem_c.dylib, and that is defeating the lookup of the "struct C" here. Adding the bug for that.

[Lldb-commits] [lldb] r283276 - Add the new minidump files to the Xcode project.

Author: jingham Date: Tue Oct 4 19:07:01 2016 New Revision: 283276 URL: http://llvm.org/viewvc/llvm-project?rev=283276=rev Log: Add the new minidump files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

Ah, missed it there. No it is fine to put it in the header. Jim > On Oct 4, 2016, at 2:37 PM, Zachary Turner wrote: > > zturner added inline comments. > > >> jingham wrote in BreakpointIDList.cpp:329-330 >> Did you upload the latest version of your patch, I don't see a

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. No good deed goes unpunished... You made ParseCanonicalReference more beautiful but forgot to update the header doc. Also I didn't see the comment for SplitIDRangeExpression.

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks correct to me. I had a couple of trivial inline comments, but this looks fine. > BreakpointID.cpp:80-81 > > -bool BreakpointID::ParseCanonicalReference(const char *input, >

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

jingham added a comment. You messed up the meaning of one comment (noted inline). Otherwise this looks fine to me too. > Args.cpp:97-98 > + // Argument can be split into multiple discontiguous pieces, for example: > + // "Hello " "World" > + // this would result in a single argument

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

Ah, okay, thanks! Jim > On Oct 3, 2016, at 1:44 PM, Pavel Labath <lab...@google.com> wrote: > > The test fails on remote targets because it tries to set breakpoints based on > remote paths. We'll have that fixed shortly. > > On 3 October 2016 at 11:13, Jim Ingham v

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

/builders/lldb-x86_64-ubuntu-14.04-android/builds/9655 > > Thanks, > Dimitar > > On Fri, Sep 30, 2016 at 11:07 PM, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Fri Sep 30 17:07:41 2016 > New Revision: 282966

[Lldb-commits] [lldb] r282993 - Fix up this test case.

Author: jingham Date: Fri Sep 30 19:49:12 2016 New Revision: 282993 URL: http://llvm.org/viewvc/llvm-project?rev=282993=rev Log: Fix up this test case. The lldbutil.run_break_set_by_file_and_line has already checked that the number of locations was 1, so don't check it again. And certainly

[Lldb-commits] [lldb] r282976 - Fix up the test so it gets closer to passing.

Author: jingham Date: Fri Sep 30 17:55:57 2016 New Revision: 282976 URL: http://llvm.org/viewvc/llvm-project?rev=282976=rev Log: Fix up the test so it gets closer to passing. Remove the test for thread stopped states from this test. That isn't set properly now, and its setting doesn't matter

[Lldb-commits] [lldb] r282970 - Add the radar on our end to the bugreport string.

Author: jingham Date: Fri Sep 30 17:24:11 2016 New Revision: 282970 URL: http://llvm.org/viewvc/llvm-project?rev=282970=rev Log: Add the radar on our end to the bugreport string. Modified:

[Lldb-commits] [lldb] r282969 - Add the radar from our end to the bugreport string.

Author: jingham Date: Fri Sep 30 17:22:09 2016 New Revision: 282969 URL: http://llvm.org/viewvc/llvm-project?rev=282969=rev Log: Add the radar from our end to the bugreport string. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/completion/TestCompletion.py Modified:

[Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

Author: jingham Date: Fri Sep 30 17:07:41 2016 New Revision: 282966 URL: http://llvm.org/viewvc/llvm-project?rev=282966=rev Log: IsValid is the way to ask a breakpoint location whether it is valid. Modified:

[Lldb-commits] [lldb] r282830 - Add the tracking radar on our end.

Author: jingham Date: Thu Sep 29 20:23:46 2016 New Revision: 282830 URL: http://llvm.org/viewvc/llvm-project?rev=282830=rev Log: Add the tracking radar on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/break_after_join/TestBreakAfterJoin.py Modified:

[Lldb-commits] [lldb] r282810 - Add some logging when trace is on. We're getting a bot failure on i386 that doesn't

Author: jingham Date: Thu Sep 29 18:48:21 2016 New Revision: 282810 URL: http://llvm.org/viewvc/llvm-project?rev=282810=rev Log: Add some logging when trace is on. We're getting a bot failure on i386 that doesn't I can't reproduce locally. Hopefully this will help us catch the reason.

[Lldb-commits] [lldb] r282432 - Fix serialization of Python breakpoint commands.

Author: jingham Date: Mon Sep 26 14:47:37 2016 New Revision: 282432 URL: http://llvm.org/viewvc/llvm-project?rev=282432=rev Log: Fix serialization of Python breakpoint commands. CommandData breakpoint commands didn't know whether they were Python or Command line commands, so they couldn't

Re: [Lldb-commits] [lldb] r282309 - Fix build on Ubuntu.

Not done building yet, I also had to fetch a new llvm, but at least those were needed. Jim > On Sep 23, 2016, at 3:47 PM, Zachary Turner wrote: > > Ahh nvm, I see you beat me to it. Thanks > > On Fri, Sep 23, 2016 at 3:47 PM Zachary Turner wrote: >

[Lldb-commits] [lldb] r282311 - Mutatis mutandis for char * -> StringRef.

Author: jingham Date: Fri Sep 23 17:36:00 2016 New Revision: 282311 URL: http://llvm.org/viewvc/llvm-project?rev=282311=rev Log: Mutatis mutandis for char * -> StringRef. Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL:

Re: [Lldb-commits] [lldb] r282309 - Fix build on Ubuntu.

I think you missed some changes in Host.mm on OS X as well. Jim > On Sep 23, 2016, at 3:27 PM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Fri Sep 23 17:27:03 2016 > New Revision: 282309 > > URL:

Re: [Lldb-commits] [PATCH] D24629: Allow for tests to be disabled at runtime

jingham added a subscriber: jingham. jingham added a comment. As long as the only way you can specify the black-list is explicitly on the command line, I think this is fine. There should never be implicit searches for a backlist file. You must have to supply it each time you run the

[Lldb-commits] [lldb] r282212 - Add the ability to append breakpoints to the save file.

Author: jingham Date: Thu Sep 22 18:42:42 2016 New Revision: 282212 URL: http://llvm.org/viewvc/llvm-project?rev=282212=rev Log: Add the ability to append breakpoints to the save file. Modified: lldb/trunk/include/lldb/API/SBTarget.h lldb/trunk/include/lldb/Target/Target.h

[Lldb-commits] [lldb] r282207 - Add the ability to deserialize only breakpoints matching a given name.

Author: jingham Date: Thu Sep 22 17:20:28 2016 New Revision: 282207 URL: http://llvm.org/viewvc/llvm-project?rev=282207=rev Log: Add the ability to deserialize only breakpoints matching a given name. Also tests for this and the ThreadSpec serialization. Modified:

[Lldb-commits] [lldb] r282205 - Serilize the thread options within the breakpoint options.

Author: jingham Date: Thu Sep 22 17:00:59 2016 New Revision: 282205 URL: http://llvm.org/viewvc/llvm-project?rev=282205=rev Log: Serilize the thread options within the breakpoint options. Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

I imagine Greg also thought the llvm classes were just a wrapper around the system reg* functions. I wouldn't have had a problem with that, though it wouldn't have made any noticeable difference to lldb's performance. But I actually had to deal with a bug in the OS X copy of the regex engine

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

First off, I bet we could decide for giggles to make 5 or 6 random copies of strings before we pass them to regcomp in lldb and none of our users would notice the difference. It's just not something we do as a hot code path. So avoiding a copy or two is not worth even one new bug in regex

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

I was being facetious about the enhancements. I am more serious about bugs. I would really rather use a maintained rather than a "I got this source at some point and use it for some things, but don't rigorously test it" version of regcomp & friends. Can we hold off on that change till we

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

So does the build machinery use the one that is supported on that platform if it is available? They are going to get much wider testing, fixes and even "ENHANCE"ments... Jim > On Sep 21, 2016, at 6:07 PM, Zachary Turner wrote: > > Windows :) > > But that was before

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

It seems a little odd that llvm has its own forked copy of Henry Spencer's old regular expression engine? Are there platforms we care about that don't have a maintained version of exactly the same code? Jim > On Sep 21, 2016, at 5:42 PM, Zachary Turner wrote: > > I'll

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

> On Sep 21, 2016, at 5:25 PM, Greg Clayton via lldb-commits > wrote: > > Yep, and we can't have any regex objects in LLDB using those because they > will only work on Apple and we don't want code like: > > #if defined(__APPLE__) > RegularExpression e("\s+"); >

Re: [Lldb-commits] [lldb] r282090 - Fix failing regex tests.

IIRC you said the llvm one doesn't support extended regular expressions. If that's true, please don't do this till that is fixed. I think pretty much everybody who is using reg expressions expects to be able to use extended regular expressions. Jim > On Sep 21, 2016, at 4:58 PM, Zachary

[Lldb-commits] [lldb] r282103 - Probably should add the breakpoint names test directory as well...

Author: jingham Date: Wed Sep 21 14:21:38 2016 New Revision: 282103 URL: http://llvm.org/viewvc/llvm-project?rev=282103=rev Log: Probably should add the breakpoint names test directory as well... Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_names/

[Lldb-commits] [lldb] r282043 - Adds tests for breakpoint names, and a FindBreakpointsByName.

Author: jingham Date: Tue Sep 20 20:21:19 2016 New Revision: 282043 URL: http://llvm.org/viewvc/llvm-project?rev=282043=rev Log: Adds tests for breakpoint names, and a FindBreakpointsByName. Also if you set a breakpoint with an invalid name, we'll refuse to set the breakpoint rather than

<    3   4   5   6   7   8   9   10   11   12   >