Re: [PATCH rtems-docs v2 1/2] Added FAQ page

2021-04-03 Thread Chris Johns
f things to do. Chris > > On Sun, Apr 4, 2021 at 5:05 AM Chris Johns wrote: >> >> >> >> On 3/4/21 6:25 am, Gedare Bloom wrote: >>> On Fri, Apr 2, 2021 at 12:19 PM Ayushman Mishra >>> wrote: >>>> >>>> --- >>>

Re: [PATCH rtems-docs v2 1/2] Added FAQ page

2021-04-03 Thread Chris Johns
On 3/4/21 6:25 am, Gedare Bloom wrote: > On Fri, Apr 2, 2021 at 12:19 PM Ayushman Mishra > wrote: >> >> --- >> user/bld/index.rst | 2 + >> user/overview/index.rst | 2 + >> user/start/faq.rst | 295 +++ >>

Re: [PATCH 1/2] Added FAQ page

2021-04-03 Thread Chris Johns
On 3/4/21 6:29 am, Gedare Bloom wrote: > On Fri, Apr 2, 2021 at 12:55 PM Joel Sherrill wrote: >> On Fri, Apr 2, 2021 at 1:50 PM Ayushman Mishra >> wrote: >>> >>> Sir, It was given as an issue https://devel.rtems.org/ticket/3958 ( >>> Review wiki/TBR/Website/FAQ for correct links) for the faq

Re: [PATCH 1/2] Added FAQ page

2021-04-03 Thread Chris Johns
On 24/3/21 6:34 am, Gedare Bloom wrote: > Did you build the docs and verify they look good? > On Tue, Mar 23, 2021 at 12:44 PM Ayushman Mishra > wrote: >> +How are floating point numbers handled ? >> +- >> + >> +`Floating point support in RTEMS >>

Re: [PATCH rtems-docs v2 2/2] Corrected link

2021-04-03 Thread Chris Johns
On 3/4/21 5:19 am, Ayushman Mishra wrote: > --- > eng/stakeholders.rst | 4 +++- > user/bld/index.rst | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/eng/stakeholders.rst b/eng/stakeholders.rst > index 756c462..a4413cf 100644 > --- a/eng/stakeholders.rst > +++

Re: [lfs-support] LFS translation to Ancient Greek completed

2021-04-01 Thread Alex Johns
On 1/04/21 11:32 pm, Rob Hudson wrote: Tim Tassonis wrote: It took me a while, but I now finally completed my translation of the LFS book into Ancient Greek. It is based on LFS 10.0, and only the sysv version is done yet, Systemd is still pending due to ancient greek only having capital

Re: [libbsd] How to install machine header files?

2021-03-31 Thread Chris Johns
On 1/4/21 6:37 am, jan.som...@dlr.de wrote: > Hello, > > I stumbled upon some include path problems in libbsd while looking at Chris' > ptpd port and I am not sure what is the recommended way to solve it. > It starts with "freebsd/sys/sys/bus.h" including "machine/_bus.h". > Currently, this will

Re: [rtems5 PATCH 0/5] Backport zynq SPI drivers to rtems5

2021-03-31 Thread Chris Johns
Hi Jan, This looks good. Has this been tested on zync hardware? If no then some testing is needed and if yes then please push. Thanks Chris On 31/3/21 8:06 pm, Jan Sommer wrote: > This patchset backports: > - The cadence SPI driver (see: https://devel.rtems.org/ticket/4369) > - The xilinx axi

Re: [PATCH] rld-cc: Add -target to recognised cflags

2021-03-31 Thread Chris Johns
On 1/4/21 3:04 am, Gedare Bloom wrote: > On Wed, Mar 31, 2021 at 12:19 AM Hesham Almatary > wrote: >> >> Ping >> > Go ahead if you tested with gcc also. Fine with me. Chris ___ devel mailing list devel@rtems.org

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

2021-03-31 Thread Chris Johns
On 1/4/21 11:03 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 31, 2021 at 4:19 PM Chris Johns wrote: >> >> Do we need to support platform as well? I have lost track of which Python we >> need build doco. I suspect it is only 3. > > platform.dist is deprecated since

Re: [rtems-tools commit] rld-process: Add named tempfile constructor

2021-03-31 Thread Chris Johns
On 1/4/21 2:26 am, Alex White wrote: > On Tue, Mar 30, 2021 at 10:30 PM Chris Johns wrote: >> >> Hi, >> >> When I looked at this on vc@ I saw it is broken. I am sorry I did not pick >> this >> up in the review. >> >> On 31/3/21 5:20 am, Joel Sh

Re: [PATCH rtems-libbsd] libbsd.py: Build i2c shell command

2021-03-31 Thread Chris Johns
I am fine with this. I did not know it existed. On 27/3/21 7:40 am, Vijay Kumar Banerjee wrote: > --- > libbsd.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libbsd.py b/libbsd.py > index f7efda43..fe0566e7 100644 > --- a/libbsd.py > +++ b/libbsd.py > @@ -258,6 +258,7 @@ class

Re: [PATCH rtems-docs] common/latex.py: use distro module for python3.5 and up

2021-03-31 Thread Chris Johns
Do we need to support platform as well? I have lost track of which Python we need build doco. I suspect it is only 3. Chris On 24/3/21 7:05 am, Vijay Kumar Banerjee wrote: > --- > common/latex.py | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/common/latex.py

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

2021-03-30 Thread Chris Johns
On 31/3/21 3:29 pm, Vijay Kumar Banerjee wrote: > On Tue, Mar 30, 2021 at 10:24 PM Chris Johns wrote: >> >> OK for 5 the branch. >> > Thanks. will it be ok for master as well? I have created a cloned > ticket for master: #4367. Master is more complicated because

Re: [PATCH 2/2] rtl-allocator.c: Put dereferences after nullcheck

2021-03-30 Thread Chris Johns
+1 ... but it is blocked by the 1/2 patch until that is resolved or a v2 patch set is created. On 31/3/21 4:05 am, Gedare Bloom wrote: > ok > > On Tue, Mar 30, 2021 at 10:57 AM Ryan Long wrote: >> >> ping >> >> -Original Message- >> From: Ryan Long >> Sent: Monday, March 22, 2021

Re: [PATCH 1/2] rtl-obj.c: Added an early return if rtl lock fails

2021-03-30 Thread Chris Johns
On 31/3/21 4:08 am, Gedare Bloom wrote: > This looks ok. I'm wondering however if these rtems_rtl_lock () ever > should fail in practice, should it be an assert? Just wondering. Good question, I cannot remember. Maybe a better solution is to move to a statically allocated lock using the newer

Re: [PATCH RSB 5 v2] gdb-9-1: Add patch to fix linker error with gcc10

2021-03-30 Thread Chris Johns
OK for 5 the branch. It was a really great piece of work by everyone to sort this out. I have recently been hit by 4 separate cases of this change in gcc10 effecting code. Thanks Chris On 31/3/21 11:19 am, Vijay Kumar Banerjee wrote: > Close #4366 > --- > rtems/config/tools/rtems-gdb-9.1-1.cfg

Re: [rtems-tools commit] rld-process: Add named tempfile constructor

2021-03-30 Thread Chris Johns
Hi, When I looked at this on vc@ I saw it is broken. I am sorry I did not pick this up in the review. On 31/3/21 5:20 am, Joel Sherrill wrote: > Module:rtems-tools > Branch:master > Commit:420d7a13672991a1480d06ac02190f2976b9253b > Changeset: >

Re: [PATCH rtems-docs v2] User/BSPs/Beagle: Add JTAG debugger section

2021-03-30 Thread Chris Johns
And me. Thanks. Chris On 30/3/21 7:47 am, Gedare Bloom wrote: > looks fine to me > > On Mon, Mar 29, 2021 at 1:12 PM Christian Mauderer wrote: >> >> --- >> user/bsps/arm/beagle.rst | 67 ++-- >> 1 file changed, 65 insertions(+), 2 deletions(-) >> >> diff

Re: [PATCH rtems 01/18] Broke low-level parts of mv643xx_eth driver into separate files

2021-03-30 Thread Chris Johns
On 30/3/21 6:03 pm, Till Straumann wrote: > Hi Chris. > > On 3/30/21 4:16 AM, Chris Johns wrote: >> Hi, >> >> Thanks for bring this to our attention. >> >> I have pinged Till via github about the patches. >> >> There is no point adding these

Re: [PATCH rtems-libbsd 1/5] rtemsbsd: Add mv643xx nexus ethernet driver

2021-03-30 Thread Chris Johns
On 30/3/21 6:08 pm, Till Straumann wrote: > None of these additions to libbsd.py -- except for mv643xx_nexus.c > are in my patches. Note, however, that my pull-request is on top of > another branch (on request/suggestion by Heinz Junkes): 'RTEMS:5-freebsd-12'. Thanks, that is what I thought. I

Re: [PATCH rtems 03/18] verified that we can compile with MVETH_TESTING and MVETH_DEBUG

2021-03-30 Thread Chris Johns
On 30/3/21 5:58 pm, Till Straumann wrote: > This emailing of patches is too confusing and time-consuming for me. That is a shame, it is the process we have. > The tip of my branch which I submitted as a pull request > (c77e67ef3cbf71e27ac5daa6a4c4b5acb4f4ba0e) > does not #define MVETH_DEBUG.

Re: [PATCH rtems-libbsd 1/5] rtemsbsd: Add mv643xx nexus ethernet driver

2021-03-29 Thread Chris Johns
On 30/3/21 12:30 pm, Vijay Kumar Banerjee wrote: > From: till straumann > > Update #4345 > --- > libbsd.py| 19 + > rtemsbsd/include/bsp/nexus-devices.h | 7 +- > rtemsbsd/sys/dev/mve/mv643xx_nexus.c | 965 +++ > 3 files changed, 990

Re: [PATCH rtems 03/18] verified that we can compile with MVETH_TESTING and MVETH_DEBUG

2021-03-29 Thread Chris Johns
On 30/3/21 12:27 pm, Vijay Kumar Banerjee wrote: > From: till straumann > > Update #4344 > --- > bsps/powerpc/beatnik/net/if_mve/mv643xx_eth.c | 59 +++ > .../beatnik/net/if_mve/mv643xx_eth_bsdnet.c | 1 - > 2 files changed, 47 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH] covoar: Add option to create named objdumps

2021-03-29 Thread Chris Johns
On 30/3/21 9:10 am, Alex White wrote: > On Mon, Mar 29, 2021 at 4:39 PM Chris Johns wrote: >> >> On 30/3/21 7:56 am, Gedare Bloom wrote: >>> On Fri, Mar 12, 2021 at 10:07 AM Alex White wrote: >>>> >>>> This adds a new behavior to the -d option

Re: [PATCH] coverage/symbol-sets.ini : Add libtrace

2021-03-29 Thread Chris Johns
On 30/3/21 7:19 am, Alex White wrote: > On Sat, Mar 27, 2021 at 9:46 AM Gedare Bloom wrote: >> >> On Fri, Mar 12, 2021 at 10:17 AM Alex White wrote: >>> >>> --- >>>  tester/rtems/testing/coverage/symbol-sets.ini | 3 ++- >>>  1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git

Re: [PATCH] covoar: Add option to create named objdumps

2021-03-29 Thread Chris Johns
On 30/3/21 7:56 am, Gedare Bloom wrote: > On Fri, Mar 12, 2021 at 10:07 AM Alex White wrote: >> >> This adds a new behavior to the -d option which allows the creation of >> named objdump outputs in the /tmp directory. This allows the outputs to >> be reused on subsequent runs of covoar rather

Re: [Beagle BSP] How to run all tests on a Beaglebone Black in an automated way

2021-03-28 Thread Chris Johns
On 28/3/21 8:04 pm, Christian Mauderer wrote: > On 28/03/2021 03:16, Chris Johns wrote: >> On 28/3/21 6:16 am, Ahamed Husni wrote: >>> Hi, >>> >>> I ran the hello program on the BBB using a bootable SD card. The SD card >>> has two >>> pa

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

2021-03-27 Thread Chris Johns
On 22/3/21 7:45 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 19.03.21 um 02:11 schrieb Chris Johns: >> On 3/3/21 7:41 pm, Christian MAUDERER wrote: >>> Hello Chris, >>> >>> Am 03.03.21 um 02:17 schrieb Chris Johns: >>>> On 2/3/2

Re: [Beagle BSP] How to run all tests on a Beaglebone Black in an automated way

2021-03-27 Thread Chris Johns
On 28/3/21 6:16 am, Ahamed Husni wrote: > Hi, > > I ran the hello program on the BBB using a bootable SD card. The SD card has > two > partitions. > > 1. BOOT - primary, bootable, FAT32 > 2. ROOT - primary, ext4 > > The BOOT partition has the following files. > > 1. uEnv.txt > 2.

Re: psim failure - dl06

2021-03-27 Thread Chris Johns
On 28/3/21 7:21 am, Joel Sherrill wrote: > While the "multiple resource leaks" thread continues, I thought I would start > threads for other failures that are not resource leaks. dl06 fails as > follows.  There has been no work done on the RAP format and I currently do not have the time to look

Re: [PATCH v6 1/2] covoar: Fix NOP execution marking

2021-03-25 Thread Chris Johns
On 26/3/21 10:28 am, Alex White wrote: > On Thu, Mar 25, 2021 at 6:10 PM Chris Johns wrote: >> >> On 26/3/21 8:49 am, Alex White wrote: >>> Some NOP instructions were not being marked as executed because they >>> are located at the end of uncovered ranges. This ha

Re: [PATCH v6 1/2] covoar: Fix NOP execution marking

2021-03-25 Thread Chris Johns
On 26/3/21 8:49 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ > tester/covoar/CoverageMapBase.h | 4 ++ >

Re: Making Covoar More C++

2021-03-24 Thread Chris Johns
On 25/3/21 11:54 am, Joel Sherrill wrote: > > > On Wed, Mar 24, 2021, 7:28 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 25/3/21 6:54 am, Joel Sherrill wrote: > > > > > > On Wed, Mar 24, 2021 at 2:

Re: Making Covoar More C++

2021-03-24 Thread Chris Johns
On 25/3/21 6:54 am, Joel Sherrill wrote: > > > On Wed, Mar 24, 2021 at 2:42 PM Gedare Bloom > wrote: > > On Wed, Mar 24, 2021 at 1:35 PM Joel Sherrill > wrote: > > > > Hi > > > > There has been a lot of talk about

Re: [PATCH v2] bsps/sparc: Remove INI files using SIS in GBD

2021-03-23 Thread Chris Johns
On 24/3/21 6:46 am, Gedare Bloom wrote: > On Tue, Mar 23, 2021 at 1:45 PM Ryan Long wrote: >> >> Removed the INI files that use the "target sim" option >> since the SIS sparc simulator in GBD is no longer used > GDB > >> with RTEMS. A newer version of SIS is built seperately. > while you're at

Re: rtems-test not running tests for leon3

2021-03-23 Thread Chris Johns
On 24/3/21 1:18 am, Richi Dubey wrote: > Afaik minimum tests are supposed to fail. This is something I am not sure about. It is minimal by definition and as a result does not print anything so it is impossible to determine if the test runs of fails. As an example to show how small RTEMS can be it

Re: [PATCH rtems-docs v2] networking: Rename to legacy networking

2021-03-23 Thread Chris Johns
On 24/3/21 7:08 am, Vijay Kumar Banerjee wrote: > Hi, > > Thanks for the review. > > On Tue, Mar 23, 2021 at 12:56 PM Joel Sherrill wrote: >> >> I'm OK with this. >> >> Does this move the manual to near the bottom of the manual list? >> > No, it doesn't. The order is set by the order in this

Re: Installing rtems on 32 bit windows host machine

2021-03-22 Thread Chris Johns
gw-w64-i686-toolchain, after > exporting > the proper path of the compiler I ran the  > gcc -dumpmachine command, it returned i686-w64-mingw32 yet the > sb-check of rsb wants a i686-w32-mingw32-gcc compiler. > > > Chris

Re: [PATCH rtems-docs v3 1/6] prefixes: Update installation prefix

2021-03-22 Thread Chris Johns
On 23/3/21 4:41 am, Gedare Bloom wrote:> I wonder what is your opinion, should we bump these tutorials with > every version? And, is the find/replace of the commands the best way > to do this? > > I feel like this topic comes up now and again. Maintaining these > examples is a little fragile. It

Re: [PATCH v3 1/3] rtems-debugger: Fixed 32bit pointers

2021-03-22 Thread Chris Johns
On 23/3/21 4:58 am, Joel Sherrill wrote: > On Mon, Mar 22, 2021 at 12:54 PM Joel Sherrill > wrote: > > I posted to the gdb mailing list and this is the response: > > "If the inferior is using 64-bit addresses, then the remote protocol will > also use 64-bit

Re: [PATCH v3 1/3] rtems-debugger: Fixed 32bit pointers

2021-03-21 Thread Chris Johns
On 21/3/21 2:26 am, Joel Sherrill wrote: > > > On Sat, Mar 20, 2021, 1:21 AM Gedare Bloom > wrote: > > Hi Stephen, Joel: > > On Fri, Mar 19, 2021 at 9:35 AM Stephen Clark > wrote: > > > > Using 32bit types like

Re: [PATCH] rtems-fdt/rtems-fdt.c: Fix bug in loop termination

2021-03-21 Thread Chris Johns
On 21/3/21 10:43 pm, Christian Mauderer wrote: > I pushed the patch on master and 5. Thank you Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd 1/2] racoon/session: Honor file descriptor maximum

2021-03-18 Thread Chris Johns
On 3/3/21 7:41 pm, Christian MAUDERER wrote: > Hello Chris, > > Am 03.03.21 um 02:17 schrieb Chris Johns: >> On 2/3/21 7:26 pm, Christian MAUDERER wrote: >>> Hello Chris, >>> >>> Am 02.03.21 um 01:03 schrieb Chris Johns: >>>> On 1/3/2

Re: [PATCH 3/3] bsps/aarch64: changed comments and test statuses

2021-03-18 Thread Chris Johns
On 19/3/21 7:27 am, Ryan Long wrote: > Expanded upon the commments that were present previously. > Added more tests that may finish as 'indeterminate'. > --- > spec/build/bsps/aarch64/a53/tsta53.yml| 39 > +++ > spec/build/bsps/aarch64/xilinx-zynqmp/tstqemu.yml |

Re: [PATCH v2] pwdgrp.c: removed assert causing runtime issues

2021-03-18 Thread Chris Johns
On 19/3/21 6:19 am, Joel Sherrill wrote: > On Thu, Mar 18, 2021 at 2:14 PM Gedare Bloom > wrote: > On Thu, Mar 18, 2021 at 11:40 AM Ryan Long > wrote: > > > > Changed the _Assert_unused_variable_equals macro to just a (void)

Re: [PATCH v2 1/3] rtems-debugger: Fixed 32bit pointers

2021-03-18 Thread Chris Johns
On 19/3/21 4:49 am, Joel Sherrill wrote: > On Thu, Mar 18, 2021 at 12:33 PM Stephen Clark > wrote: > > Using 32bit types like uint32_t for pointers creates issues on 64 bit > architectures like AArch64. Replaced occurrences of these with uintptr_t, >

Re: [PATCH 1/4] eng: Update EARS syntax

2021-03-18 Thread Chris Johns
On 18/3/21 4:50 pm, Sebastian Huber wrote: > On 18/03/2021 01:43, Chris Johns wrote: > >> On 18/3/21 4:34 am, Sebastian Huber wrote: >>> The document used the EARS syntax from 2009 which slightly changed in >>> 2016, see "Listens Learned (8 Lessons Learned App

PTP on RTEMS

2021-03-17 Thread Chris Johns
Hello, I have created a tarball of my PTP efforts so far: https://ftp.rtems.org/pub/rtems/people/chrisj/ptp/ It is a collection of sources I have as a WIP that you link into an application. This is a development technique I use to avoid building multiple libraries. The package contains: -

Re: [PATCH 1/4] eng: Update EARS syntax

2021-03-17 Thread Chris Johns
On 18/3/21 4:34 am, Sebastian Huber wrote: > The document used the EARS syntax from 2009 which slightly changed in > 2016, see "Listens Learned (8 Lessons Learned Applying EARS)". The > optional pre-conditions moved to the state-driven pattern. This refined > syntax fits better to the action

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

2021-03-16 Thread Chris Johns
On 17/3/21 9:56 am, Joel Sherrill wrote: > On Tue, Mar 16, 2021, 4:47 PM Alex White > wrote: > > > Do any non-compiler-generated symbols include "."? > > Yes, according to the output of nm: > > $ i386-rtems6-nm

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

2021-03-16 Thread Chris Johns
On 17/3/21 8:16 am, Alex White wrote: > Assuming I'm sending a v4 of this patch out, should I add the explanation of > the compiler-generated suffixes to the commit message or perhaps as a comment > in the code? Yes if you think it helps. In the end what you are doing makes the tool work and

Re: [PATCH 2/5] rtems-fdt.c: Fix Resource leak (CID #1437645)

2021-03-16 Thread Chris Johns
On 17/3/21 2:14 am, Gedare Bloom wrote: > On Tue, Mar 16, 2021 at 1:15 AM Niteesh G. S. wrote: >> On Tue, 16 Mar 2021, 1:37 am Gedare Bloom, wrote: >>> >>> This one looks ok to me, Niteesh? >> >> +1 >> >> The below question is not related to this patch. >> >> Out of interest, I started going

Re: [PATCH v3] covoar: Handle periods in symbols from objdump

2021-03-16 Thread Chris Johns
On 17/3/21 2:05 am, Alex White wrote: > I’m not sure if I have seen an example of method split into more than one > piece. > It has been a while since I made this fix. > > A specific test executable that shows the suffixes is > testsuites/libtests/block08.exe, but most (if not all) of them

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

2021-03-15 Thread Chris Johns
On 16/3/21 11:49 am, Joel Sherrill wrote: > On Mon, Mar 15, 2021, 6:10 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 15/3/21 2:21 pm, Joel Sherrill wrote: > > On Sun, Mar 14, 2021, 9:27 PM Chris Johns <mailto:chr...@rtems.org> > >

Re: [PATCH] covoar: Handle periods in symbols from objdump

2021-03-15 Thread Chris Johns
On 16/3/21 8:26 am, Alex White wrote: > The exceptions are being used as legitimate error cases. The "what" messages > that I use here are not helpful. I think that's why it looks like they're > being used as labels. Understood and thanks. > As part of a revision of my "covoar: Fix NOP

Re: [PATCH v2] covoar: Handle periods in symbols from objdump

2021-03-15 Thread Chris Johns
On 16/3/21 9:04 am, Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > This looks to be related to compiler optimizations. Such symbols were > being treated as unique. For our purposes,

Re: [PATCH v2 0/4] coverage/reports: Improve coverage reports

2021-03-15 Thread Chris Johns
OK. Nice change and thank you. Chris On 16/3/21 9:09 am, Alex White wrote: > v2: > - Replace tab expansion function in ReportsBase with std::string version > > This patch set includes a few improvements to the coverage reports. > > Alex White (4): > covoar/reports: Add new statistics to

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

2021-03-15 Thread Chris Johns
On 16/3/21 10:00 am, Joel Sherrill wrote: On Mon, Mar 15, 2021 at 5:58 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 16/3/21 9:11 am, Gedare Bloom wrote: > > On Mon, Mar 15, 2021 at 3:34 PM Alex White <mailto:alex.wh...@oarcorp.com> > >

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

2021-03-15 Thread Chris Johns
On 16/3/21 10:07 am, Joel Sherrill wrote: > On Mon, Mar 15, 2021 at 6:01 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 16/3/21 6:55 am, Joel Sherrill wrote: > > > > > > On Mon, Mar 15, 2021 at 2:46 PM Gedare Bloom <mailto:g

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

2021-03-15 Thread Chris Johns
On 15/3/21 2:21 pm, Joel Sherrill wrote: > On Sun, Mar 14, 2021, 9:27 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > On 13/3/21 2:18 am, Ryan Long wrote: > > CID 1439298: Resource leak in rtems_fdisk_initialize(). > > > > Closes #4299 >

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

2021-03-15 Thread Chris Johns
On 16/3/21 6:55 am, Joel Sherrill wrote: > > > On Mon, Mar 15, 2021 at 2:46 PM Gedare Bloom <mailto:ged...@rtems.org>> wrote: > > On Sun, Mar 14, 2021 at 8:27 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 13/3/21

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

2021-03-15 Thread Chris Johns
On 16/3/21 9:11 am, Gedare Bloom wrote: > On Mon, Mar 15, 2021 at 3:34 PM Alex White > wrote: > > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any > issues. I think I

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

2021-03-15 Thread Chris Johns
On 16/3/21 8:34 am, Alex White wrote: > I honestly can't remember why I changed 1024 to 20,000. > > I've looked back at that code and changed it back to 1024 without any issues. > I think I might have missed that this is all happening in a loop, and at one > point during a (long) debugging

Re: [PATCH 1/5] hexdump-parse.c: Fix Resource leak (CID #26032)

2021-03-14 Thread Chris Johns
On 13/3/21 2:18 am, Ryan Long wrote: > CID 26032: Resource leak in rtems_shell_hexdump_rewrite(). > > Closes #4296 > --- > cpukit/libmisc/shell/hexdump-parse.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cpukit/libmisc/shell/hexdump-parse.c >

Re: [PATCH] covoar: Handle periods in symbols from objdump

2021-03-14 Thread Chris Johns
On 13/3/21 3:37 am, Alex White wrote: > Occasionally the compiler will generate symbols that look similar to > symbols defined in RTEMS code except that they contain some suffix. > This looks to be related to compiler optimizations. Such symbols were > being treated as unique. For our purposes,

Re: [PATCH v3 1/2] covoar: Fix NOP execution marking

2021-03-14 Thread Chris Johns
This v3 set is blocked by the v2 questions I have raised. Chris On 13/3/21 2:48 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ >

Re: [PATCH 5/5] rtl-shell.c: Resource leak (CID #1444140)

2021-03-14 Thread Chris Johns
On 13/3/21 2:18 am, Ryan Long wrote: > CID 1444140: Resource leak in rtems_rtl_shell_object(). > > Closes #4300 > --- > cpukit/libdl/rtl-shell.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/cpukit/libdl/rtl-shell.c b/cpukit/libdl/rtl-shell.c > index 9f8a136..bcecdd4 100644 > ---

Re: [PATCH 4/5] flashdisk.c: Fix Resource leak (CID #1439298)

2021-03-14 Thread Chris Johns
On 13/3/21 2:18 am, Ryan Long wrote: > CID 1439298: Resource leak in rtems_fdisk_initialize(). > > Closes #4299 > --- > cpukit/libblock/src/flashdisk.c | 42 > ++--- > 1 file changed, 31 insertions(+), 11 deletions(-) > > diff --git

Re: [PATCH v2] shell.c: Fix Dereference after null check (CID #26083)

2021-03-14 Thread Chris Johns
Sorry, this patch is blocked by the v1 thread. Chris On 12/3/21 9:17 am, Ryan Long wrote: > CID 26083: Dereference after null check in rtems_shell_login(). > > Closes #4327 > --- > cpukit/libmisc/shell/shell.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

2021-03-14 Thread Chris Johns
On 12/3/21 5:30 am, Alex White wrote: > There was a potential that the branch info loop never terminated. > This has been fixed by adding a more reliable termination condition > and logging an error if it cannot find the branch target. > --- > tester/covoar/CoverageReaderQEMU.cc | 11 +--

Re: [PATCH 1/2] covoar: Fix NOP execution marking

2021-03-14 Thread Chris Johns
On 12/3/21 3:18 am, Gedare Bloom wrote: > On Thu, Mar 11, 2021 at 9:01 AM Alex White wrote: >> >> Hi Chris, >> >> Good catch. That looks to be left over from some debugging I was doing. >> > I caught what you did there. Ha, ha, ha, I hope you don't take > exception to my pun. I tried to restrain

Re: [PATCH v2 1/2] covoar: Fix NOP execution marking

2021-03-14 Thread Chris Johns
On 12/3/21 3:14 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ > tester/covoar/CoverageMapBase.h | 4 ++ >

Re: [PATCH] shell.c: Dereference after null check (CID #26083)

2021-03-14 Thread Chris Johns
On 12/3/21 2:56 am, Ryan Long wrote: > After talking with Joel, we determined that 'out' shouldn’t be NULL by the > time it gets to rtems_shell_login(). Did you examine telnet use cases, nested shell calls (eg nesting joel scripts), telnet and joel scripts, and then the various options that can

Re: [PATCH] covoar: Fix DWARF reading

2021-03-14 Thread Chris Johns
On 14/3/21 8:43 am, Joel Sherrill wrote: > On Fri, Mar 12, 2021 at 5:47 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > These are design question and not review issues > > On 12/3/21 5:33 am, Alex White wrote: > > +  // Create data based on

Re: [PATCH] covoar: Fix DWARF reading

2021-03-12 Thread Chris Johns
These are design question and not review issues On 12/3/21 5:33 am, Alex White wrote: > + // Create data based on target. > + TargetInfo = Target::TargetFactory( buildTarget ); Any pointers in this object given there is a copy operator at work here? > + // Create the set of desired

Re: [PATCH] sb/config.py: Fix operator reconstruction

2021-03-11 Thread Chris Johns
On 12/3/21 3:55 am, Vijay Kumar Banerjee wrote: > Hi, > > Pushed the patches to upstream and 5. Thank you! > Thank you for the testing and Ricardo thank you for the fix. Excellent work. Chris ___ devel mailing list devel@rtems.org

Re: Offline download of sources fails

2021-03-10 Thread Chris Johns
On 11/3/21 4:37 pm, Ida Delphine wrote: > When I run it again with "--trace" I still get the same output. Nothing extra. > Don't know if I am missing something... It could by my instructions. I would need to check but I am not able to at the moment. If you are using git and are up to date on

Re: RSB build breaks

2021-03-10 Thread Chris Johns
On 11/3/21 4:38 pm, Vijay Kumar Banerjee wrote: > Hello, > > After fixing the logical error in the parser, it exposed another issue that's > causing RSB to break. Strange that it was hidden for so long. > > I have filed a ticket with details: http://deveone linel.rtems.org/ticket/4335 >

Re: Offline download of sources fails

2021-03-10 Thread Chris Johns
On 11/3/21 4:17 pm, Ida Delphine wrote: > My development host is Ubuntu 20.04 not Windows. Oh I do apologise, for some reason I thought your host was Windows. > Also I'm a bit confused on how > to run it with --trace to find the log file. Can you please help me with some > context? Add the

Re: Offline download of sources fails

2021-03-10 Thread Chris Johns
On 11/3/21 3:34 pm, Ida Delphine wrote: > Hello again, > > So I started over and downloaded all the required packages for my host (Ubuntu > 20.04) and still have offline download issues... > Please take a look at the error message: > > RTEMS Source Builder - Set Builder, 6 (fe2d13b6daf3) >

Re: [PATCH 1/2] covoar: Fix NOP execution marking

2021-03-10 Thread Chris Johns
On 11/3/21 10:33 am, Alex White wrote: > Some NOP instructions were not being marked as executed because they > are located at the end of uncovered ranges. This has been fixed. > --- > tester/covoar/CoverageMapBase.cc | 10 +++ > tester/covoar/CoverageMapBase.h | 4 ++ >

Re: Offline download of sources fails

2021-03-10 Thread Chris Johns
On 11/3/21 8:23 am, Michael Davidsaver wrote: > On 3/10/21 10:55 AM, Chris Johns wrote: >> ... >> Also have a look at the command sb-get-sources. It will fetch the source and >> patches for all hosts and architectures. > > Neat. I've been wishing for something like

Re: Offline download of sources fails

2021-03-10 Thread Chris Johns
On 10/3/21 11:57 pm, Joel Sherrill wrote: > On Wed, Mar 10, 2021, 6:42 AM Ida Delphine > wrote: > > Hello, > On trying to download my sources using this command stated in the > documentation: > > ../source-builder/sb-set-builder --source-only-download

Re: [PATCH 0/3] Fix Missing break in switch Coverity issues

2021-03-10 Thread Chris Johns
On 9/3/21 5:28 pm, Gedare Bloom wrote: > On Mon, Mar 8, 2021 at 11:04 PM Sebastian Huber > wrote: >> >> On 09/03/2021 06:47, Gedare Bloom wrote: >> >> I would just use a comment which is understood by GCC, clang, and >> Coverity. What does Linux use? >> > That's fine, if there

Re: Standalone repository for libnetworking stack

2021-03-10 Thread Chris Johns
On 11/3/21 5:14 am, Joel Sherrill wrote: > > > On Wed, Mar 10, 2021 at 11:48 AM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 11/3/21 1:11 am, Joel Sherrill wrote: > > On Tue, Mar 9, 2021 at 11:00 PM Vijay Kumar Banerjee <mai

Re: Qemu on Zynq Hanging

2021-03-10 Thread Chris Johns
On 11/3/21 5:17 am, Joel Sherrill wrote: > On Wed, Mar 10, 2021 at 11:42 AM Chris Johns <mailto:chr...@rtems.org>> wrote: > > On 11/3/21 1:22 am, Joel Sherrill wrote: > > I see qemu hanging for days testing zynq. This is on the Xeon Centos > compu

Re: [PATCH RSB] sb/config.py: Fix relational operator

2021-03-10 Thread Chris Johns
On 11/3/21 5:32 am, Vijay Kumar Banerjee wrote: > On Wed, Mar 10, 2021 at 10:53 AM Chris Johns wrote: >> >> Nice find and thanks. OK to push. >> > Pushed to master. > >> I think this should also be applied to the 5 branch. >> > Do I need to make any

Re: Flashdisk driver based on spidev

2021-03-10 Thread Chris Johns
On 11/3/21 12:59 am, jan.som...@dlr.de wrote: > Hello, > > We will probably at some point need support for Micron-based NOR-flash > devices to store data which are connected via SPI. > I found the flashdisk API in RTEMS and was wondering if I understand > everything correctly. > My idea would

Re: RSB build issue with rtems-libbsd

2021-03-10 Thread Chris Johns
On 9/3/21 3:53 pm, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 7:57 PM Chris Johns wrote: >> >> On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: >>> On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: >>>> On Mon, Mar 8, 2021, 4:02 PM Chris Johns

Re: [PATCH RSB v2] Add recipe for building rtems-net-legacy

2021-03-10 Thread Chris Johns
Thanks, this looks good and is OK to push. Chris On 10/3/21 5:33 am, Vijay Kumar Banerjee wrote: > --- > rtems/config/6/rtems-net-legacy.bset | 4 + > rtems/config/tools/rtems-net-legacy-6.cfg | 12 +++ > .../config/tools/rtems-net-legacy-common.cfg | 78 +++ > 3

Re: [PATCH, RSB] sparc, leon: GCC-7.5 patch needed for LEON3FT TN0018 errata

2021-03-10 Thread Chris Johns
On 10/3/21 2:15 am, Sebastian Huber wrote: > On 09/03/2021 15:19, Daniel Hellstrom wrote: > >> Set the __FIX_LEON3FT_TN0018 define for the affected LEON3FT multilibs: >>   * UT699 >>   * UT700 >>   * GR712RC >> >> Update #4322. > This change is fine. Same, OK. Chris

Re: [PATCH v5 0/3] Add cadence-SPI driver

2021-03-10 Thread Chris Johns
OK to push from me. On 9/3/21 10:22 pm, Jan Sommer wrote: > v5: > - Add some documentation > - Thanks for testing by Rick van der Wal > - Fix bug in CS logic > - Work-around too slow RXNEMPTY flag for some bus frequencies > - Created issue in trac: https://devel.rtems.org/ticket/4320 > >

Re: [PATCH RSB] sb/config.py: Fix relational operator

2021-03-10 Thread Chris Johns
Nice find and thanks. OK to push. I think this should also be applied to the 5 branch. Chris On 10/3/21 5:32 am, Vijay Kumar Banerjee wrote: > Close #4319 > --- > source-builder/sb/config.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/source-builder/sb/config.py

Re: [PATCH 0/3] tester: Fix RLD classes for covoar

2021-03-10 Thread Chris Johns
On 10/3/21 7:47 am, Alexander White wrote: > I can confirm that they do compile on Windows. Thanks. As stated OK to push :) Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: Standalone repository for libnetworking stack

2021-03-10 Thread Chris Johns
On 11/3/21 1:11 am, Joel Sherrill wrote: > On Tue, Mar 9, 2021 at 11:00 PM Vijay Kumar Banerjee <mailto:vi...@rtems.org>> wrote: > > On Tue, Mar 9, 2021 at 9:56 PM Chris Johns <mailto:chr...@rtems.org>> wrote: > > > > On 10/3/21 3:51 p

Re: Qemu on Zynq Hanging

2021-03-10 Thread Chris Johns
On 11/3/21 1:22 am, Joel Sherrill wrote: > I see qemu hanging for days testing zynq. This is on the Xeon Centos computer > I > use for batch and automated testing. > > This is ps but top shows six qemu processes having around 2231:52 in CPU time > used and using 100% CPU. Luckily this machine

Re: Standalone repository for libnetworking stack

2021-03-09 Thread Chris Johns
On 10/3/21 3:51 pm, Gedare Bloom wrote: > On Tue, Mar 9, 2021 at 6:58 PM Joel Sherrill wrote: >> On Tue, Mar 9, 2021, 3:28 PM Vijay Kumar Banerjee wrote: >>> On Fri, Mar 5, 2021 at 10:03 AM Vijay Kumar Banerjee >>> wrote: >>> In this proposed set of patches, I have removed telnetd from RTEMS

Re: [PATCH RSB] Add recipe for building rtems-net-legacy

2021-03-08 Thread Chris Johns
On 9/3/21 2:03 pm, Vijay Kumar Banerjee wrote: > Hi Chris, > > Thanks for reviewing. > > On Mon, Mar 8, 2021 at 7:54 PM Chris Johns wrote: >> >> Hi Vijay, >> >> Thank you for sorting this out. >> >> On 9/3/21 1:31 pm, Vijay Kumar Ba

Re: RSB build issue with rtems-libbsd

2021-03-08 Thread Chris Johns
On 9/3/21 1:44 pm, Vijay Kumar Banerjee wrote: > On Mon, Mar 8, 2021 at 3:14 PM Joel Sherrill wrote: >> On Mon, Mar 8, 2021, 4:02 PM Chris Johns wrote: >>> >>> On 6/3/21 2:24 pm, Vijay Kumar Banerjee wrote: >>>> Hello, >>>> >>>> I'

<    14   15   16   17   18   19   20   21   22   23   >