Re: [RFC 1/1] SWDEV476969 - dm: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-10-28 Thread Leo Li
On 2024-10-25 22:01, Melissa Wen wrote: On 25/10/2024 16:37, Zaeem Mohamed wrote: [why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. Hi Zaeem, Thanks for working on this fix. [how] Bounds check on plane_count when requiring overlay curs

Re: [RFC 1/1] SWDEV476969 - dm: Fail dm_atomic_check if cursor overlay is required at MAX_SURFACES

2024-10-28 Thread Leo Li
On 2024-10-25 22:01, Melissa Wen wrote: On 25/10/2024 16:37, Zaeem Mohamed wrote: [why] Prevent index-out-of-bounds due to requiring cursor overlay when plane_count is MAX_SURFACES. Hi Zaeem, Thanks for working on this fix. [how] Bounds check on plane_count when requiring overlay curs

Re: [PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail

2024-10-23 Thread Leo Li
On 2024-10-23 09:53, Melissa Wen wrote: There are two events to trace the beginning and the end of amdgpu_dm_atomic_commit_tail, but only the one ate the beginning was placed. Place amdgpu_dm_atomic_commit_tail_finish tracepoint at the end than. Signed-off-by: Melissa Wen Reviewed-by: Leo

Re: [PATCH] drm/amd/display: add missing tracepoint event in DM atomic_commit_tail

2024-10-23 Thread Leo Li
On 2024-10-23 09:53, Melissa Wen wrote: There are two events to trace the beginning and the end of amdgpu_dm_atomic_commit_tail, but only the one ate the beginning was placed. Place amdgpu_dm_atomic_commit_tail_finish tracepoint at the end than. Signed-off-by: Melissa Wen Reviewed-by: Leo

Re: [PATCH] drm/amd/display: Disable PSR-SU on Parade 08-01 TCON too

2024-10-21 Thread Leo Li
/dmesg.log [1] Link: https://gitlab.freedesktop.org/drm/amd/uploads/8f13ff3b00963c833e23e68aa8116959/output.log [2] Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2645 Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Thanks --- --- drivers/gpu/drm/amd/display/modules/power

Re: [REGRESSION][BISECTED] 58a261bfc967: choppy GPU performance

2024-10-01 Thread Leo Li
On 2024-10-01 15:10, Mario Limonciello wrote: On 10/1/2024 14:09, John Rowley wrote: I was using power-profiles-daemon version 0.23 in balanced mode. I also tested TLP, and vanilla kernel without any power daemons running. Without any daemons I use the following: energy_performance_

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-10 Thread Leo Li
Hi Mikhail, Can you give this patch a try to see if it helps? https://gist.github.com/leeonadoh/3271e90ec95d768424c572c970ada743 Thanks, Leo On 2024-09-10 11:47, Leo Li wrote: On 2024-09-08 19:30, Mikhail Gavrilov wrote: I have done additional tests: 1. The computer does not hang with

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-10 Thread Leo Li
Hi Mikhail, Can you give this patch a try to see if it helps? https://gist.github.com/leeonadoh/3271e90ec95d768424c572c970ada743 Thanks, Leo On 2024-09-10 11:47, Leo Li wrote: On 2024-09-08 19:30, Mikhail Gavrilov wrote: I have done additional tests: 1. The computer does not hang with

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-10 Thread Leo Li
On 2024-09-08 19:30, Mikhail Gavrilov wrote: I have done additional tests: 1. The computer does not hang with 6900XT instead the screen flickers when moving the cursor. 2. The computer does not hang with 7900XTX if I turn off VRR. But the screen flickers when moving the cursor, as on 6900XT. T

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-10 Thread Leo Li
On 2024-09-08 19:30, Mikhail Gavrilov wrote: I have done additional tests: 1. The computer does not hang with 6900XT instead the screen flickers when moving the cursor. 2. The computer does not hang with 7900XTX if I turn off VRR. But the screen flickers when moving the cursor, as on 6900XT. T

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-06 Thread Leo Li
anes being used on my setup. Third, in case these two issues are related, can you give the attached patch on this issue thread a try as well? https://gitlab.freedesktop.org/drm/amd/-/issues/3569#note_2558359 Thanks, Leo On 2024-09-05 02:06, Mikhail Gavrilov wrote: On Thu, Sep 5, 2024 at 4:06

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-06 Thread Leo Li
anes being used on my setup. Third, in case these two issues are related, can you give the attached patch on this issue thread a try as well? https://gitlab.freedesktop.org/drm/amd/-/issues/3569#note_2558359 Thanks, Leo On 2024-09-05 02:06, Mikhail Gavrilov wrote: On Thu, Sep 5, 2024 at 4:06

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-04 Thread Leo Li
On 2024-09-04 18:21, Mikhail Gavrilov wrote: On Wed, Sep 4, 2024 at 4:15 AM Leo Li wrote: Hi Mike, Super sorry for the ridiculous wait. Your first two emails slipped by my inbox, which is really silly, given I'm first in the to field... Thanks for bisecting and finding a free ga

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-04 Thread Leo Li
On 2024-09-04 18:21, Mikhail Gavrilov wrote: On Wed, Sep 4, 2024 at 4:15 AM Leo Li wrote: Hi Mike, Super sorry for the ridiculous wait. Your first two emails slipped by my inbox, which is really silly, given I'm first in the to field... Thanks for bisecting and finding a free ga

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-03 Thread Leo Li
On 2024-09-03 02:35, Mikhail Gavrilov wrote: On Sun, Aug 25, 2024 at 2:12 AM Mikhail Gavrilov wrote: Hi, Is anyone trying to look into it? I continue to reproduce this issue on fresh kernel builds 6.11-rc4+. In addition to the RenPy engine, the problem also reproduces on games from Ubisoft

Re: 6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-09-03 Thread Leo Li
On 2024-09-03 02:35, Mikhail Gavrilov wrote: On Sun, Aug 25, 2024 at 2:12 AM Mikhail Gavrilov wrote: Hi, Is anyone trying to look into it? I continue to reproduce this issue on fresh kernel builds 6.11-rc4+. In addition to the RenPy engine, the problem also reproduces on games from Ubisoft

Re: [PATCH] drm/amd/display: Determine IPS mode by ASIC and PMFW versions

2024-08-28 Thread Leo Li
On 2024-08-27 16:38, Harry Wentland wrote: On 2024-08-27 15:53, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN IPS interoperates with other system idle power features, such as Zstates. On DCN35, there is a known issue where system Z8 + DCN IPS2 causes a hard hang. We observe this on

Re: [PATCH 15/16] drm/amd/display: 3.2.298

2024-08-26 Thread Leo Li
improvements for text display and HDR DWM and MPO - Fix Synaptics Cascaded Panamera DSC Determination - Allocate DCN35 clock table transfer buffers in GART - Add Replay Low Refresh Rate parameters in dc type Signed-off-by: Aric Cyr Signed-off-by: Zaeem Mohamed Acked-by: Leo Li --- drivers

Re: [PATCH 1/5] drm/amd: Introduce additional IPS debug flags

2024-08-19 Thread Leo Li
On 2024-08-19 10:41, Harry Wentland wrote: On 2024-08-16 18:57, sunpeng...@amd.com wrote: From: Leo Li [Why] Idle power states (IPS) describe levels of power-gating within DCN. DM and DC is responsible for ensuring that we are out of IPS before any DCN programming happens. Any DCN

Re: [PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-07 Thread Leo Li
On 2024-08-07 01:13, Mario Limonciello wrote: On 8/6/24 13:42, Sebastian Wick wrote: From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. Th

Re: [PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-07 Thread Leo Li
On 2024-08-07 01:13, Mario Limonciello wrote: On 8/6/24 13:42, Sebastian Wick wrote: From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. Th

Re: [PATCH v4 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-10 Thread Leo Li
o bit mask "Require low latency" PSR should be disabled. When the property is restored to an empty bit mask ABM and PSR can be enabled again. Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Thanks! --- v3->v4: * Fix enabling again after disable (Xaver) --- dri

Re: [PATCH v4 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-10 Thread Leo Li
o bit mask "Require low latency" PSR should be disabled. When the property is restored to an empty bit mask ABM and PSR can be enabled again. Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Thanks! --- v3->v4: * Fix enabling again after disable (Xaver) --- dri

Re: [PATCH 29/50] drm/amd/display: Re-enable panel replay feature

2024-07-10 Thread Leo Li
On 2024-07-10 15:36, Fangzhi Zuo wrote: From: Tom Chung [Why & How] Fixed the replay issues and now re-enable the panel replay feature. Reported-by: Arthur Borsboom Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344 Reviewed-by: Mario Limonciello Reviewed-by: Rodrigo Siqueira

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
o bit mask "Require low latency" PSR should be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Thanks! --- v2->v3: * Use `disallow_edp_enter_psr` i

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
o bit mask "Require low latency" PSR should be disabled. When the property is restored to an empty bit mask the previous value of ABM and pSR will be restored. Signed-off-by: Mario Limonciello Reviewed-by: Leo Li Thanks! --- v2->v3: * Use `disallow_edp_enter_psr` i

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Leo Li
On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 10064

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Leo Li
On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 10064

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Leo Li
Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to h

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Leo Li
Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to h

Re: [PATCH] drm/amd/display: Guard ACPI calls with CONFIG_ACPI

2024-06-10 Thread Leo Li
On 2024-06-10 11:32, Mario Limonciello wrote: On 6/10/2024 09:55, sunpeng...@amd.com wrote: From: Leo Li To fix CONFIG_ACPI disabled build error. Fixes: ec6f30c776ad ("drm/amd/display: Set default brightness according to ACPI") Signed-off-by: Leo Li ---   drivers/gpu/drm/a

Re: [PATCH] drm/amd/display: Set default brightness according to ACPI

2024-06-07 Thread Leo Li
lo Acked-by: Alex Deucher Reviewed-by: Leo Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +++- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 8 3 files changed, 23 insertions(+),

Re: [PATCH v2 1/2] drm: Introduce 'power saving policy' drm property

2024-06-04 Thread Leo Li
experience intended by the compositor. Signed-off-by: Mario Limonciello Acked-by: Leo Li Thanks! --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h

Re: [PATCH v2 1/2] drm: Introduce 'power saving policy' drm property

2024-06-04 Thread Leo Li
experience intended by the compositor. Signed-off-by: Mario Limonciello Acked-by: Leo Li Thanks! --- drivers/gpu/drm/drm_connector.c | 46 + include/drm/drm_connector.h | 2 ++ include/drm/drm_mode_config.h | 5 include/uapi/drm/drm_mode.h

Re: [PATCH v2 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-04 Thread Leo Li
On 2024-05-22 18:05, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Requ

Re: [PATCH v2 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-04 Thread Leo Li
On 2024-05-22 18:05, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Requ

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Leo Li
On 2024-05-21 13:32, Mario Limonciello wrote: On 5/21/2024 12:27, Leo Li wrote: On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Leo Li
On 2024-05-21 13:32, Mario Limonciello wrote: On 5/21/2024 12:27, Leo Li wrote: On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Leo Li
On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hard

Re: [PATCH 0/2] Add support for Panel Power Savings property

2024-05-21 Thread Leo Li
On 2024-05-21 12:21, Mario Limonciello wrote: On 5/21/2024 11:14, Xaver Hugl wrote: Am Di., 21. Mai 2024 um 16:00 Uhr schrieb Mario Limonciello : On 5/21/2024 08:43, Simon Ser wrote: This makes sense to me in general. I like the fact that it's simple and vendor-neutral. Do we want to hard

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-17 Thread Leo Li
On 2024-04-16 10:10, Harry Wentland wrote: On 2024-04-16 04:01, Pekka Paalanen wrote: On Mon, 15 Apr 2024 18:33:39 -0400 Leo Li wrote: On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-17 Thread Leo Li
On 2024-04-16 10:10, Harry Wentland wrote: On 2024-04-16 04:01, Pekka Paalanen wrote: On Mon, 15 Apr 2024 18:33:39 -0400 Leo Li wrote: On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-15 Thread Leo Li
On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-15 Thread Leo Li
On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Leo Li
On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: ... That begs the question of what can be

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Leo Li
On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: ... That begs the question of what can be

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Leo Li
On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-12 Thread Leo Li
On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-11 Thread Leo Li
On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400 Leo Li wrote: On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-11 Thread Leo Li
On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400 Leo Li wrote: On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-03 Thread Leo Li
On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400 wrote: From: Leo Li These patches aim to make the amdgpgu KMS driver play nicer with compositors when building multi-plane scanout configurations. They do so by: 1. Making cursor behavior more sensible. 2

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-03 Thread Leo Li
On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400 wrote: From: Leo Li These patches aim to make the amdgpgu KMS driver play nicer with compositors when building multi-plane scanout configurations. They do so by: 1. Making cursor behavior more sensible. 2

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-04-01 Thread Leo Li
On 2024-03-28 11:52, Harry Wentland wrote: On 2024-03-28 11:48, Robert Mader wrote: Hi, On 15.03.24 18:09, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-04-01 Thread Leo Li
On 2024-03-28 11:52, Harry Wentland wrote: On 2024-03-28 11:48, Robert Mader wrote: Hi, On 15.03.24 18:09, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to

Re: We are glad to announce the release of Apache SeaTunnel 2.3.4

2024-03-06 Thread Leo Li
Hello, Do we have a release plan for seantunnel-web project ?  It looks like  there is  no any updates since last release. Bases on my own use experience,  there are a lot of remaining issues(bugs) to be fixed,  it's not a difficult thing to fix so many issues in a short term. But, web

About Kakfa Connector's enhancement(Key/value's Deserialization)

2024-01-18 Thread Leo Li
Hi, ALL     I'm trying and evaluating SeaTunnel's functionality,  When testing  data sync from Kafka to any sink database(e.g. Mysql, PG, clickhouse,,.etc, I find an "issue" and it may need to be enhanced.     The issue is that:  the default key And/Or value's deserializer when cosuming Kafka

Re: [PATCH v2] Revert "drm/amd/display: Enable Replay for static screen use cases"

2023-10-03 Thread Leo Li
s being enabled? It causes a regression in amd_psr. Unless there's a quick fix, we should revert for now. It sounds like this can break existing support for PSR/PSR SU. Acked-by: Leo Li - Leo Bhawan *From:* LIPSKI,

Re: [PATCH v2] Revert "drm/amd/display: Enable Replay for static screen use cases"

2023-10-03 Thread Leo Li
there's a quick fix, we should revert for now. It sounds like this can break existing support for PSR/PSR SU. Acked-by: Leo Li - Leo Bhawan *From:* LIPSKI, IVAN *Sent:* October 2, 2023 1:47 PM *To:* amd-gfx@l

Re: [PATCH 6/7] Revert "drm/amd/display: Implement zpos property"

2023-08-18 Thread Leo Li
On 2023-08-18 04:25, Melissa Wen wrote: On 07/26, Aurabindo Pillai wrote: This reverts commit 6c8ff1683d30024c8cff137d30b740a405cc084e. This patch causes IGT test case 'kms_atomic@plane-immutable-zpos' to fail on AMDGPU hardware. Cc: Joshua Ashton Signed-off-by: Nicholas Choi --- driver

RE: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-10 Thread Leo Li
> -Original Message- > From: Azeem Shaikh > Sent: Sunday, July 9, 2023 9:36 PM > To: Kees Cook > Cc: Qiang Zhao ; linux-harden...@vger.kernel.org; > linuxppc-dev@lists.ozlabs.org; linux-ker...@vger.kernel.org; Leo Li > ; linux-arm-ker...@lists.infradead.org >

RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

2023-06-29 Thread Leo Li
> -Original Message- > From: gre...@linuxfoundation.org > Sent: Thursday, June 29, 2023 3:41 AM > To: Christophe Leroy > Cc: Leo Li ; Ma Ke ; linux- > u...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH]

RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

2023-06-28 Thread Leo Li
> -Original Message- > From: Christophe Leroy > Sent: Wednesday, June 28, 2023 2:40 PM > To: Leo Li ; Ma Ke > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] us

RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

2023-06-28 Thread Leo Li
> -Original Message- > From: Ma Ke > Sent: Wednesday, June 28, 2023 3:15 AM > To: Leo Li > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; Ma Ke > > Subject: [PATCH] usb: gadget: fsl_q

Re: [PATCH v2 3/4] drm/amd/display: Set minimum requirement for using PSR-SU on Phoenix

2023-06-26 Thread Leo Li
z Cc: Tsung-hua (Ryan) Lin Signed-off-by: Mario Limonciello Reviewed-by: Leo Li --- v1->v2: * Fix a s/dcn31/dcn314/ mixup --- drivers/gpu/drm/amd/display/dmub/src/dmub_dcn314.c | 5 + drivers/gpu/drm/amd/display/dmub/src/dmub_dcn314.h | 2 ++ drivers/gpu/drm/amd/display/

Re: [PATCH v2 2/4] drm/amd/display: Set minimum requirement for using PSR-SU on Rembrandt

2023-06-26 Thread Leo Li
newer firmware. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza Mahfooz Cc: Tsung-hua (Ryan) Lin Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2443 Signed-off-by: Mario Limonciello Reviewed-by: Leo Li --- v1->v2: * Fix a s/dcn314/dcn31/ mixup --- drivers/gpu/drm/amd/display/a

Re: [PATCH 4/4] Revert "drm/amd: Disable PSR-SU on Parade 0803 TCON"

2023-06-23 Thread Leo Li
On 6/22/23 14:25, Mario Limonciello wrote: This reverts commit 33eec907ce0eb50a56dca621aa7310f7fa904b93. This is no longer necessary when using newer DMUB F/W. Cc: Sean Wang Cc: Marc Rossi Cc: Hamza Mahfooz Cc: Tsung-hua (Ryan) Lin Signed-off-by: Mario Limonciello Reviewed-by: Leo Li

Re: [PATCH 1/4] drm/amd/display: Correct `DMUB_FW_VERSION` macro

2023-06-23 Thread Leo Li
: Mario Limonciello Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h b/drivers/gpu/drm/amd/display/dmub/dmub_srv.h index 7c9a2b34bd05..2a66a305679a 100644

Re: [PATCH 2/4] drm/amd/display: Set minimum requirement for using PSR-SU on Rembrandt

2023-06-23 Thread Leo Li
On 6/22/23 14:25, Mario Limonciello wrote: A number of parade TCONs are causing system hangs when utilized with older DMUB firmware and PSR-SU. Some changes have been introduced into DMUB firmware to add resilience against these failures. Don't allow running PSR-SU unless on the newer firmwa

Re: [PATCH] drm/amd/display: perform a bounds check before filling dirty rectangles

2023-06-21 Thread Leo Li
ed in fill_dc_dirty_rect(). Cc: sta...@vger.kernel.org # 6.1+ Fixes: 30ebe41582d1 ("drm/amd/display: add FB_DAMAGE_CLIPS support") Signed-off-by: Hamza Mahfooz Reviewed-by: Leo Li Thanks! --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 - 1 file changed, 4 i

RE: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors

2023-05-31 Thread Leo Li
> -Original Message- > From: Randy Dunlap > Sent: Sunday, May 21, 2023 5:52 PM > To: linux-ker...@vger.kernel.org > Cc: Randy Dunlap ; kernel test robot > ; Michael Ellerman ; Christophe > Leroy ; Leo Li ; > Masahiro Yamada ; Nicolas Schier > ; Qiang Zhao ;

RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void

2023-05-30 Thread Leo Li
> -Original Message- > From: Uwe Kleine-König > Sent: Tuesday, May 30, 2023 8:51 AM > To: Leo Li > Cc: Stuart Yoder ; Gaurav Jain > ; Roy Pledge ; Diana > Madalina Craciun (OSS) ; Eric Dumazet > ; Ioana Ciornei ; > k...@vger.kernel.org; Horia Geanta ; Jak

RE: [RFC PATCH 0/4] Remove some e500/MPC85xx evaluation platforms

2023-04-14 Thread Leo Li
> -Original Message- > From: Michael Ellerman > Sent: Thursday, April 13, 2023 9:14 PM > To: Leo Li ; Paul Gortmaker > > Cc: Scott Wood ; Paul Mackerras ; > Claudiu Manoil ; linuxppc-dev@lists.ozlabs.org; > Pali Rohár > Subject: Re: [RFC PATCH 0/4] Remove s

RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void

2023-04-12 Thread Leo Li
> -Original Message- > From: Uwe Kleine-König > Sent: Wednesday, April 12, 2023 12:11 PM > To: Stuart Yoder ; Laurentiu Tudor > ; Roy Pledge ; Leo Li > ; Horia Geanta ; Pankaj > Gupta ; Gaurav Jain ; > Herbert Xu ; David S. Miller > ; Vinod Koul ; Ioana Ciorn

RE: [PATCH] README.mpc85xx-sd-spi-boot: Suggest the NXP boot format github repo

2023-03-08 Thread Leo Li
> -Original Message- > From: Pali Rohár > Sent: Wednesday, March 8, 2023 2:54 PM > To: Leo Li > Cc: Fabio Estevam ; Priyanka Jain > ; Fabio Estevam ; > ka...@kernel.org; u-boot@lists.denx.de > Subject: Re: [PATCH] README.mpc85xx-sd-spi-boot: Suggest the NXP b

RE: [PATCH] README.mpc85xx-sd-spi-boot: Suggest the NXP boot format github repo

2023-02-28 Thread Leo Li
> -Original Message- > From: Pali Rohár > Sent: Tuesday, February 28, 2023 9:32 AM > To: Leo Li > Cc: Fabio Estevam ; Priyanka Jain > ; Fabio Estevam ; > ka...@kernel.org; u-boot@lists.denx.de > Subject: Re: [PATCH] README.mpc85xx-sd-spi-boot: Suggest the NXP b

RE: [RFC PATCH 0/4] Remove some e300/MPC83xx evaluation platforms

2023-02-24 Thread Leo Li
> -Original Message- > From: Paul Gortmaker > Sent: Monday, February 20, 2023 5:59 AM > To: linuxppc-dev@lists.ozlabs.org > Cc: Leo Li ; Claudiu Manoil ; > Paul Gortmaker ; Scott Wood > ; Michael Ellerman ; Benjamin > Herrenschmidt ; Paul Mackerras > > S

RE: [RFC PATCH 0/4] Remove some e300/MPC83xx evaluation platforms

2023-02-20 Thread Leo Li
> -Original Message- > From: Paul Gortmaker > Sent: Monday, February 20, 2023 5:59 AM > To: linuxppc-dev@lists.ozlabs.org > Cc: Leo Li ; Claudiu Manoil ; > Paul Gortmaker ; Scott Wood > ; Michael Ellerman ; Benjamin > Herrenschmidt ; Paul Mackerras > > S

RE: [PATCH v5 02/10] soc: fsl: cpm1: Add support for TSA

2023-02-16 Thread Leo Li
> -Original Message- > From: Herve Codina > Sent: Thursday, February 16, 2023 7:42 AM > To: Herve Codina ; Leo Li > ; Rob Herring ; Krzysztof > Kozlowski ; Liam Girdwood > ; Mark Brown ; Christophe > Leroy ; Michael Ellerman > ; Nicholas Piggin ; Qia

RE: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

2023-02-15 Thread Leo Li
> -Original Message- > From: Herve Codina > Sent: Thursday, January 26, 2023 2:32 AM > To: Herve Codina ; Leo Li > ; Rob Herring ; Krzysztof > Kozlowski ; Liam Girdwood > ; Mark Brown ; Christophe > Leroy ; Michael Ellerman > ; Nicholas Piggin ; Qiang Zhao &g

RE: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

2023-02-15 Thread Leo Li
> -Original Message- > From: Christophe Leroy > Sent: Wednesday, February 15, 2023 10:08 AM > To: Leo Li ; Qiang Zhao > Cc: linuxppc-dev@lists.ozlabs.org; Krzysztof Kozlowski > ; Rob Herring ; > Herve Codina ; linux-arm- > ker...@lists.infradead.org; devicet..

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Leo Li
points to this commit: b261509952bc19d1012cf732f853659be6ebc61e. b261509952bc19d1012cf732f853659be6ebc61e is the first bad commit commit b261509952bc19d1012cf732f853659be6ebc61e Author: Leo Li Date: Tue Aug 30 16:38:16 2022 -0400 drm/amd/display: Fix double cursor on non-video RGB MPO

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Leo Li
points to this commit: b261509952bc19d1012cf732f853659be6ebc61e. b261509952bc19d1012cf732f853659be6ebc61e is the first bad commit commit b261509952bc19d1012cf732f853659be6ebc61e Author: Leo Li Date: Tue Aug 30 16:38:16 2022 -0400 drm/amd/display: Fix double cursor on non-video RGB MPO

Re: [PATCH v2 10/21] drm/amd/display: Signal mode_changed if colorspace changed

2023-01-24 Thread Leo Li
: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 10/21] drm/amd/display: Signal mode_changed if colorspace changed

2023-01-24 Thread Leo Li
: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: dri-de...@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 17/21] drm/amd/display: Format input and output CSC matrix

2023-01-24 Thread Leo Li
...@amd.com Cc: Joshua Ashton Cc: dri-de...@lists.freedesktop.org Cc: amd-gfx@lists.freedesktop.org Reviewed-by: Leo Li --- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 38 - drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 54 +++ 2 files changed, 56 insertions

Re: [PATCH v2 17/21] drm/amd/display: Format input and output CSC matrix

2023-01-24 Thread Leo Li
...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-by: Leo Li --- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 38 - drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 54 +++ 2 files changed, 56 insertions

RE: usb.c:undefined reference to `qe_immr'

2023-01-11 Thread Leo Li
> -Original Message- > From: Christophe Leroy > Sent: Wednesday, January 11, 2023 1:43 PM > To: Randy Dunlap ; Michael Ellerman > ; kernel test robot ; Masahiro > Yamada > Cc: Nicolas Schier ; linux-ker...@vger.kernel.org; Leo Li > ; oe-kbuild-...@lists

Re: [PATCH v2] drm/amd/display: fix PSR-SU/DSC interoperability support

2023-01-05 Thread Leo Li
On 1/5/23 15:07, Hamza Mahfooz wrote: On 1/5/23 13:29, Harry Wentland wrote: On 1/5/23 12:38, Hamza Mahfooz wrote: Currently, there are issues with enabling PSR-SU + DSC. This stems from the fact that DSC imposes a slice height on transmitted video data and we are not conforming to that s

Re: [PATCH v2] drm/amd/display: fix PSR-SU/DSC interoperability support

2023-01-05 Thread Leo Li
On 1/5/23 15:07, Hamza Mahfooz wrote: On 1/5/23 13:29, Harry Wentland wrote: On 1/5/23 12:38, Hamza Mahfooz wrote: Currently, there are issues with enabling PSR-SU + DSC. This stems from the fact that DSC imposes a slice height on transmitted video data and we are not conforming to that s

Re: [PATCH v2] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-12-01 Thread Leo Li
ts in fill_dc_dirty_rects(). Signed-off-by: Hamza Mahfooz Thanks for the patch, it LGTM. Reviewed-by: Leo Li It would be good to add an IGT case to cover combinations of MPO & damage clip commits. Perhaps something that covers the usecase of moving a MPO video, while desktop UI updates. We'd

Re: [PATCH v2] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-12-01 Thread Leo Li
ts in fill_dc_dirty_rects(). Signed-off-by: Hamza Mahfooz Thanks for the patch, it LGTM. Reviewed-by: Leo Li It would be good to add an IGT case to cover combinations of MPO & damage clip commits. Perhaps something that covers the usecase of moving a MPO video, while desktop UI updates. We'd

Re: [PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-11-17 Thread Leo Li
On 11/15/22 15:24, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and fill them into dirty_rects in fill_dc_dirty_

Re: [PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-11-17 Thread Leo Li
On 11/15/22 15:24, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and fill them into dirty_rects in fill_dc_dirty_

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Leo Li
t are only useful for debugging PSR (and confusing otherwise). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz Reviewed-by: Leo Li Thanks --- v2: give a more concrete reason. --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Leo Li
t are only useful for debugging PSR (and confusing otherwise). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz Reviewed-by: Leo Li Thanks --- v2: give a more concrete reason. --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.

Re: [PATCH] drm/amd/display: explicitly disable psr_feature_enable appropriately

2022-10-07 Thread Leo Li
On 2022-10-07 00:28, Shirish S wrote: [Why] If psr_feature_enable is set to true by default, it continues to be enabled for non capable links. [How] explicitly disable the feature on links that are not capable of the same. Signed-off-by: Shirish S Reviewed-by: Leo Li Thanks

Re: [PATCH] drm/amd/display: disable psr whenever applicable

2022-10-06 Thread Leo Li
On 2022-10-06 03:46, S, Shirish wrote: On 10/6/2022 4:33 AM, Leo Li wrote: On 2022-10-03 11:26, S, Shirish wrote: Ping! Regards, Shirish S On 9/30/2022 7:17 PM, S, Shirish wrote: On 9/30/2022 6:59 PM, Harry Wentland wrote: +Leo On 9/30/22 06:27, Shirish S wrote: [Why] psr

Re: [PATCH] drm/amd/display: disable psr whenever applicable

2022-10-05 Thread Leo Li
On 2022-10-03 11:26, S, Shirish wrote: Ping! Regards, Shirish S On 9/30/2022 7:17 PM, S, Shirish wrote: On 9/30/2022 6:59 PM, Harry Wentland wrote: +Leo On 9/30/22 06:27, Shirish S wrote: [Why] psr feature continues to be enabled for non capable links. Do you have more info on what

Re: [PATCH] drm/amdgpu: Fix mc_umc_status used uninitialized warning

2022-09-28 Thread Leo Li
On 2022-09-28 10:53, Hamza Mahfooz wrote: On 2022-09-28 10:49, sunpeng...@amd.com wrote: From: Leo Li On ChromeOS clang build, the following warning is seen: /mnt/host/source/src/third_party/kernel/v5.15/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c:463:6: error: variable 'mc_umc_status

Re: [PATCH] drm/amd/display: Prevent OTG shutdown during PSR SU

2022-09-28 Thread Leo Li
On 2022-09-28 09:52, Harry Wentland wrote: On 2022-09-27 19:13, sunpeng...@amd.com wrote: From: Leo Li [Why] Enabling Z10 optimizations allows DMUB to disable the OTG during PSR link-off. This theoretically saves power by putting more of the display hardware to sleep. However, we

  1   2   3   4   5   6   7   8   9   >