Re: [Nouveau] RFC: gallium/nv50: get rid of the screen_init stateobj

2010-03-14 Thread Maarten Maathuis
BEGIN_RING also does autobind, the rest seems ok. Maarten. On Sun, Mar 14, 2010 at 2:53 PM, Christoph Bumiller e0425...@student.tuwien.ac.at wrote: On 14.03.2010 13:03, Maarten Maathuis wrote: On Sun, Mar 14, 2010 at 11:32 AM, Christoph Bumiller e0425...@student.tuwien.ac.at wrote: Hi

Re: [PATCH 1/2] drm/ttm: remove some bo-mutex remains

2010-03-12 Thread Maarten Maathuis
Ping? On Mon, Mar 1, 2010 at 9:55 PM, Jerome Glisse gli...@freedesktop.org wrote: On Mon, Mar 01, 2010 at 07:34:39PM +0100, Maarten Maathuis wrote: - A few comments existed here and there that referred to a bo-mutex. Signed-off-by: Maarten Maathuis madman2...@gmail.com Reviewed-by: Jerome

Re: [Nouveau] Nouveau [vanilla 2.6.33] + GeForce FX 5200 = blank screen

2010-03-08 Thread Maarten Maathuis
On Mon, Mar 8, 2010 at 10:06 PM, Lev A. Melnikovsky melnikov...@mail.ru wrote: ...please, could someone investigate this? I'd be glad to provide more info or test patches or whatever...  On Sun, 28 Feb 2010 at 6:50pm, Lev A. Melnikovsky wrote: LAM Hi there, LAM LAM I have just decided to

Re: [Nouveau] making 0.0.16 into 1.0.0

2010-03-05 Thread Maarten Maathuis
On Fri, Mar 5, 2010 at 2:23 AM, Dave Airlie airl...@gmail.com wrote: So with all this ongoing Linus crap I'm going to be brave and ask for reasons why 0.0.16 kernel API can't become 1.0.0. Pros: All old userspace compatibility is gone. No more UMS cruft to support. Something can be shipped

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
people that get to keep the pieces. Sincerely, Maarten Maathuis. -- Download Intel#174; Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
On Thu, Mar 4, 2010 at 10:21 PM, Maarten Maathuis madman2...@gmail.com wrote: On Thu, Mar 4, 2010 at 7:18 PM, Linus Torvalds torva...@linux-foundation.org wrote: Hmm. What the hell am I supposed to do about        (II) NOUVEAU(0): [drm] nouveau interface version: 0.0.16        (EE) NOUVEAU

Re: [git pull] drm request 3

2010-03-04 Thread Maarten Maathuis
On Thu, Mar 4, 2010 at 7:18 PM, Linus Torvalds torva...@linux-foundation.org wrote: Hmm. What the hell am I supposed to do about        (II) NOUVEAU(0): [drm] nouveau interface version: 0.0.16        (EE) NOUVEAU(0): [drm] wrong version, expecting 0.0.15        (EE) NOUVEAU(0): 879: now?

Re: [Nouveau] [PATCH] nouveau: make sure initial kalloc for user bo ends up in the right place

2010-03-02 Thread Maarten Maathuis
pushed. On Mon, Mar 1, 2010 at 10:26 PM, Francisco Jerez curroje...@riseup.net wrote: Acked-by: Francisco Jerez curroje...@riseup.net ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau

[PATCH 1/2] drm/ttm: remove some bo-mutex remains

2010-03-01 Thread Maarten Maathuis
- A few comments existed here and there that referred to a bo-mutex. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_bo.c|6 +- drivers/gpu/drm/ttm/ttm_bo_vm.c |2 +- include/drm/ttm/ttm_bo_api.h|3 +-- include/drm/ttm/ttm_bo_driver.h

[PATCH 2/2] drm/ttm: don't write to bo-reserved without holding glob-lru_lock

2010-03-01 Thread Maarten Maathuis
- The headerfile says you can't write to it without holding the lock. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_bo.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c

[Nouveau] [PATCH 2/2] drm/nv50: add a memory barrier to pushbuf submission

2010-03-01 Thread Maarten Maathuis
- pre-nv50 has one too (in WRITE_PUT). Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_dma.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.c b/drivers/gpu/drm/nouveau/nouveau_dma.c index

[Nouveau] [PATCH] nouveau: make sure initial kalloc for user bo ends up in the right place

2010-03-01 Thread Maarten Maathuis
- Currently reloc'ing a user bo to gart will first cause an allocation in vram, which is then cpu written to, then the bo gets moved to gart. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- nouveau/nouveau_reloc.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff

Re: [PATCH] drm/ttm: handle OOM in ttm_tt_swapout

2010-02-23 Thread Maarten Maathuis
On Tue, Feb 23, 2010 at 6:59 AM, Dave Airlie airl...@gmail.com wrote: On Sat, Feb 20, 2010 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: - Without this change I get a general protection fault. - Also use PTR_ERR where applicable. I just want to make sure I understand, but really

[PATCH] drm/ttm: handle OOM in ttm_tt_swapout

2010-02-19 Thread Maarten Maathuis
- Without this change I get a general protection fault. - Also use PTR_ERR where applicable. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/ttm/ttm_tt.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm

Re: Board voting ends today, but...

2010-02-18 Thread Maarten Maathuis
I am not a member, which says something already. But in short everything surrounding the board has never tempted to sign up or vote. Apart from hosting a few servers i never knew what they were doing. This situation has somewhat improved but it's still vague. At the moment i still do not feel the

Re: [PATCH] exa/mixed: fix gnome-panel corruption

2010-02-17 Thread Maarten Maathuis
I don't mind, i just thought this was preferred. I did gave you the final sign-off, to indicate you were the final author. 2010/2/17 Michel Dänzer mic...@daenzer.net: On Tue, 2010-02-16 at 22:55 +0100, Maarten Maathuis wrote: - A mapped pixmap can't be used for acceleration, any decent memory

Re: [PATCH] exa/mixed: fix gnome-panel corruption

2010-02-17 Thread Maarten Maathuis
Both patches are functional on their own, Michel's patch just makes it prettier. 2010/2/17 Dave Airlie airl...@gmail.com: 2010/2/17 Michel Dänzer mic...@daenzer.net: On Tue, 2010-02-16 at 22:55 +0100, Maarten Maathuis wrote: - A mapped pixmap can't be used for acceleration, any decent memory

Re: [Mesa3d-dev] [Nouveau] Build failure in Mesa

2010-02-16 Thread Maarten Maathuis
On Tue, Feb 16, 2010 at 11:00 AM, Johannes Obermayr johannesoberm...@gmx.de wrote: Am Dienstag, 16. Februar 2010 09:53:58 schrieb Ben Skeggs: On Tue, 2010-02-16 at 09:25 +0100, Johannes Obermayr wrote: Hi, Ben Skeggs latest changes in Mesa cause a build failure (libdrm is latest git

Re: [Nouveau] Build failure in Mesa

2010-02-16 Thread Maarten Maathuis
On Tue, Feb 16, 2010 at 11:00 AM, Johannes Obermayr johannesoberm...@gmx.de wrote: Am Dienstag, 16. Februar 2010 09:53:58 schrieb Ben Skeggs: On Tue, 2010-02-16 at 09:25 +0100, Johannes Obermayr wrote: Hi, Ben Skeggs latest changes in Mesa cause a build failure (libdrm is latest git

[PATCH] exa/mixed: fix gnome-panel corruption

2010-02-16 Thread Maarten Maathuis
. Signed-off-by: Maarten Maathuis madman2...@gmail.com Signed-off-by: Michel Dänzer daen...@vmware.com --- exa/exa_migration_mixed.c | 48 1 files changed, 30 insertions(+), 18 deletions(-) diff --git a/exa/exa_migration_mixed.c b/exa

Re: [git pull] drm

2010-02-15 Thread Maarten Maathuis
The channel/context switch lock related patches (to the best of knowledge) haven't even gone outside the nouveau tree, so the initial damage isn't even there. At least not for the first path. As for the 2nd patch, that one was squished into the original patch for this pull iirc. Maarten. On Mon,

Re: [Nouveau] [git pull] drm

2010-02-15 Thread Maarten Maathuis
The channel/context switch lock related patches (to the best of knowledge) haven't even gone outside the nouveau tree, so the initial damage isn't even there. At least not for the first path. As for the 2nd patch, that one was squished into the original patch for this pull iirc. Maarten. On Mon,

Re: [PATCH] exa: fix gnome-panel corruption

2010-02-15 Thread Maarten Maathuis
2010/2/15 Michel Dänzer mic...@daenzer.net: On Thu, 2010-02-11 at 20:06 +0100, Maarten Maathuis wrote: 2010/2/11 Michel Dänzer mic...@daenzer.net: Thanks for tackling this, Maarten! On Thu, 2010-02-11 at 19:05 +0100, Maarten Maathuis wrote: - A mapped pixmap can't be used

[PATCH] exa/mixed: fix gnome-panel corruption

2010-02-15 Thread Maarten Maathuis
. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- exa/exa_migration_mixed.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/exa/exa_migration_mixed.c b/exa/exa_migration_mixed.c index 6816e6c..d200917 100644 --- a/exa/exa_migration_mixed.c +++ b

Re: [PATCH] exa: fix gnome-panel corruption

2010-02-12 Thread Maarten Maathuis
One possibility would be to put exaDoMigration with src with preg on the deferred pixmap list, i haven't tested this, but i could try this evening or tomorrow. Maarten. 2010/2/11 Maarten Maathuis madman2...@gmail.com: 2010/2/11 Michel Dänzer mic...@daenzer.net: Thanks for tackling

[PATCH] exa/mixed: fix gnome-panel corruption

2010-02-12 Thread Maarten Maathuis
- A mapped pixmap can't be used for acceleration, any decent memory manager will refuse this. - Source pixmaps with preg are incomplete (in the gpu pixmap), so also put them on the deferred pixmap list. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- exa/exa_migration_mixed.c | 31

Re: [PATCH] exa/mixed: fix gnome-panel corruption

2010-02-12 Thread Maarten Maathuis
This is the other way to do it. On Fri, Feb 12, 2010 at 7:02 PM, Maarten Maathuis madman2...@gmail.com wrote: - A mapped pixmap can't be used for acceleration, any decent memory manager will refuse this. - Source pixmaps with preg are incomplete (in the gpu pixmap), so also put them

[PATCH] exa: fix gnome-panel corruption

2010-02-11 Thread Maarten Maathuis
- A mapped pixmap can't be used for acceleration, any decent memory manager will refuse this. - Source pixmaps may need updating, so move in the pixmap unconditionally, it should be a no-op in most cases anyway. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- exa/exa_migration_mixed.c

Re: [PATCH] exa: fix gnome-panel corruption

2010-02-11 Thread Maarten Maathuis
This should be exa/mixed instead of exa. On Thu, Feb 11, 2010 at 7:05 PM, Maarten Maathuis madman2...@gmail.com wrote: - A mapped pixmap can't be used for acceleration, any decent memory manager will refuse this. - Source pixmaps may need updating, so move in the pixmap unconditionally

Re: [PATCH] exa: fix gnome-panel corruption

2010-02-11 Thread Maarten Maathuis
2010/2/11 Michel Dänzer mic...@daenzer.net: Thanks for tackling this, Maarten! On Thu, 2010-02-11 at 19:05 +0100, Maarten Maathuis wrote: - A mapped pixmap can't be used for acceleration, any decent memory manager will refuse this. - Source pixmaps may need updating, so move in the pixmap

Re: [PATCH 2/2] drm/radeon: Add asic hook for dma copy to r200 cards.

2010-02-10 Thread Maarten Maathuis
What happens if you have two cards, one RS200 and one RV280 (just an example). I think you shouldn't change values in a static struct. On Wed, Feb 10, 2010 at 11:10 PM, Pauli Nieminen suok...@gmail.com wrote: r200 cards have dma engine which can be used to tranfer data between vram and system

Re: [Nouveau] [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL

2010-02-09 Thread Maarten Maathuis
Pushed as announced. On Mon, Feb 8, 2010 at 6:39 PM, Maarten Maathuis madman2...@gmail.com wrote: Added the Tested-by, added Marcin's real name. And added a spin unlock in the nv50 fifo failure path. Will push in a day if there are no further comments. Maarten. On Mon, Feb 8, 2010 at 6:38

Re: [Nouveau] [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL

2010-02-08 Thread Maarten Maathuis
Thanks for pointing that out, is it preferred to use goto style failure or just stick the spin unlock everywhere where you return? Maarten. On Mon, Feb 8, 2010 at 11:30 AM, Pekka Paalanen p...@iki.fi wrote: On Sun,  7 Feb 2010 02:11:20 +0100 Maarten Maathuis madman2...@gmail.com wrote

Re: [Nouveau] [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL

2010-02-08 Thread Maarten Maathuis
Added the Tested-by, added Marcin's real name. And added a spin unlock in the nv50 fifo failure path. Will push in a day if there are no further comments. Maarten. On Mon, Feb 8, 2010 at 6:38 PM, Maarten Maathuis madman2...@gmail.com wrote: - Marcin Slusarz pointed out that this triggers

Re: [Nouveau] [PATCH] drm/nouveau: Add proper vgaarb support.

2010-02-08 Thread Maarten Maathuis
2010/2/8 Marcin Kościelnicki koria...@0x04.net: Signed-off-by: Marcin Kościelnicki koria...@0x04.net ---  drivers/gpu/drm/nouveau/nouveau_state.c |    7 +++  1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c

[Nouveau] [PATCH] drm/nouveau: don't hold spin lock while calling kzalloc with GFP_KERNEL

2010-02-06 Thread Maarten Maathuis
, it isn't activated at that stage. - Move and rename the lock after some discussion with 'joi', even better naming suggestions are appreciated. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_channel.c |9 ++--- drivers/gpu/drm/nouveau/nouveau_drv.h

Re: [Nouveau] nouveau interrupts firewire ISO streaming

2010-02-04 Thread Maarten Maathuis
On Thu, Feb 4, 2010 at 11:58 AM, Adrian Knoth a...@drcomp.erfurt.thur.de wrote: On Tue, Feb 02, 2010 at 02:35:04PM +0100, Maarten Maathuis wrote: Hi! When the X pointer changes from arrow to the vertical text selection bar, firewire streaming is interrupted. Same with scrolling in firefox

Re: [Nouveau] nouveau interrupts firewire ISO streaming

2010-02-04 Thread Maarten Maathuis
On Thu, Feb 4, 2010 at 1:38 PM, Adrian Knoth a...@drcomp.erfurt.thur.de wrote: On Thu, Feb 04, 2010 at 12:19:14PM +0100, Maarten Maathuis wrote: Hi! When the X pointer changes from arrow to the vertical text selection bar, firewire streaming is interrupted. Same with scrolling in firefox

Re: [Nouveau] [PATCH 6/6] drm/nouveau: give pgraph a chance to idle before spinlock

2010-02-04 Thread Maarten Maathuis
Pushed as announced, with a few minor style changes that checkpatch pointed out. On Wed, Feb 3, 2010 at 7:02 PM, Maarten Maathuis madman2...@gmail.com wrote: Patches 4-6 will be pushed tomorrow if there are no objections. Acks or comments appreciated as usual. Maarten. On Tue, Feb 2, 2010

Re: [Nouveau] [PATCH 3/6] drm/nv50: delete ramfc object after disabling fifo, not before

2010-02-03 Thread Maarten Maathuis
1-3 pushed as announced. On Tue, Feb 2, 2010 at 10:37 PM, Maarten Maathuis madman2...@gmail.com wrote: I intend to push patch 1-3 tomorrow if there are no objections. Acks are appreciated as usual. On Tue, Feb 2, 2010 at 10:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - ramfc

Re: [Nouveau] [PATCH 6/6] drm/nouveau: give pgraph a chance to idle before spinlock

2010-02-03 Thread Maarten Maathuis
Patches 4-6 will be pushed tomorrow if there are no objections. Acks or comments appreciated as usual. Maarten. On Tue, Feb 2, 2010 at 10:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - Under some rare conditions i've managed to get pgraph errors after the  channel is closed, which has

[Nouveau] [PATCH 1/6] drm/nv50: align size of buffer object to the right boundaries.

2010-02-02 Thread Maarten Maathuis
users or splitting vram into 2 zones. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index

[Nouveau] [PATCH 3/6] drm/nv50: delete ramfc object after disabling fifo, not before

2010-02-02 Thread Maarten Maathuis
- ramfc is zero'ed upon destruction, so it's safer to do things in the right order. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nv50_fifo.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_fifo.c b

[Nouveau] [PATCH 5/6] drm/nv50: make the pgraph irq handler loop like the pre-nv50 version

2010-02-02 Thread Maarten Maathuis
- Unset the bit that indicates that a ctxprog can continue at the end. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_irq.c | 139 ++--- 1 files changed, 75 insertions(+), 64 deletions(-) diff --git a/drivers/gpu/drm/nouveau

[Nouveau] [PATCH 4/6] drm/nouveau: protect channel create/destroy and irq handler with a spin lock

2010-02-02 Thread Maarten Maathuis
- The nv50 pgraph handler (for example) could reenable pgraph fifo access and that would be bad when pgraph context is being unloaded (we need the garuantee a ctxprog isn't running). Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_channel.c |9

[Nouveau] [PATCH 2/6] drm/nv50: avoid unloading pgraph context when ctxprog is running

2010-02-02 Thread Maarten Maathuis
is set as invalid. So remove them altogether. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_channel.c |7 +++ drivers/gpu/drm/nouveau/nv50_graph.c | 10 +++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu

Re: [Nouveau] [PATCH 3/6] drm/nv50: delete ramfc object after disabling fifo, not before

2010-02-02 Thread Maarten Maathuis
I intend to push patch 1-3 tomorrow if there are no objections. Acks are appreciated as usual. On Tue, Feb 2, 2010 at 10:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - ramfc is zero'ed upon destruction, so it's safer to do things in the right order. Signed-off-by: Maarten Maathuis

[Nouveau] [PATCH 1/4] drm/nv50: align size of buffer object to the right boundaries.

2010-02-01 Thread Maarten Maathuis
- Depth and stencil buffers are supposed to be large enough in general. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_bo.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers

[Nouveau] [PATCH 4/4] drm/nv50: delete ramfc object after disabling fifo, not before

2010-02-01 Thread Maarten Maathuis
- ramfc is zero'ed upon destruction, so it's safer to do things in the right order. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nv50_fifo.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_fifo.c b

Re: [Nouveau] [PATCH 3/4] drm/nv50: avoid unloading pgraph context when ctxprog is running

2010-02-01 Thread Maarten Maathuis
Someone should probably check this out on earlier cards as well. On Mon, Feb 1, 2010 at 7:34 PM, Maarten Maathuis madman2...@gmail.com wrote: - We need to disable pgraph fifo access before checking the current channel, otherwise we could still hit a running ctxprog. - The writes to 0x400500

[Nouveau] [PATCH 2/4] drm/nv50: make the pgraph irq handler loop like the pre-nv50 version

2010-02-01 Thread Maarten Maathuis
Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_irq.c | 140 ++--- 1 files changed, 76 insertions(+), 64 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_irq.c b/drivers/gpu/drm/nouveau/nouveau_irq.c index baa9b3e

[Nouveau] [PATCH 3/4] drm/nv50: avoid unloading pgraph context when ctxprog is running

2010-02-01 Thread Maarten Maathuis
is set as invalid. So remove them altogether. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_channel.c |7 +++ drivers/gpu/drm/nouveau/nv50_graph.c | 10 +++--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu

Re: [Nouveau] [PATCH 2/4] drm/nv50: make the pgraph irq handler loop like the pre-nv50 version

2010-02-01 Thread Maarten Maathuis
I'm wondering if the write to 0x400824 should be outside the loop, since it's a flag blocking a ctxprog from continuing. Anyone know why this one wasn't looping but the pre-nv50 one is? On Mon, Feb 1, 2010 at 7:34 PM, Maarten Maathuis madman2...@gmail.com wrote: Signed-off-by: Maarten Maathuis

Re: [Nouveau] [PATCH 3/4] drm/nv50: avoid unloading pgraph context when ctxprog is running

2010-02-01 Thread Maarten Maathuis
If there are no objections, please share them as soon as possible. On Mon, Feb 1, 2010 at 7:40 PM, Maarten Maathuis madman2...@gmail.com wrote: Someone should probably check this out on earlier cards as well. On Mon, Feb 1, 2010 at 7:34 PM, Maarten Maathuis madman2...@gmail.com wrote: - We

Re: [Nouveau] [PATCH] drm/nouveau: call ttm_bo_wait with the bo lock held to prevent hang

2010-01-30 Thread Maarten Maathuis
Acked-by: Maarten Maathuis madman2...@gmail.com On Thu, Jan 28, 2010 at 10:33 PM, Maarten Maathuis madman2...@gmail.com wrote: Looks sane to me, it would be nice if someone else also agreed, before committing. On Thu, Jan 28, 2010 at 5:28 PM, Luca Barbieri l...@luca-barbieri.com wrote

Re: [Nouveau] [PATCH] drm/nouveau: call ttm_bo_wait with the bo lock held to prevent hang

2010-01-28 Thread Maarten Maathuis
Looks sane to me, it would be nice if someone else also agreed, before committing. On Thu, Jan 28, 2010 at 5:28 PM, Luca Barbieri l...@luca-barbieri.com wrote: Please apply or state objections to this patch. Thanks. ___ Nouveau mailing list

Re: [PATCH] drm: Add a generic function to change connector type/id of connector dynamically

2010-01-27 Thread Maarten Maathuis
On Wed, Jan 27, 2010 at 8:16 AM, yakui.z...@intel.com wrote: From: Zhao Yakui yakui.z...@intel.com Sometimes one connector can support more than one connector type. And it will switch the connector type/id dynamically according to the external connected device. I very much doubt it's the

Re: [Nouveau] [PATCH] drm/ttm: Fix race condition in ttm_bo_delayed_delete

2010-01-21 Thread Maarten Maathuis
On Thu, Jan 21, 2010 at 3:44 PM, Francisco Jerez curroje...@riseup.net wrote: Luca Barbieri l...@luca-barbieri.com writes: Nvidia cards have a synchronization primitive that could be used to synchronize several FIFOs in hardware (AKA semaphores, see [1] for an example). Does this operate

Re: [Nouveau] [PATCH] drm/ttm: Fix race condition in ttm_bo_delayed_delete

2010-01-21 Thread Maarten Maathuis
On Thu, Jan 21, 2010 at 4:56 PM, Luca Barbieri l...@luca-barbieri.com wrote: Doing it without software methods means you need to have a semaphore that exists in the cpu domain and therefore cannot be used again until the cpu is sure it's done. So that will probably require a rotating queue of

Re: [Nouveau] [PATCH] drm/ttm: Fix race condition in ttm_bo_delayed_delete

2010-01-21 Thread Maarten Maathuis
On Thu, Jan 21, 2010 at 3:44 PM, Francisco Jerez curroje...@riseup.net wrote: Luca Barbieri l...@luca-barbieri.com writes: Nvidia cards have a synchronization primitive that could be used to synchronize several FIFOs in hardware (AKA semaphores, see [1] for an example). Does this operate

Re: [Nouveau] [libdrm PATCH] nouveau: fix memory leak in nouveau_channel_free

2010-01-14 Thread Maarten Maathuis
Could you resend these (not just this one) patches as proper git send-email patches, those have authorship too, so they can be used with git am. Maarten. On Tue, Jan 12, 2010 at 3:32 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: From: Marcin Slusarz marcin.slus...@gmail.com Subject:

Re: [Nouveau] [libdrm PATCH] nouveau: fix memory leak in nouveau_channel_free

2010-01-14 Thread Maarten Maathuis
Sorry, this was a brainfart. On Thu, Jan 14, 2010 at 11:30 PM, Maarten Maathuis madman2...@gmail.com wrote: Could you resend these (not just this one) patches as proper git send-email patches, those have authorship too, so they can be used with git am. Maarten. On Tue, Jan 12, 2010 at 3:32

Re: [Nouveau] [libdrm PATCH] nouveau: fix memory leak in nouveau_channel_free

2010-01-14 Thread Maarten Maathuis
I'll push this one tomorrow. On Thu, Jan 14, 2010 at 11:54 PM, Maarten Maathuis madman2...@gmail.com wrote: Sorry, this was a brainfart. On Thu, Jan 14, 2010 at 11:30 PM, Maarten Maathuis madman2...@gmail.com wrote: Could you resend these (not just this one) patches as proper git send

Re: [Nouveau] [libdrm PATCH] nouveau: disable flush_notify on channel_free

2010-01-14 Thread Maarten Maathuis
I'll push this one tomorrow if there are no complaints. On Tue, Jan 12, 2010 at 3:38 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: From: Marcin Slusarz marcin.slus...@gmail.com Subject: [libdrm PATCH] nouveau: disable flush_notify on channel_free We don't want do call flush_notify when

Re: [Nouveau] reserve_ram_pages_type failed

2010-01-12 Thread Maarten Maathuis
For completeness, track 8 means the pages are mapped write combined, and req 16 means they were going to be mapped uncached (this is for agp gart). This can be found in the x86 specific PAE code that is invoked upon ioremap. On Tue, Jan 12, 2010 at 1:10 AM, Xavier shinin...@gmail.com wrote: On

Re: [PATCH] drm/radeon/kms/rv100: reject modes 135 Mhz on DVI

2010-01-11 Thread Maarten Maathuis
On Mon, Jan 11, 2010 at 6:57 PM, Alex Deucher alexdeuc...@gmail.com wrote: From 6d980869ef031752dac505c1aacbbe221fb2c6e7 Mon Sep 17 00:00:00 2001 From: Alex Deucher alexdeuc...@gmail.com Date: Mon, 11 Jan 2010 12:39:35 -0500 Subject: [PATCH] drm/radeon/kms/rv100: reject modes 135 Mhz on DVI

[Nouveau] [PATCH 3/3] drm/nv50: wait for pgraph to idle before unloading the context

2010-01-11 Thread Maarten Maathuis
- This should fix the problem with gpu hangs people have had when closing channels. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- drivers/gpu/drm/nouveau/nv50_graph.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_graph.c b

Re: [Nouveau] [PATCH 3/3] drm/nv50: wait for pgraph to idle before unloading the context

2010-01-11 Thread Maarten Maathuis
This patch alone, so ignore the 3/3. I think this fixes the channel unload hang issues in a less obscure way. Feedback appreciated as usual. On Mon, Jan 11, 2010 at 9:18 PM, Maarten Maathuis madman2...@gmail.com wrote: - This should fix the problem with gpu hangs people have had when closing

Re: [Nouveau] [PATCH 3/3] drm/nv50: wait for pgraph to idle before unloading the context

2010-01-11 Thread Maarten Maathuis
This patch *is* alone, sorry for the typo. On Mon, Jan 11, 2010 at 9:20 PM, Maarten Maathuis madman2...@gmail.com wrote: This patch alone, so ignore the 3/3. I think this fixes the channel unload hang issues in a less obscure way. Feedback appreciated as usual. On Mon, Jan 11, 2010 at 9:18

Re: [Nouveau] [PATCH 3/3] drm/nv50: wait for pgraph to idle before unloading the context

2010-01-11 Thread Maarten Maathuis
at 11:11 PM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-11 at 22:12 +0100, Maarten Maathuis wrote: A few comments are in order, i noticed that this additional wait_for_idle does cause delays sometimes (obviously). and it seems like an excellent way to do a DOS attack on your gpu. fbcon

Re: [TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-10 Thread Maarten Maathuis
page_address on x86_64, since that doesn't have or need PAE or anything like that. /Thomas Maarten Maathuis wrote: I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious

Re: [Nouveau] [TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-10 Thread Maarten Maathuis
page_address on x86_64, since that doesn't have or need PAE or anything like that. /Thomas Maarten Maathuis wrote: I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious

[TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-09 Thread Maarten Maathuis
I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious, the result of kmap_atomic() is wrong. This is nouveau/linux-2.6 which is somewhere after 2.6.32. I was wondering if

Re: [Nouveau] [PATCH] nouveau: nv50: fix -pseudo_palette usage

2010-01-09 Thread Maarten Maathuis
This is the patch http://cgit.freedesktop.org/nouveau/linux-2.6/commit/?id=aac125bb84c73a7637de5e85a6cc23ab81357552 Maybe a rebased patch went upstream (no idea if this happened already)? Maarten. On Sat, Jan 9, 2010 at 5:05 PM, Alexey Dobriyan adobri...@gmail.com wrote: On Mon, Jan 04, 2010

[Nouveau] [TTM] general protection fault in ttm_tt_swapout, to_virtual looks screwed up

2010-01-09 Thread Maarten Maathuis
I've been noticing for a while that i've been getting general protection faults in ttm_to_swapout, this time i was printk'ing the virtual addresses. In case it's not obvious, the result of kmap_atomic() is wrong. This is nouveau/linux-2.6 which is somewhere after 2.6.32. I was wondering if

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-06 Thread Maarten Maathuis
:55 PM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 10:19 PM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 9:41 AM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 4:20 AM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01

Re: [Nouveau] Removal of Non-KMS support

2010-01-06 Thread Maarten Maathuis
the patch line by line, and only agree with the intention of the patch: Acked-By: Maarten Maathuis madman2...@gmail.com Assuming curro_ concerns are dealt with. On Wed, Jan 6, 2010 at 9:59 PM, Francisco Jerez curroje...@riseup.net wrote: Ben Skeggs skeg...@gmail.com writes: I did a very quick

Re: [Nouveau] Removal of Non-KMS support

2010-01-06 Thread Maarten Maathuis
It should be Acked-by (notice the lack of capital b): Acked-by: Maarten Maathuis madman2...@gmail.com And curro_ == Francisco Jerez, i was thinking in irc mode. On Wed, Jan 6, 2010 at 11:16 PM, Maarten Maathuis madman2...@gmail.com wrote: I had a quick look, and i have nothing to add. I must

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-05 Thread Maarten Maathuis
On Tue, Jan 5, 2010 at 4:20 AM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-04 at 23:54 +0100, Maarten Maathuis wrote: I forgot to mention that you should run nop from fbcon without X running for reliable lockups. Yup, that's what I've been doing. On Mon, Jan 4, 2010 at 11:39 PM

Re: [Nouveau] [PATCH 3/3] nouveau: rewrite nouveau_stateobj to use BEGIN_RING properly

2010-01-05 Thread Maarten Maathuis
Pushed after conformation that nv3x and nv4x work. On Tue, Jan 5, 2010 at 3:19 AM, Younes Manton youne...@gmail.com wrote: On Wed, Dec 30, 2009 at 4:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - The previous solution was hacky and didn't do subchannel autobinding. - The beheaviour

Re: [Nouveau] Assertion failure in gallium on nv50

2010-01-05 Thread Maarten Maathuis
Update to the latest mesa, it's a know bug and the fix was finally pushed about 20 minutes ago. Maarten. On Tue, Jan 5, 2010 at 7:28 PM, Tavian Barnes taviana...@gmail.com wrote: I upgraded mesa, libdrm, xf86-video-nouveau and the DRM module to latest git recently (previously I had git

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-05 Thread Maarten Maathuis
On Tue, Jan 5, 2010 at 9:41 AM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 4:20 AM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-04 at 23:54 +0100, Maarten Maathuis wrote: I forgot to mention that you should run nop from fbcon without X running for reliable

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-05 Thread Maarten Maathuis
On Tue, Jan 5, 2010 at 10:19 PM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 9:41 AM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 4:20 AM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-04 at 23:54 +0100, Maarten Maathuis wrote: I forgot

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-05 Thread Maarten Maathuis
On Tue, Jan 5, 2010 at 10:19 PM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 9:41 AM, Maarten Maathuis madman2...@gmail.com wrote: On Tue, Jan 5, 2010 at 4:20 AM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-04 at 23:54 +0100, Maarten Maathuis wrote: I forgot

Mesa (master): nouveau: kill nouveau_push. h and use libdrm versions of BEGIN_RINGs, etc

2010-01-05 Thread Maarten Maathuis
Module: Mesa Branch: master Commit: 29d2ab37e65c9242d01f63cc5376cb6929f9285f URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=29d2ab37e65c9242d01f63cc5376cb6929f9285f Author: Marcin Slusarz marcin.slus...@gmail.com Date: Tue Dec 29 00:36:17 2009 +0100 nouveau: kill nouveau_push.h and

Mesa (master): nv50: remove vtxbuf stateobject after a referenced vtxbuf is mapped

2010-01-05 Thread Maarten Maathuis
Module: Mesa Branch: master Commit: c306ef5e81da5456d39a6e98cfc1f5f00b9c77a7 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c306ef5e81da5456d39a6e98cfc1f5f00b9c77a7 Author: Maarten Maathuis madman2...@gmail.com Date: Sun Dec 20 12:19:19 2009 +0100 nv50: remove vtxbuf stateobject

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-04 Thread Maarten Maathuis
:36 PM, Maarten Maathuis madman2...@gmail.com wrote: Many people using nv50+ hardware are aware of gpu lockups when a fifo closes under certain conditions. Based on a mmio-trace and some trail and error testing i've come up with a patch that improves the situation on my NV96. This patch needs

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-04 Thread Maarten Maathuis
I forgot to mention that you should run nop from fbcon without X running for reliable lockups. On Mon, Jan 4, 2010 at 11:39 PM, Ben Skeggs skeg...@gmail.com wrote: On Mon, 2010-01-04 at 20:29 +0100, Maarten Maathuis wrote: I've narrowed it down further, the pgraph-fifo_access bit is still

Re: Window Manager Decoration garbage w/ head everything + KMS

2010-01-03 Thread Maarten Maathuis
2009/12/31 Maarten Maathuis madman2...@gmail.com: Yes, i'm seeing these corruptions. Busy with something else atm though. Maarten. 2009/12/31 Michel Dänzer mic...@daenzer.net: On Wed, 2009-12-30 at 16:11 -0500, Andrew Chant wrote: The output of git-bisect, which I verified by checking out

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-02 Thread Maarten Maathuis
Please do report your successes, and not only failures. On Sat, Jan 2, 2010 at 4:36 PM, Maarten Maathuis madman2...@gmail.com wrote: Many people using nv50+ hardware are aware of gpu lockups when a fifo closes under certain conditions. Based on a mmio-trace and some trail and error testing

Re: [Nouveau] Latest xf86-video-nouveau does not compile

2010-01-02 Thread Maarten Maathuis
Does this patch help? From f1fa2e3b15e24175fb899418bbe0d587237ca797 Mon Sep 17 00:00:00 2001 From: Maarten Maathuis madman2...@gmail.com Date: Sun, 3 Jan 2010 02:14:36 +0100 Subject: [PATCH] exa: Some compat defines for depth 30 formats. Signed-off-by: Maarten Maathuis madman2...@gmail.com

Re: [Nouveau] Latest xf86-video-nouveau does not compile

2010-01-02 Thread Maarten Maathuis
Attempt 2, better? From 061cb284b93612848296599759b915a4d66b6d01 Mon Sep 17 00:00:00 2001 From: Maarten Maathuis madman2...@gmail.com Date: Sun, 3 Jan 2010 02:14:36 +0100 Subject: [PATCH] exa: Some compat defines for new pixman formats. Signed-off-by: Maarten Maathuis madman2...@gmail.com

Re: [Nouveau] [PATCH/TESTING(all hw)/DISCUSSION] FIFO (minor) create and (major) destroy instabilities on nv50+

2010-01-02 Thread Maarten Maathuis
I hope you did add a note for your victims :-) On Sun, Jan 3, 2010 at 1:37 AM, Johannes Obermayr johannesoberm...@gmx.de wrote: Am Samstag, 2. Januar 2010 16:39:55 schrieb Maarten Maathuis: Please do report your successes, and not only failures. Hi, I included it in my openSUSE Build

Re: Window Manager Decoration garbage w/ head everything + KMS

2010-01-01 Thread Maarten Maathuis
fallbacks.     Signed-off-by: Michel Dänzer daen...@vmware.com     Acked-By: Maarten Maathuis madman2...@gmail.com     Signed-off-by: Keith Packard kei...@keithp.com :04 04 1f2bb220d39d1ea98fbe330b08786570fb089190 9cbf71dd4c6aa203c0f5220e88f9263f583a8faa M      exa Thanks

[Nouveau] [PATCH 1/3] nv50: remove vtxbuf stateobject after a referenced vtxbuf is mapped

2009-12-30 Thread Maarten Maathuis
- This avoids problematic reloc'ed while mapped messages and some associated corruption as well. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- src/gallium/drivers/nouveau/nouveau_screen.c | 21 + src/gallium/drivers/nouveau/nouveau_screen.h |3 +++ src

[Nouveau] [PATCH 3/3] nouveau: rewrite nouveau_stateobj to use BEGIN_RING properly

2009-12-30 Thread Maarten Maathuis
debugging is on it will check for abuse. - The values for nv30/nv40 may be off, but this should be easily caught with DEBUG on. Signed-off-by: Maarten Maathuis madman2...@gmail.com --- src/gallium/drivers/nouveau/nouveau_stateobj.h | 289 +--- src/gallium/drivers/nv04/nv04_screen.c

Re: [Nouveau] [PATCH 1/3] nv50: remove vtxbuf stateobject after a referenced vtxbuf is mapped

2009-12-30 Thread Maarten Maathuis
Same patch from before, without the debatable unmap change. On Wed, Dec 30, 2009 at 10:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - This avoids problematic reloc'ed while mapped messages and some associated corruption as well. Signed-off-by: Maarten Maathuis madman2...@gmail.com

Re: [Nouveau] [PATCH 3/3] nouveau: rewrite nouveau_stateobj to use BEGIN_RING properly

2009-12-30 Thread Maarten Maathuis
The prerequisite patch (which kills nouveau_push) got stuck in queue because of it's size. This patch is here for discussion, and it needs testing on nv30/nv40 for miscalculated so sizes. On Wed, Dec 30, 2009 at 10:36 PM, Maarten Maathuis madman2...@gmail.com wrote: - The previous solution

Re: [PATCH 2/3] EXA: Fix migration avoidance for 1x1 pixmaps.

2009-12-29 Thread Maarten Maathuis
Acked-by: Maarten Maathuis madman2...@gmail.com 2009/12/28 Michel Dänzer mic...@daenzer.net: On Mon, 2009-12-28 at 13:27 +0100, Maarten Maathuis wrote: Why does it help to allocate the sys_ptr up front, why does that avoid migration (i would except sys_ptr to be allocated when needed

Re: [PATCH 4/4] EXA: Restrict the regions that need to be migrated for composite fallback for src / mask pictures.

2009-12-29 Thread Maarten Maathuis
Acked-by: Maarten Maathuis madman2...@gmail.com 2009/12/28 Michel Dänzer mic...@daenzer.net: On Mon, 2009-12-28 at 16:05 +0100, Maarten Maathuis wrote: 2009/12/28 Michel Dänzer mic...@daenzer.net: On Mon, 2009-12-28 at 13:51 +0100, Maarten Maathuis wrote: I don't quite get why this has

<    1   2   3   4   5   6   7   8   9   >