https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/94654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94869
- Removed custom smart pointers handling (were hiding issues)
- Changed 'move occurred here' note location to always point to 'std::move'
Closes #90174
>From 1179f63d792da2462e1490c1b0a59cf1e6e47349 Mon Sep
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/94654
>From 5d37ba1925696582d752a45ceec605c8b6277543 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Thu, 6 Jun 2024 18:17:55 +
Subject: [PATCH] [clang-tidy] Ignore non-math operators in
PiotrZSL wrote:
Check if you can commit to sebwolf-de:avoid-bounds-error-check
https://github.com/llvm/llvm-project/pull/90043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/94697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
@11happy You may want to take a look.
https://github.com/llvm/llvm-project/pull/94654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94654
Do not emit warnings for non-math operators.
Closes #92516
>From 034026add71cc0ec09e7cb715bffef38c5533233 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Thu, 6 Jun 2024 18:17:55 +
Subject: [PATCH]
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94651
Add StrictCStandardCompliance and StrictCppStandardCompliance options that
default to true.
Closes #83732
>From 1f166251b629c1fd9dd2e5b8ac64ee5976ee0724 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Thu,
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/94527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/94636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -24,12 +24,28 @@ namespace {
AST_MATCHER(Decl, isFirstDecl) { return Node.isFirstDecl(); }
-AST_MATCHER_P(Decl, isInMainFile, FileExtensionsSet, HeaderFileExtensions) {
+static bool isInMainFile(SourceLocation L, SourceManager ,
+ const
@@ -24,12 +24,28 @@ namespace {
AST_MATCHER(Decl, isFirstDecl) { return Node.isFirstDecl(); }
-AST_MATCHER_P(Decl, isInMainFile, FileExtensionsSet, HeaderFileExtensions) {
+static bool isInMainFile(SourceLocation L, SourceManager ,
+ const
https://github.com/PiotrZSL deleted
https://github.com/llvm/llvm-project/pull/90830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94527
Fixed crash caused by call to getCookedLiteral on
template user defined literal. Fix base on assert in getCookedLiteral method.
Closes #94454
>From a19a71fdf5e421c6b79fc3d6ecf7212b090b13a1 Mon Sep 17 00:00:00
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94524
Ignore implicit pointer conversions that are part of a cast expression
Closes #93959
>From bdff94eb18212005d059a5cbb8d649a356fdd301 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Wed, 5 Jun 2024 19:19:38
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/93217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/94512
Ignore implicit declarations and defaulted functions. Helps with issues in
generated code like, C++
spaceship operator.
Closes #93409
>From 22cd99f5288f53eb561a3040ce78c5143a9a7dad Mon Sep 17 00:00:00 2001
@@ -193,3 +193,8 @@ Options
When `true`, the check will warn on an expression like
``sizeof(expr)`` where the expression is a pointer
to aggregate. Default is `true`.
+
+.. option:: WarnOnSizeOfPointer
+
+ When `true`, the check will warn on an expression like
@@ -292,11 +318,17 @@ void SizeofExpressionCheck::check(const
MatchFinder::MatchResult ) {
diag(E->getBeginLoc(),
"suspicious usage of 'sizeof(char*)'; do you mean 'strlen'?")
<< E->getSourceRange();
- } else if (const auto *E =
-
https://github.com/PiotrZSL approved this pull request.
+- LGTM, except nits.
https://github.com/llvm/llvm-project/pull/94356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/94356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -193,3 +193,8 @@ Options
When `true`, the check will warn on an expression like
``sizeof(expr)`` where the expression is a pointer
to aggregate. Default is `true`.
+
+.. option:: WarnOnSizeOfPointer
+
+ When `true`, the check will warn on an expression like
https://github.com/PiotrZSL approved this pull request.
I accept this change as it's fine for 1.0 version
Any fixed can be always done in this or new change.
https://github.com/llvm/llvm-project/pull/90830
___
cfe-commits mailing list
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/94104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -351,6 +351,10 @@ Changes in existing checks
` check to also handle
calls to ``compare`` method.
+- Improved :doc:`modernize-use-std-format` and
PiotrZSL wrote:
remove modernize-use-std-format from here, as it's new check, only leave
std-print
https://github.com/PiotrZSL approved this pull request.
Overall LGTM, consider adding release note entry for modernize-use-std-print
(as it were added in previous release)
https://github.com/llvm/llvm-project/pull/94104
___
cfe-commits mailing list
@@ -20,6 +20,11 @@ namespace clang::tidy::modernize {
namespace {
AST_MATCHER(StringLiteral, isOrdinary) { return Node.isOrdinary(); }
+AST_MATCHER(QualType, isSimpleChar) {
+ const auto ActualType = Node.getTypePtr();
+ return
@@ -20,6 +20,11 @@ namespace clang::tidy::modernize {
namespace {
AST_MATCHER(StringLiteral, isOrdinary) { return Node.isOrdinary(); }
+AST_MATCHER(QualType, isSimpleChar) {
+ const auto ActualType = Node.getTypePtr();
+ return
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/94104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -41,3 +41,25 @@ The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and
``c_reference``
will all generate warnings since they are either a non-const globally
accessible
variable, a pointer or a reference providing global access to non-const data
or both.
+
+Options
@@ -41,3 +41,25 @@ The variables ``a``, ``c``, ``c_ptr1``, ``c_const_ptr`` and
``c_reference``
will all generate warnings since they are either a non-const globally
accessible
variable, a pointer or a reference providing global access to non-const data
or both.
+
+Options
@@ -1,29 +1,39 @@
-// RUN: %check_clang_tidy %s
cppcoreguidelines-avoid-non-const-global-variables %t
+// RUN: %check_clang_tidy %s -check-suffix=DEFAULT
cppcoreguidelines-avoid-non-const-global-variables %t
+// RUN: %check_clang_tidy %s -check-suffix=NAMESPACE
@@ -16,9 +15,12 @@ using namespace clang::ast_matchers;
namespace clang::tidy::cppcoreguidelines {
void AvoidNonConstGlobalVariablesCheck::registerMatchers(MatchFinder *Finder) {
+ auto NamespaceMatcher = Options.get("AllowAnonymousNamespace", false)
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/93827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL requested changes to this pull request.
- storeOptions is missing
- release notes need to be updated about added new option
- tests need some love (reduce amount of changes)
- what about "static" non const global variables
I'm fine for having an options that control
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/93724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
I'm not 100% sure about release-notes entry. If it shouldn't say that check is
restricted now to zero-argument size/length.
https://github.com/llvm/llvm-project/pull/93724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/93724
Verify that size/length methods are called with no arguments.
Closes #88203
>From 0e8c1ceb616d797298db720069e2eea937a9078e Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Wed, 29 May 2024 19:39:22 +
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/93217
>From 14e3f91ba749eec5be94a9cad370f794ad836fc8 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Wed, 22 May 2024 20:56:00 +
Subject: [PATCH 1/2] [clang-tidy] Fix handling of members in
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/93467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -387,6 +387,11 @@ Changes in existing checks
` check to properly
emit warnings for static data member with an in-class initializer.
+- Improved :doc:`readability-redundant-member-init
+ ` check to avoid
+ false-positives when type of the member does not match type of
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/93467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/89744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
> > For me this entire change doesn't make sense.
>
> Could you elaborate on why?
This is basically names passed as FOLDER property are very generic. My main
confusion where with clangTidyMiscModule library, but as this is
semi-redundant. Then this change is +- fine.
PiotrZSL wrote:
@nicovank Overall looks fine from functionality point of view.
Problem A)
Getting bunch of
```
task: wait_for=
cb=[as_completed.._on_completion() at
/usr/lib/python3.12/asyncio/tasks.py:618]>
Task was destroyed but it is pending!
```
When CTR+C a script. More graceful
PiotrZSL wrote:
No need for release notes as this realpath stuff were added in this release
anyway. So this is just a fix for degradation.
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson
Message-ID:
In-Reply-To:
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/92241
___
cfe-commits mailing
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/93217
Compare class type instead of just assuming
that called constructor belong to same class.
Fixes #91605
>From 6402bdd7555b8804ca4a2c392695fa81e8a87c4e Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Wed, 22
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy
Message-ID:
In-Reply-To:
https://github.com/PiotrZSL approved this pull request.
LGTM (if tests pass)
https://github.com/llvm/llvm-project/pull/93024
___
cfe-commits mailing list
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 8ed57a657d9b87bfaaa5c4394fc3fcaf670ba94c Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/6] [clang-tidy] Added bugprone-exception-rethrow check
@@ -0,0 +1,103 @@
+// RUN: %check_clang_tidy %s bugprone-exception-rethrow %t -- -- -fexceptions
+
+struct exception {};
+
+namespace std {
PiotrZSL wrote:
that's a job for separate change, as std::move is duplicated in multiple test
files.
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From c99ba980b0b242fced57fb323c5069d856c68810 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 31 Mar 2024 12:16:53 +
Subject: [PATCH 1/6] fix
---
clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 01/10] [clang-tidy] Added bugprone-exception-rethrow check
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/9] [clang-tidy] Added bugprone-exception-rethrow check
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/8] [clang-tidy] Added bugprone-exception-rethrow check
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/7] [clang-tidy] Added bugprone-exception-rethrow check
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/5] [clang-tidy] Added bugprone-exception-rethrow check
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/86448
>From 1b5c351acca7375c577111a4c55506146ef108ef Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Sun, 24 Mar 2024 18:39:54 +
Subject: [PATCH 1/6] [clang-tidy] Added bugprone-exception-rethrow check
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/91954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson
Message-ID:
In-Reply-To:
@@ -267,6 +275,10 @@ void
ImplicitBoolConversionCheck::registerMatchers(MatchFinder *Finder) {
auto BoolXor =
binaryOperator(hasOperatorName("^"),
=?utf-8?q?Bj=C3=B6rn?= Svensson ,
=?utf-8?q?Bj=C3=B6rn?= Svensson ,
=?utf-8?q?Bj=C3=B6rn?= Svensson
Message-ID:
In-Reply-To:
https://github.com/PiotrZSL approved this pull request.
LGTM, just nits
https://github.com/llvm/llvm-project/pull/92241
___
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson ,
=?utf-8?q?Björn?= Svensson
Message-ID:
In-Reply-To:
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/92241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/92659
>From a2ae273d083f451f44a41bd928c42a5bbdd946ae Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Tue, 21 May 2024 17:36:08 +
Subject: [PATCH] [clang-tidy] Optimize readability-identifier-naming
- Reduce
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/92659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/92659
- Reduce disk IO usage by adding cache to an realpath introduced by #81985
- Refactor HungarianNotation::getDeclTypeName to remove some string copies and
use more safe string API.
>From
PiotrZSL wrote:
@nicovank I think that code is fine, will re-check it today. We could always
think about something else later.
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/71683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/92019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/71683
>From 40d7a61e98fdd64d295aa720671f47b522c261a3 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Wed, 8 Nov 2023 13:31:28 +
Subject: [PATCH] [clang-tidy] Add AllowImplicitlyDeletedCopyOrMove option to
https://github.com/PiotrZSL updated
https://github.com/llvm/llvm-project/pull/92019
>From 5f0302b0d1c34d13b566aa6f992568005a47fac0 Mon Sep 17 00:00:00 2001
From: Piotr Zegar
Date: Mon, 13 May 2024 19:47:44 +
Subject: [PATCH 1/2] [clang-tidy] Fix crash in modernize-use-constraints
Improved
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/92025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
Not adding release notes & tests, as this is issue happen only when asserts are
enabled and input is invalid.
Fix created only to improve diagnostic for end user (errors instead of crash)
in this particular case.
https://github.com/llvm/llvm-project/pull/92025
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/92025
When expression got errors (missing typedef) and clang-tidy is compiled with
asserts enabled, then we crash in this check on assert because type with errors
is visible as an dependent one. This is issue caused
PiotrZSL wrote:
@ccotter Can you take a look, somehow I cannot select you as reviewer.
https://github.com/llvm/llvm-project/pull/92019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL created
https://github.com/llvm/llvm-project/pull/92019
Improved modernize-use-constraints check by fixing a crash that occurred in
some scenarios and excluded system headers from analysis.
Problem were with DependentNameTypeLoc having null type location as
PiotrZSL wrote:
Bump.
https://github.com/llvm/llvm-project/pull/71683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/90397
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/90410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,78 @@
+//===--- UseInternalLinkageCheck.cpp -
clang-tidy--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/PiotrZSL commented:
Few nits.
Missing:
- more proper handling for unity files (.cpp included from .cpp)
- nits
- auto-fixes (any) - in worst case you can provide just fixes with static, but
attaching them to notes.
https://github.com/llvm/llvm-project/pull/90830
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/90830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
> > * The auto-fix should be configurable to choose `static` or anonymous
> > namespace.
>
> Should I implement auto-fix for this check? Maybe some functions / variables
> will be marked incorrectly and cause link error because the coder just forget
> to include the header
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -115,6 +115,8 @@ Improvements to clang-tidy
- Fixed `--verify-config` option not properly parsing checks when using the
literal operator in the `.clang-tidy` config.
+- Added argument `--exclude-header-filter` to exclude headers from analysis
via a RegEx.
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/91400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
LGTM, just 2 nits.
https://github.com/llvm/llvm-project/pull/91400
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -292,6 +296,14 @@ def main():
"-config option after reading specified config file. "
"Use either -config-file or -config, not both.",
)
+parser.add_argument(
+"-exclude-header-filter",
+default=None,
+help="regular expression
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/91954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1905 matches
Mail list logo
