Author: rnk
Date: Thu Mar 14 11:12:17 2019
New Revision: 356185
URL: http://llvm.org/viewvc/llvm-project?rev=356185&view=rev
Log:
Add PragmaHandler for MSVC pragma execution_character_set
__pragma(execution_character_set(push, "UTF-8")) is used in
TraceLoggingProvider.h. This commit implements a
Author: rnk
Date: Thu Mar 14 11:12:17 2019
New Revision: 356185
URL: http://llvm.org/viewvc/llvm-project?rev=356185&view=rev
Log:
Add PragmaHandler for MSVC pragma execution_character_set
__pragma(execution_character_set(push, "UTF-8")) is used in
TraceLoggingProvider.h. This commit implements a
Aaron, I've followed both links you point to to answer the questions being
asked, and to me they don't seem to contain obvious answers. I understand
that repeatedly answering the same question over and over again is tedious
and we are all busy, but please remind us why both DIFlagTrivial and
DIFlag
I would recommend doing what was done for _xgetbv as in r351391:
- Provide __builtin_ia32_rot* everywhere (or something like that in the
implementor's namespace)
- Conditionally #define _rot* to __builtin_ia32_rot* in ia32intrin.h, maybe
ifdef _GNUC
- Also provide _rot* builtins when -fms-extension
Author: rnk
Date: Thu Mar 7 10:57:04 2019
New Revision: 355625
URL: http://llvm.org/viewvc/llvm-project?rev=355625&view=rev
Log:
Fix some clang analysis tests passing arguments incorrectly
Modified:
cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp
Modified: cfe/trunk/unittests/Anal
Author: rnk
Date: Wed Feb 27 15:38:44 2019
New Revision: 355044
URL: http://llvm.org/viewvc/llvm-project?rev=355044&view=rev
Log:
[InstrProf] Use separate comdat group for data and counters
Summary:
I hadn't realized that instrumentation runs before inlining, so we can't
use the function as the c
Author: rnk
Date: Tue Feb 26 12:42:52 2019
New Revision: 354924
URL: http://llvm.org/viewvc/llvm-project?rev=354924&view=rev
Log:
[MS] Don't emit coverage for deleting dtors
Summary:
The MS C++ ABI has no constructor variants, but it has destructor
variants, so we should move the deleting destruc
Author: rnk
Date: Mon Feb 25 18:22:22 2019
New Revision: 354839
URL: http://llvm.org/viewvc/llvm-project?rev=354839&view=rev
Log:
Revert r354832 "[ASTImporter] Add support for importing ChooseExpr AST nodes."
Test does not pass on Windows
Removed:
cfe/trunk/test/ASTMerge/
Modified:
cfe/t
Author: rnk
Date: Mon Feb 25 18:22:17 2019
New Revision: 354838
URL: http://llvm.org/viewvc/llvm-project?rev=354838&view=rev
Log:
[MS] Fix for Bug 8446, template instantiation without a 'typename' keyword
Patch by Zahira Ammarguellat!
Differential Revision: https://reviews.llvm.org/D41950
Added
Author: rnk
Date: Thu Feb 21 13:53:12 2019
New Revision: 354626
URL: http://llvm.org/viewvc/llvm-project?rev=354626&view=rev
Log:
[clang-cl] Whitelist -fbracket-depth=123 in clang-cl
Users apparently need it when expanding large quantities of macros.
Fixes PR38685
Modified:
cfe/trunk/includ
Author: rnk
Date: Fri Feb 15 12:48:12 2019
New Revision: 354169
URL: http://llvm.org/viewvc/llvm-project?rev=354169&view=rev
Log:
Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening
the file"
The new test doesn't pass on Windows.
Modified:
cfe/trunk/lib/Basic/Fil
Reverted:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351
On Fri, Feb 15, 2019 at 11:07 AM Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Jan,
>
> It looks like this commit broke tests on couple of win builders:
>
> http://lab.llvm.org:8011/buil
Author: rnk
Date: Fri Feb 15 11:59:45 2019
New Revision: 354162
URL: http://llvm.org/viewvc/llvm-project?rev=354162&view=rev
Log:
[MSVC] Recognize `static_assert` keyword in C and C++98
Summary:
The main effect is that clang now accepts the following conforming C11
code with MSVC headers:
#incl
Author: rnk
Date: Tue Feb 12 14:51:54 2019
New Revision: 353893
URL: http://llvm.org/viewvc/llvm-project?rev=353893&view=rev
Log:
Revert r353880 "[HIP] Handle compile -m options and propagate into LLC"
This was still causing test failures in the clang test suite.
Removed:
cfe/trunk/test/Driv
Author: rnk
Date: Tue Feb 12 13:04:21 2019
New Revision: 353878
URL: http://llvm.org/viewvc/llvm-project?rev=353878&view=rev
Log:
[X86] Use __m128_u for _mm_loadu_ps after r353555
Add secondary triple to existing SSE test for it. I audited other uses
of __attribute__((__packed__)) in the intrins
Author: rnk
Date: Sun Feb 10 12:20:26 2019
New Revision: 353654
URL: http://llvm.org/viewvc/llvm-project?rev=353654&view=rev
Log:
Fix test to pass on LLP64 targets
Modified:
cfe/trunk/test/Analysis/osobjectcstylecastchecker_test.cpp
Modified: cfe/trunk/test/Analysis/osobjectcstylecastchecker
Author: rnk
Date: Sun Feb 10 12:17:07 2019
New Revision: 353653
URL: http://llvm.org/viewvc/llvm-project?rev=353653&view=rev
Log:
Fix clang tests broken by r353547 that depend on InstrProf
Modified:
cfe/trunk/test/CoverageMapping/unused_names.c
cfe/trunk/test/Profile/cxx-lambda.cpp
cf
Author: rnk
Date: Fri Jan 25 11:18:40 2019
New Revision: 352232
URL: http://llvm.org/viewvc/llvm-project?rev=352232&view=rev
Log:
[CodeGen] Implement isTriviallyRecursive with StmtVisitor instead of
RecursiveASTVisitor
This code doesn't need to traverse types, lambdas, template arguments,
etc to
Author: rnk
Date: Thu Jan 24 14:26:51 2019
New Revision: 352119
URL: http://llvm.org/viewvc/llvm-project?rev=352119&view=rev
Log:
[clang-cl] Ignore space-separated /AI arguments
The /AI flag is for #using directives, which I don't think we support.
This is consistent with how the /I flag is handl
Author: rnk
Date: Thu Jan 17 12:52:46 2019
New Revision: 351478
URL: http://llvm.org/viewvc/llvm-project?rev=351478&view=rev
Log:
Fix -Wsign-compare in new tests
Modified:
cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
URL:
http://llvm.org/
Author: rnk
Date: Wed Jan 16 14:05:34 2019
New Revision: 351383
URL: http://llvm.org/viewvc/llvm-project?rev=351383&view=rev
Log:
Fix libc++ mac driver test to pass on Windows
There is a substitution for 'clang-check' to absolutize it, so the
'$(which clang-check)' is unnecessary.
Modified:
Author: rnk
Date: Tue Jan 15 13:24:55 2019
New Revision: 351249
URL: http://llvm.org/viewvc/llvm-project?rev=351249&view=rev
Log:
[clang-cl] Alias /Zc:alignedNew[-] to -f[no-]aligned-allocation
Implements PR40180.
clang-cl has one minor behavior difference with cl with this change.
Clang allows
Author: rnk
Date: Wed Dec 26 13:04:08 2018
New Revision: 350072
URL: http://llvm.org/viewvc/llvm-project?rev=350072&view=rev
Log:
[clang-cl] Treat inputs as C++ with /E, like MSVC
midl invokes the compiler on .idl files with /E. Before this change, we
would treat unrecognized inputs as object fil
Author: rnk
Date: Wed Dec 26 12:07:52 2018
New Revision: 350071
URL: http://llvm.org/viewvc/llvm-project?rev=350071&view=rev
Log:
[MS] Mangle return adjusting thunks with the public access specifier
MSVC does this, so we should too.
Fixes PR40138
Added:
cfe/trunk/test/CodeGenCXX/mangle-ms-t
Author: rnk
Date: Wed Dec 26 09:44:40 2018
New Revision: 350068
URL: http://llvm.org/viewvc/llvm-project?rev=350068&view=rev
Log:
Ignore ConstantExpr in IgnoreParens
Summary:
This moves it up from IgnoreParenImpCasts to IgnoreParens, so that more
helpers ignore it. For most clients, this ensures
Author: rnk
Date: Thu Dec 20 17:40:29 2018
New Revision: 349872
URL: http://llvm.org/viewvc/llvm-project?rev=349872&view=rev
Log:
[mingw] Don't mangle thiscall like fastcall etc
GCC does not mangle it when it is not explicit in the source. The
mangler as currently written cannot differentiate be
Author: rnk
Date: Mon Dec 17 15:16:43 2018
New Revision: 349415
URL: http://llvm.org/viewvc/llvm-project?rev=349415&view=rev
Log:
Fix ms-layout_version declspec test and add missing new test
Now that MSVC compatibility versions are stored as a four digit number
(1912) instead of a two digit numbe
Author: rnk
Date: Mon Dec 17 15:10:43 2018
New Revision: 349414
URL: http://llvm.org/viewvc/llvm-project?rev=349414&view=rev
Log:
Update Microsoft name mangling scheme for exception specifiers in the type
system
Summary:
The msvc exception specifier for noexcept function types has changed
from t
I sent https://reviews.llvm.org/D55781 and cc'd the original reviewers so
we can decide if it's worth the cost.
On Fri, Dec 14, 2018 at 5:17 PM Richard Smith wrote:
> Should this change be disableable by -fclang-abi-compat=7 or below?
>
> On Fri, 14 Dec 2018, 15:46 Reid Kleck
Author: rnk
Date: Fri Dec 14 15:42:59 2018
New Revision: 349212
URL: http://llvm.org/viewvc/llvm-project?rev=349212&view=rev
Log:
Mangle calling conventions into function pointer types where GCC does
Summary:
GCC 5.1 began mangling these Windows calling conventions into function
types, since they
r349086 should take care of it, but you may want to tweak it.
On Thu, Dec 13, 2018 at 1:30 PM Reid Kleckner wrote:
> This new test doesn't pass on Windows. I think it's an LLP64-ness bug
> based on the output:
> Note: Google Test filter = PreferredTypeTest.Binar*
> [==] Running 1 test fr
Author: rnk
Date: Thu Dec 13 13:41:07 2018
New Revision: 349086
URL: http://llvm.org/viewvc/llvm-project?rev=349086&view=rev
Log:
Attempt to fix code completion test to handle LLP64 platforms
Modified:
cfe/trunk/unittests/Sema/CodeCompleteTest.cpp
Modified: cfe/trunk/unittests/Sema/CodeCompl
This new test doesn't pass on Windows. I think it's an LLP64-ness bug based
on the output:
Note: Google Test filter = PreferredTypeTest.Binar*
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from PreferredTypeTest
[ RUN ] Preferred
Author: rnk
Date: Thu Dec 13 13:24:08 2018
New Revision: 349085
URL: http://llvm.org/viewvc/llvm-project?rev=349085&view=rev
Log:
Fix test after -Wstring-plus-int warning was enabled
Use array indexing instead of addition.
Modified:
cfe/trunk/test/SemaCXX/constant-expression-cxx1y.cpp
Modif
Author: rnk
Date: Thu Dec 13 13:18:16 2018
New Revision: 349083
URL: http://llvm.org/viewvc/llvm-project?rev=349083&view=rev
Log:
Fix debug-info-abspath.c on Windows by removing /tmp/t.o line
This object seemed unused, so I believe we can just remove this compiler
invocation without losing any te
On Thu, Dec 13, 2018 at 9:56 AM Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> +// RUN: cd %t/UNIQUEISH_SENTINEL
> +// RUN: %clang_cc1 -debug-info-kind=limited -triple %itanium_abi_triple \
> +// RUN: debug-info-abspath.c -emit-obj -o /tmp/t.o
>
Do you need to create thi
Author: rnk
Date: Wed Dec 12 17:33:20 2018
New Revision: 349001
URL: http://llvm.org/viewvc/llvm-project?rev=349001&view=rev
Log:
Remove unused Args parameter from EmitFunctionBody, NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
cfe/trunk/lib/CodeGen/CodeGenFunction.h
Modified:
Author: rnk
Date: Wed Dec 12 15:46:06 2018
New Revision: 348991
URL: http://llvm.org/viewvc/llvm-project?rev=348991&view=rev
Log:
Emit a proper diagnostic when attempting to forward inalloca arguments
The previous assertion was relatively easy to trigger, and likely will
be easy to trigger going
Author: rnk
Date: Tue Nov 27 13:20:42 2018
New Revision: 347713
URL: http://llvm.org/viewvc/llvm-project?rev=347713&view=rev
Log:
[MS] Push outermost class DeclContexts only in -fdelayed-template-parsing
This is more or less a complete rewrite of r347627, and it fixes PR38460
I added a reduced te
Author: rnk
Date: Mon Nov 26 19:55:15 2018
New Revision: 347633
URL: http://llvm.org/viewvc/llvm-project?rev=347633&view=rev
Log:
[docs] UBSan and ASan are supported on Windows
Also fix a bullet list.
Fixes PR39775
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/UndefinedBe
Author: rnk
Date: Mon Nov 26 18:54:17 2018
New Revision: 347630
URL: http://llvm.org/viewvc/llvm-project?rev=347630&view=rev
Log:
Revert r347627 "[MS] Push fewer DeclContexts for delayed template parsing"
It broke the Windows self-host:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/bui
Author: rnk
Date: Mon Nov 26 18:21:51 2018
New Revision: 347627
URL: http://llvm.org/viewvc/llvm-project?rev=347627&view=rev
Log:
[MS] Push fewer DeclContexts for delayed template parsing
Only push the outermost record as a DeclContext when parsing a function
body. See the comments in Sema::getCo
Author: rnk
Date: Fri Nov 16 15:17:11 2018
New Revision: 347111
URL: http://llvm.org/viewvc/llvm-project?rev=347111&view=rev
Log:
Add missing test for r347072 -gcodeview-ghash
Added:
cfe/trunk/test/Driver/gcodeview-ghash.c
Added: cfe/trunk/test/Driver/gcodeview-ghash.c
URL:
http://llvm.org/
Author: rnk
Date: Fri Nov 16 10:47:41 2018
New Revision: 347072
URL: http://llvm.org/viewvc/llvm-project?rev=347072&view=rev
Log:
[codeview] Expose -gcodeview-ghash for global type hashing
Summary:
Experience has shown that the functionality is useful. It makes linking
optimized clang with debug
Author: rnk
Date: Wed Nov 14 14:59:27 2018
New Revision: 346907
URL: http://llvm.org/viewvc/llvm-project?rev=346907&view=rev
Log:
[codeview] Make "clang -g" emit codeview by default when targetting MSVC
Summary:
If you're using the Microsoft ABI, chances are that you want PDBs and
codeview debug
Author: rnk
Date: Tue Nov 6 12:45:26 2018
New Revision: 346265
URL: http://llvm.org/viewvc/llvm-project?rev=346265&view=rev
Log:
[MS] Zero out ECX in __cpuid in intrin.h
Summary:
Some CPUID leafs depend on the value of ECX as well as EAX, but we left
it uninitialized.
Originally reported as htt
Author: rnk
Date: Thu Nov 1 12:54:45 2018
New Revision: 345882
URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev
Log:
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing
Author: rnk
Date: Thu Nov 1 12:54:45 2018
New Revision: 345882
URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev
Log:
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing
Author: rnk
Date: Thu Nov 1 11:53:02 2018
New Revision: 345873
URL: http://llvm.org/viewvc/llvm-project?rev=345873&view=rev
Log:
Add LLVM_FALLTHROUGH annotation after switch
This silences a -Wimplicit-fallthrough warning from clang. GCC does not
appear to warn when the case body ends in a switch
Author: rnk
Date: Thu Nov 1 10:51:48 2018
New Revision: 345862
URL: http://llvm.org/viewvc/llvm-project?rev=345862&view=rev
Log:
Replace two fallthrough annotations after covered switch with unreachable
Both preceding switches handle all possible enumerators, so the
fallthrough is actually unrea
Author: rnk
Date: Wed Oct 31 10:43:55 2018
New Revision: 345748
URL: http://llvm.org/viewvc/llvm-project?rev=345748&view=rev
Log:
Re-land r345676 "[Win64] Handle passing i128 by value"
Fix the unintended switch/case fallthrough to avoid changing long double
behavior.
Added:
cfe/trunk/test/Co
On Wed, Oct 31, 2018 at 7:39 AM wrote:
> Also, don't we usually put ABI changes under an ABI compatibility check?
> This would be making Clang incompatible with itself.
>
I don't think it's worth it because nobody can use i128 in a meaningful way
on x64 Windows right now. If you do i128 multipli
Author: rnk
Date: Tue Oct 30 16:58:41 2018
New Revision: 345676
URL: http://llvm.org/viewvc/llvm-project?rev=345676&view=rev
Log:
[Win64] Handle passing i128 by value
For arguments, pass it indirectly, since the ABI doc says pretty clearly
that arguments larger than 8 bytes are passed indirectly.
This patch makes a lot of posix assumptions, and that header file doesn't
exist on Windows. I reverted this to fix the build, but you might want to
reconsider how this is designed.
On Fri, Oct 12, 2018 at 10:24 AM Nick Desaulniers via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nic
Author: rnk
Date: Fri Oct 12 11:08:11 2018
New Revision: 344389
URL: http://llvm.org/viewvc/llvm-project?rev=344389&view=rev
Log:
Revert r344375 "[Driver] check for exit code from SIGPIPE"
This doesn't build on Windows.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Drive
Author: rnk
Date: Wed Oct 10 14:59:56 2018
New Revision: 344190
URL: http://llvm.org/viewvc/llvm-project?rev=344190&view=rev
Log:
[AST] Use -fvisibility value when ignoring -fv-i-h* inline static locals
Summary:
In r340386 we added code to give static locals in inline functions
default visibility
Author: rnk
Date: Thu Oct 4 13:34:52 2018
New Revision: 343809
URL: http://llvm.org/viewvc/llvm-project?rev=343809&view=rev
Log:
Update Clang Windows getting started docs
Summary:
- Update the example VS project generation to use VS2017.
- Add docs for generating ninja build files, since they ar
Author: rnk
Date: Tue Oct 2 15:23:27 2018
New Revision: 343641
URL: http://llvm.org/viewvc/llvm-project?rev=343641&view=rev
Log:
Remove spurious assertion in -Wdocumentation
Some code in OpenCV uses interesting doxygen directives that make it so
we don't see any tokens inside a @note, despite th
I reverted this in r343610 because I noticed many bots were failing to
build after this change. Declaring the field `Corpus Corpus;` upsets GCC. I
considered trying to pick a different field name, but I wasn't able to come
up with one I liked, so I'm punting it back to you. =/
On Tue, Oct 2, 2018
Author: rnk
Date: Tue Oct 2 10:31:43 2018
New Revision: 343610
URL: http://llvm.org/viewvc/llvm-project?rev=343610&view=rev
Log:
Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold
constant. NFC"
Declaring a field with the same name as a type causes GCC to error out:
D
It looks like we don't do anything special if you run clang-cl -O0 or /O0,
but it's not an error. I don't have my computer and can't run a test, but
from the outside, it looks like clang-cl -O0 does generate unoptimized code
without warning about an unrecognized flag, but it doesn't disable FP
elim
Author: rnk
Date: Tue Sep 18 16:16:30 2018
New Revision: 342516
URL: http://llvm.org/viewvc/llvm-project?rev=342516&view=rev
Log:
[MS] Defer dllexport inline friend functions like other inline methods
This special case was added in r264841, but the code breaks our
invariants by calling EmitTopLev
That construct does not work on Windows, where we don't use bash. We use
the lit internal shell, which doesn't support 'if [ ...]'. I marked it
REQUIRES: shell in r342282.
On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: omtcyfz
> Date:
Author: rnk
Date: Fri Sep 14 13:51:07 2018
New Revision: 342282
URL: http://llvm.org/viewvc/llvm-project?rev=342282&view=rev
Log:
Mark index-tools.test as REQUIRES: shell so that it does not run with the
internal lit shell which does not support "if"
Modified:
clang-tools-extra/trunk/test/cl
Author: rnk
Date: Fri Sep 14 13:50:39 2018
New Revision: 342281
URL: http://llvm.org/viewvc/llvm-project?rev=342281&view=rev
Log:
Relax assumption about default method calling convention in new test
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-lambda.cpp
Modified: cfe/trunk/test/CodeGenCXX
Author: rnk
Date: Thu Sep 6 11:25:39 2018
New Revision: 341572
URL: http://llvm.org/viewvc/llvm-project?rev=341572&view=rev
Log:
Re-land r334417 "[MS] Use mangled names and comdats for string merging with
ASan"
The issue with -fprofile-generate was fixed and the dependent CL
relanded in r340232
Author: rnk
Date: Wed Aug 22 10:47:41 2018
New Revision: 340427
URL: http://llvm.org/viewvc/llvm-project?rev=340427&view=rev
Log:
Disable the aligned allocation test on old mac versions instead of XFAILing it
It looks like this test XPASSes when the deployment target is older than
the OS of the s
Author: rnk
Date: Fri Aug 17 15:11:31 2018
New Revision: 340101
URL: http://llvm.org/viewvc/llvm-project?rev=340101&view=rev
Log:
Don't warn on returning the address of a label from a statement expression
Summary:
There isn't anything inherently wrong with returning a label from a
statement expre
Author: rnk
Date: Fri Aug 17 13:59:52 2018
New Revision: 340080
URL: http://llvm.org/viewvc/llvm-project?rev=340080&view=rev
Log:
Update comments in CGDebugInfo to reflect changes in the MS mangler, NFC
I've tried to elaborate on the purpose of these type identifiers and why
and when clang uses t
Author: rnk
Date: Fri Aug 17 13:59:27 2018
New Revision: 340079
URL: http://llvm.org/viewvc/llvm-project?rev=340079&view=rev
Log:
[MS] Mangle a hash of the main file path into anonymous namespaces
Summary:
This is needed to avoid conflicts in mangled names for codeview types in
anonymous namespac
After this, check-clang no longer worked, it emitted a fatal error because
USE_Z3_SOLVER was not in lit_config.params. I worked around it in r339728,
but you might want to double check it.
On Mon, Aug 13, 2018 at 4:13 PM George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Auth
Author: rnk
Date: Tue Aug 14 14:15:57 2018
New Revision: 339728
URL: http://llvm.org/viewvc/llvm-project?rev=339728&view=rev
Log:
Fix lit fatal errors about requiring a USE_Z3_SOLVER param
Modified:
cfe/trunk/test/lit.site.cfg.py.in
Modified: cfe/trunk/test/lit.site.cfg.py.in
URL:
http://ll
Author: rnk
Date: Mon Aug 13 18:55:37 2018
New Revision: 339638
URL: http://llvm.org/viewvc/llvm-project?rev=339638&view=rev
Log:
Revert r339623 "Model type attributes as regular Attrs."
This breaks compiling atlwin.h in Chromium. I'm sure the code is invalid
in some way, but we put a lot of work
Author: rnk
Date: Wed Aug 1 15:10:03 2018
New Revision: 338643
URL: http://llvm.org/viewvc/llvm-project?rev=338643&view=rev
Log:
Fix -Wcovered-switch-default uncovered after r338630
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
Modified: cfe/trunk/lib/AST/DeclBase.cpp
URL:
http://llvm.org/viewv
Author: rnk
Date: Tue Jul 31 14:57:35 2018
New Revision: 338444
URL: http://llvm.org/viewvc/llvm-project?rev=338444&view=rev
Log:
Revert r337635 "[Driver] Sanitizer support based on runtime library presence"
This change causes issues with distributed build systems, which may only
have compiler bi
On Wed, Jul 25, 2018 at 4:39 AM Nico Weber wrote:
> I thought about adding -fblocks when that thread happened, but since
> there's no runtime for them that just works exposing it doesn't seem very
> helpful. Maybe we should instead change the warning text to not suggest
> -fblocks when building o
I reverted this in r338084 because it broke clang tests on Windows:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12916
On Thu, Jul 26, 2018 at 11:55 AM Simon Marchi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: simark
> Date: Thu Jul 26 11:55:02 2018
> New
Author: rnk
Date: Thu Jul 26 16:21:51 2018
New Revision: 338084
URL: http://llvm.org/viewvc/llvm-project?rev=338084&view=rev
Log:
Revert r338057 "[VirtualFileSystem] InMemoryFileSystem::status: Return a Status
with the requested name"
This broke clang/test/PCH/case-insensitive-include.c on Windo
Author: rnk
Date: Thu Jul 26 16:18:44 2018
New Revision: 338083
URL: http://llvm.org/viewvc/llvm-project?rev=338083&view=rev
Log:
[MS] Add L__FUNCSIG__ for compatibility
Clang already has L__FUNCTION__ as a workaround for dealing with
pre-processor code that expects to be able to do L##__FUNCTION
Author: rnk
Date: Mon Jul 23 14:29:43 2018
New Revision: 337746
URL: http://llvm.org/viewvc/llvm-project?rev=337746&view=rev
Log:
[clang-cl] Expose -fblocks and -fno-builtin as driver flags
Users have requested them.
Helps with PR36427.
Modified:
cfe/trunk/include/clang/Driver/Options.td
Author: rnk
Date: Mon Jul 23 10:44:00 2018
New Revision: 337715
URL: http://llvm.org/viewvc/llvm-project?rev=337715&view=rev
Log:
[MS] Update _MSVC_LANG values for C++17 and C++2a
Fixes PR38262
Added:
cfe/trunk/test/Preprocessor/predefined-win-macros.c
Modified:
cfe/trunk/lib/Basic/Targe
Author: rnk
Date: Fri Jul 20 15:36:33 2018
New Revision: 337629
URL: http://llvm.org/viewvc/llvm-project?rev=337629&view=rev
Log:
Disable clang crash-report-modules.m test on Windows again
It still appears to be failing:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12825
$
Author: rnk
Date: Fri Jul 20 13:55:00 2018
New Revision: 337616
URL: http://llvm.org/viewvc/llvm-project?rev=337616&view=rev
Log:
[codeview] Don't emit variable templates as class members
MSVC doesn't, so neither should we.
Fixes PR38004, which is a crash that happens when we try to emit debug
i
Author: rnk
Date: Sat Jun 23 10:32:51 2018
New Revision: 335419
URL: http://llvm.org/viewvc/llvm-project?rev=335419&view=rev
Log:
Attempt to fix latent tablegen dependency issue
Modified:
cfe/trunk/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
Modified: cfe/trunk/tools/clang-fuzzer/handle-ll
Author: rnk
Date: Wed Jun 20 14:12:20 2018
New Revision: 335175
URL: http://llvm.org/viewvc/llvm-project?rev=335175&view=rev
Log:
[MS] Make sure __GetExceptionInfo works on types with no linkage
Fixes PR36327
Modified:
cfe/trunk/lib/Sema/Sema.cpp
cfe/trunk/test/CodeGenCXX/microsoft-abi-t
And, as soon as I sent that, I realized what was up. Apparently
auto-complete is driven by the parser, and delayed template parsing means
we don't parse templates. That seems like a serious issue that should get
fixed eventually.
Anyway, I landed a crummy workaround in r334973 to green the bots.
Author: rnk
Date: Mon Jun 18 11:55:10 2018
New Revision: 334973
URL: http://llvm.org/viewvc/llvm-project?rev=334973&view=rev
Log:
Fix clangd test to pass when delayed template parsing is on by default
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-to
This test has been failing on Windows since it has been added:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12549
I took a look at the unittest code, but I'm not familiar enough with this
code to debug it. Can you take a look at this?
On Fri, Jun 15, 2018 at 1:35 AM Ilya Bi
The length of that path is about 257, or very near MAX_PATH, which suggests
that the version of rm you are using does not tolerate deep paths. This has
been a long standing problem, and our solution to it was to install a
special version of rm.exe on all of our buildbots that reliably handles
long
On Tue, Jun 12, 2018 at 4:43 AM Hans Wennborg wrote:
> Actually, maybe switching the order from "not env ... %clang" to "env
> ... not %clang" might work...
>
Thanks, I was going to try that next.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rnk
Date: Mon Jun 11 09:50:07 2018
New Revision: 334418
URL: http://llvm.org/viewvc/llvm-project?rev=334418&view=rev
Log:
Enable crash recovery tests on Windows, globs work in the lit internal shell now
Modified:
cfe/trunk/test/Driver/crash-report-header.h
cfe/trunk/test/Driver/cr
Author: rnk
Date: Mon Jun 11 09:49:43 2018
New Revision: 334417
URL: http://llvm.org/viewvc/llvm-project?rev=334417&view=rev
Log:
[MS] Use mangled names and comdats for string merging with ASan
This should reduce the binary size penalty of ASan on Windows. After
r334313, ASan will add red zones t
set_acq'
> use of undeclared identifier '_interlockedbittestandset_rel'
> use of undeclared identifier '_interlockedbittestandset_nf'
>
> I see that you have removed them in your patch. Apparently they are needed
> (at least for ARM64 Win).
>
> --Mandeep
>
&
Author: rnk
Date: Thu Jun 7 14:39:04 2018
New Revision: 334239
URL: http://llvm.org/viewvc/llvm-project?rev=334239&view=rev
Log:
[MS] Re-add support for the ARM interlocked bittest intrinscs
Adds support for these intrinsics, which are ARM and ARM64 only:
_interlockedbittestandreset_acq
_int
Author: rnk
Date: Wed Jun 6 11:39:47 2018
New Revision: 334112
URL: http://llvm.org/viewvc/llvm-project?rev=334112&view=rev
Log:
[MS][ARM64]: Promote _setjmp to_setjmpex as there is no _setjmp in the ARM64
libvcruntime.lib
Factor out the common setjmp call emission code.
Based on a patch by Ch
Author: rnk
Date: Tue Jun 5 18:44:10 2018
New Revision: 334060
URL: http://llvm.org/viewvc/llvm-project?rev=334060&view=rev
Log:
Fix std::tuple errors
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: rnk
Date: Tue Jun 5 18:35:08 2018
New Revision: 334059
URL: http://llvm.org/viewvc/llvm-project?rev=334059&view=rev
Log:
Implement bittest intrinsics generically for non-x86 platforms
I tested these locally on an x86 machine by disabling the inline asm
codepath and confirming that it doe
On Tue, Jun 5, 2018 at 2:33 AM Martin Storsjö wrote:
> > // Many of MSVC builtins are on both x64 and ARM; to avoid repeating
> code, we
> > // handle them here.
>
> This doesn't seem thought through wrt non-x86 architectures. I'm not sure
> if there's any similar suitable instruction to use on A
Author: rnk
Date: Mon Jun 4 18:33:40 2018
New Revision: 333978
URL: http://llvm.org/viewvc/llvm-project?rev=333978&view=rev
Log:
Reimplement the bittest intrinsic family as builtins with inline asm
We need to implement _interlockedbittestandset as a builtin for
windows.h, so we might as well do
Author: rnk
Date: Mon Jun 4 14:39:20 2018
New Revision: 333958
URL: http://llvm.org/viewvc/llvm-project?rev=333958&view=rev
Log:
Revert r333791 "Cap "voluntary" vector alignment at 16 for all Darwin
platforms."
Adding __attribute__((aligned(32))) to __m256 breaks the implementation
of _mm256_lo
401 - 500 of 1340 matches
Mail list logo
