Thanks!
Jini.
On 2/11/2019 7:25 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC
in the SA.
http://cr.openjdk.java.net/~stefank/8218746/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218746
ZGC uses a 16TB virtual memory address
://cr.openjdk.java.net/~stefank/8218978/webrev.01/
I'm currently rerunning the tests to see that the latest changes didn't
break anything.
Thanks,
StefanK
Thanks,
Yasumasa
On 2019/02/13 23:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live heap
If this patch is accepted we also need this patch to turn on the SA
hprof implementation:
http://cr.openjdk.java.net/~stefank/8218970/webrev.01/
StefanK
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region
this further at some point in the future
to deal with broken Klass pointers better.
Thanks,
/Erik
On 2019-02-13 15:52, Stefan Karlsson wrote:
Hi all,
Please review / comment on this patch to enable a best-effort live
heap region iteration implementation in ZGC.
http://cr.openjdk.java.net
do that or not.
Otherwise looks good. Don't need another webrev.
I'll fix. Thanks for reviewing.
StefanK
Thanks,
/Erik
On 2019-02-11 14:55, Stefan Karlsson wrote:
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC in
the SA.
http://cr.openjdk.java.net/~stefank/8218
Thanks, Erik.
Stefank
On 2019-02-14 10:11, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 13:36, Stefan Karlsson wrote:
Hi all,
Please review this patch to add support for large bitmaps in the SA.
http://cr.openjdk.java.net/~stefank/8218743/webrev.01/
https
Thanks, Erik.
Stefank
On 2019-02-14 09:38, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2019-02-11 09:13, Stefan Karlsson wrote:
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs
.
StefanK
Thanks,
/Erik
On 2019-02-11 09:39, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https://cr.openjdk.java.net/~stefank/8218734/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218734
Before this patch
Thanks, Erik.
Stefank
On 2019-02-14 09:26, Erik Österlund wrote:
Hi Stefan,
Given that the remark from Jini is fixed, this looks good. I don't need
another webrev.
Thanks,
/Erik
On 2019-02-11 19:09, Stefan Karlsson wrote:
Hi Jini,
On 2019-02-11 19:00, Jini George wrote:
Hi Stefan
Thanks, Erik.
Stefank
On 2019-02-14 09:19, Erik Österlund wrote:
Hi Stefan,
This looks good and trivial.
Thanks,
/Erik
On 2019-02-11 08:47, Stefan Karlsson wrote:
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https
On 2019-02-13 17:12, coleen.phillim...@oracle.com wrote:
On 2/13/19 10:40 AM, Stefan Karlsson wrote:
On 2019-02-13 14:40, coleen.phillim...@oracle.com wrote:
On 2/11/19 3:39 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to fix the resolving of oops inside the
(VM
Hi all,
Please review / comment on this patch to enable a best-effort live heap
region iteration implementation in ZGC.
http://cr.openjdk.java.net/~stefank/8218922/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218922
The SA has functionally that relies on live heap region information
Hi Jini,
On 2019-02-13 05:53, Jini George wrote:
Hi Stefan,
Looks good to me. Nits: pls do change the copyright year.
Thanks for reviewing. I'll update the copyright years.
Thanks,
StefanK
Thanks,
Jini.
On 2/11/2019 6:06 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch
/2019 1:23 PM, Stefan Karlsson wrote:
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical
as a value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameters vie
Hi all,
Please review this patch to implement a discontiuous bitmap for ZGC in
the SA.
http://cr.openjdk.java.net/~stefank/8218746/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218746
ZGC uses a 16TB virtual memory address range, so the normal scheme to
map a bitmap over the entire
Hi all,
Please review this patch to add support for large bitmaps in the SA.
http://cr.openjdk.java.net/~stefank/8218743/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218743
I've added a minimal interface (at, atPut, clear) that uses longs
instead of ints, and changed MarkBits to use
Thanks, Jini.
StefanK
On 2019-02-11 13:00, Jini George wrote:
Hi Stefan,
Looks good to me.
Thanks,
Jini.
On 2/11/2019 1:43 PM, Stefan Karlsson wrote:
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs
On 2019-02-11 10:39, Aleksey Shipilev wrote:
On 2/11/19 9:13 AM, Stefan Karlsson wrote:
Please review this patch to remove the broken implementation of CollectedHeap
used() and capacity()
and instead force all GCs to provide their own implementations.
https://cr.openjdk.java.net/~stefank
Hi all,
Please review this patch to fix the resolving of oops inside the (VM)
OopHandles.
https://cr.openjdk.java.net/~stefank/8218734/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218734
Before this patch the OopHandle::_obj was assumed to be located at
offset 0, and the SA resolved
Hi all,
Please review this patch to remove the broken implementation of
CollectedHeap used() and capacity() and instead force all GCs to provide
their own implementations.
https://cr.openjdk.java.net/~stefank/8218733/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218733
This was found
Hi all,
Please review this small patch to resolve ZPageAllocator::_physical as a
value object instead of a pointer.
https://cr.openjdk.java.net/~stefank/8218732/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8218732
This fixes the Heap Parameters view.
Thanks,
StefanK
Hi all,
I propose this simple change to use the concrete class as the return
type of VMObjectFactory.newObject.
https://cr.openjdk.java.net/~stefank/8218731/webrev.01
https://bugs.openjdk.java.net/browse/JDK-8218731
This allows us to specify the class only once when calling newObject.
For
space as well.
Stefan Karlsson
Looks good to me. Thanks for fixing this.
StefanK
On 2018-06-12 14:46, Srinivas Dama wrote:
Hi,
My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has broken
the build on linux.
So I am reverting my fix for now.
Bug : https://bugs.openjdk.java.net/browse/JDK-8204861
webrev:
On 2018-05-31 20:09, mandy chung wrote:
On 5/31/18 10:36 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:19, mandy chung wrote:
Hi Stefan,
This change looks okay. Can you add a comment to describe the
expected memory pools for ZGC so that it explains why the min number
of heap
MemoryTestZGC.sh test, that calls MemoryTest 1
1 and explains that ZGC has one memory manager and one heap memory pool?
Thanks,
StefanK
Mandy
On 5/31/18 6:53 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http
On 2018-05-31 19:04, mandy chung wrote:
On 5/31/18 10:01 AM, Stefan Karlsson wrote:
Hi Mandy,
On 2018-05-31 18:44, mandy chung wrote:
Hi Stefan,
I think a better fix is to find another operation that will throw an
exception. ThreadMXBean::getThreadInfo throws IAE and it can
with the other GCs.
Does this sound reasonable?
Thanks,
StefanK
Mandy
On 5/31/18 6:38 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http://cr.openjdk.java.net/~stefank/8204170/webrev.01/
https
Thanks, Erik.
StefanK
On 2018-05-31 16:27, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:38, Stefan Karlsson wrote:
Hi all,
Please review this patch to deal with the case when all available
MemoryPoolMXBeans support usage thresholds.
http
Thanks, Erik.
StefanK
On 2018-05-31 16:26, Erik Österlund wrote:
Hi Stefan,
Looks good.
Thanks,
/Erik
On 2018-05-31 15:53, Stefan Karlsson wrote:
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank
Hi all,
Please review this patch to lower the minimum number of heap memory
pools in MemoryTest.java.
http://cr.openjdk.java.net/~stefank/8204173/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8204173
Just like the comment in the test says:
* NOTE: This expected result is hardcoded in
ake sure to test with hs-tier2-graal.
Thanks for reviewing!
StefanK
Thanks,
Vladimir
On 5/2/18 7:37 AM, Stefan Karlsson wrote:
Hi all,
Please review these patches to allow for conditional compilation of
the GCs in HotSpot.
Full patch:
http://cr.openjdk.java.net/~stefank/8200729/webrev.04/al
On 2018-05-03 15:19, Erik Helin wrote:
On 05/02/2018 04:37 PM, Stefan Karlsson wrote:
> Hi all,
Hi Stefan,
thanks for taking on this work, much appreciated!
On 05/02/2018 04:37 PM, Stefan Karlsson wrote:
> The first patch simply cleans up some INCLUDE_ALL_GCS usages in
platform-sp
On 2018-05-03 11:06, Magnus Ihse Bursie wrote:
On 2018-05-02 16:37, Stefan Karlsson wrote:
Hi all,
Please review these patches to allow for conditional compilation of
the GCs in HotSpot.
Full patch:
http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/
It's nice to see this cleanup
Looks good to me. Thanks for fixing.
StefanK
On 2018-05-03 00:13, Vladimir Kozlov wrote:
http://cr.openjdk.java.net/~kvn/8202552/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8202552
Stefan K. found several places where #ifdef instead of #if is used for
INCLUDE_JVMCI.
I also found
Hi all,
Please review these patches to allow for conditional compilation of the
GCs in HotSpot.
Full patch:
http://cr.openjdk.java.net/~stefank/8200729/webrev.04/all/
(See below for a more fine-grained division into smaller patches)
Today Parallel, G1, and CMS, are all guarded by
Hi Magnus,
Thanks a lot for implementing this! I tested this with
--with-log=info,report=none, and it's exactly what I want in my config
script ;)
Thanks,
StefanK
On 2018-04-10 22:54, Magnus Ihse Bursie wrote:
From the bug report:
"The compile errors you get from HotSpot are quite large,
Looks good.
StefanK
On 2018-03-20 20:39, Chris Plummer wrote:
Hi,
New webrev:
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html
There was a build failure on solaris-sparc in threadSMR.cpp. References
to the Copy class were producing "unresolved symbol" errors.
Looks good to me.
StefanK
On 2018-03-20 01:48, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8195109
http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html
The assert I added to make sure this is safe has been in place in
Looks good.
StefanK
On 2018-02-23 02:16, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8198585
http://cr.openjdk.java.net/~cjplummer/8198585/webrev.00/webrev/
Before removing ServiceUtil::visible_oop(), I want to make sure it
really isn't
y receive
> the node for just one of
> them. SVN seems to pick a random revision to include, it is not always the
> "first" revision in any logical order.
>
> Regards,
> Gabor
>
> On Sunday, March 6, 2016 at 6:51:18 PM UTC+1, Stefan Karlsson wrote:
>
>
>
Hi David,
On 10/05/16 12:17, David Holmes wrote:
Hi Stefan,
Thanks for looking at this again.
On 10/05/2016 6:24 PM, Stefan Karlsson wrote:
Hi David,
On 10/05/16 02:33, David Holmes wrote:
Okay here is version 2:
http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/
Lots of cosmetic
Hi David,
On 10/05/16 02:33, David Holmes wrote:
Okay here is version 2:
http://cr.openjdk.java.net/~dholmes/8154715/webrev.v2/
Lots of cosmetic changes but only a couple of functional ones:
- After thread->run() returns we clear the TLS by calling
clear_thread_current(), but only for
Hi David,
On 06/05/16 15:38, David Holmes wrote:
Hi Stefan,
Thanks for taking a look at this.
On 6/05/2016 5:02 PM, Stefan Karlsson wrote:
Hi David,
I looked through the GC part of this webrev and I think the change is
fine.
However, it seems a bit error prone. If we decide to change
Hi David,
I looked through the GC part of this webrev and I think the change is fine.
However, it seems a bit error prone. If we decide to change the code to,
for example, terminate the AbstractGangWorker threads, then we have to
remember to insert a ThreadLocalStorage::set_thread(NULL)
Hi Robbin,
This looks good to me. This breaks gc nightly and is a fairly trivial
change, so I'll push this right away.
Thanks,
StefanK
On 2016-04-20 09:40, Robbin Ehn wrote:
Hi all,
Please review.
We are missing a cr on a log stream, which leads to this guarantee.
Bug:
On 2016-04-19 12:45, Alan Bateman wrote:
On 19/04/2016 10:58, Stefan Karlsson wrote:
I've left the locale specific launcher files untouched. Should I
update them as well?
Dropping -Xincgc rom the -X output looks okay to me. We usually don't
touch the translations as they are updated
Hi all,
I hope this is the right list for this RFR.
Please review this patch to remove the -Xincgc output from the java
launcher.
http://cr.openjdk.java.net/~stefank/8072921/webrev.01
https://bugs.openjdk.java.net/browse/JDK-8072921
The output can be seen by running 'java -X':
$
Hi Ramki and Jon,
What's the status of this review thread? The bug is still open and
targeted for JDK 9.
Thanks,
StefanK
On 2015-06-03 08:15, Srinivas Ramakrishna wrote:
Thanks Jon for the review and the pointer to the test. I'll get back
to you later this week with a suitable test.
--
Looks good.
StefanK
On 2016-04-13 07:50, Robbin Ehn wrote:
Hi all,
Please review this bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154064
Test with tonga. (the 5 crashed tonga test no longer crashes)
Thanks!
/Robbin
diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp
---
Looks good.
StefanK
On 2016-04-08 10:08, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153731/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153731
Tested with internal vm test (inc a new test for just this).
Thanks!
/Robbin
Looks good.
StefanK
On 2016-04-04 17:09, Robbin Ehn wrote:
Hi all,
Please review,
Webrev: http://cr.openjdk.java.net/~rehn/8153396/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153396
Tested with internal vm test.
Thanks!
/Robbin
Hi Marcus,
On 23/03/16 11:59, Marcus Larsson wrote:
Hi Stefan,
On 03/23/2016 11:00 AM, Stefan Karlsson wrote:
Hi Marcus,
On 2016-03-23 10:23, Marcus Larsson wrote:
Hi,
Please review the following patch to fix the issue where duplicate
tagsets are created for the same logical tagset
Hi Robbin,
On 2016-03-23 14:50, Robbin Ehn wrote:
Hi all,
After more input, this is the current version.
Please have a look.
Webrev: http://cr.openjdk.java.net/~rehn/8151993/v4/webrev/
Incremental: http://cr.openjdk.java.net/~rehn/8151993/v3-v4/
Looks good to me.
It's non-obvious why you
Hi all,
Please, review this patch to optimize the log_is_enabled check in the
Unified Logging framework.
http://cr.openjdk.java.net/~stefank/8152538/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8152538
The following code:
void logLine() {
log_debug(gc)("logLine");
}
expands
I will try to describe the "scenery", but I have also attached a Windows
batch file that creates a repository ("repos") and a work folder ("work"),
as well as the log file ("log.txt") described below. I have also attached
my copy of "log.txt".
This is in short was the batch file does:
A branch
Hi,
Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS.
http://cr.openjdk.java.net/~stefank/8078601/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8078601
This code in thread.cpp is guarded by INCLUDE_ALL_GCS:
#if INCLUDE_ALL_GCS
// Dump concurrent locks
library is
ported from) though. Am i blind? :-)
Maybe. Or reload:
http://xmpp.org/xmpp-software/libraries/
12th row down from the top.
Peter
/ Stefan
On 2015-01-30 17:11, Peter Saint-Andre - yet wrote:
On 1/29/15 5:38 PM, Stefan Karlsson wrote:
Awesome, please do :-)
Actually it's
Heya. Just released a very minimalistic client in c#.
Its well designed webpage is located at http://deusexmachinae.se/dxmppnet
It's based on the C++ project dxmpp but I havent ported the proper SASL
mechanisms yet, so only plain works, ie wouldnt recommend it for
production without enforced
Awesome, please do :-)
/stefan
Peter Saint-Andre - yet skrev den 29/01/15 23:30:
On 1/29/15 10:33 AM, Stefan Karlsson wrote:
Heya. Just released a very minimalistic client in c#.
Its well designed webpage is located at
http://deusexmachinae.se/dxmppnet
Would you like that added
On 2015-01-08 20:15, Chris Plummer wrote:
Hi Stefan,
Comments inline below:
On 1/8/15 2:50 AM, Stefan Karlsson wrote:
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first
Hi Chris,
On 2015-01-08 00:29, Chris Plummer wrote:
Hi,
Please review the following changes for the addition of the
VM.class_hierarchy DCMD. Please read the bug first for some background
information.
Webrev: http://cr.openjdk.java.net/~cjplummer/8054888/webrev.00/
Bug:
On 2014-11-19 15:28, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following changeset to clean up the
usage of the INCLUDE_TRACE define:
Bug: https://bugs.openjdk.java.net/browse/JDK-8065361
Webrev: http://cr.openjdk.java.net/~mgronlun/8065361/webrev01/
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
StefanK
On 2014-09-05 14:01, Stefan Karlsson wrote:
Hi all,
Here's an updated version of the test:
http://cr.openjdk.java.net/~stefank/8057174/webrev.01.delta/
http://cr.openjdk.java.net/~stefank/8057174/webrev.01/
1
://cr.openjdk.java.net/~stefank/8057174/webrev.02
and have restarted the test runs.
thanks,
StefanK
Other than that the change looks fine.
-JB-
On 09/09/2014 01:45 PM, Stefan Karlsson wrote:
(Adding GC)
Hi,
Could I get a couple of reviews for this test fix?
StefanK
On 2014-09-05 14:01, Stefan
On 2014-09-09 14:49, Daniel Fuchs wrote:
Hi,
Looks good to me - although I'm not a specialist of -XX options ;-)
:)
Thanks, Daniel.
StefanK
-- daniel
On 9/9/14 2:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav
On 2014-09-09 16:19, Jaroslav Bachorik wrote:
Thumbs up!
Thanks.
StefanK
-JB-
On 09/09/2014 02:29 PM, Stefan Karlsson wrote:
Hi Jaroslav,
Thanks a lot for looking at the test change.
On 2014-09-09 14:04, Jaroslav Bachorik wrote:
Hi Stefan,
* test/java/lang/management/MemoryMXBean
Hi Daniel,
On 2014-09-04 16:58, Daniel Fuchs wrote:
Looks good Stefan!
Thanks a lot for reviewing.
I realized that I need to do some extra hardening so I'll have to send
out an updated version of the test.
thanks,
StefanK
best regards,
-- daniel
On 9/4/14 4:34 PM, Stefan Karlsson
Hi all,
Please review this patch to make these tests a bit more stable. I've
changed the code to always allocate objects that are larger than the
young gen size.
http://cr.openjdk.java.net/~stefank/8057174/webrev.00/
I've tested this by running the tests through jprt.
thanks,
StefanK
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed.
http://cr.openjdk.java.net/~stefank/8056143/webrev.00/
thanks,
StefanK
Thanks.
StefanK
On 27/08/14 10:48, Chris Hegarty wrote:
Reviewed.
-Chris.
On 27/08/14 09:48, Stefan Karlsson wrote:
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed
I revoke this RFR. Bengt pointed out that I shouldn't use 8056143 to
updated the problem list. I've created a new bug JDK-8056148 and will
send out a new RFR.
thanks,
StefanK
On 27/08/14 10:48, Stefan Karlsson wrote:
Hi all,
Please review this patch to put the LowMemoryTest.java test
Hi all,
Please review this patch to put the LowMemoryTest.java test in the
ProblemLists.txt. It currently hangs and leaves processes running after
the test run has completed.
http://cr.openjdk.java.net/~stefank/8056148/webrev.00/
thanks,
StefanK
On 2014-08-19 12:51, Staffan Larsen wrote:
Looks good!
Thanks!
StefanK
Thanks,
/Staffan
On 19 aug 2014, at 12:25, Stefan Karlsson stefan.karls...@oracle.com wrote:
Hi all,
Please review this patch harden two MemoryMXBean tests. These tests cause
intermittent test failures when
Jon suggested that I should add -Xincgc.
Here's the updated webrev:
http://cr.openjdk.java.net/~stefank/8055111/webrev.01/
thanks,
StefanK
On 2014-08-14 14:04, Stefan Karlsson wrote:
Hi all,
Please, review this patch to add -Xconcgc to the set of flags to be
filtered out
Sweden would be nice! ;)
Or Norway/Oslo.
/Stefan
Joachim Lindborg skrev 24/07/14 08:13:
Sweden Stockholm would be perfect :) happy to host you all.
/Regards/
Joachim Lindborg
CTO, systems architect
Sustainable Innovation SUST.se
Barnhusgatan 3 111 23 Stockholm
Email:
Silly question:
Why not just have invisible as a presence mode, and remove the silly
enforced empty presence/ at initialization?
/stefan
Peter Saint-Andre skrev 16/07/14 17:11:
On 6/19/14, 9:30 PM, Lance Stout wrote:
1. Is this specification needed to fill gaps in the XMPP protocol
stack
I am also a bit too late but; how does this work with XEP 0184?
/stefan
Christian Schudt skrev 06/07/14 20:56:
I might be too late to the party, but I just began implementing it on client
side and I think 3.1.2 Client Handling lacks some point:
After becoming invisible the client should
Yes. Very nice! Iam hoping this means more developers time on keeping
smack* updated aswell :-)
/Stefan
Emil Ivov skrev 03/06/14 09:05:
Great news! Openfire is one of the great XMPP servers and I am happy
to know that it's now in such good hands!
Emil
On 02.06.14, 23:28, Dave Cridland
Hi Markus,
On 2014-04-24 17:42, Markus Grönlund wrote:
Greetings,
Kindly asking for reviews for the following very small fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8041723
Webrev: http://cr.openjdk.java.net/~mgronlun/8041723/webrev01/
Sorry for not replying to the correct post - I could swear I saw a list
of clients where tickets were created I couldn't find it.
I checked jabbernet and as far as i could trace the code the iqtracker
did not make use of from, only the id field.
I hacked the static NextID() function in
On 2014-01-09 16:29, Kirk Pepperdine wrote:
Hi Marcus,
Looks like some of the details have been chopped off. Is there a GC log
available? If there is a problem with MethodHandle a work around might be a
simple as expanding perm.. but wait, this is meta space now and it should grow
as long as
On 10/17/13 4:02 PM, Fredrik Arvidsson wrote:
Hi
I have added a new revision of my changes here:
http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.02/
http://cr.openjdk.java.net/%7Eallwin/farvidss/8024423/webrev.02/
I haven't looked at the patch i great detail, but I found this
On 2013-10-16 18:09, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector.
Instead of registering the oop as an unhandled oop, which would have
worked, I decided to wrap the oop in a handle
2013, at 20:02, Stefan Karlsson stefan.karls...@oracle.com
mailto:stefan.karls...@oracle.com wrote:
On 10/11/13 7:44 PM, Coleen Phillimore wrote:
Stefan,
I added a check about the count exceeding 1 000 000 because it
causes the test to create an invalid class file. With the shell
script
Changeset: f15a0087181e
Author:stefank
Date: 2013-10-14 14:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e
7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2
Reviewed-by: coleenp, sla
Contributed-by: stefan.karls...@oracle.com,
Changeset: f15a0087181e
Author:stefank
Date: 2013-10-14 14:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e
7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2
Reviewed-by: coleenp, sla
Contributed-by: stefan.karls...@oracle.com,
Changeset: f15a0087181e
Author:stefank
Date: 2013-10-14 14:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e
7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2
Reviewed-by: coleenp, sla
Contributed-by: stefan.karls...@oracle.com,
Please, review this test fix.
http://cr.openjdk.java.net/~stefank/7196801/webrev.00/
Most of the fix was implemented by Coleen, I've only done some small
tweaks and updated some comments.
The fix depends on these changes:
JDK-8025996 Track metaspace usage when metaspace is expanded
this thinking it has a corrupted constant
pool again.
OK. I though that was old debugging left-overs.
New webrev:
http://cr.openjdk.java.net/~stefank/7196801/webrev.01/
thanks,
StefanK
Thanks,
Coleen
On 10/11/2013 1:33 PM, Stefan Karlsson wrote:
Please, review this test fix.
http
On 10/11/13 8:04 PM, Coleen Phillimore wrote:
Looks good.
Thanks, Coleen.
StefanK
Thanks!
Coleen
On 10/11/2013 2:02 PM, Stefan Karlsson wrote:
On 10/11/13 7:44 PM, Coleen Phillimore wrote:
Stefan,
I added a check about the count exceeding 1 000 000 because it
causes the test
http://cr.openjdk.java.net/~stefank/8025996/webrev.00
Previously, the Metaspace memory usage was only tracked at the end of
the GCs. This causes the MemoryPoolMXBean.getUsageThreshold(…)
functionality to fail for the Metaspace memory pools. This patch adds
tracking of Metaspace usage when a
On 2013-09-30 16:48, Coleen Phillimore wrote:
Hi, Stefan has found the cause of the problem you have described this
thread, but we're discussing internally how to fix it. I'll let him
explain.
First, my experiments were done without --indy so I might be seeing a
different issue than you
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
!
Changeset: b606775fd1a3
Author:stefank
Date: 2013-08-29 11:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3
8014659: NPG: performance counters for compressed klass space
Reviewed-by: jmasa, sla
Contributed-by: erik.he...@oracle.com
!
On 09/19/2013 05:13 PM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The changes looks good.
There are some changes that I don't fully agree with, but I will not
block the push because of them. I'm just going to
On 09/20/2013 02:46 PM, Stefan Karlsson wrote:
On 09/19/2013 05:13 PM, Lois Foltan wrote:
Please review the following fix:
Webrev:
http://cr.openjdk.java.net/~hseigel/bug_jdk7195622.0/
The changes looks good.
I forgot this rather benign bug:
http://cr.openjdk.java.net/~hseigel
On 9/12/13 9:21 PM, serguei.spit...@oracle.com wrote:
On 9/11/13 8:54 PM, David Holmes wrote:
Hi Dmitry,
It seems odd that you install the new_method even if there was an
exception. What if the new_method is not valid because of the
exception ?
Coleen suggested this fragment.
New methods
Changeset: 4c84d351cca9
Author:stefank
Date: 2013-08-16 13:22 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4c84d351cca9
8007074: SIGSEGV at ParMarkBitMap::verify_clear()
Summary: Replace the broken large pages implementation on Linux. New flag:
On 6/20/13 4:14 PM, Erik Gahlin wrote:
Hi,
Could I have a review of these small metadata changes for event
tracing, most importantly the split of the ParallelScavangeHeapSummary
event name..
http://cr.openjdk.java.net/~mgronlun/8016331/webrev01/
Looks good.
StefanK
Thanks in advance
501 - 600 of 668 matches
Mail list logo
