Re: svn commit: r1892471 - in /subversion/trunk/subversion: libsvn_client/conflicts.c libsvn_wc/wc_db.c tests/cmdline/merge_tree_conflict_tests.py

2021-08-23 Thread Stefan Sperling
On Sat, Aug 21, 2021 at 09:38:56PM +0200, Daniel Sahlberg wrote: > > @@ -3028,12 +3028,12 @@ conflict_tree_get_details_local_missing( > >deleted_basename, > >conflict->pool); > >

CVS: cvs.openbsd.org: src

2021-08-23 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/23 02:59:31 Modified files: sys/dev/pci: if_iwx.c Log message: Fix the initial length check in iwx_fill_probe_req() to match iwm(4). Patch by zxystd from OpenIntelWireless.

Re: Crash in token.c after incomplete cherry pick merges in 1.15

2021-08-20 Thread Stefan Sperling
On Tue, Aug 10, 2021 at 02:46:50PM +0200, Stefan Sperling wrote: > On Mon, Aug 09, 2021 at 06:19:38PM -0400, Joshua Kordani wrote: > > Attached is a script to reproduce the error. > > > > I also have a packed rr debugger session that I can provide (I highly > >

CVS: cvs.openbsd.org: src

2021-08-19 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/19 18:22:54 Modified files: sys/dev/pci: if_iwm.c if_iwx.c Log message: Revert previous; Turns out the start_hw() functions don't always work right during the resume path. To be revisited later.

CVS: cvs.openbsd.org: src

2021-08-19 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/19 12:45:11 Modified files: sys/dev/pci: if_iwm.c if_iwx.c Log message: Run more device init code when resuming iwm(4) and iwx(4) devices. deraadt@ pointed out that the resume code path only

Re: Unexpected pf behavior for DHCP traffic?

2021-08-19 Thread Stefan Sperling
On Thu, Aug 19, 2021 at 06:42:25PM +0100, Étienne wrote: > On 31/07/2021 19:27, Stefan Sperling wrote: > > On Sat, Jul 31, 2021 at 07:02:35PM +0100, Étienne wrote: > > > On 30/07/2021 04:37, Theo de Raadt wrote: > > > > dhcpleased (and a few other daemons)

CVS: cvs.openbsd.org: src

2021-08-19 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/19 00:02:39 Modified files: sys/dev/ic : bwfm.c Log message: Fix an off-by-one in bwfm(4) SSID length checks. SSIDs are binary data, not NUL-terminated strings. ok patrick@

CVS: cvs.openbsd.org: src

2021-08-19 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/19 00:02:04 Modified files: sys/dev/pci: if_iwm.c if_iwn.c if_iwx.c Log message: Hide detailed firmware error reports from iwn/iwm/iwx by default. These drivers will now report "fatal firmware

iwn/iwm/iwx: hide firmware error dump by default again

2021-08-18 Thread Stefan Sperling
Detailed firmware error reports from Intel wifi drivers are quite noisy so it makes sense to hide them by default, especially on systems running -release. When Tx agg support was added to iwn and iwm it was important to see detailed firmware error reports. These were hidden behind the

CVS: cvs.openbsd.org: src

2021-08-13 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/13 07:13:11 Modified files: sys/dev/pci: if_iwx.c Log message: Plug memory leak in an unlikely error path of iwx_umac_scan_v14(). CID 1506261

Re: Crash in token.c after incomplete cherry pick merges in 1.15

2021-08-10 Thread Stefan Sperling
On Mon, Aug 09, 2021 at 06:19:38PM -0400, Joshua Kordani wrote: > Attached is a script to reproduce the error. > > I also have a packed rr debugger session that I can provide (I highly > recommend the rr reversible debugger).  Its ~30meg Thank you Joshua! The patch below makes your test script

Re: Segfault in libsvn_client/conflicts.c

2021-08-10 Thread Stefan Sperling
On Mon, Aug 09, 2021 at 07:56:27PM -0400, Joshua Kordani wrote: > On my work repo, this causes the crash.  In a small repo where I have > repeated these steps, it does not. Most likely in your test repository the history is arranged such that the deletions can be properly correllated by logging

Re: Segfault in libsvn_client/conflicts.c

2021-08-09 Thread Stefan Sperling
On Mon, Aug 09, 2021 at 02:09:40PM -0400, Joshua Kordani wrote: > The shell script is easy.  I run resolve on my codebase :-).  The trick will > be recreating the repo history that reproduces this problem, and that has > always been gnarly to me.  I could use some advice for this. > > Basically,

Re: Segfault in libsvn_client/conflicts.c

2021-08-08 Thread Stefan Sperling
On Sun, Aug 08, 2021 at 10:26:43AM +0200, Daniel Sahlberg wrote: > On 2021-08-07 17:14, Joshua Kordani wrote: > > Yes it does appear to fix the issue.  Thank you! > > Hi Joshua (and list), > > I've been trying to reproduce your issue both to have test case for > backporting the fix and possibly

Re: 1.14.x test failure under USE_HTTPV1=1: ra-test 13 commit_empty_last_change

2021-08-08 Thread Stefan Sperling
On Sun, Aug 01, 2021 at 10:53:18PM +0200, Daniel Sahlberg wrote: > Did anyone have the time to review this? > > I realise another way to do it would be to add an argument to > location_common. Maybe a bit clearer, possibly even reducing to a single > call to cat if the AuthzSVNAccessFile is put

Re: panic: config_detach: forced detach of iwm0 failed (45)

2021-08-08 Thread Stefan Sperling
On Sat, Aug 07, 2021 at 08:59:33PM -0700, Bryan Linton wrote: > On 2021-08-07 16:05:34, Bryan Linton wrote: > > >Synopsis: The system randomly panics with the message: panic: > > >config_detach: forced detach of iwm0 failed (45) > > >Category: system > > >Environment: > > System :

Re: Segfault in libsvn_client/conflicts.c

2021-08-07 Thread Stefan Sperling
On Sat, Aug 07, 2021 at 06:32:34AM -0400, Joshua Kordani wrote: > Thank you for explaining the convention, it makes sense now that you > describe it like that. > > It was delightfully short work to hunt down with the rr debugger ;-) > > I'm having trouble testing it right now but I suspect it

CVS: cvs.openbsd.org: src

2021-08-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/08/07 03:21:51 Modified files: sys/dev/pci: if_iwx.c if_iwxvar.h Log message: Remove another unused DMA allocation from iwx(4). This driver does not need to allocate a DMA segment for the Tx

Re: Segfault in libsvn_client/conflicts.c

2021-08-07 Thread Stefan Sperling
On Fri, Aug 06, 2021 at 07:41:42PM -0400, Joshua Kordani wrote: > I am merging two branches together, A into B.  In A, I deleted a file and > cherrypicked that onto B.  Later, I want to merge at the toplevel from A > into B, and I get a segfault when svn tries to figure out how to resolve the >

Re: Unexpected pf behavior for DHCP traffic?

2021-07-31 Thread Stefan Sperling
On Sat, Jul 31, 2021 at 07:02:35PM +0100, Étienne wrote: > On 30/07/2021 04:37, Theo de Raadt wrote: > > dhcpleased (and a few other daemons) use bpf, thus see raw packets > > from the wire before pf can block them. Most daemons of this type > > also use bpf to send packets, and pf doesn't see

CVS: cvs.openbsd.org: src

2021-07-30 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/30 08:09:12 Modified files: sys/dev/pci: if_iwx.c Log message: Print iwx(4) firmware version numbers like Linux iwlwifi does it. Starting with major version 35 the Linux driver prints the minor

Re: clean iwx unused firmware dma allocation

2021-07-30 Thread Stefan Sperling
On Fri, Apr 02, 2021 at 06:26:11PM +0800, zxystd wrote: > It is not a functionality change. The firmware dma is not actually used and > it is due to ported from iwm, this patch remove this allocation. Thanks! I have committed a slightly tweaked version, renaming the final goto label only. I'm

CVS: cvs.openbsd.org: src

2021-07-30 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/30 07:56:44 Modified files: sys/dev/pci: if_iwx.c if_iwxvar.h Log message: Remove an unused 320k bytes DMA memory allocation from iwx(4). This allocation was left over from code inherited from

Re: Unexpected pf behavior for DHCP traffic?

2021-07-30 Thread Stefan Sperling
On Fri, Jul 30, 2021 at 04:59:03AM +, beebeet...@posteo.de wrote: > Thanks Theo for the answer! > > I'm still having difficulty wrapping my head around it. > > I have two packets: DHCPREQUEST and DHCPACK > {timestamp} {my_ip}.68 > {ip1}.67: xid:0xfe51c9a3 [|bootp] > {timestamp} {ip2}.67 >

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 11:06:21 Modified files: share/man/man4 : iwx.4 Log message: Update the list of firmware files used by iwx(4).

Re: WIP iwx(4) Tx aggregation

2021-07-29 Thread Stefan Sperling
On Tue, Jul 13, 2021 at 08:20:23PM +0200, Hrvoje Popovski wrote: > On 30.6.2021. 13:28, Stefan Sperling wrote: > > On Mon, Jun 21, 2021 at 08:37:11PM +0200, Stefan Sperling wrote: > >> This patch attempts to implement Tx aggregation support for iwx(4). > >> > >>

net80211: initialize Tx agg sequence number

2021-07-29 Thread Stefan Sperling
The sequence numbers for QoS data frames sent with Tx aggregation are implicitly initialized to 0 when the system boots. From then on the counters will simply keep incrementing with a wrap after 0xfff. This isn't a problem with iwn(4) or iwm(4) because we always send the current value in 'add

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 06:13:58 Modified files: sys/dev/pci: if_iwx.c Log message: Switch iwx(4) to -63 firmware images as shipped in iwx-firmware-20210512. These images contain fixes which address fragattacks

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 06:01:45 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Implement support for the BAR_FRAME_RELEASE iwx(4) firmware notification. New firmware will generate this notification

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 06:01:04 Modified files: sys/dev/pci: if_iwx.c if_iwxvar.h Log message: Get Tx queues working with new iwx(4) firmware. ADD_STA command version >= 12 implies that firmware uses an internal

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 06:00:30 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Support the new iwx(4) firmware TLC_MNG_CONFIG command. This command was expanded by a 4 byte max_tx_op field. As far

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:58:35 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Support the new iwx(4) firmware session protection command. Required for having associations succeed with new

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:57:59 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Add support for iwx(4) umac scan command version 14. ok kevlo@

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:57:33 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Add support for iwx(4) "reduced" scan config command required by new firmware. ok kevlo@

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:56:53 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Handle iwx(4) PHY context command version 3. ok kevlo@

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:56:21 Modified files: sys/dev/pci: if_iwx.c Log message: New iwx(4) firmware doesn't require an AUX station to be added. ADD_STA command version >= 12 implies that firmware uses an

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:53:46 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Remove support for the narrow command header on the iwx(4) command queue. This is related to the previous commit which

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:52:58 Modified files: sys/dev/pci: if_iwx.c if_iwxvar.h Log message: Fix "BAD COMMAND" errors with new iwx(4) firmware. Firmware API versions >= 50 reject old-style commands in group 0

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:52:11 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Handle iwx(4) firmware alive response version 5. ok kevlo@

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:51:39 Modified files: sys/dev/pci: if_iwx.c if_iwxreg.h Log message: Recognize "phy integration" and "num stations" TLVs found in new iwx(4) firmware images. For now, we can simply ignore

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:50:58 Modified files: sys/dev/pci: if_iwx.c Log message: Ignore debug sections present in newer iwx(4) firmware images. ok kevlo@

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:50:37 Modified files: sys/dev/pci: if_iwx.c if_iwxvar.h Log message: Increase fixed limits for the number of iwx(4) command versions, channels, and microcode sections. Required for loading

CVS: cvs.openbsd.org: src

2021-07-29 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/29 05:49:53 Modified files: sys/dev/pci: if_iwxreg.h Log message: Declare additional iwx(4) firmware capability and api support flags. ok kevlo@

Re: iwx(4) firmware update to -63

2021-07-29 Thread Stefan Sperling
On Wed, Jul 28, 2021 at 02:13:41PM +0200, Stefan Sperling wrote: > On Mon, Jul 26, 2021 at 06:21:46PM +0200, Stefan Sperling wrote: > > This patch implements support for new iwx(4) -63 firmware images > > available in the iwx-firmware-20210512 package (via fw_update). >

Re: iwx(4) firmware update to -63

2021-07-28 Thread Stefan Sperling
On Mon, Jul 26, 2021 at 06:21:46PM +0200, Stefan Sperling wrote: > This patch implements support for new iwx(4) -63 firmware images > available in the iwx-firmware-20210512 package (via fw_update). > > Please test this patch and report back. If testing works out well > the

iwx(4) firmware update to -63

2021-07-26 Thread Stefan Sperling
This patch implements support for new iwx(4) -63 firmware images available in the iwx-firmware-20210512 package (via fw_update). Please test this patch and report back. If testing works out well then I will commit these changes to CVS incrementally. Thanks! For those testing my iwx Tx agg patch:

CVS: cvs.openbsd.org: src

2021-07-26 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/26 08:15:40 Modified files: sys/dev/pci: if_iwx.c Log message: Fix accounting of the number of frames queued on an iwx(4) Tx ring. Stop decrementing ring->queued inside the if-statement which

CVS: cvs.openbsd.org: ports

2021-07-26 Thread Stefan Sperling
CVSROOT:/cvs Module name:ports Changes by: s...@cvs.openbsd.org2021/07/26 03:50:09 Modified files: devel/got : Makefile distinfo Log message: Update to got 0.55 - display recovery steps in the lonely pack index error message - fix double-free that ocurred upon

CVS: cvs.openbsd.org: src

2021-07-22 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/22 12:01:29 Modified files: sbin/dhcpleased: dhcpleased.c Log message: Make dhcpleased(8) always configure provided routes, regardless of whether the address we received in our lease is already

CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/20 10:01:53 Modified files: share/man/man4 : iwm.4 Log message: Add the 7265-17 image back into the list of firmware used by iwm(4).

CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/20 10:00:47 Modified files: sys/dev/pci: if_iwm.c Log message: Do not attempt to load 7265D iwm(4) firmware on all 7265 devices. There are several variants of 7265 devices, all of which share a

CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/20 08:44:37 Modified files: sys/dev/pci: if_iwm.c Log message: Make iwm_init() call iwm_stop() if we fail to move into SCAN state. Generally, iwm_init() must either succeed or reset everything.

CVS: cvs.openbsd.org: src

2021-07-20 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/20 08:44:09 Modified files: sys/dev/pci: if_iwx.c Log message: Make iwx_init() call iwx_stop() if we fail to move into SCAN state. Generally, iwx_init() must either succeed or reset everything.

Re: iwx(4): Whitespace fix

2021-07-20 Thread Stefan Sperling
On Mon, Jul 19, 2021 at 09:20:17PM -0400, Ashton Fagg wrote: > Found this while poking around - an extra newline in if_iwx.c. > > Index: sys/dev/pci/if_iwx.c > === > RCS file: /cvs/src/sys/dev/pci/if_iwx.c,v > retrieving revision

CVS: cvs.openbsd.org: src

2021-07-19 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/19 13:00:58 Modified files: sys/net: if_pppoe.c Log message: Fix an alignment fault observed on an octeon machine while pppoe(4) was attempting to negotiate a large MTU. Copy the peer's max

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 07:07:13 Modified files: sys/dev/pci: if_iwx.c Log message: Do not ask iwx(4) firmware to send probe requests on passive channels. This seems to fix a problem where firmware becomes

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 06:39:16 Modified files: sys/dev/pci: if_iwx.c Log message: Clear the "persistence bit" on iwx(4) devices during hardware init. According to iwlwifi commit messages this fixes an edge case

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 06:21:49 Modified files: sys/dev/pci: if_iwx.c Log message: Set MIMO-related flags in the iwx(4) ADD_STA command. Not sure how we ended up missing these. MIMO apparently works without the

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 06:03:57 Modified files: sys/dev/pci: if_iwx.c Log message: Newer iwx(4) firmware doesn't like the DQA command anymore. Check whether firmware advertises DQA support before sending the DQA

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 05:56:11 Modified files: sys/dev/pci: if_iwx.c Log message: Fix wrong usage of iwx_lookup_cmd_ver() in iwx_send_soc_conf(). Callers are supposed to check whether iwx_lookup_cmd_ver() returns

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 05:40:31 Modified files: sys/dev/pci: if_iwx.c Log message: Fix iwx(4) PHY context updates for newer firmware versions. Firmware which advertises the BINDING_CDB_SUPPORT capability needs a

CVS: cvs.openbsd.org: src

2021-07-18 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/18 03:37:50 Modified files: share/man/man4 : iwm.4 Log message: Update the list of firmware files used by iwm(4).

Re: Why demotion counter for group carp is set to 33 on boot?

2021-07-14 Thread Stefan Sperling
On Wed, Jul 14, 2021 at 11:38:15AM +0200, Tom K wrote: > > > > but why? If I reboot the other node, the system become MASTER. > > > > That is because the other system stops sending carp announcements > > when you reboot it. This is unrelated to the demote counter. The demote > > counter only

Re: Why demotion counter for group carp is set to 33 on boot?

2021-07-14 Thread Stefan Sperling
On Wed, Jul 14, 2021 at 08:28:09AM +0200, Tom K wrote: > JP, > > but why? If I reboot the other node, the system become MASTER. That is because the other system stops sending carp announcements when you reboot it. This is unrelated to the demote counter. The demote counter only matters as long

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:41:20 Modified files: sys/dev/pci: if_iwm.c Log message: Switch iwm(4) to new firmware images available in iwm-firmware-20210512. This updates firmware for 3165, 3168, 7265, 8260, 8265,

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:36:15 Modified files: sys/dev/pci: if_iwm.c Log message: Print new iwm(4) firmware version numbers like Linux iwlwifi does it. Starting with major version 35 the Linux driver prints the

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:33:00 Modified files: sys/dev/pci: if_iwm.c Log message: remove unused lines of code from iwm(4) which were specific to iwx(4) devices

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:31:05 Modified files: sys/dev/pci: if_iwm.c Log message: Fix errors in the probe request template we provide to iwm(4) firmware. The SSID should not be inserted into the template itself.

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:29:08 Modified files: sys/dev/pci: if_iwm.c Log message: Do not ask iwm(4) firmware to send probe requests on passive channels. This seems to fix a problem where newer 9k firmware

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:24:55 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Make iwm(4) set various scan command flags just like how iwlwifi sets them. Discrepancies found while investigating an

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:21:31 Modified files: sys/dev/pci: if_iwm.c Log message: Fix iwm(4) PHY context updates for newer firmware versions. Firmware which advertises the BINDING_CDB_SUPPORT capability needs a

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:11:36 Modified files: sys/dev/pci: if_iwm.c Log message: Make iwm(4) use only antenna B for single-antenna Tx on 9k devices. This matches what Linux and FreeBSD do. According to Linux

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 05:04:06 Modified files: sys/dev/pci: if_iwm.c Log message: Clear the "persistence bit" on iwm(4) 9k devices during hardware init. According to iwlwifi commit messages this fixes an edge

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 04:46:56 Modified files: sys/dev/pci: if_iwm.c Log message: Ignore undocumented TLVs found in the iwm(4) 9000-43 firmware image.

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 04:45:17 Modified files: sys/dev/pci: if_iwm.c Log message: Reset sc_ucode_api flags before iwm(4) loads firmware. Fixes firmware re-loading after an initial attempt to load firmware failed.

CVS: cvs.openbsd.org: src

2021-07-09 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/09 04:42:35 Modified files: sys/dev/pci: if_iwm.c Log message: Simplify code supporting the new iwm(4) time quota firmware command. There was no real need to use a separate function for this.

CVS: cvs.openbsd.org: ports

2021-07-08 Thread Stefan Sperling
CVSROOT:/cvs Module name:ports Changes by: s...@cvs.openbsd.org2021/07/08 12:26:36 Modified files: devel/got : Makefile distinfo Log message: update got 0.54 - fix imsg header includes in pack_create.c - explicitly include endian.h for be32toh() in

CVS: cvs.openbsd.org: src

2021-07-08 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/08 11:14:08 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h if_iwmvar.h Log message: Support MCC update response used by newer iwm(4) firmware, and verify the size of the response we receive

Re:

2021-07-08 Thread Stefan Sperling
On Thu, Jul 08, 2021 at 04:00:15PM +0200, land...@asia.com wrote: > >Synopsis: > >Category: > >Environment: > System : OpenBSD 6.9 > Details : OpenBSD 6.9 (GENERIC) #4: Mon Jun 7 08:20:14 MDT 2021 > >

Re: [PATCH] limit diff effort to fix performance issue

2021-07-08 Thread Stefan Sperling
On Tue, Jun 08, 2021 at 05:58:14PM +0200, Johan Corveleyn wrote: > Also: one of the last things that Morten Kloster committed in 2011 was > another performance improvement, namely "restarting the LCS" in some > specific cases. At the time, I didn't have enough time to review this > properly, and

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 18:12:49 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h if_iwmvar.h Log message: Back out support for newer MCC update commands in iwm(4) for now. This seems to cause "could not init LAR"

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 03:47:40 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h if_iwmvar.h Log message: Support MCC update response used by newer iwm(4) firmware, and verify the size of the response we receive

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 03:13:50 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h if_iwmvar.h Log message: Support the SoC configuration command used by newer iwm(4) 9560 firmware.

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 03:06:23 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Support the critical temperature detection feature of newer iwm(4) firmware.

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 02:52:54 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h if_iwmvar.h Log message: Parse CMD_VERSION TLV found in iwm(4) fw images and add iwm_lookup_cmd_ver(). It seems Intel saw a risk of

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 02:32:00 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Support a new variant of the binding command required by new iwm(4) firmware.

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 02:21:32 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Support the larger phy context command required by newer iwm(4) firmware.

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 02:13:37 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Recognize and ignore new debug sections found in latest iwm(4) 9k fw images.

CVS: cvs.openbsd.org: src

2021-07-07 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/07 02:05:11 Modified files: sys/dev/pci: if_iwm.c if_iwmreg.h Log message: Support a new time quota command required for newer iwm(4) firmware.

CVS: cvs.openbsd.org: src

2021-07-06 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/06 09:53:33 Modified files: sys/dev/pci: if_iwx.c Log message: Fix iwx(4) against access points which use TKIP as the group cipher. This was broken when key installation was moved into a task

Re: iwx not getting to status: active

2021-07-06 Thread Stefan Sperling
On Mon, Jul 05, 2021 at 06:36:00PM -0700, Greg Steuck wrote: > Stefan Sperling writes: > > > On Tue, Jul 06, 2021 at 12:31:20AM +0200, Stefan Sperling wrote: > >> On Mon, Jul 05, 2021 at 02:11:36PM -0700, Greg Steuck wrote: > >> > Do I need to figure

Re: iwx not getting to status: active

2021-07-05 Thread Stefan Sperling
On Tue, Jul 06, 2021 at 12:31:20AM +0200, Stefan Sperling wrote: > On Mon, Jul 05, 2021 at 02:11:36PM -0700, Greg Steuck wrote: > > Do I need to figure out the state machines behind iwx and iee80211 now? :) > > This AP seems to use TKIP for the groupcipher and the iwx > setkey t

Re: iwx not getting to status: active

2021-07-05 Thread Stefan Sperling
On Mon, Jul 05, 2021 at 02:11:36PM -0700, Greg Steuck wrote: > Do I need to figure out the state machines behind iwx and iee80211 now? :) This AP seems to use TKIP for the groupcipher and the iwx setkey task doesn't handle this case properly. Can you try this? diff

Re: iwx not getting to status: active

2021-07-05 Thread Stefan Sperling
On Mon, Jul 05, 2021 at 10:20:09AM -0700, Greg Steuck wrote: > Stefan Sperling writes: > > > On Mon, Jul 05, 2021 at 09:35:20AM +0200, Stefan Sperling wrote: > >> On Sun, Jul 04, 2021 at 07:58:47PM -0700, Greg Steuck wrote: > >> > I never se

Re: iwx not getting to status: active

2021-07-05 Thread Stefan Sperling
On Mon, Jul 05, 2021 at 09:35:20AM +0200, Stefan Sperling wrote: > On Sun, Jul 04, 2021 at 07:58:47PM -0700, Greg Steuck wrote: > > I never see "iwx0: sending action to" after this. > > And you still see status: "no network" in ifconfig at this point? >

Re: iwx not getting to status: active

2021-07-05 Thread Stefan Sperling
On Sun, Jul 04, 2021 at 07:58:47PM -0700, Greg Steuck wrote: > I stumbled upon a weird hotel WiFi which never gets to a fully running > link with iwx0. I see ifconfig is stuck with: > > iwx0: flags=808847 > mtu 1500 > lladdr xx > index 1 priority 4 llprio 3 > groups: wlan

CVS: cvs.openbsd.org: src

2021-07-01 Thread Stefan Sperling
CVSROOT:/cvs Module name:src Changes by: s...@cvs.openbsd.org2021/07/01 05:51:55 Modified files: sys/dev/ic : ar5008.c Log message: Prevent athn(4) from calling ieee80211_find_rxnode() on bad frames. This fixes an issue introduced with our workaround for bogus

close net80211 hardware crypto set_key races

2021-07-01 Thread Stefan Sperling
Some wifi drivers defer installation of keys into a process context. There was a noticable race in the past which was fixed thanks to krw@ where link state was set to UP before key installation had completed in hardware. This race could result in dhclient failing to get a lease. Other races

Re: apu2 and Atheros WLE600VX not working

2021-06-30 Thread Stefan Sperling
On Wed, Jun 30, 2021 at 07:45:13AM -0400, George wrote: > Hi thanks for the reply! How is the performance on the 200nx are you using > it as an access point i.e. router? How many antennas? There is currently no way to run an AP on OpenBSD if you require performance levels comparable to

Re: iwm(4): use new firmware images with fragattack fixes

2021-06-30 Thread Stefan Sperling
On Tue, May 25, 2021 at 03:48:16PM +0200, Stefan Sperling wrote: > This patch allows iwm(4) to use new firmware images which are part > of the iwm-20210512 firmware package, available via fw_update (you > need to run fw_update *before* booting with this patch). Here is a rebase

<    5   6   7   8   9   10   11   12   13   14   >