Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

On 21/10/16 00:19, Manman wrote: On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev Log: [modules] Do not report m

r284877 - Remove accidentally checked in assert.

Author: vvassilev Date: Fri Oct 21 15:30:30 2016 New Revision: 284877 URL: http://llvm.org/viewvc/llvm-project?rev=284877=rev Log: Remove accidentally checked in assert. Thanks to Manman for spotting this. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added a subscriber: rsmith. v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; bkramer wrote:

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; Using emplace seems to break our modules libstdc++ 4.7

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

I totally misinterpreted this revert. I was confused it reverted r284284. Sorry for the noise. With the fix introduced in r284577 our bots should be happy. On 19/10/16 09:50, Vassil Vassilev wrote: On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r284577. https://reviews.llvm.org/D25678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577=rev Log: [modules] Do not report missing definitions of demoted constexpr variable templates. This is a followup to regression introduced in r284284. This should fix our

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev updated this revision to Diff 75050. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Remove assert. https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp test/Modules/Inputs/merge-var-template-def/a.h

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. Also, creduce (I've specialized it a bit for modules) helps reducing the modules complexity (https://github.com/vgvassilev/creduce/blob/master/USAGE.md#reducing-clang-c-modules-bugs). After reduction, the debugger is much more useful.

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. I am not sure whether that's useful for debugging out-of-date issues but this is what I use and it is helpful. Some debugging aids (suggested by Richard Smith): -fdiagnostics-show-note-include-stack will tell you which module a note comes from #pragma clang

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10129 +!Var->isThisDeclarationADemotedDefinition()) { + assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules + && "Demoting decls is only in the contest of

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 74955. v.g.vassilev marked an inline comment as done. https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp test/Modules/Inputs/merge-var-template-def/a.h

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bkramer. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

On 17/10/16 16:40, Benjamin Kramer wrote: Too slow ;) Do you have the fix somewhere, so I can try it? That would be https://reviews.llvm.org/D25678 Do you run into something else than what I have as a test case (merging templated constexpr variables)? On Mon, Oct 17, 2016 at 4:38 PM,

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

I was just to commit a fix :( On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote: Author: d0k Date: Mon Oct 17 08:00:44 2016 New Revision: 284382 URL: http://llvm.org/viewvc/llvm-project?rev=284382=rev Log: Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling

[PATCH] D25602: Do not reset TUScope when we are in incremental processing mode.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r284372. https://reviews.llvm.org/D25602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284372 - Do not reset TUScope when we are in incremental processing mode.

Author: vvassilev Date: Mon Oct 17 05:15:25 2016 New Revision: 284372 URL: http://llvm.org/viewvc/llvm-project?rev=284372=rev Log: Do not reset TUScope when we are in incremental processing mode. Patch by Axel Naumann! Reviewed by Richard Smith and me. Modified: cfe/trunk/lib/Sema/Sema.cpp

Re: r284284 - Reinstate r284008 reverted in r284081, with two fixes:

It seems that we are still missing a piece, because this broke the libstdc++ selfhost: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/5891 On 14/10/16 23:41, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Oct 14 16:41:24 2016 New Revision: 284284

Re: r284284 - Reinstate r284008 reverted in r284081, with two fixes:

Thanks! When calling makeMergedDefinitionVisible shouldn't we get the template instantiation pattern? On 14/10/16 23:41, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Oct 14 16:41:24 2016 New Revision: 284284 URL: http://llvm.org/viewvc/llvm-project?rev=284284=rev Log:

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev created this revision. v.g.vassilev added reviewers: chandlerc, rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25604 Files: lib/Driver/ToolChains.cpp Index:

[PATCH] D20785: Python 3.5 compatibility for clang-format.py

v.g.vassilev closed this revision. v.g.vassilev added a comment. Thanks I am closing it! Repository: rL LLVM https://reviews.llvm.org/D20785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20785: Python 3.5 compatibility for clang-format.py

v.g.vassilev added a comment. The print related changes were added in in r280240 (https://reviews.llvm.org/D23319). Could you rebase the patch? Repository: rL LLVM https://reviews.llvm.org/D20785 ___ cfe-commits mailing list

[PATCH] D7842: Make clang-format-diff compatible with Python 3.4

v.g.vassilev added a comment. This patch needs rebasing. https://reviews.llvm.org/D7842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D7842: Make clang-format-diff compatible with Python 3.4

v.g.vassilev added a subscriber: djasper. v.g.vassilev added a comment. I think @djasper could help with this review. https://reviews.llvm.org/D7842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r284008 - Reinstate r283887 and r283882.

caused random behavior. Cheers, Vassil And what was the issue that caused the revert? Thanks, Manman On Oct 12, 2016, at 4:57 AM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Wed Oct 12 06:57:08 2016 New Revision: 284008 URL: http://ll

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev closed this revision. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Relanded in r284008. https://reviews.llvm.org/D24508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284008 - Reinstate r283887 and r283882.

Author: vvassilev Date: Wed Oct 12 06:57:08 2016 New Revision: 284008 URL: http://llvm.org/viewvc/llvm-project?rev=284008=rev Log: Reinstate r283887 and r283882. Original message: "[modules] PR28752: Do not instantiate variable declarations which are not visible.

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 74353. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. We should not access the IsThisDeclarationADemotedDefinition bits if the decl is ParmVarDecl. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h

r283890 - Revert r283887 and r283882, until the issue is understood and fixed.

Author: vvassilev Date: Tue Oct 11 10:51:06 2016 New Revision: 283890 URL: http://llvm.org/viewvc/llvm-project?rev=283890=rev Log: Revert r283887 and r283882, until the issue is understood and fixed. Removed: cfe/trunk/test/Modules/Inputs/PR28752/ cfe/trunk/test/Modules/pr28752.cpp

r283887 - r283882 followup. Don't demote ParmVarDecls. This should fix our module builds.

Author: vvassilev Date: Tue Oct 11 10:09:26 2016 New Revision: 283887 URL: http://llvm.org/viewvc/llvm-project?rev=283887=rev Log: r283882 followup. Don't demote ParmVarDecls. This should fix our module builds. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified:

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Landed in r283882. Comment at: include/clang/AST/Decl.h:1222 + void demoteThisDefinitionToDeclaration() { +assert (!isThisDeclarationADemotedDefinition() && "Aleady demoted!"); +assert

r283882 - [modules] PR28752: Do not instantiate variable declarations which are not visible.

Author: vvassilev Date: Tue Oct 11 08:57:36 2016 New Revision: 283882 URL: http://llvm.org/viewvc/llvm-project?rev=283882=rev Log: [modules] PR28752: Do not instantiate variable declarations which are not visible. https://reviews.llvm.org/D24508 Patch developed in collaboration with Richard

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 74129. v.g.vassilev marked 3 inline comments as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev added inline comments. > rsmith wrote in SemaTemplate.cpp:509 > This function still appears to be able to return true (indicating to the > caller that a diagnostic was produced) without actually producing a > diagnostic. Is it better now? > rsmith wrote in SemaTemplate.cpp:505 >

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 73803. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Rebase, comments some more fixes. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp lib/Sema/SemaDecl.cpp

r283448 - Allocate after the early exit checks. NFC.

Author: vvassilev Date: Thu Oct 6 08:18:06 2016 New Revision: 283448 URL: http://llvm.org/viewvc/llvm-project?rev=283448=rev Log: Allocate after the early exit checks. NFC. Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp Modified: cfe/trunk/lib/Serialization/ASTReaderDecl.cpp URL:

r283444 - [modules] Allow VarDecls with initializers to use special var abbrev.

Author: vvassilev Date: Thu Oct 6 08:04:54 2016 New Revision: 283444 URL: http://llvm.org/viewvc/llvm-project?rev=283444=rev Log: [modules] Allow VarDecls with initializers to use special var abbrev. Update storage sizes to fit the (past) changes in the VarDecl's data model. Update some

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev updated this revision to Diff 73688. v.g.vassilev added a comment. Address some comments and publish current progress. https://reviews.llvm.org/D24508 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

v.g.vassilev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102 @@ -95,5 +101,3 @@ // as a note. -DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID); -for (unsigned i = 1; i < Group.Sequences.size(); ++i) { -

Re: [PATCH] D22439: Add missing includes.

v.g.vassilev added a comment. The 'atomic' bug was fixed I assume as part of https://llvm.org/bugs/show_bug.cgi?id=28794 Other includes landed in r281450. https://reviews.llvm.org/D22439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24508 Files: lib/Sema/SemaTemplate.cpp

r281316 - Revert accidentally checked in change in r281315.

Author: vvassilev Date: Tue Sep 13 05:38:26 2016 New Revision: 281316 URL: http://llvm.org/viewvc/llvm-project?rev=281316=rev Log: Revert accidentally checked in change in r281315. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL:

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

v.g.vassilev added a comment. Thanks for working on this! On my browser the note "Detected code clone" note appears slightly off the highlighted range which was a bit confusing to me. Given my limited understanding of the SA bug reports, this looks good to me. Comment at:

r280984 - [modules] Apply ODR merging for function scoped tags only in C++ mode.

Author: vvassilev Date: Thu Sep 8 15:34:41 2016 New Revision: 280984 URL: http://llvm.org/viewvc/llvm-project?rev=280984=rev Log: [modules] Apply ODR merging for function scoped tags only in C++ mode. In C mode, if we have a visible declaration but not a visible definition, a tag defined in the

r280827 - Add missing include. White space.

Author: vvassilev Date: Wed Sep 7 12:30:50 2016 New Revision: 280827 URL: http://llvm.org/viewvc/llvm-project?rev=280827=rev Log: Add missing include. White space. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Lex/ModuleMap.h URL:

Re: r262189 - [modules] Prefer more complete array types.

n Feb 28, 2016, at 11:08 AM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: Author: vvassilev Date: Sun Feb 28 13:08:24 2016 New Revision: 262189 URL: http://llvm.org/viewvc/llvm-project?rev=262189=rev Log: [modules] Prefer more compl

Re: r262189 - [modules] Prefer more complete array types.

int k = 2; }; void foo2() { C c; c.foo1(); } $ cat f3.cpp void foo1() { extern int foo0[1]; } template void foo2() { extern int foo0[n ? 1 : -1]; } void foo3() { foo2<5>(); } The code looks legal, so I don’t think clang should complain? On Feb 28, 2016, at 11:08 AM, Vassil Vassilev

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r279164 and r279486. https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added a comment. Thanks! Shall I close this? https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Thanks a lot! On 23/08/16 22:50, Richard Smith via cfe-commits wrote: Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth > wrote: Reverted this per Richard's request in r279500. On Mon, Aug 22,

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation.

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation.

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev updated this revision to Diff 68834. v.g.vassilev added a comment. Add the right diff. https://reviews.llvm.org/D23400 Files: include/clang/Analysis/DefUse.h lib/Analysis/CMakeLists.txt lib/Analysis/DefUse.cpp Index: lib/Analysis/DefUse.cpp

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68833. v.g.vassilev added a comment. Adapt to the new APIs. Now it builds. https://reviews.llvm.org/D23400 Files: lib/Sema/SemaExceptionSpec.cpp

Re: [PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:235 @@ +234,3 @@ + /// respective virtual methods. + class Constraint { + public: I am still unsure about the name. It is too generic. What about `CloneConstraint`?

r279371 - PR28423: Compare primary declaration contexts.

Author: vvassilev Date: Sat Aug 20 09:50:22 2016 New Revision: 279371 URL: http://llvm.org/viewvc/llvm-project?rev=279371=rev Log: PR28423: Compare primary declaration contexts. In certain cases (mostly coming from modules), Sema's idea of the StdNamespace does not point to the first declaration

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68723. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Sink some of the diagnostics in the DiagnoseUninstantiableTemplate. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

r279164 - PR28794: Don't try to instantiate function templates which are not visible.

Author: vvassilev Date: Thu Aug 18 17:01:25 2016 New Revision: 279164 URL: http://llvm.org/viewvc/llvm-project?rev=279164=rev Log: PR28794: Don't try to instantiate function templates which are not visible. Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inputs/PR28794/

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68620. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Move DiagnoseUninstantiableTemplate before the late template parsing. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68536. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add setHidden(false) and update fixme. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3600-3605 @@ -3598,2 +3599,8 @@ // which definitions should be visible. + if (DiagnoseUninstantiableTemplate(PointOfInstantiation, Function, +

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r279024 - PR28438: Update the information on an identifier with local definitions before

On 18/08/16 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macro

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68354. v.g.vassilev added a comment. Add forgotten change. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68349. v.g.vassilev added a comment. Do not instantiate function declarations which are not visible. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM once the @NoQ remarks are addressed. https://reviews.llvm.org/D23555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23492: Make function local tags visible.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Upon instantiating function decls, we should mark visible any tag decl in the function's body. Repository: rL

[PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev created this revision. v.g.vassilev added subscribers: teemperor, dergachev.a, krememek, cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. As a result of a few internal discussions, I'd like to continue the work done in this ancient thread

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

v.g.vassilev added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:431 @@ +430,3 @@ +// level of it's containing clone. This prevents false-positives caused by +// complex macros. For example 'assert(false)' could be reported as a clone +// if the assert

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:83 @@ +82,3 @@ +auto WarnID = DiagEngine.getCustomDiagID( +DiagnosticsEngine::Warning, "Maybe you wanted to use %0

Re: [PATCH] D23320: [analyzer] Fixed crash in CloneDetector in function calls.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D23320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278110 - [analyzer] Try to fix coverity CID 1360469.

Author: vvassilev Date: Tue Aug 9 05:00:23 2016 New Revision: 278110 URL: http://llvm.org/viewvc/llvm-project?rev=278110=rev Log: [analyzer] Try to fix coverity CID 1360469. Patch by Raphael Isemann! Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified:

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. My comments were clarified in a Skype chat. https://reviews.llvm.org/D22982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r276508 - Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark

On 23/07/16 04:32, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Jul 22 21:32:21 2016 New Revision: 276508 URL: http://llvm.org/viewvc/llvm-project?rev=276508=rev Log: Add -fmodules-ts flag to cc1 for the provisional C++ modules TS, and mark 'module' and 'import' as keywords

Re: [PATCH] D17820: Clang Code Completion Filtering

Fixed in r276889 by Simon Pilgrim! On 27/07/16 22:03, Vassil Vassilev wrote: Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change :

Re: r276889 - Fix unnecessary default switch warning

Thanks a lot! On 27/07/16 18:41, Simon Pilgrim via cfe-commits wrote: Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889=rev Log: Fix unnecessary default switch warning Modified:

Re: [PATCH] D17820: Clang Code Completion Filtering

Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r276878. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276878 - Implement filtering for code completion of identifiers.

Author: vvassilev Date: Wed Jul 27 09:56:59 2016 New Revision: 276878 URL: http://llvm.org/viewvc/llvm-project?rev=276878=rev Log: Implement filtering for code completion of identifiers. Patch by Cristina Cristescu and Axel Naumann! Agreed on post commit review (D17820). Modified:

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev requested changes to this revision. v.g.vassilev added a reviewer: v.g.vassilev. This revision now requires changes to proceed. Comment at: lib/Lex/Preprocessor.cpp:748 @@ +747,3 @@ + if (Result.is(tok::code_completion)) +

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

(forgot to click "reply all") Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL:

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL:

Re: r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

It could, it fixes a set of issues wrt to modules. On 25/07/16 22:39, Hans Wennborg wrote: Should this be merged to 3.9? On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision:

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev added a subscriber: v.g.vassilev. Comment at: include/clang/Lex/Preprocessor.h:270 @@ +269,3 @@ + /// on the stem that is to be code completed. + IdentifierInfo *CodeCompletionII; + Can you initialize this variable in the PP's ctor? Repository:

r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision: 276473 URL: http://llvm.org/viewvc/llvm-project?rev=276473=rev Log: [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader. Processing update records (and loading a module, in general) might trigger unexpected

r276469 - Add regression test for PR27699.

Author: vvassilev Date: Fri Jul 22 15:49:31 2016 New Revision: 276469 URL: http://llvm.org/viewvc/llvm-project?rev=276469=rev Log: Add regression test for PR27699. Added: cfe/trunk/test/Modules/Inputs/PR27699/ cfe/trunk/test/Modules/Inputs/PR27699/Subdir/

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev added a comment. Could we stress test the implementation by running on files from llvm's/clang's test suite. For example, for a test TST we could do something like: cat TST >> tmp_TST; cat TST >> tmp_TST and run our our copy-paste checker on tmp_TST. This way we know how many

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, given the comments are addressed. Comment at: include/clang/Analysis/CloneDetection.h:37 @@ +36,3 @@ + /// Stmt, then S is a pointer to this Stmt. + Stmt

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. I guess the question about the binary size holds here, too. What would be the impact on the binary size? Comment at: lib/Analysis/CloneDetection.cpp:104 @@ +103,3 @@ +/// defines what a 'similar'

r274930 - Teach -ast-print to print constexpr variables.

Author: vvassilev Date: Fri Jul 8 16:09:08 2016 New Revision: 274930 URL: http://llvm.org/viewvc/llvm-project?rev=274930=rev Log: Teach -ast-print to print constexpr variables. Patch reviewed by Richard Smith (D22168). Modified: cfe/trunk/lib/AST/DeclPrinter.cpp

r274859 - Don't crash when printing auto variables.

Author: vvassilev Date: Fri Jul 8 11:04:22 2016 New Revision: 274859 URL: http://llvm.org/viewvc/llvm-project?rev=274859=rev Log: Don't crash when printing auto variables. Patch by Axel Naumann! Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/test/SemaCXX/ast-print.cpp Modified:

r274830 - Recommit r274348 and r274349. The Windows failures should be fixed.

Author: vvassilev Date: Fri Jul 8 03:33:56 2016 New Revision: 274830 URL: http://llvm.org/viewvc/llvm-project?rev=274830=rev Log: Recommit r274348 and r274349. The Windows failures should be fixed. Original commit message: "Add postorder traversal support to the RecursiveASTVisitor. This

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/CloneDetection.h:148 @@ +147,3 @@ +/// This class only searches for clones in exectuable source code +/// (e.g. function bodies). Other clones (e.g.

Re: [PATCH] D20795: Added ASTStructure for analyzing the structure of Stmts.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Basic/SourceManager.h:1173 @@ +1172,3 @@ + + // + A leftover from something else? Comment at:

r274359 - Revert r274348 and r274349 until the Windows failures are fixed.

Author: vvassilev Date: Fri Jul 1 11:07:57 2016 New Revision: 274359 URL: http://llvm.org/viewvc/llvm-project?rev=274359=rev Log: Revert r274348 and r274349 until the Windows failures are fixed. Removed: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Modified:

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r274348 and r274349. http://reviews.llvm.org/D20382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274349 - Add forgotten test to r274348.

Author: vvassilev Date: Fri Jul 1 08:30:08 2016 New Revision: 274349 URL: http://llvm.org/viewvc/llvm-project?rev=274349=rev Log: Add forgotten test to r274348. Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp Added: cfe/trunk/unittests/AST/PostOrderASTVisitor.cpp URL:

r274348 - Add postorder traversal support to the RecursiveASTVisitor.

Author: vvassilev Date: Fri Jul 1 08:28:31 2016 New Revision: 274348 URL: http://llvm.org/viewvc/llvm-project?rev=274348=rev Log: Add postorder traversal support to the RecursiveASTVisitor. This feature needs to be explicitly enabled by overriding shouldTraversePostOrder() as it has

<    2   3   4   5   6   7   8   >