D24764: Deprecate KIconTheme::assignIconsToContextMenu

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY It's no longer necessary as Qt sets icons on context menu actions itself by now. REPOSITORY R302 KIconThemes

D24762: Remove two unused member variables using KSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24762 AFFECTED FILES

D24742: Make non-ignorable SSL errors explicit

vkrause updated this revision to Diff 68248. vkrause added a comment. Fix return value. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24742?vs=68168=68248 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 AFFECTED FILES

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b5f5fb475da7: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24742: Make non-ignorable SSL errors explicit

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far this is done implicitly in KSSLD by not being able to persist these error codes in its config file. This

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24703 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24703 AFFECTED FILES src/core/ksslerror_p.h

Re: ELF Dissector in kdereview

On Saturday, 12 October 2019 13:56:12 CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 12. Oktober 2019, 12:46:19 CEST schrieb Volker Krause: > > From the feedback everything should be addressed, apart from the following: > ... > * "hicolor" icons for the app icon are

D24682: Use ECMGenerateExportHeader to manage deprecated API better

vkrause accepted this revision. This revision is now accepted and ready to land. BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24682 To: kossebau, #frameworks, vkrause

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

vkrause added a task: T11544: Remove KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24675 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 AFFECTED FILES

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The KSslErrorUiData variant below covers KTcpSocket too as a source for errors, next to QSslSocket/QNAM. Also,

Re: KPublicTransport in kdereview

On Sunday, 13 October 2019 17:24:50 CEST Albert Astals Cid wrote: > El dissabte, 12 d’octubre de 2019, a les 12:54:31 CEST, Volker Krause va escriure: > > Hi, > > > > KPublicTransport has been moved to kdereview: > > > > https://phabricato

[kmail2] [Bug 411999] kmail crashes on a base64 encoded PDF file

https://bugs.kde.org/show_bug.cgi?id=411999 --- Comment #4 from Volker Krause --- A local workaround for this is to delete /usr/lib64/plugins/messageviewer/bodypartformatter/messageviewer_bodypartformatter_semantic.so (exact location can vary slightly depending on the distro). This entire class

[kmail2] [Bug 411999] kmail crashes on a base64 encoded PDF file

https://bugs.kde.org/show_bug.cgi?id=411999 --- Comment #4 from Volker Krause --- A local workaround for this is to delete /usr/lib64/plugins/messageviewer/bodypartformatter/messageviewer_bodypartformatter_semantic.so (exact location can vary slightly depending on the distro). This entire class

[kmail2] [Bug 412251] Kmail crashes when deleting mail

https://bugs.kde.org/show_bug.cgi?id=412251 --- Comment #1 from Volker Krause --- A local workaround for this is to delete /usr/lib64/plugins/messageviewer/bodypartformatter/messageviewer_bodypartformatter_semantic.so (exact location can vary slightly depending on the distro). Debugging

[kmail2] [Bug 412251] Kmail crashes when deleting mail

https://bugs.kde.org/show_bug.cgi?id=412251 --- Comment #1 from Volker Krause --- A local workaround for this is to delete /usr/lib64/plugins/messageviewer/bodypartformatter/messageviewer_bodypartformatter_semantic.so (exact location can vary slightly depending on the distro). Debugging

D24655: give all pointers in slavebase a default init to nullptr

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24655 To: sitter, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:77fce361d9ba: Port KSslErrorUiData to QSslError (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24590?vs=67828=67918#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24631: exclude ioslaves directory from api docs

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH no-slave-dox REVISION DETAIL https://phabricator.kde.org/D24631 To: sitter, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

vkrause added a comment. In D24590#546528 , @aacid wrote: > Do we have tests for the thing you discovered breaks? Do we need them? There's almost no test coverage for this unfortunately, and yes, I'd feel much better if we had that. I

[systemsettings] [Bug 412913] Initial loading is broken

https://bugs.kde.org/show_bug.cgi?id=412913 --- Comment #2 from Volker Krause --- Not sure I fully understand, what would be the behavior change you need in KUserFeedback? -- You are receiving this mail because: You are watching all bug changes.

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #23 from Volker Krause --- Git commit 7e0e66911e642a82b8807022926d24996479fc19 by Volker Krause. Committed on 13/10/2019 at 10:47. Pushed by vkrause into branch 'Applications/19.08'. Better end time default for restaurant reservations

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #22 from Volker Krause --- Oh, I see, this happens when adding it to the calendar, I can reproduce now. Yes, 2h when no end time is given makes sense, I'll fix that. -- You are receiving this mail because: You are watching all bug changes.

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #19 from Volker Krause --- Interesting! This seems to show up correctly here in KMail and in KDE Itinerary, however I don't see the end time shown anywhere (and there is none specified in the email). Where did it show 23h59 for you

D24603: Port away from deprecated KDELibs4Support

vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24603: Port away from deprecated KDELibs4Support

vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

vkrause added a comment. In D24588#546229 , @dfaure wrote: > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`. > Don't know, just wondering (not

D24590: Port KSslErrorUiData to QSslError

vkrause updated this revision to Diff 67828. vkrause added a comment. This revision is now accepted and ready to land. Deal with errors with full QSslError level of detail until kssld is ported, make variables const. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24590: Port KSslErrorUiData to QSslError

vkrause planned changes to this revision. vkrause added a comment. This actually breaks things when the error comes from a Qt source rather than a KIO one, as we now carry the QSslError level of detail forward far enough and compare it to the stored KSslError. This is a temporary problem

KPublicTransport in kdereview

Hi, KPublicTransport has been moved to kdereview: https://phabricator.kde.org/source/kpublictransport/ KPublicTransport is a library for accessing real-time public transport information (location, departure and journey queries) via a C++ or QML API, aggregating results from Navitia.io as well

Re: ELF Dissector in kdereview

ody adding that, but I don't have the bandwidth to maintain that myself. Again, IMHO not a review or release blocker. Regards, Volker On Saturday, 28 September 2019 13:01:11 CEST Volker Krause wrote: > Hi, > > ELF Dissector has been moved to kdereview for the usual review process

D24590: Port KSslErrorUiData to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24590 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24590 AFFECTED

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:41a209b2b6ce: Implement KSslCertificateRule with QSslError instead of KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:524023533886: Port (most of) the interface of KSslCertificateRule to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause updated this revision to Diff 67782. vkrause added a comment. bump version number to 5.64 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24382?vs=67247=67782 BRANCH arcpatch-D24382 REVISION DETAIL https://phabricator.kde.org/D24382 AFFECTED

D24294: Port KSslCertificateManager to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4bfbdad31fdc: Port KSslCertificateManager to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24294?vs=67780=67781 REVISION DETAIL

D24294: Port KSslCertificateManager to QSslError

vkrause updated this revision to Diff 67780. vkrause added a comment. bump version to 5.64 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24294?vs=67019=67780 BRANCH arcpatch-D24294 REVISION DETAIL https://phabricator.kde.org/D24294 AFFECTED FILES

D24537: Icons for windy weather

vkrause added a comment. Nice! We use the Breeze weather icons in KDE Itinerary too, based on api.met.no data, but so far didn't make use of the wind information in there yet. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis Cc:

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

vkrause added a reviewer: KDE PIM. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim Cc: vkrause, dvratil, davidedmundson, dhaumann

D24443: Add a plugin system

vkrause added a comment. In D24443#543140 , @vkrause wrote: > - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even needed for this),

D24294: Port KSslCertificateManager to QSslError

vkrause added a comment. In D24294#543158 , @apol wrote: > I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets. The context is the (still

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24419 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

vkrause added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

vkrause added subscribers: dvratil, vkrause. vkrause added a comment. Thanks for working on this! Some general thoughts: - Is KDeclarative is the right place for this? It's a module on the way out in KF6, it is hard to build for Android due to its dependency chain (which isn't even

Re: Call for action: applying version-based deprecation macros for KDE Frameworks API

On Sunday, 6 October 2019 13:14:50 CEST Friedrich W. H. Kossebau wrote: > PROTOTYPE BECOMING PRODUCTION VERSION > > So far feedback has been positive (thanks especially David, but also > Christian & Albert for comments). Could have been more feedback, but I > project the silence onto "seems fine

D24434: Fix include path to kjob.h

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24434 To: hallas, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24416: Declare Calendar::Ptr as metatype

vkrause accepted this revision. This revision is now accepted and ready to land. BRANCH metatype REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

Re: Work Branches

On Saturday, 5 October 2019 04:11:11 CEST Ben Cooksley wrote: > Hi all, > > Recently we had a discussion (which I think may have ended up spread > over a couple of mailing lists in the end) concerning branches and the > ability to force push to them. > > Current policy forbids force pushing to

D24416: Declare Calendar::Ptr as metatype

vkrause added a comment. Ok as such, but there seem to be unrelated changes to test scripts in this commit. REVISION DETAIL https://phabricator.kde.org/D24416 To: nicolasfella, #frameworks, vkrause

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24419 AFFECTED

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The implementation is still done in terms of KSslError, swapping that is one of the

D24348: Use range for loop instead of ugly sizeof arithmetic

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24348 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: ELF Dissector in kdereview

On Tuesday, 1 October 2019 14:06:57 CEST Jonathan Riddell wrote: > The file src/3rdparty/treemap/treemap.cpp is GPL while the rest of the > application is LGPL. This makes the whole application copyable under only > the terms of the GPL. It would be good to have COPYING moved to > COPYING.LIB

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D24347 To: aacid, vkrause Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D24346 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24344 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: ELF Dissector in kdereview

On Tuesday, 1 October 2019 17:28:03 CEST Thiago Macieira wrote: > On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > > -isystem > > /usr/include/capstone/.. > > [...] > > > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > > directory > > That -isystem is

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9713ea02e49e: Consider the usage of WebDAV methods sufficient for assuming WebDAV (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24315: REPORT also supports the Depth header

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ac0462180c0d: REPORT also supports the Depth header (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24315?vs=67078=67141 REVISION DETAIL

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far WebDAV only really works when using webdav[s]: URLs, which is an unexpected

D24315: REPORT also supports the Depth header

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY See RFC 3253 Section 3.6. Setting the depth for REPORT currently requires dirty

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fab04a62f2ca: Make QSslError::SslError - KSslError::Error conversion reusable (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23920: Deprecate the KSslError::Error ctor of KSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d75d5ac36582: Deprecate the KSslError::Error ctor of KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23920?vs=65954=67076 REVISION

Re: ELF Dissector in kdereview

Thanks for the feedback :) On Sunday, 29 September 2019 12:51:03 CEST Albert Astals Cid wrote: > El dissabte, 28 de setembre de 2019, a les 13:01:11 CEST, Volker Krause va escriure: > > Hi, > > > > ELF Dissector has been moved to kdereview for the usual review process.

D24294: Port KSslCertificateManager to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY An easy one admittedly. Uses have not been adapted yet, as this needs at least

D24293: Make QSslError::SslError <-> KSslError::Error conversion reusable

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This will allow a step by step migration of the certificate manager and kssld code

D23920: Deprecate the KSslError::Error ctor of KSslError

vkrause added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23920 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

ELF Dissector in kdereview

Hi, ELF Dissector has been moved to kdereview for the usual review process. https://phabricator.kde.org/source/elf-dissector/ ELF Dissector is a static analysis tool for ELF libraries and executables, for doing things like inspecting forward and backward dependencies (on a library or symbol

D23927: Improve naming of KTitleWidget icon methods

vkrause added a comment. In D23927#537583 , @kossebau wrote: > When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: > > - KTitleWidget has a property "pixmap" > - the `setPixmap`

D24182: Fix FindEGL when using Emscripten

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks safe to me, should not change the non-EMSCRIPTEN behavior. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24182 To: hausmann, vkrause,

D24182: Fix FindEGL when using Emscripten

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks safe to me, should not change the non-EMSCRIPTEN behavior. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24182 To: hausmann, vkrause,

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

This revision was automatically updated to reflect the committed changes. Closed by commit R302:22132a50c4a8: Deprecate the global [Small|Desktop|Bar]Icon() methods (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66606=66617

D24138: Port away from deprecated KIconThemes methods

This revision was automatically updated to reflect the committed changes. Closed by commit R241:371522fd31e9: Port away from deprecated KIconThemes methods (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24138?vs=66607=66616 REVISION DETAIL

D24138: Port away from deprecated KIconThemes methods

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24138 AFFECTED

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause updated this revision to Diff 66606. vkrause added a comment. Actually use KICONTHEMES_NO_DEPRECATED correctly. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66605=66606 BRANCH master REVISION DETAIL

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause updated this revision to Diff 66605. vkrause added a comment. Use KICONTHEMES_NO_DEPRECATED. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24136?vs=66592=66605 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24136 AFFECTED

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24136 To: vkrause, dfaure Cc: dfaure, ngraham, kde-frameworks-devel,

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause added a comment. In D24136#535818 , @dfaure wrote: > kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon. > (and that's all I can find in all of KF5) Right, usage is fortunately not very wide-spread anymore. Before

D24136: Deprecate the global [Small|Desktop|Bar]Icon() methods

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY They are not namespaced and promote the use of pixmaps rather than icons. Additionally their API allowing to specify

D24060: Make KColorScheme compatible with QVariant

vkrause added a task: T8837: QColor support for Grantlee. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Heads-up: KContacts and KCalendarCore about to move to Frameworks

On Thursday, 19 September 2019 21:40:19 CEST Luigi Toscano wrote: > Christoph Feck ha scritto: > > Hello packagers, > > > > to minimize disruption caused by the git repo rename, I offered to > > distribute 19.08.x tarballs with the old name ('kcalcore' instead of > > 'kcalendarcore'). > > > > On

D24113: xcf: Properly read image resolution

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D24113 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24114: xcf: Fix regression when reading files with "unsupported" properties

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D24114 To: aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24059: Replace KSslError::errorString with QSslError::errorString

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b56de79a281f: Replace KSslError::errorString with QSslError::errorString (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24059?vs=66400=66546

D24060: Make KColorScheme compatible with QVariant

vkrause added a dependent revision: D24094: Add support for KColorScheme. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24060: Make KColorScheme compatible with QVariant

This revision was automatically updated to reflect the committed changes. Closed by commit R265:d65940d8e882: Make KColorScheme compatible with QVariant (authored by vkrause). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24060?vs=66401=66490

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #17 from Volker Krause --- Git commit 1bec3fd915adfc63c55d9b9e478718b623fd by Volker Krause. Committed on 19/09/2019 at 17:03. Pushed by vkrause into branch 'Applications/19.08'. Fix date parsing in SNCF confirmation emails M +2

Re: Heads-up: KContacts and KCalendarCore about to move to Frameworks

On Sunday, 15 September 2019 12:19:14 CEST Volker Krause wrote: > Hi, > > as previously discussed here and finally approved during Akademy we will > move KContacts and KCalendarCore from Applications to Frameworks. This > should hopefully cause minimal disruptions as the version

Re: Heads-up: KContacts and KCalendarCore about to move to Frameworks

On Sunday, 15 September 2019 12:19:14 CEST Volker Krause wrote: > Hi, > > as previously discussed here and finally approved during Akademy we will > move KContacts and KCalendarCore from Applications to Frameworks. This > should hopefully cause minimal disruptions as the version

D24060: Make KColorScheme compatible with QVariant

vkrause added a comment. In D24060#534122 , @dfaure wrote: > Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already? No, as Q_DECLARE_METATYPE requires the type to have a default ctor,

D24060: Make KColorScheme compatible with QVariant

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This requires default constructability and a meta type declaration. The use-case for this is to expose a KColorScheme

D24059: Replace KSslError::errorString with QSslError::errorString

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24059 To: vkrause, dfaure, aacid, ltoscano Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24059: Replace KSslError::errorString with QSslError::errorString

vkrause created this revision. vkrause added reviewers: dfaure, aacid, ltoscano. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This trades more detailed and complete messages with currently less

D24027: Remove the minitools plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R226:6bbbd0c313ba: Remove the minitools plugin (authored by vkrause). REPOSITORY R226 Konqueror CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24027?vs=66310=66396 REVISION DETAIL

<    6   7   8   9   10   11   12   13   14   15   >