On Wed, Aug 12, 2020 at 11:45:54AM +0800, Anson Huang wrote:
> dev_err_probe() can reduce code size, uniform error handling and record the
> defer probe reason etc., use it to simplify the code.
>
> Signed-off-by: Anson Huang
Applied to for-next, thanks!
signature.asc
Description: PGP
On Wed, Sep 02, 2020 at 12:51:37AM -0400, Jeffrey Lin wrote:
> Value of /sys/devices/platform/lis3lv02d/position when
> Horizontal: (36,-108,-1152)
> Left elevated: (-432,-126,-1062)
> Front elevated: (36,594,-936)
> Upside down:(-126,-252,1098)
>
> Signed-off-by: Jeffrey
in a lock up/high CPU usage. We need to re-apply any configuration that
> had previously been set and re-enable the chip.
>
> Signed-off-by: Evan Nimmo
> Reviewed-by: Chris Packham
> Reviewed-by: Andy Shevchenko
> Reviewed-by: Wolfram Sang
Applied to for-current, thanks!
For the
Hi Evan,
> changes in v2:
> - changed lowercase "pca to uppercase "PCA".
> - reworded and reformatted the multiline comment.
> - moved the clock frequency KERN_INFO closer to the call that sets this.
> - moved the i2c_bus_settings struct to the more generic i2c.h and removed
> - the comments
On Mon, Aug 31, 2020 at 12:31:21AM +0300, Tali Perry wrote:
> timeout_usec value calculation was wrong, the calculated value
> was in msec instead of usec.
>
> Signed-off-by: Tali Perry
> Reviewed-by: Avi Fishman
Applied to for-current, thanks! And thanks for the Fixes-tag, Joel.
On Fri, Sep 04, 2020 at 11:06:47AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> clang static analyzer reports this problem
>
> i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates
> to a garbage value
> return err ? err : num;
>^~~
>
> err is not
Hi Codrin,
> The pinmux driver needs to have strict set to false, otherwise the
> switching is not available, not at this time at least. Perhaps there is
> room for improvement here, because the I2C bus is not using the pins
> while we are doing GPIO recovery.
Our driver doesn't use 'strict'.
The LTS granularity of patches is a nice idea! I will keep it in mind.
>
> Signed-off-by: Douglas Anderson
In general, I like more coverage of async probing. It makes sense for
SD/MMC, I think.
Reviewed-by: Wolfram Sang
> drivers/mmc/host/renesas_sdhi_internal_dmac
gned-off-by: Robin Murphy
Double-checked the mentioned commit above:
Reviewed-by: Wolfram Sang
No regression and same performance when checksumming a large file:
Tested-by: Wolfram Sang
Thanks for the patch!
signature.asc
Description: PGP signature
> > +/**
> > + * struct i2c_bus_settings - The configured i2c bus settings
> > + * @mode: Configured i2c bus mode (PCA9665)
> > + * @tlow: Configured SCL LOW period (PCA9665)
> > + * @thi: Configured SCL HIGH period (PCA9665)
> > + * @clock_freq: The configured clock frequency (PCA9564)
> > + */
> + switch (event) {
> + case I2C_SLAVE_STOP:
> + command_size = panel->idx;
> + fallthrough;
> + case I2C_SLAVE_WRITE_REQUESTED:
> + panel->idx = 0;
> + break;
> + case I2C_SLAVE_WRITE_RECEIVED:
> + if (panel->idx <
> > + ibm-panel@62 {
> > + compatible = "ibm,op-panel";
> > + reg = <0x4062>; /* I2C_OWN_SLAVE_ADDRESS */
>
> Other users of SLAVE_ADDRESS have included and
> written the reg as follows:
>
> reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)>
>
> Which obviously has
Signed-off-by: Wolfram Sang
---
Only buildtested. Found while analyzing retune-handling in the core.
drivers/mmc/host/meson-gx-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 08a3b1c05acb
> + unsigned int flags;
u32?
signature.asc
Description: PGP signature
> This patchset is really about changing the default of ACPI powering up I²C
> devices. On OF the drivers are indeed responsible for that.
So, maybe it makes sense then to move from 'device_property_present()'
to 'acpi_dev_get_property()' or something alike? To clearly tell this
binding is
Hi Soeren,
> Personally, my prefered solution would be to ask the user when uninstalling
> as he/she is the only one who can make the desired choice when using
> makefiles. Is there a way to add a yes/no confirmation? If so, this is the
> route I'd go.
Uh, please no. Nobody expects user
Hi Gerhard,
> Minor make nit: Was to understand that $(RM) is more portable,
> and might be preferred. But could not find examples in existing
> rules within the minute that I spent searching. It's pre-set in
> GNU make, can't speak with certainty for automake on other
> platforms that don't use
From: Wolfram Sang
Decoders were left when using 'uninstall' target.
Signed-off-by: Wolfram Sang
---
Found this while trying to remove outdated (because renamed) decoders
which triggered warnings. I hope this is proper automake.
Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff
fail PRP0001 enumeration when no ID table exist
i2c: acpi: Remove dead code, i.e. i2c_acpi_match_device()
Ray Jui (1):
i2c: iproc: Fix shifting 31 bits
Wolfram Sang (1):
i2c: rcar: in slave mode, clear NACK earlier
with much appreciated quality assurance from
Hi Sakari,
On Wed, Aug 26, 2020 at 02:54:27PM +0300, Sakari Ailus wrote:
> Enable drivers to tell ACPI that there's no need to power on a device for
> probe. Drivers should still perform this by themselves if there's a need
> to. In some cases powering on the device during probe is undesirable,
i2c: rcar: handle RXDMA HW behaviour on Gen3")
> Cc: Wolfram Sang
> Cc:
> Signed-off-by: Dirk Behme
> Signed-off-by: Andy Lowe
> [erosca: Add "if ARCH_RCAR_GEN3" on Wolfram's request]
> Signed-off-by: Eugeniu Rosca
Applied to for-next, thanks!
signature.asc
Description: PGP signature
On Wed, Aug 26, 2020 at 01:54:26PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 26, 2020 at 07:38:07PM +0900, Sergey Senozhatsky wrote:
> > On (20/08/26 19:24), Sergey Senozhatsky wrote:
> > > > But then the question is why we have this code in the ->probe() at all?
> > > > ->match() is run before
> Thanks, this would be great! I tested this on a sam9x60, with the HW
> feature for the 9 pulses disabled, with a picky audio codec as I2C device.
> Please let me know of the result.
I can't make use of the feature on the platform I had in mind, sadly. It
doesn't really support switching
On Wed, Aug 26, 2020 at 01:29:37PM +0900, Sergey Senozhatsky wrote:
> Unlike acpi_match_device(), acpi_driver_match_device() does
> consider devices that provide of_match_table and performs
> of_compatible() matching for such devices. The key point here is
> that ACPI of_compatible() matching -
On Tue, Aug 25, 2020 at 10:55:32AM +0200, Maxime Ripard wrote:
> On Mon, Aug 24, 2020 at 09:03:27AM +0100, Lee Jones wrote:
> > On Mon, 24 Aug 2020, Frank Lee wrote:
> >
> > > ping..
> >
> > "Please don't send content free pings and please allow a reasonable
> > time for review. People get
Hi Phil,
yes, this thread is old but a similar issue came up again...
On Fri, Oct 25, 2019 at 09:14:00AM +0800, Phil Reid wrote:
> >
> > > So at the beginning of a new transfer, we should check if SDA (or SCL?)
> > > is low and, if it's true, only then we should try recover the bus.
> >
> >
On Tue, Aug 25, 2020 at 10:52:54AM +1200, Mark Tomlinson wrote:
> This adds i2c bus recovery to the mv64xxx driver.
>
> Implement bus recovery to recover from SCL/SDA stuck low.
>
> This uses the generic recovery function, setting the clock/data lines as
> GPIO pins, and sending 9 clocks to try
On Fri, Jul 24, 2020 at 03:17:01PM +0800, Frank Lee wrote:
> From: Yangtao Li
>
> Allwinner A100 have a mv64xxx i2c interface available to be used.
>
> Signed-off-by: Yangtao Li
> Reviewed-by: Rob Herring
For the record, this got upstream during the 5.9 merge window. I seem to
have forgotten
On Fri, Aug 14, 2020 at 03:40:08PM -0700, Ray Jui wrote:
> Fix additional checkpatch warnings in the iProc I2C driver by using
> 'BIT' marcro.
>
> Reported-by: Wolfram Sang
> Signed-off-by: Ray Jui
Changed the commit msg a little. This is not about 'checkpatch', this is
about f
..@alsa-project.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-...@lists.infradead.org
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-ser...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Rob Herring
I trust you guys in figuring out the details, so for touching I2C:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
..@alsa-project.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-...@lists.infradead.org
> Cc: net...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-ser...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Rob Herring
I trust you guys in figuring out the details, so fo
> + select RESET_CONTROLLER
Only needed for Gen3, so 'if ARCH_RCAR_GEN3'?
signature.asc
Description: PGP signature
> + irq_received &= 0xf000;
Can we have a define for this? Like ASPEED_I2CD_INTR_MASTER_IRQS or
something?
signature.asc
Description: PGP signature
On Sat, May 02, 2020 at 04:26:56PM +0200, Wolfram Sang wrote:
> The 'pengutronix' address is defunct for years. Use the proper contact
> address.
>
> Signed-off-by: Wolfram Sang
Ping?
> ---
> drivers/net/can/mscan/mpc5xxx_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1
management
Wolfram Sang (6):
i2c: revert "i2c: core: Allow drivers to disable i2c-core irq mapping"
i2c: rcar: slave: only send STOP event when we have been addressed
i2c: core: do not use logical device when creating irq domain
Merge tag 'v5.8-rc7' into i2c/for
On Wed, Jul 08, 2020 at 09:10:36AM +1200, Mark Tomlinson wrote:
> This adds i2c bus recovery to the mv64xxx driver.
>
> Implement bus recovery to recover from SCL/SDA stuck low.
>
> This uses the generic recovery function, setting the clock/data lines as
> GPIO pins, and sending 9 clocks to try
On Mon, Aug 10, 2020 at 05:42:40PM -0700, Dhananjay Phadke wrote:
> When i2c client unregisters, synchronize irq before setting
> iproc_i2c->slave to NULL.
>
> (1) disable_irq()
> (2) Mask event enable bits in control reg
> (3) Erase slave address (avoid further writes to rx fifo)
> (4) Flush tx
> Wolfram says. From my side: I'd prefer to see the
> disable_i2c_core_irq_mapping converted to flags first and then the
> flags extended with whatever you need. disable_i2c_core_irq_mapping
> could also be removed AFAICT - nobody uses it.
I haven't read the details here, just saying that
On Thu, Aug 06, 2020 at 01:06:15AM +0530, Vaibhav Gupta wrote:
> The driver calls pci_enable_wake(, false) in pch_i2c_suspend() as well
> as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
> or should not invoke pci_enable_wake() at all.
>
> Concluding that this driver
On Thu, Aug 06, 2020 at 01:06:16AM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
>
> Switch to generic power
identifier tables during probes.
>
> Signed-off-by: Stephen Kitt
This is useful, helps deprecating the old probe method:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
identifier tables during probes.
>
> Signed-off-by: Stephen Kitt
This is useful, helps deprecating the old probe method:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
identifier tables during probes.
>
> Signed-off-by: Stephen Kitt
This is useful, helps deprecating the old probe method:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
identifier tables during probes.
>
> Signed-off-by: Stephen Kitt
This is useful, helps deprecating the old probe method:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
level of error-handling (if any) as before.
>
> Additionally, the mismatch message in the ltc2978 driver is adjusted
> so that it no longer assumes that the driver_data is an index into
> ltc2978_id.
>
> Signed-off-by: Stephen Kitt
Still no detailed review, but I suppor
t; level of error-handling (if any) as before.
>
> Signed-off-by: Stephen Kitt
I haven't checked the patch in detail, just saying that the bulk move to
probe_new is much appreciated, so:
Acked-by: Wolfram Sang
One thing hit my eye, though:
> if (md)
> vs = (e
On Thu, Aug 06, 2020 at 06:14:56PM +0200, Stephen Kitt wrote:
> All the drivers have long since been upgraded, and all the important
> information here is also included in the "Implementing I2C device
> drivers" guide.
>
> Signed-off-by: Stephen Kitt
Reviewed-by: Wolfr
On Thu, Aug 06, 2020 at 11:29:01AM +0100, Colin King wrote:
> From: Colin Ian King
>
> There are spelling mistakes in two debug messages. As recommended
> by Wolfram Sang, these can be removed as there is plenty of debug
> in the driver core.
>
> Signed-off-by: Col
On Thu, Aug 06, 2020 at 11:29:01AM +0100, Colin King wrote:
> From: Colin Ian King
>
> There are spelling mistakes in two debug messages. As recommended
> by Wolfram Sang, these can be removed as there is plenty of debug
> in the driver core.
>
> Signed-off-by: Col
2 once we decide where it should go.
I am fine with either it going via the doc-tree or you sending me v2
again after 5.9-rc1. For the first case:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
On Wed, Aug 05, 2020 at 11:43:37AM +0100, Colin King wrote:
> From: Colin Ian King
>
> There are spelling mistakes in DBG messages. Fix them.
>
> Signed-off-by: Colin Ian King
These comments can go entirely. i2c_detach is long history. And for
remove, we have debugging output in the driver
On Wed, Aug 05, 2020 at 11:43:37AM +0100, Colin King wrote:
> From: Colin Ian King
>
> There are spelling mistakes in DBG messages. Fix them.
>
> Signed-off-by: Colin Ian King
These comments can go entirely. i2c_detach is long history. And for
remove, we have debugging output in the driver
Hi Stephen,
On Wed, Aug 05, 2020 at 08:31:49PM +0200, Stephen Kitt wrote:
> All the drivers have long since been upgraded, and all the important
> information here is also included in the "Implementing I2C device
> drivers" guide.
>
> Signed-off-by: Stephen Kitt
True! Thanks.
But I can't
> Yes, I've chosen "the easy way" of git commit --amend:
> Editing the patch file.
> I this a problem?
Usually, yes. It can easily create inconsitencies which make me as a
maintainer suspicious.
signature.asc
Description: PGP signature
On Mon, Jul 27, 2020 at 01:43:40PM -0700, Ray Jui wrote:
>
>
> On 7/27/2020 1:26 PM, Wolfram Sang wrote:
> > On Mon, Jul 27, 2020 at 08:13:46PM +0200, Wolfram Sang wrote:
> >>
> >>> Can you confirm that even if we have irq pending at the i2c IP core
>
On Mon, Jul 20, 2020 at 07:30:32PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy PM have to manage PCI states and device's PM states
> themselves. They also need to take care of configuration registers.
>
> With improved and powerful support of generic PM, PCI Core takes care of
> above
> I've simplified the index handling as you suggested. The only impact is that
> finally we do not consider anymore the I2C_SLAVE_WRITE_REQUESTED event as the
> beginning of the transaction since we don't perform the "reset" of the
> handling upon this event.
One more comment on this one because
On Fri, Jun 19, 2020 at 05:19:04PM +0300, Codrin Ciubotariu wrote:
> Make the Microchip at91 driver the first to use the generic GPIO bus
> recovery support from the I2C core and discard the driver implementation.
>
> Signed-off-by: Codrin Ciubotariu
> ---
> drivers/i2c/busses/i2c-at91-master.c
On Fri, Jun 19, 2020 at 05:19:03PM +0300, Codrin Ciubotariu wrote:
> Even if I2C bus GPIO recovery is optional, devm_gpiod_get() can return
> -EPROBE_DEFER, so we should at least treat that. This ends up with
> i2c_register_adapter() to be able to return -EPROBE_DEFER.
>
> Signed-off-by: Codrin
On Fri, Jun 19, 2020 at 05:19:02PM +0300, Codrin Ciubotariu wrote:
> Multiple I2C bus drivers use similar bindings to obtain information needed
> for I2C recovery. For example, for platforms using device-tree, the
> properties look something like this:
>
> {
> ...
> pinctrl-names =
)
Akash Asthana (1):
MAINTAINERS: Update GENI I2C maintainers list
Wolfram Sang (3):
i2c: also convert placeholder function to return errno
i2c: slave: improve sanity check when registering
i2c: slave: add sanity check when unregistering
with much appreciated quality
ke this via I2C, but I'd need an ack from Rafael or Len.
Or it can go via ACPI, fine with me
Acked-by: Wolfram Sang
> ---
> drivers/acpi/acpi_apd.c | 1 +
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff
On Fri, Jul 31, 2020 at 02:02:39AM -0700, Sowjanya Komatineni wrote:
> This series adds support for video capture from external camera sensor to
> Tegra video driver.
No need anymore to CC me or the i2c-list, I think? Also, is this series
really still RFC?
signature.asc
Description: PGP
Hi Alain,
> I've taken your comments and prepared a new serie including them.
> I'll wait for the conclusion regarding the bindings before pushing it.
Thanks! I hope we can finish the discussion this week because Linus
hasn't made a clear statement if there will be an rc8. But I still think
we
On Mon, Jul 27, 2020 at 01:57:20PM -0700, Sowjanya Komatineni wrote:
> clk_enable, clk_disable, clk_prepare, and clk_unprepare APIs have
> implementation for checking clk pointer not NULL and clock consumers
> can safely call these APIs without NULL pointer check.
>
> So, this patch cleans up
On Mon, Jul 27, 2020 at 01:57:23PM -0700, Sowjanya Komatineni wrote:
> VI I2C is on host1x bus so APB DMA can't be used for Tegra210 VI
> I2C and there are no tx and rx dma channels for VI I2C.
>
> So, avoid attempt of requesting DMA channels.
>
> Reviewed-by: Dmitry Osipenko
> Signed-off-by:
On Mon, Jul 27, 2020 at 01:57:21PM -0700, Sowjanya Komatineni wrote:
> tegra_i2c_runtime_resume does not disable prior enabled clocks
> properly.
>
> This patch fixes it.
>
> Reviewed-by: Dmitry Osipenko
> Signed-off-by: Sowjanya Komatineni
Applied to for-next, thanks!
signature.asc
On Mon, Jul 27, 2020 at 01:57:22PM -0700, Sowjanya Komatineni wrote:
> VI I2C is on host1x bus and is part of VE power domain.
>
> During suspend/resume VE power domain goes through power off/on.
>
> So, controller reset followed by i2c re-initialization is required
> after the domain power up.
On Mon, Jul 27, 2020 at 01:57:19PM -0700, Sowjanya Komatineni wrote:
> Tegra VI I2C is part of VE power domain and typically used for
> camera usecases.
>
> VE power domain is not always on and is non-IRQ safe. So, IRQ safe
> device cannot be attached to a non-IRQ safe domain as it prevents
>
On Mon, Jul 27, 2020 at 08:13:46PM +0200, Wolfram Sang wrote:
>
> > Can you confirm that even if we have irq pending at the i2c IP core
> > level, as long as we execute Step 2. below (to disable/mask all slave
> > interrupts), after 'enable_irq' is called, we still
On Mon, Jul 27, 2020 at 01:56:00PM +0530, Akash Asthana wrote:
> Alok Chauhan has moved out of GENI team, he no longer supports GENI I2C
> driver, remove him from maintainer list.
>
> Add Akash Asthana & Mukesh Savaliya as maintainers for GENI I2C drivers.
>
> Signed-off-by: Akash Asthana
> Can you confirm that even if we have irq pending at the i2c IP core
> level, as long as we execute Step 2. below (to disable/mask all slave
> interrupts), after 'enable_irq' is called, we still will not receive any
> further i2c slave interrupt?
This is HW dependant. From my tests with Renesas
On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote:
> Wolfram Sang writes:
>
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> >> Missing this firmware is not fatal, my wifi card still works. Even more,
> >> I couldn't find any documentat
On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If you browse
> > +void i2c_free_slave_host_notify_device(struct i2c_client *client)
> > +{
> > + i2c_slave_unregister(client);
> > + kfree(client->dev.platform_data);
> > + i2c_unregister_device(client);
> > +}
> > +EXPORT_SYMBOL_GPL(i2c_free_slave_host_notify_device);
>
> Sidenote: With my recent
On Thu, Jul 23, 2020 at 09:56:34PM +0200, Wolfram Sang wrote:
> On Wed, Jul 22, 2020 at 03:00:21PM -0700, Douglas Anderson wrote:
> > When I have KASAN enabled on my kernel and I start stressing the
> > touchscreen my system tends to hang. The touchscreen is one of the
> >
On Wed, Jul 15, 2020 at 12:09:01PM +0100, Lad Prabhakar wrote:
> Document i2c controller for RZ/G2H (R8A774E1) SoC, which is compatible
> with R-Car Gen3 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Applied to for-next, thanks!
signature.asc
On Wed, Jul 15, 2020 at 12:09:02PM +0100, Lad Prabhakar wrote:
> Document IIC controller for RZ/G2H (R8A774E1) SoC, which is compatible
> with R-Car Gen3 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Applied to for-next, thanks!
signature.asc
Hi Alain,
some more comments for this one. I hope to come to a conclusion with Rob
regarding the binding for patch 2, so we are then ready to go.
On Fri, Jul 03, 2020 at 01:36:07PM +0200, Alain Volmat wrote:
> SMBus Host-Notify protocol, from the adapter point of view
> consist of receiving a
Linus,
> Do you have a lot of pending fixes? Because things _seem_ fairly quiet
> for this release, and right now it doesn't seem to make much sense to
> delay 5.8.
No, it is not about fixes. I have one fix pending and I am quite sure we
make it for 5.8.
It would simply give me one more week to
> I think the following sequence needs to be implemented to make this
> safe, i.e., after 'synchronize_irq', no further slave interrupt will be
> fired.
>
> In 'bcm_iproc_i2c_unreg_slave':
>
> 1. Set an atomic variable 'unreg_slave' (I'm bad in names so please come
> up with a better name than
On Sun, Jun 28, 2020 at 01:52:45PM +0200, Wolfram Sang wrote:
> I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the
> SMBus 2.0 specs. I don't see a reason to add 1 here.
>
> Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")
> Si
On Sun, Jul 05, 2020 at 11:19:18PM +0200, Wolfram Sang wrote:
>
> > +- pinctrl
> > + add extra pinctrl to configure SCL/SDA pins to GPIO function for bus
> > + recovery, call it "gpio" or "recovery" state
>
> I think we should stick w
On Tue, Jun 09, 2020 at 03:15:55PM -0500, Eddie James wrote:
> Ports should be defined in the devicetree if they are to be enabled on
> the system.
>
> Signed-off-by: Eddie James
> Signed-off-by: Joel Stanley
Applied to for-next, thanks!
signature.asc
Description: PGP signature
):
i2c: drop duplicated word in the header file
Raviteja Narayanam (2):
Revert "i2c: cadence: Fix the hold bit setting"
i2c: cadence: Clear HOLD bit at correct time in Rx path
Wolfram Sang (1):
i2c: rcar: always clear ICSAR to avoid side effects
with much appreciat
> I can also take the i2c-tegra patches if preferred, but there too I need Acks.
> Dmitry, can you either take these i2c patches, or reply with Acks if you want
> me to take it?
There are some more patches for i2c-tegra pending, so I'd rather pick
them into my I2C tree once the Tegra maintainers
> + /* Enable partial slave HW PEC support if requested by the client */
> + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC);
> + if (iproc_i2c->en_s_pec)
> + dev_info(iproc_i2c->device, "Enable PEC\n");
Where do you set the I2C_CLIENT_PEC flag for the slave? Is
On Fri, Jul 17, 2020 at 02:31:54PM +0530, Rayagonda Kokatanur wrote:
> Add new event I2C_SLAVE_PEC_ERR to list of slave events.
> This event will be used by slave bus driver to indicate
> PEC error to slave client or backend driver.
>
> Signed-off-by: Rayagonda Kokatanur
Definately needs
> > If you want to resend, please only one patch for all I2C drivers. The
> > change is "cosmetic" enough to do that IMO.
> >
>
> The reason why I'm sending separate patches for this is because
> the drivers have different maintainers.
I see. Still, people can ack parts of a patch they are
On Wed, Jul 22, 2020 at 03:00:21PM -0700, Douglas Anderson wrote:
> When I have KASAN enabled on my kernel and I start stressing the
> touchscreen my system tends to hang. The touchscreen is one of the
> only things that does a lot of big i2c transfers and ends up hitting
> the DMA paths in the
> > > [1]
> > > https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> >
> > Perhaps you may do it as Link: tag?
> >
>
> mmh... that's a good suggestion; thanks, Andy.
If you want to resend, please only one patch for all I2C
> Sorry about that, lessons learnt.
I'll mark the I2C patches as RFC for me. If you resend them, please
mention if I should pick them or if the series shall go in via some
other tree.
signature.asc
Description: PGP signature
On Tue, Jul 14, 2020 at 03:18:39PM +0800, Frank Lee wrote:
> From: Yangtao Li
>
> Allwinner A100 have a mv64xxx i2c interface available to be used.
>
> Signed-off-by: Yangtao Li
> Reviewed-by: Rob Herring
Applied to for-next, thanks!
signature.asc
Description: PGP signature
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote:
> Drop doubled word "new".
>
> Signed-off-by: Randy Dunlap
For the record:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote:
> Drop doubled word "new".
>
> Signed-off-by: Randy Dunlap
For the record:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
___
dri-devel mai
On Fri, Jul 17, 2020 at 04:38:15PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap
>
> Drop the doubled word "be" in a comment.
>
> Signed-off-by: Randy Dunlap
> Cc: Wolfram Sang
> Cc: linux-...@vger.kernel.org
Applied to for-current, thanks!
signature.asc
Description: PGP signature
> > + synchronize_irq(iproc_i2c->irq);
>
> If one takes a look at the I2C slave ISR routine, there are places where
> IRQ can be re-enabled in the ISR itself. What happens after we mask all
> slave interrupt and when 'synchronize_irq' is called, which I suppose is
> meant to wait for inflight
On Fri, Jul 03, 2020 at 07:26:12PM +0530, Raviteja Narayanam wrote:
> There are few issues on Zynq SOC observed in the stress tests causing
> timeout errors. Even though all the data is received, timeout error
> is thrown. This is due to an IP bug in which the COMP bit in ISR is
> not set at end
On Fri, Jul 03, 2020 at 07:25:49PM +0530, Raviteja Narayanam wrote:
> This reverts commit d358def706880defa4c9e87381c5bf086a97d5f9.
>
> There are two issues with "i2c: cadence: Fix the hold bit setting" commit.
>
> 1. In case of combined message request from user space, when the HOLD
> bit is
On Wed, Jul 22, 2020 at 10:58:49AM +0200, Wolfram Sang wrote:
> On Thu, Jul 16, 2020 at 06:18:17PM +0100, Lad Prabhakar wrote:
> > Add PCIe{0,1} device nodes for R8A774E1 SoC.
> >
> > Signed-off-by: Lad Prabhakar
> > Reviewed-by: Marian-Cristian Rotariu
> >
701 - 800 of 16193 matches
Mail list logo
