[frameworks-ktexteditor] [Bug 435855] Selecting the whole text scrolls down document to the end

2021-05-04 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435855

Ahmad Samir  changed:

   What|Removed |Added

  Component|general |general
   Assignee|mon...@kde.org  |kwrite-bugs-n...@kde.org
Product|frameworks-ktextwidgets |frameworks-ktexteditor
Version|5.81.0  |unspecified
 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435309] 3b06b6f22 makes selection near invisible with some foreground/background color combinations

2021-05-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435309

--- Comment #21 from Ahmad Samir  ---
It looks like we'll either have to revert the whole change or add (yet) another
option to the settings dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syndication] [Bug 436288] Wrong indentation in pre-formatted html content (5.78 regression)

2021-05-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436288

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
A link to an affected feed would be nice to test with here :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[frameworks-syndication] [Bug 436288] Wrong indentation in pre-formatted html content (5.78 regression)

2021-05-01 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436288

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
A link to an affected feed would be nice to test with here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 393423] Scrollbar is invisible with non-Breeze widget styles

2021-04-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=393423

Ahmad Samir  changed:

   What|Removed |Added

Summary|"Use the terminal color |Scrollbar is invisible with
   |scheme for the scrollbar"   |non-Breeze widget styles
   |doesn't work with   |
   |non-Breeze widget styles;   |
   |consider making it optional |

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 393423] "Use the terminal color scheme for the scrollbar" doesn't work with non-Breeze widget styles; consider making it optional

2021-04-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=393423

Ahmad Samir  changed:

   What|Removed |Added

 CC||firew4l...@gmail.com

--- Comment #16 from Ahmad Samir  ---
*** Bug 436298 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 436298] Vertical Scrollbar is invisible

2021-04-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436298

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 393423 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 433512] Low contrast text selection background on some terminal background colors

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=433512

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #3 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 435309 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435309] 3b06b6f22 makes selection near invisible with some foreground/background color combinations

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435309

Ahmad Samir  changed:

   What|Removed |Added

 CC||noaha...@gmail.com

--- Comment #8 from Ahmad Samir  ---
*** Bug 433512 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 436170] LSP plugin auto-completion should follow "remove tail on complete" setting

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436170

--- Comment #4 from Ahmad Samir  ---
Mid-air comments collision :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 436170] LSP plugin auto-completion should follow "remove tail on complete" setting

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436170

--- Comment #3 from Ahmad Samir  ---
An example:
if (fileName.endsWith("foo")) {

}
Now if I put the cursor right before "fileName" and type "QStringV", and
auto-complete it to QStringView the text becomes:
if (QStringView.endsWith("foo")) {

whereas with "remove tail on complete" (in settings -> Editing ->
Auto-Completion) disabled I expect (and that's how it works without the LSP
completion, i.e. if I disable the LSP plugin):
if (QStringViewfileName.endsWith("foo")) {

(then I just type the opening '(' and go on ...etc.)

Does that make sense?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 436170] New: LSP plugin auto-completion should follow "remove tail on complete" setting

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436170

Bug ID: 436170
   Summary: LSP plugin auto-completion should follow "remove tail
on complete" setting
   Product: kate
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: kwrite-bugs-n...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: ---

It looks like when code auto-completion is done by the LSP plugin, it removes
the tail by default and there is no setting to change that. Maybe it should
follow the global setting in the auto-completion config dialog or have a
separate option?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 436169] The default font for Konsole is not monospaced

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436169

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED
 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
The built-in default font setting is:
QFontDatabase::systemFont(QFontDatabase::FixedFont)

so it's whatever the default Monospaced font on your system is. On my system
this returns the same font returned by:
fc-match monospace

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435309] 3b06b6f22 makes selection near invisible with some foreground/background color combinations

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435309

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #6 from Ahmad Samir  ---
Should be fixed by
https://invent.kde.org/utilities/konsole/-/merge_requests/380

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435309] 3b06b6f22 makes selection near invisible with some foreground/background color combinations

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435309

Ahmad Samir  changed:

   What|Removed |Added

 CC||firew4l...@gmail.com

--- Comment #5 from Ahmad Samir  ---
*** Bug 436154 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 436154] New text selection color scheme is is not clear on some screens

2021-04-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=436154

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 435309 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[bugs.kde.org] [Bug 435998] Missing favicon of bugs.kde.org

2021-04-24 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435998

--- Comment #2 from Ahmad Samir  ---
Thanks :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 416995] "Permissions" tab is not immediately updated after I change ownership via CLI

2021-04-24 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=416995

--- Comment #3 from Ahmad Samir  ---
Right, reading the steps to reproduce again I see it's a different issue; sorry
for the noise. :|

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431233] Fails to execute .sh shell script file that lacks a shebang

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431233

--- Comment #8 from Ahmad Samir  ---
(In reply to David from comment #6)
> Running 'sh file.sh' does not require a shebang. 
[...]
You run `sh file.sh` from terminal, using a shell, bash, zsh...etc; but
KProcess/QProcess doesn't know that, and without that info the system call
it'll use fails, IIUC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 430396] Runs many programs when executable confirmation settings are changed

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430396

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/7f81b92a3
   ||577fd318eef19f564206b8b0cc1
   ||cd05
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Ahmad Samir  ---
Git commit 7f81b92a3577fd318eef19f564206b8b0cc1cd05 by Ahmad Samir.
Committed on 21/04/2021 at 17:43.
Pushed by ahmadsamir into branch 'master'.

Make the openOrExecute dialog modal

It makes sense to make modal, and it goes with the general behaviour of dialogs
spawned by KIO jobs, e.g. RenameDialog and SkipDialog.

M  +1-0src/widgets/widgetsopenorexecutefilehandler.cpp

https://invent.kde.org/frameworks/kio/commit/7f81b92a3577fd318eef19f564206b8b0cc1cd05

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: Including instead of , does it upset POSIX?

2021-04-21 Thread Ahmad Samir

On 21/04/2021 15:34, Ahmad Samir wrote:

On 21/04/2021 15:20, Harald Sitter wrote:

To conclude this our verdict is to always use the modern headers?



I am re-checking the rest of the frameworks that failed the first time around; Albert already 
reported that it built for him locally with '#include '; I'll test again, push the changes 
and if the CI doesn't barf on any of it, then my conclusion is it's OK so far.




I've now pushed all those changes; only remains:

Deprecated:
kdelibs4support
kjs

kdesu/src/kdesu_stub.c: this stays since this is C code

these two files are generated by some tool, I left them be:
kholidays/src/parsers/plan2/holidayscannerplan.cpp
kholidays/src/parsers/plan2/holidayscannerplan.lpp


kinit/src/kdeinit/kinit_mac.mm: no idea about mac, can't test, so didn't change 
it
kinit/src/start_kdeinit/start_kdeinit.c: C code


They seemed to build fine on the CI.

--
Ahmad Samir


[frameworks-kio] [Bug 429541] [Regression] Can't create folders or files on ftp shares

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=429541

Ahmad Samir  changed:

   What|Removed |Added

 CC||j...@kdenlive.org

--- Comment #17 from Ahmad Samir  ---
*** Bug 432156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 432156] KNewFileMenu: cannot create new file for remote protocols like ftp

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432156

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 429541 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: Including instead of , does it upset POSIX?

2021-04-21 Thread Ahmad Samir

On 21/04/2021 15:20, Harald Sitter wrote:

To conclude this our verdict is to always use the modern headers?



I am re-checking the rest of the frameworks that failed the first time around; Albert already 
reported that it built for him locally with '#include '; I'll test again, push the changes 
and if the CI doesn't barf on any of it, then my conclusion is it's OK so far.


--
Ahmad Samir


[frameworks-kio] [Bug 431351] For files that don't fit in the trash, the user isn't provided with the option to delete immediately

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431351

Ahmad Samir  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||a.samir...@gmail.com

--- Comment #4 from Ahmad Samir  ---
Wouldn't showing two entries in Dolphin's context menu, one to move to trash
and another to delete permanently fix this issue? apparently "the press Shift
while the menu is open to show "Delete"" isn't readily obvious to new users.

-- 
You are receiving this mail because:
You are watching all bug changes.

[bugs.kde.org] [Bug 435998] New: Missing favicon of bugs.kde.org

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435998

Bug ID: 435998
   Summary: Missing favicon of bugs.kde.org
   Product: bugs.kde.org
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: sysad...@kde.org
  Reporter: a.samir...@gmail.com
CC: she...@kde.org
  Target Milestone: ---

>From Firefox's console:
[Exception... "Favicon at "https://www.kde.org/aether/media/16x16.svg; failed
to load: Not Found."  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS
frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 253" 
data: no]

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431233] Fails to execute .sh shell script file that lacks a shebang

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431233

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||fa...@kde.org

--- Comment #5 from Ahmad Samir  ---
I think this is not a bug, you should add a proper shebang to a shell script.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 430894] Confirmation prompt displayed every time a file is opened on a NextCloud webdav share

2021-04-21 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430894

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||vkra...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 430724] "Devices" section is missing from places panel while Gparted is running

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430724

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #6 from Ahmad Samir  ---
IIRC, gparted used to use systemctl to mask the devices .mount services to
prevent systemd from remounting them while gparted is running.

Run gparted from terminal and have a look at the output.

(I've tested again now, but I don't see the masking of the .mount services (or
whatever it's called), maybe gparted changed? I have gparted-1.2.0).

-- 
You are receiving this mail because:
You are watching all bug changes.

[baloo-widgets] [Bug 431771] "Details" tab is missing from Properties dialog of files on desktop

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431771

Ahmad Samir  changed:

   What|Removed |Added

Product|frameworks-baloo|baloo-widgets
  Component|general |general

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 431771] "Details" tab is missing from Properties dialog of files on desktop

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431771

Ahmad Samir  changed:

   What|Removed |Added

Product|frameworks-kio  |frameworks-baloo
 CC||a.samir...@gmail.com,
   ||baloo-bugs-n...@kde.org,
   ||n...@kde.org
  Component|Properties dialog   |general
   Assignee|kio-bugs-n...@kde.org   |stefan.bruens@rwth-aachen.d
   ||e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 432977] webdav:// "file or folder xxx doesn't exist

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432977

Ahmad Samir  changed:

   What|Removed |Added

 CC||vkra...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 433737] File-open dialogs do not follow per-folder sorting options set by Dolphin

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=433737

Ahmad Samir  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
They are two different apps, with two different functionalities...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 435744] kioclient5 exec should be able to open .desktop files without absolute path

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435744

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #2 from Ahmad Samir  ---
Closing, feel free to reopen if you disagree :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 435744] kioclient5 exec should be able to open .desktop files without absolute path

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435744

--- Comment #1 from Ahmad Samir  ---
I think for that functionality you can use kstart:
kstart5 --application org.kde.dolphin

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde-cli-tools] [Bug 435744] kioclient5 exec should be able to open .desktop files without absolute path

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435744

Ahmad Samir  changed:

   What|Removed |Added

   Assignee|kio-bugs-n...@kde.org   |aleix...@kde.org
  Component|general |general
 CC||a.samir...@gmail.com
Product|frameworks-kio  |kde-cli-tools

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 435376] Gwenview crashed in KIO::UDSEntry::UDSEntry() after viewing an image via MTP

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435376

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||fa...@kde.org

--- Comment #3 from Ahmad Samir  ---
This might not be the reason it's crashing, but in
ThumbnailProvider::slotResult I would move the removeSubjob() call to the end
of that method. It could be that the StatJob is removed and gets deleted before
statResult() is called.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 404777] KIO::CopyJob::setDefaultPermissions does not work

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=404777

Ahmad Samir  changed:

   What|Removed |Added

   Assignee|fa...@kde.org   |kio-bugs-n...@kde.org
   Priority|HI  |NOR
   Severity|critical|minor
 CC||a.samir...@gmail.com,
   ||fa...@kde.org

--- Comment #5 from Ahmad Samir  ---
I think the issue here is the interpretation of the docs[1]:
“By default the permissions of the copied files will be those of the source
files.

But when copying "template" files to "new" files, people prefer the umask to
apply, rather than the template's permissions. For that case, call
setDefaultPermissions(true)”

The code ends up going through FileProtocol::copy() which has:
// set final permissions
// if no special mode given, preserve the mode from the sourcefile
qDebug() << "_mode" << _mode;
if (_mode == -1) {
_mode = buff_src.st_mode;
}


What that means, is that if permissions are -1, which is what
setDefaultPermissions(true) does, no special permissions will be set, and the
permissions of the source are used.

I'll see if I can make the documentation more clear.

[1]
https://api.kde.org/frameworks/kio/html/classKIO_1_1CopyJob.html#a3bd4dda22a3bd50adf195542d9d009ad

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 407360] Allow searching for external user/groups when setting permissions/owners

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=407360

Ahmad Samir  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 416995] "Permissions" tab is not immediately updated after I change ownership via CLI

2021-04-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=416995

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/-/commit/0570624
   ||32b4b5cc4f4fa27990dcde60d3e
   ||afa758
 CC||a.samir...@gmail.com
   Version Fixed In||5.82

--- Comment #1 from Ahmad Samir  ---
This was fixed by
https://invent.kde.org/frameworks/kio/-/commit/057062432b4b5cc4f4fa27990dcde60d3eafa758

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 194017] Bad alignment of the progress bar on a file dialog still loading the file list

2021-04-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=194017

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/7b1997933
   ||d1013f8a2e8cfd8ebd8c277c562
   ||2613

--- Comment #9 from Ahmad Samir  ---
Git commit 7b1997933d1013f8a2e8cfd8ebd8c277c5622613 by Ahmad Samir.
Committed on 17/04/2021 at 11:01.
Pushed by ahmadsamir into branch 'master'.

KDirOperator: show the progress bar above the horizontal scrollbar

In compact view a horizontal scroll bar could be shown, adjust the position
of the progress bar in that case.

M  +27   -2src/filewidgets/kdiroperator.cpp

https://invent.kde.org/frameworks/kio/commit/7b1997933d1013f8a2e8cfd8ebd8c277c5622613

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435835] Konsole opens Vivaldi when opening a link or documentation from Help-menu - no other Term does and my default is set to FireFox

2021-04-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435835

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Check BrowserApplication= entry in ~/.config/kdeglobals (and/or
x-scheme-handler/http*= entries in ~/.config/mimeapps.list).

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: Including instead of , does it upset POSIX?

2021-04-15 Thread Ahmad Samir

On 15/04/2021 00:16, Albert Astals Cid wrote:

[...]


karchive/autotests/karchivetest.cpp:28:#include 
karchive/src/karchive.cpp:23:#include 


I changed those and it compiles just fine here.



kdesu/src/kdesu_stub.c:31:#include  (this is C code (guessing since I 
don't know C), so it
makes sense to leave that one in)


Yes, this is not C++


kholidays/src/parsers/plan2/holidayscannerplan.cpp:1313:# include 
kholidays/src/parsers/plan2/holidayscannerplan.lpp:17:# include 


This works too


kinit/src/kdeinit/kinit.cpp:24:#include 
kinit/src/kdeinit/kinit_mac.mm:25:#include 
kinit/src/kdeinit/kinit_win.cpp:15:#include 
kinit/src/klauncher/klauncher.cpp:21:#include 
kinit/src/start_kdeinit/start_kdeinit.c:12:#include 
kinit/src/wrapper.cpp:23:#include 


Same (obviously excluding start_kdeinit.c)



ktexteditor/src/buffer/katesecuretextbuffer.cpp:12:#include 
ktexteditor/src/buffer/katetextbuffer.cpp:20:#include 


Same.

Maybe your problem was that you tried to change C files?



I'll try again, maybe there is/was something in my build environment... no idea 
what though. :)

There was only a couple of .c files (I remember kdesu); but ktexteditor doesn't 
have an .c files.

Thanks for re-checking.


Cheers,
   Albert

  


--
Ahmad Samir


Re: Including instead of , does it upset POSIX?

2021-04-15 Thread Ahmad Samir



On 14/04/2021 22:20, Albert Astals Cid wrote:

El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure:

Hello :)

A week or so ago I created an MR to include  instead of  in 
KIO[1].

  From /usr/include/c++/10/cerrno:
/** @file cerrno
   *  This is a Standard C++ Library file.  You should @c \#include this file
   *  in your programs, rather than any of the @a *.h implementation files.
   *
   *  This is the C++ version of the Standard C Library header @c errno.h,
   *  and its contents are (mostly) the same as that header, but are all
   *  contained in the namespace @c std (except for names which are defined
   *  as macros in C).
   */


And then I made similar commits to a lot of the other Frameworks (not all, 
since the build failed
for some of them, so I left them alone).


I honestly didn't think this would be a problem, but you say the build of some 
of them failed, so i guess it is :D

Could you link to the particular MR's that failed?



I created one MR for KIO, once that was reviewed, I then applied similar patches to the other 
Frameworks directly.


Fortunately, it's easy to find which ones weren't changed, grep/rg; (I excluded frameworks that are 
going to be deprecated, kdelibs4support and kjs):


karchive/autotests/karchivetest.cpp:28:#include 
karchive/src/karchive.cpp:23:#include 

kdesu/src/kdesu_stub.c:31:#include  (this is C code (guessing since I don't know C), so it 
makes sense to leave that one in)


kholidays/src/parsers/plan2/holidayscannerplan.cpp:1313:# include 
kholidays/src/parsers/plan2/holidayscannerplan.lpp:17:# include 

kinit/src/kdeinit/kinit.cpp:24:#include 
kinit/src/kdeinit/kinit_mac.mm:25:#include 
kinit/src/kdeinit/kinit_win.cpp:15:#include 
kinit/src/klauncher/klauncher.cpp:21:#include 
kinit/src/start_kdeinit/start_kdeinit.c:12:#include 
kinit/src/wrapper.cpp:23:#include 

ktexteditor/src/buffer/katesecuretextbuffer.cpp:12:#include 
ktexteditor/src/buffer/katetextbuffer.cpp:20:#include 



Cheers,
   Albert




--
Ahmad Samir


[konsole] [Bug 435638] Killing nslookup in Konsole breaks font

2021-04-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435638

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #9 from Ahmad Samir  ---
Actually I have to press Ctrl+C twice to exit, or Ctrl+D (once).

It's not a Konsole bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

Including instead of , does it upset POSIX?

2021-04-14 Thread Ahmad Samir

Hello :)

A week or so ago I created an MR to include  instead of  in 
KIO[1].

From /usr/include/c++/10/cerrno:
/** @file cerrno
 *  This is a Standard C++ Library file.  You should @c \#include this file
 *  in your programs, rather than any of the @a *.h implementation files.
 *
 *  This is the C++ version of the Standard C Library header @c errno.h,
 *  and its contents are (mostly) the same as that header, but are all
 *  contained in the namespace @c std (except for names which are defined
 *  as macros in C).
 */


And then I made similar commits to a lot of the other Frameworks (not all, since the build failed 
for some of them, so I left them alone).


Harald Sitter asked me to raise the point here, basically he's wondering whether this change might 
cause issues, not being 100% POSIX compliant...etc; I'll quote him because he explained it much 
better than I would:


 ahmadsamir: 
https://invent.kde.org/frameworks/kcrash/-/commit/7a20755723dc1527edb7ed5c3fdcccdbcf7fa768 was this 
ever discussed anywhere? cause there are others like this and my thinking up until now was that 
using the C .h is more appropriate since we use them for POSIX APIs and from that POV the POSIX 
specified header is errno.h


[...]

 might be worth raising for discussion on the mailing list. with c++>=14 there's a whole 
mountain of "deprecated" headers OTOH I also recall reading that the c++ standard doesn't guarantee 
compatibility
 which may or may not be a concern when we use stuff specifically with the expectation that 
they will behave as documented from a POSIX or linux POV (such as signal safety in kcrash)



[1] https://invent.kde.org/frameworks/kio/-/merge_requests/397
--
Ahmad Samir


[konsole] [Bug 435675] File association is overriding http(s)/ftp links in konsole

2021-04-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435675

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #4 from Ahmad Samir  ---
I couldn't reproduce this issue.

Note that http/ftp links aren't supposed to go through FileFilterHotSpot at
all, since they're links, so UrlFilterHotspot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435638] Killing nslookup in Konsole breaks font

2021-04-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435638

--- Comment #5 from Ahmad Samir  ---
I tested and I don't get that behaviour. How do you end/exit nslookup?

I did:
$ nslookup
$ yahoo.com
it displays some info, I press Ctrl+C Ctrl+C or Ctrl+D (once) to exit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435638] Killing nslookup in Konsole breaks font

2021-04-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435638

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
I've just tested this and everything seemed to work.

Does it happen with one specific font or all monospace fonts?

-- 
You are receiving this mail because:
You are watching all bug changes.

Saturday, 2021-04-11 KF6 meeting notes

2021-04-11 Thread Ahmad Samir
Hello, we held the second ever KF6 weekly meeting yesterday, and here are the meeting notes, taken 
by Luigi Toscano (lightly proof-read by myself).



Investigate replacing KSelectAction with QActionGroup 
(<https://phabricator.kde.org/T12097> )

Moved back to backlog, because it (most likely) doesn't require any input. Nicolas Fella will check 
whether any work is really needed.




KGlobalAccel cleanup and improvement for desktop files 
(<https://phabricator.kde.org/T12063>)

A bit of recap:

* the original API has some issues (see the ticket)
* some time ago it was changed to accepte a desktop file with shortcut definitions, but the code is 
not trivial


The question is: should we support only the desktop file as a way to define the 
global shortcuts?

Probably fine for applications, it may not work for plasma or kwin, which have a lot of actions. A 
huge file with all actions would be needed. But in fact anything that can be installed can install a 
desktop file.


The discussion moved to some cross -framework dependencies (powerdevil uses kxmlgui to access 
shortcut stuff for example), and to the question on whether KGlobalAccel should be part of 
Frameworks or Plasma.


In short, KGlobalAccel is made of an API and a daemon.

The deamon is really Plasma-specific, but there are really no drawbacks of keeping that in 
Frameworks, as long as the code is fixed to never trigger it outside Plasma (not even through 
dbus-activation). Right now it can happen and it leads to bad interference with other DE's shortcuts 
API (e.g. GNOME).


The API can probably stay as it is. While the only implementation is on Plasma, it may stay with the 
current Windows/macOS code to allow people to easily compile it on those platforms without #ifdefs, 
and smart enough to disable for example the global shortcut creation integration in KXMLGui when 
running on other platforms.


Future contributors may decide whether a) revamp the platform-specific backends or b) create a new, 
really multiplatform API which would use KGlobalAccel as Plasma backend.




Create replacement for KPluginInfo::kcmServices 
(<https://phabricator.kde.org/T13555>)

The work is mostly done: a refactor of the way plugins and their KCMs are associated, with a direct 
link in the plugin definition instead of the complicated code which runs right now (and which relies 
on a deprecated classes).


The pending question is whether to allow each plugin to list multiple KCMs (which would cover some 
use cases, like Kontact plugins, even though those don't use this mechanism right now). After some 
discussion, it seems there is really no drawback on using a list of KCMs instead of a single KCM.



What we forgot to do is pick the tasks for discussion for the next meeting, so if you have 
suggestions please post them somewhere (on this ML would work best).


--
Ahmad Samir


[konsole] [Bug 435534] New Tab button shows two profiles while I only have one defined.

2021-04-10 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435534

--- Comment #4 from Ahmad Samir  ---
AFAIK, currently there is no way to hide the Default profile from menus ...etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 435534] New Tab button shows two profiles while I only have one defined.

2021-04-09 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=435534

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
The "Default" profile is the built-in/immutable/fallback profile; it can't be
modified, instead a new profile is created (which is a copy of the fallback
one); so, this is per design (we've had a plethora of bugs related to the
editing of the Default profile).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 143227] Konsole doesn't seem to support xterm's style titeInhibit option

2021-04-03 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=143227

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #5 from Ahmad Samir  ---
More workarounds:
With `less` you can use -X:
export LESS=$LESS-X
see the man page for details.

For vim:
http://vimdoc.sourceforge.net/htmldoc/term.html
https://www.shallowsky.com/linux/noaltscreen.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 422426] Implement Wayland Primary Selection Protocol bridge with XWayland

2021-03-30 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=422426

--- Comment #18 from Ahmad Samir  ---
(I haven't tested yet, but thanks for the fixes and for the heads up, both are
much appreciated o/ ).

-- 
You are receiving this mail because:
You are watching all bug changes.

Request for wide spread testing

2021-03-30 Thread Ahmad Samir

Hello.

Just to give this more visibility, there is a plan being contemplated to set evn var 
KDE_FORK_SLAVES=1 by default, see[1] for details.


So, if you can, please set KDE_FORK_SLAVES=1 in your env, and report any 
breakage.


[1] https://phabricator.kde.org/T12140


Thanks and have a good day.

--
Ahmad Samir


clang-format section added to the coding style guide

2021-03-29 Thread Ahmad Samir



Thanks to Alexander Lohnau, there is now a section in the KF coding style that explains about the 
usage of clang-format in the Frameworks:

https://community.kde.org/Policies/Frameworks_Coding_Style#Clang-format_automatic_code_formatting

including tips and tricks (mainly to trick clang-format so that it doesn't 
mangle your code)


Have a good day. :)

--
Ahmad Samir


[konsole] [Bug 434776] Backspace doesn't send characters based on the current terminfo entry

2021-03-24 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434776

Ahmad Samir  changed:

   What|Removed |Added

Summary|Konsole: backspace returns  |Backspace doesn't send
   |wrong value |characters based on the
   ||current terminfo entry

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 434776] Konsole: backspace returns wrong value

2021-03-23 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434776

--- Comment #7 from Ahmad Samir  ---
I would say this is by design, the details are explained in
https://invent.kde.org/utilities/konsole/-/blob/master/doc/user/README.keyboard

so Konsole doesn't follow the terminfo in this case, but offers an editor to
let the user change it easily.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kinit] [Bug 434455] kinit doesn't terminate "file.so" and the partition cannot be unmounted.

2021-03-23 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434455

Ahmad Samir  changed:

   What|Removed |Added

   Version Fixed In||5.81
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/-/commit/05e1090
   ||603ca81eb54a23febe41a8823a0
   ||e7d572

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kinit] [Bug 434455] kinit doesn't terminate "file.so" and the partition cannot be unmounted.

2021-03-23 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434455

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from Ahmad Samir  ---
https://invent.kde.org/frameworks/kio/-/merge_requests/378

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 434776] backspace returns wrong value

2021-03-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434776

--- Comment #3 from Ahmad Samir  ---
infocmp on my system shows:
#   Reconstructed via infocmp from file:
/usr/share/terminfo/x/xterm-256color
xterm-256color|xterm with 256 colors,

and:
kbs=^?



Ctrl+V then Backspace shows '^?'
Ctrl+V then Ctrl+Backspace shows '^H'
in Konsole, XTerm, and Gnome-terminal.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 434776] backspace returns wrong value

2021-03-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434776

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
Please check which key binding scheme is selected in "Edit current
profile"->Keyboard, "Default" should give the behaviour you want, i.e.
Backspace sends \x7f.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 434575] kdeinit crashes on screenshot previews (Segmentation fault)

2021-03-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434575

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Attachment #136817|text/vnd.kde.kcrash-report  |text/plain
  mime type||

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio-extras] [Bug 430862] Kde5init crashes in ThumbnailProtocol::get() every time I take a screenshot or start the computer

2021-03-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430862

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Attachment #136819|text/vnd.kde.kcrash-report  |text/plain
  mime type||

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430450] Profiles and realtime preview not working

2021-03-18 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430450

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #11 from Ahmad Samir  ---
@Wolfgang, was that an issue with the "Default" (the fallback/built-in)
profile? if so it should be fixed by
https://invent.kde.org/utilities/konsole/-/commit/5ab8423139467ad97d87d00dc82a85f91c5a1492

Closing, per comment#9, if there are still issues please create a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 434285] Panel Opacity setting isn't remembered

2021-03-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434285

Ahmad Samir  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 434285] New: Panel Opacity setting isn't remembered

2021-03-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434285

Bug ID: 434285
   Summary: Panel Opacity setting isn't remembered
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Panel
  Assignee: plasma-b...@kde.org
  Reporter: a.samir...@gmail.com
  Target Milestone: 1.0

If I change the panel "Opacity" setting to anything other than "Adaptive", the
setting is always reverted to Adaptive upon restart.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 434214] Cursor font is huge on startup with some fonts.

2021-03-10 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=434214

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
Does it happen with other fonts?

Also by cursor font you mean the cursor rectangle or ...?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 415067] Plasma crashes in KIO::DropJob::setApplicationActions() when dragging and dropping something from Chrome to the desktop

2021-02-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=415067

--- Comment #9 from Ahmad Samir  ---
I couldn't reproduce this issue; here is what I tried, in chromium, dragged
some file from a random git repo and dropped it on the desktop then selected
"link here". I tried with both "folder view" and "desktop containment".

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 380518] Konsole does not create profiles by default

2021-02-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=380518

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||a.samir...@gmail.com

--- Comment #3 from Ahmad Samir  ---
Things have changed over the years, the current situation is:
- Profile name "Default" is reserved for the Default/fallback profile, which is
hardcoded and created by Konsole on the fly from C++ code, it can't be "edited"
per se, i.e. you can create a new profile based on it. When you run konsole and
there are no .profile files in e.g. ~/.local/share/konsole the Default profile
is used, and when you "edit current profile", it will let you change the
settings and will pick a name, e.g. Profile 1, when you try to save the
settings. The intention is that the "Default" profile will always be there,
hardcoded/immutable as a fallback profile.

- The Default profile now shows up in the context menus, you can switch to
it... etc

- There is a patch to make the Default profile show up in the Profile Manager
dialog, see bug 433210

- The UI won't let you create multiple profiles with the same name

*** This bug has been marked as a duplicate of bug 433210 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 433210] Konsole doesn't show the default profile in the list of profiles

2021-02-22 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=433210

Ahmad Samir  changed:

   What|Removed |Added

 CC||abrouw...@gmail.com

--- Comment #4 from Ahmad Samir  ---
*** Bug 380518 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 433210] Konsole doesn't show the default profile in the list of profiles

2021-02-20 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=433210

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
It is indeed confusing when the "Default" profile isn't listed; I am thinking
of showing it in the dialog and disabling the Edit button for it, i.e. you can
"set as default" or create a "New" profile based on the Default one but not
"edit" it, I'll how that goes and create a merge request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 433209] Konsole doesn't automatically re-wrap after resizing the terminal window

2021-02-19 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=433209

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #4 from Ahmad Samir  ---
@Carlos: could you please add which version it'll be fixed, in the "Version
Fixed In:" field?

Thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 432944] Dolphin crashes when repeatedly trying to read file from disk with I/O errors

2021-02-16 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432944

--- Comment #3 from Ahmad Samir  ---
This has been fixed in 5.79 (and I posted to the kde distros ML to notify
distro packagers about the patch fixing the bug).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431731] Apps crash in KIO::CopyJobPrivate::skip() while skipping files in the overwrite dialog

2021-02-16 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431731

Ahmad Samir  changed:

   What|Removed |Added

 CC||jens-bugs.kde.org@spamfreem
   ||ail.de

--- Comment #8 from Ahmad Samir  ---
*** Bug 432944 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 432944] Dolphin crashes when repeatedly trying to read file from disk with I/O errors

2021-02-16 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432944

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 431731 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432779] Konsole understands multiple dots as a file path

2021-02-15 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432779

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/ac0b5e
   ||f4a8ffe7ae92508c113f6eaabad
   ||d62e0e4
 Status|REPORTED|RESOLVED

--- Comment #2 from Ahmad Samir  ---
Git commit ac0b5ef4a8ffe7ae92508c113f6eaabadd62e0e4 by Ahmad Samir.
Committed on 15/02/2021 at 22:42.
Pushed by hindenburg into branch 'master'.

FileFilter: don't create a hotspot for ''

Only '.' and '..' could be valid hotspots, but '..' isn't. The
latter is used by some CLI tools to indicate progress ...etc.

To test, in any dir use `ls -a`, Ctrl + clicking '.' and '..' should
open the current dir and parent of the current dir respectively.

Type .. at the prompt, before it would get underlined, after no
hotspot will be created for it.

M  +6-0src/filterHotSpots/FileFilter.cpp

https://invent.kde.org/utilities/konsole/commit/ac0b5ef4a8ffe7ae92508c113f6eaabadd62e0e4

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432779] Konsole understands multiple dots as a file path

2021-02-15 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432779

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
https://invent.kde.org/utilities/konsole/-/merge_requests/342

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 411496] Scrollbar should only be shown if needed

2021-02-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=411496

Ahmad Samir  changed:

   What|Removed |Added

 CC||dodie...@gmail.com

--- Comment #3 from Ahmad Samir  ---
*** Bug 360718 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 360718] Add option to automatically hide scrollbar when not needed

2021-02-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=360718

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Ahmad Samir  ---


*** This bug has been marked as a duplicate of bug 411496 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432817] Autocompletion for brace expansion

2021-02-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432817

--- Comment #3 from Ahmad Samir  ---
No worries (we have all been beginners at some point :)).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 432817] Autocompletion for brace expansion

2021-02-11 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432817

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com
 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

--- Comment #1 from Ahmad Samir  ---
Konsole has nothing to do with shell completion, you should look at the shell
(bash, zhs...etc) you're using for that feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431731] Apps crash in KIO::CopyJobPrivate::skip() while skipping files in the overwrite dialog

2021-02-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431731

Ahmad Samir  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.79
  Latest Commit||https://invent.kde.org/fram
   ||eworks/kio/commit/a183dd0d1
   ||ee0659e5341c7cb4117df27edd6
   ||f125
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Ahmad Samir  ---
Git commit a183dd0d1ee0659e5341c7cb4117df27edd6f125 by Ahmad Samir.
Committed on 02/02/2021 at 09:37.
Pushed by dfaure into branch 'master'.

CopyJob: fix crash with skip/retry

The crash was happening because I was disconnecting the wrong signal in
the lambda connected to KIO::AskUserActionInterface::askUserSkipResult...
FIXED-IN: 5.79

M  +2-2src/core/copyjob.cpp

https://invent.kde.org/frameworks/kio/commit/a183dd0d1ee0659e5341c7cb4117df27edd6f125

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 431731] Apps crash in KIO::CopyJobPrivate::skip() while skipping files in the overwrite dialog

2021-02-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431731

--- Comment #5 from Ahmad Samir  ---
(In reply to seplexfake from comment #4)
> I have put some additional information to my bug report which was marked as
> a duplicate of this one. https://bugs.kde.org/show_bug.cgi?id=432309
> Mainly a very simple way to reproduce this issue (just 4 simple steps) and
> why it seems to crash (at least in my case).

Thanks for that, it gave more info/clues as to what was going south, (and
actually the test in the merge request uses something similar). :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 431739] Dolphin shown a dialog about permissions issue when I tried to move data and then crashed when I clicked on "Skip all" button

2021-02-02 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431739

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
(@Patrick: thanks for installing all the debuginfo packages and providing a
complete backtrace :)).

-- 
You are receiving this mail because:
You are watching all bug changes.

D27224: add Kongress icon

2021-01-31 Thread Ahmad Samir
ahmadsamir added a comment.


  Hello. FWIW, I would also close/abandon this diff :) (nice icon BTW).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27224

To: mbruchert, dkardarakos, #vdg, ndavis
Cc: ahmadsamir, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-26 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #10 from Ahmad Samir  ---
Thanks for the speedy solution, up and down stream :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-26 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #8 from Ahmad Samir  ---
I built clazy and all the tests passed; then I rebuilt and reinstalled the rpm
package, and now it works

The rpm changelog:
  * Sat Jan 09 2021 Aaron Puchert 
  - Update to version 11.0.1.
* This release contains bug-fixes for the LLVM 11.0.0 release.
  This release is API and ABI compatible with 11.0.0.

  * Mon Oct 19 2020 Aaron Puchert 
  - Update to version 11.0.0.
* For details, see the release notes:
- https://releases.llvm.org/11.0.0/docs/ReleaseNotes.html
[...]

apparently something broke between 11.0.0 and .1.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431695] Pasting \n does not work

2021-01-26 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431695

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #6 from Ahmad Samir  ---
I don't think this is specific to konsole; bash/readline has bracketed-paste,
if it's enabled the shell will behave the way you describe.

You can enable/disable bracketed-paste by editing /etc/inputrc and adding a
line:
set enable-bracketed-paste off

See:
https://www.gnu.org/software/bash/manual/bash.html#index-enable_002dbracketed_002dpaste
https://www.gnu.org/software/bash/manual/bash.html#Readline-Init-File-Syntax

(If you want the change to be in your user account only, you can also create a
~/.inputrc file:
$include /etc/inputrc
set enable-bracketed-paste off
)

Note that bash/readline in recent versions have enabled bracketed-paste by
default: https://lwn.net/Articles/839212/

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #6 from Ahmad Samir  ---
Created attachment 135187
  --> https://bugs.kde.org/attachment.cgi?id=135187=edit
cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #5 from Ahmad Samir  ---
Created attachment 135186
  --> https://bugs.kde.org/attachment.cgi?id=135186=edit
output of run_tests.py

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

--- Comment #3 from Ahmad Samir  ---
Opensuse tumbleweed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[clazy] [Bug 432078] Crash when building with 'ENABLE_CLAZY'

2021-01-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=432078

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

Re: Retiring

2021-01-17 Thread Ahmad Samir

On 13/01/2021 22:57, Christoph Feck wrote:

Hello developers,

my personal situation allows for much less time for KDE
related work, at least during the Corona times.

I would like to retire as soon as possible from these
responsibilities:
- bug triaging
- release service
- KIconTheme maintainer
- KPlotting maintainer
- KWidgetAddons maintainer

For bugzilla, I see many new and old contributors doing awesome
work with triaging, so departing here shouldn't be a big issue.
I hope someone can continue checking responses to NEEDINFO bugs
and REPORTED bugs that didn't get a reply within about two weeks.

Regarding the release service work, I have made sure the load
isn't all back to Albert. For future release work, Heiko Becker
volunteered to help, but maybe another hand would be awesome, too.

For the frameworks modules, I initially assumed each module
must have a separate maintainer, so I volunteered. Today I
see many modules still just community-maintained, and I hope
the community can take over maintainance. Not that I did any
relevant work here in the recent years...

I might eventually continue to prepare some patches, so please
keep all my accounts intact, but only de-list me as the maintainer.

Thank you,
Christoph



This is sad, but I guess life happens and things change and time constraints 
change too.

Thanks a lot for your work on KDE, you are the oldest bugzilla gate keeper, looking at all those 
reports (any ones you didn't have a look at? :D).


(Actually you gave my account elevated privileges when you saw me regularly commenting on bugs a 
couple of years ago, so thanks for that too, it was a very appreciated leg up :))


I wish you and yours the best and hope to still see you around; when time permits and there is an 
itchy bug that bothers you enough to warrant a patch to fix it :)



--
Ahmad Samir


[konsole] [Bug 431601] Ctrl-clicking on filenames with line numbers on the end from `grep` output has broken recently

2021-01-14 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431601

Ahmad Samir  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #3 from Ahmad Samir  ---
I think I see what the issue is (in the lovely world of mimetypes :)).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431496] Konsole commit 5cb2121751569d8fb1e478b10e5980be4abeaa9b: all files open in defined text editor

2021-01-13 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431496

--- Comment #6 from Ahmad Samir  ---
We are in the realm of colliding use-cases, on the one hand an .html text/html,
inherits text/plain, so if a user grep's for a string in a dir that contains
.html files with instances of that string, he'd get output like:
foo.html:20

now, if we exclude the text/html mime type the user will have the file opened
in web browser, and if we leave it, then the file will be opened by the
specified text editor at line 20.

Experimenting with this some more, it looks like you can right click a .html
file and select "open with " and ctrl + click to open it
in a text editor... which admittedly could be confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431496] Konsole commit 5cb2121751569d8fb1e478b10e5980be4abeaa9b: all files open in defined text editor

2021-01-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431496

Ahmad Samir  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/43c14e
   ||980141d66b5c21b6bdee12c67d3
   ||c4bf3f3
 Resolution|--- |FIXED

--- Comment #4 from Ahmad Samir  ---
Git commit 43c14e980141d66b5c21b6bdee12c67d3c4bf3f3 by Ahmad Samir.
Committed on 12/01/2021 at 16:27.
Pushed by hindenburg into branch 'master'.

FileFilterHotspot: check the mime type before opening with text editor

When activating a file filter hot spot, everything got opened with the text
editor specified in the profile settings, which is wrong e.g. with pdf or
png files. Check the mime type of the file path, based only on the extension
so as to keep things fast.

Also rename openWithSysDefaultEditor() to openWithSysDefaultApp(), which is
more accurate.

M  +12   -4src/filterHotSpots/FileFilterHotspot.cpp
M  +1-1src/filterHotSpots/FileFilterHotspot.h

https://invent.kde.org/utilities/konsole/commit/43c14e980141d66b5c21b6bdee12c67d3c4bf3f3

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431337] konsole Profile Visibility Can No Longer Be Controlled, and More Of Them Appear in Menus

2021-01-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431337

--- Comment #7 from Ahmad Samir  ---
Errr, typo, should be /usr.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431337] konsole Profile Visibility Can No Longer Be Controlled, and More Of Them Appear in Menus

2021-01-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431337

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #6 from Ahmad Samir  ---
IIRC read-only profiles, ones that are installed under /user, used to editable
in Konsole, and that was done by copying the .profile to
~/.local/share/konsole/, but that was a source of a lot of bugs.

Look at the colorscheme editor KCM, it doesn't allow editing the schemes
installed under /usr, you can however "copy" the scheme and save it under a
different name under ~/; Kate's revamped syntax highlighting config dialog, and
 Qt Creator syntax highlighting color schemes act the same way.

IMHO, we shouldn't go back to that.

Also the "Default" profile, which comes directly from the C++ code in Konsole,
should always be there as a fallback/pristine profile, you can create a new
profile based on it, but not modify it directly.

I don't know how this bug should be fixed... maybe distros should switch from
installing the profiles under /usr/share/konsole to putting them in
/etc/.skel/, then they're copied to the user's home, but that would mean that
existing users with existing home dirs won't have the "Root Shell", whatever
that profile does.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 431496] Konsole commit 5cb2121751569d8fb1e478b10e5980be4abeaa9b: all files open in defined text editor

2021-01-12 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=431496

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #1 from Ahmad Samir  ---
For now as a workaround, you can get the old behaviour back by setting the
"Text editor command" to "Custom" and leaving it empty (you can edit the the
custom entry); it's in "Edit current profile" > Mouse > Miscellaneous.

-- 
You are receiving this mail because:
You are watching all bug changes.

<    5   6   7   8   9   10   11   12   13   14   >