[Kicad-developers] [PATCH] Init OPENGL_GAL currentTarget

Hi, This patch initialises a class member in OPENGL_GAL. It uses the SetTarget function to make sure the target and manager initialise in a consistent way. Cheers, John From f9a0fc626f78337165595f18f4dca73afa11a9af Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Dat

[Kicad-developers] [PATCH] Allow editing locked modules in modedit

). Fixes: LP 1591625 https://bugs.launchpad.net/kicad/+bug/1591625 From 317510c194c8e8c3829abb4cdabbeab773b087bc Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 01:32:45 +0800 Subject: [PATCH] Allow editing locked modules in modedit Since you have to expl

[Kicad-developers] [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME

-recompile for anyone pulling both at once! Cheers, John From f8c76db985a90fbf5e209317e04011028b95e4de Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Tue, 17 Jan 2017 13:57:53 +0800 Subject: [PATCH] Move PostCommandMenuEvent to EDA_BASE_FRAME There is nothing PCB

[Kicad-developers] Fwd: [PATCH] C++14-style std::make_unique for C++11

FWD to list -- Forwarded message -- From: John Beard <john.j.be...@gmail.com> Date: Mon, Jan 23, 2017 at 8:36 AM Subject: Re: [Kicad-developers] [PATCH] C++14-style std::make_unique for C++11 To: Wayne Stambaugh <stambau...@gmail.com> The idea with std:

[Kicad-developers] [PATCH] Tidy consts in D_PAD

t are part of a larger inheriance hierarchy. Cheers, John From 4f726e83fb44f5057a28b05777bfef5613b3fbf9 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 04:19:46 +0800 Subject: [PATCH 1/2] Tidy consts for class D_PAD Some accessors should be con

[Kicad-developers] [PATCH] C++14-style std::make_unique for C++11

ay moves on to C++14, this file can be removed entirely and forgetten! Cheers, John From 5762fed4ae255612d244f5ab51c88c6b3c31fde4 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sun, 22 Jan 2017 00:03:01 +0800 Subject: [PATCH] Add C++14-style std::make_unique 'polyfill' f

Re: [Kicad-developers] [PATCH] Signal handlers for SINGLE_TOP and KICAD

And here is the patch with the class name in capitals and a class comment block. Sorry! On Wed, Jan 11, 2017 at 11:26 PM, John Beard <john.j.be...@gmail.com> wrote: > Hi, > > None of the KiCad programs appear to implement any signal handlers. > This means that some of them (

[Kicad-developers] [PATCH] Signal handlers for SINGLE_TOP and KICAD

Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Wed, 11 Jan 2017 22:48:57 +0800 Subject: [PATCH] Signal handlers for Kicad and Single-Top programs This allows Kicad programs to be terminated with Ctrl-C (or SIGINT in general) and still execute the correct shutodwn pro

Re: [Kicad-developers] -Wsuggest-override with scripting enabled

On Thu, Oct 6, 2016 at 7:10 AM, jp charras wrote: > > It works for me, but I had to modify the patch > the change in pcbnew/CMakeLists.txt is > if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE ) > set_source_files_properties(pcbnew_wrap.cxx pcbnewPYTHON_wrap.cxx >

[Kicad-developers] -Wsuggest-override with scripting enabled

for all other files. Second patch is an override opportunity which was previously silenced by the blanket disabling of the warning. Thanks, John From 177fad07745c99a6adfb1fee76e235fc1a443234 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Wed, 5 Oct 2016 13:34:04

Re: [Kicad-developers] Parse error in one symbol lib prevents subsequent libs loading

y a message after all of > the libraries are loaded. This way the user will always see the > failure(s) and subsequent libraries will still be loaded in case of a > failure. > > Thanks, > > Wayne > > On 9/23/2016 2:26 PM, John Beard wrote: >> Hi, >> >> If a sy

[Kicad-developers] Parse error in one symbol lib prevents subsequent libs loading

the user can still see the problem, but can elect to proceed (or break in their debugger) and load the remaining symbol libs. Thanks, John From 63f3f172b3b34875e1e9205078b6e44ff3edb597 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Sat, 24 Sep 2016 02:15:41 +0800 S

[Kicad-developers] Possibility of uninitialised variable in RN_DATA::Add

t's been set to something valid so the vector can be safely indexed. I also added an assert to document that all paths (i.e. first if statement) must correctly lengthen the vector if needed. Cheers, John From 5f2a8bcfdc3e5e7a9c99545491ba73592ec834b6 Mon Sep 17 00:00:00 2001 From: John Beard <joh

Re: [Kicad-developers] Git transition

I understand that many people will be using the Bzr UI tools, but Git is very good at enabling digging in the history using the command line. I have a handy Git alias which shows me a condensed version of the history (it's actually coloured in my terminal, so it's really clear what's going on):

[Kicad-developers] [PATCH] .gitconfig syntax, missing '='

git config --local include.path ../.gitconfig Cheers, John From 53b2afd692ecaab9757b5b0698dad09e624502bc Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 8 Aug 2016 11:03:04 +0800 Subject: [PATCH] Fix .gitconfig syntax --- .gitconfig | 2 +- 1 file changed, 1

[Kicad-developers] Array tool patches

canvasses (decouples the array tool from the actual canvas implementation) * Improved error reporting when bad parameters are detected. Thanks, John >From 15d935aa90757b69ab332919358fde1049b06992 Mon Sep 17 00:00:00 2001 From: John Beard <john.j.be...@gmail.com> Date: Mon, 21 Mar 2016 07:25

[Kicad-developers] Array tool patches

. The third patch refactors some of the array code to make reuse easier for any future array tools and adds a few general tidy-ups. Thank you, John From 61e09b33ec7d1edcd14a49eed45655c264b98952 Mon Sep 17 00:00:00 2001 From: John Beard john.j.be...@gmail.com Date: Thu, 9 Jul 2015 23:36:12 +0100 Subject

Re: [Kicad-developers] Feature Request: ViaStiching

Hi, The array tool should make rudimentary stitching possible - just create a grid of the via you want to duplicate and remove any that aren't in the area you want. It's a fully manual process, but it seems to interact sensibly with zones at least - see the attached screenshot for the behaviour

[Bug 1429230] Re: Aegisub causes X-server to crash

I see exactly the same issue in 3.2.2 (using the stable PPA). The crash log is the same (only the addresses are different). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1429230 Title: Aegisub

[Kicad-developers] [PATCH] Re: Icons needed

Hi all, I have made a few modifications to the icons (mostly pixel alignment at 26px) and added them to the relevant CMake file and header. They are now used in the pcbnew menus. Balint should still get credit for the icons - I just tweaked them! Are there other places these icons can/should be

[Kicad-developers] [PATCH] Fix for broken callback in diff pair dimensions dialog

The callback for the checkbox in the Differential Pair Dimensions dialog is broken due to function name mismatch (on... vs On...). Because the function is impure virtual and we can't mark the overrider with override due to the compiler type, the different spelling didn't cause a compile time

[Kicad-developers] [PATCH] Fix for cancellation of duplicate in GAL mode

I have noticed a quirk when cancelling a duplicate in modedit under GAL. The duplicated item would be left in the same place as the original rather than being deleted. This was caused by not handling the creation of the undo point correctly in modedit (the analogous case was already handled in

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

. I noticed that the MD_CTRL + 'E' is not MD_CTRL + int( 'E' ) like the other shortcuts, but changing this didn't seem to work either. Cheers, John On Fri, 2015-01-23 at 10:43 +0100, Tomasz Wlostowski wrote: On 02.12.2014 22:16, John Beard wrote: On Mon, 2014-12-01 at 13:22 -0500, Wayne

Re: [Kicad-developers] cmake errors wxWidgets

On Tue, 2015-02-10 at 01:11 -0600, inkblotter wrote: I'll try again to find someone who understands the ins and out of cmake enough to steer me to some solution that make sense. Below you will see what happens on Fedora always with kicad cmake and wxWidgets. CMake Error at

Re: [Kicad-developers] documentation format

On Wed, 2015-02-04 at 01:31 +, John Beard wrote: On Tue, 2015-02-03 at 19:14 -0500, Wayne Stambaugh wrote: I think the availability of tools on those platforms is actually not of huge significance. The worst case is that the docs are built for every commit by something like Jenkins

Re: [Kicad-developers] documentation format

On Tue, 2015-02-03 at 19:14 -0500, Wayne Stambaugh wrote: On 2/3/2015 6:55 PM, Cirilo Bernardo wrote: It has been some time since Marco has done an evaluation of document format alternatives. Has any decision been made yet about what format we shall use, or are there still some other

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

On Sun, 2014-12-07 at 21:54 +, John Beard wrote: Here is an amended patch, where Ctrl-E over an item in either legacy or GAL will launch the footprint editor. A single selection works as before. That patch no longer applies, please find attached a new patch for the current product tip

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit (now with arrays)

On Fri, 2014-12-05 at 22:02 +, John Beard wrote: The move exact and duplicate tools are now supplemented by an array tool which allows creation of grid, staggered grid and circular arrays of pads, lines or text within modedit. It is available in both legacy and GAL modes, but blocks can only

[Kicad-developers] Uncrustify case indentation rules

Hi, Is the policy for braced case indentation as follows? case SOMETHING: { int i = 0; break; } This seems to be the case for tidying-up commits like r5288, but the uncrustify.cfg rules call for: case SOMETHING: { int i = 0; break; } If this is in fact

Re: [Kicad-developers] The library tables wizard

On Wed, 2015-01-07 at 23:38 +0100, Miguel Ángel Ajo wrote: Hi Jean Pierre, just an idea for your wizard work: https://api.github.com/orgs/KiCad/repos You could save the need to work with the HTML viewer and pagination problems using the above API endpoint, all the KiCad project

Re: [Kicad-developers] Modifier keys for hotkeys

On Thu, Dec 18, 2014 at 6:58 PM, jp charras jp.char...@wanadoo.fr wrote: Le 15/12/2014 20:26, John Beard a écrit : On Sun, 2014-12-14 at 20:04 +0100, jp charras wrote: Le 14/12/2014 03:02, John Beard a écrit : I'm trying to get a hotkey defined as Ctrl-Shift-D. Currently, I can make it work

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

On Sat, 2014-12-06 at 15:37 -0500, Wayne Stambaugh wrote: This still doesn't work correctly unless the footprint is already the current item selected. It behaves the same in both the GAL and legacy rendering modes. You should not have to select an item first to make a hot keys work. Try

[Kicad-developers] [PATCH/RFC] Transfer user settings to child frames

Attached is a patch to import settings from a parent frame to child frames. This is in response to a bug reported in IRC that the warp-on-zoom behaviour in pcbnew was not being transferred to modedit. This patch provides a generic way of importing settings from a wxWindow parent in impure virtual

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit

On Sun, 2014-11-16 at 10:33 -0500, Wayne Stambaugh wrote: Thanks. I'll test this as soon as I get a chance. It would also be worthwhile to port any new features added to the legacy rendering to the new OpenGL/Cairo rendering using the new tool framework. I think its a good idea at this

Re: [Kicad-developers] Haskell Library (SVG drawing)

/plugins/bezier_converter.py @@ -0,0 +1,339 @@ + +Copyright 2014 (C) John Beard, john.j.be...@gmail.com +based on gcode_tools.py (C) 2009 Nick Drobchenko, n...@cnc-club.ru +based on gcode.py (C) 2007 hugomatic... +based on addnodes.py (C) 2005,2007 Aaron Spike, aa...@ekips.org +based on dots.py (C) 2005

Re: [Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

On Mon, 2014-12-01 at 13:22 -0500, Wayne Stambaugh wrote: Hi John, Sorry it took so long to try out this patch but I've been busy. I found a segfault on the first attempt to use Ctrl-E when no previous item has been selected. D'oh, what a clanger! Once you fix this issue, I'll commit

[Kicad-developers] [PATCH] Handle empty string in cvpcb GetModuleInfo()

Hi, Here is a tiny patch to defend against asserts in debug mode when the footprint list in cvpcb is empty. The aFootprintName was coming in as in that case. You could also check for an empty string at the call sites, but since this function already can return null (and thus callers should be

Re: [Kicad-developers] [PATCH/RFC] Move exactly and duplicate in modedit

On 15/11/14 15:32, Wayne Stambaugh wrote: I just commented on Cirilo's request and the same hold true for your change as well. Please push the branch with these changes to launchpad and submit a merge request. Since this is a new feature and we are trying to work towards a stable release, I

[Kicad-developers] [PATCH] Hotkey for editing module with module editor (Ctrl-E)

Hi all, Here is a little patch for adding a hotkey to edit a module with the module editor. It defaults to Ctrl-E. At least this makes it a little easier to develop for modedit, as you now don't need to click into the menu to get there! Thanks, John diff --git a/pcbnew/hotkeys.cpp

[Kicad-developers] [PATCH] Info panel for DRAWSEGMENTs in the module editor

about the angle display - I used an anti-clockwise from 3-o'clock convention, rather than a compass-like clockwise from 12-o'clock. Also, I don't know what each of the colours signifies, so I went with DARKGREEN. Thanks, John commit 8cd6097275c41afa237f92fc81c6f8c7dbb1a456 Author: John Beard

[Kicad-developers] [PATCH] Minor tweaks for the eeschema component chooser, especially for aliases.

Hello, Attached is a small patch that does a few things in the eeschema component chooser: * Shows aliases' names, rather than the root device names in the preview window * Doesn't paint the background if nothing is selected * Add the component name as a heading in the

[Kicad-developers] [PATCH] Use the main workspace background in component chooser/browser dialogues

Hi, Here is a small patch to make the component chooser dialogue and the library browser dialogue use the main workspace background colour (white or black, as configured) instead of white, which otherwise looks inconsistent when the main workspace is black. Because DIALOG_CHOOSE_COMPONENT and

[Kicad-developers] PATCH: Footprint wizard helpers

Hi, I have a patch (fpw-overhaul.diff) for the Python footprint wizard helpers. This adds a few more drawing functions, such as for circles, and also uses a matrix-based transform stack with greatly simplifies constructing footprints consisting of regularly spaced elements (e.g. in lines, grids,

[Kicad-developers] Use of std::vectorwxPoint in Python

Hi, I am trying to get fp_poly working in the footprint wizards. It seems that I should be using pcbnew.DRAWSEGMENT.SetPolyPoints(), which takes a std::vectorwxPoint as an argument. I tried to feed it a Python list of wxPoints, but it couldn't handle that: File

[Kicad-developers] Footprint wizard changes

Hi, I have made some changes to the helpers for the footprint wizards. There is now a matrix-based transform stack that helps simplify calculations that footprint wizards need to do. The patch attached is based on BZR rev 4975. There are also some tests in the pcbnew/scripting/tests directory

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

On 13/06/14 19:36, Lorenzo Marcantonio wrote: On Fri, Jun 13, 2014 at 06:46:37PM +0100, John Beard wrote: The silk screen is put so it can be seen after soldering. The ASCII art arrow is an assembly layer feature, modelled after the IPC standard. Sorry my fault. I was thinking was a fancy

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

On 13/06/14 20:44, Lorenzo Marcantonio wrote: On Fri, Jun 13, 2014 at 08:33:02PM +0100, John Beard wrote: OK, I won't worry too much about it and get one with making more footprints! Are there any more things you'd like to see changed? No matter how tiny! These are already *way* nicer than

Re: [Kicad-developers] [Kicad-lib-committers] Silk screens over pads and naming

On 13/06/14 21:23, Nick Østergaard wrote: I like the 3D view very much, even the old simple one is great for verifying tracks. I often find things I want to change when looking at the 3D view of just the traces and silk. I agree, I think it's having an alaternative perspective. A bit like

Re: [Kicad-lib-committers] Silk screens over pads and naming

On 03/06/14 07:42, Lorenzo Marcantonio wrote: Seems a good starting point to me. Also advanced fabrication requires often custom-made modules anyway. How about this for an example of how the SMD headers would look? I haven't added the dot/arrow yet, but it basically uses the line extension at

Re: [Kicad-lib-committers] Silk screens over pads and naming

On 02/06/14 20:18, Lorenzo Marcantonio wrote: On Mon, Jun 02, 2014 at 07:34:12PM +0100, John Beard wrote: What is the cost of the yellow layer? The 'cost' of the fabrication layer is simply the full component outline (99% of the times a rectangle) and a corner line for pin 1. But it's

Re: [Kicad-lib-committers] Silk screens over pads and naming

On 01/06/14 20:01, Lorenzo Marcantonio wrote: On Sun, Jun 01, 2014 at 06:08:32PM +0100, John Beard wrote: OK, so what I did so far (with a fancy silk) is not really what we are after? Never said so. Probably we never decided the standard for silks :P No time like the present. Any opinions

[Kicad-lib-committers] Silk screens over pads and naming

I'm working on the THT Right-Angle Molex Picoblade headers. I have a question about the silk screen. If you look at the datasheet, the line of the body intersects the pins along the back edge. What should I do about the silkscreen in this case? Artificially extend it away from the pads (in which

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 08/05/14 20:44, Dick Hollenbeck wrote: On 05/08/2014 02:18 PM, Dick Hollenbeck wrote: On 05/08/2014 01:31 PM, John Beard wrote: On 08/05/14 15:53, Dick Hollenbeck wrote: Submit a patch. Hope it gets accepted. Since your interest is limited to the *.kicad_mod file. You can use

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 08/05/14 15:53, Dick Hollenbeck wrote: That's exactly what I mean - older versions of KiCad should be able to ignore, but retain, unknown data. This sentence has two concepts in it. One is fools gold, the other is poorly expressed. 1) An older kicad should load a data file that is

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 07/05/14 07:19, Lorenzo Marcantonio wrote: On Wed, May 07, 2014 at 12:48:22AM +0100, John Beard wrote: I would have thought this would exactly be done at the end of tokenisation More or less, that's the idea :D There are various ways to do this but all depends on the flexibility

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 08/05/14 20:12, Lorenzo Marcantonio wrote: On Thu, May 08, 2014 at 07:31:47PM +0100, John Beard wrote: it will show you what it can. You'd be annoyed if it didn't, it would be like Flash needing the latest version to watch your video, without the excuse that is necessary to implement

[Kicad-developers] Forward-compatibility in s-expression formats

I think it would be a good idea to allow unknown fields in the s-expression formats so that an older KiCad doesn't choke on things it doesn't understand, and doesn't need to. For example, I was thinking that it might be helpful to add a field to the footprint format: part_reference, which would

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 06/05/14 21:47, Jean-Paul Louis wrote: Why not collect all the field of any part being loaded, and consider all the fields that are not known as “user defined fields”? In future you may want you use a word for a new field, and you don't really want to stomp on some poor sap who thought he

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 06/05/14 23:18, Tomasz Wlostowski wrote: How about about adding a generic attribute set for each part, stored as a list of type-name-value entries: (part xxx (attribute simulation_model (string .cir) ) (attribute part_reference_farnell (int 123456 ) ) ) Such scheme would not

Re: [Kicad-developers] Forward-compatibility in s-expression formats

On 06/05/14 21:47, Lorenzo Marcantonio wrote: That said, I think that *if* the sexp reader can traverse automatically a generic sexp (without having a grammar, only tokenising) we could decide that it could 'skip' each subexpression starting with an unknown token. Maybe with warnings:D I

Re: [Kicad-developers] [PATCH] IPC-7351 Footprint wizard

On 27/04/14 20:18, Francesco Del Degan wrote: Yes, I will try to reuse the helper classes that was committed few days ago, and fix some issues with it. (I just discovered that actual BGA footprint uses all 26 letters, but only ABCDEFGHJKLMNPRTUVWY should be allowed) . My bad, thanks for

Re: [avr-libc-dev] SPMCR poisoning workaround for ATmega128

On 30/05/13 16:22, Weddington, Eric wrote: Hi John, Since this will be on your local installation, there's really no right or wrong way to do it. Like you said, if you toggle the *DEPRECATED_ENABLE identifier, then it unpoisons everything else; you may not want to do that. If you remove

[avr-libc-dev] SPMCR poisoning workaround for ATmega128

Hi, I have run in bug #36410 while trying to compile for a mega128: In file included from main.c:13:0: /usr/lib/gcc/avr/4.7.0/../../../avr/include/avr/boot.h:112:16: error: attempt to use poisoned SPMCR The poisoning is in iom128.h, line 1246: #pragma GCC poison SPMCR I know

Userspace access to PCIe - SATA device memory BAR

Hi, I have a PCIe - SATA bridge device, and I would like to access the I2C control registers in the PCI memory region (BAR5) - these use just two addresses in the BAR. I have tried, in userspace, to mmap() the /sys/bus/pci/devices//resource5 file and read from that, but all I get is 0xFF in

Re: Block device driver: how to terminate the block device if media disappears?

On 21/12/12 18:23, Ezequiel Garcia wrote: On Thu, Dec 13, 2012 at 12:31 PM, John Beard jo...@codexdigital.com wrote: What is the right way to terminate requests and delete the gendisk in the case of physically vanished PCI devices (or even devices in general)? There are several block

<    1   2   3   4   5