[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461412#comment-17461412
 ] 

Pierre Smits commented on OFBIZ-12450:
--

Additional observations:
 * function 'makeProducePriceRuleList' is used in function 
'calculateProductPrice'
 * function 'calculateProductPrice' is used in 
 ** service 'calculateProductPrice' in services_pricePromo.xml
 * service 'calculateProductPrice' is used in the ecommerce component in:
 ** MiniProductSummary.groovy
 ** EditShoppingList.groovy

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461402#comment-17461402
 ] 

Pierre Smits commented on OFBIZ-12466:
--

Hi Jacques,

Thanks for the reaction.

Looking at [https://github.com/apache/solr/commits/main,] I see that yesterday 
the Sole team committed changes to the repo regarding 8.11.1. So we just have 
to monitor that repo (and maven central ?) to see that changes come through. 

I guess, the combo of Lucene and Solr extensions in the plugins repo makes this 
harder for us. Correct?

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardC

[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461395#comment-17461395
 ] 

Pierre Smits commented on OFBIZ-12450:
--

There is also a 'getAssociatedPriceRulesConds' in PriceServices.groovy that 
does something with a price rule for the aforementioned conditions.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Comment Edited] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461321#comment-17461321
 ] 

Pierre Smits edited comment on OFBIZ-12450 at 12/17/21, 12:03 PM:
--

Price calculations working with price rules is done through PriceServices.java 
in function makeProducePriceRuleList

According to the code price calculations should work for following conditions 
(as referenced in the description):
 * Product Category (productCateogryId
 * Product Id (both productId and pvirtualProductId)
 * Party (partyId)

And there are others referenced (based on records in the Enumeration table with 
enumTypeId="PROD_PRICE_IN_PARAM")


was (Author: pfm.smits):
Price calculations working with price rules is done through PriceServices.java

According to the code price calculations should work for following conditions 
(as referenced in the description):
 * Product Category (productCateogryId
 * Product Id (both productId and pvirtualProductId)
 * Party (partyId)

And there are others referenced (based on records in the Enumeration table with 
enumTypeId="PROD_PRICE_IN_PARAM")

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>    Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12450:
-
Description: 
When adding a Price Rule, whether it be a Product Category, Product, Party, 
Party Classification, the system doesn't show a price difference.

The price rules work with the Database as they do get changed when saved. But 
their functionality doesn't work, it won't give a price increase or decrease or 
restriction.

  was:
When adding a Price Rule, whether it be a Product Category, Product, Party, 
Party Classification, the system doesn't show a price difference.

 

The price rules work with the Database as they do get changed when saved. But 
their functionality doesn't work, it won't give a price increase or decrease or 
restriction.


> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461385#comment-17461385
 ] 

Pierre Smits commented on OFBIZ-12450:
--

Is a bit hard to demonstrate without proper data in our datasets.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12466:


 Summary: Solr generates an error
 Key: OFBIZ-12466
 URL: https://issues.apache.org/jira/browse/OFBIZ-12466
 Project: OFBiz
  Issue Type: Bug
  Components: solr
Affects Versions: Trunk
Reporter: Pierre Smits


Following error is shown:
{code:java}
2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
|E| Could not start Solr. Check solr/home property and the logs
2021-12-17 12:45:37,707 |main                 |SolrCore                      
|E| null:java.lang.NoClassDefFoundError: Could not initialize class 
org.slf4j.impl.StaticLoggerBinder
at 
org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
at 
org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
at 
org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
at 
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
at 
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
at 
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
at 
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
at 
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
at 
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
at 
org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at org.apache.ofbiz.base.start.Start.main(Start.java:89)


Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
SEVERE: Exception starting filter [SolrFilter]
java.lang.NoClassDefFoundError: Could not initialize class 
org.slf4j.impl.StaticLoggerBinder
at 
org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
at 
org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
at 
org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
at 
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
at 
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
at 
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
at 
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256

[jira] [Commented] (OFBIZ-12459) Cybersource - configuration

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461369#comment-17461369
 ] 

Pierre Smits commented on OFBIZ-12459:
--

[~mbrohl] 

Switching over to using SystemProperty records for runtime configuration is an 
ongoing effort since it was introduced way back when in 2012, effected by 
contributors of all kinds. Never before somewhere in 2018, in your 20 years of 
history with OFBiz (or even the 15 years of this project being part of the ASF) 
have you 'collaborated' on this subject. And even when you started providing 
comments/suggestions to the subject, you couldn't convince the community to 
change directions.

Here, elsewhere, you keep circling back, or referring to creating a mess for 
users. But the thing is that by insisting (like you do) on not moving forward 
you perpetuate the mess. Not only regarding this aspects, but others as well. 

A while back I advised you to read the header of OFBiz code files. Apparently 
you did not learn anything from those files, still thinking that the project 
must ensure any kind of compatibility.
You claim to know what OFBiz users want/need from the project. I suggest you 
wake up. You're no OFBiz user! And what you know about what OFBiz users 
wanted/needed is from the limited few that paid you regarding the 
implementations you worked on. 

You talk about destroying trust? You made me both cringe and laugh when you 
mentioned that.  In an other ticket discussion, you insist on not improving 
just that trust by rejecting that fields like createdByUserLogin and 
modifiedByUserLogin should be part of the metadata fields automatically added 
and populated. Fields that are included in every piece of serious software 
(like SalesForce, Microsoft Dynamics 365, SAP, etc.).

If you're so dissatisfied about the direction of the project, I suggest you 
follow the route other (privileged) contributors embarked on and start working 
on and  promoting your own derivative. 
And, if you're dissatisfied with how contributors react to your kind of 
collaboration I suggest you take a hard look at your own actions and [those 
tickets | 
https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20assignee%20in%20(mbrohl)%20ORDER%20BY%20updated%20DESC]
 you're 'collaborating on'.

I appreciate suggestions, but nowhere is it stated that any other contributor 
(or I) *must* follow that, or adhere your kind of collaboration, blindly.
I object to your kind of collaboration. I reject your kind of collaboration. 
Your kind of collaboration moves (contributions to) the project to a grinding 
halt. You can't even seem to able to collaborate with the contributors from 
your own company to get their contributions to move the project forward.
I rather have you 'collaborate' similarly to the dozens of other privileged 
contributors than you injecting your unwanted kind of collaboration into 
tickets.

So you ask yourself what else can you do...
Here are a few suggestions (how you can adjust your kind of collaborating for 
the good of the project, its users and its contributors):
 * go 'collaborate' with someone else, and stop stalking me,
 * go take any of the tickets you have assigned yourself to and work those to a 
satisfactory resolution, instead of 'managing' the status,
 * go take any PR that is good enough and merge that into the code base,
 * go take any other open ticket and work that to a satisfactory resolution,
 * go take any Confluence page that is WIP and work that to an acceptable level.

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Comment Edited] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461324#comment-17461324
 ] 

Pierre Smits edited comment on OFBIZ-12450 at 12/17/21, 10:19 AM:
--

According to the code, price calculations for Party Classification 
(PRIP_PARTY_CLAS) is still marked as TODO.

At line 1197 PRIP_PARTY_CLASS is evaluated as an inputParamEnumId of 
productPricCond


was (Author: pfm.smits):
According to the code, price calculations for Party Classification is still 
marked as TODO.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461324#comment-17461324
 ] 

Pierre Smits commented on OFBIZ-12450:
--

According to the code, price calculations for Party Classification is still 
marked as TODO.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461321#comment-17461321
 ] 

Pierre Smits commented on OFBIZ-12450:
--

Price calculations working with price rules is done through PriceServices.java

According to the code price calculations should work for following conditions 
(as referenced in the description):
 * Product Category (productCateogryId
 * Product Id (both productId and pvirtualProductId)
 * Party (partyId)

And there are others referenced (based on records in the Enumeration table with 
enumTypeId="PROD_PRICE_IN_PARAM")

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-12450:


Assignee: Pierre Smits

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12465) PriceScreens.xml - incorrect reference in screen

2021-12-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-12465.

Fix Version/s: Upcoming Branch
   Resolution: Fixed

Thanks to Jacques for his assistance to get this into the codebase.

> PriceScreens.xml - incorrect reference in screen
> 
>
> Key: OFBIZ-12465
> URL: https://issues.apache.org/jira/browse/OFBIZ-12465
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> With commit 
> [92533b5|https://github.com/apache/ofbiz-framework/commit/92533b5651af6cd9f10db1e429b4eed0fee55aae]
>  the reference in screen FindProductPriceRule was not changed when the 
> relating object in PriceForms.xml changed from form to grid.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12465) PriceScreens.xml - incorrect reference in screen

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12465:


 Summary: PriceScreens.xml - incorrect reference in screen
 Key: OFBIZ-12465
 URL: https://issues.apache.org/jira/browse/OFBIZ-12465
 Project: OFBiz
  Issue Type: Bug
  Components: product/catalog
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


With commit 
[92533b5|https://github.com/apache/ofbiz-framework/commit/92533b5651af6cd9f10db1e429b4eed0fee55aae]
 the reference in screen FindProductPriceRule was not changed when the relating 
object in PriceForms.xml changed from form to grid.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-1151) Passwords are not salted

2021-12-16 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-1151.
---
  Assignee: (was: Adam Heath)
Resolution: Not A Problem

Closing as it is either already resolved in another way or due to lack of 
interest of the community.

> Passwords are not salted
> 
>
> Key: OFBIZ-1151
> URL: https://issues.apache.org/jira/browse/OFBIZ-1151
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Release Branch 4.0, Trunk
>Reporter: Wickersheimer Jeremy
>Priority: Minor
>
> Password are currently hashed but not seeded which may be a security issue.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: lib/README file and .DS_Store in .gitignore

2021-12-16 Thread Pierre Smits
Hi Jacques,

IMO, 'applications/content/index/' can be removed from .gitignore, as
indexes should be under the 'runtime' folder. And, AFAICT, this
'applications/content/index/' isn't in use in current setup.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Thu, Dec 16, 2021 at 11:18 AM Michael Brohl 
wrote:

> Thanks Jacques!
>
> Michael
>
> Am 16.12.21 um 08:11 schrieb Jacques Le Roux:
> > Thanks Michael,
> >
> > I add a doubt, fixed
> >
> > Jacques
> >
> > Le 15/12/2021 à 20:43, Michael Brohl a écrit :
> >> Hi Jacques,
> >>
> >> thanks for bringing this up.
> >>
> >> The lib dir is a mechanism which allows users to use and load
> >> external libs which can not (or should not) be loaded from external
> >> repositories through the Gradle mechanism. It is used in build.gradle
> >> at the end of the dependencies section.
> >>
> >> We do not use this library path but others may be using it. It's a
> >> feature to extend OFBiz, does no harm and might be useful in some cases.
> >>
> >> I would propose to keep it and change the README inside the folder to
> >> point to Maven Central instead of jCenter.
> >>
> >> Yes, .DS_Store is Mac related (https://file.org/extension/ds_store)
> >> and should stay in .gitignore.
> >>
> >> Thanks
> >>
> >> Michael
> >>
> >> ecomify GmbH - www.ecomify.de
> >>
> >> Am 15.12.21 um 17:36 schrieb Jacques Le Roux:
> >>> Hi All,
> >>>
> >>> The lib/README file contains deprecated information, like using
> >>> jcenter. I propose to get rid of the whole lib dir, except if I miss
> >>> something (I know .DS_Store is Apple-Mac related)?
> >>>
> >>> Jacques
> >>>
>


[jira] [Commented] (OFBIZ-10333) Improve Party

2021-12-16 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460560#comment-17460560
 ] 

Pierre Smits commented on OFBIZ-10333:
--

IMO, action triggers should - as much as possible - be rendered through menus. 
We have ample possibilities (with various styles to apply) to achieve this, 
with appropriate permission handling, in an easy widget way. Menus can also be 
included in ftl templates.

> Improve Party
> -
>
> Key: OFBIZ-10333
> URL: https://issues.apache.org/jira/browse/OFBIZ-10333
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-10221-party.template-party.AddCheckForParty.patch, 
> OFBIZ-10221-party.template-party.profileBlocks.ProductStores.patch, 
> OFBIZ-10221-party.template-party.profileBlocks.Visits.patch, 
> OFBIZ-10221-party.template.party.EditShoppingList.patch, 
> OFBIZ-10221-party.template.party.profileblocks.Attributes.patch, 
> OFBIZ-10221-party.template.party.profileblocks.Contact.patch, 
> OFBIZ-10221-party.template.party.profileblocks.Content.patch, 
> OFBIZ-10221-party.template.party.profileblocks.ContentList.patch, 
> OFBIZ-10221-party.template.party.profileblocks.Notes.patch, 
> OFBIZ-10221-party.template.party.profileblocks.UserLogin.patch
>
>
> All improvements for layout and structure for the Order-Application



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers

2021-12-16 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460556#comment-17460556
 ] 

Pierre Smits commented on OFBIZ-10470:
--

IMO, ftl templates should only be used for screen elements where a definition 
in a Forms.xml file (form or grid) is either
 * impossible to achieve, or
 * too complex to be understood easily by a contributor (or a downstream) 
developer, or
 * javascript code cannot be included in a javascript file that is referenced 
in a screen definition where it is needed

Definitions of the type screenlet (or rather anything that can be a screen 
level), however, are not part of a form or grid definition, and should 
therefore not be part of the ftl template.

> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of 
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
> 
> 
> 
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
> 
> 
> Title
> {code}
> # {code:html}
> 
> 
> Title
> {code}
> # {code:html}
> 
> 
> 
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales 
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style 
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather 
> confusing than useful



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-16 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12450:
-
Labels: user-experience  (was: )

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-16 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12450:
-
Component/s: product/catalog
 (was: product)

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Priority: Critical
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: Back Orders

2021-12-16 Thread Pierre Smits
Hi James,

I guess you attached something to your mail to the user ml. It happens to
be so that the configuration of this mailing list does not allow for
attachments to go through.

If you feel this is an error due to a flaw in the OFBiz code, please
register a ticket in our JIRA (see [1])
It may also be so that an ticket is registered for the same. Please check
our JIRA.

[1] https://issues.apache.org/jira/projects/OFBIZ/issues/

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Thu, Dec 9, 2021 at 7:22 PM  wrote:

> Has anyone seen the attached error when creating a production run?  We
> have proper dates set for the BOM and Routings.
>
>  Original Message 
> Subject: RE: Back Orders
> From: 
> Date: Tue, November 16, 2021 9:55 am
> To: "user@ofbiz.apache.org" 
>
> anyone have any idea on how the system was designed to function?
>
>
>  Original Message 
> Subject: Back Orders
> From: 
> Date: Wed, November 10, 2021 12:33 pm
> To: "user@ofbiz.apache.org" 
>
> Can someone tell me how backorders are suppose to function out of the
> box. Here is what I am seeing
>
> 1. Order Placed with a total of 10 items with 1 item that is back
> ordered (Correct)
> 2. Pick List Created with 9 items (Correct)
> 3. When packing the system should only show 9 items but system is
> showing all 10 items (incorrect)
> 4. After Original Order is shipped and the backordered product is
> received then the backordered item is now available for picking but
> should have ship group 2 but currently it has ship group 1
>
> Am I missing something? Can anyone let me know how it is suppose to
> function?
>


[jira] [Created] (OFBIZ-12463) Payment Group Common Decorator

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12463:


 Summary: Payment Group Common Decorator
 Key: OFBIZ-12463
 URL: https://issues.apache.org/jira/browse/OFBIZ-12463
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


title of a payment group is shown below its menu(s)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12458) Invoice - CommonInvoiceDecorator

2021-12-16 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12458:
-
Environment: (was: label for invoice is shown below Invoice menus)

> Invoice - CommonInvoiceDecorator
> 
>
> Key: OFBIZ-12458
> URL: https://issues.apache.org/jira/browse/OFBIZ-12458
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, usability
>
> label for invoice is shown below Invoice menus



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12462) Agreement - CommonAgreementDecorator

2021-12-16 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12462:


 Summary: Agreement - CommonAgreementDecorator
 Key: OFBIZ-12462
 URL: https://issues.apache.org/jira/browse/OFBIZ-12462
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


title of an agreement is shown below its menu(s).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: lib/README file and .DS_Store in .gitignore

2021-12-15 Thread Pierre Smits
Hi Jacques,

Maybe you forgot, but ...
As a privileged contributor you have the discretionary power to remove
deprecated elements at any time from the files in the OFBiz repository
without a proposal for (and a discussion regarding) such removal.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Wed, Dec 15, 2021 at 5:38 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi All,
>
> The lib/README file contains deprecated information, like using jcenter. I
> propose to get rid of the whole lib dir, except if I miss something (I know
> .DS_Store is Apple-Mac related)?
>
> Jacques
>
>


Re: Migration from ci.a.o

2021-12-15 Thread Pierre Smits
HI Jacques,

If the project still sees XMLRPC functionality as an important OFBiz
service, we should work to get the CI to work with the tests. If the
project feels it has outlived its usefulness, we should work to get this
attic-ed.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Wed, Dec 15, 2021 at 5:24 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 14/12/2021 à 09:34, Jacques Le Roux a écrit :
> > I also wonder if we should not get rid of Apache XMLRPC knowing that
> it's no longer maintained:
> https://github.com/advisories/GHSA-6vwp-35w3-xph8
>
> A milder mitigation would be to simply comment out the 2 tests that fail
> on BuildBot. That would allow to keep XMLRPC for those interested. Like
> people working in a safe (ie no internet) environment. We also know that
> only post-auth attacks are possible.
>
> Opinions?
>
> Jacques
>
>


[jira] [Commented] (OFBIZ-12459) Cybersource - configuration

2021-12-15 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17460048#comment-17460048
 ] 

Pierre Smits commented on OFBIZ-12459:
--

[~mbrohl]

As it stands now, the only thing I see you doing is commenting/complaining from 
the back bench, twisting and turning - and providing (IMO) politically 
motivated arguments - to get your way. Which is, as I see it, to *not* improve 
OFBiz in favour of that being left in the hands of OFBiz integrators, and is 
rather intended to influence others from collaborating with me and merging (my) 
contributions into the codebase.

As soon as you actually start merging my contributions into the codebase, 
actually start collaborating with me on improvements, actually start 
recognising my merit, my way (of reacting to your comments) may change. 

A suggestion: if you're so keen on OFBiz users working with having 
SystemProperty configuration records as .property file elements (as you 
remarked in OFBIZ-6670 regarding OFBiz DEVOPS work being a nightmare), why 
don't you contribute e.g. a Confluence page called:

 
{noformat}
How To Convert SystemProperty Data Elements to '.property'File Elements - For 
OFBiz DEVOPS{noformat}
 

 

 

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12461) Missing attribute 'description' on element 'entity-options'

2021-12-15 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459990#comment-17459990
 ] 

Pierre Smits commented on OFBIZ-12461:
--

Ahh. Yes. An older release of OFBiz could have that issue still.

Thanks for the follow-up, Danny. Much obliged.

> Missing attribute 'description' on element 'entity-options'
> ---
>
> Key: OFBIZ-12461
> URL: https://issues.apache.org/jira/browse/OFBIZ-12461
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Minor
>
> Log Warning:
> {code:java}
> XmlFileLoader: File 
> file:/.../applications/product/widget/catalog/ProductForms.xml process error. 
> Line: 131. Error message: cvc-complex-type.4: Attribute 'description' must 
> appear on element 'entity-options'.{code}
> There are several other places in that XML file and maybe other XML files 
> where the description attribute is missing on entity-options elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12459) Cybersource - configuration

2021-12-15 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459981#comment-17459981
 ] 

Pierre Smits commented on OFBIZ-12459:
--

[~mbrohl]

Please stop your silly complaints. 
when
{noformat}
forces the user to use SystemProperty{noformat}
is unreasonable, then the opposite (forcing the user to use a .property file 
for a runtime configuration) is equally so. This project is 

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12461) Missing attribute 'description' on element 'entity-options'

2021-12-15 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459970#comment-17459970
 ] 

Pierre Smits commented on OFBIZ-12461:
--

Hi [~dtrunk90],

Can you elaborate a bit more on when this is happening? I tried today against 
trunk. And this 

Attribute 'description' must appear on element 'entity-options'
didn't appear in my logs, nor in my IDE. 

What is the release of OFBiz that you are using? What platform?

> Missing attribute 'description' on element 'entity-options'
> ---
>
> Key: OFBIZ-12461
> URL: https://issues.apache.org/jira/browse/OFBIZ-12461
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Minor
>
> Log Warning:
> {code:java}
> XmlFileLoader: File 
> file:/.../applications/product/widget/catalog/ProductForms.xml process error. 
> Line: 131. Error message: cvc-complex-type.4: Attribute 'description' must 
> appear on element 'entity-options'.{code}
> There are several other places in that XML file and maybe other XML files 
> where the description attribute is missing on entity-options elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12461) Missing attribute 'description' on element 'entity-options'

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12461:
-
Labels:   (was: catalog)

> Missing attribute 'description' on element 'entity-options'
> ---
>
> Key: OFBIZ-12461
> URL: https://issues.apache.org/jira/browse/OFBIZ-12461
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Minor
>
> Log Warning:
> {code:java}
> XmlFileLoader: File 
> file:/.../applications/product/widget/catalog/ProductForms.xml process error. 
> Line: 131. Error message: cvc-complex-type.4: Attribute 'description' must 
> appear on element 'entity-options'.{code}
> There are several other places in that XML file and maybe other XML files 
> where the description attribute is missing on entity-options elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12461) Missing attribute 'description' on element 'entity-options'

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12461:
-
Component/s: product/catalog
 (was: product)

> Missing attribute 'description' on element 'entity-options'
> ---
>
> Key: OFBIZ-12461
> URL: https://issues.apache.org/jira/browse/OFBIZ-12461
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Minor
>  Labels: catalog
>
> Log Warning:
> {code:java}
> XmlFileLoader: File 
> file:/.../applications/product/widget/catalog/ProductForms.xml process error. 
> Line: 131. Error message: cvc-complex-type.4: Attribute 'description' must 
> appear on element 'entity-options'.{code}
> There are several other places in that XML file and maybe other XML files 
> where the description attribute is missing on entity-options elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12461) Missing attribute 'description' on element 'entity-options'

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12461:
-
Labels: catalog  (was: )

> Missing attribute 'description' on element 'entity-options'
> ---
>
> Key: OFBIZ-12461
> URL: https://issues.apache.org/jira/browse/OFBIZ-12461
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Minor
>  Labels: catalog
>
> Log Warning:
> {code:java}
> XmlFileLoader: File 
> file:/.../applications/product/widget/catalog/ProductForms.xml process error. 
> Line: 131. Error message: cvc-complex-type.4: Attribute 'description' must 
> appear on element 'entity-options'.{code}
> There are several other places in that XML file and maybe other XML files 
> where the description attribute is missing on entity-options elements.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12460) Unable to build in M1 Mac

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12460:
-
Environment: 
Apple Mac: M1 processor

Java version:

Ofbiz release/branche

> Unable to build in M1 Mac
> -
>
> Key: OFBIZ-12460
> URL: https://issues.apache.org/jira/browse/OFBIZ-12460
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Upcoming Branch
> Environment: Apple Mac: M1 processor
> Java version:
> Ofbiz release/branche
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Following error occurs when building in M1 Mac
> {code:java}
> Could not determine the dependencies of task ':nodeSetup'.
> > Failed to query the value of task ':nodeSetup' property 'nodeArchiveFile'.
>> Could not resolve all files for configuration ':detachedConfiguration1'.
>   > Could not find node-12.18.1-darwin-arm64.tar.gz 
> (org.nodejs:node:12.18.1).
> Searched in the following locations:
> https://nodejs.org/dist/v12.18.1/node-v12.18.1-darwin-arm64.tar.gz
> {code}
> Need to upgrade Node.js version from 12.x.x to 16.x.x as 16.x.x has support 
> for M1 Mac.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12460) Unable to build in M1 Mac

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12460:
-
Labels: build-failure  (was: )

> Unable to build in M1 Mac
> -
>
> Key: OFBIZ-12460
> URL: https://issues.apache.org/jira/browse/OFBIZ-12460
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Upcoming Branch
> Environment: Apple Mac: M1 processor
> Java version:
> Ofbiz release/branche
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
>  Labels: build-failure
> Fix For: Upcoming Branch
>
>
> Following error occurs when building in M1 Mac
> {code:java}
> Could not determine the dependencies of task ':nodeSetup'.
> > Failed to query the value of task ':nodeSetup' property 'nodeArchiveFile'.
>> Could not resolve all files for configuration ':detachedConfiguration1'.
>   > Could not find node-12.18.1-darwin-arm64.tar.gz 
> (org.nodejs:node:12.18.1).
> Searched in the following locations:
> https://nodejs.org/dist/v12.18.1/node-v12.18.1-darwin-arm64.tar.gz
> {code}
> Need to upgrade Node.js version from 12.x.x to 16.x.x as 16.x.x has support 
> for M1 Mac.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12459) Cybersource - configuration

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12459:
-
Summary: Cybersource - configuration  (was: Cybersource - from 
payment.properties to SystemProperty)

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12459) Cybersource - from payment.properties to SystemProperty

2021-12-15 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12459:


 Summary: Cybersource - from payment.properties to SystemProperty
 Key: OFBIZ-12459
 URL: https://issues.apache.org/jira/browse/OFBIZ-12459
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Move 3rd party Fintech integration configuration for Cybersource from 
initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-3278) Improvement in Cybersource integration to better handle a sale transaction response

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-3278:

Labels: 3rdParty cybersource integration  (was: )

> Improvement in Cybersource integration to better handle a sale transaction 
> response
> ---
>
> Key: OFBIZ-3278
> URL: https://issues.apache.org/jira/browse/OFBIZ-3278
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pranay Pandey
>Assignee: Ashish Vijaywargiya
>Priority: Minor
>  Labels: 3rdParty, cybersource, integration
> Fix For: Trunk
>
> Attachments: OFBIZ-3278.patch
>
>
> For running the sale transaction that is auth+capture in a single transaction 
> we set field autoBill to true in PaymentGatewayCyberSource entity or 
> payment.cybersource.autoBill to true in payment.properties.
> Improvement in code for Cybersource integration to handle better sale 
> transaction response is needed. Sale transaction is used in Cybersource 
> integration to provide payment authorization and capture together. Its 
> already supported but improvement is needed so that transaction can be better 
> entered in the system for further review for a specific order.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-246) Better handling of 0.00 total response from gateway implementations

2021-12-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-246.
--
Resolution: Abandoned

Closed due to lack of interest within the community.

> Better handling of 0.00 total response from gateway implementations
> ---
>
> Key: OFBIZ-246
> URL: https://issues.apache.org/jira/browse/OFBIZ-246
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Jacopo Cappellato
>Priority: Minor
>
> Copy of an old issue from Alexander Heiss:
> When we get back a 0.00 processAmount from an external payment 
> implementation, setting the total to capture back to the max amount for the 
> order is a bad idea; should at least change to get remaining total of 
> payments left to be paid instead.
> ~line 1159 of PaymentGatewayServices change:
> amount = paymentPreference.getDouble("maxAmount");
> to
> double orderTotal = orh.getOrderGrandTotal();
> double totalPayments = PaymentWorker.getPaymentsTotal(orh.getOrderPayments());
> double remainingTotal = orderTotal - totalPayments;
> amount = new Double(remainingTotal);
> This assumes you want to always charge rest of order to this card. Could also 
> possibly check against the maxAmount to make sure we don't go over, but not 
> too sure at the moment what to do if total left on order is over origional 
> maxAmount, just cap it?
>  All   CommentsWork LogChange History 
>   Sort Order: [navigator.ascending.order]
> Comment by Andrew Zeneski [27/Aug/04 12:34 PM]
> [ Permlink ]
> I am thinking if we get back 0.00 from the gateway, that would mean that 0.00 
> was authorized. This probably should not capture at all in this case. Have 
> you seen this actually happen?
> Comment by Alexander Heiss [27/Aug/04 01:07 PM]
> [ Permlink ]
> 0.00 back from the implementation may not necessarially mean that there was a 
> successful capture of 0.00. In both cybersource and clearcommerce, a 0.00 is 
> returned when there is no ccAuthReply_amount sent back (cybersource) or there 
> is some sort of error.
> I am using older implementation of cybersource, but I've seen a null 
> ccAuthReply_amount come back from them when an attempt is made to capture, 
> and a 102 (REJECT).. invalid data.. is returned. The request to them is fine, 
> but the auth being captured is expired.
> Do we want to use 0.00 in the implementations, or maybe change to a -1 or 
> something? It's time consuming to test expired auths but I think the main 
> issue here is setting 0.00 in the implementation when we really dont get a 
> 0.00 back (even though $0 was actually captured in the transaction).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: [jira] [Commented] (OFBIZ-12449) [SECURITY] CVE-2021-44228: Apache Log4j2

2021-12-14 Thread Pierre Smits
Thanks Jaques, for being on top of this.
Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Tue, Dec 14, 2021 at 12:23 PM ASF subversion and git services (Jira) <
j...@apache.org> wrote:

>
> [
> https://issues.apache.org/jira/browse/OFBIZ-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17459094#comment-17459094
> ]
>
> ASF subversion and git services commented on OFBIZ-12449:
> -
>
> Commit 479e222bbb7ecb81fdbf123cc6cfcc10f8dbac4a in ofbiz-framework's
> branch refs/heads/trunk from Jacques Le Roux
> [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=479e222 ]
>
> Improved: Apache Log4j2 (OFBIZ-12449)
>
> Updates log4j2 from 2.15.0 to 2.16.0 because of
> https://lists.apache.org/thread/d6v4r6nosxysyq9rvnr779336yf0woz4
>
> It's not a security issue, I lazily use OFBIZ-12449 because it can improve
> security even if it's not necessary (dixit the announce)
>
>
> > [SECURITY] CVE-2021-44228: Apache Log4j2
> > 
> >
> > Key: OFBIZ-12449
> > URL: https://issues.apache.org/jira/browse/OFBIZ-12449
> > Project: OFBiz
> >  Issue Type: Sub-task
> >  Components: ALL COMPONENTS
> >Affects Versions: Trunk
> >Reporter: Jacques Le Roux
> >Assignee: Jacques Le Roux
> >Priority: Blocker
> > Fix For: 18.12.03
> >
> >
> > CVE-2021-44228: Apache Log4j2 JNDI features do not protect against
> attacker controlled LDAP and other JNDI related endpoints:
> > https://logging.apache.org/log4j/2.x/security.html
> > I'm not sure we are concerned, have no time to check, better safe than
> sorry...
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.20.1#820001)
>


[jira] [Updated] (OFBIZ-12458) Invoice - CommonInvoiceDecorator

2021-12-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12458:
-
Description: label for invoice is shown below Invoice menus

> Invoice - CommonInvoiceDecorator
> 
>
> Key: OFBIZ-12458
> URL: https://issues.apache.org/jira/browse/OFBIZ-12458
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: label for invoice is shown below Invoice menus
>    Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, usability
>
> label for invoice is shown below Invoice menus



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12458) Invoice - CommonInvoiceDecorator

2021-12-14 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12458:


 Summary: Invoice - CommonInvoiceDecorator
 Key: OFBIZ-12458
 URL: https://issues.apache.org/jira/browse/OFBIZ-12458
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
 Environment: label for invoice is shown below Invoice menus
Reporter: Pierre Smits
Assignee: Pierre Smits






--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12457) VIEW permissions BillingAccount

2021-12-14 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12457:


 Summary: VIEW permissions BillingAccount
 Key: OFBIZ-12457
 URL: https://issues.apache.org/jira/browse/OFBIZ-12457
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the billing account screen, sees editable 
fields and/or triggers (to requests) reserved for users with 'CREATE' or 
'UPDATE' permissions.

See (test with): 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditBillingAccount?billingAccountId=9010



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12423) Font used with Helveticus theme generates CSP violations

2021-12-14 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12423:
-
Summary: Font used with Helveticus theme generates CSP violations  (was: 
Font used with Helvetica theme generates CSP violations)

> Font used with Helveticus theme generates CSP violations
> 
>
> Key: OFBIZ-12423
> URL: https://issues.apache.org/jira/browse/OFBIZ-12423
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: CSP, trust, usability
>
> The font used by the Helvetica theme generates multiple CSP violations 
> according to the inspector in the Firefox browser. See below.
> {code:java}
> Content Security Policy: The page’s settings observed the loading of a 
> resource at inline (“default-src”). A CSP report is being sent. 3 
> EditTaxAuthority
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> http

Re: [ANNOUNCE] Apache OFBiz 18.12.03 released

2021-12-13 Thread Pierre Smits
Thanks Jacques, jacopo, all

Op ma 13 dec. 2021 21:22 schreef Jacopo Cappellato :

> The Apache OFBiz community is pleased to announce the new release "Apache
> OFBiz 18.12.03".
>
> Apache OFBiz® is an open source product for the automation of enterprise
> processes that includes framework components and business applications.
>
> http://ofbiz.apache.org/
>
> "Apache OFBiz 18.12.03" is the third release of the 18.12 series.
>
> For more details of the changes introduced with this new version
> please refer to http://ofbiz.apache.org/release-notes-18.12.03.html
>
> The release file can be downloaded following the instructions in the OFBiz
> download page:
>
> http://ofbiz.apache.org/download.html
>


[jira] [Commented] (OFBIZ-12423) Font used with Helvetica theme generates CSP violations

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458668#comment-17458668
 ] 

Pierre Smits commented on OFBIZ-12423:
--

Hi Jacques,

I won't. See also my comment in the other Helveticus bug ticket.

> Font used with Helvetica theme generates CSP violations
> ---
>
> Key: OFBIZ-12423
> URL: https://issues.apache.org/jira/browse/OFBIZ-12423
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: CSP, trust, usability
>
> The font used by the Helvetica theme generates multiple CSP violations 
> according to the inspector in the Firefox browser. See below.
> {code:java}
> Content Security Policy: The page’s settings observed the loading of a 
> resource at inline (“default-src”). A CSP report is being sent. 3 
> EditTaxAuthority
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJVQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hJFQNYuDyP7bh.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> https://fonts.gstatic.com/s/quicksand/v24/6xKtdSZaM9iE8KbpRA_hK1QNYuDyPw.woff2
>  (“default-src”). A CSP report is being sent. 
> Content Security Policy: The page’s settings observed the loading of a 
> resource at 
> http

[jira] [Commented] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458666#comment-17458666
 ] 

Pierre Smits commented on OFBIZ-12452:
--

Hi Jacques,

I'll pass. I rather see bug tickets fixed than shoved around and under an 
improvement ticket. 

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, themes
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10.png, Screenshot 
> 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: svn commit: r51352 - /release/ofbiz/README.html

2021-12-13 Thread Pierre Smits
Hi Jacopo, all,

Please do not forget to set the tag for the release in the git repo, and
inform our users.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Sun, Dec 12, 2021 at 7:46 PM  wrote:

> Author: jacopoc
> Date: Sun Dec 12 18:46:15 2021
> New Revision: 51352
>
> Log:
> Add to history log the new release 18.12.03
>
> Modified:
> release/ofbiz/README.html
>
> Modified: release/ofbiz/README.html
>
> ==
> --- release/ofbiz/README.html (original)
> +++ release/ofbiz/README.html Sun Dec 12 18:46:15 2021
> @@ -5,6 +5,7 @@ Note: old releases can be downloaded fro
>  18.12 series
>  This series has been stabilized with bug fixes since December 2018.
>  
> +apache-ofbiz-18.12.03.zip - Released in December 2021.  target="external" href="
> http://ofbiz.apache.org/release-notes-18.12.03.html;>Release
> notes.
>  apache-ofbiz-18.12.02.zip - Released in November 2021.  target="external" href="
> http://ofbiz.apache.org/release-notes-18.12.02.html;>Release
> notes.
>  apache-ofbiz-18.12.01.zip - Released in October 2021.  target="external" href="
> http://ofbiz.apache.org/release-notes-18.12.01.html;>Release
> notes.
>  
>
>
>


[jira] [Commented] (OFBIZ-6670) Have configuration options for Content.

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458387#comment-17458387
 ] 

Pierre Smits commented on OFBIZ-6670:
-

So you don't have to bring up that 'Ecomify's Gradle based' approach here.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Comment Edited] (OFBIZ-6670) Have configuration options for Content.

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458386#comment-17458386
 ] 

Pierre Smits edited comment on OFBIZ-6670 at 12/13/21, 1:22 PM:


The disinterest of the community to clean-up code (as with various other 
elements, like e.g. labels) is not a means to disparage improvements. What you 
have implemented downstream at your customers isn't the project's concern. 

Your 'Gradle based' approach? Is that the thing you referenced recently? And 
that you promised to write a page about? If not documented in the project 
(and/or explained in detail on a project's ml) it does not exist.


was (Author: pfm.smits):
The disinterest of the community to clean-up code (as with various other 
elements, like e.g. labels) is not a means to disparage improvements. What you 
have implemented downstream at your customers is the project's concern. 

Your 'Gradle based' approach? Is that the thing you referenced recently? And 
that you promised to write a page about? If not documented in the project 
(and/or explained in detail on a project's ml) it does not exist.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-6670) Have configuration options for Content.

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458386#comment-17458386
 ] 

Pierre Smits commented on OFBIZ-6670:
-

The disinterest of the community to clean-up code (as with various other 
elements, like e.g. labels) is not a means to disparage improvements. What you 
have implemented downstream at your customers is the project's concern. 

Your 'Gradle based' approach? Is that the thing you referenced recently? And 
that you promised to write a page about? If not documented in the project 
(and/or explained in detail on a project's ml) it does not exist.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12454) testInvoicePerShipment is broken

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458382#comment-17458382
 ] 

Pierre Smits commented on OFBIZ-12454:
--

The same happens with 
List invoices = testInvoicePerShipment("GZ-1000", "Y")

> testInvoicePerShipment is broken
> 
>
> Key: OFBIZ-12454
> URL: https://issues.apache.org/jira/browse/OFBIZ-12454
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: integration-test, test-failure
>
>  
> Running the test with parameters ("GZ-1000", "N") as shown in comment in 
> OFBIZ-12453 (see below)
> {code:java}
> List invoices = testInvoicePerShipment("GZ-1000", "N") {code}
> results in an error (see below)
> {code:java}
> assert ServiceUtil.isSuccess(serviceResult) | | false ['shipmentId':'EMPTY', 
> 'errorMessage':'No items currently set to be shipped. Cannot complete!', 
> 'responseMessage':'error']
> Assertion failed: 
> assert ServiceUtil.isSuccess(serviceResult)
> | |
> false ['shipmentId':'EMPTY', 'errorMessage':'No items currently set to be 
> shipped. Cannot complete!', 'responseMessage':'error']
> at 
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
> at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> at 
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipment(InvoicePerShipmentTests.groovy:137)
> at 
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
> at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
> at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
> at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
> at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
> at org.apache.ofbiz.base.start.Start.main(Start.java:89) {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: Migration from ci.a.o

2021-12-13 Thread Pierre Smits
Jacques,
The failure is not due to the inclusion of the SystemProperty record in
seed data. It is due to a unexpected result when testInvoicePerShipment is
called with product="GZ-1000" and invoicePerShipment="N". And the same
happens in the same test with product="GZ-1000" and invoicePerShipment="Y".

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Mon, Dec 13, 2021 at 11:38 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks guys,
>
> With the help of Pierre, I found that it's due to
> https://github.com/apache/ofbiz-framework/pull/392/files
>
> Exactly to
>
>systemPropertyId="create.invoice.per.shipment" systemPropertyValue="Y"
>  description="create invoice per shipment. Options: = Y (Invoice per
> shipment), N (Invoice per order)"/>
>
> As the test name says testInvoicePerShipmentSetFalse
>
> The alternatives are:
>
>  1. Revert the PR (would allow to go on with INFRA-22279)
>  2. Just comment out the property above (would allow to go on with
> INFRA-22279)
>  3. Discuss if we want to use invoice per shipment by default (I guess it
> has been already done, if not several times)
>
> For now I decide to use 2 as it's the easiest way to go on with INFRA-22279
>
> Jacques
>
> Le 13/12/2021 à 10:47, Pierre Smits a écrit :
> > On my Mac the testInvoicePerShipmentSetFalse fails too, giving
> >
> > assert UtilValidate.isEmpty(invoices) | | false
> [['orderItemSeqId':'1',
> >> 'amount':15.99, 'quantity':1.00, 'statusId':'INVOICE_READY',
> >> 'orderId':'WSCO10020', 'itemIssuanceId':'10020', 'invoiceId':'CI1',
> >> 'invoiceItemSeqId':'1', 'shipmentReceiptId':null]]
> >>
> >> Assertion failed:
> >>
> >> assert UtilValidate.isEmpty(invoices)
> >> | |
> >> false [['orderItemSeqId':'1', 'amount':15.99, 'quantity':1.00,
> >> 'statusId':'INVOICE_READY', 'orderId':'WSCO10020',
> >> 'itemIssuanceId':'10020', 'invoiceId':'CI1', 'invoiceItemSeqId':'1',
> >> 'shipmentReceiptId':null]]
> >>
> >> at
> >>
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
> >> at
> >>
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> >> at
> >>
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
> >> at
> >>
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> >> at
> >>
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
> >> at
> >>
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
> >> at
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
> >> at
> >>
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
> >> at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> >>
> > Met vriendelijke groet,
> >
> > Pierre Smits
> > *Proud* *contributor** of* Apache OFBiz<https://ofbiz.apache.org/>
> since
> > 2008 (without privileges)
> > Proud contributor to the ASF since 2006
> >
> > *Apache Directory<https://directory.apache.org>, PMC Member*
> >
> >
> > On Mon, Dec 13, 2021 at 10:28 AM Daniel Watford
> wrote:
> >
> >> Hi Jacques,
> >>
> >> After running ./gradlew testIntegration I can confirm that I see the
> test
> >> failure for testInvoicePerShipmentSetFalse.
> >>
> >> The error was visible by viewing
> >> $OFBIZ/runtime/logs/test-results/html/index.html in a browser and then
> >> navigating to the invoicestests class.
> >>
> >> On Mon, 13 Dec 2021 at 08:28, Jacques Le Roux <
> >> jacques.le.r...@les7arts.com>
> >> wrote:
> >>
> >>> Hi All,
> >>>
> >>> We have an issue withhttps://issues.apache.org/jira/browse/INFRA-22279
> >>> for tests on trunk and I need all your attention to help me fix it.
> >>>
> >>> The last successful trunk build on the old Buildbot (0.8) was <<*Oct.
> >>> 18*>>:
> >>> https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/
> >>>

[jira] [Commented] (OFBIZ-6670) Have configuration options for Content.

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458363#comment-17458363
 ] 

Pierre Smits commented on OFBIZ-6670:
-

Hi Jacques,

I came across this one: OFBIZ-4730. Both the discussion and the ticket were 
catalysts to the change. However, though good suggestions were made in the 
thread, nobody picked up on the aspect of difference between the configuration 
aspects for OFBiz initialisation and the configuration aspects vis-a-vis 
runtime. 

Applications don't not need initialisation configuration as framework takes 
care of that. So, anything in an application's property file is to be 
considered as 'run-time'. And thus to be in a SystemProperty record.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12454) testInvoicePerShipment is broken

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12454:
-
Summary: testInvoicePerShipment is broken  (was: tesitInvoicePerShipment is 
broken)

> testInvoicePerShipment is broken
> 
>
> Key: OFBIZ-12454
> URL: https://issues.apache.org/jira/browse/OFBIZ-12454
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: integration-test, test-failure
>
>  
> Running the test with parameters ("GZ-1000", "N") as shown in comment in 
> OFBIZ-12453 (see below)
> {code:java}
> List invoices = testInvoicePerShipment("GZ-1000", "N") {code}
> results in an error (see below)
> {code:java}
> assert ServiceUtil.isSuccess(serviceResult) | | false ['shipmentId':'EMPTY', 
> 'errorMessage':'No items currently set to be shipped. Cannot complete!', 
> 'responseMessage':'error']
> Assertion failed: 
> assert ServiceUtil.isSuccess(serviceResult)
> | |
> false ['shipmentId':'EMPTY', 'errorMessage':'No items currently set to be 
> shipped. Cannot complete!', 'responseMessage':'error']
> at 
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
> at 
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> at 
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipment(InvoicePerShipmentTests.groovy:137)
> at 
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
> at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
> at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
> at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
> at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
> at org.apache.ofbiz.base.start.Start.main(Start.java:89) {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12454) tesitInvoicePerShipment is broken

2021-12-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12454:


 Summary: tesitInvoicePerShipment is broken
 Key: OFBIZ-12454
 URL: https://issues.apache.org/jira/browse/OFBIZ-12454
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits


 

Running the test with parameters ("GZ-1000", "N") as shown in comment in 
OFBIZ-12453 (see below)
{code:java}
List invoices = testInvoicePerShipment("GZ-1000", "N") {code}
results in an error (see below)
{code:java}
assert ServiceUtil.isSuccess(serviceResult) | | false ['shipmentId':'EMPTY', 
'errorMessage':'No items currently set to be shipped. Cannot complete!', 
'responseMessage':'error']

Assertion failed: 

assert ServiceUtil.isSuccess(serviceResult)
| |
false ['shipmentId':'EMPTY', 'errorMessage':'No items currently set to be 
shipped. Cannot complete!', 'responseMessage':'error']

at 
org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
at 
org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipment(InvoicePerShipmentTests.groovy:137)
at 
org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at org.apache.ofbiz.base.start.Start.main(Start.java:89) {code}
 

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12453) testInvoicePerShipmentSetFalse work with runtime configuration data

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12453:
-
Issue Type: Bug  (was: Improvement)

> testInvoicePerShipmentSetFalse work with runtime configuration data
> ---
>
> Key: OFBIZ-12453
> URL: https://issues.apache.org/jira/browse/OFBIZ-12453
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: integration-test, test-failure
>
> The testInvoicePerShipmentSetFalse fails when the following is loaded into 
> the SystemProperty table and the test is executed.
> {code:java}
>  systemPropertyId="create.invoice.per.shipment" 
> systemPropertyValue="Y"
> description="create invoice per shipment. Options: = Y (Invoice per 
> shipment), N (Invoice per order)"/> {code}
> See 
> https://github.com/apache/ofbiz-framework/blob/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12453) testInvoicePerShipmentSetFalse work with runtime configuration data

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458360#comment-17458360
 ] 

Pierre Smits commented on OFBIZ-12453:
--

Using the test with following in code:
{code:java}
void testInvoicePerShipmentSetFalse() {
        /* Test Invoice Per Shipment
            Step 1) Set create.invoice.per.shipment=N in accounting.properties 
file.
            Step 2) Create order and approve order.
            Step 3) Pack Shipment For Ship Group.
            Step 4) Check invoice should not created.
        */
        //UtilProperties.setPropertyValueInMemory("accounting", 
"create.invoice.per.shipment", "N")
        //logInfo("= >>> Set Accounting.properties / 
create.invoice.per.shipment = N")


        List invoices = testInvoicePerShipment("GZ-1000", "N")
        assert UtilValidate.isEmpty(invoices)
    } {code}
results in:
{code:java}
assert ServiceUtil.isSuccess(serviceResult) | | false ['shipmentId':'EMPTY', 
'errorMessage':'No items currently set to be shipped. Cannot complete!', 
'responseMessage':'error']

Assertion failed: 

assert ServiceUtil.isSuccess(serviceResult)
| |
false ['shipmentId':'EMPTY', 'errorMessage':'No items currently set to be 
shipped. Cannot complete!', 'responseMessage':'error']

at 
org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
at 
org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
at 
org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipment(InvoicePerShipmentTests.groovy:137)
at 
org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
at org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at org.apache.ofbiz.base.start.Start.main(Start.java:89) {code}

> testInvoicePerShipmentSetFalse work with runtime configuration data
> ---
>
> Key: OFBIZ-12453
> URL: https://issues.apache.org/jira/browse/OFBIZ-12453
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: integration-test, test-failure
>
> The testInvoicePerShipmentSetFalse fails when the following is loaded into 
> the SystemProperty table and the test is executed.
> {code:java}
>  systemPropertyId="create.invoice.per.shipment" 
> systemPropertyValue="Y"
> description="create invoice per shipment. Options: = Y (Invoice per 
> shipment), N (Invoice per order)"/> {code}
> See 
> https://github.com/apache/ofbiz-framework/blob/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-6670) Have configuration options for Content.

2021-12-13 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458324#comment-17458324
 ] 

Pierre Smits commented on OFBIZ-6670:
-

Hi Jacques,

Aren't you mixing things up? Runtime configuration through SystemProperty 
records and OFBIZ-7112 are not just related to multi-tenancy. It is runtime 
related configuration, as opposed to initialisation related.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Reopened] (OFBIZ-6189) Have configuration options for accounting

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reopened OFBIZ-6189:
-

Reopening issue due to failure testInvoicePerShipmentSetFalse

> Have configuration options for accounting
> -
>
> Key: OFBIZ-6189
> URL: https://issues.apache.org/jira/browse/OFBIZ-6189
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12453) testInvoicePerShipmentSetFalse work with runtime configuration data

2021-12-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12453:


 Summary: testInvoicePerShipmentSetFalse work with runtime 
configuration data
 Key: OFBIZ-12453
 URL: https://issues.apache.org/jira/browse/OFBIZ-12453
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits


The testInvoicePerShipmentSetFalse fails when the following is loaded into the 
SystemProperty table and the test is executed.
{code:java}
 {code}

See 
https://github.com/apache/ofbiz-framework/blob/trunk/applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12452:
-
Component/s: themes

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, themes
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10.png, Screenshot 
> 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12452:
-
Attachment: (was: Screenshot 2021-12-13 at 11.13.10-1.png)

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10.png, Screenshot 
> 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12452:
-
Attachment: (was: Screenshot 2021-12-13 at 11.13.24-1.png)

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10.png, Screenshot 
> 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12452:
-
Attachment: Screenshot 2021-12-13 at 11.13.24.png
Screenshot 2021-12-13 at 11.13.10.png

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10-1.png, Screenshot 
> 2021-12-13 at 11.13.10.png, Screenshot 2021-12-13 at 11.13.24-1.png, 
> Screenshot 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12452:
-
Attachment: Screenshot 2021-12-13 at 11.13.24-1.png
Screenshot 2021-12-13 at 11.13.10-1.png

> Helveticus - Sapphire - inconsistency order app menu
> 
>
> Key: OFBIZ-12452
> URL: https://issues.apache.org/jira/browse/OFBIZ-12452
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: theme, usability
> Attachments: Screenshot 2021-12-13 at 11.13.10-1.png, Screenshot 
> 2021-12-13 at 11.13.10.png, Screenshot 2021-12-13 at 11.13.24-1.png, 
> Screenshot 2021-12-13 at 11.13.24.png
>
>
> When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
> menu changes when a user goes from the main screen into an order. See 
> attached images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12452) Helveticus - Sapphire - inconsistency order app menu

2021-12-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12452:


 Summary: Helveticus - Sapphire - inconsistency order app menu
 Key: OFBIZ-12452
 URL: https://issues.apache.org/jira/browse/OFBIZ-12452
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Pierre Smits


When using the Helveticus Sapphire theme, the presentation of the OrderAppBar 
menu changes when a user goes from the main screen into an order. See attached 
images.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: Migration from ci.a.o

2021-12-13 Thread Pierre Smits
On my Mac the testInvoicePerShipmentSetFalse fails too, giving

assert UtilValidate.isEmpty(invoices) | | false [['orderItemSeqId':'1',
> 'amount':15.99, 'quantity':1.00, 'statusId':'INVOICE_READY',
> 'orderId':'WSCO10020', 'itemIssuanceId':'10020', 'invoiceId':'CI1',
> 'invoiceItemSeqId':'1', 'shipmentReceiptId':null]]
>
> Assertion failed:
>
> assert UtilValidate.isEmpty(invoices)
> | |
> false [['orderItemSeqId':'1', 'amount':15.99, 'quantity':1.00,
> 'statusId':'INVOICE_READY', 'orderId':'WSCO10020',
> 'itemIssuanceId':'10020', 'invoiceId':'CI1', 'invoiceItemSeqId':'1',
> 'shipmentReceiptId':null]]
>
> at
> org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670)
> at
> org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154)
> at
> org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
> at
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
> at
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
> at
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
> at
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
> at org.apache.ofbiz.base.start.Start.main(Start.java:89)
>

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Mon, Dec 13, 2021 at 10:28 AM Daniel Watford  wrote:

> Hi Jacques,
>
> After running ./gradlew testIntegration I can confirm that I see the test
> failure for testInvoicePerShipmentSetFalse.
>
> The error was visible by viewing
> $OFBIZ/runtime/logs/test-results/html/index.html in a browser and then
> navigating to the invoicestests class.
>
> On Mon, 13 Dec 2021 at 08:28, Jacques Le Roux <
> jacques.le.r...@les7arts.com>
> wrote:
>
> > Hi All,
> >
> > We have an issue with https://issues.apache.org/jira/browse/INFRA-22279
> > for tests on trunk and I need all your attention to help me fix it.
> >
> > The last successful trunk build on the old Buildbot (0.8) was <<*Oct.
> > 18*>>:
> > https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/
> >
> > Gavin has worked since on INFRA-22279 but got stuck because of (I
> > guess/hope only)  testInvoicePerShipmentSetFalse error on trunk.
> >
> > The last time I locally tried the test was 09/Nov/21 19:31
> > <
> >
> https://issues.apache.org/jira/browse/INFRA-22279?focusedCommentId=17441317=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17441317
> > >
> >
> > Yesterday, I have tried locally to run the tests 3 times (I'm on Windows
> > and there are sometimes quirks with tests) and 3 times got this sole
> > testInvoicePerShipmentSetFalse error.
> >
> > I have just checked the changes in accounting between 09/Nov/21 and now.
> I
> > did not find any evidences related to testInvoicePerShipmentSetFalse.
> >
> > I'll continue on this today, if you know better please help.
> >
> > First I'd appreciate if you can confirm you also cross the
> > testInvoicePerShipmentSetFalse error.
> >
> > TIA
> >
> > Jacques
> >
> >
> > Le 31/08/2021 à 14:08, Jacques Le Roux a écrit :
> > > Hi Gavin,
> > >
> > > Answering there
> > >
> > > Jacques
> > >
> > > Le 31/08/2021 à 11:32, Gavin McDonald a écrit :
> > >> I have created a Jira ticket where we can liaise on the migration
> which
> > I
> > >> would like to do ASAP.
> > >
>
>
>
> --
> Daniel Watford
>


[jira] [Updated] (OFBIZ-12451) VIEW permissions FinAccount mutations

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12451:
-
Description: 
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the Financial Account mutations screen  sees 
editable fields and/or triggers (to requests) reserved for users with 'CREATE' 
or 'UPDATE' permissions.

See (test with):
 * 
[https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING]
 * 
[https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw]

  was:
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the Financial Account 'Deposit/Withdraw screen 
 sees editable fields and/or triggers (to requests) reserved for users with 
'CREATE' or 'UPDATE' permissions.

See (test with):
 * 
[https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING]
 * 
https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw


> VIEW permissions FinAccount mutations
> -
>
> Key: OFBIZ-12451
> URL: https://issues.apache.org/jira/browse/OFBIZ-12451
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: financial_account, permissions, usability
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the Financial Account mutations screen  sees 
> editable fields and/or triggers (to requests) reserved for users with 
> 'CREATE' or 'UPDATE' permissions.
> See (test with):
>  * 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING]
>  * 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12451) VIEW permissions FinAccount mutations

2021-12-13 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12451:
-
Summary: VIEW permissions FinAccount mutations  (was: VIEW permissions 
PaymentsDepositWithdraw)

> VIEW permissions FinAccount mutations
> -
>
> Key: OFBIZ-12451
> URL: https://issues.apache.org/jira/browse/OFBIZ-12451
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: financial_account, permissions, usability
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the Financial Account 'Deposit/Withdraw 
> screen  sees editable fields and/or triggers (to requests) reserved for users 
> with 'CREATE' or 'UPDATE' permissions.
> See (test with):
>  * 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING]
>  * 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12451) VIEW permissions PaymentsDepositWithdraw

2021-12-13 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12451:


 Summary: VIEW permissions PaymentsDepositWithdraw
 Key: OFBIZ-12451
 URL: https://issues.apache.org/jira/browse/OFBIZ-12451
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the Financial Account 'Deposit/Withdraw screen 
 sees editable fields and/or triggers (to requests) reserved for users with 
'CREATE' or 'UPDATE' permissions.

See (test with):
 * 
[https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING]
 * 
https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-6670) Have configuration options for Content.

2021-12-12 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458179#comment-17458179
 ] 

Pierre Smits commented on OFBIZ-6670:
-

[~mbrohl],

If contributors fail to understand the reason d'être of SystemProperty records, 
then - IMO - a explanatory page in our Confluence could help. Maybe you can 
write one up?

Secretly overrides values of records in the database? Wow! Does that happen? 
How would we tell? 
All joking aside, if that happens there is something bigger going wrong in the 
organisation using OFBiz. 

Nevertheless, with metadata fields createdByUserlogin and 
lastModifiedByUserlogin automatically populated for all entities (as per 
OFBIZ-12391) you would have more insights about who created and/or modified the 
records and when. 

As for 'in the past'; we had a lot not available in the past that we have 
now. Having data in OFBiz, but not having it in OFBiz is 

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12447) Accounting remove create trigger for objects

2021-12-12 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-12447.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his assistance to get this into the codebase.

> Accounting remove create trigger for objects
> 
>
> Key: OFBIZ-12447
> URL: https://issues.apache.org/jira/browse/OFBIZ-12447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: usability
> Fix For: Upcoming Branch
>
>
> With the implementation of the Accounting MainActionMenu, various menu-items 
> and/or other triggers to create an object are now obsolete



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-11345) Lists and grids

2021-12-12 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17458009#comment-17458009
 ] 

Pierre Smits commented on OFBIZ-11345:
--

Thanks to Jacques for his assistance to the this into the codebase.

> Lists and grids
> ---
>
> Key: OFBIZ-11345
> URL: https://issues.apache.org/jira/browse/OFBIZ-11345
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: cleanup, refactoring, widget
> Fix For: Upcoming Branch
>
>
> According to the definition in widget-form.xsd the use of a combination of a 
> form with type="list" is deprecated in favour of a grid.
> Refactor various list forms into grids.
> Refactor various list form references in screens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-11782) Have a Menu in Manufacturing featuring actions to create the main objects

2021-12-12 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-11782.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his assistance to get this into the codebase

> Have a Menu in Manufacturing featuring actions to create the main objects
> -
>
> Key: OFBIZ-11782
> URL: https://issues.apache.org/jira/browse/OFBIZ-11782
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: menus, refactoring, usability
> Fix For: Upcoming Branch
>
>
> Currently the create buttons for the main objects of the manufacturing 
> application are located within find and profile widgets/templates of those 
> objects.
> In order to improve the usability of this application, OFBiz and thus the 
> appeal of it for adopters and users, these create buttons/links/etc. should 
> be in a main action menu visible at all times when a user is working within 
> the appliclation of the component.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-6670) Have configuration options for Content.

2021-12-12 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6670.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his feedback and assistance to get this into the codebase.

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (OFBIZ-6670) Have configuration options for Content.

2021-12-12 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6670:
---

Assignee: Pierre Smits

> Have configuration options for Content.
> ---
>
> Key: OFBIZ-6670
> URL: https://issues.apache.org/jira/browse/OFBIZ-6670
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


Re: Make to Order Production Run

2021-12-11 Thread Pierre Smits
A ticket to enhance inventory (demo data) of pc components would certainly
help. Demo this

Op za 11 dec. 2021 10:59 schreef Jacques Le Roux <
jacques.le.r...@les7arts.com>:

> Yes indeed, else the products are backordered, you can see that in the
> order,
>
> eg:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10004
>
> <<[10 Backordered]>> (PCs there)
>
> HTH
>
> Jacques
>
> Le 11/12/2021 à 10:52, Pierre Smits a écrit :
> > Hi Serge,
> >
> > Jacques and I tested the process this morning with ordering 10 units of
> PC
> > config:
> >
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-pcs-PC-100.html
> > .
> > When looking at the order generated in ordermgr, you'll find that there
> is
> > a production run referenced.
> >
> > After the production run is completed, and goods have moved into
> inventory
> > the order can be picked, packed, shipped and invoiced.
> >
> > Met vriendelijke groet,
> >
> > Pierre Smits
> > *Proud* *contributor** of* Apache OFBiz<https://ofbiz.apache.org/>
> since
> > 2008 (without privileges)
> > Proud contributor to the ASF since 2006
> >
> > *Apache Directory<https://directory.apache.org>, PMC Member*
> >
> >
> > On Sat, Dec 11, 2021 at 8:38 AM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi Serge,
> >>
> >> This is what products like
> >>
> >> Configurables Foods:
> >>
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-foods-FOOD-001.html
> >> and
> >> PC config:
> >>
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-pcs-PC-100.html
> >> achieve.
> >>
> >> You should look in details at how this products are produced.
> >>
> >> Or are you looking for something else?
> >>
> >> Jacques
> >>
> >>
> >> Le 09/12/2021 à 10:04, Bs Serge a écrit :
> >>> Hi,
> >>>
> >>> Any ideas on how this can be achieved would be appreciated!
> >>>
> >>> Basically it is to have a sales order linked with the manufacture of
> >>> ordered products by the buyer/customer.
> >>>
> >>> Best Regards,
> >>>
> >>> On Wed, Dec 8, 2021 at 1:06 PM Bs Serge  wrote:
> >>>
> >>>> Hi Pierre,
> >>>>
> >>>> I looked into the demo data, and I could see the pizza preparation
> >> routing
> >>>> (Stock Out and Preparation routing tasks), as shown below, but that
> did
> >> not
> >>>> answer my question except if i'm missing something.
> >>>>
> >>>>  >>>> workEffortPurposeTypeId="ROU_ASSEMBLING" currentStatusId="ROU_ACTIVE"
> >>>> workEffortName="Stock out" description="Components" revisionNumber="1"
> >>>> fixedAssetId="DEMO_FOOD_GROUP" estimatedMilliSeconds="60"
> >>>> estimatedSetupMillis="0"/>
> >>>>  >>>> workEffortPurposeTypeId="ROU_ASSEMBLING" currentStatusId="ROU_ACTIVE"
> >>>> workEffortName="Preparation" description="Preparation"
> >> revisionNumber="1"
> >>>> fixedAssetId="DEMO_FOOD_GROUP" estimatedMilliSeconds="90"
> >>>> estimatedSetupMillis="0"/>
> >>>>  >>>> currentStatusId="ROU_ACTIVE" workEffortName="Pizza preparation"
> >>>> description="Pizza preparation" revisionNumber="1"
> >> quantityToProduce="0"/>
> >>>>  >>>> workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED"
> >>>> fromDate="2004-09-24 15:10:14.227"/>
> >>>>  >>>> workEffortAssocTypeId="ROUTING_COMPONENT" sequenceNum="10"
> >>>> fromDate="2004-09-24 15:09:38.736"/>
> >>>>  >>>> workEffortAssocTypeId="ROUTING_COMPONENT" sequenceNum="20"
> >>>> fromDate="2004-09-24 15:09:47.338"/>
> >>>>
> >>>> So I'm still wondering how can one have a sales order trigger a
> >>>> manufacturing production run specifically for the buyer/customer.
> >>>>
> >>>> Best Regards,
> &

Re: Make to Order Production Run

2021-12-11 Thread Pierre Smits
Hi Serge,

Jacques and I tested the process this morning with ordering 10 units of PC
config:
https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-pcs-PC-100.html
.
When looking at the order generated in ordermgr, you'll find that there is
a production run referenced.

After the production run is completed, and goods have moved into inventory
the order can be picked, packed, shipped and invoiced.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Sat, Dec 11, 2021 at 8:38 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Serge,
>
> This is what products like
>
> Configurables Foods:
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-foods-FOOD-001.html
> and
> PC config:
> https://demo-trunk.ofbiz.apache.org/ecomseo/category/configurable-pcs-PC-100.html
> achieve.
>
> You should look in details at how this products are produced.
>
> Or are you looking for something else?
>
> Jacques
>
>
> Le 09/12/2021 à 10:04, Bs Serge a écrit :
> > Hi,
> >
> > Any ideas on how this can be achieved would be appreciated!
> >
> > Basically it is to have a sales order linked with the manufacture of
> > ordered products by the buyer/customer.
> >
> > Best Regards,
> >
> > On Wed, Dec 8, 2021 at 1:06 PM Bs Serge  wrote:
> >
> >> Hi Pierre,
> >>
> >> I looked into the demo data, and I could see the pizza preparation
> routing
> >> (Stock Out and Preparation routing tasks), as shown below, but that did
> not
> >> answer my question except if i'm missing something.
> >>
> >>  >> workEffortPurposeTypeId="ROU_ASSEMBLING" currentStatusId="ROU_ACTIVE"
> >> workEffortName="Stock out" description="Components" revisionNumber="1"
> >> fixedAssetId="DEMO_FOOD_GROUP" estimatedMilliSeconds="60"
> >> estimatedSetupMillis="0"/>
> >>  >> workEffortPurposeTypeId="ROU_ASSEMBLING" currentStatusId="ROU_ACTIVE"
> >> workEffortName="Preparation" description="Preparation"
> revisionNumber="1"
> >> fixedAssetId="DEMO_FOOD_GROUP" estimatedMilliSeconds="90"
> >> estimatedSetupMillis="0"/>
> >>  >> currentStatusId="ROU_ACTIVE" workEffortName="Pizza preparation"
> >> description="Pizza preparation" revisionNumber="1"
> quantityToProduce="0"/>
> >>  >> workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED"
> >> fromDate="2004-09-24 15:10:14.227"/>
> >>  >> workEffortAssocTypeId="ROUTING_COMPONENT" sequenceNum="10"
> >> fromDate="2004-09-24 15:09:38.736"/>
> >>  >> workEffortAssocTypeId="ROUTING_COMPONENT" sequenceNum="20"
> >> fromDate="2004-09-24 15:09:47.338"/>
> >>
> >> So I'm still wondering how can one have a sales order trigger a
> >> manufacturing production run specifically for the buyer/customer.
> >>
> >> Best Regards,
> >>
> >> On Tue, Dec 7, 2021 at 10:57 AM Pierre Smits 
> >> wrote:
> >>
> >>> Good morning Serge,
> >>>
> >>> You can take a look at how (in demo) OFBiz provides functionalities for
> >>> this. In the demo (datasets), this is done via the pizza examples.
> >>>
> >>>
> >>> Met vriendelijke groet,
> >>>
> >>> Pierre Smits
> >>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/>
> since
> >>> 2008 (without privileges)
> >>> Proud contributor to the ASF since 2006
> >>>
> >>> *Apache Directory <https://directory.apache.org>, PMC Member*
> >>>
> >>>
> >>> On Mon, Dec 6, 2021 at 9:40 AM Bs Serge  wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> Referring to the Manufacturing & MRP Tutorial (from Sharan Foga) It is
> >>>> mentioned that OFBiz supports a Make to Order (MTO) process where the
> >>>> manufacturing process is triggered by an order from a customer. The
> >>> product
> >>>> is manufactured specifically for that customer.
> >>>>
> >>>> In OFBiz I can start & complete production runs with routing tasks but
> >>> I’m
> >>>> having trouble connecting a product sales order with a production run.
> >>>>
> >>>> So I’m wondering how does that happen? How does a product sales order
> >>>> trigger the manufacturing production run of a certain ordered product?
> >>>>
> >>>> Best Regards,
> >>>>
>


[jira] [Commented] (OFBIZ-11345) Lists and grids

2021-12-10 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17457027#comment-17457027
 ] 

Pierre Smits commented on OFBIZ-11345:
--

Thanks to Jacques for his assistance to get this into the codebase.

> Lists and grids
> ---
>
> Key: OFBIZ-11345
> URL: https://issues.apache.org/jira/browse/OFBIZ-11345
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: cleanup, refactoring, widget
> Fix For: Upcoming Branch
>
>
> According to the definition in widget-form.xsd the use of a combination of a 
> form with type="list" is deprecated in favour of a grid.
> Refactor various list forms into grids.
> Refactor various list form references in screens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12448) VIEW permissions Budget Attributes

2021-12-10 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12448:


 Summary: VIEW permissions Budget Attributes
 Key: OFBIZ-12448
 URL: https://issues.apache.org/jira/browse/OFBIZ-12448
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Though there is an entity BudgetAttribute this cannot be accessed by user with 
VIEW permissions when accessing a Budget.

See:
 * for entity data: 
https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/BudgetAttribute
 * test budget: 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditBudget?budgetId=DemoBudget001



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12447) Accounting remove create trigger for Invoice

2021-12-10 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12447:


 Summary: Accounting remove create trigger for Invoice
 Key: OFBIZ-12447
 URL: https://issues.apache.org/jira/browse/OFBIZ-12447
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


With the implementation of the Accounting MainActionMenu, various menu-items 
and/or other triggers to create an object are now obsolete



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12447) Accounting remove create trigger for objects

2021-12-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12447:
-
Summary: Accounting remove create trigger for objects  (was: Accounting 
remove create trigger for Invoice)

> Accounting remove create trigger for objects
> 
>
> Key: OFBIZ-12447
> URL: https://issues.apache.org/jira/browse/OFBIZ-12447
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: usability
>
> With the implementation of the Accounting MainActionMenu, various menu-items 
> and/or other triggers to create an object are now obsolete



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-11780) Have a Menu in Accounting featuring actions to create the main objects

2021-12-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-11780.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his feedback and assistance to get this into the codebase.

> Have a Menu in Accounting featuring actions to create the main objects
> --
>
> Key: OFBIZ-11780
> URL: https://issues.apache.org/jira/browse/OFBIZ-11780
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: menus, refactoring, usability
> Fix For: Upcoming Branch
>
>
> Currently the create buttons for the main objects of the accounting 
> application are located within find and profile widgets/templates of those 
> objects.
> In order to improve the usability of this application, OFBiz and thus the 
> appeal of it for adopters and users, these create buttons/links/etc. should 
> be in a main action menu visible at all times when a user (with the CREATE 
> permission) is working within the application of the component.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12442) VIEW permissions show ManufacturingAppBar items

2021-12-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-12442.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his assistance to get this into the codebase.

> VIEW permissions show ManufacturingAppBar items
> ---
>
> Key: OFBIZ-12442
> URL: https://issues.apache.org/jira/browse/OFBIZ-12442
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: manufacturing, menu-item, permissions, usability
> Fix For: Upcoming Branch
>
>
> Currently, when a user with only VIEW permissions accesses the manufacturing 
> component menu-items of the ManufacturingAppBar are not shown due to too 
> restrictive conditions. 
> These menu-items allow users to access various overviews related to 
> manufacturing, like
>  * production runs, 
>  * routings (production schemas),
>  * routing task (schema tasks),
>  * production calendar,
>  * etc.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11780) Have a Menu in Accounting featuring actions to create the main objects

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11780:
-
Description: 
Currently the create buttons for the main objects of the accounting application 
are located within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz and thus the 
appeal of it for adopters and users, these create buttons/links/etc. should be 
in a main action menu visible at all times when a user (with the CREATE 
permission) is working within the application of the component.

  was:
Currently the create buttons for the main objects of the accounting application 
are located within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz and thus the 
appeal of it for adopters and users, these create buttons/links/etc. should be 
in a main action menu visible at all times when a user is working within the 
appliclation of the component.


> Have a Menu in Accounting featuring actions to create the main objects
> --
>
> Key: OFBIZ-11780
> URL: https://issues.apache.org/jira/browse/OFBIZ-11780
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: menus, refactoring, usability
>
> Currently the create buttons for the main objects of the accounting 
> application are located within find and profile widgets/templates of those 
> objects.
> In order to improve the usability of this application, OFBiz and thus the 
> appeal of it for adopters and users, these create buttons/links/etc. should 
> be in a main action menu visible at all times when a user (with the CREATE 
> permission) is working within the application of the component.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12439) VIEW permissions Payment Attributes

2021-12-09 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456291#comment-17456291
 ] 

Pierre Smits commented on OFBIZ-12439:
--

Hi Jacques,
{noformat}
#1 Showing the payment (or invoice) sub-menu when there is no info (like in 
overview) about the payment (or invoice) seems ambiguous to me. For instance 
for payment attribute there is a Create button but it's to create a payment not 
an attribute.
#2 I understand it's only about view, but, for both invoice and payment, would 
not be logical to have an attribut create feature before being able to view 
it?{noformat}
Re #1 Indeed, the label for the 'create' trigger is ambiguous. As a result of 
past choices. I tried to fix that with OFBIZ-11780 and PR181 in June of 2020. 
But that didn't get in. If it had been, the trigger for sub elements of an 
object (Invoice, Payment, etc) either via SubTabBar menu or directly 
(via links) would have been much less ambiguous. 

Re #2 That, my friend, is a classic chicken and egg situation. And the lack of 
functionality to create something regarding an entity is another issue and 
ticket.

> VIEW permissions Payment Attributes
> ---
>
> Key: OFBIZ-12439
> URL: https://issues.apache.org/jira/browse/OFBIZ-12439
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: attribute, payment, permissions, usability
>
> Though there is an entity PaymentAttribute this cannot be accessed by user 
> with VIEW permissions when accessing a Payment.
> See:
>  * for entity data: 
> https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/PaymentAttribute
>  * test payment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=8003



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12439) VIEW permissions Payment Attributes

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-12439.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his feedback and assistance to get this into the codebase.

> VIEW permissions Payment Attributes
> ---
>
> Key: OFBIZ-12439
> URL: https://issues.apache.org/jira/browse/OFBIZ-12439
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: attribute, payment, permissions, usability
> Fix For: Upcoming Branch
>
>
> Though there is an entity PaymentAttribute this cannot be accessed by user 
> with VIEW permissions when accessing a Payment.
> See:
>  * for entity data: 
> https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/PaymentAttribute
>  * test payment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=8003



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12162:
-
Labels: css theme  (was: )

> Single Form Widget on CSS Grid Layout
> -
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
>  Labels: css, theme
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form 
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12162:
-
Fix Version/s: (was: Upcoming Branch)

> Single Form Widget on CSS Grid Layout
> -
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form 
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12162:
-
Affects Version/s: Trunk
   (was: Upcoming Branch)

> Single Form Widget on CSS Grid Layout
> -
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form 
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-12-09 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456237#comment-17456237
 ] 

Pierre Smits commented on OFBIZ-12162:
--

Hi Jacques,

Now I am. Set the link.

> Single Form Widget on CSS Grid Layout
> -
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form 
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-11712) Have a service that retrieves the parties with a particular roleTypeId

2021-12-09 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456236#comment-17456236
 ] 

Pierre Smits commented on OFBIZ-11712:
--

Hi [~priya.sharma.9362],

Thanks you for the feedback. I will have a look at that.

> Have a service that retrieves the parties with a particular roleTypeId
> --
>
> Key: OFBIZ-11712
> URL: https://issues.apache.org/jira/browse/OFBIZ-11712
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: agreements, assignment, invoice, quote, role, roles
>
> Various create or edit forms involving assigning parties to a role for a 
> particular artefact (or object, like agreement, order, quote, invoice, etc) 
> allow to select from all parties and from all roles.
> See as an example of this: 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/EditQuoteRole?quoteId=CQ0001
> However, for many of those artefacts (or objects) there are specific roleType 
> records defined to cater to either permission related functions or to provide 
> flow functions regarding the objects.
> In order to help assigning a party for a given role associated to the object, 
> a generic service is required that retrieves the parties associated with the 
> role.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12370) InvoiceRole: impossible combination of party and role selectable: leads to error

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12370:
-
Parent: OFBIZ-12445
Issue Type: Sub-task  (was: Bug)

> InvoiceRole: impossible combination of party and role selectable: leads to 
> error
> 
>
> Key: OFBIZ-12370
> URL: https://issues.apache.org/jira/browse/OFBIZ-12370
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk, 17.12.08, 18.12.01
>    Reporter: Pierre Smits
>Priority: Major
>  Labels: roles
>
> On the invoice role page in accounting (see e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/invoiceRoles?invoiceId=demo10001]
>  ) it is possible to select an impossible combination of a party and a role. 
> After the submit an error is shown:
> {code:java}
> The Following Errors Occurred:Exception thrown while creating the "newEntity" 
> GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: [GenericEntity:InvoiceRole][createdStamp,2021-11-09 
> 10:21:14.073(java.sql.Timestamp)][createdTxStamp,2021-11-09 
> 10:21:14.02(java.sql.Timestamp)][datetimePerformed,2021-11-09 
> 10:21:14.073(java.sql.Timestamp)][invoiceId,demo10001(java.lang.String)][lastUpdatedStamp,2021-11-09
>  10:21:14.073(java.sql.Timestamp)][lastUpdatedTxStamp,2021-11-09 
> 10:21:14.02(java.sql.Timestamp)][partyId,DemoLead(java.lang.String)][percentage,null()][roleTypeId,INTERNAL_ORGANIZATIO(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.INVOICE_ROLE 
> (INVOICE_ID, PARTY_ID, ROLE_TYPE_ID, DATETIME_PERFORMED, PERCENTAGE, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) 
> VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'INVOICE_ROLE' caused a 
> violation of foreign key constraint 'INVCE_RLE_PTRL' for key 
> (DemoLead,INTERNAL_ORGANIZATIO). The statement has been rolled back.)) (Error 
> while inserting: [GenericEntity:InvoiceRole][createdStamp,2021-11-09 
> 10:21:14.073(java.sql.Timestamp)][createdTxStamp,2021-11-09 
> 10:21:14.02(java.sql.Timestamp)][datetimePerformed,2021-11-09 
> 10:21:14.073(java.sql.Timestamp)][invoiceId,demo10001(java.lang.String)][lastUpdatedStamp,2021-11-09
>  10:21:14.073(java.sql.Timestamp)][lastUpdatedTxStamp,2021-11-09 
> 10:21:14.02(java.sql.Timestamp)][partyId,DemoLead(java.lang.String)][percentage,null()][roleTypeId,INTERNAL_ORGANIZATIO(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.INVOICE_ROLE 
> (INVOICE_ID, PARTY_ID, ROLE_TYPE_ID, DATETIME_PERFORMED, PERCENTAGE, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) 
> VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'INVOICE_ROLE' caused a 
> violation of foreign key constraint 'INVCE_RLE_PTRL' for key 
> (DemoLead,INTERNAL_ORGANIZATIO). The statement has been rolled back.))) {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12446) InvoiceRole (demo) dataset

2021-12-09 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456223#comment-17456223
 ] 

Pierre Smits commented on OFBIZ-12446:
--

Following the pattern used with BudgetRole

> InvoiceRole (demo) dataset
> --
>
> Key: OFBIZ-12446
> URL: https://issues.apache.org/jira/browse/OFBIZ-12446
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, role, usability
>
> Based on the description of OFBIZ-12445, have InvoiceRole data in the data 
> set.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12446) InvoiceRole (demo) dataset

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12446:
-
Labels: invoice role usability  (was: )

> InvoiceRole (demo) dataset
> --
>
> Key: OFBIZ-12446
> URL: https://issues.apache.org/jira/browse/OFBIZ-12446
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, role, usability
>
> Based on the description of OFBIZ-12445, have InvoiceRole data in the data 
> set.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12446) InvoiceRole (demo) dataset

2021-12-09 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12446:


 Summary: InvoiceRole (demo) dataset
 Key: OFBIZ-12446
 URL: https://issues.apache.org/jira/browse/OFBIZ-12446
 Project: OFBiz
  Issue Type: Sub-task
  Components: datamodel
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Based on the description of OFBIZ-12445, have InvoiceRole data in the data set.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-6002) Have the RoleType field in AddInvoiceRole only show the roles of the selected party

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6002.
---
Resolution: Won't Do

Closing as 'won't do' due to being superseded by OFBIZ-12445

> Have the RoleType field in AddInvoiceRole only show the roles of the selected 
> party
> ---
>
> Key: OFBIZ-6002
> URL: https://issues.apache.org/jira/browse/OFBIZ-6002
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>    Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, roles
>
> Currently, and regardless of the party selected, the roletype fields show all 
> possible roletypes. This field should only show the roles of the party 
> selected, and it should only show the roles available at the moment of 
> creation of the invoice role (life-span, filter-by-date).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (OFBIZ-6002) Have the RoleType field in AddInvoiceRole only show the roles of the selected party

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6002:
---

Assignee: Pierre Smits

> Have the RoleType field in AddInvoiceRole only show the roles of the selected 
> party
> ---
>
> Key: OFBIZ-6002
> URL: https://issues.apache.org/jira/browse/OFBIZ-6002
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>    Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, roles
>
> Currently, and regardless of the party selected, the roletype fields show all 
> possible roletypes. This field should only show the roles of the party 
> selected, and it should only show the roles available at the moment of 
> creation of the invoice role (life-span, filter-by-date).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12444) Entity InvoiceRole

2021-12-09 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12444:
-
Parent: OFBIZ-12445
Issue Type: Sub-task  (was: Improvement)

> Entity InvoiceRole
> --
>
> Key: OFBIZ-12444
> URL: https://issues.apache.org/jira/browse/OFBIZ-12444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>    Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, role
>
> Based on page regarding EntityNameRole page in Confluence (see link) and the 
> discussions on dev ml, the entity definition for InvoiceRole does not comply 
> with the rules as outlined in the page. 
> It is missing the fromDate and thruDate fields, and the from date field being 
> part of the primary key of the entity



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


<    3   4   5   6   7   8   9   10   11   12   >