Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200818671
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2756#discussion_r200818673
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -80,22 +81,24 @@ public void refresh() {
List mine
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200803766
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/NamedTopicFilter.java
---
@@ -54,8 +57,12 @@ public NamedTopicFilter(String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200803791
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/NamedTopicFilterTest.java
---
@@ -63,6 +63,20 @@ public void testFilter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2755#discussion_r200803795
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicPartitionConnections.java
---
@@ -57,6 +57,7 @@ public SimpleConsumer register(Partition
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2443
@HeartSaVioR Are you still planning on getting this in? I could probably
put some time in to trying this out if no one else is willing to test/use
storm-sql, so we can get a +1.
---
Merge branch 'STORM-3090' of https://github.com/choojoyq/storm into
asfgit-1.x-branch
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/83e5788c
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/83e5788c
Diff:
Repository: storm
Updated Branches:
refs/heads/1.x-branch 9938ed357 -> 83e5788c0
STORM-3090 - use topic together with partition number during recreation of
partition managers
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
Is this ready to merge @choojoyq?
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200657323
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java ---
@@ -140,6 +140,42 @@ public void testPartitionManagerRecreate
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200653436
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
I guess this should target 1.0.x-branch, going by the listed commits.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2755
@aniketalhat I think you are targeting the wrong branch. You should target
the branch you started working on (e.g. 1.x-branch).
We can review 1.x first, but we'll also need a PR against master
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
The changes look good to me, +1. Left some comments, but I don't think it
makes sense to put too much effort into making the tests more realistic, or
refactoring, given that storm-kafka is being
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200456835
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ZkCoordinator.java ---
@@ -107,14 +110,14 @@ public void refresh
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2726#discussion_r200456703
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/ZkCoordinatorTest.java ---
@@ -140,6 +140,42 @@ public void testPartitionManagerRecreate
Merge branch 'STORM-3142' of https://github.com/srdo/storm into asfgit-master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/db86bade
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/db86bade
Diff: http://git-wip
Repository: storm
Updated Branches:
refs/heads/master 26d2f9552 -> db86bade0
STORM-3142: Add JUnit 5 support, migrate a couple of tests in
storm-kafka-client to check that both JUnit 5 and 4 work. Also fix
storm-kafka-client tests so they delete their temporary directories when done
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2750#discussion_r200445007
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -22,56 +22,53 @@
import java.util.List;
import
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2751
STORM-3142: Add JUnit 5 support, migrate a couple of tests in storm-kâ¦
â¦afka-client to check that both JUnit 5 and 4 work. Also fix
storm-kafka-client tests so they delete their temporary
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2750
STORM-3141: Fix NPE in WorkerState.transferLocalBatch, and refactor Bâ¦
â¦ackpressureTracker to get rid of placeholder JCQueue
https://issues.apache.org/jira/browse/STORM-3141
You can merge
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199600468
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199574066
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
@revans2 Good point. It probably doesn't hurt much in the real code,
because the queue is only shut down when the worker or executor is shut down.
It could be an issue for tests with LocalCluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199566175
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimedResource.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2746
Ran this 4 times on top of the changes from
https://github.com/apache/storm/pull/2733 on Travis, runs of the integration
test passed.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2748
+1
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2749
STORM-3137: Fix too strict mock verification in nimbus_test
https://issues.apache.org/jira/browse/STORM-3137
You can merge this pull request into a Git repository by running:
$ git pull https
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2745
The failure is unrelated, raised an issue at
https://issues.apache.org/jira/browse/STORM-3137 to track.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2746
STORM-3136: Fix flaky integration test, clean up that code to be moreâ¦
⦠readable
https://issues.apache.org/jira/browse/STORM-3136
* Deduplicated the test spouts and bolts a bit
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2742
+1 (relying on the tests here)
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199277655
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/TimedWritableByteChannel.java
---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2743#discussion_r199278789
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/timed/TimedResource.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2745
STORM-3135: Allow JCQueueTest to retry interrupting the consumer if tâ¦
â¦he queue happens to be full
https://issues.apache.org/jira/browse/STORM-3135
You can merge this pull request
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2741#discussion_r199193610
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/KerberosSaslClientHandler.java
---
@@ -96,53 +96,69 @@ private void handleControlMessage
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2741#discussion_r199057391
--- Diff:
storm-client/src/jvm/org/apache/storm/messaging/netty/KerberosSaslClientHandler.java
---
@@ -96,53 +96,69 @@ private void handleControlMessage
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2733
@revans2 Rebased
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2735#discussion_r198022430
--- Diff: storm-core/pom.xml ---
@@ -184,6 +184,10 @@
mockito-core
test
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2737
+1
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857993
--- Diff: storm-core/test/resources/log4j2-test.xml ---
@@ -23,7 +23,8
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857694
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -185,8 +173,17 @@ public static void advanceTimeNanos(long nanos
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857719
--- Diff: storm-core/pom.xml ---
@@ -184,6 +184,10 @@
mockito-core
test
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2733#discussion_r197857597
--- Diff: dev-tools/travis/travis-script.sh ---
@@ -31,7 +31,14 @@ else
# Travis only has 3GB of memory, lets use 1GB for build, and 1.5GB for
forked
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2735#discussion_r197856967
--- Diff: storm-core/pom.xml ---
@@ -184,6 +184,10 @@
mockito-core
test
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197856612
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -185,8 +173,17 @@ public static void advanceTimeNanos(long nanos
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197838009
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -82,45 +66,49 @@ public static void sleepUntilNanos(long
targetTimeNanos) throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197686220
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -82,45 +66,49 @@ public static void sleepUntilNanos(long
targetTimeNanos) throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197686035
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Time.java ---
@@ -82,45 +66,49 @@ public static void sleepUntilNanos(long
targetTimeNanos) throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197652839
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -196,6 +196,9 @@ private LocalCluster(Builder builder) throws Exception
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2736
MINOR: Mkdir for storm.home when running LocalCluster
Turns out Rocksdb doesn't handle creating parent directories, so
https://github.com/apache/storm/pull/2728 doesn't prevent it from throwing
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2734#discussion_r197652495
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -196,6 +196,9 @@ private LocalCluster(Builder builder) throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2735#discussion_r197652249
--- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj ---
@@ -87,12 +91,22 @@
(first) ;; pick first task in the list, ignore other tasks
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2735
I saw failures in the metrics tests very often when adding Java 10 to the
testing matrix, e.g. https://travis-ci.org/srdo/storm/builds/395663084. Maybe
Travis runs the tests on the same machine
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2733
Pulled metrics test changes and Time changes into
https://github.com/apache/storm/pull/2735 and
https://github.com/apache/storm/pull/2734. Will rebase this once those get
merged.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2735
STORM-3121: Fix flaky metrics tests in storm-core
https://issues.apache.org/jira/browse/STORM-3121
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2734
STORM-3120: Clean up leftover null checks in Time, ensure idle threadâ¦
â¦s get to run when cluster time is advanced
https://issues.apache.org/jira/browse/STORM-3120
Some
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2733
Fair enough, will split this up.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2733
STORM-3119: Build Storm with Java 10
https://issues.apache.org/jira/browse/STORM-3119
There are some changes in this PR that are only tangentially related to
building with JDK10, namely fixes
Merge branch 'storm3064' of https://github.com/milantracy/storm into
asfgit-master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/41cf4f32
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/41cf4f32
Diff:
Repository: storm
Updated Branches:
refs/heads/master 7122a4e2c -> 41cf4f322
STORM-3064: PartitionedTridentSpoutExecutor should use getPartitionsForTask
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b80cd70d
Tree:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2731
+1
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
@milantracy Looks great. Please squash to one commit, and we can merge once
the 24 hour waiting period is over.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2729#discussion_r197162525
--- Diff:
storm-client/src/jvm/org/apache/storm/trident/spout/IPartitionedTridentSpout.java
---
@@ -36,7 +37,7 @@
interface Coordinator
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2729
+1, looks good.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2728#discussion_r196559711
--- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java ---
@@ -193,6 +194,10 @@ private LocalCluster(Builder builder) throws Exception
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2728
STORM-3116: Set storm.home for clojure tests and during LocalCluster â¦
â¦runs
https://issues.apache.org/jira/browse/STORM-3116
You can merge this pull request into a Git repository
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@danny0405 Okay, thanks. I think the MetricRegistryImpl class looks nice
https://github.com/apache/flink/blob/16ec3d7ea12c520c5c86f0721553355cc938c2ae/flink-runtime/src/main/java/org/apache/flink
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2725
STORM-3114: Ban jdk.tools
https://issues.apache.org/jira/browse/STORM-3114
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3114
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2724
STORM-3113: Upgrade Mockito to fix Java 10 incompatibility
https://issues.apache.org/jira/browse/STORM-3113
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user srdo opened a pull request:
https://github.com/apache/storm-site/pull/6
Add southcom to powered by
Requested on the mailing list
http://mail-archives.apache.org/mod_mbox/storm-dev/201806.mbox/%3CCAHKhnHw%3Dcpt76XGCEvu7XTs2a_vX%2B5bh_6pEPCmTvLQ8nWJ3RA%40mail.gmail.com%3E
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@danny0405 A quick search for Role or MetricsGroup in the flink repo didn't
turn up anything. Could you elaborate on what you mean, and why/how we could
use Flink's mechanism here?
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
It might be good to consider whether we could move away from `static` for
metrics, and consider if we could do dependency injection instead? The cause of
the issue you mention on JIRA (accidentally
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2713
Thanks @ManoharVanam, merged to 1.x and 1.1.x
---
Repository: storm
Updated Branches:
refs/heads/1.1.x-branch 83bc0f3b7 -> f0a35bd65
[STORM-3094] : Added topology name validation at client side
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f0a35bd6
Tree:
Repository: storm
Updated Branches:
refs/heads/1.1.x-branch 6542f0c9a -> 83bc0f3b7
STORM-3109: Fixed incorrect conversion from relative path to absolute path for
STORM_LOCAL_DIR
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Repository: storm
Updated Branches:
refs/heads/1.x-branch b0f34ac1b -> 8fabff553
STORM-3109: Fixed incorrect conversion from relative path to absolute path for
STORM_LOCAL_DIR
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Repository: storm
Updated Branches:
refs/heads/master 15a9a3bac -> d3625b098
STORM-3109: Fixed incorrect conversion from relative path to absolute path for
STORM_LOCAL_DIR
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Merge branch 'STORM-3109' of https://github.com/zd-project/storm into
asfgit-master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d3625b09
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/d3625b09
Diff:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2720
Ah right. Thanks, that makes sense. +1
---
Merge branch 'agresch_timer' of https://github.com/agresch/storm into
STORM-3103-merge
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/15a9a3ba
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/15a9a3ba
Diff:
Repository: storm
Updated Branches:
refs/heads/master 1e3ab3ac3 -> 15a9a3bac
STORM-3103 allow nimbus to shutdown properly
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5c5d0713
Tree:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2718
+1
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2720
Could you explain a bit more why the conversion to absolute path is a
problem? I'm having a hard time understanding why kill_workers would break if
the STORM_LOCAL_DIR is given as an absolute path.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2722
STORM-3111: Remove dead code in StormSubmitter related to local mode
https://issues.apache.org/jira/browse/STORM-3111
You can merge this pull request into a Git repository by running:
$ git pull
Merge branch 'bugfix/STORM-3102-kafka-client-performance-storm-1.1.x' of
https://github.com/acseidel/storm into asfgit-1.1.x
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/6542f0c9
Tree:
Repository: storm
Updated Branches:
refs/heads/1.1.x-branch 2dc3d53a1 -> 6542f0c9a
STORM-3102 Remove check for partition offset before every emit.
IN kafka >0.10.2 this check became expensive, causing large performance
decreases.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Repository: storm
Updated Branches:
refs/heads/1.x-branch 24f0ff0b9 -> b0f34ac1b
STORM-3102 Remove check for partition offset before every emit.
IN kafka >0.10.2 this check became expensive, causing large performance
decreases.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Merge branch 'bugfix/STORM-3102-kafka-client-performance-storm-1.x' of
https://github.com/acseidel/storm into asfgit-1.x-branch
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b0f34ac1
Tree:
Merge branch 'bugfix/STORM-3102-kafka-client-performance-storm-2.0.0' of
https://github.com/acseidel/storm into asfgit-master
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/1e3ab3ac
Tree:
Repository: storm
Updated Branches:
refs/heads/master 0cb659040 -> 1e3ab3ac3
STORM-3102 Remove check for partition offset before every emit.
IN kafka >0.10.2 this check became expensive, causing large performance
decreases.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit:
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2715
+1
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2717
+1. Please squash to one commit.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2716
+1
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194141182
--- Diff: shaded-deps/pom.xml ---
@@ -251,6 +253,10 @@
org.jboss.netty
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r194140703
--- Diff: storm-client/pom.xml ---
@@ -172,7 +172,7 @@
**/generated
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2704
Rebased, and put in a work around for the flaky test. The test was using
the fact that the client's channel to the server was open as indication that
the channelConnected method must have finished
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2707
Thanks, +1 again
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2698
Looks great. +1.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2707
Remember https://github.com/apache/storm/blob/master/docs/storm-druid.md
and any links in the other docs referring to druid. +1 otherwise.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2706
+1, but please also add the note to
https://github.com/apache/storm/blob/1.x-branch/docs/storm-druid.md
---
601 - 700 of 2639 matches
Mail list logo
