Re: [PR] using tikv limited scan to avoid oom [flink-cdc]
PatrickRen closed pull request #2145: using tikv limited scan to avoid oom URL: https://github.com/apache/flink-cdc/pull/2145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update OracleScanFetchTask.java [flink-cdc]
PatrickRen closed pull request #2097: Update OracleScanFetchTask.java URL: https://github.com/apache/flink-cdc/pull/2097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add a table of cdc json type [flink-cdc]
PatrickRen closed pull request #2067: Add a table of cdc json type URL: https://github.com/apache/flink-cdc/pull/2067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]
doris-robot commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2124029363 TPC-DS: Total hot run time: 202347 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ff07338349d02fe88658ce3a7e9ab429ea955b52, data reload: false query1 937 384 375 375 query2 6544269723812381 query3 6916205 210 205 query4 21374 18032 17887 17887 query5 19747 655565436543 query6 274 223 223 223 query7 4153316 326 316 query8 250 247 229 229 query9 3151267426392639 query10 400 300 287 287 query11 11302 10768 10793 10768 query12 123 78 81 78 query13 5581685 679 679 query14 17939 13633 13475 13475 query15 358 221 238 221 query16 6470271 254 254 query17 17621453867 867 query18 2335398 405 398 query19 203 149 151 149 query20 80 78 79 78 query21 191 93 97 93 query22 5341502250345022 query23 32473 31914 31986 31914 query24 7013654965826549 query25 517 437 405 405 query26 529 157 164 157 query27 1882296 288 288 query28 6228234723092309 query29 2966269928722699 query30 241 164 162 162 query31 918 741 752 741 query32 70 62 57 57 query33 400 247 245 245 query34 854 464 470 464 query35 1126918 894 894 query36 1281109111581091 query37 94 62 63 62 query38 3056292529272925 query39 1390131713281317 query40 201 93 93 93 query41 37 42 35 35 query42 85 87 81 81 query43 719 720 713 713 query44 1140711 715 711 query45 237 235 223 223 query46 1227953 959 953 query47 1812191717081708 query48 1006724 699 699 query49 620 370 362 362 query50 880 612 610 610 query51 4752461446134613 query52 95 81 82 81 query53 444 320 319 319 query54 2647243024282428 query55 90 78 87 78 query56 228 233 209 209 query57 1170114110761076 query58 219 202 200 200 query59 4302427938643864 query60 216 213 196 196 query61 90 82 83 82 query62 866 455 470 455 query63 474 344 333 333 query64 2542147714441444 query65 3615354537053545 query66 820 433 387 387 query67 17299 15017 15411 15017 query68 8349651 654 651 query69 550 333 349 333 query70 1796147912981298 query71 398 306 324 306 query72 6526340434093404 query73 739 328 317 317 query74 6352593058555855 query75 4499378037043704 query76 4685115412161154 query77 562 258 250 250 query78 12590 11530 11901 11530 query79 8157640 646 640 query80 1667385 390 385 query81 513 231 234 231 query82 148199 93 93 query83 169 130 135 130 query84 262 69 69 69 query85 1265295 294 294 query86 357 293 289 289 query87 3205296829842968 query88 5240234423292329 query89 371 292 286 286 query90 1809210 220 210 query91 178 138 149 138 query92 61 53 52 52 query93 4695559 606 559 query94 871 204 197 197 query95 1113104310561043 query96 649 336 326 326 query97 6480628964546289 query98 194 181 175 175 query99 2827934 881 881 Total cold run time: 312912 ms Total hot run time: 202347 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
[PR] Bump Snappy v1.2.1 [kvrocks]
aleksraiden opened a new pull request, #2325: URL: https://github.com/apache/kvrocks/pull/2325 Patch release, restore ABI incomparability issue (see: https://github.com/google/snappy/issues/183) Release notes: https://github.com/google/snappy/releases/tag/1.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add contract first development section in rest-openapi doc [camel-quarkus]
zhfeng commented on code in PR #6115: URL: https://github.com/apache/camel-quarkus/pull/6115#discussion_r1609411148 ## extensions/rest-openapi/runtime/src/main/doc/usage.adoc: ## @@ -24,4 +24,55 @@ When using the `classpath` resource locator with native code, the path to the Op [source] quarkus.native.resources.includes=openapi.json - \ No newline at end of file + + +=== Contract First Development +The model classes generation has been integrated with `quarkus-maven-plugin`. So it's no need to use `swagger-codegen-maven-plugin`, instead to put your contract files in the `src/main/openapi` with `.json` suffix. And add `generate-code` goal in `quarkus-maven-plugin` like: + +[source,xml] + + +io.quarkus +quarkus-maven-plugin + + + +generate-code + + + + + + +It requires to specific the package name of the model classes by using `quarkus.camel.openapi.codegen.model-package` property of the `application.properties` file. For example: Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#1711] feat(server): Introduce the reconfigurable conf [incubator-uniffle]
zuston commented on code in PR #1712:
URL:
https://github.com/apache/incubator-uniffle/pull/1712#discussion_r160944
##
common/src/main/java/org/apache/uniffle/common/ReconfigurableConfManager.java:
##
@@ -0,0 +1,53 @@
+package org.apache.uniffle.common;
+
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.uniffle.common.config.ConfigOption;
+import org.apache.uniffle.common.config.RssBaseConf;
+import org.apache.uniffle.common.config.RssConf;
+import org.apache.uniffle.common.util.ThreadUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ReconfigurableConfManager {
+private static final Logger LOGGER =
LoggerFactory.getLogger(ReconfigurableConfManager.class);
+
+private static RssBaseConf rssConf;
+private ScheduledExecutorService scheduledThreadPoolExecutor;
+
+private ReconfigurableConfManager(Supplier confSupplier) {
+rssConf = confSupplier.get();
+scheduledThreadPoolExecutor =
ThreadUtils.getDaemonSingleThreadScheduledExecutor("Refresh-rss-conf");
+scheduledThreadPoolExecutor.schedule(() -> {
+try {
+rssConf.addAll(confSupplier.get());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2124030163 `shuffle`, `array_sort` are already supported, can be marked as complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
[PR] Part of the document content is added and adjusted, and it is adapted to the Chinese and English formats of the document. [shardingsphere]
DIDA-lJ opened a new pull request, #31340: URL: https://github.com/apache/shardingsphere/pull/31340 Changes proposed in this pull request: - Part of the document content is added and adjusted, and it is adapted to the Chinese and English formats of the document. --- Before committing this PR, I'm sure that I have checked the following options: - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project. - [ ] I have self-reviewed the commit code. - [ ] I have (or in comment I request) added corresponding labels for the pull request. - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. - [ ] I have made corresponding changes to the documentation. - [ ] I have added corresponding unit tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add contract first development section in rest-openapi doc [camel-quarkus]
zhfeng commented on code in PR #6115: URL: https://github.com/apache/camel-quarkus/pull/6115#discussion_r1609410873 ## extensions/rest-openapi/runtime/src/main/doc/usage.adoc: ## @@ -24,4 +24,55 @@ When using the `classpath` resource locator with native code, the path to the Op [source] quarkus.native.resources.includes=openapi.json - \ No newline at end of file + + +=== Contract First Development +The model classes generation has been integrated with `quarkus-maven-plugin`. So it's no need to use `swagger-codegen-maven-plugin`, instead to put your contract files in the `src/main/openapi` with `.json` suffix. And add `generate-code` goal in `quarkus-maven-plugin` like: Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat: instance interface [dubbo-kubernetes]
chickenlj commented on code in PR #286:
URL: https://github.com/apache/dubbo-kubernetes/pull/286#discussion_r1609404126
##
pkg/admin/service/instance.go:
##
@@ -43,3 +44,33 @@ func SearchInstances(rt core_runtime.Runtime, req
*model.SearchInstanceReq) ([]*
return res, , nil
}
+
+func GetInstanceDetail(rt core_runtime.Runtime, req *model.InstanceDetailReq)
([]*model.InstanceDetailResp, error) {
+ manager := rt.ResourceManager()
+ dataplaneList := {}
+
+ if err := manager.List(rt.AppContext(), dataplaneList,
store.ListByNameContains(req.InstanceName)); err != nil {
+ return nil, err
+ }
+
+ instMap := make(map[string]*model.InstanceDetail)
+ for _, dataplane := range dataplaneList.Items {
+ instName := dataplane.Meta.GetLabels()[mesh_proto.InstanceTag]
+ var instanceDetail *model.InstanceDetail
+ if _, ok := instMap[instName]; ok {
+ instanceDetail = instMap[instName]
+ } else {
+ instanceDetail = model.NewInstanceDetail()
+ }
+ instanceDetail.Merge(dataplane) //convert dataplane info to
instance detail
+ instMap[instName] = instanceDetail
Review Comment:
Should we only set the map `instMap[instName] = instanceDetail` in the
`else` branch above?
##
pkg/admin/model/instance.go:
##
@@ -73,3 +78,105 @@ type State struct {
Tip string `json:"tip"`
Value string `json:"value"`
}
+
+type InstanceDetailResp struct {
+ RpcPort []string `json:"rpcPort"`
+ Ip []string `json:"ip"`
+ AppName []string `json:"appName"`
+ WorkloadName[]string `json:"workloadName"`
+ Labels []string `json:"labels"`
+ CreateTime []string `json:"createTime"`
+ ReadyTime []string `json:"readyTime"`
+ RegisterTime[]string `json:"registerTime"`
+ RegisterCluster []string `json:"registerCluster"`
+ DeployCluster []string `json:"deployCluster"`
+ Node[]string `json:"node"`
+ Image []string `json:"image"`
+ Probes struct {
+ StartupProbe struct {
+ Type string `json:"type"`
+ Port int`json:"port"`
+ Open bool `json:"open"`
+ } `json:"startupProbe"`
+ ReadinessProbe struct {
+ Type string `json:"type"`
+ Port int`json:"port"`
+ Open bool `json:"open"`
+ } `json:"readinessProbe"`
+ LivenessProbe struct {
+ Type string `json:"type"`
+ Port int`json:"port"`
+ Open bool `json:"open"`
+ } `json:"livenessProbe"`
+ } `json:"probes"`
+}
+
+func (r *InstanceDetailResp) FromInstanceDetail(id *InstanceDetail)
*InstanceDetailResp {
+ r.AppName = id.AppName.Values()
+ r.RpcPort = id.RpcPort.Values()
+ r.Ip = id.Ip.Values()
+ r.WorkloadName = id.WorkloadName.Values()
+ r.Labels = id.Labels.Values()
+ r.CreateTime = id.CreateTime.Values()
+ r.ReadyTime = id.ReadyTime.Values()
+ r.RegisterTime = id.RegisterTime.Values()
+ r.RegisterCluster = id.RegisterClusters.Values()
+ r.DeployCluster = id.DeployCluster.Values()
+ r.Node = id.Node.Values()
+ r.Image = id.Image.Values()
+ return r
+}
+
+type InstanceDetail struct {
+ RpcPort Set
+ Ip Set
+ AppName Set
+ WorkloadName Set
+ Labels Set
+ CreateTime Set
+ ReadyTimeSet
+ RegisterTime Set
+ RegisterClusters Set
+ DeployClusterSet
+ Node Set
+ ImageSet
+}
Review Comment:
Why are all fields here declared as `Set`?
##
conf/dubbo-cp.yaml:
##
@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
+# Licensed to the Apache Software Foundation (ASF) under one or moreshop-use
Review Comment:
Please check if this is an unexpected change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Update mysql-postgres-tutorial-zh.md [flink-cdc]
PatrickRen closed pull request #1896: Update mysql-postgres-tutorial-zh.md URL: https://github.com/apache/flink-cdc/pull/1896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [cdc][base]Support dynamically table addition in flink-cdc-base [flink-cdc]
PatrickRen closed pull request #1877: [cdc][base]Support dynamically table addition in flink-cdc-base URL: https://github.com/apache/flink-cdc/pull/1877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [mysql] a new way to find binlog/positon in timestamp startupmode [flink-cdc]
PatrickRen closed pull request #1852: [mysql] a new way to find binlog/positon in timestamp startupmode URL: https://github.com/apache/flink-cdc/pull/1852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix HiveResult.toHiveString compatibility for Spark 4.0 [kyuubi]
pan3793 commented on PR #6404: URL: https://github.com/apache/kyuubi/pull/6404#issuecomment-2124028193 Merged to master/1.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
Re: [PR] Fix HiveResult.toHiveString compatibility for Spark 4.0 [kyuubi]
pan3793 closed pull request #6404: Fix HiveResult.toHiveString compatibility for Spark 4.0 URL: https://github.com/apache/kyuubi/pull/6404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
Re: [PR] Switch to a MySQL image with arm64 support [flink-cdc]
PatrickRen closed pull request #1759: Switch to a MySQL image with arm64 support URL: https://github.com/apache/flink-cdc/pull/1759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] A problem with an abnormal log output location. (logging-log4j2)
vy closed issue #2582: A problem with an abnormal log output location. URL: https://github.com/apache/logging-log4j2/issues/2582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] A problem with an abnormal log output location. (logging-log4j2)
vy commented on issue #2582: URL: https://github.com/apache/logging-log4j2/issues/2582#issuecomment-2124027437 @FrankCy, thanks for the update. I am closing the issue. Feel free to re-open it when you manage to create the minimal reproduction code that I asked for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 升级Jackson版本 [flink-cdc]
PatrickRen closed pull request #1660: 升级Jackson版本 URL: https://github.com/apache/flink-cdc/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Improvement] Add admin flag for role entity [paimon-webui]
s7monk commented on PR #234: URL: https://github.com/apache/paimon-webui/pull/234#issuecomment-2124027203 > @s7monk, IMO, the frontend could not get the admin flag of role. @zhangmo8 requires this field when connecting to the front end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]
github-actions[bot] commented on PR #35193: URL: https://github.com/apache/doris/pull/35193#issuecomment-2124027011 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]
github-actions[bot] commented on PR #35193: URL: https://github.com/apache/doris/pull/35193#issuecomment-2124026955 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]
jsedding commented on PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124026921 I read the spec on the subject of the `pid` in the `Designate` element and found that the `pid` attribute is ignored if a `factoryPid` attribute is present. Both, the `DefaultSyncHandler` and the `ExternalLoginModuleFactory` have the `factoryPid` attribute specified. Thus the new version is arguably more correct than the old version that includes the ignored `pid` attribute. > The [getPids()](https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#org.osgi.service.metatype.MetaTypeInformation.getPids--) method returns an array of PIDs that were specified in the pid attribute of the Object elements. The [getFactoryPids()](https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#org.osgi.service.metatype.MetaTypeInformation.getFactoryPids--) method returns an array of the factoryPid attributes. **For factories, the related pid attribute is ignored because all instances of a factory must share the same meta type.** (emphasis is mine) Source: https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.metatype.html#i1492258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [BugFix](Replica) fix bug that replica remote data size set to data size [doris]
doris-robot commented on PR #35097: URL: https://github.com/apache/doris/pull/35097#issuecomment-2124026825 TPC-H: Total hot run time: 50319 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e3479bdc641cc70e2b7adc4b90c0cdf71fda61b0, data reload: false -- Round 1 -- q1 18255 433343304330 q2 2050157 152 152 q3 10458 190119481901 q4 10622 122713451227 q5 8454424239073907 q6 244 127 124 124 q7 2049158016051580 q8 9612274727092709 q9 13314 10358 10292 10292 q10 8647357435413541 q11 415 243 253 243 q12 465 305 303 303 q13 19903 402141094021 q14 355 332 352 332 q15 522 485 473 473 q16 694 614 616 614 q17 1142945 916 916 q18 7719734772507250 q19 1687157915491549 q20 568 316 305 305 q21 4419416541574157 q22 505 410 393 393 Total cold run time: 122099 ms Total hot run time: 50319 ms - Round 2, with runtime_filter_mode=off - q1 4363436443424342 q2 316 218 219 218 q3 4143414041144114 q4 2750272427452724 q5 7167711071207110 q6 235 121 122 121 q7 3238285528102810 q8 4390447944724472 q9 16894 16810 16745 16745 q10 4207429942954295 q11 745 669 698 669 q12 1018830 868 830 q13 6943377337283728 q14 452 423 434 423 q15 497 458 457 457 q16 735 687 683 683 q17 3813385138623851 q18 8653871787868717 q19 1713165317051653 q20 2403218021162116 q21 8514846084488448 q22 1019964 946 946 Total cold run time: 84208 ms Total hot run time: 79472 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [e2e] optimization for arm64 [flink-cdc]
PatrickRen closed pull request #1560: [e2e] optimization for arm64 URL: https://github.com/apache/flink-cdc/pull/1560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [mysql] Populate table schemas when scanNewlyAddedTables is enabled in binlog phase [flink-cdc]
PatrickRen closed pull request #1464: [mysql] Populate table schemas when scanNewlyAddedTables is enabled in binlog phase URL: https://github.com/apache/flink-cdc/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]
github-actions[bot] commented on PR #41732: URL: https://github.com/apache/arrow/pull/41732#issuecomment-2124026391 Revision: eb2f4736004e97367d844a8078b81b27a99f3658 Submitted crossbow builds: [ursacomputing/crossbow @ actions-c98dc1f751](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c98dc1f751) |Task|Status| ||--| |java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844928/job/25263299280)| |test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844906/job/25263297934)| |test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844890/job/25263297728)| |test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844897/job/25263297746)| |verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9186845298/job/25263298962)| |verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844776/job/25263297125)| |verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844831/job/25263297195)| |verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9186844887/job/25263297384)| |verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/9186845088/job/25263298460)| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [AMORO-2853] Improve the packaging and compilation process for amoro project [amoro]
xleoken commented on PR #2854: URL: https://github.com/apache/amoro/pull/2854#issuecomment-2124026181 Hi @zhoujinsong for the suggestion. Patch is updated accordingly, can you please take another look? Had tried following mvn commad in local environment. - Execute `mvn clean package` to package all modules except `amoro-mixed-format-trino`. - Execute `mvn clean package -Pbuild-mixed-format-trino -Ptoolchain` to package all modules. - Execute `mvn clean package -Pbuild-mixed-format-trino -pl 'amoro-mixed-format/amoro-mixed-format-trino' -am` to package `amoro-mixed-format-trino` only. _Originally posted by @zhoujinsong in https://github.com/apache/amoro/issues/2853#issuecomment-2122373505_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [metric] fix flink cdc metric conflict with flink built in metric [flink-cdc]
PatrickRen closed pull request #1431: [metric] fix flink cdc metric conflict with flink built in metric URL: https://github.com/apache/flink-cdc/pull/1431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix bug : https://issues.apache.org/jira/browse/SPARK-44473 [spark]
ychris78 opened a new pull request, #46699: URL: https://github.com/apache/spark/pull/46699 ### What changes were proposed in this pull request? Through code tracking, I found that the folder corresponding to the partition on HDFS is generated by the 'AlterTableAddPartitionCommand' command, and whether the command is executed depends on whether the partition already exists in the metastore, which is the root cause of the non-idempotence. So we need to drop the updated part of the partitions from the metastore to initialize its state. ### Why are the changes needed? For fix issue #SPARK-44473 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? manually tested ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] Fix nullability checks in .net deserializers [tinkerpop]
FlorianHockmann commented on code in PR #2610:
URL: https://github.com/apache/tinkerpop/pull/2610#discussion_r1609407967
##
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/EdgeDeserializer.cs:
##
@@ -31,26 +31,26 @@ internal class EdgeDeserializer : IGraphSONDeserializer
public dynamic Objectify(JsonElement graphsonObject, GraphSONReader
reader)
{
var outVId = reader.ToObject(graphsonObject.GetProperty("outV"));
-var outVLabel = graphsonObject.TryGetProperty("outVLabel", out var
outVLabelProperty)
-? outVLabelProperty.GetString()
+string outVLabel = graphsonObject.TryGetProperty("outVLabel", out
var outVLabelProperty)
Review Comment:
> Visual Studio 17.9.5 think GetString()! is not enough
OK, I see. I'm using Rider and that even complains if `string` is used
instead of `var`, but then we can stick with `string` of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [mysql] Support docker image of ARM chip [flink-cdc]
PatrickRen closed pull request #1368: [mysql] Support docker image of ARM chip URL: https://github.com/apache/flink-cdc/pull/1368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SPARK-48384][BUILD] Exclude `io.netty:netty-tcnative-boringssl-static` from `zookeeper` [spark]
pan3793 commented on PR #46695: URL: https://github.com/apache/spark/pull/46695#issuecomment-2124025089 cc @mridulm and @hasnain-db as the change is related to SSL dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [Debezium] Fix the server timeZone bug of debeziumDeserialization when using dataSream API（#317） [flink-cdc]
PatrickRen closed pull request #1366: [Debezium] Fix the server timeZone bug of debeziumDeserialization when using dataSream API（#317） URL: https://github.com/apache/flink-cdc/pull/1366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] BUG? Response执行完先于IssueRPC中的bthread_id_unlock执行完毕的话, unlock会失败吧? (brpc)
chenBright commented on issue #2646: URL: https://github.com/apache/brpc/issues/2646#issuecomment-2124024905 bthread_id_unlock的返回值是什么？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
Re: [PR] [ISSUE #708] Fix the issue that PushConsumer reentrant pop doesn't work as expected [rocketmq-clients]
starhu521 commented on PR #709: URL: https://github.com/apache/rocketmq-clients/pull/709#issuecomment-2124024281 May I know when this fix will be released? This issue often occurs during network fluctuations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [mysql] Fix use latest-offset mode during caused add newly table not … [flink-cdc]
PatrickRen closed pull request #1185: [mysql] Fix use latest-offset mode during caused add newly table not … URL: https://github.com/apache/flink-cdc/pull/1185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] After restarting ShardingSphere-Proxy 5.5, previously created tables cannot be viewed. [shardingsphere]
liangjiajie-hub commented on issue #31328: URL: https://github.com/apache/shardingsphere/issues/31328#issuecomment-2124023979 > @liangjiajie-hub You may need to use cluster mode (with zookeeper) to persist the meta data. The 5.3.2 version has been tested and does not have this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [PostgreSQL] Add DeserializationConverterFactory for PostGIS schemas [flink-cdc]
PatrickRen closed pull request #1161: [PostgreSQL] Add DeserializationConverterFactory for PostGIS schemas URL: https://github.com/apache/flink-cdc/pull/1161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [mysql] expose update_before field in the metadata through flink sql [flink-cdc]
PatrickRen closed pull request #1139: [mysql] expose update_before field in the metadata through flink sql URL: https://github.com/apache/flink-cdc/pull/1139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
reswqa commented on PR #101: URL: https://github.com/apache/flink-connector-elasticsearch/pull/101#issuecomment-2124023352 Thanks for the review! Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix failure test with ConfigKeyScheduledExecutionWrapperTest [cloudstack]
codecov[bot] commented on PR #9103: URL: https://github.com/apache/cloudstack/pull/9103#issuecomment-2124023587 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9103?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.26%. Comparing base [(`21af134`)](https://app.codecov.io/gh/apache/cloudstack/commit/21af134087a55c044f921b3f6ab64aba83b80071?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`8bcdcd0`)](https://app.codecov.io/gh/apache/cloudstack/pull/9103?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9103 +/- ## - Coverage 15.28% 4.26% -11.02% Files 5425 363 -5062 Lines474138 29565 -444573 Branches 589845190-53794 - Hits 724861262-71224 + Misses 393584 28160 -365424 + Partials 8068 143 -7925 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9103/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9103/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.26% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9103/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9103?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#1721] fix(coordinator): classCastExpection of boolean->String with yaml style remote client conf [incubator-uniffle]
zuston commented on PR #1722: URL: https://github.com/apache/incubator-uniffle/pull/1722#issuecomment-2124023162 > @zuston Could you commit this to branch 0.9? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [mysql] expose op type in the metadata through flink sql [flink-cdc]
PatrickRen closed pull request #1137: [mysql] expose op type in the metadata through flink sql URL: https://github.com/apache/flink-cdc/pull/1137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]
vibhatha commented on PR #41732: URL: https://github.com/apache/arrow/pull/41732#issuecomment-2124022796 @github-actions crossbow submit -g java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MINOR] fix(docs): Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms [incubator-uniffle]
zuston commented on PR #1734: URL: https://github.com/apache/incubator-uniffle/pull/1734#issuecomment-2124022772 > @zuston Could you commit this to branch 0.9? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [FLINK-35416][Connector/Elasticsearch] Remove the dependency on flink-shaded [flink-connector-elasticsearch]
reswqa merged PR #101: URL: https://github.com/apache/flink-connector-elasticsearch/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [GLUTEN-5787][CH]Make shuffle writer exit gracefully when tasks in executors are killed [incubator-gluten]
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2124022604 https://github.com/apache/incubator-gluten/issues/5787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [GLUTEN-5787][CH]Make shuffle writer exit gracefully when tasks in executors are killed [incubator-gluten]
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2124022956 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] feat(c++,spark): support json payload file format [incubator-graphar]
acezen commented on PR #488: URL: https://github.com/apache/incubator-graphar/pull/488#issuecomment-2124022333 The Spark CI got some error like: ``` Error: ] /home/runner/work/incubator-graphar/incubator-graphar/maven-projects/spark/datasources-32/src/main/scala/org/apache/graphar/datasources/GarTable.scala:42: object JSONWriteBuilder is not a member of package org.apache.graphar.datasources.json Error: ] /home/runner/work/incubator-graphar/incubator-graphar/maven-projects/spark/datasources-32/src/main/scala/org/apache/graphar/datasources/GarTable.scala:87: class JSONOptions in package json cannot be accessed in package org.apache.spark.sql.catalyst.json ``` Could you double check that the JSONOptions is accessed in package org.apache.spark.sql.catalyst.json? Note that we run the Spark CI on spark.3.x and spark 3.2.x, the spark 3.4.x code and above may not work. https://github.com/apache/incubator-graphar/blob/87d5eeb6a7f86574328da26f08d950e3c5bc3de8/.github/workflows/spark.yaml#L47-L52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
jerqi commented on PR #1725: URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2124021457 @dingshun3016 Could you create an issue for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [I] [Bug] Some lines in the line chart disappear progressively [echarts]
helgasoft commented on issue #19958: URL: https://github.com/apache/echarts/issues/19958#issuecomment-2124021086 > I tried with `select` but according to this issue it doesn't work (#16545) and will never work. good that you mentioned it! See my Demo Code in related #19194. Event [selectchanged](https://echarts.apache.org/en/api.html#events.selectchanged) should successfully replace emphasis in your example. Just remove all _areaStyle_. Toggle _lineStyle_ by clicking on a line symbol and mouse-out. 拾 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]
sdd commented on code in PR #367:
URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609404309
##
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##
@@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_>
{
reference: ,
_predicate: ,
) -> crate::Result {
-todo!()
+let field: = self.field_summary_for_reference(reference);
+
+// contains_null encodes whether at least one partition value is null,
+// lowerBound is null if all partition values are null
+if self.are_all_null(field, ().field_type) {
+ROWS_CANNOT_MATCH
+} else {
+ROWS_MIGHT_MATCH
+}
}
+#[allow(clippy::bool_comparison)]
fn is_nan(
self,
reference: ,
_predicate: ,
) -> crate::Result {
-Ok(self
-.field_summary_for_reference(reference)
-.contains_nan
-.is_some())
+let field: = self.field_summary_for_reference(reference);
+if field.contains_nan.is_some_and(|x| x == false) {
+return ROWS_CANNOT_MATCH;
+}
+
+if self.are_all_null(field, ().field_type) {
Review Comment:
@marvinlanhenke if field.contains_nan is `None` rather than `Some(false)`
then this implies that the metrics don't indicate if the fields contain NaN or
not. So the subsequent check for all nulls is still valid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Bump org.wiremock:wiremock from 3.0.3 to 3.5.4 [camel]
github-actions[bot] commented on PR #14221: URL: https://github.com/apache/camel/pull/14221#issuecomment-2124020788 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [D] AutoGenView and RouteView issue [cloudstack]
GitHub user Pearl1594 added a comment to the discussion: AutoGenView and RouteView issue @SamEsmailR Is the package-lock.json file missing by any chance? GitHub link: https://github.com/apache/cloudstack/discussions/9089#discussioncomment-9517499 This is an automatically sent email for users@cloudstack.apache.org. To unsubscribe, please send an email to: users-unsubscr...@cloudstack.apache.org
[PR] Bump org.wiremock:wiremock from 3.0.3 to 3.5.4 [camel]
dependabot[bot] opened a new pull request, #14221: URL: https://github.com/apache/camel/pull/14221 Bumps [org.wiremock:wiremock](https://github.com/wiremock/wiremock) from 3.0.3 to 3.5.4. Release notes Sourced from https://github.com/wiremock/wiremock/releases;>org.wiremock:wiremock's releases. 3.5.4 Dependency updates Bump versions.jetty from 12.0.7 to 12.0.8 (https://redirect.github.com/wiremock/wiremock/issues/2668;>#2668) https://github.com/dependabot;>@dependabot ✍ Other changes Allow commons-fileupload to load commons-io as a transitive dependency (https://redirect.github.com/wiremock/wiremock/issues/2691;>#2691) https://github.com/leeturner;>@leeturner Fix some Sonar or/and IDEA inspect code issues (partly) (https://redirect.github.com/wiremock/wiremock/issues/2686;>#2686) https://github.com/pks-1981;>@pks-1981 3.5.3 Some minor improvements, bug fixes and dependency updates. Dependency updates Bump io.github.gradle-nexus.publish-plugin from 1.3.0 to 2.0.0 (https://redirect.github.com/wiremock/wiremock/issues/2673;>#2673) https://github.com/dependabot;>@dependabot Bump commons-io:commons-io from 2.16.0 to 2.16.1 (https://redirect.github.com/wiremock/wiremock/issues/2676;>#2676) https://github.com/dependabot;>@dependabot Bump org.sonarqube from 4.4.1.3373 to 5.0.0.4638 (https://redirect.github.com/wiremock/wiremock/issues/2649;>#2649) https://github.com/dependabot;>@dependabot Bug fixes removeEventsMatching supports custom matchers (https://redirect.github.com/wiremock/wiremock/issues/2682;>#2682) https://github.com/Mahoney;>@Mahoney Near miss takes custom matchers into account (https://redirect.github.com/wiremock/wiremock/issues/2683;>#2683) https://github.com/Mahoney;>@Mahoney ✍ Other changes Fixes https://redirect.github.com/wiremock/wiremock/issues/2665;>#2665 - WireMock.stubFor throws descriptive exception message on 404 error code from non-WireMock server instead of unclear JsonException (https://redirect.github.com/wiremock/wiremock/issues/2666;>#2666) https://github.com/vasiliy-sarzhynskyi;>@vasiliy-sarzhynskyi Use modern Gradle GHA setup (https://redirect.github.com/wiremock/wiremock/issues/2685;>#2685) https://github.com/Mahoney;>@Mahoney Support sub events on partial matchers (https://redirect.github.com/wiremock/wiremock/issues/2681;>#2681) https://github.com/Mahoney;>@Mahoney Remove deprecated java.security.AccessControl (https://redirect.github.com/wiremock/wiremock/issues/2672;>#2672) https://github.com/pks-1981;>@pks-1981 Fix some Sonar or/and IDEA inspect code issues (partly) (https://redirect.github.com/wiremock/wiremock/issues/2669;>#2669) https://github.com/pks-1981;>@pks-1981 Make it easier to fix issue with file's path (https://redirect.github.com/wiremock/wiremock/issues/2670;>#2670) https://github.com/Mahoney;>@Mahoney Replace commons-io:commons-io (https://redirect.github.com/wiremock/wiremock/issues/2632;>#2632) https://github.com/pks-1981;>@pks-1981 Move template benchmark into benchmarks (https://redirect.github.com/wiremock/wiremock/issues/2667;>#2667) https://github.com/Mahoney;>@Mahoney Use Temurin JDK (https://redirect.github.com/wiremock/wiremock/issues/2663;>#2663) https://github.com/sullis;>@sullis 3.5.2 3.5.0 and 3.5.1 have a problem with their POM files, meaning Maven fails to properly load all of the transitive dependencies. This release is primarily to fix this issue. Bug fixes Fix publications by excluding testFixturesApi components (https://redirect.github.com/wiremock/wiremock/issues/2661;>#2661) https://github.com/reta;>@reta Dependency updates Bump commons-io:commons-io from 2.15.1 to 2.16.0 (https://redirect.github.com/wiremock/wiremock/issues/2656;>#2656) https://github.com/dependabot;>@dependabot 3.5.1 ✍ Other changes ... (truncated) Commits https://github.com/wiremock/wiremock/commit/a861e50a54c3ddee666d4d1f4a8cad53d8a49132;>a861e50 Merge pull request https://redirect.github.com/wiremock/wiremock/issues/2692;>#2692 from wiremock/docker_release_doc https://github.com/wiremock/wiremock/commit/4dd21ee5de217ee63652141692c9a3b84339a102;>4dd21ee docker relase documentation updated https://github.com/wiremock/wiremock/commit/0b4f8a41f0f768397ac8563829f0e5dc9eee85c8;>0b4f8a4 Bump patch version https://github.com/wiremock/wiremock/commit/2a4e236d2419b51a3593353dab8bae6f9134edac;>2a4e236 Merge pull request https://redirect.github.com/wiremock/wiremock/issues/2691;>#2691 from wiremock/allow-commons-io-transitive-dep https://github.com/wiremock/wiremock/commit/45743468c614a0113e93c81ec51d1eb04a2f1f32;>4574346 Merge pull request https://redirect.github.com/wiremock/wiremock/issues/2668;>#2668 from wiremock/dependabot/gradle/versions.jetty-12.0.8
Re: [PR] NeptuneStopDbClusterOperator - Handle invalid cluster states [airflow]
eladkal merged PR #38287: URL: https://github.com/apache/airflow/pull/38287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Amazon NeptuneStopDbClusterOperator bug [airflow]
eladkal closed issue #38120: Amazon NeptuneStopDbClusterOperator bug URL: https://github.com/apache/airflow/issues/38120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix](pipeline) Fix resource leak if prepare failed [doris]
github-actions[bot] commented on PR #35195: URL: https://github.com/apache/doris/pull/35195#issuecomment-2124019461 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [FLINK-35359][config] General Improvement to Configuration for Flink 2.0 [flink]
xintongsong commented on code in PR #24815:
URL: https://github.com/apache/flink/pull/24815#discussion_r1609367863
##
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##
@@ -140,7 +141,7 @@
public abstract class Dispatcher extends FencedRpcEndpoint
implements DispatcherGateway {
-@VisibleForTesting
+@Internal
Review Comment:
`@VisibleForTesting` should not be removed. This field is `public` only for
the testing purpose. Without testing, the filed can be `private` because no
production codes outside `Dispatcher` uses it.
##
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java:
##
@@ -378,7 +378,9 @@ public static NettyShuffleEnvironmentConfiguration
fromConfiguration(
boolean batchShuffleCompressionEnabled =
configuration.get(NettyShuffleEnvironmentOptions.BATCH_SHUFFLE_COMPRESSION_ENABLED);
String compressionCodec =
-
configuration.get(NettyShuffleEnvironmentOptions.SHUFFLE_COMPRESSION_CODEC);
+configuration
+
.get(NettyShuffleEnvironmentOptions.SHUFFLE_COMPRESSION_CODEC)
+.toString();
Review Comment:
Why would we want to convert this enum to a string. Looking into all its
usages, eventually the string will be passed into
`BlockCompressionFactory#createBlockCompressionFactory` and convert to
`CompressionFactoryName`.
##
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##
@@ -121,6 +121,12 @@ public class NettyShuffleEnvironmentOptions {
+ "speed is the slowest, and LZO is
between the two. Also note "
+ "that this option is experimental and
might be changed in the future.");
+public enum ShuffleCompressionCodec {
+LZ4,
+LZO,
+ZSTD
+}
Review Comment:
How about we just use `BlockCompressionFactory#CompressionFactoryName`,
moving it to some API module / package and maybe also rename it to
`ShuffleCompressionCodec`.
##
flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java:
##
@@ -140,12 +140,12 @@ public static String parseMapToString(Map
map) {
public static Time getStandaloneClusterStartupPeriodTime(Configuration
configuration) {
final Time timeout;
-long standaloneClusterStartupPeriodTime =
+Duration standaloneClusterStartupPeriodTime =
configuration.get(ResourceManagerOptions.STANDALONE_CLUSTER_STARTUP_PERIOD_TIME);
-if (standaloneClusterStartupPeriodTime >= 0) {
-timeout = Time.milliseconds(standaloneClusterStartupPeriodTime);
+if (standaloneClusterStartupPeriodTime != null) {
+timeout = Time.fromDuration(standaloneClusterStartupPeriodTime);
Review Comment:
What happens if the configured value is negative? Can a Duration be negative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [improve](jdbc catalog) Add a function that does not push down to MySQL: negative [doris]
doris-robot commented on PR #35196: URL: https://github.com/apache/doris/pull/35196#issuecomment-2124018423 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]
zgxme commented on PR #35193: URL: https://github.com/apache/doris/pull/35193#issuecomment-2124018180 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](jdbc catalog) Add a function that does not push down to MySQL: negative [doris]
zy-kkk opened a new pull request, #35196: URL: https://github.com/apache/doris/pull/35196 ## Proposed changes Issue Number: close #xxx We noticed that mysql does not have a negative function, so the function pushdown rule prohibits it ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix][Connector-V2] Field information lost during Paimon DataType and SeaTunnel Column conversion [seatunnel]
dailai commented on PR #6767: URL: https://github.com/apache/seatunnel/pull/6767#issuecomment-2124018113 > @xiaochen-zhou Please resolve the conflicts. https://github.com/apache/seatunnel/assets/18141150/5023a70b-e023-43fb-819b-92213f0e0d5c;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): bump redis.clients:jedis from 4.4.3 to 5.1.3
dependabot[bot] commented on PR #2891: URL: https://github.com/apache/streampipes/pull/2891#issuecomment-2124016974 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: Resolve python client mypy failed in pre-commit
bossenti commented on code in PR #2884: URL: https://github.com/apache/streampipes/pull/2884#discussion_r1609400582 ## streampipes-client-python/Makefile: ## @@ -47,7 +47,7 @@ reformat-all: .PHONY: pre-commit pre-commit: - git ls-files -- 'streampipes/**/*' | xargs poetry run pre-commit run --verbose --files Review Comment: We can do it this way, but since this is used as pre-commit hook I'd prefer to only scan the changed files Scanning all files causes some unnecessary latency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): bump redis.clients:jedis from 4.4.3 to 5.1.3
bossenti closed pull request #2891: chore(deps): bump redis.clients:jedis from 4.4.3 to 5.1.3 URL: https://github.com/apache/streampipes/pull/2891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@streampipes.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [#1675][FOLLOWUP] fix(test): Fix various flaky tests [incubator-uniffle]
rickyma commented on code in PR #1730:
URL:
https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609400955
##
pom.xml:
##
@@ -921,6 +921,7 @@
${project.build.directory}/tmp
${project.version}
target/jacoco.exec
+ true
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [MINOR] fix(docs): Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms [incubator-uniffle]
jerqi commented on PR #1734: URL: https://github.com/apache/incubator-uniffle/pull/1734#issuecomment-2124015742 @zuston Could you commit this to branch 0.9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org For additional commands, e-mail: issues-h...@uniffle.apache.org
Re: [PR] [Improvement] Add admin flag for role entity [paimon-webui]
SteNicholas commented on PR #234: URL: https://github.com/apache/paimon-webui/pull/234#issuecomment-2124014063 @s7monk, IMO, the frontend could not get the admin flag of role. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Feature] Complete the job result page [paimon-webui]
s7monk commented on code in PR #232:
URL: https://github.com/apache/paimon-webui/pull/232#discussion_r1609398662
##
paimon-web-ui/src/views/playground/components/query/components/console/components/controls/index.module.scss:
##
@@ -0,0 +1,57 @@
+/* Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License. */
+
+.container {
+ display: flex;
+ align-items: center;
+ width: 100%;
+ height: 42px;
+
+ .left {
+display: flex;
+padding: 10px 0 10px 20px;
+ }
+
+ .right {
+display: flex;
+flex: 1;
+justify-content: flex-end;
+padding: 10px 20px 10px 0;
+ }
+
+ .active-button-light {
+color: #7D818E;
+background-color: #DBDCDE;
+border-radius: 6px;
+padding: 4px;
+ }
+
+ .active-button-dark {
+color: #7D818E;
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Improvement] Support assigning sort field with value when creating a role [paimon-webui]
SteNicholas merged PR #233: URL: https://github.com/apache/paimon-webui/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix](pipeline) Fix resource leak if prepare failed [doris]
Gabriel39 commented on PR #35195: URL: https://github.com/apache/doris/pull/35195#issuecomment-2124013890 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](nereids) support pushdown count when scan project without any slot ref [doris]
doris-robot commented on PR #35162: URL: https://github.com/apache/doris/pull/35162#issuecomment-2124013560 TPC-H: Total hot run time: 42089 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f1b6021c851c6f736c7795e011de8a212dac43fc, data reload: false -- Round 1 -- q1 17610 442142924292 q2 2023187 213 187 q3 10459 125112301230 q4 10198 866 845 845 q5 7512272427642724 q6 221 133 136 133 q7 1036589 612 589 q8 9243216521352135 q9 9540677167016701 q10 9676395738943894 q11 464 250 237 237 q12 416 235 240 235 q13 17246 321032503210 q14 283 228 216 216 q15 508 472 471 471 q16 497 386 379 379 q17 1009683 746 683 q18 8582780377567756 q19 3411156515421542 q20 669 316 312 312 q21 5270404941214049 q22 356 290 269 269 Total cold run time: 116229 ms Total hot run time: 42089 ms - Round 2, with runtime_filter_mode=off - q1 4603445743924392 q2 371 276 258 258 q3 3147294027652765 q4 1872161316641613 q5 5503553855075507 q6 213 125 130 125 q7 2365200720262007 q8 3266339934663399 q9 8725875586168616 q10 3949384538793845 q11 608 490 497 490 q12 801 623 660 623 q13 17068 323631433143 q14 294 263 256 256 q15 528 475 465 465 q16 466 423 415 415 q17 1770148814621462 q18 7844774774287428 q19 1718157115441544 q20 2021178417691769 q21 8972492347904790 q22 575 465 493 465 Total cold run time: 76679 ms Total hot run time: 55377 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Bump org.cometd.java:cometd-java-client-http-jetty from 8.0.0 to 8.0.1 [camel]
github-actions[bot] commented on PR #14220: URL: https://github.com/apache/camel/pull/14220#issuecomment-2124013090 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.cometd.java:cometd-java-client-http-jetty from 8.0.0 to 8.0.1 [camel]
dependabot[bot] opened a new pull request, #14220: URL: https://github.com/apache/camel/pull/14220 Bumps org.cometd.java:cometd-java-client-http-jetty from 8.0.0 to 8.0.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(c++,spark): support json payload file format [incubator-graphar]
acezen commented on code in PR #488: URL: https://github.com/apache/incubator-graphar/pull/488#discussion_r1609393249 ## maven-projects/spark/datasources-32/src/main/scala/org/apache/graphar/datasources/json/JSONWriterBuilder.scala: ## @@ -0,0 +1,74 @@ +/* Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: The update should apply to both datasources-32 and datasources-33 https://github.com/apache/incubator-graphar/tree/main/maven-projects/spark/datasources-33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]
doris-robot commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2124011293 TeamCity be ut coverage result: Function Coverage: 37.79% (8076/21369) Line Coverage: 29.45% (65944/223905) Region Coverage: 28.92% (33948/117388) Branch Coverage: 24.78% (17421/70316) Coverage Report: http://coverage.selectdb-in.cc/coverage/ff07338349d02fe88658ce3a7e9ab429ea955b52_ff07338349d02fe88658ce3a7e9ab429ea955b52/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [CH] Make shuffle writer exit gracefully when tasks in executors are killed [incubator-gluten]
taiyang-li commented on issue #5823: URL: https://github.com/apache/incubator-gluten/issues/5823#issuecomment-2124011279 解决： 去掉上述第3点中的逻辑。如此celeborn client中产生的java.lang.InterruptedException异常可被传递到jvm中，并进行相应的处理  经验证，修改之后没有FAILED的任务。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] RAS: Optimize offload rule code to gain better compatibility with rewrite rules [incubator-gluten]
github-actions[bot] commented on PR #5836: URL: https://github.com/apache/incubator-gluten/pull/5836#issuecomment-2124011144 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [fix](test) let test_sys_rowsets compatible with three replicas [doris]
github-actions[bot] commented on PR #35187: URL: https://github.com/apache/doris/pull/35187#issuecomment-2124011196 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](test) let test_sys_rowsets compatible with three replicas [doris]
dataroaring merged PR #35187: URL: https://github.com/apache/doris/pull/35187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] feat(c++,spark): support json payload file format [incubator-graphar]
acezen commented on code in PR #488: URL: https://github.com/apache/incubator-graphar/pull/488#discussion_r1609393249 ## maven-projects/spark/datasources-32/src/main/scala/org/apache/graphar/datasources/json/JSONWriterBuilder.scala: ## @@ -0,0 +1,74 @@ +/* Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: The update should apply to both datasources-32 and datasources-33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [VL] RAS: Reuse same code path with heuristic planner for convention enforcement [incubator-gluten]
github-actions[bot] commented on PR #5824: URL: https://github.com/apache/incubator-gluten/pull/5824#issuecomment-2124010431 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [VL] RAS: Reuse same code path with heuristic planner for convention enforcement [incubator-gluten]
github-actions[bot] commented on PR #5824: URL: https://github.com/apache/incubator-gluten/pull/5824#issuecomment-2124010303 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [fix](pipeline) Fix resource leak if prepare failed [doris]
doris-robot commented on PR #35195: URL: https://github.com/apache/doris/pull/35195#issuecomment-2124010182 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fix the bug where obtaining instance metadata inf… [dubbo-kubernetes]
chickenlj merged PR #289: URL: https://github.com/apache/dubbo-kubernetes/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] [fix](pipeline) Fix resource leak if prepare failed [doris]
Gabriel39 opened a new pull request, #35195: URL: https://github.com/apache/doris/pull/35195 ## Proposed changes Now we think a query is done only if all instances are done. But instances account is computed by FE which is an expected values. If query failed in prepare phase and some instances are not ready, this condition will never be met . ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [camel]
github-actions[bot] commented on PR #14219: URL: https://github.com/apache/camel/pull/14219#issuecomment-2124009168 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [camel]
dependabot[bot] opened a new pull request, #14219: URL: https://github.com/apache/camel/pull/14219 Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.10.1 to 2.11.0. Release notes Sourced from https://github.com/google/gson/releases;>com.google.code.gson:gson's releases. gson-parent-2.11.0 Most important changes Added default ProGuard / R8 rules (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2397;>#2397, https://redirect.github.com/google/gson/issues/2420;>#2420; https://github.com/sgjesse;>@sgjesse, https://redirect.github.com/google/gson/issues/2448;>#2448; https://github.com/sfreilich;>@sfreilich) If you are using ProGuard or R8 (for example for Android projects) you might not need any special Gson configuration anymore if your classes have a no-args constructor and use @SerializedName for their fields. On Android, Gson now requires API level 21 or newer Added new Strictness API (https://github.com/marten-voorberg;>@marten-voorberg fellow students, https://redirect.github.com/google/gson/issues/2437;>#2437) Some of Gson's API is still lenient by default, but you can now use the newly added methods GsonBuilder#setStrictness, JsonReader#setStrictness and JsonWriter#setStrictness with Strictness.STRICT to override this behavior and to instead strictly adhere to the JSON specification when parsing. New FormattingStyle class to allow configuring line breaks in JSON output (https://github.com/mihnita;>@mihnita, https://redirect.github.com/google/gson/issues/2231;>#2231) Can be set using GsonBuilder#setFormattingStyle and JsonWriter#setFormattingStyle. TypeToken can no longer capture type variables by default (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2376;>#2376) This was previously a common source of issues. The newly thrown exception refers to a https://github.com/google/gson/blob/main/Troubleshooting.md#typetoken-type-variable;>Troubleshooting Guide article which explains this in more detail and provides suggestions for updating affected code. Added serialization support for anonymous and local classes with a custom adapter (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2498;>#2498) This affects for example List implementations returned by libraries such as Guava which are implemented as anonymous class, which were previously serialized as null. Anonymous and local classes without custom adapter will still be serialized as null. Added dependency on com.google.errorprone:error_prone_annotations This dependency can be considered optional, but if missing it might lead to compiler warnings. Therefore Gson does not declare it as optional. Many exception messages now refer to the https://github.com/google/gson/blob/main/Troubleshooting.md;>Troubleshooting Guide (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2357;>#2357) Feedback regarding the Troubleshooting Guide is appreciated! Officially documented that JVM languages other than Java might not be fully supported, see the https://github.com/google/gson/blob/main/README.md;>README. Guarantee that JsonElement#toString produces JSON output (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2659;>#2659) Other changes Bug fixes Fixed incorrect JsonPrimitive#equals results for large BigInteger values (https://github.com/MaicolAntali;>@MaicolAntali, https://redirect.github.com/google/gson/issues/2311;>#2311) Fixed incorrect JsonPrimitive#equals results for large BigDecimal values (https://github.com/MaicolAntali;>@MaicolAntali, https://redirect.github.com/google/gson/issues/2364;>#2364) Fixed JsonReader throwing NumberFormatException instead of MalformedJsonException for malformed Unicode escape sequences (https://github.com/MaicolAntali;>@MaicolAntali, https://redirect.github.com/google/gson/issues/2337;>#2337) Fixed TypeToken#getParameterized returning bogus ParameterizedType for non-generic types (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2447;>#2447) Fixed Java Record adapter not working for GraalVM Native Image (https://github.com/eamonnmcmanus;>@eamonnmcmanus, https://redirect.github.com/google/gson/issues/2465;>#2465) Fixed JsonWriter#name not throwing exception when no JSON object is currently being written (https://github.com/shivam-sehgal;>@shivam-sehgal, https://redirect.github.com/google/gson/issues/2475;>#2475; https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2476;>#2476) Fixed Gson#getDelegateAdapter not working properly for @JsonAdapter (https://github.com/Marcono1234;>@Marcono1234, https://redirect.github.com/google/gson/issues/2435;>#2435)
Re: [PR] [VL] RAS: Reuse same code path with heuristic planner for convention enforcement [incubator-gluten]
github-actions[bot] commented on PR #5824: URL: https://github.com/apache/incubator-gluten/pull/5824#issuecomment-2124008743 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]
doris-robot commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2124008727 TPC-H: Total hot run time: 49451 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ff07338349d02fe88658ce3a7e9ab429ea955b52, data reload: false -- Round 1 -- q1 17580 431743364317 q2 2040155 144 144 q3 10424 191219641912 q4 10317 125513531255 q5 8786386338753863 q6 230 127 126 126 q7 2073159215901590 q8 9311270727092707 q9 10547 10305 10251 10251 q10 8644351434533453 q11 419 241 255 241 q12 458 300 299 299 q13 18373 393540183935 q14 357 341 327 327 q15 510 464 454 454 q16 685 583 580 580 q17 1127972 952 952 q18 7232698467896789 q19 1715156115301530 q20 548 303 304 303 q21 4464408940414041 q22 496 410 382 382 Total cold run time: 116336 ms Total hot run time: 49451 ms - Round 2, with runtime_filter_mode=off - q1 4310428942994289 q2 313 224 215 215 q3 4133412741484127 q4 2761274127402740 q5 7182712070297029 q6 234 123 119 119 q7 3220284327802780 q8 4279441444744414 q9 16859 16829 16727 16727 q10 4276429642164216 q11 765 671 704 671 q12 1032873 851 851 q13 7147373137513731 q14 458 423 426 423 q15 513 459 456 456 q16 747 704 687 687 q17 3850386338223822 q18 8826866487678664 q19 1691171016281628 q20 2378213621262126 q21 8486846183518351 q22 1015941 947 941 Total cold run time: 84475 ms Total hot run time: 79007 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](jdbc catalog) Remove all property checks during create [doris]
zy-kkk commented on PR #35194: URL: https://github.com/apache/doris/pull/35194#issuecomment-2124008547 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](jdbc catalog) Remove all property checks during create [doris]
doris-robot commented on PR #35194: URL: https://github.com/apache/doris/pull/35194#issuecomment-2124008474 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improve](jdbc catalog) Remove all property checks during create [doris]
zy-kkk opened a new pull request, #35194: URL: https://github.com/apache/doris/pull/35194 ## Proposed changes Issue Number: close #xxx Previously, in order to prevent users from writing wrong parameters when creating a jdbc catalog, we checked all properties. However, we found that when the parent class adds a new property, the subclass cannot sense the parent class's newly added property and can only manually add a check list. In order to avoid this trouble, I will delete this check for now and will check it in a better way later. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](case) Remove sensitive information in k8s deploy test [doris]
yongjinhou commented on PR #35185: URL: https://github.com/apache/doris/pull/35185#issuecomment-2124008291 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Fix failure test with ConfigKeyScheduledExecutionWrapperTest [cloudstack]
weizhouapache opened a new pull request, #9103:
URL: https://github.com/apache/cloudstack/pull/9103
### Description
This PR fixes the test failure with ConfigKeyScheduledExecutionWrapperTest
see
https://github.com/apache/cloudstack/actions/runs/9171106108/job/25214722629
https://github.com/apache/cloudstack/actions/runs/9171320792/job/25215400678
https://github.com/apache/cloudstack/actions/runs/9180519825/job/25261374756
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [fix](test) let test_sys_rowsets compatible with three replicas [doris]
github-actions[bot] commented on PR #35187: URL: https://github.com/apache/doris/pull/35187#issuecomment-2124007955 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]
zgxme commented on PR #35193: URL: https://github.com/apache/doris/pull/35193#issuecomment-2124007934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
