Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-05-22 Thread via GitHub
weizhouapache commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1609350275 ## engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java: ## @@ -1041,6 +1042,8 @@ public Pair, Integer> listByVmsNotInClusterUsingPool(long

Re: [PR] Spark engine supports both javax and jakarta ws.rs namespaces [kyuubi]

2024-05-22 Thread via GitHub
pan3793 commented on PR #6405: URL: https://github.com/apache/kyuubi/pull/6405#issuecomment-2123969202 Thanks, merged to master/1.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-22 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

2024-05-22 Thread via GitHub
ling0900 commented on issue #5529: URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2123968496 Please assign one or more to me, I would like to do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] IGNITE-21983 Extend test coverage for SQL T031(BOOLEAN data type) [ignite-3]

2024-05-22 Thread via GitHub
ygerzhedovich commented on code in PR #3802: URL: https://github.com/apache/ignite-3/pull/3802#discussion_r1609354466 ## modules/sql-engine/src/integrationTest/sql/types/boolean/test_boolean_type.test: ## @@ -0,0 +1,120 @@ +# name: test/sql/cast/test_boolean_type.test +#

Re: [PR] Spark engine supports both javax and jakarta ws.rs namespaces [kyuubi]

2024-05-22 Thread via GitHub
pan3793 closed pull request #6405: Spark engine supports both javax and jakarta ws.rs namespaces URL: https://github.com/apache/kyuubi/pull/6405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15541: Add num-open-iterators metric [kafka]

2024-05-22 Thread via GitHub
mjsax merged PR #15975: URL: https://github.com/apache/kafka/pull/15975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-22 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-22 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef

Re: [PR] Fix bugs in Redisson plugin [skywalking-java]

2024-05-22 Thread via GitHub
wu-sheng merged PR #693: URL: https://github.com/apache/skywalking-java/pull/693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-22 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609353060 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-22 Thread via GitHub
morrySnow commented on PR #35154: URL: https://github.com/apache/doris/pull/35154#issuecomment-2123965357 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-6311] Support PostgreSQL DATE_PART [calcite]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #3794: URL: https://github.com/apache/calcite/pull/3794#issuecomment-2123963775 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[I] [Bug] when define Consumer in class field, and restart consumer, message received More than once [pulsar]

2024-05-22 Thread via GitHub
sdvdxl opened a new issue, #22759: URL: https://github.com/apache/pulsar/issues/22759 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that

Re: [PR] Fix HiveResult.toHiveString compatibility for Spark 4.0 [kyuubi]

2024-05-22 Thread via GitHub
pan3793 commented on code in PR #6404: URL: https://github.com/apache/kyuubi/pull/6404#discussion_r1609346903 ## externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala: ## @@ -262,6 +262,11 @@ object SparkSQLEngine extends Logging {

Re: [PR] [#1675][FOLLOWUP] fix(test): Fix various flaky tests [incubator-uniffle]

2024-05-22 Thread via GitHub
rickyma commented on code in PR #1730: URL: https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609344778 ## pom.xml: ## @@ -921,6 +921,7 @@ ${project.build.directory}/tmp ${project.version} target/jacoco.exec +

Re: [PR] test [doris]

2024-05-22 Thread via GitHub
zzzxl1993 commented on PR #35068: URL: https://github.com/apache/doris/pull/35068#issuecomment-2123960441 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ci/blockers: fix a few CI blockers [nuttx]

2024-05-22 Thread via GitHub
yf13 commented on code in PR #12387: URL: https://github.com/apache/nuttx/pull/12387#discussion_r1609336416 ## tools/ci/testrun/script/test_open_posix/test_openposix_.py: ## @@ -2026,7 +2026,7 @@ def test_ltp_interfaces_sigwait_6_1(p): def test_ltp_behavior_WIFEXITED_1_2(p):

Re: [PR] ci/blockers: fix a few CI blockers [nuttx]

2024-05-22 Thread via GitHub
yf13 commented on code in PR #12387: URL: https://github.com/apache/nuttx/pull/12387#discussion_r1609336416 ## tools/ci/testrun/script/test_open_posix/test_openposix_.py: ## @@ -2026,7 +2026,7 @@ def test_ltp_interfaces_sigwait_6_1(p): def test_ltp_behavior_WIFEXITED_1_2(p):

Re: [I] property "type" must be provided when reading from the Broker [camel-k]

2024-05-22 Thread via GitHub
squakez commented on issue #5529: URL: https://github.com/apache/camel-k/issues/5529#issuecomment-2123957968 I think the root cause is the second bug you've reported. If you create this from scratch with the right property does it work? in such case, feel free to close this issue and we'll

Re: [PR] ci/blockers: fix a few CI blockers [nuttx]

2024-05-22 Thread via GitHub
yf13 commented on code in PR #12387: URL: https://github.com/apache/nuttx/pull/12387#discussion_r1609336416 ## tools/ci/testrun/script/test_open_posix/test_openposix_.py: ## @@ -2026,7 +2026,7 @@ def test_ltp_interfaces_sigwait_6_1(p): def test_ltp_behavior_WIFEXITED_1_2(p):

Re: [I] ExternalTaskSensor can never find External Parent Task [airflow]

2024-05-22 Thread via GitHub
guhuajun commented on issue #13681: URL: https://github.com/apache/airflow/issues/13681#issuecomment-2123957732 Greetings, IMHO, it's a gotcha for newcomers after testing `TriggerDagRunOperator` successfully. When trying `ExternalTaskSensor`, newcomers need to fight with the

Re: [PR] [Fix-16046][SqlTask] Fix Sql task use time type is incorrect [dolphinscheduler]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #16050: URL: https://github.com/apache/dolphinscheduler/pull/16050#issuecomment-2123956894 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2123956769 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2123956836 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] IGNITE-22242 Inject LogStorageFactory dependency in Loza & JRaftServer [ignite-3]

2024-05-22 Thread via GitHub
JAkutenshi commented on code in PR #3757: URL: https://github.com/apache/ignite-3/pull/3757#discussion_r1609330592 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java: ## @@ -105,9 +108,18 @@ public

Re: [PR] [Fix-16046][SqlTask] Fix Sql task use time type is incorrect [dolphinscheduler]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #16050: URL: https://github.com/apache/dolphinscheduler/pull/16050#issuecomment-2123955784 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]

2024-05-22 Thread via GitHub
BePPPower commented on code in PR #35142: URL: https://github.com/apache/doris/pull/35142#discussion_r1609328621 ## thirdparty/vars.sh: ## @@ -399,10 +412,10 @@ BENCHMARK_MD5SUM="8ddf8571d3f6198d37852bcbd964f817" # xsimd # for arrow-7.0.0, if arrow upgrade, this version may

Re: [PR] [fix](decimal) Fix long string casting to decimalv2 [doris]

2024-05-22 Thread via GitHub
Gabriel39 merged PR #35121: URL: https://github.com/apache/doris/pull/35121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] listNetworks optimization [cloudstack]

2024-05-22 Thread via GitHub
abh1sar commented on code in PR #9096: URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1609327509 ## server/src/main/java/com/cloud/network/NetworkServiceImpl.java: ## @@ -2322,41 +2322,52 @@ public Pair, Integer> searchForNetworks(ListNetworksCmd

Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]

2024-05-22 Thread via GitHub
Gabriel39 merged PR #34720: URL: https://github.com/apache/doris/pull/34720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Fix](Outfile) upgrade apache-arrow version to 13.0.0 [doris]

2024-05-22 Thread via GitHub
BePPPower commented on PR #35142: URL: https://github.com/apache/doris/pull/35142#issuecomment-2123954943 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug] parseMessageMetadata error when broker entry metadata enable with high loading [pulsar]

2024-05-22 Thread via GitHub
lhotari commented on issue #22601: URL: https://github.com/apache/pulsar/issues/22601#issuecomment-2123954717 Looking up in Netty issue tracker. Found these issues that provide a lot of context: * https://github.com/netty/netty/issues/6184 *

[I] Flaky TestRunCronExample [camel-k]

2024-05-22 Thread via GitHub
squakez opened a new issue, #5533: URL: https://github.com/apache/camel-k/issues/5533 ### What happened? `` ❌ TestRunCronExample (10m59.86s) cron_test.go:54: Timed out after 420.000s. Expected : to contain substring

Re: [PR] Fix HiveResult.toHiveString compatibility for Spark 4.0 [kyuubi]

2024-05-22 Thread via GitHub
cxzl25 commented on code in PR #6404: URL: https://github.com/apache/kyuubi/pull/6404#discussion_r1609325076 ## externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala: ## @@ -262,6 +262,11 @@ object SparkSQLEngine extends Logging {

Re: [PR] [fix](multi-catalog)put java udf to custom lib [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34990: URL: https://github.com/apache/doris/pull/34990#issuecomment-2123952316 TPC-H: Total hot run time: 41889 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] Clean up `PropertyEnvironment` (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz closed pull request #2460: Clean up `PropertyEnvironment` URL: https://github.com/apache/logging-log4j2/pull/2460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Bugfix] Fix mv column type is not changed when do schema change [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34598: URL: https://github.com/apache/doris/pull/34598#issuecomment-2123951107 TPC-H: Total hot run time: 40399 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
ggershinsky commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609323577 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition.

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
ggershinsky commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609323273 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition.

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-22 Thread via GitHub
showuon commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123949904 Forgot to say, thanks for closing all the `ConsumerGroupService` instances. I can't believe we leak these resources before. -- This is an automated message from the Apache Git Service.

Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #41732: URL: https://github.com/apache/arrow/pull/41732#issuecomment-2123949694 Revision: 67fc7ceadab5a7ff7446c95097ebe2e8c501296a Submitted crossbow builds: [ursacomputing/crossbow @

Re: [PR] CAY-2854 Improve delete prevention detection of flattened attribute row [cayenne]

2024-05-22 Thread via GitHub
Jugen commented on PR #615: URL: https://github.com/apache/cayenne/pull/615#issuecomment-2123949263 I have rebased and updated the release-notes for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Enable local sort-based shuffle [incubator-gluten]

2024-05-22 Thread via GitHub
marin-ma commented on PR #5811: URL: https://github.com/apache/incubator-gluten/pull/5811#issuecomment-2123948922 The UT failure of commit https://github.com/apache/incubator-gluten/pull/5811/commits/56580aa690fd5099c55fcf01e213b9cad1267fad is due to metrics changed which causes AQE

Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]

2024-05-22 Thread via GitHub
weihubeats commented on PR #740: URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2123948927 @lizhanhui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Pipe: Fixed the bug that insertNode.getDevicePath() is not handled correctly for insertRowsNode [iotdb]

2024-05-22 Thread via GitHub
SteveYurongSu merged PR #12569: URL: https://github.com/apache/iotdb/pull/12569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [AMORO-2855] Paimon version bump to 0.8.0 [amoro]

2024-05-22 Thread via GitHub
zhoujinsong merged PR #2856: URL: https://github.com/apache/amoro/pull/2856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-22 Thread via GitHub
showuon commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123948788 One high-level question: I found after this change, we increased the test case numbers from 492 -> 660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we really need

Re: [PR] kie-kogito-serverless-operator-459: Restructuring of the Cloud -> Operator -> Persistence chapter [incubator-kie-kogito-docs]

2024-05-22 Thread via GitHub
kaldesai commented on code in PR #628: URL: https://github.com/apache/incubator-kie-kogito-docs/pull/628#discussion_r1609321302 ## serverlessworkflow/modules/ROOT/pages/persistence/core-concepts.adoc: ## @@ -6,11 +6,38 @@ :keywords: sonataflow, workflow, serverless, timeout,

Re: [I] [Improvement]: paimon version bump to 0.8.0 [amoro]

2024-05-22 Thread via GitHub
zhoujinsong closed issue #2855: [Improvement]: paimon version bump to 0.8.0 URL: https://github.com/apache/amoro/issues/2855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.0 to 2.17.1 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2567: URL: https://github.com/apache/logging-log4j2/pull/2567#issuecomment-2123947990 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [D] 重试消息一次发送多次,只能通过幂等处理吗? [rocketmq]

2024-05-22 Thread via GitHub
GitHub user ling0900 added a comment to the discussion: 重试消息一次发送多次,只能通过幂等处理吗? 业务幂等是非常有必要的,这也是兜底的一种方式。 GitHub link: https://github.com/apache/rocketmq/discussions/8131#discussioncomment-9516998 This is an automatically sent email for dev@rocketmq.apache.org. To unsubscribe, please send

Re: [PR] [Fix](regression) fix test_user_var.groovy by add set disable_nereids_rules=PRUNE_EMPTY_PARTITION [doris]

2024-05-22 Thread via GitHub
morrySnow merged PR #35151: URL: https://github.com/apache/doris/pull/35151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10389 Implement a search feature for users to locate open keys within the Open Keys Insights section. [ozone]

2024-05-22 Thread via GitHub
devmadhuu commented on code in PR #6231: URL: https://github.com/apache/ozone/pull/6231#discussion_r1609301039 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightSearchEndpoint.java: ## @@ -0,0 +1,390 @@ +/** + * Licensed to the Apache Software

Re: [PR] [fix](multi-catalog)put java udf to custom lib [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34990: URL: https://github.com/apache/doris/pull/34990#issuecomment-2123947117 TeamCity be ut coverage result: Function Coverage: 35.68% (9016/25269) Line Coverage: 27.32% (74581/272958) Region Coverage: 26.54% (38572/145320) Branch Coverage:

Re: [PR] [#1675][FOLLOWUP] fix(test): Fix various flaky tests [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #1730: URL: https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609319998 ## pom.xml: ## @@ -921,6 +921,7 @@ ${project.build.directory}/tmp ${project.version} target/jacoco.exec +

Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]

2024-05-22 Thread via GitHub
vibhatha commented on PR #41732: URL: https://github.com/apache/arrow/pull/41732#issuecomment-2123946437 @github-actions crossbow submit -g java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Fix-16046][SqlTask] Fix Sql task use time type is incorrect [dolphinscheduler]

2024-05-22 Thread via GitHub
codecov-commenter commented on PR #16050: URL: https://github.com/apache/dolphinscheduler/pull/16050#issuecomment-2123946269 ##

Re: [PR] Bump ejs and nightwatch [couchdb-fauxton]

2024-05-22 Thread via GitHub
big-r81 commented on PR #1437: URL: https://github.com/apache/couchdb-fauxton/pull/1437#issuecomment-2123946075 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Feature][Kafka] Support multi-table source read [seatunnel]

2024-05-22 Thread via GitHub
EricJoy2048 merged PR #5992: URL: https://github.com/apache/seatunnel/pull/5992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] (#5489) Use yaml in e2e install [camel-k]

2024-05-22 Thread via GitHub
squakez commented on PR #5518: URL: https://github.com/apache/camel-k/pull/5518#issuecomment-2123945759 Let me know if this is good to merge, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Spark Kyuubi UI supports both javax and jakarta servlet namespaces [kyuubi]

2024-05-22 Thread via GitHub
yikf commented on PR #6399: URL: https://github.com/apache/kyuubi/pull/6399#issuecomment-2123944690 late lgtm due to busy with other things, thanks @pan3793 for the nice work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Spark engine supports both javax and jakarta ws.rs namespaces [kyuubi]

2024-05-22 Thread via GitHub
codecov-commenter commented on PR #6405: URL: https://github.com/apache/kyuubi/pull/6405#issuecomment-2123942900 ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6405?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Add required status checks and review count [couchdb-fauxton]

2024-05-22 Thread via GitHub
big-r81 merged PR #1436: URL: https://github.com/apache/couchdb-fauxton/pull/1436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [TubeMQ] Adjust FATAL type error return content, without carrying class name [inlong]

2024-05-22 Thread via GitHub
gosonzhang closed issue #9613: [TubeMQ] Adjust FATAL type error return content, without carrying class name URL: https://github.com/apache/inlong/issues/9613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-05-22 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1609316591 ## extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/output/RetryableS3OutputStreamTest.java: ## @@ -286,12 +286,12 @@

Re: [PR] [INLONG-9613][TubeMQ] Adjust FATAL type error return content, without carrying class name [inlong]

2024-05-22 Thread via GitHub
gosonzhang merged PR #10251: URL: https://github.com/apache/inlong/pull/10251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Feature] Can the current chart be displayed like this? [echarts]

2024-05-22 Thread via GitHub
xyy7260 commented on issue #19947: URL: https://github.com/apache/echarts/issues/19947#issuecomment-2123941724 > @helgasoft Thank you very much for letting me know the term. :D This is great! When will it be released? -- This is an automated message from the Apache Git

Re: [PR] Fix typo keyparis -> keypairs in InvalidParameterValueException [cloudstack]

2024-05-22 Thread via GitHub
codecov[bot] commented on PR #9100: URL: https://github.com/apache/cloudstack/pull/9100#issuecomment-2123941773 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9100?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] chore: Update pekko version [flink]

2024-05-22 Thread via GitHub
He-Pin commented on PR #24823: URL: https://github.com/apache/flink/pull/24823#issuecomment-2123941241 ``` 05:58:50,756 INFO org.apache.flink.tools.ci.licensecheck.NoticeFileChecker [] - Problems were detected for a NOTICE file. flink-rpc-akka: These issue

Re: [PR] [Feature][Connector Hive] support hive savemode [seatunnel]

2024-05-22 Thread via GitHub
liunaijie commented on PR #6842: URL: https://github.com/apache/seatunnel/pull/6842#issuecomment-2123940700 > 大佬你好,创建的statement好像有点问题 org.apache.hadoop.hive.ql.parse.ParseException:line 1:0 cannot recognize input near '' '' '' 是提交partition信息的语句吗 还是哪个语句? -- This is an automated

Re: [PR] listNetworks optimization [cloudstack]

2024-05-22 Thread via GitHub
abh1sar commented on code in PR #9096: URL: https://github.com/apache/cloudstack/pull/9096#discussion_r1609315083 ## server/src/main/java/com/cloud/network/NetworkServiceImpl.java: ## @@ -2267,7 +2267,7 @@ public Pair, Integer> searchForNetworks(ListNetworksCmd

Re: [PR] [DSIP-42] Add dolphinscheduler-aws-authentication module [dolphinscheduler]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #16043: URL: https://github.com/apache/dolphinscheduler/pull/16043#issuecomment-2123940284 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] [#1731] improvement(server): Bump gRPC from 1.63.0 to 1.64.0 [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on PR #1732: URL: https://github.com/apache/incubator-uniffle/pull/1732#issuecomment-2123940121 Maybe we should upgrade to 1.63.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-05-22 Thread via GitHub
liuyongvs commented on PR #24526: URL: https://github.com/apache/flink/pull/24526#issuecomment-2123939160 @snuyanzin Indeed, while this might only result in a difference in function behavior, it would generally be best to align with the practices of the majority of other engines. If in the

Re: [PR] [DSIP-42] Add dolphinscheduler-aws-authentication module [dolphinscheduler]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #16043: URL: https://github.com/apache/dolphinscheduler/pull/16043#issuecomment-2123939144 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]

2024-05-22 Thread via GitHub
vibhatha commented on code in PR #41732: URL: https://github.com/apache/arrow/pull/41732#discussion_r1609314106 ## java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java: ## @@ -76,12 +78,13 @@ public ArrowRecordBatch( * @param nodes field

Re: [PR] GH-41764: [Parquet][C++] Support future logical types in the Parquet reader [arrow]

2024-05-22 Thread via GitHub
wgtmac commented on code in PR #41765: URL: https://github.com/apache/arrow/pull/41765#discussion_r1609313940 ## cpp/src/parquet/types.cc: ## @@ -464,7 +464,10 @@ std::shared_ptr LogicalType::FromThrift( } else if (type.__isset.FLOAT16) { return

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-22 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1609312616 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -281,64 +276,15 @@ void testEnsureMetadataUpdateOnPoll() {

Re: [PR] [VL] Not fallback for function spark_partition_id [incubator-gluten]

2024-05-22 Thread via GitHub
zhli1142015 merged PR #5830: URL: https://github.com/apache/incubator-gluten/pull/5830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-22 Thread via GitHub
showuon commented on code in PR #15908: URL: https://github.com/apache/kafka/pull/15908#discussion_r1609296852 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java: ## @@ -92,6 +94,7 @@ static void generator(ClusterGenerator

Re: [I] [Enhancement] support update topic reserved time for topic in tiered storage [rocketmq]

2024-05-22 Thread via GitHub
lizhimins closed issue #8129: [Enhancement] support update topic reserved time for topic in tiered storage URL: https://github.com/apache/rocketmq/issues/8129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Update readme to point to 1.14.0 release [parquet-java]

2024-05-22 Thread via GitHub
wgtmac merged PR #1356: URL: https://github.com/apache/parquet-java/pull/1356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
ggershinsky commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609311732 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition.

Re: [PR] [ISSUE #8129] Support topic reserved time in tiered storage [rocketmq]

2024-05-22 Thread via GitHub
lizhimins merged PR #8130: URL: https://github.com/apache/rocketmq/pull/8130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [refactor](datalake) return the error status instead of static_cast [doris]

2024-05-22 Thread via GitHub
morningman merged PR #34873: URL: https://github.com/apache/doris/pull/34873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] server,test: fix resourceid for VOLUME.DESTROY in restore VM [cloudstack]

2024-05-22 Thread via GitHub
shwstppr closed pull request #9032: server,test: fix resourceid for VOLUME.DESTROY in restore VM URL: https://github.com/apache/cloudstack/pull/9032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] api,server: allow project role-based api access [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #9090: URL: https://github.com/apache/cloudstack/pull/9090#issuecomment-2123935134 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: honor listall param for listiso api [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #9064: URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2123935091 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2123935046 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,server: list autoscalevmgroups with keyword [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #9046: URL: https://github.com/apache/cloudstack/pull/9046#issuecomment-2123934993 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,server: list autoscalevmgroups with keyword [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #9046: URL: https://github.com/apache/cloudstack/pull/9046#issuecomment-2123934236 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] GH-41764: [Parquet][C++] Support future logical types in the Parquet reader [arrow]

2024-05-22 Thread via GitHub
mapleFU commented on code in PR #41765: URL: https://github.com/apache/arrow/pull/41765#discussion_r1609310095 ## cpp/src/parquet/types.cc: ## @@ -464,7 +464,10 @@ std::shared_ptr LogicalType::FromThrift( } else if (type.__isset.FLOAT16) { return

Re: [PR] server,cks: check if vm is cks node during vm destroy [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #9057: URL: https://github.com/apache/cloudstack/pull/9057#issuecomment-2123933525 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: honor listall param for listiso api [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #9064: URL: https://github.com/apache/cloudstack/pull/9064#issuecomment-2123933388 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-05-22 Thread via GitHub
cryptoe commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1609309586 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java: ## @@ -103,13 +109,35 @@ public class

Re: [PR] api,ui: vm template format, fix vm info link [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #9094: URL: https://github.com/apache/cloudstack/pull/9094#issuecomment-2123932783 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,server: allow project role-based api access [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #9090: URL: https://github.com/apache/cloudstack/pull/9090#issuecomment-2123932632 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1719: Bump `guava` to 33.2.0-jre [orc]

2024-05-22 Thread via GitHub
dependabot[bot] commented on PR #1934: URL: https://github.com/apache/orc/pull/1934#issuecomment-2123932733 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] ORC-1719: Bump `guava` to 33.2.0-jre [orc]

2024-05-22 Thread via GitHub
cxzl25 closed pull request #1934: ORC-1719: Bump `guava` to 33.2.0-jre URL: https://github.com/apache/orc/pull/1934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    1   2   3   4   5   6   7   8   9   10   >