Re: [PR] ORC-1718: Upgrade `build-helper-maven-plugin` to 3.6.0 [orc]

2024-05-21 Thread via GitHub
cxzl25 closed pull request #1938: ORC-1718: Upgrade `build-helper-maven-plugin` to 3.6.0 URL: https://github.com/apache/orc/pull/1938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-05-21 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1609243592 ## flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsSinkBuilder.java: ## @@ -0,0 +1,161 @@ +/* + *

[PR] RATIS-2098. RaftLogTruncateTests may fail. [ratis]

2024-05-21 Thread via GitHub
szetszwo opened a new pull request, #1097: URL: https://github.com/apache/ratis/pull/1097 See RATIS-2098. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-35353][docs-zh]Translate "Profiler" page into Chinese [flink]

2024-05-21 Thread via GitHub
drymatini closed pull request #24793: [FLINK-35353][docs-zh]Translate "Profiler" page into Chinese URL: https://github.com/apache/flink/pull/24793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-5757][CORE] Remove unnecessary ProjectExecTransformer for Generate [incubator-gluten]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #5782: URL: https://github.com/apache/incubator-gluten/pull/5782#issuecomment-2123846934 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve][ci] Add arm64 image build [pulsar]

2024-05-21 Thread via GitHub
codecov-commenter commented on PR #22755: URL: https://github.com/apache/pulsar/pull/22755#issuecomment-2123846887 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22755?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-21 Thread via GitHub
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123845660 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-05-21 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1609241620 ## flink-connector-aws/flink-connector-sqs/src/main/java/org.apache.flink.connector.sqs/sink/SqsSinkWriter.java: ## @@ -0,0 +1,272 @@ +/* + *

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35154: URL: https://github.com/apache/doris/pull/35154#issuecomment-2123844752 TPC-H: Total hot run time: 49800 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [MINOR] fix(docs): Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms [incubator-uniffle]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #1734: URL: https://github.com/apache/incubator-uniffle/pull/1734#issuecomment-2123844721 ## Test Results  2 405 files  ±0   2 405 suites  ±0   4h 58m 18s :stopwatch: -9s    931 tests ±0     930 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0  10 

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-21 Thread via GitHub
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123843950 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug] chrome@109,echart@5.5和echarts-gl@2.0.9散点图坐标系消失 [echarts]

2024-05-21 Thread via GitHub
helgasoft commented on issue #19964: URL: https://github.com/apache/echarts/issues/19964#issuecomment-2123844200 your code is missing data, cannot reproduce. When data added, it works -

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123843870 TeamCity be ut coverage result: Function Coverage: 35.68% (9017/25274) Line Coverage: 27.32% (74575/272981) Region Coverage: 26.54% (38567/145325) Branch Coverage:

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [camel-quarkus]

2024-05-21 Thread via GitHub
zhfeng merged PR #6114: URL: https://github.com/apache/camel-quarkus/pull/6114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] HBASE-28612 fix replication quota leak when peer changes [hbase]

2024-05-21 Thread via GitHub
1458451310 opened a new pull request, #5930: URL: https://github.com/apache/hbase/pull/5930 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] MINOR: Aesthetic, Uniformity Changes and Reducing warnings [kafka]

2024-05-21 Thread via GitHub
rreddy-22 opened a new pull request, #16026: URL: https://github.com/apache/kafka/pull/16026 Went through all the files in the group coordinator module and fixed up a few minor warnings and cleaned up a few leftover errors. Also fixed the formatting to make it more uniform -- This

Re: [PR] Bump go version [dubbo-go]

2024-05-21 Thread via GitHub
qinyuanlong-tx commented on PR #2612: URL: https://github.com/apache/dubbo-go/pull/2612#issuecomment-2123842613 can't find this module. $ go get dubbo.apache.org/dubbo-go/v3/cmd/protoc-gen-go-triple

Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 [maven-artifact-plugin]

2024-05-21 Thread via GitHub
dependabot[bot] closed pull request #34: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 URL: https://github.com/apache/maven-artifact-plugin/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 [maven-artifact-plugin]

2024-05-21 Thread via GitHub
dependabot[bot] commented on PR #34: URL: https://github.com/apache/maven-artifact-plugin/pull/34#issuecomment-2123841726 Superseded by #44. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.4 [maven-artifact-plugin]

2024-05-21 Thread via GitHub
dependabot[bot] opened a new pull request, #44: URL: https://github.com/apache/maven-artifact-plugin/pull/44 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.4. Release notes Sourced from

Re: [PR] [MINOR] fix(server): Use warn log when unable to acquire memory [incubator-uniffle]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #1733: URL: https://github.com/apache/incubator-uniffle/pull/1733#issuecomment-2123841353 ## Test Results  2 405 files  ±0   2 405 suites  ±0   4h 57m 55s :stopwatch: -32s    931 tests ±0     930 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0  10 

Re: [PR] SOLR-17118: Simplify CoreContainerProvider initialization [solr]

2024-05-21 Thread via GitHub
dsmiley commented on code in PR #2474: URL: https://github.com/apache/solr/pull/2474#discussion_r1609237802 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -167,8 +158,10 @@ public void init(FilterConfig config) throws ServletException { }

Re: [PR] [fix] [client] PIP-344 Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName) [pulsar]

2024-05-21 Thread via GitHub
poorbarcode commented on PR #22206: URL: https://github.com/apache/pulsar/pull/22206#issuecomment-2123840423 Rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](regression) fix test_user_var.groovy by add set disable_nereids_rules=PRUNE_EMPTY_PARTITION [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35151: URL: https://github.com/apache/doris/pull/35151#issuecomment-2123840188 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](regression) fix test_user_var.groovy by add set disable_nereids_rules=PRUNE_EMPTY_PARTITION [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35151: URL: https://github.com/apache/doris/pull/35151#issuecomment-2123840162 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-28109][connector/elasticsearch] Delete useful code in the row emitter [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa closed pull request #21: [FLINK-28109][connector/elasticsearch] Delete useful code in the row emitter URL: https://github.com/apache/flink-connector-elasticsearch/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-28109][connector/elasticsearch] Delete useful code in the row emitter [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa commented on PR #21: URL: https://github.com/apache/flink-connector-elasticsearch/pull/21#issuecomment-2123839960 I think we can open a new PR to deal with this, because it has been stale for too long. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-28109][connector/elasticsearch] Delete useful code in the row emitter [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa commented on PR #21: URL: https://github.com/apache/flink-connector-elasticsearch/pull/21#issuecomment-2123838824 Would you minding rebasing this on the latest main branch, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Support ListAgg WITHIN GROUP clause [pinot]

2024-05-21 Thread via GitHub
xiangfu0 merged PR #13146: URL: https://github.com/apache/pinot/pull/13146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123838659 ClickBench: Total hot run time: 31.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] Use ContextServiceFacade to decouple EventBus for set instance state and label instance [shardingsphere]

2024-05-21 Thread via GitHub
strongduanmu merged PR #31338: URL: https://github.com/apache/shardingsphere/pull/31338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(python): DLPack support on CBufferView [arrow-nanoarrow]

2024-05-21 Thread via GitHub
AlenkaF commented on code in PR #469: URL: https://github.com/apache/arrow-nanoarrow/pull/469#discussion_r1609236451 ## python/tests/test_dlpack.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] [FLINK-28428][connectors/elasticsearch][docs][docs-zh] Fix example and Chinese translations [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa commented on PR #23: URL: https://github.com/apache/flink-connector-elasticsearch/pull/23#issuecomment-2123837897 I think we can close this first, because it has been stale for too long. Feel free to rebase/update and reopen this. -- This is an automated message from the Apache

Re: [PR] [FLINK-28428][connectors/elasticsearch][docs][docs-zh] Fix example and Chinese translations [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa closed pull request #23: [FLINK-28428][connectors/elasticsearch][docs][docs-zh] Fix example and Chinese translations URL: https://github.com/apache/flink-connector-elasticsearch/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] ARTEMIS-4420 user auth leaks into non-Artemis servlets [activemq-artemis]

2024-05-21 Thread via GitHub
jbertram commented on PR #4897: URL: https://github.com/apache/activemq-artemis/pull/4897#issuecomment-2123837290 @gtully, point taken. I've updated the PR with what I believe will address the `ThreadLocal` issue. I wasn't able to come up with a way to test it automatically, but manual

Re: [PR] [VL] Upgrade folly to v2024.04.01.00 [incubator-gluten]

2024-05-21 Thread via GitHub
zhouyuan commented on PR #5314: URL: https://github.com/apache/incubator-gluten/pull/5314#issuecomment-2123837405 @PHILO-HE It looks like this patch is missed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add support of the command JSON.DEBUG MEMORY [kvrocks]

2024-05-21 Thread via GitHub
jacky commented on code in PR #2323: URL: https://github.com/apache/kvrocks/pull/2323#discussion_r1609215770 ## src/types/json.h: ## @@ -217,6 +217,42 @@ struct JsonValue { return results; } + StatusOr> GetBytes(std::string_view path, JsonStorageFormat

Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]

2024-05-21 Thread via GitHub
mymeiyi commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2123837048 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
morrySnow commented on PR #35153: URL: https://github.com/apache/doris/pull/35153#issuecomment-2123836702 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.19 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
dependabot[bot] commented on PR #95: URL: https://github.com/apache/flink-connector-elasticsearch/pull/95#issuecomment-2123836152 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-21 Thread via GitHub
Apache9 commented on code in PR #5903: URL: https://github.com/apache/hbase/pull/5903#discussion_r1609234851 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloseExcessRegionReplicasProcedure.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache

Re: [PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.19 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa commented on PR #95: URL: https://github.com/apache/flink-connector-elasticsearch/pull/95#issuecomment-2123836129 We should discuss it before we upgrade, close for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.19 in /flink-connector-elasticsearch-base [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa closed pull request #95: Bump org.elasticsearch:elasticsearch from 7.10.2 to 7.17.19 in /flink-connector-elasticsearch-base URL: https://github.com/apache/flink-connector-elasticsearch/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] ensure inverse AndFilterOperator implementation matches the query [pinot]

2024-05-21 Thread via GitHub
itschrispeck commented on PR #13199: URL: https://github.com/apache/pinot/pull/13199#issuecomment-2123835730 Got it, added a test case. Also left a comment on the `or` implementation. I don't have a strong opinion there. -- This is an automated message from the Apache Git

Re: [I] Build CuratorFrameworkFactory supports an option to skip Ensemble tracking. [shardingsphere-elasticjob]

2024-05-21 Thread via GitHub
xull1995 commented on issue #2072: URL: https://github.com/apache/shardingsphere-elasticjob/issues/2072#issuecomment-2123835239 I'm facing the same issue. My ZooKeeper cluster is deployed on Kubernetes, and the ZooKeeper nodes are using a headless service. As a result, the headless domain

Re: [PR] [fix](memory) Allow flush memtable failed when process exceed memlimit [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35150: URL: https://github.com/apache/doris/pull/35150#issuecomment-2123834866 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](memory) Allow flush memtable failed when process exceed memlimit [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35150: URL: https://github.com/apache/doris/pull/35150#issuecomment-2123834838 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35153: URL: https://github.com/apache/doris/pull/35153#issuecomment-2123834734 ClickBench: Total hot run time: 31.01 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123834445 TPC-DS: Total hot run time: 182062 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

[PR] SOLR-17118: Simplify CoreContainerProvider initialization [solr]

2024-05-21 Thread via GitHub
dsmiley opened a new pull request, #2474: URL: https://github.com/apache/solr/pull/2474 Thereby fixing some rare bugs in tests, maybe in the real world too. https://issues.apache.org/jira/browse/SOLR-17118 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-35287] Builder builds NetworkConfig for Elasticsearch connector 8 [flink-connector-elasticsearch]

2024-05-21 Thread via GitHub
reswqa merged PR #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Reuse same code path with heuristic planner for convention enforcement [incubator-gluten]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #5824: URL: https://github.com/apache/incubator-gluten/pull/5824#issuecomment-2123833755 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Optimize offload rule code to gain better compatibility with rewrite rules [incubator-gluten]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #5836: URL: https://github.com/apache/incubator-gluten/pull/5836#issuecomment-2123833793 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Merge config files to iotdb-system.properties [iotdb-client-go]

2024-05-21 Thread via GitHub
shuwenwei opened a new pull request, #99: URL: https://github.com/apache/iotdb-client-go/pull/99 Merge config files to iotdb-system.properties https://github.com/apache/iotdb/pull/12570 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Optimize the decoding of generic http2 [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14175: URL: https://github.com/apache/dubbo/pull/14175#issuecomment-2123832500 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Add contract first development section in rest-openapi doc [camel-quarkus]

2024-05-21 Thread via GitHub
zhfeng opened a new pull request, #6115: URL: https://github.com/apache/camel-quarkus/pull/6115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35153: URL: https://github.com/apache/doris/pull/35153#issuecomment-2123830376 TPC-DS: Total hot run time: 181957 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] Fix `Coalesce` casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion [datafusion]

2024-05-21 Thread via GitHub
appletreeisyellow commented on PR #10268: URL: https://github.com/apache/datafusion/pull/10268#issuecomment-2123829586 > I am not sure I have the time to do that in the next week -- maybe @appletreeisyellow does 樂 @alamb I'm happy to coordinate with our performance team and run an

Re: [D] Unable to package with Java11, error reported [pekko]

2024-05-21 Thread via GitHub
GitHub user zhenggexia closed a discussion: Unable to package with Java11, error reported I downloaded the source code for version v1.1.0-M1 and packaged it with Java11. However, I encountered an error message. Here is my log. How can I package it properly? ```scala WARNING: An illegal

Re: [D] Unable to package with Java11, error reported [pekko]

2024-05-21 Thread via GitHub
GitHub user He-Pin closed the discussion with a comment: Unable to package with Java11, error reported I have contacted him/her, and now it works, mostly local issue. close it. GitHub link: https://github.com/apache/pekko/discussions/1333#discussioncomment-9516143 This is an

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
morrySnow commented on PR #35154: URL: https://github.com/apache/doris/pull/35154#issuecomment-2123828019 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [fix][broker] The result is inaccurate when schema is non-recoverable in method trimDeletedSchemaAndGetList. [pulsar]

2024-05-21 Thread via GitHub
hanmz opened a new pull request, #22758: URL: https://github.com/apache/pulsar/pull/22758 ### Motivation The return secheamResult is inaccurate when schema encounter an non-recoverable exception in method `trimDeletedSchemaAndGetList`. Although, we executed the

Re: [PR] [Feat](planner)create table stmt offer default distribution attribute :random distribution and auto bucket [doris]

2024-05-21 Thread via GitHub
feiniaofeiafei commented on PR #35189: URL: https://github.com/apache/doris/pull/35189#issuecomment-2123827879 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Feat](planner)create table stmt offer default distribution attribute :random distribution and auto bucket [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35189: URL: https://github.com/apache/doris/pull/35189#issuecomment-2123827826 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Feat](planner)create table stmt offer default distribution attribute :random distribution and auto bucket [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35189: URL: https://github.com/apache/doris/pull/35189#issuecomment-2123827797 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Clustering issues leading to all nodes being downed [pekko]

2024-05-21 Thread via GitHub
zhenggexia commented on issue #578: URL: https://github.com/apache/pekko/issues/578#issuecomment-2123827582 目前我的k8s集群有26个pod运行,当其中某一个pod因为资源不足重启的时候,常常会导致整个集群挂调,我们处理数据量比较大,资源占用比较高,目前在其他集群上(比如docker运行注册到nacos上),暂时没有出现这个问题 -- This is an automated message from the Apache Git Service. To

Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2123827036 ClickBench: Total hot run time: 30.28 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] KAFKA-16709: abortAndPauseCleaning only when future log is not existed [kafka]

2024-05-21 Thread via GitHub
showuon commented on code in PR #15951: URL: https://github.com/apache/kafka/pull/15951#discussion_r1609228927 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2114,16 +2114,12 @@ class ReplicaManager(val config: KafkaConfig, partition.log.foreach { _

Re: [PR] [improve](nereids) support pushdown count when scan project without any slot ref [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35162: URL: https://github.com/apache/doris/pull/35162#issuecomment-2123826895 ClickBench: Total hot run time: 30.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] Add TripleConfig to ProtocolConfig as nest configuration [dubbo]

2024-05-21 Thread via GitHub
sonarcloud[bot] commented on PR #14077: URL: https://github.com/apache/dubbo/pull/14077#issuecomment-2123826843 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Feat](planner)create table stmt offer default distribution attribute :random distribution and auto bucket [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35189: URL: https://github.com/apache/doris/pull/35189#issuecomment-2123826220 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] GH-41755: [C++][ORC] Teach CheckTimeZoneDatabaseAvailability how to inspect conda environments [arrow]

2024-05-21 Thread via GitHub
wgtmac commented on code in PR #41767: URL: https://github.com/apache/arrow/pull/41767#discussion_r1609228646 ## cpp/src/arrow/adapters/orc/adapter.cc: ## @@ -189,15 +189,21 @@ liborc::RowReaderOptions DefaultRowReaderOptions() { #ifdef ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK

[PR] [Feat](planner)create table stmt offer default distribution attribute :random distribution and auto bucket [doris]

2024-05-21 Thread via GitHub
feiniaofeiafei opened a new pull request, #35189: URL: https://github.com/apache/doris/pull/35189 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [D] Unable to package with Java11, error reported [pekko]

2024-05-21 Thread via GitHub
GitHub user jxnu-liguobin added a comment to the discussion: Unable to package with Java11, error reported > 你是阿里的同学吗? 为啥叫同学 GitHub link: https://github.com/apache/pekko/discussions/1333#discussioncomment-9516134 This is an automatically sent email for notifications@pekko.apache.org.

Re: [PR] feat: add hex scalar function [datafusion-comet]

2024-05-21 Thread via GitHub
tshauck commented on code in PR #449: URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1609228014 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -1038,6 +1038,26 @@ class CometExpressionSuite extends CometTestBase with

Re: [PR] [FLINK-34549][API] Introduce config, context and processingTimerService for DataStream API V2 [flink]

2024-05-21 Thread via GitHub
reswqa merged PR #24541: URL: https://github.com/apache/flink/pull/24541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] after switching tabs for a while, when switching back, the chart content is blank [echarts]

2024-05-21 Thread via GitHub
plainheart commented on issue #16462: URL: https://github.com/apache/echarts/issues/16462#issuecomment-2123825237 @wangf1978 I'm not sure but you may try this, ``` document.addEventListener('visibilitychange', function () { if (document.visibilityState === "visible") {

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [syncope]

2024-05-21 Thread via GitHub
ilgrosso merged PR #722: URL: https://github.com/apache/syncope/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48281][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringInStr, SubstringIndex) [spark]

2024-05-21 Thread via GitHub
mkaravel commented on PR #46589: URL: https://github.com/apache/spark/pull/46589#issuecomment-2123824946 @uros-db Please see my comment about the PR description in https://github.com/apache/spark/pull/46511 The same comment applies to the PR description for this PR. -- This is an

Re: [PR] feat: add hex scalar function [datafusion-comet]

2024-05-21 Thread via GitHub
tshauck commented on PR #449: URL: https://github.com/apache/datafusion-comet/pull/449#issuecomment-2123824670 @kazuyukitanimura @advancedxy ... re-requesting reviews from you two, please. I've updated the code to support dictionaries and removed some of the finer int types. Barring

Re: [I] remove orphan file question [iceberg]

2024-05-21 Thread via GitHub
manuzhang commented on issue #10363: URL: https://github.com/apache/iceberg/issues/10363#issuecomment-2123824636 It usually happens when snapshots are removed while their referenced files are not somehow. For example, in `expire_snapshots` procedure, expired file are removed after their

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on PR #15825: URL: https://github.com/apache/kafka/pull/15825#issuecomment-2123824613 @junrao @showuon Thanks for the review! Addressed all the review comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609227442 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new

Re: [PR] [SPARK-48221][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (Contains, StartsWith, EndsWith, StringLocate) [spark]

2024-05-21 Thread via GitHub
mkaravel commented on PR #46511: URL: https://github.com/apache/spark/pull/46511#issuecomment-2123824322 @uros-db I am reading this in the PR description: > Why are the changes needed? Fix functions that give unexpected results due to the conditional case mapping when

Re: [PR] [SPARK-48370][CONNECT] Checkpoint and localCheckpoint in Scala Spark Connect client [spark]

2024-05-21 Thread via GitHub
HyukjinKwon commented on code in PR #46683: URL: https://github.com/apache/spark/pull/46683#discussion_r1609227214 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -73,6 +73,11 @@ class SparkSession private[sql] ( with Logging {

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-21 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1609227180 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -370,11 +370,17 @@ class LocalLog(@volatile private var _dir: File, throw new

[PR] [Fix-16046][api] Fix PreparedStatement parameter type [dolphinscheduler]

2024-05-21 Thread via GitHub
yinxiaolog opened a new pull request, #16050: URL: https://github.com/apache/dolphinscheduler/pull/16050 ## Purpose of the pull request If SQL specifies a user-defined parameter of the TIME type, set it to the java.sql.Time type when setting the PreparedStatement parameter.

Re: [PR] Fix bugs in Redisson plugin [skywalking-java]

2024-05-21 Thread via GitHub
CzyerChen commented on code in PR #693: URL: https://github.com/apache/skywalking-java/pull/693#discussion_r1609226635 ## apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java: ## @@

Re: [PR] HIVE-28271: DirectSql fails for AlterPartitions. [hive]

2024-05-21 Thread via GitHub
wecharyu commented on PR #5256: URL: https://github.com/apache/hive/pull/5256#issuecomment-2123823254 LGTM overall, only a nit code change request. BTW the error mainly comes from Derby DB right? @ayushtkn -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #34721: URL: https://github.com/apache/doris/pull/34721#issuecomment-2123822888 TPC-DS: Total hot run time: 182574 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improve](nereids) support pushdown count when scan project without any slot ref [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35162: URL: https://github.com/apache/doris/pull/35162#issuecomment-2123822795 TPC-DS: Total hot run time: 182104 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35153: URL: https://github.com/apache/doris/pull/35153#issuecomment-2123821859 TPC-H: Total hot run time: 42062 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [AMORO-2731]: remove unuse import [amoro]

2024-05-21 Thread via GitHub
zhoujinsong commented on PR #2858: URL: https://github.com/apache/amoro/pull/2858#issuecomment-2123821817 You can add some content like `Close #2731` to link this PR to its related issue. I have added it for you this time. -- This is an automated message from the Apache Git Service.

Re: [PR] [SPARK-48370][CONNECT] Checkpoint and localCheckpoint in Scala Spark Connect client [spark]

2024-05-21 Thread via GitHub
HyukjinKwon commented on code in PR #46683: URL: https://github.com/apache/spark/pull/46683#discussion_r1609225579 ## connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala: ## @@ -73,6 +73,11 @@ class SparkSession private[sql] ( with Logging {

Re: [PR] Add locking logic to get consistent table view for upsert tables [pinot]

2024-05-21 Thread via GitHub
klsince merged PR #12976: URL: https://github.com/apache/pinot/pull/12976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HIVE-28271: DirectSql fails for AlterPartitions. [hive]

2024-05-21 Thread via GitHub
wecharyu commented on code in PR #5256: URL: https://github.com/apache/hive/pull/5256#discussion_r1609225498 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java: ## @@ -548,6 +548,16 @@ public void addPartitions(List

Re: [PR] [Pick 2.0](index writer) fix docWriter is null, when reenter close [doris-thirdparty]

2024-05-21 Thread via GitHub
qidaye merged PR #217: URL: https://github.com/apache/doris-thirdparty/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Fix](Nereids) fix hint tests with different be instances [doris]

2024-05-21 Thread via GitHub
LiBinfeng-01 commented on PR #35188: URL: https://github.com/apache/doris/pull/35188#issuecomment-2123821217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](Nereids) fix hint tests with different be instances [doris]

2024-05-21 Thread via GitHub
doris-robot commented on PR #35188: URL: https://github.com/apache/doris/pull/35188#issuecomment-2123821186 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] [Bug](runtime-filter) fix brpc ctrl use after free and remove apply filter v1 [doris]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #35186: URL: https://github.com/apache/doris/pull/35186#issuecomment-2123821038 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

<    1   2   3   4   5   6   7   8   9   10   >