[Github-comments] Re: [geany/geany] I have just solved the socket problem in my computer. (Issue #3880)

2024-05-21 Thread Colomban Wendling via Github-comments
Closed #3880 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3880#event-12885446945 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] I have just solved the socket problem in my computer. (Issue #3880)

2024-05-21 Thread Colomban Wendling via Github-comments
Short answer is "no". If this "solved" the issue you mentioned in #3871 it is probably just that you started Geany with sudo, and quit it cleanly. It thus removed the problematic socket file, allowing subsequent non-sudo runs to work properly. The issue you had was a leftover file *not owned

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-21 Thread Colomban Wendling via Github-comments
FWIW, it *is* enough to change the output of `glxinfo`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122562997 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-21 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. LGTM, apart possibly the inline comments. Sad we have to do that in several functions, but makes sense. > + kindDefinition *def; + + if (lang == TM_PARSER_NONE) + return "unknown"; + + def = getLanguageKindForLetter(lang, kind);

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-21 Thread Colomban Wendling via Github-comments
…and no crashes either with 1.39 at a random commit with Compiz under Debian Buster. So either those don't reproduce the issue, or simply setting `XLIB_SKIP_ARGB_VISUALS=1` for the Geany process isn't enough to cause the issue. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-21 Thread Colomban Wendling via Github-comments
Possibly, but I just tried enabling Metacity's compositor (xrender) with no crashes either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122542648 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-21 Thread Colomban Wendling via Github-comments
FWIW I just tested, I can't reproduce the crash simply by setting `XLIB_SKIP_ARGB_VISUALS=1` on my machine (Debian Bookworm, non-composited Metacity WM under MATE -- weird setup you say? bah :grin:) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-21 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-21 Thread Colomban Wendling via Github-comments
@elextr I wouldn't trust X11R6 release notes on this :). It possibly was not useful back then, but it seems useful for transparency in apps. Then again I might lack knowledge on this, but it seems to be the generally accepted idea. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-21 Thread Colomban Wendling via Github-comments
@xiota I don't know exactly the minimum version, but practically any should be ok, why you ask? The issue mentioned above is a change of behavior in glib 2.79. The plugin was admittedly using invalid syntax in the configuration files, but it went unnoticed because it worked fine. -- Reply to

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Colomban Wendling via Github-comments
@eht16 paste configuration issue should be fixed. But indeed it's unrelated to this PR, just to you using a newer GLib -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121311153 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 0e2de9fae3f6c23a1a048da046279222b1118ce7 geniuspaste: Fix replace configurations with GLib 2.79+ -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/7a86376bf18109af37cd534ce9e97ff298ed1012..0e2de9fae3f6c23a1a048da046279222b1118ce7 You are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Colomban Wendling via Github-comments
> Weird, here is Debian Testing but Geany is installed from GIT master. Yeah I meant separate Git install, not from Debian. But I got it, it's likely just you using a newer GLib than I am, and they made a incompatible change: https://gitlab.gnome.org/GNOME/glib/-/issues/3098 -- Reply to this

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2024-05-20 Thread Colomban Wendling via Github-comments
@eht16 no, it's ctags, or rather glibc 2.10. Apparently though upstream ctags switched to gnulib's in universal-ctags/ctags#3054, so we might want to follow that… which might or might not solve this. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-20 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Colomban Wendling via Github-comments
@b4n pushed 2 commits. 4abbf8f4bc4095abf0bde1a97c11c5e7fc5301a9 fixup! Update CI for libsoup3 7a86376bf18109af37cd534ce9e97ff298ed1012 geniuspaste: Update TODO -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread Colomban Wendling via Github-comments
> No leftover configuration. I could reproduce this with pastebin.geany.org on > Linux and Windows. > After removing the keys from the `[parse]` section in > `geniuspaste/data/pastebin.geany.org.conf` so that the section remains empty > in the config, it works. What does the section contain??

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Colomban Wendling via Github-comments
Better, but what about `#ebdfd8`? ![metallic-bottle-ebdfd8](https://github.com/geany/geany-themes/assets/793526/ad7c12be-4434-4a4b-942d-79e4b863570d) Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems. Not that I care, it's indeed better to

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-20 Thread Colomban Wendling via Github-comments
> Sounds like its GTK thats misusing the visuals since its not just Geany thats > affected. Well, it could be that several apps don't properly check the presence of RGBA visuals and just assume they work. But indeed in Geany and Scintilla I don't see any obvious match. In GTK there are a

[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)

2024-05-20 Thread Colomban Wendling via Github-comments
@felixzng cool, that's also instructive and might allow to actually fix it. No guarantee, but at least we've got an idea where to look (unchecked usage of ARGB visuals) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2120427383 You

[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)

2024-05-20 Thread Colomban Wendling via Github-comments
Realistically the only thing we could do is add a button "Start a new instance anyway" kind of button to that dialog that would work as `-i`, or **maybe** offer to delete the problematic socket file as well, but that's not guaranteed to work either (depending on permissions). But that's adding

[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)

2024-05-20 Thread Colomban Wendling via Github-comments
BTW, I want to point out that having other-user-owned files in your homedir is not a problem specific to Geany, and is gonna cause more trouble (and possibly more subtle) than just this message. Think impossibility to save (or possibly even read) configuration or plain files, etc. Check your

[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)

2024-05-19 Thread Colomban Wendling via Github-comments
> Just thinking, in #3859 I mapped matlab variables to `tm_tag_variable_t` so > they are displayed in the sidebar but maybe the result is a little too > verbose. Especially since it generates a tag for every variable assignment - > I just tried it with some random code from github and it

[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)

2024-05-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. Wanna laugh? https://github.com/universal-ctags/ctags/pull/4008 :smile: > @@ -951,6 +951,7 @@ static TMParserMapEntry map_POWERSHELL[] = { {'c', tm_tag_class_t}, // class {'i', tm_tag_function_t}, // filter {'g', tm_tag_enum_t},

[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)

2024-05-19 Thread Colomban Wendling via Github-comments
>I don't think this would be better. >Then every time a new instance would be started which works indepedent of the >existing one. This is especially unconvenient when opening files via the >.desktop items (task bar, app menus, file managers, ...). Agreed, we ain't gonna do that. > The socket

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-16 Thread Colomban Wendling via Github-comments
@techee FWIW, the PRs I wanted merged now are, so it's whenever you like :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2115065344 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
I rebased against master to have a fixed CI, plus added @eht16 Windows bundle fixes -- hopefully this will help testing and finding out what's wrong :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2113570447 You are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
@b4n pushed 7 commits. e7f19b79f4b9e200b3e23d645e3cf62c8a7ca7c9 geniuspaste: Port to libsoup3 bb4513ca7e2a7540461d07acbd4a365ce14be802 geniuspaste: Remove use of deprecated GTK API 80607621e5b1569737f3d2da8f3de6d830c9f706 geniuspaste: Enable HTTPS for paste.debian.net

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
> Then, I got a compiler warning which might or might not be new but still > worth to look at: > > […] It's actually not an issue (the buffer is taken the line before), but probably worth silencing. > When trying to paste some file, Geany crashes for me when it is executed > natively. I

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-14 Thread Colomban Wendling via Github-comments
Once this is dealt with that'd be fine: * https://github.com/universal-ctags/ctags/pull/3993 * https://github.com/universal-ctags/ctags/pull/3998 (new feature, so quite optional) * https://github.com/universal-ctags/ctags/pull/3999 -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-13 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. I didn't review all parser's changes (sorry :sob:), but the Geany changes, tests and behavior look good :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#pullrequestreview-2053777392 You are receiving this

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-13 Thread Colomban Wendling via Github-comments
@techee I just added 2 more commits -- feel free to comment and reject them :) Anyway, looks good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2108753021 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-13 Thread Colomban Wendling via Github-comments
@b4n pushed 2 commits. 77614bd228aaba187faaef3631d127f231fce1f4 Map PowerShell classes and enums ae75c73b48db70a5d59e2dc02a566f1ebfa2ef46 Fix a JavaScript test -- View it on GitHub:

[Github-comments] Re: [geany/geany] Document Comments in Python (Discussion #3869)

2024-05-10 Thread Colomban Wendling via Github-comments
Closed #3869 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3869 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +static TMParserMapGroup group_LDSCRIPT[] = { +}; BTW, it's not merely a warning, but I had an error. However, it's a [GCC extension](https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
> Can do that. Should it be part of this PR or a separate one after this one is > merged? Whichever you prefer. I'd have said this one given it'll introduce yet another set of changes that are probably best diffed from current master, but I don't really mind either way in practice, so if it's

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -557,6 +562,7 @@ static TMParserMapEntry map_FREEBASIC[] = { {'t', tm_tag_struct_t}, // type {'v', tm_tag_variable_t}, // variable {'g', tm_tag_externvar_t}, // enum + {'n', tm_tag_undef_t}, // namespace No

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On tests/ctags/matlab_test.m.tags: that's a bit sad… I'll see if I can get those fixed upstream (it's easy enough to patch actually -- yet, I don't have a clue about matlab :grin: ) -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +static TMParserMapGroup group_LDSCRIPT[] = { +}; This gives me: ``` src/tagmanager/tm_parser.c:1165:44: warning: ISO C forbids empty initializer braces [-Wpedantic] 1165 | static TMParserMapGroup group_LDSCRIPT[] = { |

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-10 Thread Colomban Wendling via Github-comments
As nobody seemed horrified by this, I merged it so we can get CI working again. If there's any issue with this, we can always fix or revert. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2105222322 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-10 Thread Colomban Wendling via Github-comments
Merged #1346 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#event-12773739990 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-05-10 Thread Colomban Wendling via Github-comments
Merged #3759 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#event-12773542349 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Document Comments in Python (Discussion #3869)

2024-05-10 Thread Colomban Wendling via Github-comments
I don't think there is a way to get two different comment colors without modifying the lexer code and Geany's styling. However, the "pythonic" way is using triple-quoted strings (or well, I guess any string will do, but usually documentation is longer than that) as the first statement in e.g.

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
BTW: > Sync our ctags to the latest tag version (p6.1.20240421.0) Tags `p*` are NOT releases, but probably pre-versions, or even nightly snapshots. Releases are `v*`. It's probably fine, but noteworthy :slightly_smiling_face: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Colomban Wendling via Github-comments
Regarding JS: > The only unexpected thing is the behavior of the javascript parser - this is > from the javascript commit message: > > There are lots of differences because of > >

[Github-comments] Re: [geany/geany] Unable to "Build" using Geany (Issue #3863)

2024-05-03 Thread Colomban Wendling via Github-comments
> ```shell > gcc -Wall -o "%e" "%f“ `pkg-config --cflags gtk+-3.0` > -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_0 `pkg-config --libs gtk+-3.0` > ``` The issue you have is that the 4th quote (after the `%f`) is not an ASCII quote, but U+201C *Left Double Quotation Mark*. Just replace the command

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-02 Thread Colomban Wendling via Github-comments
(just updated d0192a3621e2505f2fcf6bc1c390278b2396749e to use a more precise cppcheck suppression) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2091810652 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-02 Thread Colomban Wendling via Github-comments
If there's an option for it, sure (I didn't understand that was something you would be happy about). And I don't mind the default on non-Linux either, whatever people like best on those platforms. It would be nice to have this available on Linux as well (**but off by default**) for the

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-05-01 Thread Colomban Wendling via Github-comments
This PR won (IMO), so it's the one to review @frlan -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2089096951 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Colomban Wendling via Github-comments
Closed #1340. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#event-12673653995 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Colomban Wendling via Github-comments
Yeah I agree, better stick with libsoup then, although relying on an existing component was an interesting idea. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2088925494 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-01 Thread Colomban Wendling via Github-comments
Thanks for the replies  So unless I made a huge mistake (maybe cppcheck my code fixes ), I suggest merging this and seeing where it leads us — at the very least it makes the checks green again, and it did reveal a few leaks. It finished in 10 minutes which is not so bad I'd say. If it's a

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-05-01 Thread Colomban Wendling via Github-comments
> > not using --library=gtk > > See #1197 for why its needed I'm on my phone so can't ask git for details, but l just added it here, so either I bluntly missed it somehow, or it got removed in the meantime, which would be concerning for re-adding it here… > ... should we switch to C++ where

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-04-30 Thread Colomban Wendling via Github-comments
> * Use a version that doesn't require the exhaustive checking (@eht16 why do > we use latest version in the first place? I see > [1562ca0](https://github.com/geany/geany-plugins/commit/1562ca07500505ab396fe99ce19cb211d1c2c8fa) > but no rationale… and if it's that the version in Ubuntu 20.04

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-04-30 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. a34f3a35f92598242888982014e3d8b36c763b4f ci: Disable cppcheck on distcheck -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1346/files/119676eabff36ec59f1bbcac5889a0e1cf66cc13..a34f3a35f92598242888982014e3d8b36c763b4f You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-04-30 Thread Colomban Wendling via Github-comments
21 minutes might be a tad long… 2 things we could to: * Use a version that doesn't require the exhaustive checking (@eht16 why do we use latest version in the first place? I see 1562ca07500505ab396fe99ce19cb211d1c2c8fa but no rationale… and if it's that the version in Ubuntu 20.04 is too old

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-04-30 Thread Colomban Wendling via Github-comments
@b4n pushed 10 commits. 3d1a5aa72b4e3905e0da108ec1c3a5033bc7961c ci: Enable exhaustive cppcheck checking e3f2816ceb5ec08bd16597c045b130c3d18e43ea cppcheck: Enable inline suppression hints 98fc4fb79834e19bca025626f3d6c53aed3038c2 addons: Fix memory leak detected by cppcheck

[Github-comments] [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

2024-04-30 Thread Colomban Wendling via Github-comments
Lets try to make cppcheck work again, and even report useful stuff. During the journey it found a few actual issues, which is good. It also found some false-positives, which isnt so good. We probably could reduce the false positives by not using `--library=gtk`, but that also would reduce the

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. d336856411f9b8897b62c705da5944c29205647b Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/0e025a780b403c083c1d3dcfede8c42a3c26d865..d336856411f9b8897b62c705da5944c29205647b You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 @eht16 Seems

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n pushed 4 commits. 125fe5376e806fb26612d6af1505b639efe8f0df geniuspaste: Port to libsoup3 bb27723f0bea02016036573524570001f1b7a443 geniuspaste: Remove use of deprecated GTK API 1c3ca837f59d98f1b4d26ef69a102049fe6eb391 geniuspaste: Enable HTTPS for paste.debian.net

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 7758920773f9918f1a672064434122ea674e5a79 Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/ab31775cbaa1fc401d5c7c0aa8231726d0729f4e..7758920773f9918f1a672064434122ea674e5a79 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 Indeed,

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n pushed 2 commits. bdd4db94934400b447c8a7d5de2a7c5cd3740bf0 geniuspaste: Enable HTTPS for paste.debian.net ab31775cbaa1fc401d5c7c0aa8231726d0729f4e Update CI for libsoup3 -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. LGTM, indeed the ABOUTs don't seem useful, and for numberedbookmarks it's an old version of README including typos that have been corrected. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +* Wizard to create new LaTeX documents in a fast and easy way + with a bunch of templates available + +* A front end for add labels ``\label{}`` and references ``\ref{}`` and + ``\pageref{}`` with getting suggestion from aux file of document + +*

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Colomban Wendling via Github-comments
> The bad news is that it doesn't work too. > I have added it, closed geany, reopen and all is the same. WFM, looks like that: Default: ![default](https://github.com/geany/geany/assets/793526/73d4a2cd-639d-46bf-8ff9-dd28c7e37a32) Adding `lexer.bash.styling.inside.string=1`

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Colomban Wendling via Github-comments
> I "think" it will work. > In detail this is, when querying https://geany.org/ I get an error: `GET > request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […] > > If I change the URL to query to https://httpbin.org/anything/version, the > HTTP request works fine and I get the expected

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Colomban Wendling via Github-comments
Try adding this in *filetypes.sh* (you can open it from *Tools → Configuration files → Filetypes configuration files → Scripting languages*): ```ini [lexer_properties] lexer.bash.styling.inside.string=1 lexer.bash.styling.inside.backticks=1 lexer.bash.styling.inside.parameter=1

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Colomban Wendling via Github-comments
@elextr you never know what the future of the web holds, but I highly doubt a security issue would ruin the current API. A new feature maybe, but well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081379570 You are

[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)

2024-04-28 Thread Colomban Wendling via Github-comments
That's not how things work here, the identifier id either recognized as such anf given a separate style (which we might or might not draw the same as a string), or it's not recognized and thus is considered a string. Which language do you have issue with? -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Colomban Wendling via Github-comments
I'll look into this Soon™, but the JS changes might have an issue (might be what you see, might be something else), see [this](https://github.com/universal-ctags/ctags/commit/6d85089456ed215ce6b6a673744ae42ccc5e0e99#diff-eb186936271438240da764e7ccf36ffa04ba8f0a6e1eabd1c69400164ae9f608R1) which

[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)

2024-04-27 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGBI, makes sense. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#pullrequestreview-2026699270 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-27 Thread Colomban Wendling via Github-comments
Merged #1295 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#event-12632694851 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-27 Thread Colomban Wendling via Github-comments
> Yeah, but then its back to four plugins to synchronise on > libsoup3/webkit2gtk-4.1. Yet, does it currently matter? I mean, the code is ready (but for more testing maybe) for all four now, porting isn't what is holding back anymore. Sure the question might arise again for a future libsoup4

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread Colomban Wendling via Github-comments
> It didn't appear to do either. No popup or message in status or msgwin on > success. I don't recall seeing anything but some usual gtk errors in terminal. Weird… unless you have a libsoup2 plugin loaded? IIUC nothing will stop you from doing so, but things will just perform bizarrely (or

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-04-27 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. LGTM, see inline comments. Apart from that, I was kind of disappointed that the "goto file" only lists Geany open documents rather than the project's documents -- maybe you'd like to add that? Also, I hoped to be able to go to a specific file's

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-27 Thread Colomban Wendling via Github-comments
@elextr hence checking if it does :) But if it's a concern, just keep using the libsoup implementation, it *ought* to work with HTTP as that's the whole point of that library :smiley: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread Colomban Wendling via Github-comments
> Do Debian and Ubuntu even bother rebuilding packages for old releases? No, the dependency only matter for users of older releases that would like to build a newer Geany by themselves. And Debian was just an example, sometimes we check what even more slow-paced distro do, like RHEL or so.

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread Colomban Wendling via Github-comments
> After testing the plugin, I think it should be dropped. Most of the pastebins > don't work. Indeed only 3 did in my tests (Geany's, Debian's and Sprunge) > There's no confirmation of what it's sending. […] Once data is sent, there's > no way to delete it, which is a security risk if

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-27 Thread Colomban Wendling via Github-comments
@techee any chance you could check whether gvfs works with HTTP(S) under macos? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080478237 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread Colomban Wendling via Github-comments
Thanks for review & testing! BTW, a few things things to note: * libsoup3 is fairly recent (2021-09-18), and e.g. not available in Debian before Bookworm (12, current stable) * I probably won't make it possible to support both libsoup2 and libsoup3, because the changes are too complex which

[Github-comments] [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-26 Thread Colomban Wendling via Github-comments
Many pastebins dont work, but its not new to the changes here… CC @xiota @jbicha You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1342 -- Commit Summary -- * geniuspaste: Port to libsoup3 * geniuspaste: Remove use of deprecated

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-26 Thread Colomban Wendling via Github-comments
@xiota I don't think we need to explore a *different* additional HTTP library; either we only use what's already part of the general GTK stack, or using libsoup which is also a direct or indirect dependency of 3 other plugins is fine. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-26 Thread Colomban Wendling via Github-comments
See #1340 if wanted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079550087 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-26 Thread Colomban Wendling via Github-comments
Same as #1336 but using GIO instead of libsoup. If wanted? CC @elextr @xiota @frlan. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1340 -- Commit Summary -- * updatechecker: Port to libsoup3 * updatechecker: Dont leak the

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-26 Thread Colomban Wendling via Github-comments
Note that writing an async version of the feature, while reasonably easy, is a little bit more work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079476011 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-26 Thread Colomban Wendling via Github-comments
hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR because it's HTTP, or depend on a GVFS backend for HTTP? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079474204 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-26 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self, g_free (real_uri); } +gboolean +gwh_browser_set_uri_from_document (GwhBrowser*self, + GeanyDocument *doc) +{ + gchar *uri; + + /* document must

[Github-comments] Re: [geany/geany] [FR] Use XDG desktop portal filechooser instead GTK on Linux/BSD (Issue #3458)

2024-04-26 Thread Colomban Wendling via Github-comments
The main issue with native dialogs/portals, is that they have reduced feature set, see e.g. [GtkFileChooserNative](https://docs.gtk.org/gtk3/class.FileChooserNative.html). And some might be a problematic trade-off for our use cases. Also note that I can't read anything in the link above about

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-26 Thread Colomban Wendling via Github-comments
Yeah I guess using GIO directly for this kind of super simple GET would make sense Indeed. I also think that gvfs will indeed be part of all reasonable GIO installations, but I could be wrong. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread Colomban Wendling via Github-comments
And voila, I got plagued with another round of cleanups :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2078136827 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself,

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread Colomban Wendling via Github-comments
@b4n pushed 5 commits. 52ab3ebefc8fdf805b081bac74efaec442c82529 webhelper: Use modern GObject private data 9f420e09447cc2f8a57e4880dfa99bebc67734e7 webhelper: Replace use of deprecated GtkVBox with GtkBox 3edea3f891cdbe241d63d2b4b37ef4c5eea035c4 webhelper: Remove use of deprecated

[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)

2024-04-25 Thread Colomban Wendling via Github-comments
Merged #1335 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#event-12612366928 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself,

[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)

2024-04-25 Thread Colomban Wendling via Github-comments
Merged #1232 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#event-12607573353 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] When the "Markdown" plug-in is enabled, opening a markdown file containing "@@markdown@@" always freezes. (#936)

2024-04-25 Thread Colomban Wendling via Github-comments
Closed #936 as completed via #1232. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/936#event-12607573756 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)

2024-04-25 Thread Colomban Wendling via Github-comments
Oopsie, I didn't check the OP, only the commit message :confused: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2077050321 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself,

  1   2   3   4   5   6   7   >