[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-21 Thread Jiří Techet via Github-comments
If you are planning to continue working on this PR, there's one catch. Because of https://github.com/geany/geany-plugins/commit/33984abc9bd24bbf03db3ac517eb45ca2c7e6b7f you have to first move the cursor on the visible line before performing a fold - otherwise folding won't work because the

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-21 Thread Jiří Techet via Github-comments
Closed #1326. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#event-12885969899 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-21 Thread Jiří Techet via Github-comments
Closing this PR as #1338 was merged. Having SCN_MARGINCLICK handled would however be worth adding as a separate PR. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#issuecomment-2123515548 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-21 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -306,6 +306,14 @@ gboolean vi_notify_sci(SCNotification *nt) } } + if (nt->nmhdr.code == SCN_MARGINCLICK) { I've just merged #1338 which functionality-wise covers most of this PR but doesn't contain the

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-21 Thread Jiří Techet via Github-comments
Merged #1338 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#event-12885918807 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 522b79dc7b1f25576e4bf44277f5e49bfa46cd9d vimode: Take into account folded lines when moving cursor 33984abc9bd24bbf03db3ac517eb45ca2c7e6b7f vimode: Ensure that the line with the cursor is expanded after performing a command -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-21 Thread Jiří Techet via Github-comments
Also prefix the commit message with `vimode:` so it's clear what plugin the commit modifies. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2123481464 You are receiving this because you are subscribed to this thread. Message

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-21 Thread Jiří Techet via Github-comments
Looks good, thanks! One last request - would you squash all the commits into one? I'll merge it afterwards. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2123477613 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-21 Thread Jiří Techet via Github-comments
@techee approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#pullrequestreview-2069658017 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-21 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 7794a3f9a6f2e18293ddc78993a00e54b2afdafc Fix compilation with the combined geany-lsp repo -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/fe72e17aa9cf198a15df0208e6d8dff0da718a16..7794a3f9a6f2e18293ddc78993a00e54b2afdafc You are receiving

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fe72e17aa9cf198a15df0208e6d8dff0da718a16 Implement non-standard clangd LSP extension textDocument/switchSourceHeader -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 4e6be72aa9980fac5e51d7456e5177de3e7fc22f Add some sanity checks d9668e7a8fee51bf99109e740b102328467ba299 Fix some more leaks -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. cf1c68e80508f5f4fe1eb33c4e932ce49e7d8144 Fix memory leak -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/2a9118b60c64283701a641764284b32915f1fd40..cf1c68e80508f5f4fe1eb33c4e932ce49e7d8144 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-20 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 2a9118b60c64283701a641764284b32915f1fd40 Allow disabling diagnostic messages only for some files -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/eb5a7491b713105d6eb211f90f4d745cc14cc1ae..2a9118b60c64283701a641764284b32915f1fd40 You are

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-20 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. aa62690507cbbc5d194d739097c02d0ad4305be0 Force-kill LSP server if normal shutdown unsuccessful eb5a7491b713105d6eb211f90f4d745cc14cc1ae Unref should close the stream so remove the todo comment -- View it on GitHub:

[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)

2024-05-19 Thread Jiří Techet via Github-comments
> Python does this too, every assignment is a new declaration and shows in the > sidebar Yes, but this happens only for the global variables, not variables inside functions. Since the matlab parser is just a dumb regex parser, it doesn't know whether it's inside a function so it shows all

[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)

2024-05-19 Thread Jiří Techet via Github-comments
Just thinking, in https://github.com/geany/geany/pull/3859 I mapped matlab variables to `tm_tag_variable_t` so they are displayed in the sidebar but maybe the result is a little too verbose. Especially since it generates a tag for every variable assignment - I just tried it with some random

[Github-comments] [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)

2024-05-19 Thread Jiří Techet via Github-comments
This PR contains some ctags updates which were made upstream as discussed in https://github.com/geany/geany/pull/3859. Apart from that I noticed that the `update-ctags.py` script didnt copy the updated libreadtags library so I modified it to do so and as a result this PR also contains updated

[Github-comments] Re: [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)

2024-05-19 Thread Jiří Techet via Github-comments
Merged #1348 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1348#event-12858259774 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. df2a325fd0d0aeaff1bde339a1bf36c1ac6d4053 Prefer autocomplete when both autocomplete and calltips are available -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > return; - /* see cmd_goto_up() for explanation */ - one_above = p->line + num - 1; - one_above = one_above < last_line ? one_above : last_line - 1; - pos = SSM(p->sci, SCI_GETLINEENDPOSITION, one_above, 0); -

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 7ae19de41e7d45c1c97a96b06ade67d80edf26a1 Don't update cursor position when going down on the last line -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1338/files/fa7025ba9d58fb4680fb47e13bd5c05c6f1f1059..7ae19de41e7d45c1c97a96b06ade67d80edf26a1 You

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > /* Calling SCI_LINEUP/SCI_LINEDOWN in a loop for num lines leads to > visible * slow scrolling. On the other hand, SCI_LINEUP preserves the value of * SCI_CHOOSECARETX which we cannot read directly from Scintilla and which

[Github-comments] Re: [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)

2024-05-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -109,9 +111,10 @@ Get the code from:: Ideas, questions, patches and bug reports = -Please direct all questions, bug reports and patches to the plugin author using the -email address listed below or to the

[Github-comments] Re: [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)

2024-05-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -11,7 +11,9 @@ GeanyCtags adds a simple support for generating and > querying ctags files for a G project. It requires that the ctags command is installed in a system path. On unix systems, distributions usually provide the ctags package; on

[Github-comments] Re: [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)

2024-05-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. de9a25bb9e7aff4c7f89677120df1f9d80e419cd geanyctags: Add information about universal-ctags -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1348/files/d479bae66f24240964aa22bc6c70c4c79be9f5b3..de9a25bb9e7aff4c7f89677120df1f9d80e419cd You are receiving

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-18 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. > @@ -219,3 +220,12 @@ void goto_nonempty(ScintillaObject *sci, gint line, > gboolean scroll) pos = NEXT(sci, pos); SET_POS(sci, pos, scroll); } + + +gboolean is_start_of_line(ScintillaObject *sci, gint pos) This

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-16 Thread Jiří Techet via Github-comments
Great, I think I'll just wait for the next ctags tag and will use that one. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2115180072 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-15 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + +void start_undo(CmdContext *c) +{ + c->undo_pos = -1; +} + +void update_undo(CmdContext *c, gint pos) +{ + c->undo_pos = pos; +} + +gboolean end_undo(CmdContext *c) +{ + ScintillaObject *sci = c->sci; + + if (c->undo_pos !=

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-15 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good to me apart from the few formal comments above and the possible `goto_nonempty()` use. Would you incorporate those changes into this PR? > @@ -162,14 +163,14 @@ void cmd_del_word_left(CmdContext *c, CmdParams *p) void

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-14 Thread Jiří Techet via Github-comments
> @techee I just added 2 more commits -- feel free to comment and reject them :) Yes, that's what I'm gonna do, just to enjoy the power :-). Anyway, great, I've merged this PR. If you plan to do some more ctags changes, just ping me when you are done and the changes are merged upstream and I'll

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-14 Thread Jiří Techet via Github-comments
Merged #3859 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#event-12800733048 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-12 Thread Jiří Techet via Github-comments
Alright, I made the suggested changes: 1. I made GtkFileChooserNative configurable, by default enabled on macOS and Windows, disabled on Linux. 2. I went through all GtkFileChooser occurrences in Geany and added the native variant 3. Not sure if intentional or if it's some left-over but

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-12 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 2d8d4f2edacbfc82743a4d020d9c22bc6526b92b Use GTK_RESPONSE_ACCEPT which is also used by GtkFileChooserNative -- View it on GitHub: https://github.com/geany/geany/pull/3861/files/4dff3767b9f80719dab3d1a83443be52cd377fa8..2d8d4f2edacbfc82743a4d020d9c22bc6526b92b You are

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-12 Thread Jiří Techet via Github-comments
@techee pushed 3 commits. 91fb8850281979356cdc38b5ea2b97e1b7132461 Use GtkFileChooserNative depending on user configuration ee8f885acf554c494b00f0f3a80a3c17676838ca Remove usage of windows-native dialogs from ui_utils.c and win32.c/h 4dff3767b9f80719dab3d1a83443be52cd377fa8 Use

[Github-comments] Re: [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-12 Thread Jiří Techet via Github-comments
Yes, but I think (3) is really rare - closing documents is typically done by users; if plugins do that, it would be very unexpected. That doesn't mean there couldn't be some races like that when a user closes a document, opens another, and only after that an asynchronous operation with a doc

[Github-comments] Re: [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-12 Thread Jiří Techet via Github-comments
@elextr Thanks for the answer. > Document objects are never freed, so you will never get an invalid pointer, > so thats one less worry. So no need to check if its in the document array, it > will be. Alright, that's the piece of information I was missing - I never actually looked at the

[Github-comments] Re: [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-12 Thread Jiří Techet via Github-comments
Closed #3872 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3872#event-12778480824 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-11 Thread Jiří Techet via Github-comments
While looking at some Geany code, I noticed that `DOC_VALID()` is used in some callbacks where it's supposed to check whether the document was closed in the meantime: https://github.com/geany/geany/blob/11b4a00a3020b1c9ace3d3ae65aa5ec7d5ff84e0/src/document.c#L1282-L1292 Unless I'm missing

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. eaa76c7e6eef919509857b9776e5338fa53c11ce Create lsp_utils_doc_is_valid() helper function 731a0f3060837a26afc183e57da1897dff366795 Perform expensive operations in idle callback after some timeout -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 884c520b0781945d67603a036215e62f7c3d3c21 Fix cppcheck warnings -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/a0e0fded5093e77d9b73cce0f304e91b2fc30f34..884c520b0781945d67603a036215e62f7c3d3c21 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] vimode: line operations cause scrolling and escape doesn't work when numlock enabled (Issue #1136)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #1136 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1136#event-12776604957 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode is Broken in Ubuntu 22.04 (Issue #1174)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #1174 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1174#event-12776603532 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add "document-before-save-as" signal (PR #3572)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 0dfd4655a98778c74ba2f3c2de135627acb84e01 Add "document-before-save-as" signal -- View it on GitHub: https://github.com/geany/geany/pull/3572/files/eab9cc19ab8280f2eef24675c621fe78352595af..0dfd4655a98778c74ba2f3c2de135627acb84e01 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a0e0fded5093e77d9b73cce0f304e91b2fc30f34 Drop the usage of session-opening signal -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/749ac83c76459735f6d75efb3da53472f0e28c7c..a0e0fded5093e77d9b73cce0f304e91b2fc30f34 You are receiving this

[Github-comments] Re: [geany/geany] Add "session-opening" signal emitted when session opening starts/stops (PR #3707)

2024-05-11 Thread Jiří Techet via Github-comments
Closing in favor of https://github.com/geany/geany/pull/3870. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3707#issuecomment-2105840059 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add "session-opening" signal emitted when session opening starts/stops (PR #3707)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #3707. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3707#event-12776567981 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix emission of document-activate signal and various related GUI glitches (PR #3870)

2024-05-11 Thread Jiří Techet via Github-comments
@kugel- Does the patch look OK to you? I restored the signal emission inside the `document_show_tab_idle()` callback which is the function that gets called when opening session files where this behavior is desired. -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Fix emission of document-activate signal and various related GUI glitches (PR #3870)

2024-05-11 Thread Jiří Techet via Github-comments
PR https://github.com/geany/geany/pull/3267 removed the special handling of the situation when no tab change happens after setting an active document after session load. This happens in the situation where 1. Theres just a single document 2. Depending on the tab opening logic, the active tab

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. acb4678486110d90dd46eb6dea336f5907cafb14 Map freepascal namespaces and add a unit test for them -- View it on GitHub: https://github.com/geany/geany/pull/3859/files/de9ea30900a3c602e89b39666b22029abc9a839a..acb4678486110d90dd46eb6dea336f5907cafb14 You are receiving

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
>>Can do that. Should it be part of this PR or a separate one after this one is >>merged? >Whichever you prefer. I'd have said this one given it'll introduce yet another >set of changes that are probably best diffed from current master, but I don't >really mind either way in practice, so if

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -557,6 +562,7 @@ static TMParserMapEntry map_FREEBASIC[] = { {'t', tm_tag_struct_t}, // type {'v', tm_tag_variable_t}, // variable {'g', tm_tag_externvar_t}, // enum + {'n', tm_tag_undef_t}, // namespace

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > +static TMParserMapGroup group_LDSCRIPT[] = { +}; I added the dummy one in the latest commit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#discussion_r1597244631 You are receiving this because you are

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 0b52e79c93942d115d94a2df6015a1c704fb0ad6 Add dummy TMParserMapGroup for ldscript to avoid warnings de9ea30900a3c602e89b39666b22029abc9a839a Map freepascal namespaces and add a unit test for them -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-05-10 Thread Jiří Techet via Github-comments
@frlan @b4n @eht16 The major things are "finished" from my perspective. If I missed something that needs to be done regarding geany-plugins integration, please let me know. The word "finished" above means the plugin works but soft-depends on some things which are not in Geany yet, it's: *

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-05-10 Thread Jiří Techet via Github-comments
@techee pushed 8 commits. 66e82da94f5b3a718a383f2bee80a7ede3137a50 Make sure menu gets updated whhen closing the last document ced8d1717dbc6db861f3824125897774c885d70b Fix semantic token flickering when LSP server sends incorrect delta value 17b29d78efe1a41309130ab5f2da24265bb86554 Some

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-05-10 Thread Jiří Techet via Github-comments
@b4n Thanks for having a look at the javascript parser. > we should probabmy use a newer snapshot (some parser changes, e.g. related to > class vs. object vs. variable are gonna lead to additional test result > changes, which are admittedly better in the newer version, and I'm not sure > it's

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-08 Thread Jiří Techet via Github-comments
But this isn't really what vim does, is it? Try the following with this patch: 1. Delete a line in the middle of a file. 2. Scroll to the top of the file so you have the cursor e.g. on the first line 3. Press `u` The undo happens but your cursor is still on the first line instead of being at the

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-08 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good except for the minor comments below. I was actually thinking about not doing this at all because it doesn't cover all fold/unfold situations like e.g. using Geany's keybindings for folding but the patch is simple and better than

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-08 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -40,42 +40,53 @@ void cmd_goto_right(CmdContext *c, CmdParams *p) SET_POS(p->sci, pos, TRUE); } +static gint doc_line_from_visible_delta(CmdParams *p, gint line, gint delta, gint *previous) +{ + gint step = delta < 0 ? -1 : 1; +

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-08 Thread Jiří Techet via Github-comments
> After read the https://sourceforge.net/p/scintilla/bugs/2438/ report, I think > the best way to automatically set the cursor position on the visible line is > surely to track the SCN_MARGINCLICK event. I did some modification to handle > this with the commit >

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-08 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fa7025ba9d58fb4680fb47e13bd5c05c6f1f1059 Fix motion problems with line wrapping -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1338/files/aeaaf3a895e75f44d4dab7d6211bb1bd93b69648..fa7025ba9d58fb4680fb47e13bd5c05c6f1f1059 You are receiving this

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
> Apart from that, I was kind of disappointed that the "goto file" only lists > Geany open documents rather than the project's documents -- maybe you'd like > to add that? Done in the last commit - open files are sorted before project files and also non-open project files don't have any icon

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + + if (!symbols) + return ret; + + tf_strv = g_strsplit_set(filter, " ", -1); + + for (i = 0; i < symbols->len && j < 100; i++) + { + PrjorgGotoSymbol *symbol = symbols->pdata[i]; +

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + + case GDK_KEY_Return: + case GDK_KEY_KP_Enter: + case GDK_KEY_ISO_Enter: + tree_view_activate_focused_row(GTK_TREE_VIEW(panel_data.tree_view)); + return TRUE; + +

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , ); + } + return gtk_icon_theme_load_icon(icon_theme, icon_name, x, 0, NULL); +} + + +static GdkPixbuf *get_icon_pixbuf(gint icon) +{ + if (!geany_icons[_ICON_CLASS].pixbuf) +

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + } + pos = new_pos; + } + end_pos = pos; + + if (start_pos == end_pos) + return NULL; + + return sci_get_contents_range(sci, start_pos, end_pos); +} + + +static void goto_panel_query(const

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + GPtrArray *arr = g_ptr_array_new_full(0, > (GDestroyNotify)prjorg_goto_symbol_free); + gint lineno = atoi(line_str); + gint linenum = sci_get_line_count(doc->editor->sci); + guint i; + + for (i = 0; i < 4; i++) + { +

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-05-07 Thread Jiří Techet via Github-comments
@techee pushed 6 commits. 6a541d0ab820d830bd0a49c10681c67a9153200d Add translator comments to file navigation strings 4638f25f4ff3dd4cc9e6d270ce7e5168eb20062d Avoid possible NULL pointer dereferences and fix some related problems 290c9a36a08fdffcf587822ee593dc18e6c62aa1 Formatting

[Github-comments] [geany/geany-plugins] geanyctags, projectorganizer, vimode: Some README and URL updates (PR #1348)

2024-05-05 Thread Jiří Techet via Github-comments
1. Suggest using Github for reporting bugs and pull requests instead of sending them by email. 2. Use https:// instead of http:// 3. Mention universal-ctags as a maintained version of ctags in geanyctags README You can view, comment on, or merge this pull request online at:

[Github-comments] Re: [geany/geany] Wrong filename in titlebar after launch (Issue #3684)

2024-05-05 Thread Jiří Techet via Github-comments
Another victim of this problem is the git-changebar plugin (and possibly others) that expects that "document-activate" is delivered also when a single tab is open. The result is that when no document is open and you open some document with changes against the committed state, git-changebar

[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-05 Thread Jiří Techet via Github-comments
> So the question goes back to, since the proposed changes are to ctags will > upstream accept the changes so we don't have to keep a patch to ctags? See the first answer here: https://github.com/geany/geany/pull/3865#issuecomment-2094775899 :-). The file `tm_ctags.c` is our source that hides

[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-05 Thread Jiří Techet via Github-comments
> Sorry, I wasn't clear, many of the custom filetypes have no parser and don't > crash. So what do they set the tag_parser to? The crash only happened because Geany was trying to load the global tags file for Python (`data/tags/std.py.tags`) and it was Python for which I set `tag_parser=`.

[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-05 Thread Jiří Techet via Github-comments
> For most languages the parser is hard-coded using the table here: ... > I think only a few non-builtin filetypes like JSON use the tag_parser option > to specify the parser by name. But if the name is invalid or not provided, we > shouldn't crash which this PR tries to do. And also the

[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-05 Thread Jiří Techet via Github-comments
> What does upstream say about the changes? The change is in our sources, not the upstream ones. > What is the setting set to if the tag_parser= is not present? For most languages the parser is hard-coded using the table here:

[Github-comments] [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)

2024-05-04 Thread Jiří Techet via Github-comments
This can happen when in the filetype configuration we set ```ini [settings] tag_parser= ``` This then leads to this crash in the ctags code: ``` #0 countKinds (kcb=0x0) at main/kind.c:230 #1 0xf7e802c8 in countLanguageKinds (language=language@entry=-2) at main/parse.c:300 #2

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-05-04 Thread Jiří Techet via Github-comments
@techee pushed 6 commits. b3df23d328f504752688a6fb5c45beaa1447f1ab Add some GeanyDocument validity checks 4229993c86319ba4479dd289a2b0ee7ac0f4cf35 Make sure cached diagnostics and semantic tokens are cleared when document closed fbf54ff4305b67787fc6f377d0576ab62836 Make semantic tokens a

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-05-03 Thread Jiří Techet via Github-comments
@techee pushed 10 commits. 92d117dc42acc8da0ff9b07f5eef99413ea74aea Add lsp to README 44bda83eb5dbca8c71c0203afe9ebc174c625083 Properly document the config file and rename 2 config options 0c486a569784822f275b4eac1806a7d510dcfc66 Fix location of global config file when using geany-plugins

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-01 Thread Jiří Techet via Github-comments
> To me it seems fine to use those dialogs since it seems to work well and if > it goes the same for "Save As" and maybe "Open Folder". Making it > configurable is a good idea, I don't mind about the default. Good to hear. I'll try to prepare the patches (after finishing the boring task of

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Jiří Techet via Github-comments
Regarding macOS, the way gio behaves I expect it will never work so better to use libsoup (2 or 3, both are provided by gtk-osx). I can try again if I manage to get tls work with libsoup - to be honest, I didn't try too hard last time because I don't use neither of the plugins. -- Reply to

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-30 Thread Jiří Techet via Github-comments
> I didn't even know it was possible to rename a file using the Open dialog - > how does one do that? OK, I guess you meant the Save as dialog where the Rename button is the added widget, which, indeed, won't be present in the native dialogs. -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-30 Thread Jiří Techet via Github-comments
> Didn't we have native dialogs a while ago, at least on Windows? So this > brings that back, basically? Yes, but I think the problem wasn't the dialogs themselves (apart from the fact they were some "old" open dialogs), but rather the fact they were implemented using Windows API that nobody

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-30 Thread Jiří Techet via Github-comments
> @techee you said in the OP "where the GTK dialogs don't offer the best user > experience.". Can you expand on that and why " using native dialogs under > Windows and macOS is more important IMO."? It's pretty much this: https://github.com/geany/geany-osx/issues/14#issuecomment-1988461271.

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-29 Thread Jiří Techet via Github-comments
File filters work both on Windows and macOS: ![Screenshot 2024-04-30 001617](https://github.com/geany/geany/assets/713965/a457b3df-a2fe-4bc3-b8e8-de97402391a0) https://github.com/geany/geany/assets/713965/03616e82-594b-4921-be10-ce999eb38167;> -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-29 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 2bf55c0d6657fa0a80ffd573316c47308d9ba581 Use filters with GtkFileChooserNative -- View it on GitHub: https://github.com/geany/geany/pull/3861/files/d1d16fa03df309916acf577a2df2a97cf7d419d9..2bf55c0d6657fa0a80ffd573316c47308d9ba581 You are receiving this because you are

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-29 Thread Jiří Techet via Github-comments
> No need to build yourself, a full installer with the changes can be downloaded from the CI builds: https://github.com/geany/geany/actions/runs/8869590862 Nice, I didn't know about that. The screenshot below comes from Windows 11, Geany on the left, Notepad++ on the right. The only difference

[Github-comments] Re: [geany/geany] Wrong filename in titlebar after launch (Issue #3684)

2024-04-28 Thread Jiří Techet via Github-comments
I've bisected this to https://github.com/geany/geany/pull/3267. The original code contained the `switch_to_session_page()` function which emitted the `switch-page` signal even in the case when the right tab was already selected (so no real switch happened) which then lead to correct

[Github-comments] [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-28 Thread Jiří Techet via Github-comments
This is an experiment to use GtkFileChooserNative on Windows and macOS to address issues like https://github.com/geany/geany-osx/issues/14 where the GTK dialogs dont offer the best user experience. I kept using GtkFileChooser on Linux because it adds extra widgets to the dialog like file

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> To confirm, the first is Windows? The second macOS? Both with GIO? Only speaking for the macOS part - yes, the second message is on macOS with GIO. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081536322 You are receiving

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
So I get ``` 17:47:11.712578: Updatechecker MESSAGE : Checking for updates (querying URL "https://geany.org/service/version/;) 17:47:14.085164: Updatechecker WARNING : Unable to perform version check: Operation not supported ``` in debug messages and also the corresponding popup error :-(. --

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> What do you mean, with GIO, with libsoup, with anything? If it doesn't work > neither on macos not Windows, it starts to feel like nobody is gonna be using > it  Yeah, it was with libsoup which, when using gtk-osx for building dependencies, depends on gnutls:

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-04-28 Thread Jiří Techet via Github-comments
@b4n Thanks for having a look at it - I'll address the changes you suggested. > Apart from that, I was kind of disappointed that the "goto file" only lists > Geany open documents rather than the project's documents -- maybe you'd like > to add that? Definitely makes sense for projectorganizer

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> @techee any chance you could check whether gvfs works with HTTP(S) under > macos? The thing is that I didn't even manage to get tls running correctly (it compiled but https didn't work afterwards, probably some configuration issue) so the updatechecker plugin isn't part of the macOS release.

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
I also added a commit updating the matlab parser to the upstream regex-based one. I'd like to avoid the situation that we have to maintain our (non-regex) version of the parser like in: https://github.com/geany/geany/pull/3358 https://github.com/geany/geany/pull/3563 Also, the kinds generated

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. aa0c796b5c1e6a1b6a4050086309a5864819eca3 Switch to uctags regex-based matlab parser d515bce2167fd8623c83dc51e38562a4b822d019 Use repoinfo.h with the used tag version -- View it on GitHub:

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
@techee pushed 8 commits. 7943b7d9ec47805caac6b071ca13da4a73c14326 Add ldscript parser f21e1de08482a73fdc41694e7dbc81c9735a29dc Update parser kind mappings e00a2684d34446ae7426ee8e00349f8d3595e2fc Map title/subtitle of the rst parser cdf1aa1fbc7ba8d93dc3373a0c8600a80a4c03be Map defines to

[Github-comments] [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
There were mostly expected problems like new source files that had to be added, rename of `perl6.c` to `raku.c`, update of kind mappings, etc. The only unexpected thing is the behavior of the javascript parser - this is from the javascript commit message: There are lots of differences because

[Github-comments] [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-04-26 Thread Jiří Techet via Github-comments
This feature allows quick navigation do document/workspace symbols based on their names, open files, and line numbers. The panels code is mostly stolen from the LSP plugin which in turn stole it from the Colomban Wendlings Commander plugin. You can view, comment on, or merge this pull request

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-04-25 Thread Jiří Techet via Github-comments
Looks good in general, but I think folding should work when the cursor is anywhere in the block, not just on the fold point (vim seems to work this way). I played with it a little and came up with something like this: ```C static gint prepare_fold(CmdParams *p) { /* foldparent of the

  1   2   3   4   5   6   7   8   >