Hi Linus,
please pull the latest changes for the kernel livepatching from
git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching
tags/livepatching-for-6.10
==
- Use more informative names for the livepatch transition states.
On Tue 2024-05-07 13:01:11, zhangwar...@gmail.com wrote:
> From: Wardenjohn
>
> The original macros of KLP_* is about the state of the transition.
> Rename macros of KLP_* to KLP_TRANSITION_* to fix the confusing
> description of klp transition state.
>
> Signed-off-by: Wardenjohn
JFYI, the
On Mon 2024-05-06 19:35:22, Josh Poimboeuf wrote:
> On Mon, May 06, 2024 at 01:32:19PM +0200, Petr Mladek wrote:
> > Also it would require adding an API to remove the sysfs files from the
> > module_exit callback.
>
> Could the sysfs removal be triggered from klp_modul
On Thu 2024-05-09 13:53:17, Yafang Shao wrote:
> On Thu, May 9, 2024 at 1:20 PM Josh Poimboeuf wrote:
> >
> > On Thu, May 09, 2024 at 10:17:43AM +0800, Yafang Shao wrote:
> > > On Wed, May 8, 2024 at 3:03 PM Josh Poimboeuf wrote:
> > > >
> > > > On Wed, May 08, 2024 at 02:01:29PM +0800, Yafang
rdenjohn
Looks good to me:
Reviewed-by: Petr Mladek
Tested-by: Petr Mladek
Best Regards,
Petr
On Mon 2024-04-29 23:06:54, Justin Stitt wrote:
> Cleanup some deprecated uses of strncpy() and strcpy() [1].
>
> There doesn't seem to be any bugs with the current code but the
> readability of this code could benefit from a quick makeover while
> removing some deprecated stuff as a benefit.
>
On Sun 2024-04-07 11:57:30, Yafang Shao wrote:
> In our production environment, upon loading a new atomic replace livepatch,
> we encountered an issue where the kernel module of the old livepatch
> remained, despite being replaced by the new one. This issue can be
> reproduced using the following
On Sun 2024-04-07 11:57:29, Yafang Shao wrote:
> Introduce a new helper function, delete_module(), designed to delete kernel
> modules from locations outside of the `kernel/module` directory.
>
> No functional change.
>
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -695,12
On Fri 2024-05-03 14:14:34, Josh Poimboeuf wrote:
> On Sun, Apr 07, 2024 at 11:57:30AM +0800, Yafang Shao wrote:
> > $ ls /sys/kernel/livepatch/
> > livepatch_test_1 livepatch_test_0 was replaced
> >
> > $ cat /sys/kernel/livepatch/livepatch_test_1/enabled
> > 1
> >
On Mon 2024-05-06 10:04:26, zhang warden wrote:
>
>
> > On May 6, 2024, at 05:00, Josh Poimboeuf wrote:
> >
> > On Mon, Apr 29, 2024 at 03:26:28PM +0800, zhangwar...@gmail.com wrote:
> >> From: Wardenjohn
> >>
> >> livepatch.h use KLP_UNDEFINED\KLP_UNPATCHED\KLP_PATCHED for klp transition
>
On Thu 2024-05-02 07:06:21, Christophe JAILLET wrote:
> Le 02/05/2024 à 01:18, Justin Stitt a écrit :
> > On Wed, May 1, 2024 at 2:39 PM Christophe JAILLET
> > wrote:
> > > Hi,
> > >
> > > Nit: The { } around each branch can now also be removed.
> >
> > There was one line before and there's one
ed.html#strncpy-on-nul-terminated-strings
> [1]
> Link: https://github.com/KSPP/linux/issues/90 [2]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
> [3]
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt
Nice improvements. Looks fine.
Reviewed-by: Petr Mladek
Best Regards,
Petr
triggered when exiting the emergency section.
> This allows the full message block to be stored as
> quickly as possible in the ringbuffer.
>
> Signed-off-by: John Ogness
Seems to be on the right location:
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Tue 2024-04-02 09:52:31, Joe Lawrence wrote:
> On Tue, Apr 02, 2024 at 11:09:54AM +0800, zhangwar...@gmail.com wrote:
> > From: Wardenjohn
> >
> > In livepatch, using KLP_UNDEFINED is seems to be confused.
> > When kernel is ready, livepatch is ready too, which state is
> > idle but not
On Sun 2024-03-31 21:38:39, Yafang Shao wrote:
> Enhance the functionality of kpatch to automatically remove the associated
> module when replacing an old livepatch with a new one. This ensures that no
> leftover modules remain in the system. For instance:
I like this feature. I would suggest to
On Wed 2024-03-27 15:16:25, Paul Moore wrote:
> On Wed, Mar 27, 2024 at 2:39 PM syzbot
> wrote:
> >
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit:fe46a7dd189e Merge tag 'sound-6.9-rc1' of git://git.kernel..
> > git tree: upstream
> > console output:
iggered when exiting the
> emergency section.
>
> Signed-off-by: John Ogness
Reviewed-by: Petr Mladek
I was just curious about one thing. But it seems to work well.
print_other_cpu_stall() print backtraces on other CPUs via NMI.
The other CPUs would not see the emergency con
On Wed 2024-02-28 09:32:37, Rasmus Villemoes wrote:
> On 27/02/2024 19.32, Ville Syrjälä wrote:
> > On Tue, Feb 27, 2024 at 10:38:10AM +0100, Rasmus Villemoes wrote:
> >> On 26/02/2024 15.57, Jani Nikula wrote:
> So if we really want to go down this road, I think it should be
> something like
On Tue 2024-01-30 15:53:36, Lee Jones wrote:
> On Tue, 30 Jan 2024, Rasmus Villemoes wrote:
> > On 30/01/2024 16.07, Lee Jones wrote:
> > > On Mon, 29 Jan 2024, Lee Jones wrote:
> > >> On Mon, 29 Jan 2024, David Laight wrote:
> > snprintf() does this and has been proven to cause
On Fri 2024-02-02 09:40:05, Paul E. McKenney wrote:
> On Fri, Feb 02, 2024 at 06:56:28AM -1000, Tejun Heo wrote:
> > Hello,
> >
> > On Fri, Feb 02, 2024 at 08:35:51AM -0800, Paul E. McKenney wrote:
> > > Good point, and if this sort of thing happens frequently, perhaps there
> > > should be an
On Fri 2024-02-02 05:04:45, Paul E. McKenney wrote:
> Hello!
>
> Starting with next-20240130 (and perhaps a bit earlier), rcutorture gets
> what initially looked like early-boot hangs, but only when running on
> dual-socket x86 systems [1], as it it works just fine on my x86 laptop [2].
> But
to create random
> locations when the livepatch gets enabled. Nothing is guarantted.
> The magic is in the randomness.
>
> Reviewed-by: Joe Lawrence
> Signed-off-by: Marcos Paulo de Souza
Reviewed-by: Petr Mladek
Best Regards,
Petr
epatched kernel function.
>
>
> Reviewed-by: Joe Lawrence
> Signed-off-by: Marcos Paulo de Souza
Looks good and works for me.
Reviewed-by: Petr Mladek
Best Regards,
Petr
n
> the files created by Kbuild to compile the modules. The new install
> rule copies only the .ko files, as we would expect the gen_tar to work.
>
> Reviewed-by: Joe Lawrence
> Signed-off-by: Marcos Paulo de Souza
I am not export on kbuild. But it looks reasonable and works for me.
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Fri 2024-01-05 09:49:44, Theodore Ts'o wrote:
> On Fri, Jan 05, 2024 at 02:20:07PM +0800, Jingzi Meng wrote:
> > CAP_SYSLOG was separated from CAP_SYS_ADMIN and introduced in Linux
> > 2.6.37 (2010-11). For a long time, certain syslog actions required
> > CAP_SYS_ADMIN or CAP_SYSLOG. Maybe it’s
On Mon 2023-11-06 17:25:10, Lukas Hruska wrote:
> Livepatches need to access external symbols which can't be handled
> by the normal relocation mechanism. It is needed for two types
> of symbols:
>
> --- /dev/null
> +++ b/scripts/livepatch/klp-convert.c
> @@ -0,0 +1,283 @@
[...]
> +/*
> + *
On Mon 2023-11-06 17:25:13, Lukas Hruska wrote:
> Add a section to Documentation/livepatch/module-elf-format.rst
> describing how klp-convert works for fixing relocations.
>
> Signed-off-by: Lukas Hruska
Looks good to me:
Reviewed-by: Petr Mladek
Best Regards,
Petr
suggest to livepatch a symbol from another test module so that
it does not modify the running system and the result is predictable.
Otherwise it looks good. With a better module name:
Reviewed-by: Petr Mladek
Best Regards,
Petr
resolved by
klp-convert.
> Signed-off-by: Josh Poimboeuf
> Signed-off-by: Lukas Hruska
Otherwise the code looks good. With the updated commit message:
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Mon 2023-11-06 17:25:10, Lukas Hruska wrote:
> Livepatches need to access external symbols which can't be handled
> by the normal relocation mechanism. It is needed for two types
> of symbols:
>
> + Symbols which can be local for the original livepatched function.
> The alternative
On Mon 2023-11-06 17:25:09, Lukas Hruska wrote:
> From: Josh Poimboeuf
>
> Define klp prefixes in include/uapi/linux/livepatch.h, and use them for
> replacing hard-coded values in kernel/livepatch/core.c.
>
> Signed-off-by: Josh Poimboeuf
> Signed-off-by: Lukas Hrusk
Hi Qi,
first, most people, including me, prefer to be in Cc for the entire patchset.
It helps to get the whole picture.
This mail is even worse because the other patches are not in the same
thread. As a result, I can't find the other patches even via lore,
see
On Wed 2024-01-03 07:59:18, Greg KH wrote:
> On Wed, Jan 03, 2024 at 01:00:58PM +0800, 孟敬姿 wrote:
> > Hi, we suggest revisiting the capability checks in
> > check_syslog_permissions(). Currently CAP_SYSLOG is checked first, and
> > if it’s not there but there is a CAP_SYS_ADMIN, it can also pass
On Tue 2023-12-19 09:50:18, Joe Lawrence wrote:
> On 12/19/23 04:45, Alexander Gordeev wrote:
> > On Mon, Dec 18, 2023 at 05:44:54PM -0500, Joe Lawrence wrote:
> >
> >> @@ -280,7 +268,13 @@ function set_pre_patch_ret {
> >> function start_test {
> >>local test="$1"
> >>
> >> - save_dmesg
On Fri 2023-12-08 09:06:30, Miroslav Benes wrote:
> > > My idea is to abandon this way completely, take the selftests and build
> > > and run them on the system right away.
> > >
> > > Both should be doable, hopefully, if we wire it all correctly... and
> > > document it.
> > >
> > I can't
On Mon 2023-12-04 09:56:28, Joel Granados wrote:
> Hey Petr
>
> I missed this message somehow
>
> On Tue, Nov 28, 2023 at 03:07:43PM +0100, Petr Mladek wrote:
> > On Tue 2023-11-07 14:45:07, Joel Granados via B4 Relay wrote:
> > > From: Joel Granados
reduction is worth the
effort. I feel that this change makes the access a bit less secure.
Well, almost all arrays are static so that it should just work.
The patch does what it says. Feel free to use:
Reviewed-by: Petr Mladek
Best Regards,
Petr
-off-by: Petr Mladek
---
include/linux/livepatch.h | 7 +-
kernel/livepatch/core.c | 17 ++-
kernel/livepatch/state.c | 27 +++--
kernel/livepatch/state.h | 1 +
lib/livepatch/test_klp_state.c
postponed until the approach has been approved
in the POC stage.
Signed-off-by: Petr Mladek
---
Documentation/livepatch/callbacks.rst | 133
Documentation/livepatch/index.rst | 1 -
include/linux/livepatch.h | 25 ---
kernel/livepatch/core.c
ils.
- Better organize the tests. test-module.sh combines
tests of various aspects which might better be suited
somewhere else.
As a first step, test-callbacks.sh has been renamed
to test-modules.sh. But there still might be a better name.
- Split this huge patch. Add the
ctionality
which might be used in more tests. It would allow to create tests
focusing on some particular feature with an easier output.
Signed-off-by: Petr Mladek
---
lib/livepatch/Makefile| 2 +
lib/livepatch/test_klp_speaker.c | 34 +
lib
per-state.
+ Remove callbacks needed to transfer the pointer between
states.
+ Keep the versioning of the state to prevent downgrade.
The problem is artificial because no callbacks are
needed to transfer or free the shadow variable anymore.
Signed-off-by: Petr Mladek
---
lib/livepa
ariables using
state->callbacks.shadow_dtor callback when provided.
Signed-off-by: Petr Mladek
---
include/linux/livepatch.h | 15 ++-
kernel/livepatch/state.c | 14 ++
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/include/linux/livepatch.h b/include/
rred.
The per-object callbacks were called after the barrier. They were
using and already existing for-cycle. And nobody did mind about
the ordering.
Signed-off-by: Petr Mladek
---
include/linux/livepatch.h | 28
kernel/livepatch/core.c
tion is not updated.
+ More selftest might be needed [**]
[*] There is some mystery in a selftest when the migration gets
blocked, see the comments in the 5th patch.
[**] In fact, many selftests would deserve some cleanup and
better split into categories.
Petr Mladek (
Hi Linus,
please pull a fix for livepatching from
git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching
tags/livepatching-for-6.7
===
- Add missing newline character to avoid waiting for a continuous message.
On Mon 2023-10-09 15:14:28, Alessandro Carminati wrote:
> Hello Kris,
>
> Thank you for your contribution and for having your thought shared with me.
>
> Allow me to begin this conversation by explaining what came to mind when
> I decided to propose a patch that creates aliases.
>
> The
On Wed 2023-09-20 01:14:55, John Ogness wrote:
> Invoke the atomic write enforcement functions for rcu stalls to
> ensure that the information gets out to the consoles.
>
> It is important to note that if there are any legacy consoles
> registered, they will be attempting to directly print from
eads and user
> mode threads")
The change makes sense to me. Well, I could not test it easily.
Anyway, feel free to use:
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Fri 2023-09-22 15:20:37, Enlin Mu wrote:
> Petr Mladek 于2023年9月16日周六 00:34写道：
> >
> > On Fri 2023-09-15 11:53:13, Greg KH wrote:
> > > On Fri, Sep 15, 2023 at 04:46:02PM +0800, Enlin Mu wrote:
> > > > John Ogness 于2023年9月15日周五 16:34写道：
> > >
On Fri 2023-09-22 15:34:44, Enlin Mu wrote:
> John Ogness 于2023年9月15日周五 16:34写道：
> >
> > On 2023-09-15, Enlin Mu wrote:
> > > Sometimes we want to print cpu id of printk() messages to consoles
> > >
> > > diff --git a/include/linux/threads.h b/include/linux/threads.h
> > > index
Adding live-patching list into Cc.
On Fri 2023-08-25 15:19:10, Leizhen (ThunderTown) wrote:
> On 2023/8/25 11:46, Yonghong Song wrote:
> > Kernel test robot reported a kallsyms_test failure when clang lto is
> > enabled (thin or full) and CONFIG_KALLSYMS_SELFTEST is also enabled.
> > I can
On Wed 2023-08-30 17:47:35, Joe Lawrence wrote:
> On 8/30/23 02:37, Michael Ellerman wrote:
> > Michael Ellerman writes:
> >> Joe Lawrence writes:
> >>> Hi ppc-dev list,
> >>>
> >>> We noticed that our kpatch integration tests started failing on ppc64le
> >>> when targeting the upstream v6.4
On Wed 2023-08-30 10:53:59, Daniel Thompson wrote:
> On Fri, Aug 25, 2023 at 07:18:44AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Fri, Aug 25, 2023 at 3:09 AM Daniel Thompson
> > wrote:
> > >
> > > On Tue, Aug 22, 2023 at 01:19:46PM -0700, Douglas Anderson wrote:
> > > > When entering
On Thu 2023-09-14 15:26:44, Zheng Yejian wrote:
> Without the newline character, the log may not be printed immediately
> after the error occurs.
>
> Fixes: ca376a937486 ("livepatch: Prevent module-specific KLP rela sections
> from referencing vmlinux symbols")
> Signed-off-by: Zheng Yejian
Signed-off-by: Zheng Yejian
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Fri 2023-09-15 11:53:13, Greg KH wrote:
> On Fri, Sep 15, 2023 at 04:46:02PM +0800, Enlin Mu wrote:
> > John Ogness 于2023年9月15日周五 16:34写道：
> > >
> > > On 2023-09-15, Enlin Mu wrote:
> > > > Sometimes we want to print cpu id of printk() messages to consoles
> > > >
> > > > diff --git
On Tue 2023-09-12 16:18:00, Alessandro Carminati wrote:
> ha scritto:
> > From: Alessandro Carminati (Red Hat)
> > > sample from new v3
> > >
> > > ~ # cat /proc/kallsyms | grep gic_mask_irq
> > > d0b03c04dae4 t gic_mask_irq
> > > d0b03c04dae4 t
On Thu 2023-07-20 16:31:16, Stefano Stabellini wrote:
> On Thu, 20 Jul 2023, Petr Mladek wrote:
> > On Wed 2023-07-19 18:46:08, Stefano Stabellini wrote:
> > > On Wed, 19 Jul 2023, Petr Mladek wrote:
> > > > I see the following warning from free_irq() in 6.5-rc2 whe
On Wed 2023-07-19 18:46:08, Stefano Stabellini wrote:
> On Wed, 19 Jul 2023, Petr Mladek wrote:
> > On Fri 2022-05-13 14:19:38, Stefano Stabellini wrote:
> > > From: Luca Miccio
> > >
> > > When running as dom0less guest (HVM domain on ARM) the xenstore event
On Fri 2022-05-13 14:19:38, Stefano Stabellini wrote:
> From: Luca Miccio
>
> When running as dom0less guest (HVM domain on ARM) the xenstore event
> channel is available at domain creation but the shared xenstore
> interface page only becomes available later on.
>
> In that case, wait for a
")
> Signed-off-by: Douglas Anderson
Thanks for the patch:
Reviewed-by: Petr Mladek
Best Regards,
Petr
On Thu 2023-06-22 16:00:21, Joel Granados wrote:
> On Thu, Jun 22, 2023 at 06:21:48AM +0200, Jiri Slaby wrote:
> > On 21. 06. 23, 15:15, Joel Granados wrote:
> > > On Wed, Jun 21, 2023 at 12:47:58PM +0200, Greg Kroah-Hartman wrote:
> > > > On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados
On Wed 2023-06-21 11:09:57, Joel Granados wrote:
> In order to remove the end element from the ctl_table struct arrays, we
> explicitly define the size when registering the targes. We add a size
> argument to the register_sysctl_init call and pass an ARRAY_SIZE for all
> the callers.
This does
On Thu 2023-06-22 16:00:21, Joel Granados wrote:
> On Thu, Jun 22, 2023 at 06:21:48AM +0200, Jiri Slaby wrote:
> > On 21. 06. 23, 15:15, Joel Granados wrote:
> > > On Wed, Jun 21, 2023 at 12:47:58PM +0200, Greg Kroah-Hartman wrote:
> > > > On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados
; Closes: https://lore.kernel.org/r/871qi5otdh.fsf@mail.lhotse
> Signed-off-by: Douglas Anderson
Looks like a reasonable solution:
Reviewed-by: Petr Mladek
Thanks a lot for fixing the regression.
Best Regards,
Petr
On Wed 2023-06-21 11:09:57, Joel Granados wrote:
> In order to remove the end element from the ctl_table struct arrays, we
> explicitly define the size when registering the targes. We add a size
> argument to the register_sysctl_init call and pass an ARRAY_SIZE for all
> the callers.
This does
On Fri 2023-06-16 09:48:06, Doug Anderson wrote:
> Hi,
>
> On Fri, Jun 16, 2023 at 8:07 AM Petr Mladek wrote:
> >
> > There are several hardlockup detector implementations and several Kconfig
> > values which allow selection and build of the pr
On Fri 2023-06-16 09:48:06, Doug Anderson wrote:
> Hi,
>
> On Fri, Jun 16, 2023 at 8:07 AM Petr Mladek wrote:
> >
> > There are several hardlockup detector implementations and several Kconfig
> > values which allow selection and build of the pr
On Fri 2023-06-16 17:06:12, Petr Mladek wrote:
> Hi,
>
> this patchset is supposed to replace the last patch in the patchset cleaning
> up after introducing the buddy detector, see
> https://lore.kernel.org/r/20230526184139.10.I821fe7609e57608913fe05abd8f35b343e7a9aae@change
On Fri 2023-06-16 17:06:12, Petr Mladek wrote:
> Hi,
>
> this patchset is supposed to replace the last patch in the patchset cleaning
> up after introducing the buddy detector, see
> https://lore.kernel.org/r/20230526184139.10.I821fe7609e57608913fe05abd8f35b343e7a9aae@change
and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc.
As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies
on arm, x86, powerpc architectures.
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/powerpc/Kconfig | 5 ++---
include/linux/nmi.h | 2 +-
lib
CTOR_BUDDY=y
CONFIG_HAVE_HARDLOCKUP_DETECTOR_SPARC64=y
CONFIG_HARDLOCKUP_DETECTOR_SPARC64=y
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/sparc/Kconfig.debug | 7 ++-
include/linux/nmi.h | 4 ++--
kernel/watchdog.c| 2 +-
lib/Kconfig.debug| 2 +-
4 f
CTOR
and it is not longer enabled when HAVE_NMI_WATCHDOG is set.
Signed-off-by: Petr Mladek
watchdog/sparc64: Rename HAVE_NMI_WATCHDOG to HAVE_HARDLOCKUP_WATCHDOG_SPARC64
The configuration variable HAVE_NMI_WATCHDOG has a generic name but
it is selected only for SPARC64.
It should _not_ be used
HAVE_NMI_WATCHDOG related
checks.
The change should not change the existing behavior.
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/powerpc/include/asm/nmi.h | 2 --
arch/sparc/include/asm/nmi.h | 1 -
include/linux/nmi.h| 13 ++---
3 files changed, 10
value is not preserved when the global switch is disabled.
The user has to make the decision again when it gets re-enabled.
Signed-off-by: Petr Mladek
---
arch/Kconfig | 23 +-
lib/Kconfig.debug | 62 +++
2 files changed, 53
behavior.
Signed-off-by: Petr Mladek
---
lib/Kconfig.debug | 112 +++---
1 file changed, 56 insertions(+), 56 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index ed7b01c4bd41..3e91fa33c7a0 100644
--- a/lib/Kconfig.debug
+++ b/lib
and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc.
As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies
on arm, x86, powerpc architectures.
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/powerpc/Kconfig | 5 ++---
include/linux/nmi.h | 2 +-
lib
CTOR_BUDDY=y
CONFIG_HAVE_HARDLOCKUP_DETECTOR_SPARC64=y
CONFIG_HARDLOCKUP_DETECTOR_SPARC64=y
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/sparc/Kconfig.debug | 7 ++-
include/linux/nmi.h | 4 ++--
kernel/watchdog.c| 2 +-
lib/Kconfig.debug| 2 +-
4 f
CTOR
and it is not longer enabled when HAVE_NMI_WATCHDOG is set.
Signed-off-by: Petr Mladek
watchdog/sparc64: Rename HAVE_NMI_WATCHDOG to HAVE_HARDLOCKUP_WATCHDOG_SPARC64
The configuration variable HAVE_NMI_WATCHDOG has a generic name but
it is selected only for SPARC64.
It should _not_ be used
HAVE_NMI_WATCHDOG related
checks.
The change should not change the existing behavior.
Signed-off-by: Petr Mladek
Reviewed-by: Douglas Anderson
---
arch/powerpc/include/asm/nmi.h | 2 --
arch/sparc/include/asm/nmi.h | 1 -
include/linux/nmi.h| 13 ++---
3 files changed, 10
value is not preserved when the global switch is disabled.
The user has to make the decision again when it gets re-enabled.
Signed-off-by: Petr Mladek
---
arch/Kconfig | 23 +-
lib/Kconfig.debug | 62 +++
2 files changed, 53
at it from
a bad side.
+ Removed superfluous "default n"
+ Fixed typos.
Petr Mladek (6):
watchdog/hardlockup: Sort hardlockup detector related config values a
logical way
watchdog/hardlockup: Make the config checks more straightforward
watchdog/hardlockup: Declare arc
behavior.
Signed-off-by: Petr Mladek
---
lib/Kconfig.debug | 112 +++---
1 file changed, 56 insertions(+), 56 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index ed7b01c4bd41..3e91fa33c7a0 100644
--- a/lib/Kconfig.debug
+++ b/lib
at it from
a bad side.
+ Removed superfluous "default n"
+ Fixed typos.
Petr Mladek (6):
watchdog/hardlockup: Sort hardlockup detector related config values a
logical way
watchdog/hardlockup: Make the config checks more straightforward
watchdog/hardlockup: Declare arc
On Thu 2023-06-08 06:55:23, Doug Anderson wrote:
> Hi,
>
> On Thu, Jun 8, 2023 at 4:02 AM Petr Mladek wrote:
> >
> > > > config HARDLOCKUP_DETECTOR
> > > > bool "Detect Hard Lockups"
> > > >
On Thu 2023-06-08 06:55:23, Doug Anderson wrote:
> Hi,
>
> On Thu, Jun 8, 2023 at 4:02 AM Petr Mladek wrote:
> >
> > > > config HARDLOCKUP_DETECTOR
> > > > bool "Detect Hard Lockups"
> > > >
On Wed 2023-06-07 16:37:10, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:26 AM Petr Mladek wrote:
> >
> > @@ -1102,6 +1103,14 @@ config HARDLOCKUP_DETECTOR_BUDDY
> > depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH
> > select HARDLOCKUP_DETECT
On Wed 2023-06-07 16:37:10, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:26 AM Petr Mladek wrote:
> >
> > @@ -1102,6 +1103,14 @@ config HARDLOCKUP_DETECTOR_BUDDY
> > depends on !HAVE_HARDLOCKUP_DETECTOR_ARCH
> > select HARDLOCKUP_DETECT
On Wed 2023-06-07 16:36:35, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index 13c6e596cf9e..57f15babe188 100644
> > --- a/arch/Kconfig
> > +++ b/arch/
On Wed 2023-06-07 16:36:35, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index 13c6e596cf9e..57f15babe188 100644
> > --- a/arch/Kconfig
> > +++ b/arch/
On Wed 2023-06-07 16:35:19, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > arch_touch_nmi_watchdog() needs a different implementation for various
> > hardlockup detector implementations. And it does nothing when
> > any
On Wed 2023-06-07 16:35:19, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > arch_touch_nmi_watchdog() needs a different implementation for various
> > hardlockup detector implementations. And it does nothing when
> > any
On Wed 2023-06-07 16:35:09, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index 422f0ffa269e..13c6e596cf9e 100644
> > --- a/arch/Kconfig
> > +++ b/arch/K
On Wed 2023-06-07 16:35:09, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> >
> > diff --git a/arch/Kconfig b/arch/Kconfig
> > index 422f0ffa269e..13c6e596cf9e 100644
> > --- a/arch/Kconfig
> > +++ b/arch/K
On Wed 2023-06-07 16:34:20, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> > Only one hardlockup detector can be compiled in. The selection is done
> > using quite complex dependencies between several CONFIG variables.
> > The
On Wed 2023-06-07 16:34:20, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 7, 2023 at 8:25 AM Petr Mladek wrote:
> > Only one hardlockup detector can be compiled in. The selection is done
> > using quite complex dependencies between several CONFIG variables.
> > The
and HAVE_HARDLOCKUP_DETECTOR_PERF definitions for powerpc.
As a result HAVE_HARDLOCKUP_DETECTOR_PERF has the same dependencies
on arm, x86, powerpc architectures.
Signed-off-by: Petr Mladek
---
arch/powerpc/Kconfig | 5 ++---
include/linux/nmi.h | 2 +-
lib/Kconfig.debug| 9 +
3 files
CTOR_BUDDY=y
CONFIG_HAVE_HARDLOCKUP_DETECTOR_SPARC64=y
CONFIG_HARDLOCKUP_DETECTOR_SPARC64=y
Signed-off-by: Petr Mladek
---
arch/sparc/Kconfig.debug | 10 +-
include/linux/nmi.h | 4 ++--
kernel/watchdog.c| 2 +-
lib/Kconfig.debug| 2 +-
4 files changed, 13 inse
arch/sparc/Kconfig.debug.
Signed-off-by: Petr Mladek
---
arch/Kconfig | 12
arch/sparc/Kconfig | 2 +-
arch/sparc/Kconfig.debug | 12
include/linux/nmi.h | 4 ++--
kernel/watchdog.c| 2 +-
lib/Kconfig.debug| 5 +
6 files changed, 17
1 - 100 of 9243 matches
Mail list logo
