Hi
I fixed a bug in amarok. Change is quite simple but i changed some methodnames
and class members. Since i am not that firm in all things amarok could someone
please review if the commit
121f91675dbf68072cefe486ccdabfff922cc0d5 and the one before that.
is bc and source compatible? Does Amaro
8 января 2011 г. 20:47 пользователь Sergey Ivanov <123k...@gmail.com> написал:
> 2011/1/8 Alexander Potashev :
>> Hi,
>>
>> I tried to make Amarok use Russian version of the icon
>> filename-sample-rate.png. I've put that file here:
>> /usr/share/apps/amarok/icons/hicolor/48x48/actions/l10n/ru/file
2011/1/8 Alexander Potashev :
> Is it possible to use localized versions of icons in Amarok?
Localized icon works for me now in Amarok, I needed to clean the icon
cache properly.
I'll start a discussion in Russian KDE mailing list about relevance of
the localized icon.
--
Alexander Potashev
__
2011/1/8 Thomas Lübking :
> (but then there could be just i18n("Hz") and no icon at all, yesno?)
Plain text "Hz" wouldn't look as an icon. Also, your solution is very
partial, you won't be able to localize the "bold"/"italic"/... icons
in KOffice/Calligra.
--
Alexander Potashev
Am Saturday 08 January 2011 schrieb Sergey Ivanov:
> > Is it possible to use localized versions of icons in Amarok?
No, but KDE should support *local* icons, ie. place them in
~/.kde/share/apps/amarok/icons/hicolor/48x48/actions/filename-sample-rate.png
- or so... =\
(but then there could be jus
Hi,
I was backing up my gmail with fetchmail and it seems something went
horribly wrong.
If this ML or any of you have got bounces of old mails from me, I'm
really sorry about that.
Nikhil
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.
2011/1/8 Alexander Potashev :
> Hi,
>
> I tried to make Amarok use Russian version of the icon
> filename-sample-rate.png. I've put that file here:
> /usr/share/apps/amarok/icons/hicolor/48x48/actions/l10n/ru/filename-sample-rate.png
> , but Amarok still uses the original icon (when running with Ru
commit 137de448c030cbfeb9de3bc21969f259a7291eca
branch master
Author: Mark Kretschmann
Date: Sat Jan 8 19:08:55 2011 +0100
Fix major issue with the Collection missing whole albums, and mixing up
artists.
Big thanks to Ralf Engels, who came up with this fix! :)
BUG: 262459
Hi,
I tried to make Amarok use Russian version of the icon
filename-sample-rate.png. I've put that file here:
/usr/share/apps/amarok/icons/hicolor/48x48/actions/l10n/ru/filename-sample-rate.png
, but Amarok still uses the original icon (when running with Russian
localization enabled).
Is it possi
On Sat, Jan 8, 2011 at 8:41 PM, Mark Kretschmann wrote:
>
> Nikhil, could you please put the original PNG image in Git Master too?
>
> It's good to have access to the original. Also, I would like to resize
> it a bit, the image is very huge.
>
done.
___
> On Jan. 8, 2011, 3:12 p.m., Mark Kretschmann wrote:
> > Yeah, you can do that. However, I have not actually tested your patch. Does
> > it change anything in the behavior of the widget?
I compiled Amarok with the first version of this patch (with «""»), and I
haven't noticed any changes.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100309/#review775
---
Yeah, you can do that. However, I have not actually tested your p
On Wed, Jan 5, 2011 at 10:13 AM, Nikhil Marathe wrote:
> On Wed, Jan 5, 2011 at 2:24 PM, Mark Kretschmann wrote:
>>> Its a PNG, the earlier was a JPG, so is
>>> that an issue
>>> or can I modify App.cpp to simply use a PNG?
>>
>> Yes, you could do that. Or, if the PNG is very large in size, conve
> On Jan. 8, 2011, 8:42 a.m., Mark Kretschmann wrote:
> > Looks good to me. At first I thought, this introduces string changes, we
> > cannot do it before 2.4.0 release. But then I realized that you have just
> > removed strings, but not changed any.
> >
> > One nitpick: You should probably ch
On Sat, Jan 8, 2011 at 12:59 PM, Mark Kretschmann wrote:
> On Fri, Jan 7, 2011 at 5:26 PM, Leo Franchi wrote:
>> On Fri, Jan 7, 2011 at 11:16 AM, Mark Kretschmann
>> wrote:
>>> Ahoy,
>>>
>>> I just noticed that Amarok would play an album, say from Artist X, and
>>> in reality it plays an album
> On Jan. 8, 2011, 11:43 a.m., Sergey Ivanov wrote:
> > I think that It's a bad idea to apply any settings when user press Cancel,
> > so storing Format Presets should stay in onAccept slot.
> > Agree with second statement.
> >
> > And finally this patch has nothing in common with mentioned Bu
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/
---
(Updated Jan. 8, 2011, 12:12 p.m.)
Review request for Amarok.
Changes
--
On Fri, Jan 7, 2011 at 5:26 PM, Leo Franchi wrote:
> On Fri, Jan 7, 2011 at 11:16 AM, Mark Kretschmann wrote:
>> Ahoy,
>>
>> I just noticed that Amarok would play an album, say from Artist X, and
>> in reality it plays an album from Artist Y. Then, complete albums are
>> missing.
>>
>> I did a fu
Heya folks,
given the remaining problems we are seeing I'm delaying tagging and
release by 3 days.
Please everyone have a look at the bugs tagged release_blocker and
regression in bugzilla. There are saved searches linked in your
preferences at https://bugs.kde.org/userprefs.cgi?tab=saved-searches
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/#review771
---
I think that It's a bad idea to apply any settings when user pres
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100321/
---
Review request for Amarok.
Summary
---
Fixes two errors:
First: Pres
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100309/#review770
---
Ship it!
Looks good to me. At first I thought, this introduces s
22 matches
Mail list logo
