Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27059 --- The patch looks good now, just some last trivial things.

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 2:21 a.m.) Review request for Amarok. Changes

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Harsh Gupta
On Feb. 9, 2013, 5:36 p.m., Matěj Laitl wrote: src/MainWindow.cpp, line 836 http://git.reviewboard.kde.org/r/108716/diff/2/?file=113315#file113315line836 Amarok coding style says: connect( action, SIGNAL(triggered(bool)), this, SLOT(slotShufflePlaylist()) );

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: src/MainWindow.cpp, line 836 http://git.reviewboard.kde.org/r/108716/diff/2/?file=113315#file113315line836 Amarok coding style says: connect( action, SIGNAL(triggered(bool)), this, SLOT(slotShufflePlaylist()) );

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-09 Thread Matěj Laitl
On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: src/MainWindow.cpp, line 836 http://git.reviewboard.kde.org/r/108716/diff/2/?file=113315#file113315line836 Amarok coding style says: connect( action, SIGNAL(triggered(bool)), this, SLOT(slotShufflePlaylist()) );