Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-11 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 11, 2013, 9 p.m.) Review request for Amarok and Vishesh Hand

Re: Review Request 108907: Added transcoding for opus format

2013-02-11 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- (Updated Feb. 11, 2013, 8:39 p.m.) Review request for Amarok and Matěj Lai

Re: Review Request 108905: Move UI code of PlaylistQueueEditor from .ui to .cpp file

2013-02-11 Thread Bart Cerneels
> On Feb. 11, 2013, 5:40 p.m., Bart Cerneels wrote: > > Use a promoted widget instead. UI forms superior to this, we prefer to use > > them more, not less. > > > > FYI the QueueEditor feature is not something we'll keep around for long. > > It's scheduled to be completely replaced one or two r

Re: Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

2013-02-11 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108906/#review27218 --- src/playlist/PlaylistQueueEditor.cpp

Re: Review Request 108905: Move UI code of PlaylistQueueEditor from .ui to .cpp file

2013-02-11 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108905/#review27217 --- Use a promoted widget instead. UI forms superior to this, we pr

Review Request 108907: Added transcoding for opus format

2013-02-11 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/ --- Review request for Amarok. Description --- In addition to request #10

Review Request 108906: Add ability to drag titles to re-arrange them in queue manager

2013-02-11 Thread Bartosz Szreder
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108906/ --- Review request for Amarok. Description --- The new ListWidget (Playli

Review Request 108905: Move UI code of PlaylistQueueEditor from .ui to .cpp file

2013-02-11 Thread Bartosz Szreder
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108905/ --- Review request for Amarok. Description --- This is the first patch (o

Re: Review Request 108542: Support for .opus file tags added

2013-02-11 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108542/ --- (Updated Feb. 11, 2013, 9:14 a.m.) Review request for Amarok. Changes --

Re: Review Request 108542: Support for .opus file tags added

2013-02-11 Thread Martin Brodbeck
> On Feb. 9, 2013, 2:17 a.m., Matěj Laitl wrote: > > shared/FileTypeResolver.cpp, lines 20-21 > > > > > > Why is including config.h needed for TAGLIB_OPUS_FOUND while it isn't > > needed for TAGLIB_MOD_FOUND? Tha