Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- Review request for Amarok. Description --- Added a shortcut button fo

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 3, 2013, 10:04 p.m.) Review request for Amarok. Descriptio

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27047 --- Hi, thanks for the patch, looks good - just one badly chosen na

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 9, 2013, 12:33 p.m.) Review request for Amarok. Changes --

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27059 --- The patch looks good now, just some last trivial things. (sorry

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 2:21 a.m.) Review request for Amarok. Changes --

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

> On Feb. 9, 2013, 5:36 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlaylis

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

> On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlayli

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

> On Feb. 9, 2013, 12:06 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlayli

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 1:44 p.m.) Review request for Amarok. Changes --

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27117 --- The ChangeLog entry from v3 seems to be absent in v4... - Matě

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 7:16 p.m.) Review request for Amarok. Changes --

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

> On Feb. 10, 2013, 4:40 p.m., Matěj Laitl wrote: > > The ChangeLog entry from v3 seems to be absent in v4... Oops ! I will fix it. - Harsh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27124 --- This review has been submitted with commit 62ce5195cfe30b78ec3

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

> On Feb. 10, 2013, 7:34 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 62ce5195cfe30b78ec3e234f1d1f5dbed7534a4b by Mat?j Laitl on behalf of Harsh > > Gupta to branch master. Thanks :) - Harsh --- This is