Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

On Sat, Aug 12, 2017 at 9:02 PM, Kuehling, Felix wrote: > Hi Oded, > > Most of our recent work has been on the amdgpu driver. We basically just keep > radeon compiling these days. Amdgpu can support all the GPUs that KFD > supports. Between the amdgpu developers and the

RE: [PATCH 16/19] drm/amdkfd: Update PM4 packet headers

IIRC the amdgpu devs had been holding back on publishing the updated MEC microcode (with scratch support) because that WOULD have broken Kaveri. With this change from Felix we should be able to publish the newest microcode for both amdgpu and amdkfd WITHOUT breaking Kaveri. IOW this is the

Re: [PATCH 00/19] KFD fixes and cleanups

[+Alex] I'll rebase this on drm-next-4.14. Alex, is this the branch that will become the new default development branch for the amdgpu team? This should make coordination of dependent AMDGPU and KFD changes easier. Regards, Felix From: Oded Gabbay Sent: Saturday,

Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

Hi Oded, Most of our recent work has been on the amdgpu driver. We basically just keep radeon compiling these days. Amdgpu can support all the GPUs that KFD supports. Between the amdgpu developers and the KFD team we've also talked about merging KFD into amdgpu at some point and replacing the

Re: [PATCH 16/19] drm/amdkfd: Update PM4 packet headers

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > To match current firmware. The map process packet has been extended > to support scratch. This is a non-backwards compatible change and > it's about two years old. So no point keeping the old version around >

Re: [PATCH 14/19] drm/amdkfd: Add more error printing to help bringup

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > From: Yong Zhao > > Signed-off-by: Yong Zhao > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 +-- > 1

Re: [PATCH 13/19] drm/amdkfd: Handle remaining BUG_ONs more gracefully

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > In most cases, BUG_ONs can be replaced with WARN_ON with an error > return. In some void functions just turn them into a WARN_ON and > possibly an early exit. > > Signed-off-by: Felix Kuehling

Re: [PATCH 11/19] drm/amdkfd: Fix doorbell initialization and finalization

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > Handle errors in doorbell aperture initialization instead of BUG_ON. > iounmap doorbell aperture during finalization. > > Signed-off-by: Felix Kuehling > --- >

Re: [PATCH 10/19] drm/amdkfd: Remove BUG_ONs for NULL pointer arguments

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > Remove BUG_ONs that check for NULL pointer arguments that are > dereferenced in the same function. Dereferencing the NULL pointer > will generate a BUG anyway, so the explicit check is redundant and > unnecessary

Re: [PATCH 09/19] drm/amdkfd: Remove usage of alloc(sizeof(struct...

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > From: Kent Russell > > See https://kernel.org/doc/html/latest/process/coding-style.html > under "14) Allocating Memory" for rationale behind removing the > x=alloc(sizeof(struct) style and

Re: [PATCH 07/19] drm/amdkfd: Change x==NULL/false references to !x

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > From: Kent Russell > > Upstream prefers the !x notation to x==NULL or x==false. Along those lines > change the ==true or !=NULL references as well. Also make the references > to !x the same,

Re: [PATCH 05/19] drm/amdkfd: Clean up KFD style errors and warnings

On Sat, Aug 12, 2017 at 3:46 PM, Oded Gabbay wrote: > I'd like to check this patch, but it doesn't apply cleanly on the > upstream tree. > Please fix and re-send. > > Thanks, > Oded > > On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling > wrote: >>

Re: [PATCH 05/19] drm/amdkfd: Clean up KFD style errors and warnings

I'd like to check this patch, but it doesn't apply cleanly on the upstream tree. Please fix and re-send. Thanks, Oded On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > From: Kent Russell > > Using checkpatch.pl -f showed a number of style

Re: [PATCH 04/19] drm/amdkfd: Fix allocated_queues bitmap initialization

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > Use shared_resources.queue_bitmap to determine the queues available > for KFD in each pipe. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c |

Re: [PATCH 03/19] drm/amdkfd: Remove bogus divide-by-sizeof(uint32_t)

On Sat, Aug 12, 2017 at 12:56 AM, Felix Kuehling wrote: > kfd2kgd->address_watch_get_offset returns dword register offsets. > The divide-by-sizeof(uint32_t) is incorrect. In amdgpu that's true, but in radeon that's incorrect. If you look at cik_reg.h in radeon driver, you