If the GFX is headless, the audio codec should be disabled on PCIE bus. the the
HDA driver will never probe the audio. right?
Thanks
JimQu
发件人: Alex Deucher
发送时间: 2018年6月29日 12:01
收件人: Zhang, Jerry
抄送: Qu, Jim; amd-gfx list; Deucher, Alexander
主题: Re: [P
On Thu, Jun 28, 2018 at 10:54 PM, Zhang, Jerry (Junwei)
wrote:
> On 06/28/2018 02:22 PM, Jim Qu wrote:
>>
>> On modern laptop, there are more and more platforms
>> have two GPUs, and each of them maybe have audio codec
>> for HDMP/DP output. For some dGPU which is no output,
>> audio codec usually
This was sent to Debian (bug #902555), which asked for it to be
reported upstream.
Package: xserver-xorg-video-radeon
Version: 1:18.0.1-1
Severity: minor
Tags: patch
Dear Maintainer,
Summary of changes:
Remove superfluous quotation marks (") from the argument of a
single-font macro.
Use a
On 06/28/2018 02:22 PM, Jim Qu wrote:
On modern laptop, there are more and more platforms
have two GPUs, and each of them maybe have audio codec
for HDMP/DP output. For some dGPU which is no output,
audio codec usually is disabled.
In currect HDA audio driver, it will set all codec as
VGA_SWITCH
On 06/29/2018 02:37 AM, Alex Deucher wrote:
The phys and vm versions had the values swapped.
Signed-off-by: Alex Deucher
Nice catch.
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/dr
On 06/28/2018 05:58 PM, Huang Rui wrote:
We still use legacy type of gem_object_create, it should update to ttm_bo_type
now.
Signed-off-by: Huang Rui
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 +++---
2 files
Do we need to maintain the uvd/vce pg state in pp?
uvd/vce have maintained the pg state by themselves.
pp only provide an interface for uvd/vce/gfx/mmhub to power up/down the ip
through smu if smu supported, concurrently enable/disable uvd/vce/mmhub dpm
feature.
Best Regards
Rex
__
Reviewed-by: Rex Zhu
Best Regards
Rex
From: amd-gfx on behalf of Alex Deucher
Sent: Friday, June 29, 2018 2:38 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pm: fix display count in non-DC path
new_active_crtcs i
Reviewed-by: Rex Zhu
Best Regards
Rex
From: amd-gfx on behalf of Alex Deucher
Sent: Friday, June 29, 2018 2:38 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pp: add missing byte swapping in
process_pptables_v1_0.
Reviewed-by: Rex Zhu
Best Regards
Rex
From: amd-gfx on behalf of Alex Deucher
Sent: Friday, June 29, 2018 2:38 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pp: fix endian swapping in
atomctrl_get_voltage_range
Reviewed-by: Rex Zhu
Best Regards
Rex
From: amd-gfx on behalf of Alex Deucher
Sent: Friday, June 29, 2018 2:38 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_init_dpm_defaults
Shoul
Reviewed-by: Rex Zhu
Best Regards
Rex
From: amd-gfx on behalf of Alex Deucher
Sent: Friday, June 29, 2018 2:38 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in
smu7_get_pp_table_entry_call
Reviewed-by: Jim Qu
Signed-off-by: Lyude Paul
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
index daa06e7c5bb7..a389
Next version of https://patchwork.freedesktop.org/series/45371/
Notable changes:
- Added explanation on why ATIF handle sometimes lives in a different
namespace (thanks Alex!)
Lyude Paul (4):
drm/amdgpu: Make struct amdgpu_atif private to amdgpu_acpi.c
drm/amdgpu: s/disp_detetion_ports/di
The handles for ACPI methods like ATPX and ATIF will live under the
integrated GPU's namespace on systems with more then one GPU. ATPX is
already detected regardless of the namespace it lives in, and it will
always be in the same namespace as ATIF. So we can make things easier on
ourselves by just
The other day I was testing one of the HP laptops at my office with an
i915/amdgpu hybrid setup and noticed that hotplugging was non-functional
on almost all of the display outputs. I eventually discovered that all
of the external outputs were connected to the amdgpu device instead of
i915, and tha
Currently, there is nothing in amdgpu that actually uses these structs
other than amdgpu_acpi.c. Additionally, since we're about to start
saving the correct ACPI handle to use for calling ATIF in this struct
this saves us from having to handle making sure that the acpi_handle
(and by proxy, the typ
Need to swap before doing arthimetic on the values.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
b/drivers/gpu/drm/amd/powerplay/hwmgr
Was missed when updating the uvd 6 module.
Fixes: 1aac3c9180 (drm/amdgpu: fix insert nop for UVD6 ring)
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
b/drivers/gpu
Values need to be swapped on big endian.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c
b/drivers/gpu/drm/amd/powe
Should be using PCIELaneLow for the low clock level.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_h
The phys and vm versions had the values swapped.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index 23927cdfbc23..99604d
Should be mclk rather than sclk.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index de295b7
new_active_crtcs is a bitmask, new_active_crtc_count is the
actual count.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
in
On Thu, Jun 28, 2018 at 2:02 PM, Jiang, Sonny wrote:
> Hi Alex,
>
>
> What's your opinion about Michel's suggestion?
You should definitely update amdgpu.rst to include the new
documentation section. As for whether to have separate sections or
one big section for the parameters, I could go either
Hi Alex,
What's your opinion about Michel's suggestion?
Thanks,
Sonny
From: Michel Dänzer
Sent: Thursday, June 28, 2018 4:39:57 AM
To: Jiang, Sonny
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: update documentation for amdgpu_drv.c
Hi S
On 2018-06-28 11:58 AM, Huang Rui wrote:
> We still use legacy type of gem_object_create, it should update to ttm_bo_type
> now.
>
> Signed-off-by: Huang Rui
Nice catch. (For anyone wondering: No need for Cc: stable, since the
values used previously matched the enum values, so there's no change
On Thu, Jun 28, 2018 at 10:19:41AM -0400, Alex Deucher wrote:
> On Thu, Jun 28, 2018 at 9:42 AM, Bjorn Helgaas wrote:
> > On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote:
> >> So drivers can use them. This can be used to replace
> >> duplicate code in the drm subsystem.
> >>
> >> Sig
Michel,
My review is only for the first patch.
Slava
From: Michel Dänzer
Sent: Thursday, June 28, 2018 4:26:28 AM
To: Abramov, Slava
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code
On 2018-06-27 08:29 PM, Abramov
On Wed, Jun 20, 2018 at 2:40 AM, Evan Quan wrote:
> On UVD/VCE dpm enabled/disabled, the powergate status will be
> set as false/true. So that we will not try to ungate/gate them(
> enable/disable their dpm) again.
>
> v2: added check for uvd/vce powergate status before gating
> v3: fix typo in de
On Thu, Jun 28, 2018 at 5:10 AM, rex zhu wrote:
> From: Rex Zhu
>
> Convert clock unit 10KHz to KHz as the data sturct defined.
> e.g.
> struct pp_clock_with_latency {
> uint32_t clocks_in_khz;
> uint32_t latency_in_us;
> };
> Meanwhile revert the same conversion in display side.
On Thu, Jun 28, 2018 at 9:42 AM, Bjorn Helgaas wrote:
> On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote:
>> So drivers can use them. This can be used to replace
>> duplicate code in the drm subsystem.
>>
>> Signed-off-by: Alex Deucher
>
> Acked-by: Bjorn Helgaas
>
> Thanks a lot fo
This patch unifies the naming of DRM functions for reference counting
of struct drm_device. The resulting code is more aligned with the rest
of the Linux kernel interfaces.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 d
On Thu, Jun 28, 2018 at 04:13:06PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Changes from the previous version mainly involve Danoie's suggestion
Can't type today either: "Daniel's"
> of hiding the drm_encoder_find() in the iterator macro. I also polished
> the msm and tilcdc cases
On Mon, Jun 25, 2018 at 04:06:02PM -0500, Alex Deucher wrote:
> So drivers can use them. This can be used to replace
> duplicate code in the drm subsystem.
>
> Signed-off-by: Alex Deucher
Acked-by: Bjorn Helgaas
Thanks a lot for doing this!
If you haven't applied these yet, please
s/pci:
From: Ville Syrjälä
Use drm_connector_for_each_possible_encoder() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
v2: Replace drm_for_each_connector_encoder_ids() with
drm_connector_for_each_possible_encoder() (Daniel)
Cc: Da
From: Ville Syrjälä
Use drm_connector_for_each_possible_encoder() for iterating
connector->encoder_ids[]. A bit more convenient not having
to deal with the implementation details.
v2: Replace drm_for_each_connector_encoder_ids() with
drm_connector_for_each_possible_encoder() (Daniel)
Cc: Da
From: Ville Syrjälä
Changes from the previous version mainly involve Danoie's suggestion
of hiding the drm_encoder_find() in the iterator macro. I also polished
the msm and tilcdc cases a bit more with another small helper.
Cc: Alex Deucher
Cc: amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs
Cc:
On Thu, Jun 28, 2018 at 2:22 AM, Jim Qu wrote:
> On modern laptop, there are more and more platforms
> have two GPUs, and each of them maybe have audio codec
> for HDMP/DP output. For some dGPU which is no output,
> audio codec usually is disabled.
>
> In currect HDA audio driver, it will set all
Hi Evan,
On 2018-06-20 08:40 AM, Evan Quan wrote:
> On UVD/VCE dpm enabled/disabled, the powergate status will be
> set as false/true. So that we will not try to ungate/gate them(
> enable/disable their dpm) again.
>
> v2: added check for uvd/vce powergate status before gating
> v3: fix typo in
We still use legacy type of gem_object_create, it should update to ttm_bo_type
now.
Signed-off-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/
From: Rex Zhu
Convert clock unit 10KHz to KHz as the data sturct defined.
e.g.
struct pp_clock_with_latency {
uint32_t clocks_in_khz;
uint32_t latency_in_us;
};
Meanwhile revert the same conversion in display side.
Acked-by: Alex Deucher
Acked-by: Harry Wentland
Signed-off-by:
Hi Sonny,
would it be possible to put the documentation of each parameter directly
next to its definition / declaration? Otherwise, I'm afraid the
documentation will quickly fall out of date WRT the code.
> +/**
> + * DOC: module_parameters
Otherwise, this needs to be referenced in Documentat
On 2018-06-27 08:29 PM, Abramov, Slava wrote:
> I wonder how '#if 0' made its way upstream, but besides this
It was inherited from xf86-video-ati, where it's been in
drmmode_display.c since that file was first added (in 2009).
> Reviewed-by: Slava Abramov
Thanks Slava (and Alex)! Is that only
44 matches
Mail list logo
