Re: [PATCH] drm/amdgpu: fix AGP location with VRAM at 0x0

2018-10-08 Thread Zhang, Jerry(Junwei)
On 10/04/2018 05:02 PM, Christian König wrote: That also simplifies handling quite a bit. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 2/2] drm/amdgpu: fix CPDMA hang in PRT mode

2018-10-08 Thread tao.zhou1
From: Tao Zhou Fix CPDMA hang in PRT mode, set CPF_INT_DMA in reg CP_MECx_F32_INT_DIS for Compute and set DISABLE_GFX_HALT_ON_UTCL1_ERROR in reg CP_DEBUG for GFX Affected ASICs: Vega10 Vega12 Raven Change-Id: I1029c9cf39c82f8415af77012cb289b565ba996b Signed-off-by: Tao Zhou Tested-by: Yukun.L

[PATCH 1/2] drm/amdgpu: add CP_DEBUG register definition for GC9.0

2018-10-08 Thread tao.zhou1
From: Tao Zhou Add CP_DEBUG register definition. Change-Id: I38b0e5accc9ed2f516f409f1ffd88a9690356083 Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_offset.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_0_offset.

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 08:17:06PM +, sylvain.bertr...@gmail.com wrote: > Sorry, I was wrong: I thought your patch set was enabling by default DC for > dce6 (it requires the DC kernel param). > I did force it, and it fails to init the dce6. I did hack a bit your patch set on amd-staging-drm-ne

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 07:02:54PM +0200, Mauro Rossi wrote: > Thanks for info, do you have some github or patch to share for > comparison/mutual knowledge? Sorry, I was wrong: I thought your patch set was enabling by default DC for dce6 (it requires the DC kernel param). I did force it, and it fa

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Zhu, Rex
> This means we should either separate filling the BO from allocating it (e.g. > split amdgpu_ucode_init_bo into two functions) and then only call the filling > function during GPU reset and resume. Got it. Thanks. I will refine this function. Regards Rex > -Original Message- > From: Chri

RE: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Deucher, Alexander
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Monday, October 8, 2018 1:41 PM > To: Deucher, Alexander > Cc: Koenig, Christian ; Peng Hao > ; airl...@linux.ie; linux-ker...@vger.kernel.org; > dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org >

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 03:57:07PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Guenter Roeck On Behalf Of Guenter Roeck > > Sent: Monday, October 8, 2018 10:11 AM > > To: Koenig, Christian ; Peng Hao > > > > Cc: airl...@linux.ie; linux-ker...@vger.kernel.org; dri- >

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: > Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: > One thing I found missing in the discussion was the reference to the > C standard. > The C99 standard states in section 6.7.8 (Initialization) clause 19: > "

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/08/2018 01:00 AM, Christian König wrote: Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:    

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/08/2018 06:47 AM, Koenig, Christian wrote: Am 08.10.2018 um 15:33 schrieb Guenter Roeck: On 10/08/2018 01:00 AM, Christian König wrote: Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On F

[PATCH][drm-next] drm/amdgpu/powerplay: fix missing break in switch statements

2018-10-08 Thread Colin King
From: Colin Ian King There are several switch statements that are missing break statements. Add missing breaks to handle any fall-throughs corner cases. Detected by CoverityScan, CID#1457175 ("Missing break in switch") Fixes: 18aafc59b106 ("drm/amd/powerplay: implement fw related smu interface

Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Christian König
Am 08.10.2018 um 20:15 schrieb Zhu, Rex: -Original Message- From: Koenig, Christian Sent: Tuesday, October 9, 2018 2:03 AM To: Zhu, Rex ; Deucher, Alexander ; Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend Am 08.10.2018 um 19

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Zhu, Rex
> -Original Message- > From: Koenig, Christian > Sent: Tuesday, October 9, 2018 2:03 AM > To: Zhu, Rex ; Deucher, Alexander > ; Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > Am 08.10.2018 um 19:58 schrieb Zhu, Rex: >

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 19:46 schrieb Guenter Roeck: > On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: >> Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: >> One thing I found missing in the discussion was the reference to the >> C standard. >> The C99 standard states in s

Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 19:58 schrieb Zhu, Rex: > >> -Original Message- >> From: Christian König >> Sent: Tuesday, October 9, 2018 1:32 AM >> To: Zhu, Rex ; Deucher, Alexander >> ; Alex Deucher >> Cc: amd-gfx list >> Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when >> suspend

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Zhu, Rex
> -Original Message- > From: Christian König > Sent: Tuesday, October 9, 2018 1:32 AM > To: Zhu, Rex ; Deucher, Alexander > ; Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > Am 08.10.2018 um 18:30 schrieb Zhu, Rex: >

Re: [PATCH 3/6] drm: add support of syncobj timeline point wait v2

2018-10-08 Thread Jason Ekstrand
On Mon, Oct 8, 2018 at 12:53 AM Zhou, David(ChunMing) wrote: > >> Another general comment (no good place to put it) is that I think we > want two kinds of waits: Wait for time point to be completed and wait for > time point to become available. The first is the usual CPU wait for > completion w

Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Christian König
Am 08.10.2018 um 18:30 schrieb Zhu, Rex: -Original Message- From: Deucher, Alexander Sent: Tuesday, October 9, 2018 12:21 AM To: Zhu, Rex ; Alex Deucher Cc: amd-gfx list Subject: RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend -Original Message- From: amd-

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: One thing I found missing in the discussion was the reference to the C standard. The C99 standard states in section 6.7.8 (Initialization) clause 19: "... all subobjects that are not initialized explicitly shall be initiali

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mauro Rossi
Hi Sylvain, On Mon, Oct 8, 2018 at 2:04 PM wrote: > > I am currently testing your patch set, on amd-staging-drm-next > (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a > displayport monitor. > patch02 drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c did not apply

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Zhu, Rex
> -Original Message- > From: Deucher, Alexander > Sent: Tuesday, October 9, 2018 12:21 AM > To: Zhu, Rex ; Alex Deucher > Cc: amd-gfx list > Subject: RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > > -Original Message- > > From: amd-gfx On Behalf Of >

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of Zhu, > Rex > Sent: Monday, October 8, 2018 11:57 AM > To: Alex Deucher > Cc: amd-gfx list > Subject: RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > > > > -Original Message- > > From: Alex Deucher > >

RE: [PATCH 4/5] drm/amdgpu: Add fw load in gfx_v8 and sdma_v3

2018-10-08 Thread Zhu, Rex
Thanks. I will fix this error in a following patch. Best Regards Rex > -Original Message- > From: Alex Deucher > Sent: Thursday, October 4, 2018 11:33 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 4/5] drm/amdgpu: Add fw load in gfx_v8 and sdma_v3 > > On Wed, Oct 3, 2018

RE: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Deucher, Alexander
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Monday, October 8, 2018 10:11 AM > To: Koenig, Christian ; Peng Hao > > Cc: airl...@linux.ie; linux-ker...@vger.kernel.org; dri- > de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Deucher, > Alexander

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

2018-10-08 Thread Zhu, Rex
> -Original Message- > From: Alex Deucher > Sent: Thursday, October 4, 2018 11:35 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > On Wed, Oct 3, 2018 at 7:11 AM Rex Zhu wrote: > > > > driver don't release the uc

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Deucher, Alexander
It's trivial to add the metadata/version headers to the existing firmware, so that is not an issue. The issue is with the firmware itself. If we used the existing firmware, we'd have to add a bunch of really ugly hacks in the driver to work around the current limitations. Alex

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 15:33 schrieb Guenter Roeck: > On 10/08/2018 01:00 AM, Christian König wrote: >> Am 05.10.2018 um 10:38 schrieb Guenter Roeck: >>> On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: > Hi, > > On Fri, Sep 14, 2018 at 06:05

[PATCH 8/8] drm/amdgpu: use paging queue for VM page table updates

2018-10-08 Thread Christian König
Only for testing, not sure if we should keep it like this. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index a362904d

[PATCH 1/8] drm/amdgpu: fix incorrect use of amdgpu_irq_add_id in si_dma.c

2018-10-08 Thread Christian König
Adding a second irq source because of a different src_id is actually a bug. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 4 drivers/gpu/drm/amd/amdgpu/si_dma.c | 27 --- 2 files changed, 8 insertions(+), 23 deletions(-) diff --

[PATCH 4/8] drm/amdgpu: remove non gfx specific handling from sdma_v4_0_gfx_resume

2018-10-08 Thread Christian König
Needed to start using the paging queue. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 36 +++--- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_

[PATCH 5/8] drm/amdgpu: remove SRIOV specific handling from sdma_v4_0_gfx_resume

2018-10-08 Thread Christian König
Just use the same code path for both SRIOV and bare metal. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 1

[PATCH 3/8] drm/amdgpu: add basics for SDMA page queue support

2018-10-08 Thread Christian König
Just the common helper and a new ring in the SDMA instance. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 10 -- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-08 Thread Christian König
Under SRIOV we were enabling the ring buffer before it was initialized. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 234 - 1 file changed, 116 insertions(+), 118 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/d

[PATCH 7/8] drm/amdgpu: activate paging queue on SDMA v4

2018-10-08 Thread Christian König
Implement all the necessary stuff to get those extra rings working. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 324 - 1 file changed, 274 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/driver

[PATCH 6/8] drm/amdgpu: add some [WR]REG32_SDMA macros to sdma_v4_0.c

2018-10-08 Thread Christian König
Significantly shortens the code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 126 - 1 file changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c ind

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 12:04:23PM +, sylvain.bertr...@gmail.com wrote: > I am currently testing your patch set, on amd-staging-drm-next > (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a > displayport monitor. Forgot a very important thing: I run it with the linux t

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
I thought it just required the existing firmware, with padding / extra info put around it? On Mon, 8 Oct 2018 at 12:29 Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > UVD/VCE on SI with amdgpu would need new firmware. > > And so far we never had time to actually look into releasing t

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
I am currently testing your patch set, on amd-staging-drm-next (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a displayport monitor. patch02 drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c did not apply but seems kind of benign. It's working out of the box on my AM

Re: [PATCH] drm/amdgpu: fix AGP location with VRAM at 0x0

2018-10-08 Thread Christian König
Ping, can anybody review this? Am 04.10.2018 um 11:02 schrieb Christian König: That also simplifies handling quite a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Christian König
UVD/VCE on SI with amdgpu would need new firmware. And so far we never had time to actually look into releasing that firmware. Regards, Christian. Am 08.10.2018 um 13:22 schrieb Mauro Rossi: Hi Mike, On Mon, Oct 8, 2018 at 1:00 PM Mike Lothian > wrote: Hi Maur

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mauro Rossi
Hi Mike, On Mon, Oct 8, 2018 at 1:00 PM Mike Lothian wrote: > Hi Mauro > > Do you know if there are any plans to add in UVD support on SI too? > > Thanks > > Mike > At the moment my focus is on getting a conformant, working and stable implementation of Atomic Display Framework, with the objectiv

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
Hi Mauro Do you know if there are any plans to add in UVD support on SI too? Thanks Mike On Mon, 8 Oct 2018 at 03:24 Mauro Rossi wrote: > [PATCH 01/10] drm/amd/display: add asics info for SI parts > [PATCH 02/10] drm/amd/display: dc/dce: add DCE6 support > [PATCH 03/10] drm/amd/display: dc/co

Re: [PATCH v2 2/3] drm: Add variable refresh property to DRM CRTC

2018-10-08 Thread Michel Dänzer
On 2018-10-05 7:48 p.m., Kazlauskas, Nicholas wrote: > On 10/05/2018 12:56 PM, Michel Dänzer wrote: >> On 2018-10-05 6:21 p.m., Kazlauskas, Nicholas wrote: >>> On 10/05/2018 04:10 AM, Pekka Paalanen wrote: I also believe that it would be useful to expose vmin/vmax to userspace as pro

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Christian König
Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:   In function ‘gmc_v8_0_process_interrupt’: dri

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-10-08 Thread Bjorn Andersson
On Wed 12 Sep 08:08 PDT 2018, Arnd Bergmann wrote: [..] > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index a76b963a7e50..02aefb2b2d47 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -285,7 +285,7 @@ static const struct file_operations r

Fwd: amd-gpu ac adaptor bug

2018-10-08 Thread UTKU HELVACI
kernels newer than 4.16 has this "amd-gpu ac adapter" bug, which makes the computer useless if ac adapter is plugged in , 4.19 and newer doesn't boot or as i tested 4.19-rc4 boots but makes computer unusable I have filled a bug report in bugzilla here: https://bugzilla.kernel.org/show_bug.cgi?

Re: [PATCH] drm/radeon: ratelimit bo warnings

2018-10-08 Thread Nick Alcock
On 5 Oct 2018, Michel Dänzer told this: > On 2018-10-04 9:58 p.m., Nick Alcock wrote: >> So a few days ago I started getting sprays of these warnings -- >> sorry, but because it was a few days ago I'm not sure what I was >> running at the time (but it was probably either Stellaris or Chromium). >>

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function ‘gmc_v8_0_process_interrupt’: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10: